]> Pileus Git - ~andy/linux/commit
sfc: Fix null function pointer in efx_sriov_channel_type
authorBen Hutchings <bhutchings@solarflare.com>
Tue, 2 Oct 2012 00:43:45 +0000 (01:43 +0100)
committerBen Hutchings <bhutchings@solarflare.com>
Tue, 2 Oct 2012 00:57:25 +0000 (01:57 +0100)
commit726ba0e14a7915effee9e8e652a37306d9637d13
tree53765b1e20c178fcf762c9263746752121ec2405
parentabb17e6c0c7b27693201dc85f75dbb184279fd10
sfc: Fix null function pointer in efx_sriov_channel_type

Commit c31e5f9 ('sfc: Add channel specific receive_skb handler and
post_remove callback') added the function pointer field
efx_channel_type::post_remove and an unconditional call through it.

This field should have been initialised to efx_channel_dummy_op_void
in the existing instances of efx_channel_type, but this was only done
in efx_default_channel_type.  Consequently, if a device has SR-IOV
enabled then removing the driver or device will result in an oops.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
drivers/net/ethernet/sfc/siena_sriov.c