]> Pileus Git - ~andy/linux/commit
i2c-smbus: Convert kzalloc to devm_kzalloc
authorJulia Lawall <Julia.Lawall@lip6.fr>
Fri, 5 Oct 2012 20:23:52 +0000 (22:23 +0200)
committerJean Delvare <khali@endymion.delvare>
Fri, 5 Oct 2012 20:23:52 +0000 (22:23 +0200)
commit71b578452ec6b2e8a470e3dae89055cd1068a9f0
tree75632bf1c1e91a28bc76cc72c96e5a007a1e4305
parenteee543e8248150e8fb833943c71f40c7b1724600
i2c-smbus: Convert kzalloc to devm_kzalloc

Converting kzalloc to devm_kzalloc simplifies the code and ensures that the
result, alert, is freed after the irq allocated by the subsequent
devm_request_irq.  This in turn ensures that when an interrupt can be
triggered, the alert structure is still available.

The problem of a free after a devm_request_irq was found using the
following semantic match (http://coccinelle.lip6.fr/)

// <smpl>
@r exists@
expression e1,e2,x,a,b,c,d;
identifier free;
position p1,p2;
@@

  devm_request_irq@p1(e1,e2,...,x)
  ... when any
      when != e2 = a
      when != x = b
  if (...) {
    ... when != e2 = c
        when != x = d
    free@p2(...,x,...);
    ...
    return ...;
  }
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
drivers/i2c/i2c-smbus.c