]> Pileus Git - ~andy/linux/commit
stop_machine: Fix race between stop_two_cpus() and stop_cpus()
authorRik van Riel <riel@redhat.com>
Fri, 1 Nov 2013 14:41:46 +0000 (10:41 -0400)
committerIngo Molnar <mingo@kernel.org>
Mon, 11 Nov 2013 11:43:38 +0000 (12:43 +0100)
commit7053ea1a34fa8567cb5e3c39e04ace4c5d0fbeaa
treeed5866f5a2449e6d7b918ce92858f891c8bc1450
parent37dc6b50cee97954c4e6edcd5b1fa614b76038ee
stop_machine: Fix race between stop_two_cpus() and stop_cpus()

There is a race between stop_two_cpus, and the global stop_cpus.

It is possible for two CPUs to get their stopper functions queued
"backwards" from one another, resulting in the stopper threads
getting stuck, and the system hanging. This can happen because
queuing up stoppers is not synchronized.

This patch adds synchronization between stop_cpus (a rare operation),
and stop_two_cpus.

Reported-and-Tested-by: Prarit Bhargava <prarit@redhat.com>
Signed-off-by: Rik van Riel <riel@redhat.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Acked-by: Mel Gorman <mgorman@suse.de>
Link: http://lkml.kernel.org/r/20131101104146.03d1e043@annuminas.surriel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/stop_machine.c