]> Pileus Git - ~andy/linux/commit
sctp: add Adaptation Layer Indication parameter only when it's set
authormalc <mlashley@gmail.com>
Thu, 12 Mar 2009 09:49:20 +0000 (09:49 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 13 Mar 2009 18:37:58 +0000 (11:37 -0700)
commit6fc791ee631728b2beddda87560f1af59e32230e
treec6fa5596160e0a3c5d03d822de165a800d3dbe35
parent76595024ffab3599bd28ea014f6c23c1a8c8dd2c
sctp: add Adaptation Layer Indication parameter only when it's set

RFC5061 states:

        Each adaptation layer that is defined that wishes
        to use this parameter MUST specify an adaptation code point in an
        appropriate RFC defining its use and meaning.

If the user has not set one - assume they don't want to sent the param
with a zero Adaptation Code Point.

Rationale - Currently the IANA defines zero as reserved - and
1 as the only valid value - so we consider zero to be unset - to save
adding a boolean to the socket structure.

Including this parameter unconditionally causes endpoints that do not
understand it to report errors unnecessarily.

Signed-off-by: Malcolm Lashley <mlashley@gmail.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/sm_make_chunk.c