]> Pileus Git - ~andy/linux/commit
ARM: hw_breakpoint: fix ordering of debug register reset sequence
authorWill Deacon <will.deacon@arm.com>
Fri, 21 Sep 2012 14:38:26 +0000 (15:38 +0100)
committerWill Deacon <will.deacon@arm.com>
Fri, 9 Nov 2012 11:47:06 +0000 (11:47 +0000)
commit614bea500a88be2a841af0967469961470f2be83
tree311a18ddb38cacf63195a002868b08770d97c38f
parentb59a540ca927ea84bb0590b9d8076f50c969abb4
ARM: hw_breakpoint: fix ordering of debug register reset sequence

The debug register reset sequence for v7 and v7.1 is congruent with
tap-dancing through a minefield.

Rather than wait until we've blown ourselves to pieces, this patch
instead checks the debug_err_mask after each potentially faulting
operation. We also move the enabling of monitor_mode to the end of the
sequence in order to prevent spurious debug events generated by UNKNOWN
register values.

Reported-by: Stephen Boyd <sboyd@codeaurora.org>
Tested-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm/kernel/hw_breakpoint.c