]> Pileus Git - ~andy/linux/commit
fs/ceph: introduce missing kfree
authorJulia Lawall <julia@diku.dk>
Sat, 21 Nov 2009 11:53:08 +0000 (12:53 +0100)
committerSage Weil <sage@newdream.net>
Sat, 21 Nov 2009 21:05:14 +0000 (13:05 -0800)
commit60d877334f7d9f5f2417ea4a83c1def769286102
treebf8faa8fd396ac883de21436408a652eed56f9dd
parentb19a29af74c09553b9fef95cdf6e9af3df65f544
fs/ceph: introduce missing kfree

Error handling code following a kmalloc should free the allocated data.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@r exists@
local idexpression x;
statement S;
expression E;
identifier f,f1,l;
position p1,p2;
expression *ptr != NULL;
@@

x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(...);
...
if (x == NULL) S
<... when != x
     when != if (...) { <+...x...+> }
(
x->f1 = E
|
 (x->f1 == NULL || ...)
|
 f(...,x->f1,...)
)
...>
(
 return \(0\|<+...x...+>\|ptr\);
|
 return@p2 ...;
)

@script:python@
p1 << r.p1;
p2 << r.p2;
@@

print "* file: %s kmalloc %s return %s" % (p1[0].file,p1[0].line,p2[0].line)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Sage Weil <sage@newdream.net>
fs/ceph/xattr.c