]> Pileus Git - ~andy/linux/commit
usb-serial: ftdi_sio: fix oops during autosuspend
authorAlan Stern <stern@rowland.harvard.edu>
Mon, 7 May 2012 15:20:06 +0000 (11:20 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 7 May 2012 19:59:02 +0000 (12:59 -0700)
commit5cbe61c5aff0a8ada691eb8b07dbfb55c303f640
tree7cacf1d68cbc681faa658d0fb15e035186c79908
parent23063b378de734383c9f42de770b01cd661cd9b4
usb-serial: ftdi_sio: fix oops during autosuspend

This patch (as1550) fixes a bug in the usb-serial core that affects
the ftdi_sio driver and most likely others as well.  The core
implements suspend and resume routines, but it doesn't store pointers
to those routines in the usb_driver structures that it registers,
even though it does set those drivers' supports_autosuspend flag.  The
end result is that when one of these devices is autosuspended, we try
to call through a NULL pointer.

The patch fixes the problem by setting the suspend and resume method
pointers to the appropriate routines in the USB serial core, along
with the supports_autosuspend field, in each driver as it is
registered.

This should be back-ported to all the stable kernels that have the new
usb_serial_register_drivers() interface.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Reported-and-tested-by: Frank Schäfer <schaefer.frank@gmx.net>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/serial/usb-serial.c