]> Pileus Git - ~andy/linux/commit
gianfar: Fix portabilty issues for ethtool and ptp
authorClaudiu Manoil <claudiu.manoil@freescale.com>
Tue, 14 Jan 2014 13:35:00 +0000 (15:35 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 15 Jan 2014 22:39:25 +0000 (14:39 -0800)
commit42851e88a7556e525a5527d46c3763830d8fdd2e
tree6d09d0819f21d87053b4b19b41a683d4f5e3b1f6
parent9895c503ef5b32c1ff4c4c224d6e8db2935dc3c0
gianfar: Fix portabilty issues for ethtool and ptp

Fixes unhandled register write in gianfar_ethtool.c.
Fixes following endianess related functional issues,
reported by sparse as well, i.e.:

gianfar_ethtool.c:1058:33: warning:
    incorrect type in argument 1 (different base types)
    expected unsigned int [unsigned] [usertype] value
    got restricted __be32 [usertype] ip4src

gianfar_ethtool.c:1164:33: warning:
    restricted __be16 degrades to integer

gianfar_ethtool.c:1669:32: warning:
    invalid assignment: ^=
    left side has type restricted __be16
    right side has type int

Solves all the sparse warnings for mixig normal pointers
with __iomem pointers for gianfar_ptp.c, i.e.:
gianfar_ptp.c:163:32: warning:
    incorrect type in argument 1 (different address spaces)
    expected unsigned int [noderef] <asn:2>*addr
    got unsigned int *<noident>

Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/gianfar_ethtool.c
drivers/net/ethernet/freescale/gianfar_ptp.c