]> Pileus Git - ~andy/linux/commit
drm/i915/intel_i2c: refactor using intel_gmbus_get_adapter
authorDaniel Kurtz <djkurtz@chromium.org>
Tue, 27 Mar 2012 18:36:14 +0000 (02:36 +0800)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 28 Mar 2012 12:40:44 +0000 (14:40 +0200)
commit3bd7d90938f1fe77de5991dc4b727843c4980b2a
treea3ae0f53674b8a95b8e2c52959e32b4cc7a43d09
parent489fbc107f5fb041d598f30f367ea3ca714ff133
drm/i915/intel_i2c: refactor using intel_gmbus_get_adapter

Instead of letting other modules directly access the ->gmbus array,
introduce intel_gmbus_get_adapter() for looking up an i2c_adapter
for a given gmbus port identifier.  This will enable later refactoring
of the gmbus port list.

Note: Before requesting an adapter for a given gmbus port number, the
driver must first check its validity using i2c_intel_gmbus_is_port_valid().
If this check fails, a call to intel_gmbus_get_adapter() will WARN_ON and
return NULL.  This is relevant for parts of the driver that read a port
from VBIOS, which might be improperly initialized and contain an invalid
port.  In these cases, the driver must fall back to using a safer default
port.

Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_drv.h
drivers/gpu/drm/i915/intel_bios.c
drivers/gpu/drm/i915/intel_crt.c
drivers/gpu/drm/i915/intel_dvo.c
drivers/gpu/drm/i915/intel_hdmi.c
drivers/gpu/drm/i915/intel_i2c.c
drivers/gpu/drm/i915/intel_lvds.c
drivers/gpu/drm/i915/intel_modes.c
drivers/gpu/drm/i915/intel_sdvo.c