]> Pileus Git - ~andy/linux/commit
tty: nwpserial: Pass correct pointer to free_irq()
authorLars-Peter Clausen <lars@metafoo.de>
Mon, 20 May 2013 17:07:30 +0000 (19:07 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 20 May 2013 18:54:55 +0000 (11:54 -0700)
commit383d2fc96c1983f5cd7fca3a3b1c9b8d8ee0de66
treedfd04cf37ddfbe94bd3edb0887e4dd9167d9f844
parentdbd2df859a4d992ccbceeb22c37f6a6c4aa4dc01
tty: nwpserial: Pass correct pointer to free_irq()

free_irq() expects the same pointer that was passed to request_irq(), otherwise
the IRQ is not freed.

The issue was found using the following coccinelle script:

<smpl>
@r1@
type T;
T devid;
@@
request_irq(..., devid)

@r2@
type r1.T;
T devid;
position p;
@@
free_irq@p(..., devid)

@@
position p != r2.p;
@@
*free_irq@p(...)
</smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/nwpserial.c