]> Pileus Git - ~andy/linux/commit
cpupower: Fix segfault due to incorrect getopt_long arugments
authorJosh Boyer <jwboyer@redhat.com>
Fri, 11 Oct 2013 12:45:51 +0000 (08:45 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jan 2014 20:24:22 +0000 (12:24 -0800)
commit37b1780623b001b57c92bc8c81c570a88f6f30d4
tree76d4f61de6e2500c129aff9da902a9286bce191b
parent96350a7067c73a288af679f3420431cabe9453bc
cpupower: Fix segfault due to incorrect getopt_long arugments

commit f447ef4a56dee4b68a91460bcdfe06b5011085f2 upstream.

If a user calls 'cpupower set --perf-bias 15', the process will end with
a SIGSEGV in libc because cpupower-set passes a NULL optarg to the atoi
call.  This is because the getopt_long structure currently has all of
the options as having an optional_argument when they really have a
required argument.  We change the structure to use required_argument to
match the short options and it resolves the issue.

This fixes https://bugzilla.redhat.com/show_bug.cgi?id=1000439

Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
Cc: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Thomas Renninger <trenn@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/power/cpupower/utils/cpupower-set.c