]> Pileus Git - ~andy/linux/commit
gianfar: fix potential sk_wmem_alloc imbalance
authorEric Dumazet <edumazet@google.com>
Thu, 5 Jul 2012 11:45:13 +0000 (11:45 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 9 Jul 2012 22:28:03 +0000 (15:28 -0700)
commit313b037cf054ec908de92fb4c085403ffd7420d4
tree7b7839d50a7d069bc825f58d8f8ad5f2e9a1ad0e
parent022f09784b85396b4ceba954ce28e50de4882281
gianfar: fix potential sk_wmem_alloc imbalance

commit db83d136d7f753 (gianfar: Fix missing sock reference when
processing TX time stamps) added a potential sk_wmem_alloc imbalance

If the new skb has a different truesize than old one, we can get a
negative sk_wmem_alloc once new skb is orphaned at TX completion.

Now we no longer early orphan skbs in dev_hard_start_xmit(), this
probably can lead to fatal bugs.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Tested-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Manfred Rudigier <manfred.rudigier@omicron.at>
Cc: Claudiu Manoil <claudiu.manoil@freescale.com>
Cc: Jiajun Wu <b06378@freescale.com>
Cc: Andy Fleming <afleming@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/gianfar.c