]> Pileus Git - ~andy/linux/commit
[XFS] don't block in xfs_qm_dqflush() during async writeback.
authorDavid Chinner <david@fromorbit.com>
Thu, 30 Oct 2008 06:07:20 +0000 (17:07 +1100)
committerLachlan McIlroy <lachlan@sgi.com>
Thu, 30 Oct 2008 06:07:20 +0000 (17:07 +1100)
commit2f8a3ce1c20f20e6494cdb77fed76bc474ca3ca5
tree01322bcb3c1d3bb9f8fd6e170414e5c748b6f77c
parent75c68f411b1242c8fdaf731078fdd4e77b14981d
[XFS] don't block in xfs_qm_dqflush() during async writeback.

Normally dquots are written back via delayed write mechanisms. They are
flushed to their backing buffer by xfssyncd, which is then pushed out by
either AIL or xfsbufd flushing. The flush from the xfssyncd is supposed to
be non-blocking, but xfs_qm_dqflush() always waits for pinned duots, which
means that it will block for the length of time it takes to do a
synchronous log force. This causes unnecessary extra log I/O to be issued
whenever we try to flush a busy dquot.

Avoid the log forces and blocking xfssyncd by making xfs_qm_dqflush() pay
attention to what type of sync it is doing when it sees a pinned dquot and
not waiting when doing non-blocking flushes.

SGI-PV: 988147

SGI-Modid: xfs-linux-melb:xfs-kern:32287a

Signed-off-by: David Chinner <david@fromorbit.com>
Signed-off-by: Peter Leckie <pleckie@sgi.com>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
fs/xfs/quota/xfs_dquot.c