]> Pileus Git - ~andy/linux/commit
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c: add missing iounmap
authorJulia Lawall <Julia.Lawall@lip6.fr>
Wed, 11 Jan 2012 23:55:10 +0000 (23:55 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 13 Jan 2012 04:05:28 +0000 (20:05 -0800)
commit25cecd7e355bf90b8fea039bd06947bb3234e77d
tree287848d194e82ba41fb71d5e4c1ac340a80b6d05
parent20d4369b6892159895d6136946e692eaf29e8413
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c: add missing iounmap

Add missing iounmap in error handling code, in a case where the function
already preforms iounmap on some other execution path.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e;
statement S,S1;
int ret;
@@
e = \(ioremap\|ioremap_nocache\)(...)
... when != iounmap(e)
if (<+...e...+>) S
... when any
    when != iounmap(e)
*if (...)
   { ... when != iounmap(e)
     return ...; }
... when any
iounmap(e);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c