]> Pileus Git - ~andy/linux/commit
drm/i915: Fix PSR programming
authorBen Widawsky <benjamin.widawsky@intel.com>
Wed, 5 Mar 2014 06:38:10 +0000 (22:38 -0800)
committerJani Nikula <jani.nikula@intel.com>
Thu, 6 Mar 2014 12:00:37 +0000 (14:00 +0200)
commit24bd9bf54d45d28089251cdf62bf14323d1aa827
treea6bd5e882c8a8a83c26ee3866a3e3d0049982097
parent6375b768a9850b6154478993e5fb566fa4614a9c
drm/i915: Fix PSR programming

| has a higher precedence than ?. Therefore, the calculation doesn't do
at all what you would expect. Thanks to Ken for convincing me that this
was indeed the issue. Send me back to C programmer school, please.

I'm sort of surprised PSR was continuing to work for people. It should
be broken IMO (and it was broken for me, but I had assumed it never
worked).

Regression from:
commit ed8546ac1f99b850879f07b1e9b06b42fb0a36d9
Author: Ben Widawsky <benjamin.widawsky@intel.com>
Date:   Mon Nov 4 22:45:05 2013 -0800

    drm/i915/bdw: Support eDP PSR

Cc: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: Kenneth Graunke <kenneth.w.graunke@intel.com>
Cc: Art Runyan <arthur.j.runyan@intel.com>
Reported-by: "Kumar, Kiran S" <kiran.s.kumar@intel.com>
Cc: stable@vger.kernel.org [v3.13+]
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/intel_dp.c