]> Pileus Git - ~andy/linux/commit
[SCSI] libiscsi: avoid unnecessary multiple NULL assignments
authorMasatake YAMATO <yamato@redhat.com>
Wed, 10 Apr 2013 16:24:38 +0000 (11:24 -0500)
committerJames Bottomley <JBottomley@Parallels.com>
Thu, 11 Apr 2013 23:54:01 +0000 (16:54 -0700)
commit1fc2b00fba55f70ab32ecc493efbca9a1a76a4e3
tree77eb0dc3b8407b8536deead9eddef3cccbedc945
parent5f28897d2827a924b746c4d85e35cf85810b8951
[SCSI] libiscsi: avoid unnecessary multiple NULL assignments

In iscsi_free_task, NULL is assigned to task->sc twice: before and
after kfifo_in invocatoin. Allocating and freeing iscsi_task are guarded
with session->lock, so multiple NULL assignments cause no trouble. But
people reading the source code may be confused.

The second NULL assignment comes from commit:

    3e5c28ad0391389959ccae81c938c7533efb3490

It seems that the line after kfifo_in invocation was introduced
accidentally.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
drivers/scsi/libiscsi.c