]> Pileus Git - ~andy/linux/commit
gianfar: Fix alloc_skb_resources on -ENOMEM cleanup path
authorClaudiu Manoil <claudiu.manoil@freescale.com>
Thu, 8 Nov 2012 22:11:41 +0000 (22:11 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 9 Nov 2012 22:07:22 +0000 (17:07 -0500)
commit1eb8f7a7da6d3b36fcc339d7bbddbf8315a5c1dd
tree08367aa6aa5fa54af7a9d82d21a98195f050880e
parentbe44389964c1855ccffedbfbf5d2a943bb84ad66
gianfar: Fix alloc_skb_resources on -ENOMEM cleanup path

Should gfar_init_bds() return with -ENOMEM inside gfar_alloc_skb_resources(),
free_skb_resources() will be called twice in a row on the "cleanup" path,
leading to duplicate kfree() calls for rx_|tx_queue->rx_|tx_skbuff resulting
in segmentation fault.
This patch prevents the segmentation fault to happen in the future
(rx_|tx_sbkbuff set to NULL), and corrects the error path handling
for gfar_init_bds().

Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com>
Acked-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/freescale/gianfar.c