]> Pileus Git - ~andy/linux/commit
iio: frequency: adf4350: using an uninitialized variable
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 8 Jun 2012 06:54:32 +0000 (09:54 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 12 Jun 2012 21:48:39 +0000 (14:48 -0700)
commit1a135d1ab5e3122ab2a50cbbdb9cb1504c1f421f
tree50de49246b892dd7152e434b7603f1fb3489ff7c
parente86ee142a223ec85efda7c66b3e99fe79aa8cc4f
iio: frequency: adf4350: using an uninitialized variable

GCC complains that we use an uninitialized variable if the user passes
an invalid parameter to adf4350_read().  I decided that we should return
-EINVAL instead in that case.

However, when I looked up at adf4350_write() it returned -ENODEV for
that condition.  In the end, I decided the -EINVAL was the right thing
and I change adf4350_write() to match.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/frequency/adf4350.c