]> Pileus Git - ~andy/linux/commit
MODSIGN: Don't use enum-type bitfields in module signature info block
authorDavid Howells <dhowells@redhat.com>
Mon, 22 Oct 2012 14:05:48 +0000 (15:05 +0100)
committerRusty Russell <rusty@rustcorp.com.au>
Wed, 5 Dec 2012 00:57:24 +0000 (11:27 +1030)
commit12e130b04580532aa099893158aa2776b321ae7f
treeb7a6ed562d7293aa1e5b584e109a9669db253f49
parentdf2fc246c8ee8b6067af1fa55d3bc23107457f61
MODSIGN: Don't use enum-type bitfields in module signature info block

Don't use enum-type bitfields in the module signature info block as we can't be
certain how the compiler will handle them.  As I understand it, it is arch
dependent, and it is possible for the compiler to rearrange them based on
endianness and to insert a byte of padding to pad the three enums out to four
bytes.

Instead use u8 fields for these, which the compiler should emit in the right
order without padding.

Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
kernel/module_signing.c