]> Pileus Git - ~andy/linux/commit
USB: Remove large struct from the stack in USB storage isd200 driver
authorIan Munsie <imunsie@au.ibm.com>
Wed, 3 Mar 2010 00:00:37 +0000 (11:00 +1100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 20 May 2010 20:21:31 +0000 (13:21 -0700)
commit0df4d8ef77f7e1251763d429f5ddbf5373961714
tree5f99a500f7708f2675013c728e0e9998a7b941e4
parentfa4dc36482a5236c92c589cdbc0a42ff5c945b6b
USB: Remove large struct from the stack in USB storage isd200 driver

The compiler throws the following warning when compiling for a PowerPC 64
bit machine:

drivers/usb/storage/isd200.c:580: warning: the frame size of 2208 bytes is larger than 2048 bytes

There is a struct scsi_device which is placed on the stack and is
largely responsible for such wastage. The struct is just a dummy struct
filled with NULLs and set as the scsi_cmnd->device to make the
usb_stor_Bulk_transport function happy.

This patch makes the struct static, so that it is never placed onto the
stack and silences the compiler warning.

Signed-off-by: Ian Munsie <imunsie@au.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/storage/isd200.c