]> Pileus Git - ~andy/linux/commit
[media] v4l2-subdev: fix broken subdev control enumeration
authorHans Verkuil <hverkuil@xs4all.nl>
Mon, 2 May 2011 11:09:25 +0000 (08:09 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 4 May 2011 19:42:55 +0000 (16:42 -0300)
commit0b84834a5a9f5fe8f3760560ef8c5b1536d22bd1
treee52094f733316990d2a01196563339a1046c9402
parent2a164d02dd34c6b49a3f0995900e0f8af102b804
[media] v4l2-subdev: fix broken subdev control enumeration

The v4l2_subdev_* functions are meant for older V4L2 drivers that do not use
the control framework yet. These functions should not be used by subdev_do_ioctl.

Most of those backwards compatibility functions are just stubs, but commit
87a0c94ce616b231f3c0bd09d7dbd39d43b0557a actually changed the behavior of
v4l2_subdev_queryctrl, so calling that one from subdev_do_ioctl broke the
control enumeration in subdev nodes.

The fix is simply not to use those compatibility functions in v4l2-subdev.c.

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/v4l2-subdev.c