]> Pileus Git - ~andy/linux/commit
ixp4xx_hss: fix build failure due to missing linux/module.h inclusion
authorFlorian Fainelli <florian@openwrt.org>
Mon, 10 Sep 2012 12:06:58 +0000 (14:06 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 10 Sep 2012 20:15:05 +0000 (16:15 -0400)
commit0b836ddde177bdd5790ade83772860940bd481ea
tree88a43d3eb0187c92b1dc44d4fe58197507b001b1
parent566f26aa705609d05940289036ab914c8a3be707
ixp4xx_hss: fix build failure due to missing linux/module.h inclusion

Commit 36a1211970193ce215de50ed1e4e1272bc814df1 (netprio_cgroup.h:
dont include module.h from other includes) made the following build
error on ixp4xx_hss pop up:

  CC [M]  drivers/net/wan/ixp4xx_hss.o
 drivers/net/wan/ixp4xx_hss.c:1412:20: error: expected ';', ',' or ')'
 before string constant
 drivers/net/wan/ixp4xx_hss.c:1413:25: error: expected ';', ',' or ')'
 before string constant
 drivers/net/wan/ixp4xx_hss.c:1414:21: error: expected ';', ',' or ')'
 before string constant
 drivers/net/wan/ixp4xx_hss.c:1415:19: error: expected ';', ',' or ')'
 before string constant
 make[8]: *** [drivers/net/wan/ixp4xx_hss.o] Error 1

This was previously hidden because ixp4xx_hss includes linux/hdlc.h which
includes linux/netdevice.h which includes linux/netprio_cgroup.h which
used to include linux/module.h. The real issue was actually present since
the initial commit that added this driver since it uses macros from
linux/module.h without including this file.

Signed-off-by: Florian Fainelli <florian@openwrt.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/ixp4xx_hss.c