]> Pileus Git - ~andy/linux/commit
xfs: prevent recursion in xfs_buf_iorequest
authorChristoph Hellwig <hch@infradead.org>
Mon, 2 Jul 2012 10:00:04 +0000 (06:00 -0400)
committerBen Myers <bpm@sgi.com>
Fri, 13 Jul 2012 17:50:42 +0000 (12:50 -0500)
commit08023d6dbe840dc4271805a9ea376fcbdee9f744
tree32349d435ec6ff60aed1aea7e17f10fd27242b2b
parenteb71a12e411fe065f8663e12a8d81d561f9502ee
xfs: prevent recursion in xfs_buf_iorequest

If the b_iodone handler is run in calling context in xfs_buf_iorequest we
can run into a recursion where xfs_buf_iodone_callbacks keeps calling back
into xfs_buf_iorequest because an I/O error happened, which keeps calling
back into xfs_buf_iorequest.  This chain will usually not take long
because the filesystem gets shut down because of log I/O errors, but even
over a short time it can cause stack overflows if run on the same context.

As a short term workaround make sure we always call the iodone handler in
workqueue context.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
fs/xfs/xfs_buf.c