]> Pileus Git - ~andy/linux/commit
arm: Remove bogus comment in futex_atomic_cmpxchg_inatomic()
authorThomas Gleixner <tglx@linutronix.de>
Mon, 14 Mar 2011 19:00:30 +0000 (20:00 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 14 Mar 2011 20:10:26 +0000 (21:10 +0100)
commit07d5ecae2940ddd77746e2fb597dcf57d3c2e277
tree2755106df53db441230d1e5356a65bde0274f20c
parent6e0aa9f8a8190e0879a29bd67aa606b51734a122
arm: Remove bogus comment in futex_atomic_cmpxchg_inatomic()

commit 522d7dec(futex: Remove redundant pagefault_disable in
futex_atomic_cmpxchg_inatomic()) added a bogus comment.

/* Note that preemption is disabled by futex_atomic_cmpxchg_inatomic
 * call sites. */

Bogus in two aspects:

1) pagefault_disable != preempt_disable even if the mechanism we use
   is the same

2) we have a call site which deliberately does not disable pagefaults
   as it wants the possible fault to be handled - though that has been
   changed for consistency reasons now.

Sigh. I really should have seen that when committing the above. :(

Catched-by-and-rightfully-ranted-at-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
LKML-Reference: <alpine.LFD.2.00.1103141126590.2787@localhost6.localdomain6>
Cc: Michel Lespinasse <walken@google.com>
Cc: Darren Hart <darren@dvhart.com>
arch/arm/include/asm/futex.h