]> Pileus Git - ~andy/linux/commit
ARC: Fix 32-bit wrap around in access_ok()
authorVineet Gupta <vgupta@synopsys.com>
Thu, 26 Sep 2013 13:20:40 +0000 (18:50 +0530)
committerVineet Gupta <vgupta@synopsys.com>
Fri, 27 Sep 2013 10:58:47 +0000 (16:28 +0530)
commit0752adfda15f0eca9859a76da3db1800e129ad43
tree854479800b11fb24d21d35f17851912cf0df7b63
parentc11eb222fd7d4db91196121dbf854178505d2751
ARC: Fix 32-bit wrap around in access_ok()

Anton reported

 | LTP tests syscalls/process_vm_readv01 and process_vm_writev01 fail
 | similarly in one testcase test_iov_invalid -> lvec->iov_base.
 | Testcase expects errno EFAULT and return code -1,
 | but it gets return code 1 and ERRNO is 0 what means success.

Essentially test case was passing a pointer of -1 which access_ok()
was not catching. It was doing [@addr + @sz <= TASK_SIZE] which would
pass for @addr == -1

Fixed that by rewriting as [@addr <= TASK_SIZE - @sz]

Reported-by: Anton Kolesov <Anton.Kolesov@synopsys.com>
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
arch/arc/include/asm/uaccess.h