]> Pileus Git - ~andy/linux/commit
projects / ~andy / linux / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: eb9001c) | patch
HID: picoLCD: fix a NULL test in picolcd_raw_cir()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 7 Sep 2012 06:47:41 +0000 (09:47 +0300)
committerJiri Kosina <jkosina@suse.cz>
Sat, 8 Sep 2012 19:19:07 +0000 (21:19 +0200)
commit02d9be1aa6e93f4819f230a1d570e2ff415fa294
treeeb1e1468ec5d8820afc4b250601581be27691083tree | snapshot
parenteb9001cd8ffff9c9b1ed1ea85d36c862bea964c0commit | diff
HID: picoLCD: fix a NULL test in picolcd_raw_cir()

Smatch complains that the NULL checking in this function is not
consistent and could lead to a NULL dereference.  The comments say that
we should return here if rc_dev is NULL so I've changed the test to
match the comment.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-picolcd_cir.c diff | blob | history
Andy's Linux Kernel repo