]> Pileus Git - ~andy/linux/commit
drivers/net/ethernet/broadcom/cnic.c: remove invalid reference to list iterator variable
authorJulia Lawall <Julia.Lawall@lip6.fr>
Sun, 8 Jul 2012 01:37:43 +0000 (01:37 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 9 Jul 2012 22:24:33 +0000 (15:24 -0700)
commit022f09784b85396b4ceba954ce28e50de4882281
tree380956e32c42ae47fbb22454ca488ceb882ef8a5
parentcae296c42c94a27e0abdea96eb762752d1ba4908
drivers/net/ethernet/broadcom/cnic.c: remove invalid reference to list iterator variable

If list_for_each_entry, etc complete a traversal of the list, the iterator
variable ends up pointing to an address at an offset from the list head,
and not a meaningful structure.  Thus this value should not be used after
the end of the iterator.  There does not seem to be a meaningful value to
provide to netdev_warn.  Replace with pr_warn, since pr_err is used
elsewhere.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/cnic.c