]> Pileus Git - ~andy/linux/commit
perf/trace: Properly use u64 to hold event_id
authorVince Weaver <vincent.weaver@maine.edu>
Fri, 15 Nov 2013 17:39:45 +0000 (12:39 -0500)
committerIngo Molnar <mingo@kernel.org>
Tue, 19 Nov 2013 15:57:44 +0000 (16:57 +0100)
commit0022cedd4a7d8a87841351e2b018bb6794cf2e67
treed52f5e595e33ed3df04acf750f3f1efe45b40d89
parent06db0b21712f878b808480ef31097637013bbf0f
perf/trace: Properly use u64 to hold event_id

The 64-bit attr.config value for perf trace events was being copied into
an "int" before doing a comparison, meaning the top 32 bits were
being truncated.

As far as I can tell this didn't cause any errors, but it did mean
it was possible to create valid aliases for all the tracepoint ids
which I don't think was intended.  (For example, 0xffffffff00000018
and 0x18 both enable the same tracepoint).

Signed-off-by: Vince Weaver <vincent.weaver@maine.edu>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/alpine.DEB.2.10.1311151236100.11932@vincent-weaver-1.um.maine.edu
Signed-off-by: Ingo Molnar <mingo@kernel.org>
kernel/trace/trace_event_perf.c