X-Git-Url: http://pileus.org/git/?a=blobdiff_plain;f=odmr.c;h=64e70bcebb3e1af0311fec11474b48d24dc328ea;hb=a23a8cf8ee1da51c4392b9f52e6b72b0c01e3b5e;hp=ea12c7c6b8ab4923a267ffd878cb863857316db8;hpb=a15938425baec600096f47506835d8c8196fe4c2;p=~andy%2Ffetchmail diff --git a/odmr.c b/odmr.c index ea12c7c6..64e70bce 100644 --- a/odmr.c +++ b/odmr.c @@ -9,24 +9,15 @@ #include #include #include -#ifdef HAVE_STRING_H /* strcat() */ #include -#endif -#ifdef HAVE_NET_SOCKET_H /* BeOS needs this */ -#include -#endif #include -#ifdef HAVE_NET_SELECT_H /* AIX needs this */ -#include -#endif -#ifdef HAVE_SYS_SELECT_H /* AIX 4.1, at least, needs this */ #include -#endif #include #include #include -#include "i18n.h" +#include "gettext.h" #include "fetchmail.h" +#include "sdump.h" #include "smtp.h" #include "socket.h" @@ -35,7 +26,8 @@ static int odmr_ok (int sock, char *argbuf) { int ok; - ok = SMTP_ok(sock); + (void)argbuf; + ok = SMTP_ok(sock, SMTP_MODE, TIMEOUT_DEFAULT); if (ok == SM_UNRECOVERABLE) return(PS_PROTOCOL); else @@ -51,7 +43,8 @@ static int odmr_getrange(int sock, struct query *ctl, const char *id, char buf [MSGBUFSIZE+1]; struct idlist *qnp; /* pointer to Q names */ - if ((ok = SMTP_ehlo(sock, fetchmailhost, + (void)id; + if ((ok = SMTP_ehlo(sock, SMTP_MODE, fetchmailhost, ctl->server.esmtp_name, ctl->server.esmtp_password, &opts))) { @@ -124,9 +117,12 @@ static int odmr_getrange(int sock, struct query *ctl, const char *id, report(stderr, GT_("Authentication required.\n")); return(PS_AUTHFAIL); - default: - report(stderr, GT_("Unknown ODMR error %d\n"), atoi(buf)); - return(PS_PROTOCOL); + default: { + char *t = sdump(buf, strlen(buf)); + report(stderr, GT_("Unknown ODMR error \"%s\"\n"), t); + xfree(t); + return(PS_PROTOCOL); + } } /* @@ -136,7 +132,7 @@ static int odmr_getrange(int sock, struct query *ctl, const char *id, * instead, we'll use select(2) to watch the read sides of both * sockets and just throw their data at each other. */ - if ((smtp_sock = smtp_open(ctl)) == -1) + if ((smtp_sock = smtp_setup(ctl)) == -1) return(PS_SOCKET); else { @@ -146,7 +142,6 @@ static int odmr_getrange(int sock, struct query *ctl, const char *id, { fd_set readfds; struct timeval timeout; - char buf[MSGBUFSIZE]; FD_ZERO(&readfds); FD_SET(sock, &readfds); @@ -211,13 +206,8 @@ static int odmr_logout(int sock, struct query *ctl) static const struct method odmr = { "ODMR", /* ODMR protocol */ -#ifdef INET6_ENABLE - "odmr", /* standard SMTP port */ - "odmrs", /* ssl SMTP port */ -#else /* INET6_ENABLE */ - 366, /* standard SMTP port */ - 2366, /* ssl SMTP port (BOGUS! RANDOM VALUE) */ -#endif /* INET6_ENABLE */ + "odmr", /* standard ODMR port */ + "odmrs", /* ssl ODMR port */ FALSE, /* this is not a tagged protocol */ FALSE, /* this does not use a message delimiter */ odmr_ok, /* parse command response */ @@ -231,6 +221,7 @@ static const struct method odmr = NULL, /* no message trailer */ NULL, /* how to delete a message */ NULL, /* how to mark a message as seen */ + NULL, /* no mailbox support */ odmr_logout, /* log out, we're done */ FALSE, /* no, we can't re-poll */ }; @@ -249,7 +240,7 @@ int doODMR (struct query *ctl) return(PS_SYNTAX); } if (ctl->mailboxes->id) { - fprintf(stderr, GT_("Option --remote is not supported with ODMR\n")); + fprintf(stderr, GT_("Option --folder is not supported with ODMR\n")); return(PS_SYNTAX); } if (check_only) {