X-Git-Url: http://pileus.org/git/?a=blobdiff_plain;f=gtk%2Fgtkcolorchooserdialog.c;h=261035473922e055cf8a1b5f242ede64bde5e061;hb=a89d420270d1a856e072ed87c365b0176f102e6c;hp=4b0b1c2e9013270c8f07c729bc22a4064962f76a;hpb=9d0febc9a64a5bfb0fcfc3a88de4757f6c1ff090;p=~andy%2Fgtk

diff --git a/gtk/gtkcolorchooserdialog.c b/gtk/gtkcolorchooserdialog.c
index 4b0b1c2e9..261035473 100644
--- a/gtk/gtkcolorchooserdialog.c
+++ b/gtk/gtkcolorchooserdialog.c
@@ -19,6 +19,7 @@
 
 #include "gtkdialog.h"
 #include "gtkstock.h"
+#include "gtkbutton.h"
 #include "gtkbox.h"
 #include "gtkprivate.h"
 #include "gtkintl.h"
@@ -69,11 +70,32 @@ propagate_notify (GObject               *o,
   g_object_notify (G_OBJECT (cc), pspec->name);
 }
 
+static void
+save_color (GtkColorChooserDialog *dialog)
+{
+  GdkRGBA color;
+
+  /* This causes the color chooser widget to save the
+   * selected and custom colors to GSettings.
+   */
+  gtk_color_chooser_get_rgba (GTK_COLOR_CHOOSER (dialog), &color);
+  gtk_color_chooser_set_rgba (GTK_COLOR_CHOOSER (dialog), &color);
+}
+
 static void
 color_activated_cb (GtkColorChooser *chooser,
                     GdkRGBA         *color,
                     GtkDialog       *dialog)
 {
+  save_color (GTK_COLOR_CHOOSER_DIALOG (dialog));
+  gtk_dialog_response (dialog, GTK_RESPONSE_OK);
+}
+
+static void
+selected_cb (GtkButton *button,
+             GtkDialog *dialog)
+{
+  save_color (GTK_COLOR_CHOOSER_DIALOG (dialog));
   gtk_dialog_response (dialog, GTK_RESPONSE_OK);
 }
 
@@ -121,9 +143,17 @@ gtk_color_chooser_dialog_init (GtkColorChooserDialog *cc)
   priv->cancel_button = gtk_dialog_add_button (dialog,
                                                GTK_STOCK_CANCEL,
                                                GTK_RESPONSE_CANCEL);
-  priv->select_button = gtk_dialog_add_button (dialog,
-                                               _("_Select"),
-                                               GTK_RESPONSE_OK);
+
+  /* We emit the response for the Select button manually,
+   * since we want to save the color first
+   */
+  priv->select_button = gtk_button_new_from_stock (_("_Select"));
+  g_signal_connect (priv->select_button, "clicked",
+                    G_CALLBACK (selected_cb), dialog);
+  gtk_widget_set_can_default (priv->select_button, TRUE);
+  gtk_widget_show (priv->select_button);
+  gtk_box_pack_end (GTK_BOX (gtk_dialog_get_action_area (dialog)),
+                    priv->select_button, FALSE, TRUE, 0);
   gtk_widget_grab_default (priv->select_button);
 
   gtk_dialog_set_alternative_button_order (dialog,
@@ -137,19 +167,15 @@ gtk_color_chooser_dialog_init (GtkColorChooserDialog *cc)
 }
 
 static void
-gtk_color_chooser_dialog_response (GtkDialog *dialog,
-                                   gint       response_id)
+gtk_color_chooser_dialog_map (GtkWidget *widget)
 {
-  if (response_id == GTK_RESPONSE_OK)
-    {
-      GdkRGBA color;
-
-      gtk_color_chooser_get_rgba (GTK_COLOR_CHOOSER (dialog), &color);
-      gtk_color_chooser_set_rgba (GTK_COLOR_CHOOSER (dialog), &color);
-    }
-
-  g_object_set (GTK_COLOR_CHOOSER_DIALOG (dialog)->priv->chooser,
+  /* We never want the dialog to come up with the editor,
+   * even if it was showing the editor the last time it was used.
+   */
+  g_object_set (GTK_COLOR_CHOOSER_DIALOG (widget)->priv->chooser,
                 "show-editor", FALSE, NULL);
+
+  GTK_WIDGET_CLASS (gtk_color_chooser_dialog_parent_class)->map (widget);
 }
 
 static void
@@ -219,12 +245,12 @@ static void
 gtk_color_chooser_dialog_class_init (GtkColorChooserDialogClass *class)
 {
   GObjectClass *object_class = G_OBJECT_CLASS (class);
-  GtkDialogClass *dialog_class = GTK_DIALOG_CLASS (class);
+  GtkWidgetClass *widget_class = GTK_WIDGET_CLASS (class);
 
   object_class->get_property = gtk_color_chooser_dialog_get_property;
   object_class->set_property = gtk_color_chooser_dialog_set_property;
 
-  dialog_class->response = gtk_color_chooser_dialog_response;
+  widget_class->map = gtk_color_chooser_dialog_map;
 
   g_object_class_override_property (object_class, PROP_RGBA, "rgba");
   g_object_class_override_property (object_class, PROP_USE_ALPHA, "use-alpha");
@@ -256,7 +282,7 @@ gtk_color_chooser_dialog_set_rgba (GtkColorChooser *chooser,
 
 static void
 gtk_color_chooser_dialog_add_palette (GtkColorChooser *chooser,
-                                      gboolean         horizontal,
+                                      GtkOrientation   orientation,
                                       gint             colors_per_line,
                                       gint             n_colors,
                                       GdkRGBA         *colors)
@@ -264,7 +290,7 @@ gtk_color_chooser_dialog_add_palette (GtkColorChooser *chooser,
   GtkColorChooserDialog *cc = GTK_COLOR_CHOOSER_DIALOG (chooser);
 
   gtk_color_chooser_add_palette (GTK_COLOR_CHOOSER (cc->priv->chooser),
-                                 horizontal, colors_per_line, n_colors, colors);
+                                 orientation, colors_per_line, n_colors, colors);
 }
 
 static void