X-Git-Url: http://pileus.org/git/?a=blobdiff_plain;f=fs%2Fsysfs%2Fsymlink.c;h=f50e3cc2ded8d76e00d203829108b40647f1fc63;hb=a77c64c1a641950626181b4857abb701d8f38ccc;hp=de402fa915f2778e010d20bfeca2c6ebc05f6ddd;hpb=8aaf226a8eaa0823c4f3c58d5207004ff6e3e758;p=~andy%2Flinux

diff --git a/fs/sysfs/symlink.c b/fs/sysfs/symlink.c
index de402fa915f..f50e3cc2ded 100644
--- a/fs/sysfs/symlink.c
+++ b/fs/sysfs/symlink.c
@@ -3,6 +3,7 @@
  */
 
 #include <linux/fs.h>
+#include <linux/mount.h>
 #include <linux/module.h>
 #include <linux/kobject.h>
 #include <linux/namei.h>
@@ -66,6 +67,7 @@ static int sysfs_add_link(struct dentry * parent, const char * name, struct kobj
 	if (!error)
 		return 0;
 
+	kobject_put(target);
 	kfree(sl->link_name);
 exit2:
 	kfree(sl);
@@ -81,14 +83,24 @@ exit1:
  */
 int sysfs_create_link(struct kobject * kobj, struct kobject * target, const char * name)
 {
-	struct dentry * dentry = kobj->dentry;
-	int error = 0;
+	struct dentry *dentry = NULL;
+	int error = -EEXIST;
+
+	BUG_ON(!name);
 
-	BUG_ON(!kobj || !kobj->dentry || !name);
+	if (!kobj) {
+		if (sysfs_mount && sysfs_mount->mnt_sb)
+			dentry = sysfs_mount->mnt_sb->s_root;
+	} else
+		dentry = kobj->dentry;
 
-	down(&dentry->d_inode->i_sem);
-	error = sysfs_add_link(dentry, name, target);
-	up(&dentry->d_inode->i_sem);
+	if (!dentry)
+		return -EFAULT;
+
+	mutex_lock(&dentry->d_inode->i_mutex);
+	if (!sysfs_dirent_exist(dentry->d_fsdata, name))
+		error = sysfs_add_link(dentry, name, target);
+	mutex_unlock(&dentry->d_inode->i_mutex);
 	return error;
 }
 
@@ -177,4 +189,3 @@ struct inode_operations sysfs_symlink_inode_operations = {
 
 EXPORT_SYMBOL_GPL(sysfs_create_link);
 EXPORT_SYMBOL_GPL(sysfs_remove_link);
-