Fix Debian bug #301964, socket leak.

[~andy/fetchmail] / pop2.c

diff --git a/pop2.c b/pop2.c
index 8615c59a410d5dd9ad414f5e38f262741a2c8d00..88ad42441830e71aa062617569d1538e1ce4514d 100644 (file)
--- a/pop2.c
+++ b/pop2.c
@@ -5,18 +5,22 @@
  * For license terms, see the file COPYING in this directory.
  */
 
-#include  <config.h>
+#include  "config.h"
+
 #ifdef POP2_ENABLE
 #include  <stdio.h>
 #if defined(STDC_HEADERS)
 #include <stdlib.h>
 #endif
+#ifdef HAVE_STRING_H
+#include <string.h>
+#endif
 #include  "fetchmail.h"
 #include  "socket.h"
 
 static int pound_arg, equal_arg;
 
-int pop2_ok (int sock, char *argbuf)
+static int pop2_ok (int sock, char *argbuf)
 /* parse POP2 command response */
 {
     int ok;
@@ -50,15 +54,21 @@ int pop2_ok (int sock, char *argbuf)
     return(ok);
 }
 
-int pop2_getauth(int sock, struct query *ctl, char *buf)
+static int pop2_getauth(int sock, struct query *ctl, char *buf)
 /* apply for connection authorization */
 {
-    return(gen_transact(sock,
+    int status;
+
+    strcpy(shroud, ctl->password);
+    status = gen_transact(sock,
                  "HELO %s %s",
-                 ctl->remotename, ctl->password));
+                 ctl->remotename, ctl->password);
+    shroud[0] = '\0';
+    return status;
 }
 
-static int pop2_getrange(int sock, struct query *ctl, const char *folder, int*countp, int*newp)
+static int pop2_getrange(int sock, struct query *ctl, const char *folder, 
+                        int *countp, int *newp, int *bytes)
 /* get range of messages to be fetched */
 {
     /* maybe the user wanted a non-default folder */
@@ -86,7 +96,7 @@ static int pop2_getrange(int sock, struct query *ctl, const char *folder, int*co
            return(PS_ERROR);
 
     *countp = pound_arg;
-    *newp = -1;
+    *bytes = *newp = -1;
 
     return(0);
 }
@@ -113,23 +123,37 @@ static int pop2_trail(int sock, struct query *ctl, int number)
     return(gen_transact(sock, ctl->keep ? "ACKS" : "ACKD"));
 }
 
-const static struct method pop2 =
+static int pop2_logout(int sock, struct query *ctl)
+/* send logout command */
+{
+    return(gen_transact(sock, "QUIT"));
+}
+
+static const struct method pop2 =
 {
     "POP2",                            /* Post Office Protocol v2 */
+#if INET6_ENABLE
+    "pop2",                            /* standard POP2 port */
+    "pop2",                            /* ssl POP2 port */
+#else /* INET6_ENABLE */
     109,                               /* standard POP2 port */
+    109,                               /* ssl POP2 port - not */
+#endif /* INET6_ENABLE */
     FALSE,                             /* this is not a tagged protocol */
     FALSE,                             /* does not use message delimiter */
-    FALSE,                             /* no getsizes method */
     pop2_ok,                           /* parse command response */
     pop2_getauth,                      /* get authorization */
     pop2_getrange,                     /* query range of messages */
     NULL,                              /* no way to get sizes */
+    NULL,                              /* no way to get sizes of subsets */
     NULL,                              /* messages are always new */
     pop2_fetch,                                /* request given message */
     NULL,                              /* no way to fetch body alone */
     pop2_trail,                                /* eat message trailer */
     NULL,                              /* no POP2 delete method */
-    "QUIT",                            /* the POP2 exit command */
+    NULL,                              /* how to mark a message as seen */
+    pop2_logout,                       /* log out, we're done */
+    FALSE,                             /* no, we can't re-poll */
 };
 
 int doPOP2 (struct query *ctl)