]> Pileus Git - ~andy/linux/blobdiff - net/ipv6/sit.c
[IPV6]: Use ipv6_addr_equal() instead of !ipv6_addr_cmp().
[~andy/linux] / net / ipv6 / sit.c
index 4786419ade0e48483ede2529c1761fd5d7585546..91e46fbe6ce2e0ec0722ad2af6a91858721dd15b 100644 (file)
@@ -198,103 +198,162 @@ failed:
 }
 
 static struct ip_tunnel_prl_entry *
-ipip6_tunnel_locate_prl(struct ip_tunnel *t, __be32 addr)
+__ipip6_tunnel_locate_prl(struct ip_tunnel *t, __be32 addr)
 {
        struct ip_tunnel_prl_entry *p = (struct ip_tunnel_prl_entry *)NULL;
 
        for (p = t->prl; p; p = p->next)
-               if (p->entry.addr == addr)
+               if (p->addr == addr)
                        break;
        return p;
 
 }
 
+static int ipip6_tunnel_get_prl(struct ip_tunnel *t, struct ip_tunnel_prl *a)
+{
+       struct ip_tunnel_prl *kp;
+       struct ip_tunnel_prl_entry *prl;
+       unsigned int cmax, c = 0, ca, len;
+       int ret = 0;
+
+       cmax = a->datalen / sizeof(*a);
+       if (cmax > 1 && a->addr != htonl(INADDR_ANY))
+               cmax = 1;
+
+       /* For simple GET or for root users,
+        * we try harder to allocate.
+        */
+       kp = (cmax <= 1 || capable(CAP_NET_ADMIN)) ?
+               kcalloc(cmax, sizeof(*kp), GFP_KERNEL) :
+               NULL;
+
+       read_lock(&ipip6_lock);
+
+       ca = t->prl_count < cmax ? t->prl_count : cmax;
+
+       if (!kp) {
+               /* We don't try hard to allocate much memory for
+                * non-root users.
+                * For root users, retry allocating enough memory for
+                * the answer.
+                */
+               kp = kcalloc(ca, sizeof(*kp), GFP_ATOMIC);
+               if (!kp) {
+                       ret = -ENOMEM;
+                       goto out;
+               }
+       }
+
+       c = 0;
+       for (prl = t->prl; prl; prl = prl->next) {
+               if (c > cmax)
+                       break;
+               if (a->addr != htonl(INADDR_ANY) && prl->addr != a->addr)
+                       continue;
+               kp[c].addr = prl->addr;
+               kp[c].flags = prl->flags;
+               c++;
+               if (a->addr != htonl(INADDR_ANY))
+                       break;
+       }
+out:
+       read_unlock(&ipip6_lock);
+
+       len = sizeof(*kp) * c;
+       ret = len ? copy_to_user(a->data, kp, len) : 0;
+
+       kfree(kp);
+       if (ret)
+               return -EFAULT;
+
+       a->datalen = len;
+       return 0;
+}
+
 static int
 ipip6_tunnel_add_prl(struct ip_tunnel *t, struct ip_tunnel_prl *a, int chg)
 {
        struct ip_tunnel_prl_entry *p;
+       int err = 0;
+
+       if (a->addr == htonl(INADDR_ANY))
+               return -EINVAL;
+
+       write_lock(&ipip6_lock);
 
        for (p = t->prl; p; p = p->next) {
-               if (p->entry.addr == a->addr) {
-                       if (chg) {
-                               p->entry = *a;
-                               return 0;
-                       }
-                       return -EEXIST;
+               if (p->addr == a->addr) {
+                       if (chg)
+                               goto update;
+                       err = -EEXIST;
+                       goto out;
                }
        }
 
-       if (chg)
-               return -ENXIO;
+       if (chg) {
+               err = -ENXIO;
+               goto out;
+       }
 
        p = kzalloc(sizeof(struct ip_tunnel_prl_entry), GFP_KERNEL);
-       if (!p)
-               return -ENOBUFS;
+       if (!p) {
+               err = -ENOBUFS;
+               goto out;
+       }
 
-       p->entry = *a;
        p->next = t->prl;
        t->prl = p;
-       return 0;
+       t->prl_count++;
+update:
+       p->addr = a->addr;
+       p->flags = a->flags;
+out:
+       write_unlock(&ipip6_lock);
+       return err;
 }
 
 static int
 ipip6_tunnel_del_prl(struct ip_tunnel *t, struct ip_tunnel_prl *a)
 {
        struct ip_tunnel_prl_entry *x, **p;
+       int err = 0;
+
+       write_lock(&ipip6_lock);
 
-       if (a) {
+       if (a && a->addr != htonl(INADDR_ANY)) {
                for (p = &t->prl; *p; p = &(*p)->next) {
-                       if ((*p)->entry.addr == a->addr) {
+                       if ((*p)->addr == a->addr) {
                                x = *p;
                                *p = x->next;
                                kfree(x);
-                               return 0;
+                               t->prl_count--;
+                               goto out;
                        }
                }
-               return -ENXIO;
+               err = -ENXIO;
        } else {
                while (t->prl) {
                        x = t->prl;
                        t->prl = t->prl->next;
                        kfree(x);
+                       t->prl_count--;
                }
        }
+out:
+       write_unlock(&ipip6_lock);
        return 0;
 }
 
-/* copied directly from anycast.c */
-static int
-ipip6_onlink(struct in6_addr *addr, struct net_device *dev)
-{
-       struct inet6_dev        *idev;
-       struct inet6_ifaddr     *ifa;
-       int     onlink;
-
-       onlink = 0;
-       rcu_read_lock();
-       idev = __in6_dev_get(dev);
-       if (idev) {
-               read_lock_bh(&idev->lock);
-               for (ifa=idev->addr_list; ifa; ifa=ifa->if_next) {
-                       onlink = ipv6_prefix_equal(addr, &ifa->addr,
-                                                  ifa->prefix_len);
-                       if (onlink)
-                               break;
-               }
-               read_unlock_bh(&idev->lock);
-       }
-       rcu_read_unlock();
-       return onlink;
-}
-
 static int
 isatap_chksrc(struct sk_buff *skb, struct iphdr *iph, struct ip_tunnel *t)
 {
-       struct ip_tunnel_prl_entry *p = ipip6_tunnel_locate_prl(t, iph->saddr);
+       struct ip_tunnel_prl_entry *p;
        int ok = 1;
 
+       read_lock(&ipip6_lock);
+       p = __ipip6_tunnel_locate_prl(t, iph->saddr);
        if (p) {
-               if (p->entry.flags & PRL_DEFAULT)
+               if (p->flags & PRL_DEFAULT)
                        skb->ndisc_nodetype = NDISC_NODETYPE_DEFAULT;
                else
                        skb->ndisc_nodetype = NDISC_NODETYPE_NODEFAULT;
@@ -302,11 +361,12 @@ isatap_chksrc(struct sk_buff *skb, struct iphdr *iph, struct ip_tunnel *t)
                struct in6_addr *addr6 = &ipv6_hdr(skb)->saddr;
                if (ipv6_addr_is_isatap(addr6) &&
                    (addr6->s6_addr32[3] == iph->saddr) &&
-                   ipip6_onlink(addr6, t->dev))
+                   ipv6_chk_prefix(addr6, t->dev))
                        skb->ndisc_nodetype = NDISC_NODETYPE_HOST;
                else
                        ok = 0;
        }
+       read_unlock(&ipip6_lock);
        return ok;
 }
 
@@ -319,7 +379,7 @@ static void ipip6_tunnel_uninit(struct net_device *dev)
                dev_put(dev);
        } else {
                ipip6_tunnel_unlink(netdev_priv(dev));
-               ipip6_tunnel_del_prl(netdev_priv(dev), 0);
+               ipip6_tunnel_del_prl(netdev_priv(dev), NULL);
                dev_put(dev);
        }
 }
@@ -879,11 +939,12 @@ ipip6_tunnel_ioctl (struct net_device *dev, struct ifreq *ifr, int cmd)
                err = 0;
                break;
 
+       case SIOCGETPRL:
        case SIOCADDPRL:
        case SIOCDELPRL:
        case SIOCCHGPRL:
                err = -EPERM;
-               if (!capable(CAP_NET_ADMIN))
+               if (cmd != SIOCGETPRL && !capable(CAP_NET_ADMIN))
                        goto done;
                err = -EINVAL;
                if (dev == ipip6_fb_tunnel_dev)
@@ -895,13 +956,23 @@ ipip6_tunnel_ioctl (struct net_device *dev, struct ifreq *ifr, int cmd)
                if (!(t = netdev_priv(dev)))
                        goto done;
 
-               ipip6_tunnel_unlink(t);
-               if (cmd == SIOCDELPRL)
+               switch (cmd) {
+               case SIOCGETPRL:
+                       err = ipip6_tunnel_get_prl(t, &prl);
+                       if (!err && copy_to_user(ifr->ifr_ifru.ifru_data,
+                                                &prl, sizeof(prl)))
+                               err = -EFAULT;
+                       break;
+               case SIOCDELPRL:
                        err = ipip6_tunnel_del_prl(t, &prl);
-               else
+                       break;
+               case SIOCADDPRL:
+               case SIOCCHGPRL:
                        err = ipip6_tunnel_add_prl(t, &prl, cmd == SIOCCHGPRL);
-               ipip6_tunnel_link(t);
-               netdev_state_change(dev);
+                       break;
+               }
+               if (cmd != SIOCGETPRL)
+                       netdev_state_change(dev);
                break;
 
        default: