bridge: Fix the way to check if a local fdb entry can be deleted

[~andy/linux] / net / bridge / br_vlan.c

diff --git a/net/bridge/br_vlan.c b/net/bridge/br_vlan.c
index af5ebd18d7059f2d0cc289e226c544f210309dc2..233ec1c6e9db4393c378902d92158accb7715ced 100644 (file)
--- a/net/bridge/br_vlan.c
+++ b/net/bridge/br_vlan.c
@@ -146,32 +146,11 @@ struct sk_buff *br_handle_vlan(struct net_bridge *br,
 
        /* At this point, we know that the frame was filtered and contains
         * a valid vlan id.  If the vlan id is set in the untagged bitmap,
-        * send untagged; otherwise, send taged.
+        * send untagged; otherwise, send tagged.
         */
        br_vlan_get_tag(skb, &vid);
        if (test_bit(vid, pv->untagged_bitmap))
                skb = br_vlan_untag(skb);
-       else {
-               /* Egress policy says "send tagged".  If output device
-                * is the  bridge, we need to add the VLAN header
-                * ourselves since we'll be going through the RX path.
-                * Sending to ports puts the frame on the TX path and
-                * we let dev_hard_start_xmit() add the header.
-                */
-               if (skb->protocol != htons(ETH_P_8021Q) &&
-                   pv->port_idx == 0) {
-                       /* vlan_put_tag expects skb->data to point to
-                        * mac header.
-                        */
-                       skb_push(skb, ETH_HLEN);
-                       skb = __vlan_put_tag(skb, skb->vlan_proto, skb->vlan_tci);
-                       if (!skb)
-                               goto out;
-                       /* put skb->data back to where it was */
-                       skb_pull(skb, ETH_HLEN);
-                       skb->vlan_tci = 0;
-               }
-       }
 
 out:
        return skb;
@@ -316,6 +295,25 @@ void br_vlan_flush(struct net_bridge *br)
        __vlan_flush(pv);
 }
 
+bool br_vlan_find(struct net_bridge *br, u16 vid)
+{
+       struct net_port_vlans *pv;
+       bool found = false;
+
+       rcu_read_lock();
+       pv = rcu_dereference(br->vlan_info);
+
+       if (!pv)
+               goto out;
+
+       if (test_bit(vid, pv->vlan_bitmap))
+               found = true;
+
+out:
+       rcu_read_unlock();
+       return found;
+}
+
 int br_vlan_filter_toggle(struct net_bridge *br, unsigned long val)
 {
        if (!rtnl_trylock())