]> Pileus Git - ~andy/linux/blobdiff - kernel/power/snapshot.c
[PATCH] Change the name of pagedir_nosave
[~andy/linux] / kernel / power / snapshot.c
index 979096c2777328af7930a185cb82d0713ed30340..1d276b3ae15292df2e92c64de9069c8a13975b14 100644 (file)
@@ -34,7 +34,9 @@
 
 #include "power.h"
 
-struct pbe *pagedir_nosave;
+/* List of PBEs used for creating and restoring the suspend image */
+struct pbe *restore_pblist;
+
 static unsigned int nr_copy_pages;
 static unsigned int nr_meta_pages;
 static unsigned long *buffer;
@@ -156,6 +158,58 @@ static inline int save_highmem(void) {return 0;}
 static inline int restore_highmem(void) {return 0;}
 #endif
 
+/**
+ *     @safe_needed - on resume, for storing the PBE list and the image,
+ *     we can only use memory pages that do not conflict with the pages
+ *     used before suspend.
+ *
+ *     The unsafe pages are marked with the PG_nosave_free flag
+ *     and we count them using unsafe_pages
+ */
+
+static unsigned int unsafe_pages;
+
+static void *alloc_image_page(gfp_t gfp_mask, int safe_needed)
+{
+       void *res;
+
+       res = (void *)get_zeroed_page(gfp_mask);
+       if (safe_needed)
+               while (res && PageNosaveFree(virt_to_page(res))) {
+                       /* The page is unsafe, mark it for swsusp_free() */
+                       SetPageNosave(virt_to_page(res));
+                       unsafe_pages++;
+                       res = (void *)get_zeroed_page(gfp_mask);
+               }
+       if (res) {
+               SetPageNosave(virt_to_page(res));
+               SetPageNosaveFree(virt_to_page(res));
+       }
+       return res;
+}
+
+unsigned long get_safe_page(gfp_t gfp_mask)
+{
+       return (unsigned long)alloc_image_page(gfp_mask, 1);
+}
+
+/**
+ *     free_image_page - free page represented by @addr, allocated with
+ *     alloc_image_page (page flags set by it must be cleared)
+ */
+
+static inline void free_image_page(void *addr, int clear_nosave_free)
+{
+       ClearPageNosave(virt_to_page(addr));
+       if (clear_nosave_free)
+               ClearPageNosaveFree(virt_to_page(addr));
+       free_page((unsigned long)addr);
+}
+
+/**
+ *     pfn_is_nosave - check if given pfn is in the 'nosave' section
+ */
+
 static inline int pfn_is_nosave(unsigned long pfn)
 {
        unsigned long nosave_begin_pfn = __pa(&__nosave_begin) >> PAGE_SHIFT;
@@ -208,37 +262,36 @@ unsigned int count_data_pages(void)
        return n;
 }
 
+static inline void copy_data_page(long *dst, long *src)
+{
+       int n;
+
+       /* copy_page and memcpy are not usable for copying task structs. */
+       for (n = PAGE_SIZE / sizeof(long); n; n--)
+               *dst++ = *src++;
+}
+
 static void copy_data_pages(struct pbe *pblist)
 {
        struct zone *zone;
        unsigned long pfn, max_zone_pfn;
-       struct pbe *pbe, *p;
+       struct pbe *pbe;
 
        pbe = pblist;
        for_each_zone (zone) {
                if (is_highmem(zone))
                        continue;
                mark_free_pages(zone);
-               /* This is necessary for swsusp_free() */
-               for_each_pb_page (p, pblist)
-                       SetPageNosaveFree(virt_to_page(p));
-               for_each_pbe (p, pblist)
-                       SetPageNosaveFree(virt_to_page(p->address));
                max_zone_pfn = zone->zone_start_pfn + zone->spanned_pages;
                for (pfn = zone->zone_start_pfn; pfn < max_zone_pfn; pfn++) {
                        struct page *page = saveable_page(pfn);
 
                        if (page) {
-                               long *src, *dst;
-                               int n;
+                               void *ptr = page_address(page);
 
                                BUG_ON(!pbe);
-                               pbe->orig_address = (unsigned long)page_address(page);
-                               /* copy_page and memcpy are not usable for copying task structs. */
-                               dst = (long *)pbe->address;
-                               src = (long *)pbe->orig_address;
-                               for (n = PAGE_SIZE / sizeof(long); n; n--)
-                                       *dst++ = *src++;
+                               copy_data_page((void *)pbe->address, ptr);
+                               pbe->orig_address = (unsigned long)ptr;
                                pbe = pbe->next;
                        }
                }
@@ -246,7 +299,6 @@ static void copy_data_pages(struct pbe *pblist)
        BUG_ON(pbe);
 }
 
-
 /**
  *     free_pagedir - free pages allocated with alloc_pagedir()
  */
@@ -257,10 +309,7 @@ static void free_pagedir(struct pbe *pblist, int clear_nosave_free)
 
        while (pblist) {
                pbe = (pblist + PB_PAGE_SKIP)->next;
-               ClearPageNosave(virt_to_page(pblist));
-               if (clear_nosave_free)
-                       ClearPageNosaveFree(virt_to_page(pblist));
-               free_page((unsigned long)pblist);
+               free_image_page(pblist, clear_nosave_free);
                pblist = pbe;
        }
 }
@@ -269,12 +318,12 @@ static void free_pagedir(struct pbe *pblist, int clear_nosave_free)
  *     fill_pb_page - Create a list of PBEs on a given memory page
  */
 
-static inline void fill_pb_page(struct pbe *pbpage)
+static inline void fill_pb_page(struct pbe *pbpage, unsigned int n)
 {
        struct pbe *p;
 
        p = pbpage;
-       pbpage += PB_PAGE_SKIP;
+       pbpage += n - 1;
        do
                p->next = p + 1;
        while (++p < pbpage);
@@ -283,62 +332,29 @@ static inline void fill_pb_page(struct pbe *pbpage)
 /**
  *     create_pbe_list - Create a list of PBEs on top of a given chain
  *     of memory pages allocated with alloc_pagedir()
+ *
+ *     This function assumes that pages allocated by alloc_image_page() will
+ *     always be zeroed.
  */
 
 static inline void create_pbe_list(struct pbe *pblist, unsigned int nr_pages)
 {
-       struct pbe *pbpage, *p;
+       struct pbe *pbpage;
        unsigned int num = PBES_PER_PAGE;
 
        for_each_pb_page (pbpage, pblist) {
                if (num >= nr_pages)
                        break;
 
-               fill_pb_page(pbpage);
+               fill_pb_page(pbpage, PBES_PER_PAGE);
                num += PBES_PER_PAGE;
        }
        if (pbpage) {
-               for (num -= PBES_PER_PAGE - 1, p = pbpage; num < nr_pages; p++, num++)
-                       p->next = p + 1;
-               p->next = NULL;
+               num -= PBES_PER_PAGE;
+               fill_pb_page(pbpage, nr_pages - num);
        }
 }
 
-static unsigned int unsafe_pages;
-
-/**
- *     @safe_needed - on resume, for storing the PBE list and the image,
- *     we can only use memory pages that do not conflict with the pages
- *     used before suspend.
- *
- *     The unsafe pages are marked with the PG_nosave_free flag
- *     and we count them using unsafe_pages
- */
-
-static void *alloc_image_page(gfp_t gfp_mask, int safe_needed)
-{
-       void *res;
-
-       res = (void *)get_zeroed_page(gfp_mask);
-       if (safe_needed)
-               while (res && PageNosaveFree(virt_to_page(res))) {
-                       /* The page is unsafe, mark it for swsusp_free() */
-                       SetPageNosave(virt_to_page(res));
-                       unsafe_pages++;
-                       res = (void *)get_zeroed_page(gfp_mask);
-               }
-       if (res) {
-               SetPageNosave(virt_to_page(res));
-               SetPageNosaveFree(virt_to_page(res));
-       }
-       return res;
-}
-
-unsigned long get_safe_page(gfp_t gfp_mask)
-{
-       return (unsigned long)alloc_image_page(gfp_mask, 1);
-}
-
 /**
  *     alloc_pagedir - Allocate the page directory.
  *
@@ -362,17 +378,17 @@ static struct pbe *alloc_pagedir(unsigned int nr_pages, gfp_t gfp_mask,
                return NULL;
 
        pblist = alloc_image_page(gfp_mask, safe_needed);
-       /* FIXME: rewrite this ugly loop */
-       for (pbe = pblist, num = PBES_PER_PAGE; pbe && num < nr_pages;
-                       pbe = pbe->next, num += PBES_PER_PAGE) {
+       pbe = pblist;
+       for (num = PBES_PER_PAGE; num < nr_pages; num += PBES_PER_PAGE) {
+               if (!pbe) {
+                       free_pagedir(pblist, 1);
+                       return NULL;
+               }
                pbe += PB_PAGE_SKIP;
                pbe->next = alloc_image_page(gfp_mask, safe_needed);
+               pbe = pbe->next;
        }
-       if (!pbe) { /* get_zeroed_page() failed */
-               free_pagedir(pblist, 1);
-               pblist = NULL;
-        } else
-               create_pbe_list(pblist, nr_pages);
+       create_pbe_list(pblist, nr_pages);
        return pblist;
 }
 
@@ -401,7 +417,7 @@ void swsusp_free(void)
        }
        nr_copy_pages = 0;
        nr_meta_pages = 0;
-       pagedir_nosave = NULL;
+       restore_pblist = NULL;
        buffer = NULL;
 }
 
@@ -476,15 +492,15 @@ asmlinkage int swsusp_save(void)
                return -ENOMEM;
        }
 
-       pagedir_nosave = swsusp_alloc(nr_pages);
-       if (!pagedir_nosave)
+       restore_pblist = swsusp_alloc(nr_pages);
+       if (!restore_pblist)
                return -ENOMEM;
 
        /* During allocating of suspend pagedir, new cold pages may appear.
         * Kill them.
         */
        drain_local_pages();
-       copy_data_pages(pagedir_nosave);
+       copy_data_pages(restore_pblist);
 
        /*
         * End of critical section. From now on, we can write to memory,
@@ -555,7 +571,7 @@ static inline struct pbe *pack_orig_addresses(unsigned long *buf, struct pbe *pb
 
 int snapshot_read_next(struct snapshot_handle *handle, size_t count)
 {
-       if (handle->page > nr_meta_pages + nr_copy_pages)
+       if (handle->cur > nr_meta_pages + nr_copy_pages)
                return 0;
        if (!buffer) {
                /* This makes the buffer be freed by swsusp_free() */
@@ -566,26 +582,26 @@ int snapshot_read_next(struct snapshot_handle *handle, size_t count)
        if (!handle->offset) {
                init_header((struct swsusp_info *)buffer);
                handle->buffer = buffer;
-               handle->pbe = pagedir_nosave;
+               handle->pbe = restore_pblist;
        }
-       if (handle->prev < handle->page) {
-               if (handle->page <= nr_meta_pages) {
+       if (handle->prev < handle->cur) {
+               if (handle->cur <= nr_meta_pages) {
                        handle->pbe = pack_orig_addresses(buffer, handle->pbe);
                        if (!handle->pbe)
-                               handle->pbe = pagedir_nosave;
+                               handle->pbe = restore_pblist;
                } else {
                        handle->buffer = (void *)handle->pbe->address;
                        handle->pbe = handle->pbe->next;
                }
-               handle->prev = handle->page;
+               handle->prev = handle->cur;
        }
-       handle->buf_offset = handle->page_offset;
-       if (handle->page_offset + count >= PAGE_SIZE) {
-               count = PAGE_SIZE - handle->page_offset;
-               handle->page_offset = 0;
-               handle->page++;
+       handle->buf_offset = handle->cur_offset;
+       if (handle->cur_offset + count >= PAGE_SIZE) {
+               count = PAGE_SIZE - handle->cur_offset;
+               handle->cur_offset = 0;
+               handle->cur++;
        } else {
-               handle->page_offset += count;
+               handle->cur_offset += count;
        }
        handle->offset += count;
        return count;
@@ -675,7 +691,7 @@ static int load_header(struct snapshot_handle *handle,
                pblist = alloc_pagedir(info->image_pages, GFP_ATOMIC, 0);
                if (!pblist)
                        return -ENOMEM;
-               pagedir_nosave = pblist;
+               restore_pblist = pblist;
                handle->pbe = pblist;
                nr_copy_pages = info->image_pages;
                nr_meta_pages = info->pages - info->image_pages - 1;
@@ -702,7 +718,7 @@ static inline struct pbe *unpack_orig_addresses(unsigned long *buf,
 
 /**
  *     prepare_image - use metadata contained in the PBE list
- *     pointed to by pagedir_nosave to mark the pages that will
+ *     pointed to by restore_pblist to mark the pages that will
  *     be overwritten in the process of restoring the system
  *     memory state from the image ("unsafe" pages) and allocate
  *     memory for the image
@@ -727,7 +743,7 @@ static int prepare_image(struct snapshot_handle *handle)
        unsigned int nr_pages = nr_copy_pages;
        struct pbe *p, *pblist = NULL;
 
-       p = pagedir_nosave;
+       p = restore_pblist;
        error = mark_unsafe_pages(p);
        if (!error) {
                pblist = alloc_pagedir(nr_pages, GFP_ATOMIC, 1);
@@ -759,7 +775,7 @@ static int prepare_image(struct snapshot_handle *handle)
                }
        }
        if (!error) {
-               pagedir_nosave = pblist;
+               restore_pblist = pblist;
        } else {
                handle->pbe = NULL;
                swsusp_free();
@@ -820,7 +836,7 @@ int snapshot_write_next(struct snapshot_handle *handle, size_t count)
 {
        int error = 0;
 
-       if (handle->prev && handle->page > nr_meta_pages + nr_copy_pages)
+       if (handle->prev && handle->cur > nr_meta_pages + nr_copy_pages)
                return 0;
        if (!buffer) {
                /* This makes the buffer be freed by swsusp_free() */
@@ -831,7 +847,7 @@ int snapshot_write_next(struct snapshot_handle *handle, size_t count)
        if (!handle->offset)
                handle->buffer = buffer;
        handle->sync_read = 1;
-       if (handle->prev < handle->page) {
+       if (handle->prev < handle->cur) {
                if (!handle->prev) {
                        error = load_header(handle,
                                        (struct swsusp_info *)buffer);
@@ -844,7 +860,7 @@ int snapshot_write_next(struct snapshot_handle *handle, size_t count)
                                error = prepare_image(handle);
                                if (error)
                                        return error;
-                               handle->pbe = pagedir_nosave;
+                               handle->pbe = restore_pblist;
                                handle->last_pbe = NULL;
                                handle->buffer = get_buffer(handle);
                                handle->sync_read = 0;
@@ -854,15 +870,15 @@ int snapshot_write_next(struct snapshot_handle *handle, size_t count)
                        handle->buffer = get_buffer(handle);
                        handle->sync_read = 0;
                }
-               handle->prev = handle->page;
+               handle->prev = handle->cur;
        }
-       handle->buf_offset = handle->page_offset;
-       if (handle->page_offset + count >= PAGE_SIZE) {
-               count = PAGE_SIZE - handle->page_offset;
-               handle->page_offset = 0;
-               handle->page++;
+       handle->buf_offset = handle->cur_offset;
+       if (handle->cur_offset + count >= PAGE_SIZE) {
+               count = PAGE_SIZE - handle->cur_offset;
+               handle->cur_offset = 0;
+               handle->cur++;
        } else {
-               handle->page_offset += count;
+               handle->cur_offset += count;
        }
        handle->offset += count;
        return count;
@@ -871,5 +887,5 @@ int snapshot_write_next(struct snapshot_handle *handle, size_t count)
 int snapshot_image_loaded(struct snapshot_handle *handle)
 {
        return !(!handle->pbe || handle->pbe->next || !nr_copy_pages ||
-               handle->page <= nr_meta_pages + nr_copy_pages);
+               handle->cur <= nr_meta_pages + nr_copy_pages);
 }