]> Pileus Git - ~andy/gtk/blobdiff - gtk/gtktreeviewcolumn.c
gtk/gtktreeviewcolumn.c: use accessor functions to access GtkWidget
[~andy/gtk] / gtk / gtktreeviewcolumn.c
index 17b0f51e6150e80fc3e95393d30bba17ce45d764..ebc054d43ebca4ccc259143b0d036307c407e46f 100644 (file)
@@ -17,7 +17,7 @@
  * Boston, MA 02111-1307, USA.
  */
 
-#include <config.h>
+#include "config.h"
 #include <string.h>
 #include "gtktreeviewcolumn.h"
 #include "gtktreeview.h"
@@ -31,7 +31,7 @@
 #include "gtkarrow.h"
 #include "gtkprivate.h"
 #include "gtkintl.h"
-#include "gtkalias.h"
+
 
 enum
 {
@@ -51,7 +51,8 @@ enum
   PROP_ALIGNMENT,
   PROP_REORDERABLE,
   PROP_SORT_INDICATOR,
-  PROP_SORT_ORDER
+  PROP_SORT_ORDER,
+  PROP_SORT_COLUMN_ID
 };
 
 enum
@@ -67,7 +68,7 @@ struct _GtkTreeViewColumnCellInfo
   GSList *attributes;
   GtkTreeCellDataFunc func;
   gpointer func_data;
-  GtkDestroyNotify destroy;
+  GDestroyNotify destroy;
   gint requested_width;
   gint real_width;
   guint expand : 1;
@@ -112,6 +113,7 @@ static void gtk_tree_view_column_cell_layout_clear_attributes   (GtkCellLayout
 static void gtk_tree_view_column_cell_layout_reorder            (GtkCellLayout         *cell_layout,
                                                                  GtkCellRenderer       *cell,
                                                                  gint                   position);
+static GList *gtk_tree_view_column_cell_layout_get_cells        (GtkCellLayout         *cell_layout);
 
 /* Button handling code */
 static void gtk_tree_view_column_create_button                 (GtkTreeViewColumn       *tree_column);
@@ -150,12 +152,17 @@ static GList *gtk_tree_view_column_cell_prev                   (GtkTreeViewColum
                                                                GList                  *current);
 static void gtk_tree_view_column_clear_attributes_by_info      (GtkTreeViewColumn      *tree_column,
                                                                GtkTreeViewColumnCellInfo *info);
+/* GtkBuildable implementation */
+static void gtk_tree_view_column_buildable_init                 (GtkBuildableIface     *iface);
 
 static guint tree_column_signals[LAST_SIGNAL] = { 0 };
 
 G_DEFINE_TYPE_WITH_CODE (GtkTreeViewColumn, gtk_tree_view_column, GTK_TYPE_OBJECT,
                         G_IMPLEMENT_INTERFACE (GTK_TYPE_CELL_LAYOUT,
-                                               gtk_tree_view_column_cell_layout_init));
+                                               gtk_tree_view_column_cell_layout_init)
+                        G_IMPLEMENT_INTERFACE (GTK_TYPE_BUILDABLE,
+                                               gtk_tree_view_column_buildable_init))
+
 
 static void
 gtk_tree_view_column_class_init (GtkTreeViewColumnClass *class)
@@ -319,7 +326,32 @@ gtk_tree_view_column_class_init (GtkTreeViewColumnClass *class)
                                                       GTK_TYPE_SORT_TYPE,
                                                       GTK_SORT_ASCENDING,
                                                       GTK_PARAM_READWRITE));
-  
+
+  /**
+   * GtkTreeViewColumn:sort-column-id:
+   *
+   * Logical sort column ID this column sorts on when selected for sorting. Setting the sort column ID makes the column header
+   * clickable. Set to %-1 to make the column unsortable.
+   *
+   * Since: 2.18
+   **/
+  g_object_class_install_property (object_class,
+                                   PROP_SORT_COLUMN_ID,
+                                   g_param_spec_int ("sort-column-id",
+                                                     P_("Sort column ID"),
+                                                     P_("Logical sort column ID this column sorts on when selected for sorting"),
+                                                     -1,
+                                                     G_MAXINT,
+                                                     -1,
+                                                     GTK_PARAM_READWRITE));
+}
+
+static void
+gtk_tree_view_column_buildable_init (GtkBuildableIface *iface)
+{
+  iface->add_child = _gtk_cell_layout_buildable_add_child;
+  iface->custom_tag_start = _gtk_cell_layout_buildable_custom_tag_start;
+  iface->custom_tag_end = _gtk_cell_layout_buildable_custom_tag_end;
 }
 
 static void
@@ -332,6 +364,7 @@ gtk_tree_view_column_cell_layout_init (GtkCellLayoutIface *iface)
   iface->set_cell_data_func = gtk_tree_view_column_cell_layout_set_cell_data_func;
   iface->clear_attributes = gtk_tree_view_column_cell_layout_clear_attributes;
   iface->reorder = gtk_tree_view_column_cell_layout_reorder;
+  iface->get_cells = gtk_tree_view_column_cell_layout_get_cells;
 }
 
 static void
@@ -376,7 +409,7 @@ gtk_tree_view_column_finalize (GObject *object)
 
       if (info->destroy)
        {
-         GtkDestroyNotify d = info->destroy;
+         GDestroyNotify d = info->destroy;
 
          info->destroy = NULL;
          d (info->func_data);
@@ -482,6 +515,11 @@ gtk_tree_view_column_set_property (GObject         *object,
                                            g_value_get_enum (value));
       break;
       
+    case PROP_SORT_COLUMN_ID:
+      gtk_tree_view_column_set_sort_column_id (tree_column,
+                                               g_value_get_int (value));
+      break;
+      
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
       break;
@@ -580,6 +618,11 @@ gtk_tree_view_column_get_property (GObject         *object,
                         gtk_tree_view_column_get_sort_order (tree_column));
       break;
       
+    case PROP_SORT_COLUMN_ID:
+      g_value_set_int (value,
+                       gtk_tree_view_column_get_sort_column_id (tree_column));
+      break;
+      
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
       break;
@@ -747,10 +790,11 @@ gtk_tree_view_column_cell_layout_reorder (GtkCellLayout   *cell_layout,
 
   g_return_if_fail (link != NULL);
 
-  column->cell_list = g_list_remove_link (column->cell_list, link);
+  column->cell_list = g_list_delete_link (column->cell_list, link);
   column->cell_list = g_list_insert (column->cell_list, info, position);
 
-  gtk_widget_queue_draw (column->tree_view);
+  if (column->tree_view)
+    gtk_widget_queue_draw (column->tree_view);
 }
 
 static void
@@ -820,7 +864,7 @@ gtk_tree_view_column_create_button (GtkTreeViewColumn *tree_column)
       gtk_widget_show (child);
     }
 
-  g_signal_connect (child, "mnemonic_activate",
+  g_signal_connect (child, "mnemonic-activate",
                    G_CALLBACK (gtk_tree_view_column_mnemonic_activate),
                    tree_column);
 
@@ -842,25 +886,33 @@ gtk_tree_view_column_create_button (GtkTreeViewColumn *tree_column)
 static void 
 gtk_tree_view_column_update_button (GtkTreeViewColumn *tree_column)
 {
+  gint sort_column_id = -1;
   GtkWidget *hbox;
   GtkWidget *alignment;
   GtkWidget *arrow;
   GtkWidget *current_child;
+  GtkArrowType arrow_type = GTK_ARROW_NONE;
+  GtkTreeModel *model;
+
+  if (tree_column->tree_view)
+    model = gtk_tree_view_get_model (GTK_TREE_VIEW (tree_column->tree_view));
+  else
+    model = NULL;
 
   /* Create a button if necessary */
   if (tree_column->visible &&
       tree_column->button == NULL &&
       tree_column->tree_view &&
-      GTK_WIDGET_REALIZED (tree_column->tree_view))
+      gtk_widget_get_realized (tree_column->tree_view))
     gtk_tree_view_column_create_button (tree_column);
   
   if (! tree_column->button)
     return;
 
-  hbox = GTK_BIN (tree_column->button)->child;
+  hbox = gtk_bin_get_child (GTK_BIN (tree_column->button));
   alignment = tree_column->alignment;
   arrow = tree_column->arrow;
-  current_child = GTK_BIN (alignment)->child;
+  current_child = gtk_bin_get_child (GTK_BIN (alignment));
 
   /* Set up the actual button */
   gtk_alignment_set (GTK_ALIGNMENT (alignment), tree_column->xalign,
@@ -896,25 +948,39 @@ gtk_tree_view_column_update_button (GtkTreeViewColumn *tree_column)
                                          "");
     }
 
-  switch (tree_column->sort_order)
+  if (GTK_IS_TREE_SORTABLE (model))
+    gtk_tree_sortable_get_sort_column_id (GTK_TREE_SORTABLE (model),
+                                         &sort_column_id,
+                                         NULL);
+
+  if (tree_column->show_sort_indicator)
     {
-    case GTK_SORT_ASCENDING:
-      gtk_arrow_set (GTK_ARROW (arrow),
-                    GTK_ARROW_DOWN,
-                    GTK_SHADOW_IN);
-      break;
+      gboolean alternative;
 
-    case GTK_SORT_DESCENDING:
-      gtk_arrow_set (GTK_ARROW (arrow),
-                    GTK_ARROW_UP,
-                    GTK_SHADOW_IN);
-      break;
-          
-    default:
-      g_warning (G_STRLOC": bad sort order");
-      break;
+      g_object_get (gtk_widget_get_settings (tree_column->tree_view),
+                   "gtk-alternative-sort-arrows", &alternative,
+                   NULL);
+
+      switch (tree_column->sort_order)
+        {
+         case GTK_SORT_ASCENDING:
+           arrow_type = alternative ? GTK_ARROW_UP : GTK_ARROW_DOWN;
+           break;
+
+         case GTK_SORT_DESCENDING:
+           arrow_type = alternative ? GTK_ARROW_DOWN : GTK_ARROW_UP;
+           break;
+
+         default:
+           g_warning (G_STRLOC": bad sort order");
+           break;
+       }
     }
 
+  gtk_arrow_set (GTK_ARROW (arrow),
+                arrow_type,
+                GTK_SHADOW_IN);
+
   /* Put arrow on the right if the text is left-or-center justified, and on the
    * left otherwise; do this by packing boxes, so flipping text direction will
    * reverse things
@@ -934,7 +1000,8 @@ gtk_tree_view_column_update_button (GtkTreeViewColumn *tree_column)
     }
   g_object_unref (arrow);
 
-  if (tree_column->show_sort_indicator)
+  if (tree_column->show_sort_indicator
+      || (GTK_IS_TREE_SORTABLE (model) && tree_column->sort_column_id >= 0))
     gtk_widget_show (arrow);
   else
     gtk_widget_hide (arrow);
@@ -943,7 +1010,7 @@ gtk_tree_view_column_update_button (GtkTreeViewColumn *tree_column)
    * if you show it before it's realized, it'll get the wrong window. */
   if (tree_column->button &&
       tree_column->tree_view != NULL &&
-      GTK_WIDGET_REALIZED (tree_column->tree_view))
+      gtk_widget_get_realized (tree_column->tree_view))
     {
       if (tree_column->visible)
        {
@@ -971,15 +1038,15 @@ gtk_tree_view_column_update_button (GtkTreeViewColumn *tree_column)
   
   if (tree_column->reorderable || tree_column->clickable)
     {
-      GTK_WIDGET_SET_FLAGS (tree_column->button, GTK_CAN_FOCUS);
+      gtk_widget_set_can_focus (tree_column->button, TRUE);
     }
   else
     {
-      GTK_WIDGET_UNSET_FLAGS (tree_column->button, GTK_CAN_FOCUS);
-      if (GTK_WIDGET_HAS_FOCUS (tree_column->button))
+      gtk_widget_set_can_focus (tree_column->button, FALSE);
+      if (gtk_widget_has_focus (tree_column->button))
        {
          GtkWidget *toplevel = gtk_widget_get_toplevel (tree_column->tree_view);
-         if (GTK_WIDGET_TOPLEVEL (toplevel))
+         if (gtk_widget_is_toplevel (toplevel))
            {
              gtk_window_set_focus (GTK_WINDOW (toplevel), NULL);
            }
@@ -988,7 +1055,7 @@ gtk_tree_view_column_update_button (GtkTreeViewColumn *tree_column)
   /* Queue a resize on the assumption that we always want to catch all changes
    * and columns don't change all that often.
    */
-  if (GTK_WIDGET_REALIZED (tree_column->tree_view))
+  if (gtk_widget_get_realized (tree_column->tree_view))
      gtk_widget_queue_resize (tree_column->tree_view);
 
 }
@@ -1030,7 +1097,8 @@ gtk_tree_view_column_button_event (GtkWidget *widget,
                                 (gint) ((GdkEventMotion *)event)->y)))
     {
       column->maybe_reordered = FALSE;
-      _gtk_tree_view_column_start_drag (GTK_TREE_VIEW (column->tree_view), column);
+      _gtk_tree_view_column_start_drag (GTK_TREE_VIEW (column->tree_view), column,
+                                        event->motion.device);
       return TRUE;
     }
   if (column->clickable == FALSE)
@@ -1071,7 +1139,7 @@ gtk_tree_view_column_mnemonic_activate (GtkWidget *widget,
   GTK_TREE_VIEW (column->tree_view)->priv->focus_column = column;
   if (column->clickable)
     gtk_button_clicked (GTK_BUTTON (column->button));
-  else if (GTK_WIDGET_CAN_FOCUS (column->button))
+  else if (gtk_widget_get_can_focus (column->button))
     gtk_widget_grab_focus (column->button);
   else
     gtk_widget_grab_focus (column->tree_view);
@@ -1170,7 +1238,7 @@ gtk_tree_view_column_setup_sort_column_id_callback (GtkTreeViewColumn *tree_colu
 
       if (tree_column->sort_column_changed_signal == 0)
         tree_column->sort_column_changed_signal =
-         g_signal_connect (model, "sort_column_changed",
+         g_signal_connect (model, "sort-column-changed",
                            G_CALLBACK (gtk_tree_view_model_sort_column_changed),
                            tree_column);
       
@@ -1197,6 +1265,7 @@ gtk_tree_view_column_setup_sort_column_id_callback (GtkTreeViewColumn *tree_colu
 void
 _gtk_tree_view_column_realize_button (GtkTreeViewColumn *column)
 {
+  GtkAllocation allocation;
   GtkTreeView *tree_view;
   GdkWindowAttr attr;
   guint attributes_mask;
@@ -1206,7 +1275,7 @@ _gtk_tree_view_column_realize_button (GtkTreeViewColumn *column)
   rtl = (gtk_widget_get_direction (GTK_WIDGET (tree_view)) == GTK_TEXT_DIR_RTL);
 
   g_return_if_fail (GTK_IS_TREE_VIEW (tree_view));
-  g_return_if_fail (GTK_WIDGET_REALIZED (tree_view));
+  g_return_if_fail (gtk_widget_get_realized (GTK_WIDGET (tree_view)));
   g_return_if_fail (tree_view->priv->header_window != NULL);
   g_return_if_fail (column->button != NULL);
 
@@ -1232,7 +1301,8 @@ _gtk_tree_view_column_realize_button (GtkTreeViewColumn *column)
   attr.width = TREE_VIEW_DRAG_WIDTH;
   attr.height = tree_view->priv->header_height;
 
-  attr.x = (column->button->allocation.x + (rtl ? 0 : column->button->allocation.width)) - 3;
+  gtk_widget_get_allocation (column->button, &allocation);
+  attr.x = (allocation.x + (rtl ? 0 : allocation.width)) - TREE_VIEW_DRAG_WIDTH / 2;
   column->window = gdk_window_new (tree_view->priv->header_window,
                                   &attr, attributes_mask);
   gdk_window_set_user_data (column->window, tree_view);
@@ -1311,12 +1381,17 @@ _gtk_tree_view_column_unset_tree_view (GtkTreeViewColumn *column)
 gboolean
 _gtk_tree_view_column_has_editable_cell (GtkTreeViewColumn *column)
 {
+  GtkCellRenderer *cell;
+  GtkCellRendererMode mode;
   GList *list;
 
   for (list = column->cell_list; list; list = list->next)
-    if (((GtkTreeViewColumnCellInfo *)list->data)->cell->mode ==
-       GTK_CELL_RENDERER_MODE_EDITABLE)
-      return TRUE;
+    {
+      cell = ((GtkTreeViewColumnCellInfo *)list->data)->cell;
+      g_object_get (cell, "mode", &mode, NULL);
+      if (mode == GTK_CELL_RENDERER_MODE_EDITABLE)
+        return TRUE;
+    }
 
   return FALSE;
 }
@@ -1342,11 +1417,13 @@ _gtk_tree_view_column_count_special_cells (GtkTreeViewColumn *column)
 
   for (list = column->cell_list; list; list = list->next)
     {
+      GtkCellRendererMode mode;
       GtkTreeViewColumnCellInfo *cellinfo = list->data;
 
-      if ((cellinfo->cell->mode == GTK_CELL_RENDERER_MODE_EDITABLE ||
-         cellinfo->cell->mode == GTK_CELL_RENDERER_MODE_ACTIVATABLE) &&
-         cellinfo->cell->visible)
+      g_object_get (cellinfo->cell, "mode", &mode, NULL);
+      if ((mode == GTK_CELL_RENDERER_MODE_EDITABLE ||
+          mode == GTK_CELL_RENDERER_MODE_ACTIVATABLE) &&
+         gtk_cell_renderer_get_visible (cellinfo->cell))
        i++;
     }
 
@@ -1404,12 +1481,12 @@ gtk_tree_view_column_new (void)
  * gtk_tree_view_column_set_attributes() on the newly created #GtkTreeViewColumn.
  *
  * Here's a simple example:
- * <informalexample><programlisting>
+ * |[
  *  enum { TEXT_COLUMN, COLOR_COLUMN, N_COLUMNS };
  *  ...
  *  {
  *    GtkTreeViewColumn *column;
- *    GtkCellRenderer   *renderer = gtk_cell_renderer_text_new (<!-- -->);
+ *    GtkCellRenderer   *renderer = gtk_cell_renderer_text_new ();
  *  
  *    column = gtk_tree_view_column_new_with_attributes ("Title",
  *                                                       renderer,
@@ -1417,7 +1494,7 @@ gtk_tree_view_column_new (void)
  *                                                       "foreground", COLOR_COLUMN,
  *                                                       NULL);
  *  }
- * </programlisting></informalexample>
+ * ]|
  * 
  * Return value: A newly created #GtkTreeViewColumn.
  **/
@@ -1501,18 +1578,10 @@ gtk_tree_view_column_clear (GtkTreeViewColumn *tree_column)
   gtk_cell_layout_clear (GTK_CELL_LAYOUT (tree_column));
 }
 
-/**
- * gtk_tree_view_column_get_cell_renderers:
- * @tree_column: A #GtkTreeViewColumn
- * 
- * Returns a newly-allocated #GList of all the cell renderers in the column, 
- * in no particular order.  The list must be freed with g_list_free().
- * 
- * Return value: A list of #GtkCellRenderers
- **/
-GList *
-gtk_tree_view_column_get_cell_renderers (GtkTreeViewColumn *tree_column)
+static GList *
+gtk_tree_view_column_cell_layout_get_cells (GtkCellLayout *layout)
 {
+  GtkTreeViewColumn *tree_column = GTK_TREE_VIEW_COLUMN (layout);
   GList *retval = NULL, *list;
 
   g_return_val_if_fail (tree_column != NULL, NULL);
@@ -1618,7 +1687,7 @@ gtk_tree_view_column_set_cell_data_func (GtkTreeViewColumn   *tree_column,
                                         GtkCellRenderer     *cell_renderer,
                                         GtkTreeCellDataFunc  func,
                                         gpointer             func_data,
-                                        GtkDestroyNotify     destroy)
+                                        GDestroyNotify       destroy)
 {
   gtk_cell_layout_set_cell_data_func (GTK_CELL_LAYOUT (tree_column),
                                       cell_renderer,
@@ -1866,7 +1935,7 @@ gtk_tree_view_column_set_fixed_width (GtkTreeViewColumn *tree_column,
   tree_column->use_resized_width = FALSE;
 
   if (tree_column->tree_view &&
-      GTK_WIDGET_REALIZED (tree_column->tree_view) &&
+      gtk_widget_get_realized (tree_column->tree_view) &&
       tree_column->column_type == GTK_TREE_VIEW_COLUMN_FIXED)
     {
       gtk_widget_queue_resize (tree_column->tree_view);
@@ -1912,7 +1981,7 @@ gtk_tree_view_column_set_min_width (GtkTreeViewColumn *tree_column,
 
   if (tree_column->visible &&
       tree_column->tree_view != NULL &&
-      GTK_WIDGET_REALIZED (tree_column->tree_view))
+      gtk_widget_get_realized (tree_column->tree_view))
     {
       if (min_width > tree_column->width)
        gtk_widget_queue_resize (tree_column->tree_view);
@@ -1972,7 +2041,7 @@ gtk_tree_view_column_set_max_width (GtkTreeViewColumn *tree_column,
 
   if (tree_column->visible &&
       tree_column->tree_view != NULL &&
-      GTK_WIDGET_REALIZED (tree_column->tree_view))
+      gtk_widget_get_realized (tree_column->tree_view))
     {
       if (max_width != -1 && max_width < tree_column->width)
        gtk_widget_queue_resize (tree_column->tree_view);
@@ -2094,8 +2163,15 @@ gtk_tree_view_column_set_expand (GtkTreeViewColumn *tree_column,
 
   if (tree_column->visible &&
       tree_column->tree_view != NULL &&
-      GTK_WIDGET_REALIZED (tree_column->tree_view))
+      gtk_widget_get_realized (tree_column->tree_view))
     {
+      /* We want to continue using the original width of the
+       * column that includes additional space added by the user
+       * resizing the columns and possibly extra (expanded) space, which
+       * are not included in the resized width.
+       */
+      tree_column->use_resized_width = FALSE;
+
       gtk_widget_queue_resize (tree_column->tree_view);
     }
 
@@ -2162,8 +2238,8 @@ gtk_tree_view_column_get_clickable (GtkTreeViewColumn *tree_column)
 /**
  * gtk_tree_view_column_set_widget:
  * @tree_column: A #GtkTreeViewColumn.
- * @widget: A child #GtkWidget, or %NULL.
- * 
+ * @widget: (allow-none): A child #GtkWidget, or %NULL.
+ *
  * Sets the widget in the header to be @widget.  If widget is %NULL, then the
  * header button is set with a #GtkLabel set to the title of @tree_column.
  **/
@@ -2326,6 +2402,7 @@ gtk_tree_view_column_set_sort_column_id (GtkTreeViewColumn *tree_column,
       gtk_tree_view_column_set_sort_order (tree_column, GTK_SORT_ASCENDING);
       gtk_tree_view_column_set_sort_indicator (tree_column, FALSE);
       gtk_tree_view_column_set_clickable (tree_column, FALSE);
+      g_object_notify (G_OBJECT (tree_column), "sort-column-id");
       return;
     }
 
@@ -2338,6 +2415,7 @@ gtk_tree_view_column_set_sort_column_id (GtkTreeViewColumn *tree_column,
                                                          NULL);
 
   gtk_tree_view_column_setup_sort_column_id_callback (tree_column);
+  g_object_notify (G_OBJECT (tree_column), "sort-column-id");
 }
 
 /**
@@ -2472,6 +2550,7 @@ gtk_tree_view_column_cell_set_cell_data (GtkTreeViewColumn *tree_column,
   GSList *list;
   GValue value = { 0, };
   GList *cell_list;
+  gboolean cell_is_expander, cell_is_expanded;
 
   g_return_if_fail (GTK_IS_TREE_VIEW_COLUMN (tree_column));
 
@@ -2487,10 +2566,12 @@ gtk_tree_view_column_cell_set_cell_data (GtkTreeViewColumn *tree_column,
 
       g_object_freeze_notify (cell);
 
-      if (info->cell->is_expander != is_expander)
+      g_object_get (cell, "is-expander", &cell_is_expander, NULL);
+      if (cell_is_expander != is_expander)
        g_object_set (cell, "is-expander", is_expander, NULL);
 
-      if (info->cell->is_expanded != is_expanded)
+      g_object_get (cell, "is-expanded", &cell_is_expanded, NULL);
+      if (cell_is_expanded != is_expanded)
        g_object_set (cell, "is-expanded", is_expanded, NULL);
 
       while (list && list->next)
@@ -2513,22 +2594,22 @@ gtk_tree_view_column_cell_set_cell_data (GtkTreeViewColumn *tree_column,
 /**
  * gtk_tree_view_column_cell_get_size:
  * @tree_column: A #GtkTreeViewColumn.
- * @cell_area: The area a cell in the column will be allocated, or %NULL
- * @x_offset: location to return x offset of a cell relative to @cell_area, or %NULL
- * @y_offset: location to return y offset of a cell relative to @cell_area, or %NULL
- * @width: location to return width needed to render a cell, or %NULL
- * @height: location to return height needed to render a cell, or %NULL
+ * @cell_area: (allow-none): The area a cell in the column will be allocated, or %NULL
+ * @x_offset: (allow-none): location to return x offset of a cell relative to @cell_area, or %NULL
+ * @y_offset: (allow-none): location to return y offset of a cell relative to @cell_area, or %NULL
+ * @width: (allow-none): location to return width needed to render a cell, or %NULL
+ * @height: (allow-none): location to return height needed to render a cell, or %NULL
  * 
  * Obtains the width and height needed to render the column.  This is used
  * primarily by the #GtkTreeView.
  **/
 void
-gtk_tree_view_column_cell_get_size (GtkTreeViewColumn *tree_column,
-                                   GdkRectangle      *cell_area,
-                                   gint              *x_offset,
-                                   gint              *y_offset,
-                                   gint              *width,
-                                   gint              *height)
+gtk_tree_view_column_cell_get_size (GtkTreeViewColumn  *tree_column,
+                                   const GdkRectangle *cell_area,
+                                   gint               *x_offset,
+                                   gint               *y_offset,
+                                   gint               *width,
+                                   gint               *height)
 {
   GList *list;
   gboolean first_cell = TRUE;
@@ -2590,11 +2671,11 @@ enum {
 static gboolean
 gtk_tree_view_column_cell_process_action (GtkTreeViewColumn  *tree_column,
                                          GdkWindow          *window,
-                                         GdkRectangle       *background_area,
-                                         GdkRectangle       *cell_area,
+                                         const GdkRectangle *background_area,
+                                         const GdkRectangle *cell_area,
                                          guint               flags,
                                          gint                action,
-                                         GdkRectangle       *expose_area,     /* RENDER */
+                                         const GdkRectangle *expose_area,     /* RENDER */
                                          GdkRectangle       *focus_rectangle, /* FOCUS  */
                                          GtkCellEditable   **editable_widget, /* EVENT  */
                                          GdkEvent           *event,           /* EVENT  */
@@ -2613,6 +2694,7 @@ gtk_tree_view_column_cell_process_action (GtkTreeViewColumn  *tree_column,
   gint special_cells;
   gint horizontal_separator;
   gboolean cursor_row = FALSE;
+  gboolean first_cell = TRUE;
   gboolean rtl;
   /* If we have rtl text, we need to transform our areas */
   GdkRectangle rtl_cell_area;
@@ -2661,27 +2743,31 @@ gtk_tree_view_column_cell_process_action (GtkTreeViewColumn  *tree_column,
   real_background_area = *background_area;
 
 
-  if (rtl)
-    depth = real_background_area.width - real_cell_area.width - horizontal_separator/2;
-  else
-    depth = real_cell_area.x - real_background_area.x - horizontal_separator/2;
-
   real_cell_area.x += focus_line_width;
   real_cell_area.y += focus_line_width;
   real_cell_area.height -= 2 * focus_line_width;
 
+  if (rtl)
+    depth = real_background_area.width - real_cell_area.width;
+  else
+    depth = real_cell_area.x - real_background_area.x;
+
   /* Find out how much extra space we have to allocate */
   for (list = tree_column->cell_list; list; list = list->next)
     {
       GtkTreeViewColumnCellInfo *info = (GtkTreeViewColumnCellInfo *)list->data;
 
-      if (! info->cell->visible)
+      if (!gtk_cell_renderer_get_visible (info->cell))
        continue;
 
       if (info->expand == TRUE)
        expand_cell_count ++;
       full_requested_width += info->requested_width;
-      /* FIXME: We prolly need to include tree_column->spacing here */
+
+      if (!first_cell)
+       full_requested_width += tree_column->spacing;
+
+      first_cell = FALSE;
     }
 
   extra_space = cell_area->width - full_requested_width;
@@ -2698,7 +2784,7 @@ gtk_tree_view_column_cell_process_action (GtkTreeViewColumn  *tree_column,
       if (info->pack == GTK_PACK_END)
        continue;
 
-      if (! info->cell->visible)
+      if (!gtk_cell_renderer_get_visible (info->cell))
        continue;
 
       if ((info->has_focus || special_cells == 1) && cursor_row)
@@ -2722,7 +2808,7 @@ gtk_tree_view_column_cell_process_action (GtkTreeViewColumn  *tree_column,
 
       if (list->next)
        {
-         real_background_area.width = info->real_width + horizontal_separator + depth ;
+         real_background_area.width = info->real_width + depth;
        }
       else
        {
@@ -2750,7 +2836,6 @@ gtk_tree_view_column_cell_process_action (GtkTreeViewColumn  *tree_column,
                                    &real_expose_area, 
                                    flags);
        }
-
       /* FOCUS */
       else if (action == CELL_ACTION_FOCUS)
        {
@@ -2859,11 +2944,11 @@ gtk_tree_view_column_cell_process_action (GtkTreeViewColumn  *tree_column,
 
       flags &= ~GTK_CELL_RENDERER_FOCUSED;
 
-      real_cell_area.x += (real_cell_area.width + tree_column->spacing);
-      real_background_area.x += (real_background_area.width + tree_column->spacing - (2 * focus_line_width ));
+      real_cell_area.x += (real_cell_area.width + 2 * focus_line_width + tree_column->spacing);
+      real_background_area.x += real_background_area.width + tree_column->spacing;
 
       /* Only needed for first cell */
-      depth=0;
+      depth = 0;
     }
 
   /* iterate list for PACK_END cells */
@@ -2874,7 +2959,7 @@ gtk_tree_view_column_cell_process_action (GtkTreeViewColumn  *tree_column,
       if (info->pack == GTK_PACK_START)
        continue;
 
-      if (! info->cell->visible)
+      if (!gtk_cell_renderer_get_visible(info->cell))
        continue;
 
       if ((info->has_focus || special_cells == 1) && cursor_row)
@@ -2895,7 +2980,7 @@ gtk_tree_view_column_cell_process_action (GtkTreeViewColumn  *tree_column,
 
       real_cell_area.width = info->real_width;
       real_cell_area.width -= 2 * focus_line_width;
-      real_background_area.width = info->real_width + horizontal_separator + depth;
+      real_background_area.width = info->real_width + depth;
 
       rtl_cell_area = real_cell_area;
       rtl_background_area = real_background_area;
@@ -2963,8 +3048,8 @@ gtk_tree_view_column_cell_process_action (GtkTreeViewColumn  *tree_column,
                      cell_area->x + cell_area->width > ((GdkEventButton *)event)->x)
                    try_event = TRUE;
                }
-             else if (real_cell_area.x <= ((GdkEventButton *)event)->x &&
-                 real_cell_area.x + real_cell_area.width > ((GdkEventButton *)event)->x)
+             else if (rtl_cell_area.x <= ((GdkEventButton *)event)->x &&
+                 rtl_cell_area.x + rtl_cell_area.width > ((GdkEventButton *)event)->x)
                /* only activate cell if the user clicked on an individual
                 * cell
                 */
@@ -3023,8 +3108,11 @@ gtk_tree_view_column_cell_process_action (GtkTreeViewColumn  *tree_column,
 
       flags &= ~GTK_CELL_RENDERER_FOCUSED;
 
-      real_cell_area.x += (real_cell_area.width + tree_column->spacing);
+      real_cell_area.x += (real_cell_area.width + 2 * focus_line_width + tree_column->spacing);
       real_background_area.x += (real_background_area.width + tree_column->spacing);
+
+      /* Only needed for first cell */
+      depth = 0;
     }
 
   /* fill focus_rectangle when required */
@@ -3061,12 +3149,12 @@ gtk_tree_view_column_cell_process_action (GtkTreeViewColumn  *tree_column,
  * #GtkTreeView.
  **/
 void
-_gtk_tree_view_column_cell_render (GtkTreeViewColumn *tree_column,
-                                  GdkWindow         *window,
-                                  GdkRectangle      *background_area,
-                                  GdkRectangle      *cell_area,
-                                  GdkRectangle      *expose_area,
-                                  guint              flags)
+_gtk_tree_view_column_cell_render (GtkTreeViewColumn  *tree_column,
+                                  GdkWindow          *window,
+                                  const GdkRectangle *background_area,
+                                  const GdkRectangle *cell_area,
+                                  const GdkRectangle *expose_area,
+                                  guint               flags)
 {
   g_return_if_fail (GTK_IS_TREE_VIEW_COLUMN (tree_column));
   g_return_if_fail (background_area != NULL);
@@ -3088,8 +3176,8 @@ _gtk_tree_view_column_cell_event (GtkTreeViewColumn  *tree_column,
                                  GtkCellEditable   **editable_widget,
                                  GdkEvent           *event,
                                  gchar              *path_string,
-                                 GdkRectangle       *background_area,
-                                 GdkRectangle       *cell_area,
+                                 const GdkRectangle *background_area,
+                                 const GdkRectangle *cell_area,
                                  guint               flags)
 {
   g_return_val_if_fail (GTK_IS_TREE_VIEW_COLUMN (tree_column), FALSE);
@@ -3106,6 +3194,24 @@ _gtk_tree_view_column_cell_event (GtkTreeViewColumn  *tree_column,
                                                   path_string);
 }
 
+void
+_gtk_tree_view_column_get_focus_area (GtkTreeViewColumn  *tree_column,
+                                     const GdkRectangle *background_area,
+                                     const GdkRectangle *cell_area,
+                                     GdkRectangle       *focus_area)
+{
+  gtk_tree_view_column_cell_process_action (tree_column,
+                                           NULL,
+                                           background_area,
+                                           cell_area,
+                                           0,
+                                           CELL_ACTION_FOCUS,
+                                           NULL,
+                                           focus_area,
+                                           NULL, NULL, NULL);
+}
+
+
 /* cell list manipulation */
 static GList *
 gtk_tree_view_column_cell_first (GtkTreeViewColumn *tree_column)
@@ -3238,8 +3344,10 @@ _gtk_tree_view_column_cell_focus (GtkTreeViewColumn *tree_column,
                                  gboolean           right)
 {
   gint count;
+  gboolean rtl;
 
   count = _gtk_tree_view_column_count_special_cells (tree_column);
+  rtl = gtk_widget_get_direction (GTK_WIDGET (tree_column->tree_view)) == GTK_TEXT_DIR_RTL;
 
   /* if we are the current focus column and have multiple editable cells,
    * try to select the next one, else move the focus to the next column
@@ -3264,8 +3372,16 @@ _gtk_tree_view_column_cell_focus (GtkTreeViewColumn *tree_column,
          if (!list || !info || !info->has_focus)
            return FALSE;
 
-         next = gtk_tree_view_column_cell_next (tree_column, list);
-         prev = gtk_tree_view_column_cell_prev (tree_column, list);
+         if (rtl)
+           {
+             prev = gtk_tree_view_column_cell_next (tree_column, list);
+             next = gtk_tree_view_column_cell_prev (tree_column, list);
+           }
+         else
+           {
+             next = gtk_tree_view_column_cell_next (tree_column, list);
+             prev = gtk_tree_view_column_cell_prev (tree_column, list);
+           }
 
          info->has_focus = FALSE;
          if (direction > 0 && next)
@@ -3276,8 +3392,12 @@ _gtk_tree_view_column_cell_focus (GtkTreeViewColumn *tree_column,
            }
          else if (direction > 0 && !next && !right)
            {
-             /* keep focus on latest cell */
-             info = gtk_tree_view_column_cell_last (tree_column)->data;
+             /* keep focus on last cell */
+             if (rtl)
+               info = gtk_tree_view_column_cell_first (tree_column)->data;
+             else
+               info = gtk_tree_view_column_cell_last (tree_column)->data;
+
              info->has_focus = TRUE;
              return TRUE;
            }
@@ -3290,7 +3410,11 @@ _gtk_tree_view_column_cell_focus (GtkTreeViewColumn *tree_column,
          else if (direction < 0 && !prev && !left)
            {
              /* keep focus on first cell */
-             info = gtk_tree_view_column_cell_first (tree_column)->data;
+             if (rtl)
+               info = gtk_tree_view_column_cell_last (tree_column)->data;
+             else
+               info = gtk_tree_view_column_cell_first (tree_column)->data;
+
              info->has_focus = TRUE;
              return TRUE;
            }
@@ -3313,21 +3437,36 @@ _gtk_tree_view_column_cell_focus (GtkTreeViewColumn *tree_column,
            info->has_focus = FALSE;
        }
 
-      if (direction > 0)
-       ((GtkTreeViewColumnCellInfo *)gtk_tree_view_column_cell_first (tree_column)->data)->has_focus = TRUE;
-      else if (direction < 0)
-       ((GtkTreeViewColumnCellInfo *)gtk_tree_view_column_cell_last (tree_column)->data)->has_focus = TRUE;
+      list = NULL;
+      if (rtl)
+        {
+         if (direction > 0)
+           list = gtk_tree_view_column_cell_last (tree_column);
+         else if (direction < 0)
+           list = gtk_tree_view_column_cell_first (tree_column);
+       }
+      else
+        {
+         if (direction > 0)
+           list = gtk_tree_view_column_cell_first (tree_column);
+         else if (direction < 0)
+           list = gtk_tree_view_column_cell_last (tree_column);
+       }
+
+      if (list)
+       ((GtkTreeViewColumnCellInfo *) list->data)->has_focus = TRUE;
     }
+
   return TRUE;
 }
 
 void
-_gtk_tree_view_column_cell_draw_focus (GtkTreeViewColumn       *tree_column,
-                                      GdkWindow               *window,
-                                      GdkRectangle            *background_area,
-                                      GdkRectangle            *cell_area,
-                                      GdkRectangle            *expose_area,
-                                      guint                    flags)
+_gtk_tree_view_column_cell_draw_focus (GtkTreeViewColumn  *tree_column,
+                                      GdkWindow          *window,
+                                      const GdkRectangle *background_area,
+                                      const GdkRectangle *cell_area,
+                                      const GdkRectangle *expose_area,
+                                      guint               flags)
 {
   gint focus_line_width;
   GtkStateType cell_state;
@@ -3342,7 +3481,7 @@ _gtk_tree_view_column_cell_draw_focus (GtkTreeViewColumn       *tree_column,
 #if 0
       gtk_paint_focus (tree_column->tree_view->style,
                       window,
-                      GTK_WIDGET_STATE (tree_column->tree_view),
+                      gtk_widget_get_state (tree_column->tree_view),
                       NULL,
                       tree_column->tree_view,
                       "treeview",
@@ -3368,7 +3507,7 @@ _gtk_tree_view_column_cell_draw_focus (GtkTreeViewColumn       *tree_column,
       cell_state = flags & GTK_CELL_RENDERER_SELECTED ? GTK_STATE_SELECTED :
              (flags & GTK_CELL_RENDERER_PRELIT ? GTK_STATE_PRELIGHT :
              (flags & GTK_CELL_RENDERER_INSENSITIVE ? GTK_STATE_INSENSITIVE : GTK_STATE_NORMAL));
-      gtk_paint_focus (tree_column->tree_view->style,
+      gtk_paint_focus (gtk_widget_get_style (tree_column->tree_view),
                       window,
                       cell_state,
                       cell_area,
@@ -3402,7 +3541,7 @@ gtk_tree_view_column_cell_is_visible (GtkTreeViewColumn *tree_column)
     {
       GtkTreeViewColumnCellInfo *info = (GtkTreeViewColumnCellInfo *) list->data;
 
-      if (info->cell->visible)
+      if (gtk_cell_renderer_get_visible (info->cell))
        return TRUE;
     }
 
@@ -3475,7 +3614,7 @@ _gtk_tree_view_column_cell_set_dirty (GtkTreeViewColumn *tree_column,
   tree_column->width = 0;
 
   if (tree_column->tree_view &&
-      GTK_WIDGET_REALIZED (tree_column->tree_view))
+      gtk_widget_get_realized (tree_column->tree_view))
     {
       if (install_handler)
        _gtk_tree_view_install_mark_rows_col_dirty (GTK_TREE_VIEW (tree_column->tree_view));
@@ -3530,8 +3669,8 @@ _gtk_tree_view_column_get_neighbor_sizes (GtkTreeViewColumn *column,
       if (info->cell == cell)
        break;
       
-      if (info->cell->visible)
-       l += info->real_width;
+      if (gtk_cell_renderer_get_visible (info->cell))
+       l += info->real_width + column->spacing;
     }
 
   while (list)
@@ -3540,8 +3679,8 @@ _gtk_tree_view_column_get_neighbor_sizes (GtkTreeViewColumn *column,
       
       list = gtk_tree_view_column_cell_next (column, list);
 
-      if (info->cell->visible)
-       r += info->real_width;
+      if (gtk_cell_renderer_get_visible (info->cell))
+       r += info->real_width + column->spacing;
     }
 
   rtl = (gtk_widget_get_direction (GTK_WIDGET (column->tree_view)) == GTK_TEXT_DIR_RTL);
@@ -3587,7 +3726,7 @@ gtk_tree_view_column_cell_get_position (GtkTreeViewColumn *tree_column,
           break;
         }
 
-      if (cellinfo->cell->visible)
+      if (gtk_cell_renderer_get_visible (cellinfo->cell))
         current_x += cellinfo->real_width;
     }
 
@@ -3614,11 +3753,29 @@ gtk_tree_view_column_cell_get_position (GtkTreeViewColumn *tree_column,
 void
 gtk_tree_view_column_queue_resize (GtkTreeViewColumn *tree_column)
 {
-  g_return_if_fail (tree_column != NULL);
+  g_return_if_fail (GTK_IS_TREE_VIEW_COLUMN (tree_column));
 
   if (tree_column->tree_view)
     _gtk_tree_view_column_cell_set_dirty (tree_column, TRUE);
 }
 
-#define __GTK_TREE_VIEW_COLUMN_C__
-#include "gtkaliasdef.c"
+/**
+ * gtk_tree_view_column_get_tree_view:
+ * @tree_column: A #GtkTreeViewColumn
+ *
+ * Returns the #GtkTreeView wherein @tree_column has been inserted.  If
+ * @column is currently not inserted in any tree view, %NULL is
+ * returned.
+ *
+ * Return value: The tree view wherein @column has been inserted if any,
+ *               %NULL otherwise.
+ *
+ * Since: 2.12
+ */
+GtkWidget *
+gtk_tree_view_column_get_tree_view (GtkTreeViewColumn *tree_column)
+{
+  g_return_val_if_fail (GTK_IS_TREE_VIEW_COLUMN (tree_column), NULL);
+
+  return tree_column->tree_view;
+}