]> Pileus Git - ~andy/gtk/blobdiff - gtk/gtktreeselection.c
Fix cut-n-paste bug.
[~andy/gtk] / gtk / gtktreeselection.c
index 02629ebff38ad9324ab9f1efa4f708b4547ea0ef..c93e375923539f2617d3044ddd5966b86aada051 100644 (file)
@@ -20,6 +20,7 @@
 #include "gtktreeselection.h"
 #include "gtktreeprivate.h"
 #include "gtkrbtree.h"
+#include "gtkmarshalers.h"
 #include "gtksignal.h"
 
 static void gtk_tree_selection_init              (GtkTreeSelection      *selection);
@@ -35,12 +36,12 @@ static gint gtk_tree_selection_real_select_node  (GtkTreeSelection      *selecti
 
 enum
 {
-  SELECTION_CHANGED,
+  CHANGED,
   LAST_SIGNAL
 };
 
-static GtkObjectClass *parent_class = NULL;
-static guint tree_selection_signals[LAST_SIGNAL] = { 0 };
+static GObjectClass *parent_class = NULL;
+static guint tree_selection_signals [LAST_SIGNAL] = { 0 };
 
 GtkType
 gtk_tree_selection_get_type (void)
@@ -62,7 +63,7 @@ gtk_tree_selection_get_type (void)
         (GInstanceInitFunc) gtk_tree_selection_init
       };
 
-      selection_type = g_type_register_static (GTK_TYPE_OBJECT, "GtkTreeSelection", &selection_info, 0);
+      selection_type = g_type_register_static (G_TYPE_OBJECT, "GtkTreeSelection", &selection_info, 0);
     }
 
   return selection_type;
@@ -77,28 +78,38 @@ gtk_tree_selection_class_init (GtkTreeSelectionClass *class)
   parent_class = g_type_class_peek_parent (class);
 
   object_class->finalize = gtk_tree_selection_finalize;
-  class->selection_changed = NULL;
+  class->changed = NULL;
 
-  tree_selection_signals[SELECTION_CHANGED] =
-    gtk_signal_new ("selection_changed",
+  tree_selection_signals[CHANGED] =
+    gtk_signal_new ("changed",
                    GTK_RUN_FIRST,
                    GTK_CLASS_TYPE (object_class),
-                   GTK_SIGNAL_OFFSET (GtkTreeSelectionClass, selection_changed),
-                   gtk_marshal_VOID__VOID,
+                   GTK_SIGNAL_OFFSET (GtkTreeSelectionClass, changed),
+                   _gtk_marshal_VOID__VOID,
                    GTK_TYPE_NONE, 0);
 }
 
 static void
 gtk_tree_selection_init (GtkTreeSelection *selection)
 {
-  selection->type = GTK_TREE_SELECTION_SINGLE;
+  selection->type = GTK_SELECTION_SINGLE;
 }
 
 static void
 gtk_tree_selection_finalize (GObject *object)
 {
-  if (GTK_TREE_SELECTION (object)->destroy)
-    (* GTK_TREE_SELECTION (object)->destroy) (GTK_TREE_SELECTION (object)->user_data);
+  GtkTreeSelection *selection = GTK_TREE_SELECTION (object);
+
+  if (selection->destroy)
+    {
+      GtkDestroyNotify d = selection->destroy;
+
+      selection->destroy = NULL;
+      d (selection->user_data);
+    }
+
+  /* chain parent_class' handler */
+  G_OBJECT_CLASS (parent_class)->finalize (object);
 }
 
 /**
@@ -114,7 +125,7 @@ _gtk_tree_selection_new (void)
 {
   GtkTreeSelection *selection;
 
-  selection = GTK_TREE_SELECTION (gtk_type_new (GTK_TYPE_TREE_SELECTION));
+  selection = GTK_TREE_SELECTION (g_object_new (GTK_TYPE_TREE_SELECTION, NULL));
 
   return selection;
 }
@@ -133,7 +144,6 @@ _gtk_tree_selection_new_with_tree_view (GtkTreeView *tree_view)
 {
   GtkTreeSelection *selection;
 
-  g_return_val_if_fail (tree_view != NULL, NULL);
   g_return_val_if_fail (GTK_IS_TREE_VIEW (tree_view), NULL);
 
   selection = _gtk_tree_selection_new ();
@@ -154,7 +164,6 @@ void
 _gtk_tree_selection_set_tree_view (GtkTreeSelection *selection,
                                    GtkTreeView      *tree_view)
 {
-  g_return_if_fail (selection != NULL);
   g_return_if_fail (GTK_IS_TREE_SELECTION (selection));
   if (tree_view != NULL)
     g_return_if_fail (GTK_IS_TREE_VIEW (tree_view));
@@ -162,36 +171,46 @@ _gtk_tree_selection_set_tree_view (GtkTreeSelection *selection,
   selection->tree_view = tree_view;
 }
 
-/* FIXME explain what the anchor is */
 /**
  * gtk_tree_selection_set_mode:
  * @selection: A #GtkTreeSelection.
- * @type: The selection type.
+ * @type: The selection mode
  *
- * Sets the selection type of the @selection.  If the previous type was
- * #GTK_TREE_SELECTION_MULTI and @type is #GTK_TREE_SELECTION_SINGLE, then
- * the anchor is kept selected, if it was previously selected.
+ * Sets the selection mode of the @selection.  If the previous type was
+ * #GTK_SELECTION_MULTIPLE, then the anchor is kept selected, if it was
+ * previously selected.
  **/
 void
-gtk_tree_selection_set_mode (GtkTreeSelection     *selection,
-                            GtkTreeSelectionMode  type)
+gtk_tree_selection_set_mode (GtkTreeSelection *selection,
+                            GtkSelectionMode  type)
 {
-  g_return_if_fail (selection != NULL);
+  GtkTreeSelectionFunc tmp_func;
   g_return_if_fail (GTK_IS_TREE_SELECTION (selection));
 
   if (selection->type == type)
     return;
 
-  if (type == GTK_TREE_SELECTION_SINGLE)
+  
+  if (type == GTK_SELECTION_NONE)
+    {
+      gtk_tree_row_reference_free (selection->tree_view->priv->anchor);
+      /* We do this so that we unconditionally unset all rows
+       */
+      tmp_func = selection->user_func;
+      selection->user_func = NULL;
+      gtk_tree_selection_unselect_all (selection);
+      selection->user_func = tmp_func;
+    }
+  else if (type == GTK_SELECTION_SINGLE ||
+          type == GTK_SELECTION_BROWSE)
     {
       GtkRBTree *tree = NULL;
       GtkRBNode *node = NULL;
       gint selected = FALSE;
+      GtkTreePath *anchor_path = NULL;
 
       if (selection->tree_view->priv->anchor)
        {
-          GtkTreePath *anchor_path;
-
           anchor_path = gtk_tree_row_reference_get_path (selection->tree_view->priv->anchor);
 
           if (anchor_path)
@@ -203,22 +222,46 @@ gtk_tree_selection_set_mode (GtkTreeSelection     *selection,
 
               if (node && GTK_RBNODE_FLAG_SET (node, GTK_RBNODE_IS_SELECTED))
                 selected = TRUE;
-
-              gtk_tree_path_free (anchor_path);
             }
        }
-      /* FIXME: if user_func is set, then it needs to unconditionally unselect
-       * all.
+
+      /* We do this so that we unconditionally unset all rows
        */
+      tmp_func = selection->user_func;
+      selection->user_func = NULL;
       gtk_tree_selection_unselect_all (selection);
+      selection->user_func = tmp_func;
 
-      /* FIXME are we properly emitting the selection_changed signal here? */
       if (node && selected)
-       GTK_RBNODE_SET_FLAG (node, GTK_RBNODE_IS_SELECTED);
+       _gtk_tree_selection_internal_select_node (selection,
+                                                 node,
+                                                 tree,
+                                                 anchor_path,
+                                                 0);
+      if (anchor_path)
+       gtk_tree_path_free (anchor_path);
     }
+
   selection->type = type;
 }
 
+/**
+ * gtk_tree_selection_get_mode:
+ * @selection: a #GtkTreeSelection
+ *
+ * Gets the selection mode for @selection. See
+ * gtk_tree_selection_set_mode().
+ *
+ * Return value: the current selection mode
+ **/
+GtkSelectionMode
+gtk_tree_selection_get_mode (GtkTreeSelection *selection)
+{
+  g_return_val_if_fail (GTK_IS_TREE_SELECTION (selection), GTK_SELECTION_SINGLE);
+
+  return selection->type;
+}
+
 /**
  * gtk_tree_selection_set_select_function:
  * @selection: A #GtkTreeSelection.
@@ -228,6 +271,8 @@ gtk_tree_selection_set_mode (GtkTreeSelection     *selection,
  *
  * Sets the selection function.  If set, this function is called before any node
  * is selected or unselected, giving some control over which nodes are selected.
+ * The select function should return %TRUE if the state of the node may be toggled,
+ * and %FALSE if the state of the node should be left unchanged.
  **/
 void
 gtk_tree_selection_set_select_function (GtkTreeSelection     *selection,
@@ -235,10 +280,17 @@ gtk_tree_selection_set_select_function (GtkTreeSelection     *selection,
                                        gpointer              data,
                                        GtkDestroyNotify      destroy)
 {
-  g_return_if_fail (selection != NULL);
   g_return_if_fail (GTK_IS_TREE_SELECTION (selection));
   g_return_if_fail (func != NULL);
 
+  if (selection->destroy)
+    {
+      GtkDestroyNotify d = selection->destroy;
+
+      selection->destroy = NULL;
+      d (selection->user_data);
+    }
+
   selection->user_func = func;
   selection->user_data = data;
   selection->destroy = destroy;
@@ -255,13 +307,20 @@ gtk_tree_selection_set_select_function (GtkTreeSelection     *selection,
 gpointer
 gtk_tree_selection_get_user_data (GtkTreeSelection *selection)
 {
-  g_return_val_if_fail (selection != NULL, NULL);
   g_return_val_if_fail (GTK_IS_TREE_SELECTION (selection), NULL);
 
   return selection->user_data;
 }
 
-GtkTreeView*
+/**
+ * gtk_tree_selection_get_tree_view:
+ * @selection: A #GtkTreeSelection
+ * 
+ * Returns the tree view associated with @selection.
+ * 
+ * Return value: A #GtkTreeView
+ **/
+GtkTreeView *
 gtk_tree_selection_get_tree_view (GtkTreeSelection *selection)
 {
   g_return_val_if_fail (GTK_IS_TREE_SELECTION (selection), NULL);
@@ -276,10 +335,10 @@ gtk_tree_selection_get_tree_view (GtkTreeSelection *selection)
  * @iter: The #GtkTreeIter, or NULL.
  *
  * Sets @iter to the currently selected node if @selection is set to
- * #GTK_TREE_SELECTION_SINGLE.  @iter may be NULL if you just want to test if
- * @selection has any selected nodes.  @model is filled with the current model
- * as a convenience.  This function will not work if you use @selection is
- * #GTK_TREE_SELECTION_MULTI.
+ * #GTK_SELECTION_SINGLE or #GTK_SELECTION_BROWSE.  @iter may be NULL if you
+ * just want to test if @selection has any selected nodes.  @model is filled
+ * with the current model as a convenience.  This function will not work if you
+ * use @selection is #GTK_SELECTION_MULTIPLE.
  *
  * Return value: TRUE, if there is a selected node.
  **/
@@ -293,9 +352,8 @@ gtk_tree_selection_get_selected (GtkTreeSelection  *selection,
   GtkTreePath *anchor_path;
   gboolean retval;
 
-  g_return_val_if_fail (selection != NULL, FALSE);
   g_return_val_if_fail (GTK_IS_TREE_SELECTION (selection), FALSE);
-  g_return_val_if_fail (selection->type == GTK_TREE_SELECTION_SINGLE, FALSE);
+  g_return_val_if_fail (selection->type != GTK_SELECTION_MULTIPLE, FALSE);
   g_return_val_if_fail (selection->tree_view != NULL, FALSE);
   g_return_val_if_fail (selection->tree_view->priv->model != NULL, FALSE);
 
@@ -358,7 +416,6 @@ gtk_tree_selection_selected_foreach (GtkTreeSelection            *selection,
   GtkRBNode *node;
   GtkTreeIter iter;
 
-  g_return_if_fail (selection != NULL);
   g_return_if_fail (GTK_IS_TREE_SELECTION (selection));
   g_return_if_fail (selection->tree_view != NULL);
   g_return_if_fail (selection->tree_view->priv->model != NULL);
@@ -368,22 +425,34 @@ gtk_tree_selection_selected_foreach (GtkTreeSelection            *selection,
       selection->tree_view->priv->tree->root == NULL)
     return;
 
+  if (selection->type == GTK_SELECTION_SINGLE ||
+      selection->type == GTK_SELECTION_BROWSE)
+    {
+      if (gtk_tree_row_reference_valid (selection->tree_view->priv->anchor))
+       {
+         path = gtk_tree_row_reference_get_path (selection->tree_view->priv->anchor);
+         gtk_tree_model_get_iter (selection->tree_view->priv->model, &iter, path);
+         (* func) (selection->tree_view->priv->model, path, &iter, data);
+         gtk_tree_path_free (path);
+       }
+      return;
+    }
+
   tree = selection->tree_view->priv->tree;
   node = selection->tree_view->priv->tree->root;
-
+  
   while (node->left != tree->nil)
     node = node->left;
 
   /* find the node internally */
-  path = gtk_tree_path_new_root ();
+  path = gtk_tree_path_new_first ();
   gtk_tree_model_get_iter (selection->tree_view->priv->model,
                           &iter, path);
-  gtk_tree_path_free (path);
 
   do
     {
       if (GTK_RBNODE_FLAG_SET (node, GTK_RBNODE_IS_SELECTED))
-       (* func) (selection->tree_view->priv->model, &iter, data);
+       (* func) (selection->tree_view->priv->model, path, &iter, data);
       if (node->children)
        {
          gboolean has_child;
@@ -395,7 +464,7 @@ gtk_tree_selection_selected_foreach (GtkTreeSelection            *selection,
            node = node->left;
          tmp = iter;
          has_child = gtk_tree_model_iter_children (selection->tree_view->priv->model, &iter, &tmp);
-
+         gtk_tree_path_append_index (path, 0);
          /* Sanity Check! */
          TREE_VIEW_INTERNAL_ASSERT_VOID (has_child);
        }
@@ -411,6 +480,7 @@ gtk_tree_selection_selected_foreach (GtkTreeSelection            *selection,
 
                  has_next = gtk_tree_model_iter_next (selection->tree_view->priv->model, &iter);
                  done = TRUE;
+                 gtk_tree_path_next (path);
 
                  /* Sanity Check! */
                  TREE_VIEW_INTERNAL_ASSERT_VOID (has_next);
@@ -423,11 +493,14 @@ gtk_tree_selection_selected_foreach (GtkTreeSelection            *selection,
                  node = tree->parent_node;
                  tree = tree->parent_tree;
                  if (tree == NULL)
-                   /* we've run out of tree */
-                   /* We're done with this function */
-                   return;
+                   {
+                     gtk_tree_path_free (path);
+                     /* we've run out of tree */
+                     /* We're done with this function */
+                     return;
+                   }
                  has_parent = gtk_tree_model_iter_parent (selection->tree_view->priv->model, &iter, &tmp_iter);
-
+                 gtk_tree_path_up (path);
                  /* Sanity check */
                  TREE_VIEW_INTERNAL_ASSERT_VOID (has_parent);
                }
@@ -453,7 +526,6 @@ gtk_tree_selection_select_path (GtkTreeSelection *selection,
   GtkRBTree *tree;
   GdkModifierType state = 0;
 
-  g_return_if_fail (selection != NULL);
   g_return_if_fail (GTK_IS_TREE_SELECTION (selection));
   g_return_if_fail (selection->tree_view != NULL);
   g_return_if_fail (path != NULL);
@@ -466,7 +538,7 @@ gtk_tree_selection_select_path (GtkTreeSelection *selection,
   if (node == NULL || GTK_RBNODE_FLAG_SET (node, GTK_RBNODE_IS_SELECTED))
     return;
 
-  if (selection->type == GTK_TREE_SELECTION_MULTI)
+  if (selection->type == GTK_SELECTION_MULTIPLE)
     state = GDK_CONTROL_MASK;
 
   _gtk_tree_selection_internal_select_node (selection,
@@ -490,7 +562,6 @@ gtk_tree_selection_unselect_path (GtkTreeSelection *selection,
   GtkRBNode *node;
   GtkRBTree *tree;
 
-  g_return_if_fail (selection != NULL);
   g_return_if_fail (GTK_IS_TREE_SELECTION (selection));
   g_return_if_fail (selection->tree_view != NULL);
   g_return_if_fail (path != NULL);
@@ -523,7 +594,6 @@ gtk_tree_selection_select_iter (GtkTreeSelection *selection,
 {
   GtkTreePath *path;
 
-  g_return_if_fail (selection != NULL);
   g_return_if_fail (GTK_IS_TREE_SELECTION (selection));
   g_return_if_fail (selection->tree_view != NULL);
   g_return_if_fail (selection->tree_view->priv->model != NULL);
@@ -553,7 +623,6 @@ gtk_tree_selection_unselect_iter (GtkTreeSelection *selection,
 {
   GtkTreePath *path;
 
-  g_return_if_fail (selection != NULL);
   g_return_if_fail (GTK_IS_TREE_SELECTION (selection));
   g_return_if_fail (selection->tree_view != NULL);
   g_return_if_fail (selection->tree_view->priv->model != NULL);
@@ -565,10 +634,75 @@ gtk_tree_selection_unselect_iter (GtkTreeSelection *selection,
   if (path == NULL)
     return;
 
-  gtk_tree_selection_select_path (selection, path);
+  gtk_tree_selection_unselect_path (selection, path);
   gtk_tree_path_free (path);
 }
 
+/**
+ * gtk_tree_selection_path_is_selected:
+ * @selection: A #GtkTreeSelection.
+ * @path: A #GtkTreePath to check selection on.
+ * 
+ * Returns %TRUE if the row pointed to by @path is currently selected.  If @path
+ * does not point to a valid location, %FALSE is returned
+ * 
+ * Return value: %TRUE if @path is selected.
+ **/
+gboolean
+gtk_tree_selection_path_is_selected (GtkTreeSelection *selection,
+                                    GtkTreePath      *path)
+{
+  GtkRBNode *node;
+  GtkRBTree *tree;
+
+  g_return_val_if_fail (GTK_IS_TREE_SELECTION (selection), FALSE);
+  g_return_val_if_fail (path != NULL, FALSE);
+  g_return_val_if_fail (selection->tree_view != NULL, FALSE);
+  g_return_val_if_fail (selection->tree_view->priv->model != NULL, FALSE);
+
+  _gtk_tree_view_find_node (selection->tree_view,
+                           path,
+                           &tree,
+                           &node);
+
+  if ((node == NULL) || !GTK_RBNODE_FLAG_SET (node, GTK_RBNODE_IS_SELECTED))
+    return FALSE;
+
+  return TRUE;
+}
+
+/**
+ * gtk_tree_selection_iter_is_selected:
+ * @selection: A #GtkTreeSelection
+ * @iter: A valid #GtkTreeIter
+ * 
+ * Returns %TRUE if the row pointed to by @path is currently selected.
+ * 
+ * Return value: %TRUE, if @iter is selected
+ **/
+gboolean
+gtk_tree_selection_iter_is_selected (GtkTreeSelection *selection,
+                                    GtkTreeIter      *iter)
+{
+  GtkTreePath *path;
+  gboolean retval;
+
+  g_return_val_if_fail (GTK_IS_TREE_SELECTION (selection), FALSE);
+  g_return_val_if_fail (iter != NULL, FALSE);
+  g_return_val_if_fail (selection->tree_view != NULL, FALSE);
+  g_return_val_if_fail (selection->tree_view->priv->model != NULL, FALSE);
+
+  path = gtk_tree_model_get_path (selection->tree_view->priv->model, iter);
+  if (path == NULL)
+    return FALSE;
+
+  retval = gtk_tree_selection_path_is_selected (selection, path);
+  gtk_tree_path_free (path);
+
+  return retval;
+}
+
+
 /* Wish I was in python, right now... */
 struct _TempTuple {
   GtkTreeSelection *selection;
@@ -629,20 +763,20 @@ gtk_tree_selection_real_select_all (GtkTreeSelection *selection)
  * gtk_tree_selection_select_all:
  * @selection: A #GtkTreeSelection.
  *
- * Selects all the nodes.  @selection is must be set to
- * #GTK_TREE_SELECTION_MULTI mode.
+ * Selects all the nodes.  @selection is must be set to #GTK_SELECTION_MULTIPLE
+ * mode.
  **/
 void
 gtk_tree_selection_select_all (GtkTreeSelection *selection)
 {
-  g_return_if_fail (selection != NULL);
   g_return_if_fail (GTK_IS_TREE_SELECTION (selection));
   g_return_if_fail (selection->tree_view != NULL);
-  g_return_if_fail (selection->tree_view->priv->tree != NULL);
-  g_return_if_fail (selection->type != GTK_TREE_SELECTION_MULTI);
+  if (selection->tree_view->priv->tree == NULL)
+    return;
+  g_return_if_fail (selection->type == GTK_SELECTION_MULTIPLE);
 
   if (gtk_tree_selection_real_select_all (selection))
-    gtk_signal_emit (GTK_OBJECT (selection), tree_selection_signals[SELECTION_CHANGED]);
+    g_signal_emit (G_OBJECT (selection), tree_selection_signals[CHANGED], 0);
 }
 
 static void
@@ -669,7 +803,8 @@ gtk_tree_selection_real_unselect_all (GtkTreeSelection *selection)
 {
   struct _TempTuple *tuple;
 
-  if (selection->type == GTK_TREE_SELECTION_SINGLE)
+  if (selection->type == GTK_SELECTION_SINGLE ||
+      selection->type == GTK_SELECTION_BROWSE)
     {
       GtkRBTree *tree = NULL;
       GtkRBNode *node = NULL;
@@ -735,15 +870,16 @@ gtk_tree_selection_real_unselect_all (GtkTreeSelection *selection)
 void
 gtk_tree_selection_unselect_all (GtkTreeSelection *selection)
 {
-  g_return_if_fail (selection != NULL);
   g_return_if_fail (GTK_IS_TREE_SELECTION (selection));
   g_return_if_fail (selection->tree_view != NULL);
-  g_return_if_fail (selection->tree_view->priv->tree != NULL);
+  if (selection->tree_view->priv->tree == NULL)
+    return;
+  
   if (selection->tree_view->priv->tree == NULL)
     return;
 
   if (gtk_tree_selection_real_unselect_all (selection))
-    gtk_signal_emit (GTK_OBJECT (selection), tree_selection_signals[SELECTION_CHANGED]);
+    g_signal_emit (G_OBJECT (selection), tree_selection_signals[CHANGED], 0);
 }
 
 static gint
@@ -757,7 +893,7 @@ gtk_tree_selection_real_select_range (GtkTreeSelection *selection,
 
   switch (gtk_tree_path_compare (start_path, end_path))
     {
-    case -1:
+    case 1:
       _gtk_tree_view_find_node (selection->tree_view,
                                end_path,
                                &start_tree,
@@ -775,7 +911,7 @@ gtk_tree_selection_real_select_range (GtkTreeSelection *selection,
       end_tree = start_tree;
       end_node = start_node;
       break;
-    case 1:
+    case -1:
       _gtk_tree_view_find_node (selection->tree_view,
                                start_path,
                                &start_tree,
@@ -792,10 +928,7 @@ gtk_tree_selection_real_select_range (GtkTreeSelection *selection,
 
   do
     {
-      if (GTK_RBNODE_FLAG_SET (start_node, GTK_RBNODE_IS_SELECTED))
-       {
-         dirty = gtk_tree_selection_real_select_node (selection, start_tree, start_node, FALSE);
-       }
+      dirty |= gtk_tree_selection_real_select_node (selection, start_tree, start_node, TRUE);
 
       if (start_node == end_node)
        break;
@@ -809,26 +942,13 @@ gtk_tree_selection_real_select_range (GtkTreeSelection *selection,
        }
       else
        {
-         gboolean done = FALSE;
-         do
+         _gtk_rbtree_next_full (start_tree, start_node, &start_tree, &start_node);
+         if (start_tree == NULL)
            {
-             start_node = _gtk_rbtree_next (start_tree, start_node);
-             if (start_node != NULL)
-               {
-                 done = TRUE;
-               }
-             else
-               {
-                 start_node = start_tree->parent_node;
-                 start_tree = start_tree->parent_tree;
-                 if (start_tree == NULL)
-                    /* FIXME should this really be silent, or should it g_warning? */
-                   /* we've run out of tree */
-                   /* This means we never found end node!! */
-                   break;
-               }
+             /* we just ran out of tree.  That means someone passed in bogus values.
+              */
+             return dirty;
            }
-         while (!done);
        }
     }
   while (TRUE);
@@ -849,12 +969,11 @@ gtk_tree_selection_select_range (GtkTreeSelection *selection,
                                 GtkTreePath      *start_path,
                                 GtkTreePath      *end_path)
 {
-  g_return_if_fail (selection != NULL);
   g_return_if_fail (GTK_IS_TREE_SELECTION (selection));
   g_return_if_fail (selection->tree_view != NULL);
 
   if (gtk_tree_selection_real_select_range (selection, start_path, end_path))
-    gtk_signal_emit (GTK_OBJECT (selection), tree_selection_signals[SELECTION_CHANGED]);
+    g_signal_emit (G_OBJECT (selection), tree_selection_signals[CHANGED], 0);
 }
 
 /* Called internally by gtktreeview.c It handles actually selecting the tree.
@@ -870,14 +989,18 @@ _gtk_tree_selection_internal_select_node (GtkTreeSelection *selection,
   gint dirty = FALSE;
   GtkTreePath *anchor_path = NULL;
 
+  if (selection->type == GTK_SELECTION_NONE)
+    return;
 
   if (selection->tree_view->priv->anchor)
     anchor_path = gtk_tree_row_reference_get_path (selection->tree_view->priv->anchor);
 
-  if (selection->type == GTK_TREE_SELECTION_SINGLE)
+  if (selection->type == GTK_SELECTION_SINGLE ||
+      selection->type == GTK_SELECTION_BROWSE)
     {
       /* Did we try to select the same node again? */
-      if (anchor_path && gtk_tree_path_compare (path, anchor_path) == 0)
+      if (selection->type == GTK_SELECTION_SINGLE &&
+         anchor_path && gtk_tree_path_compare (path, anchor_path) == 0)
        {
          if ((state & GDK_CONTROL_MASK) == GDK_CONTROL_MASK)
            {
@@ -886,12 +1009,30 @@ _gtk_tree_selection_internal_select_node (GtkTreeSelection *selection,
        }
       else
        {
-         /* FIXME: We only want to select the new node if we can unselect the
-          * old one, and we can select the new one.  We are currently
-          * unselecting the old one first, then trying the new one. */
          if (anchor_path)
            {
-             dirty = gtk_tree_selection_real_unselect_all (selection);
+             /* We only want to select the new node if we can unselect the old one,
+              * and we can select the new one. */
+             if (selection->user_func)
+               {
+                 if ((*selection->user_func) (selection, selection->tree_view->priv->model, path,
+                                              GTK_RBNODE_FLAG_SET (node, GTK_RBNODE_IS_SELECTED),
+                                              selection->user_data))
+                   dirty = TRUE;
+               }
+             else
+               {
+                 dirty = TRUE;
+               }
+
+             /* if dirty is FALSE, we weren't able to select the new one, otherwise, we try to
+              * unselect the new one
+              */
+             if (dirty)
+               dirty = gtk_tree_selection_real_unselect_all (selection);
+
+             /* if dirty is TRUE at this point, we successfully unselected the
+              * old one, and can then select the new one */
              if (dirty)
                {
                  if (selection->tree_view->priv->anchor)
@@ -914,7 +1055,7 @@ _gtk_tree_selection_internal_select_node (GtkTreeSelection *selection,
            }
        }
     }
-  else if (selection->type == GTK_TREE_SELECTION_MULTI)
+  else if (selection->type == GTK_SELECTION_MULTIPLE)
     {
       if (((state & GDK_SHIFT_MASK) == GDK_SHIFT_MASK) && (anchor_path == NULL))
        {
@@ -970,18 +1111,12 @@ _gtk_tree_selection_internal_select_node (GtkTreeSelection *selection,
     gtk_tree_path_free (anchor_path);
 
   if (dirty)
-    gtk_signal_emit (GTK_OBJECT (selection), tree_selection_signals[SELECTION_CHANGED]);
+    g_signal_emit (G_OBJECT (selection), tree_selection_signals[CHANGED], 0);
 }
 
 /* NOTE: Any {un,}selection ever done _MUST_ be done through this function!
  */
 
-/* FIXME: user_func can screw up GTK_TREE_SELECTION_SINGLE.  If it prevents
- * unselection of a node, it can keep more then one node selected.
- */
-/* Perhaps the correct solution is to prevent selecting the new node, if
- * we fail to unselect the old node.
- */
 static gint
 gtk_tree_selection_real_select_node (GtkTreeSelection *selection,
                                     GtkRBTree        *tree,
@@ -991,12 +1126,16 @@ gtk_tree_selection_real_select_node (GtkTreeSelection *selection,
   gboolean selected = FALSE;
   GtkTreePath *path = NULL;
 
+  select = !! select;
+
   if (GTK_RBNODE_FLAG_SET (node, GTK_RBNODE_IS_SELECTED) != select)
     {
       path = _gtk_tree_view_find_path (selection->tree_view, tree, node);
       if (selection->user_func)
        {
-         if ((*selection->user_func) (selection, selection->tree_view->priv->model, path, selection->user_data))
+         if ((*selection->user_func) (selection, selection->tree_view->priv->model, path,
+                                       GTK_RBNODE_FLAG_SET (node, GTK_RBNODE_IS_SELECTED),
+                                       selection->user_data))
            selected = TRUE;
        }
       else
@@ -1008,8 +1147,8 @@ gtk_tree_selection_real_select_node (GtkTreeSelection *selection,
     {
       node->flags ^= GTK_RBNODE_IS_SELECTED;
 
-      /* FIXME: just draw the one node*/
-      gtk_widget_queue_draw (GTK_WIDGET (selection->tree_view));
+      _gtk_tree_view_queue_draw_node (selection->tree_view, tree, node, NULL);
+      
       return TRUE;
     }