]> Pileus Git - ~andy/gtk/blobdiff - gtk/gtktreemodelsort.c
don't bother inserting new rows in a level with a zero refcount and
[~andy/gtk] / gtk / gtktreemodelsort.c
index 6fe97993d30dd98e42e7648b4b8c892813fc7358..ed1579421708433a6d068366729c1fdac6940993 100644 (file)
@@ -1,5 +1,6 @@
 /* gtktreemodelsort.c
- * Copyright (C) 2000  Red Hat, Inc.,  Jonathan Blandford <jrb@redhat.com>
+ * Copyright (C) 2000,2001  Red Hat, Inc.,  Jonathan Blandford <jrb@redhat.com>
+ * Copyright (C) 2001,2002  Kristian Rietveld <kris@gtk.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * iter->user_data2 = SortElt
  */
 
+/* WARNING: this code is dangerous, can cause sleepless nights,
+ * can cause your dog to die among other bad things
+ *
+ * we warned you and we're not liable for any head injuries.
+ */
+
+#include <config.h>
+#include <string.h>
+
 #include "gtktreemodelsort.h"
 #include "gtktreesortable.h"
 #include "gtktreestore.h"
-#include "gtksignal.h"
 #include "gtktreedatalist.h"
-#include <string.h>
+#include "gtkintl.h"
+#include "gtkprivate.h"
+#include "gtktreednd.h"
+#include "gtkalias.h"
 
 typedef struct _SortElt SortElt;
 typedef struct _SortLevel SortLevel;
@@ -72,42 +84,46 @@ struct _SortData
 struct _SortTuple
 {
   SortElt   *elt;
-  gint       offset;  
+  gint       offset;
+};
+
+/* Properties */
+enum {
+  PROP_0,
+  /* Construct args */
+  PROP_MODEL
 };
 
+
+
 #define GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS(tree_model_sort) \
        (((GtkTreeModelSort *)tree_model_sort)->child_flags&GTK_TREE_MODEL_ITERS_PERSIST)
 #define SORT_ELT(sort_elt) ((SortElt *)sort_elt)
 #define SORT_LEVEL(sort_level) ((SortLevel *)sort_level)
 
-#define GET_CHILD_ITER(tree_model_sort,child_iter,sort_iter) gtk_tree_model_sort_convert_iter_to_child_iter(GTK_TREE_MODEL_SORT (tree_model_sort), child_iter, sort_iter);
+#define GET_CHILD_ITER(tree_model_sort,ch_iter,so_iter) gtk_tree_model_sort_convert_iter_to_child_iter(GTK_TREE_MODEL_SORT (tree_model_sort), ch_iter, so_iter);
+
+#define NO_SORT_FUNC ((GtkTreeIterCompareFunc) 0x1)
+
+#define VALID_ITER(iter, tree_model_sort) (iter != NULL && iter->user_data != NULL && iter->user_data2 != NULL && tree_model_sort->stamp == iter->stamp)
 
+/* general (object/interface init, etc) */
 static void gtk_tree_model_sort_init                  (GtkTreeModelSort      *tree_model_sort);
 static void gtk_tree_model_sort_class_init            (GtkTreeModelSortClass *tree_model_sort_class);
 static void gtk_tree_model_sort_tree_model_init       (GtkTreeModelIface     *iface);
 static void gtk_tree_model_sort_tree_sortable_init    (GtkTreeSortableIface  *iface);
+static void gtk_tree_model_sort_drag_source_init      (GtkTreeDragSourceIface*iface);
 static void gtk_tree_model_sort_finalize              (GObject               *object);
-static void gtk_tree_model_sort_row_changed           (GtkTreeModel          *model,
-                                                      GtkTreePath           *start_path,
-                                                      GtkTreeIter           *start_iter,
-                                                      gpointer               data);
-static void gtk_tree_model_sort_row_inserted          (GtkTreeModel          *model,
-                                                      GtkTreePath           *path,
-                                                      GtkTreeIter           *iter,
-                                                      gpointer               data);
-static void gtk_tree_model_sort_row_has_child_toggled (GtkTreeModel          *model,
-                                                      GtkTreePath           *path,
-                                                      GtkTreeIter           *iter,
-                                                      gpointer               data);
-static void gtk_tree_model_sort_row_deleted           (GtkTreeModel          *model,
-                                                      GtkTreePath           *path,
-                                                      gpointer               data);
-static void gtk_tree_model_sort_rows_reordered        (GtkTreeModel          *s_model,
-                                                      GtkTreePath           *s_path,
-                                                      GtkTreeIter           *s_iter,
-                                                      gint                  *new_order,
-                                                      gpointer               data);
-
+static void gtk_tree_model_sort_set_property          (GObject               *object,
+                                                      guint                  prop_id,
+                                                      const GValue          *value,
+                                                      GParamSpec            *pspec);
+static void gtk_tree_model_sort_get_property          (GObject               *object,
+                                                      guint                  prop_id,
+                                                      GValue                *value,
+                                                      GParamSpec            *pspec);
+
+/* our signal handlers */
 static void gtk_tree_model_sort_row_changed           (GtkTreeModel          *model,
                                                       GtkTreePath           *start_path,
                                                       GtkTreeIter           *start_iter,
@@ -130,7 +146,7 @@ static void gtk_tree_model_sort_rows_reordered        (GtkTreeModel          *s_
                                                       gpointer               data);
 
 /* TreeModel interface */
-static guint        gtk_tree_model_sort_get_flags          (GtkTreeModel          *tree_model);
+static GtkTreeModelFlags gtk_tree_model_sort_get_flags     (GtkTreeModel          *tree_model);
 static gint         gtk_tree_model_sort_get_n_columns      (GtkTreeModel          *tree_model);
 static GType        gtk_tree_model_sort_get_column_type    (GtkTreeModel          *tree_model,
                                                             gint                   index);
@@ -161,9 +177,21 @@ static gboolean     gtk_tree_model_sort_iter_parent        (GtkTreeModel
                                                             GtkTreeIter           *child);
 static void         gtk_tree_model_sort_ref_node           (GtkTreeModel          *tree_model,
                                                             GtkTreeIter           *iter);
+static void         gtk_tree_model_sort_real_unref_node    (GtkTreeModel          *tree_model,
+                                                            GtkTreeIter           *iter,
+                                                           gboolean               propagate_unref);
 static void         gtk_tree_model_sort_unref_node         (GtkTreeModel          *tree_model,
                                                             GtkTreeIter           *iter);
 
+/* TreeDragSource interface */
+static gboolean     gtk_tree_model_sort_row_draggable         (GtkTreeDragSource      *drag_source,
+                                                               GtkTreePath            *path);
+static gboolean     gtk_tree_model_sort_drag_data_get         (GtkTreeDragSource      *drag_source,
+                                                               GtkTreePath            *path,
+                                                              GtkSelectionData       *selection_data);
+static gboolean     gtk_tree_model_sort_drag_data_delete      (GtkTreeDragSource      *drag_source,
+                                                               GtkTreePath            *path);
+
 /* TreeSortable interface */
 static gboolean     gtk_tree_model_sort_get_sort_column_id    (GtkTreeSortable        *sortable,
                                                               gint                   *sort_column_id,
@@ -182,7 +210,7 @@ static void         gtk_tree_model_sort_set_default_sort_func (GtkTreeSortable
                                                               GtkDestroyNotify        destroy);
 static gboolean     gtk_tree_model_sort_has_default_sort_func (GtkTreeSortable     *sortable);
 
-/* Private functions */
+/* Private functions (sort funcs, level handling and other utils) */
 static void         gtk_tree_model_sort_build_level       (GtkTreeModelSort *tree_model_sort,
                                                           SortLevel        *parent_level,
                                                           SortElt          *parent_elt);
@@ -197,29 +225,26 @@ static void         gtk_tree_model_sort_sort              (GtkTreeModelSort *tre
 static gint         gtk_tree_model_sort_level_find_insert (GtkTreeModelSort *tree_model_sort,
                                                           SortLevel        *level,
                                                           GtkTreeIter      *iter,
-                                                          gboolean          skip_sort_elt);
+                                                          gint             skip_index);
 static gboolean     gtk_tree_model_sort_insert_value      (GtkTreeModelSort *tree_model_sort,
                                                           SortLevel        *level,
                                                           GtkTreePath      *s_path,
                                                           GtkTreeIter      *s_iter);
 static GtkTreePath *gtk_tree_model_sort_elt_get_path      (SortLevel        *level,
                                                           SortElt          *elt);
-static void         get_child_iter_from_elt               (GtkTreeModelSort *tree_model_sort,
-                                                          GtkTreeIter      *child_iter,
-                                                          SortLevel        *level,
-                                                          SortElt          *elt);
 static void         gtk_tree_model_sort_set_model         (GtkTreeModelSort *tree_model_sort,
                                                           GtkTreeModel     *child_model);
 static GtkTreePath *gtk_real_tree_model_sort_convert_child_path_to_path (GtkTreeModelSort *tree_model_sort,
                                                                         GtkTreePath      *child_path,
                                                                         gboolean          build_levels);
 
+static GObjectClass *parent_class = NULL;
 
 GType
 gtk_tree_model_sort_get_type (void)
 {
   static GType tree_model_sort_type = 0;
-  
+
   if (!tree_model_sort_type)
     {
       static const GTypeInfo tree_model_sort_info =
@@ -249,16 +274,28 @@ gtk_tree_model_sort_get_type (void)
         NULL
       };
 
-      tree_model_sort_type = g_type_register_static (G_TYPE_OBJECT,
-                                                    "GtkTreeModelSort",
-                                                    &tree_model_sort_info, 0);
+      static const GInterfaceInfo drag_source_info =
+      {
+        (GInterfaceInitFunc) gtk_tree_model_sort_drag_source_init,
+        NULL,
+        NULL
+      };
+
+      tree_model_sort_type =
+       g_type_register_static (G_TYPE_OBJECT, "GtkTreeModelSort",
+                               &tree_model_sort_info, 0);
+
       g_type_add_interface_static (tree_model_sort_type,
                                    GTK_TYPE_TREE_MODEL,
                                    &tree_model_info);
-      
+
       g_type_add_interface_static (tree_model_sort_type,
                                    GTK_TYPE_TREE_SORTABLE,
                                    &sortable_info);
+
+      g_type_add_interface_static (tree_model_sort_type,
+                                   GTK_TYPE_TREE_DRAG_SOURCE,
+                                   &drag_source_info);
     }
 
   return tree_model_sort_type;
@@ -280,8 +317,21 @@ gtk_tree_model_sort_class_init (GtkTreeModelSortClass *class)
   GObjectClass *object_class;
 
   object_class = (GObjectClass *) class;
+  parent_class = g_type_class_peek_parent (class);
+
+  object_class->set_property = gtk_tree_model_sort_set_property;
+  object_class->get_property = gtk_tree_model_sort_get_property;
 
   object_class->finalize = gtk_tree_model_sort_finalize;
+
+  /* Properties */
+  g_object_class_install_property (object_class,
+                                   PROP_MODEL,
+                                   g_param_spec_object ("model",
+                                                       P_("TreeModelSort Model"),
+                                                       P_("The model for the TreeModelSort to sort"),
+                                                       GTK_TYPE_TREE_MODEL,
+                                                       GTK_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY));
 }
 
 static void
@@ -313,11 +363,19 @@ gtk_tree_model_sort_tree_sortable_init (GtkTreeSortableIface *iface)
   iface->has_default_sort_func = gtk_tree_model_sort_has_default_sort_func;
 }
 
+static void
+gtk_tree_model_sort_drag_source_init (GtkTreeDragSourceIface *iface)
+{
+  iface->row_draggable = gtk_tree_model_sort_row_draggable;
+  iface->drag_data_delete = gtk_tree_model_sort_drag_data_delete;
+  iface->drag_data_get = gtk_tree_model_sort_drag_data_get;
+}
+
 /**
  * gtk_tree_model_sort_new_with_model:
  * @child_model: A #GtkTreeModel
  *
- * Creates a new #GtkTreeModel, with @child_model as the child_model.
+ * Creates a new #GtkTreeModel, with @child_model as the child model.
  *
  * Return value: A new #GtkTreeModel.
  */
@@ -328,7 +386,7 @@ gtk_tree_model_sort_new_with_model (GtkTreeModel      *child_model)
 
   g_return_val_if_fail (GTK_IS_TREE_MODEL (child_model), NULL);
 
-  retval = GTK_TREE_MODEL (g_object_new (gtk_tree_model_sort_get_type (), NULL));
+  retval = g_object_new (gtk_tree_model_sort_get_type (), NULL);
 
   gtk_tree_model_sort_set_model (GTK_TREE_MODEL_SORT (retval), child_model);
 
@@ -351,6 +409,47 @@ gtk_tree_model_sort_finalize (GObject *object)
       _gtk_tree_data_list_header_free (tree_model_sort->sort_list);
       tree_model_sort->sort_list = NULL;
     }
+
+  /* must chain up */
+  parent_class->finalize (object);
+}
+
+static void
+gtk_tree_model_sort_set_property (GObject      *object,
+                                 guint         prop_id,
+                                 const GValue *value,
+                                 GParamSpec   *pspec)
+{
+  GtkTreeModelSort *tree_model_sort = GTK_TREE_MODEL_SORT (object);
+
+  switch (prop_id)
+    {
+    case PROP_MODEL:
+      gtk_tree_model_sort_set_model (tree_model_sort, g_value_get_object (value));
+      break;
+    default:
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
+      break;
+    }
+}
+
+static void
+gtk_tree_model_sort_get_property (GObject    *object,
+                                 guint       prop_id,
+                                 GValue     *value,
+                                 GParamSpec *pspec)
+{
+  GtkTreeModelSort *tree_model_sort = GTK_TREE_MODEL_SORT (object);
+
+  switch (prop_id)
+    {
+    case PROP_MODEL:
+      g_value_set_object (value, gtk_tree_model_sort_get_model(tree_model_sort));
+      break;
+    default:
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
+      break;
+    }
 }
 
 static void
@@ -363,14 +462,14 @@ gtk_tree_model_sort_row_changed (GtkTreeModel *s_model,
   GtkTreePath *path = NULL;
   GtkTreeIter iter;
   GtkTreeIter tmpiter;
-  
+
   SortElt tmp;
   SortElt *elt;
   SortLevel *level;
 
   gboolean free_s_path = FALSE;
 
-  gint offset, index = 0, i;
+  gint index = 0, old_index, i;
 
   g_return_if_fail (start_s_path != NULL || start_s_iter != NULL);
 
@@ -380,8 +479,9 @@ gtk_tree_model_sort_row_changed (GtkTreeModel *s_model,
       start_s_path = gtk_tree_model_get_path (s_model, start_s_iter);
     }
 
-  path = gtk_tree_model_sort_convert_child_path_to_path (tree_model_sort,
-                                                        start_s_path);
+  path = gtk_real_tree_model_sort_convert_child_path_to_path (tree_model_sort,
+                                                             start_s_path,
+                                                             FALSE);
   if (!path)
     {
       if (free_s_path)
@@ -390,60 +490,134 @@ gtk_tree_model_sort_row_changed (GtkTreeModel *s_model,
     }
 
   gtk_tree_model_get_iter (GTK_TREE_MODEL (data), &iter, path);
-  
+
   level = iter.user_data;
   elt = iter.user_data2;
-  
-  if (level->array->len < 2 || tree_model_sort->sort_column_id == -1)
+
+  level->ref_count++;
+
+  if (level->array->len < 2 ||
+      (tree_model_sort->sort_column_id == GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID &&
+       tree_model_sort->default_sort_func == NO_SORT_FUNC))
     {
       if (free_s_path)
        gtk_tree_path_free (start_s_path);
-      
+
       gtk_tree_model_row_changed (GTK_TREE_MODEL (data), path, &iter);
-      
+
       gtk_tree_path_free (path);
-      
+
+      level->ref_count--;
+
       return;
     }
-
+  
   if (!GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS (tree_model_sort))
     {
       gtk_tree_model_get_iter (tree_model_sort->child_model,
                               &tmpiter, start_s_path);
     }
-  
-  offset = elt->offset;
 
-  for (i = 0; i < level->array->len; i++)
-    if (elt->offset == g_array_index (level->array, SortElt, i).offset)
-      index = i;
-  
+  old_index = elt - SORT_ELT (level->array->data);
+
   memcpy (&tmp, elt, sizeof (SortElt));
-  g_array_remove_index (level->array, index);
-  
+
   if (GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS (tree_model_sort))
     index = gtk_tree_model_sort_level_find_insert (tree_model_sort,
                                                   level,
                                                   &tmp.iter,
-                                                  TRUE);
+                                                  old_index);
   else
     index = gtk_tree_model_sort_level_find_insert (tree_model_sort,
                                                   level,
                                                   &tmpiter,
-                                                  TRUE);
-  
-  g_array_insert_val (level->array, index, tmp);
+                                                  old_index);
+
+  if (index < old_index)
+    {
+      g_memmove (level->array->data + ((index + 1)*sizeof (SortElt)),
+                level->array->data + ((index)*sizeof (SortElt)),
+                (old_index - index)* sizeof(SortElt));
+    }
+  else if (index > old_index)
+    {
+      g_memmove (level->array->data + ((old_index)*sizeof (SortElt)),
+                level->array->data + ((old_index + 1)*sizeof (SortElt)),
+                (index - old_index)* sizeof(SortElt));
+    }
+  memcpy (level->array->data + ((index)*sizeof (SortElt)),
+         &tmp, sizeof (SortElt));
+
+  for (i = 0; i < level->array->len; i++)
+    if (g_array_index (level->array, SortElt, i).children)
+      g_array_index (level->array, SortElt, i).children->parent_elt = &g_array_index (level->array, SortElt, i);
+
+  gtk_tree_path_up (path);
+  gtk_tree_path_append_index (path, index);
 
   gtk_tree_model_sort_increment_stamp (tree_model_sort);
 
-  if (path)
-    gtk_tree_path_free (path);
+  /* if the item moved, then emit rows_reordered */
+  if (old_index != index)
+    {
+      gint *new_order;
+      gint j;
 
-  path = gtk_tree_model_sort_elt_get_path (level, &g_array_index (level->array, SortElt, index));
-  g_return_if_fail (path != NULL);
+      GtkTreePath *tmppath;
+
+      new_order = g_new (gint, level->array->len);
 
+      for (j = 0; j < level->array->len; j++)
+        {
+         if (index > old_index)
+           {
+             if (j == index)
+               new_order[j] = old_index;
+             else if (j >= old_index && j < index)
+               new_order[j] = j + 1;
+             else
+               new_order[j] = j;
+           }
+         else if (index < old_index)
+           {
+             if (j == index)
+               new_order[j] = old_index;
+             else if (j > index && j <= old_index)
+               new_order[j] = j - 1;
+             else
+               new_order[j] = j;
+           }
+         /* else? shouldn't really happen */
+       }
+
+      if (level->parent_elt)
+        {
+         iter.stamp = tree_model_sort->stamp;
+         iter.user_data = level->parent_level;
+         iter.user_data2 = level->parent_elt;
+
+         tmppath = gtk_tree_model_get_path (GTK_TREE_MODEL (tree_model_sort), &iter);
+
+         gtk_tree_model_rows_reordered (GTK_TREE_MODEL (tree_model_sort),
+                                        tmppath, &iter, new_order);
+       }
+      else
+        {
+         /* toplevel */
+         tmppath = gtk_tree_path_new ();
+
+          gtk_tree_model_rows_reordered (GTK_TREE_MODEL (tree_model_sort), tmppath,
+                                        NULL, new_order);
+       }
+
+      gtk_tree_path_free (tmppath);
+      g_free (new_order);
+    }
+
+  level->ref_count--;
+
+  /* emit row_changed signal (at new location) */
   gtk_tree_model_get_iter (GTK_TREE_MODEL (data), &iter, path);
-  
   gtk_tree_model_row_changed (GTK_TREE_MODEL (data), path, &iter);
 
   gtk_tree_path_free (path);
@@ -473,13 +647,13 @@ gtk_tree_model_sort_row_inserted (GtkTreeModel          *s_model,
   parent_level = level = SORT_LEVEL (tree_model_sort->root);
 
   g_return_if_fail (s_path != NULL || s_iter != NULL);
-  
+
   if (!s_path)
     {
       s_path = gtk_tree_model_get_path (s_model, s_iter);
       free_s_path = TRUE;
     }
-  
+
   if (!s_iter)
     gtk_tree_model_get_iter (s_model, &real_s_iter, s_path);
   else
@@ -491,10 +665,10 @@ gtk_tree_model_sort_row_inserted (GtkTreeModel          *s_model,
 
       /* the build level already put the inserted iter in the level,
         so no need to handle this signal anymore */
-      
+
       goto done_and_submit;
     }
-  
+
   /* find the parent level */
   while (i < gtk_tree_path_get_depth (s_path) - 1)
     {
@@ -513,7 +687,7 @@ gtk_tree_model_sort_row_inserted (GtkTreeModel          *s_model,
                     "before the parent was inserted.");
          goto done;
        }
-      
+
       elt = NULL;
       for (j = 0; j < level->array->len; j++)
        if (g_array_index (level->array, SortElt, j).offset == gtk_tree_path_get_indices (s_path)[i])
@@ -526,16 +700,16 @@ gtk_tree_model_sort_row_inserted (GtkTreeModel          *s_model,
 
       if (!elt->children)
        {
-         /* FIXME: emit has_child_toggled here? like the treeview? */
-
          GtkTreePath *tmppath;
          GtkTreeIter  tmpiter;
-         
-         tmppath = gtk_tree_model_sort_elt_get_path (level, elt);
+
+         tmpiter.stamp = tree_model_sort->stamp;
+         tmpiter.user_data = level;
+         tmpiter.user_data2 = elt;
+
+         tmppath = gtk_tree_model_get_path (GTK_TREE_MODEL (data), &tmpiter);
          if (tmppath)
            {
-             gtk_tree_model_get_iter (GTK_TREE_MODEL (data), &tmpiter,
-                                      tmppath);
              gtk_tree_model_row_has_child_toggled (GTK_TREE_MODEL (data),
                                                    tmppath,
                                                    &tmpiter);
@@ -550,36 +724,40 @@ gtk_tree_model_sort_row_inserted (GtkTreeModel          *s_model,
       parent_level = level;
       i++;
     }
-  
+
   if (!parent_level)
+    goto done;
+
+  if (level->ref_count == 0 && level != tree_model_sort->root)
     {
+      gtk_tree_model_sort_free_level (tree_model_sort, level);
       goto done;
     }
-  
+
   if (!gtk_tree_model_sort_insert_value (tree_model_sort,
                                         parent_level,
                                         s_path,
                                         &real_s_iter))
     goto done;
-  
+
  done_and_submit:
-  path = gtk_tree_model_sort_convert_child_path_to_path (tree_model_sort,
-                                                        s_path);
-  
+  path = gtk_real_tree_model_sort_convert_child_path_to_path (tree_model_sort,
+                                                             s_path,
+                                                             FALSE);
+
   if (!path)
     return;
 
   gtk_tree_model_sort_increment_stamp (tree_model_sort);
-  
+
   gtk_tree_model_get_iter (GTK_TREE_MODEL (data), &iter, path);
   gtk_tree_model_row_inserted (GTK_TREE_MODEL (data), path, &iter);
   gtk_tree_path_free (path);
 
  done:
-
   if (free_s_path)
     gtk_tree_path_free (s_path);
-  
+
   return;
 }
 
@@ -598,13 +776,14 @@ gtk_tree_model_sort_row_has_child_toggled (GtkTreeModel *s_model,
   path = gtk_real_tree_model_sort_convert_child_path_to_path (tree_model_sort, s_path, FALSE);
   if (path == NULL)
     return;
-  
+
   gtk_tree_model_get_iter (GTK_TREE_MODEL (data), &iter, path);
   gtk_tree_model_row_has_child_toggled (GTK_TREE_MODEL (data), path, &iter);
 
   gtk_tree_path_free (path);
 }
 
+/* FIXME: I still have doubts if this works */
 static void
 gtk_tree_model_sort_row_deleted (GtkTreeModel *s_model,
                                 GtkTreePath  *s_path,
@@ -617,7 +796,7 @@ gtk_tree_model_sort_row_deleted (GtkTreeModel *s_model,
   GtkTreeIter iter;
   gint offset;
   gint i;
-  
+
   g_return_if_fail (s_path != NULL);
 
   path = gtk_real_tree_model_sort_convert_child_path_to_path (tree_model_sort, s_path, FALSE);
@@ -630,38 +809,53 @@ gtk_tree_model_sort_row_deleted (GtkTreeModel *s_model,
   elt = SORT_ELT (iter.user_data2);
   offset = elt->offset;
 
+  /* we _need_ to emit ::row_deleted before we start unreffing the node
+   * itself. This is because of the row refs, which start unreffing nodes
+   * when we emit ::row_deleted
+   */
+  gtk_tree_model_row_deleted (GTK_TREE_MODEL (data), path);
+
+  gtk_tree_model_get_iter (GTK_TREE_MODEL (data), &iter, path);
+
   while (elt->ref_count > 0)
-    gtk_tree_model_sort_unref_node (GTK_TREE_MODEL (data), &iter);
+    gtk_tree_model_sort_real_unref_node (GTK_TREE_MODEL (data), &iter, FALSE);
 
   if (level->ref_count == 0)
     {
-      /* This will prune the level, so I can just emit the signal and not worry
-       * about cleaning this level up. */
+      /* This will prune the level, so I can just emit the signal and 
+       * not worry about cleaning this level up. 
+       * Careful, root level is not cleaned up in increment stamp.
+       */
       gtk_tree_model_sort_increment_stamp (tree_model_sort);
-      gtk_tree_model_row_deleted (GTK_TREE_MODEL (data), path);
-
       gtk_tree_path_free (path);
+      if (level == tree_model_sort->root)
+       {
+         gtk_tree_model_sort_free_level (tree_model_sort, 
+                                         tree_model_sort->root);
+         tree_model_sort->root = NULL;
+       }
       return;
     }
 
+  gtk_tree_model_sort_increment_stamp (tree_model_sort);
+
   /* Remove the row */
   for (i = 0; i < level->array->len; i++)
     if (elt->offset == g_array_index (level->array, SortElt, i).offset)
       break;
 
   g_array_remove_index (level->array, i);
-      
+
   /* update all offsets */
   for (i = 0; i < level->array->len; i++)
     {
       elt = & (g_array_index (level->array, SortElt, i));
       if (elt->offset > offset)
        elt->offset--;
+      if (elt->children)
+       elt->children->parent_elt = elt;
     }
 
-  gtk_tree_model_sort_increment_stamp (tree_model_sort);
-  gtk_tree_model_row_deleted (GTK_TREE_MODEL (data), path);
-
   gtk_tree_path_free (path);
 }
 
@@ -676,10 +870,10 @@ gtk_tree_model_sort_rows_reordered (GtkTreeModel *s_model,
   SortLevel *level;
   GtkTreeIter iter;
   gint *tmp_array;
-  int i;
+  int i, j;
   GtkTreePath *path;
   GtkTreeModelSort *tree_model_sort = GTK_TREE_MODEL_SORT (data);
-  
+
   g_return_if_fail (new_order != NULL);
 
   if (s_path == NULL || gtk_tree_path_get_indices (s_path) == NULL)
@@ -716,19 +910,26 @@ gtk_tree_model_sort_rows_reordered (GtkTreeModel *s_model,
 
   tmp_array = g_new (int, level->array->len);
   for (i = 0; i < level->array->len; i++)
-    tmp_array[new_order[i]] = g_array_index (level->array, SortElt, i).offset;
+    {
+      for (j = 0; j < level->array->len; j++)
+       {
+         if (g_array_index (level->array, SortElt, i).offset == new_order[j])
+           tmp_array[i] = j;
+       }
+    }
+
   for (i = 0; i < level->array->len; i++)
     g_array_index (level->array, SortElt, i).offset = tmp_array[i];
   g_free (tmp_array);
-  
-  if (tree_model_sort->sort_column_id == -1 &&
-      tree_model_sort->default_sort_func == (GtkTreeIterCompareFunc) 0x1)
+
+  if (tree_model_sort->sort_column_id == GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID &&
+      tree_model_sort->default_sort_func == NO_SORT_FUNC)
     {
-      
+
       gtk_tree_model_sort_sort_level (tree_model_sort, level,
                                      FALSE, FALSE);
       gtk_tree_model_sort_increment_stamp (tree_model_sort);
-      
+
       if (gtk_tree_path_get_depth (path))
        {
          gtk_tree_model_get_iter (GTK_TREE_MODEL (tree_model_sort),
@@ -748,10 +949,18 @@ gtk_tree_model_sort_rows_reordered (GtkTreeModel *s_model,
 }
 
 /* Fulfill our model requirements */
-static guint
+static GtkTreeModelFlags
 gtk_tree_model_sort_get_flags (GtkTreeModel *tree_model)
 {
+  GtkTreeModelFlags flags;
+
   g_return_val_if_fail (GTK_IS_TREE_MODEL_SORT (tree_model), 0);
+  g_return_val_if_fail (GTK_TREE_MODEL_SORT (tree_model)->child_model != NULL, 0);
+
+  flags = gtk_tree_model_get_flags (GTK_TREE_MODEL_SORT (tree_model)->child_model);
+
+  if ((flags & GTK_TREE_MODEL_LIST_ONLY) == GTK_TREE_MODEL_LIST_ONLY)
+    return GTK_TREE_MODEL_LIST_ONLY;
 
   return 0;
 }
@@ -806,7 +1015,7 @@ gtk_tree_model_sort_get_iter (GtkTreeModel *tree_model,
   for (i = 0; i < depth - 1; i++)
     {
       if ((level == NULL) ||
-         (level->array->len < indices[i]))
+         (indices[i] >= level->array->len))
        return FALSE;
 
       if (g_array_index (level->array, SortElt, indices[i]).children == NULL)
@@ -814,8 +1023,12 @@ gtk_tree_model_sort_get_iter (GtkTreeModel *tree_model,
       level = g_array_index (level->array, SortElt, indices[i]).children;
     }
 
-  if (level == NULL)
-    return FALSE;
+  if (!level || indices[i] >= level->array->len)
+    {
+      iter->stamp = 0;
+      return FALSE;
+    }
+
   iter->stamp = tree_model_sort->stamp;
   iter->user_data = level;
   iter->user_data2 = &g_array_index (level->array, SortElt, indices[depth - 1]);
@@ -927,7 +1140,7 @@ gtk_tree_model_sort_iter_children (GtkTreeModel *tree_model,
       iter->user_data = ((SortElt *)parent->user_data2)->children;
       iter->user_data2 = ((SortLevel *)iter->user_data)->array->data;
     }
-  
+
   return TRUE;
 }
 
@@ -1028,6 +1241,7 @@ gtk_tree_model_sort_ref_node (GtkTreeModel *tree_model,
                              GtkTreeIter  *iter)
 {
   GtkTreeModelSort *tree_model_sort = (GtkTreeModelSort *) tree_model;
+  GtkTreeIter child_iter;
   SortLevel *level;
   SortElt *elt;
 
@@ -1035,6 +1249,10 @@ gtk_tree_model_sort_ref_node (GtkTreeModel *tree_model,
   g_return_if_fail (GTK_TREE_MODEL_SORT (tree_model)->child_model != NULL);
   g_return_if_fail (GTK_TREE_MODEL_SORT (tree_model)->stamp == iter->stamp);
 
+  GET_CHILD_ITER (tree_model, &child_iter, iter);
+
+  gtk_tree_model_ref_node (GTK_TREE_MODEL_SORT (tree_model)->child_model, &child_iter);
+
   level = iter->user_data;
   elt = iter->user_data2;
 
@@ -1051,7 +1269,7 @@ gtk_tree_model_sort_ref_node (GtkTreeModel *tree_model,
            parent_elt->zero_ref_count--;
          else
            tree_model_sort->zero_ref_count--;
-         
+
          if (parent_level)
            {
              parent_elt = parent_level->parent_elt;
@@ -1063,10 +1281,12 @@ gtk_tree_model_sort_ref_node (GtkTreeModel *tree_model,
 }
 
 static void
-gtk_tree_model_sort_unref_node (GtkTreeModel *tree_model,
-                               GtkTreeIter  *iter)
+gtk_tree_model_sort_real_unref_node (GtkTreeModel *tree_model,
+                                    GtkTreeIter  *iter,
+                                    gboolean      propagate_unref)
 {
   GtkTreeModelSort *tree_model_sort = (GtkTreeModelSort *) tree_model;
+  GtkTreeIter child_iter;
   SortLevel *level;
   SortElt *elt;
 
@@ -1074,6 +1294,11 @@ gtk_tree_model_sort_unref_node (GtkTreeModel *tree_model,
   g_return_if_fail (GTK_TREE_MODEL_SORT (tree_model)->child_model != NULL);
   g_return_if_fail (GTK_TREE_MODEL_SORT (tree_model)->stamp == iter->stamp);
 
+  GET_CHILD_ITER (tree_model, &child_iter, iter);
+
+  if (propagate_unref)
+    gtk_tree_model_unref_node (GTK_TREE_MODEL_SORT (tree_model)->child_model, &child_iter);
+
   level = iter->user_data;
   elt = iter->user_data2;
 
@@ -1081,16 +1306,17 @@ gtk_tree_model_sort_unref_node (GtkTreeModel *tree_model,
 
   elt->ref_count--;
   level->ref_count--;
+
   if (level->ref_count == 0)
     {
       SortLevel *parent_level = level->parent_level;
       SortElt *parent_elt = level->parent_elt;
 
-      /* We were at zero -- time to decrement the zero_ref_count val */
+      /* We are at zero -- time to increment the zero_ref_count val */
       while (parent_level)
        {
          parent_elt->zero_ref_count++;
-         
+
          parent_elt = parent_level->parent_elt;
          parent_level = parent_level->parent_level;
        }
@@ -1098,6 +1324,13 @@ gtk_tree_model_sort_unref_node (GtkTreeModel *tree_model,
     }
 }
 
+static void
+gtk_tree_model_sort_unref_node (GtkTreeModel *tree_model,
+                               GtkTreeIter  *iter)
+{
+  gtk_tree_model_sort_real_unref_node (tree_model, iter, TRUE);
+}
+
 /* Sortable interface */
 static gboolean
 gtk_tree_model_sort_get_sort_column_id (GtkTreeSortable *sortable,
@@ -1108,14 +1341,15 @@ gtk_tree_model_sort_get_sort_column_id (GtkTreeSortable *sortable,
 
   g_return_val_if_fail (GTK_IS_TREE_MODEL_SORT (sortable), FALSE);
 
-  if (tree_model_sort->sort_column_id == GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID)
-    return FALSE;
-
   if (sort_column_id)
     *sort_column_id = tree_model_sort->sort_column_id;
   if (order)
     *order = tree_model_sort->order;
 
+  if (tree_model_sort->sort_column_id == GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID ||
+      tree_model_sort->sort_column_id == GTK_TREE_SORTABLE_UNSORTED_SORT_COLUMN_ID)
+    return FALSE;
+  
   return TRUE;
 }
 
@@ -1125,13 +1359,13 @@ gtk_tree_model_sort_set_sort_column_id (GtkTreeSortable *sortable,
                                        GtkSortType      order)
 {
   GtkTreeModelSort *tree_model_sort = (GtkTreeModelSort *)sortable;
-  
+
   g_return_if_fail (GTK_IS_TREE_MODEL_SORT (sortable));
-  
+
   if (sort_column_id != GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID)
     {
       GtkTreeDataSortHeader *header = NULL;
-      
+
       header = _gtk_tree_data_list_get_header (tree_model_sort->sort_list,
                                               sort_column_id);
 
@@ -1140,9 +1374,7 @@ gtk_tree_model_sort_set_sort_column_id (GtkTreeSortable *sortable,
       g_return_if_fail (header->func != NULL);
     }
   else
-    {
-      g_return_if_fail (tree_model_sort->default_sort_func != NULL);
-    }
+    g_return_if_fail (tree_model_sort->default_sort_func != NULL);
 
   if (tree_model_sort->sort_column_id == sort_column_id)
     {
@@ -1158,8 +1390,9 @@ gtk_tree_model_sort_set_sort_column_id (GtkTreeSortable *sortable,
   tree_model_sort->sort_column_id = sort_column_id;
   tree_model_sort->order = order;
 
-  gtk_tree_model_sort_sort (tree_model_sort);
   gtk_tree_sortable_sort_column_changed (sortable);
+
+  gtk_tree_model_sort_sort (tree_model_sort);
 }
 
 static void
@@ -1178,10 +1411,14 @@ gtk_tree_model_sort_set_sort_func (GtkTreeSortable        *sortable,
 
   for (list = tree_model_sort->sort_list; list; list = list->next)
     {
-      header = (GtkTreeDataSortHeader *) list->data;
-      
-      if (header->sort_column_id == sort_column_id)
-       break;
+      GtkTreeDataSortHeader *list_header;
+
+      list_header = (GtkTreeDataSortHeader*) list->data;
+      if (list_header->sort_column_id == sort_column_id)
+       {
+         header = list_header;
+         break;
+       }
     }
 
   if (header == NULL)
@@ -1193,11 +1430,19 @@ gtk_tree_model_sort_set_sort_func (GtkTreeSortable        *sortable,
     }
 
   if (header->destroy)
-    (* header->destroy) (header->data);
+    {
+      GtkDestroyNotify d = header->destroy;
+
+      header->destroy = NULL;
+      d (header->data);
+    }
 
   header->func = func;
   header->data = data;
   header->destroy = destroy;
+
+  if (tree_model_sort->sort_column_id == sort_column_id)
+    gtk_tree_model_sort_sort (tree_model_sort);
 }
 
 static void
@@ -1207,15 +1452,23 @@ gtk_tree_model_sort_set_default_sort_func (GtkTreeSortable        *sortable,
                                           GtkDestroyNotify        destroy)
 {
   GtkTreeModelSort *tree_model_sort = (GtkTreeModelSort *)sortable;
-  
+
   g_return_if_fail (GTK_IS_TREE_MODEL_SORT (sortable));
-  
+
   if (tree_model_sort->default_sort_destroy)
-    (* tree_model_sort->default_sort_destroy) (tree_model_sort->default_sort_data);
+    {
+      GtkDestroyNotify d = tree_model_sort->default_sort_destroy;
+
+      tree_model_sort->default_sort_destroy = NULL;
+      d (tree_model_sort->default_sort_data);
+    }
 
   tree_model_sort->default_sort_func = func;
   tree_model_sort->default_sort_data = data;
   tree_model_sort->default_sort_destroy = destroy;
+
+  if (tree_model_sort->sort_column_id == GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID)
+    gtk_tree_model_sort_sort (tree_model_sort);
 }
 
 static gboolean
@@ -1228,6 +1481,65 @@ gtk_tree_model_sort_has_default_sort_func (GtkTreeSortable *sortable)
   return (tree_model_sort->default_sort_func != NULL);
 }
 
+/* DragSource interface */
+static gboolean
+gtk_tree_model_sort_row_draggable (GtkTreeDragSource *drag_source,
+                                   GtkTreePath       *path)
+{
+  GtkTreeModelSort *tree_model_sort = (GtkTreeModelSort *)drag_source;
+  GtkTreePath *child_path;
+  gboolean draggable;
+
+  g_return_val_if_fail (GTK_IS_TREE_MODEL_SORT (drag_source), FALSE);
+  g_return_val_if_fail (path != NULL, FALSE);
+
+  child_path = gtk_tree_model_sort_convert_path_to_child_path (tree_model_sort,
+                                                               path);
+  draggable = gtk_tree_drag_source_row_draggable (GTK_TREE_DRAG_SOURCE (tree_model_sort->child_model), child_path);
+  gtk_tree_path_free (child_path);
+
+  return draggable;
+}
+
+static gboolean
+gtk_tree_model_sort_drag_data_get (GtkTreeDragSource *drag_source,
+                                   GtkTreePath       *path,
+                                   GtkSelectionData  *selection_data)
+{
+  GtkTreeModelSort *tree_model_sort = (GtkTreeModelSort *)drag_source;
+  GtkTreePath *child_path;
+  gboolean gotten;
+
+  g_return_val_if_fail (GTK_IS_TREE_MODEL_SORT (drag_source), FALSE);
+  g_return_val_if_fail (path != NULL, FALSE);
+
+  child_path = gtk_tree_model_sort_convert_path_to_child_path (tree_model_sort,
+                                                               path);
+  gotten = gtk_tree_drag_source_drag_data_get (GTK_TREE_DRAG_SOURCE (tree_model_sort->child_model), child_path, selection_data);
+  gtk_tree_path_free (child_path);
+
+  return gotten;
+}
+
+static gboolean
+gtk_tree_model_sort_drag_data_delete (GtkTreeDragSource *drag_source,
+                                      GtkTreePath       *path)
+{
+  GtkTreeModelSort *tree_model_sort = (GtkTreeModelSort *)drag_source;
+  GtkTreePath *child_path;
+  gboolean deleted;
+
+  g_return_val_if_fail (GTK_IS_TREE_MODEL_SORT (drag_source), FALSE);
+  g_return_val_if_fail (path != NULL, FALSE);
+
+  child_path = gtk_tree_model_sort_convert_path_to_child_path (tree_model_sort,
+                                                               path);
+  deleted = gtk_tree_drag_source_drag_data_delete (GTK_TREE_DRAG_SOURCE (tree_model_sort->child_model), child_path);
+  gtk_tree_path_free (child_path);
+
+  return deleted;
+}
+
 /* sorting code - private */
 static gint
 gtk_tree_model_sort_compare_func (gconstpointer a,
@@ -1242,12 +1554,10 @@ gtk_tree_model_sort_compare_func (gconstpointer a,
   GtkTreeIter iter_a, iter_b;
   gint retval;
 
-
   /* shortcut, if we've the same offsets here, they should be equal */
   if (sa->offset == sb->offset)
     return 0;
 
-  
   if (GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS (tree_model_sort))
     {
       iter_a = sa->elt->iter;
@@ -1319,15 +1629,17 @@ gtk_tree_model_sort_sort_level (GtkTreeModelSort *tree_model_sort,
 
   GtkTreeIter iter;
   GtkTreePath *path;
-  
+
   SortData data;
 
   g_return_if_fail (GTK_IS_TREE_MODEL_SORT (tree_model_sort));
   g_return_if_fail (level != NULL);
-  
+
   if (level->array->len < 1 && !((SortElt *)level->array->data)->children)
     return;
 
+  level->ref_count++;
+
   /* Set up data */
   data.tree_model_sort = tree_model_sort;
   if (level->parent_elt)
@@ -1338,7 +1650,7 @@ gtk_tree_model_sort_sort_level (GtkTreeModelSort *tree_model_sort,
     }
   else
     {
-      data.parent_path = gtk_tree_path_new_root ();
+      data.parent_path = gtk_tree_path_new_first ();
     }
   data.parent_path_depth = gtk_tree_path_get_depth (data.parent_path);
   data.parent_path_indices = gtk_tree_path_get_indices (data.parent_path);
@@ -1361,10 +1673,10 @@ gtk_tree_model_sort_sort_level (GtkTreeModelSort *tree_model_sort,
 
        header = _gtk_tree_data_list_get_header (tree_model_sort->sort_list,
                                                 tree_model_sort->sort_column_id);
-      
+
        g_return_if_fail (header != NULL);
        g_return_if_fail (header->func != NULL);
-      
+
        data.sort_func = header->func;
        data.sort_data = header->data;
       }
@@ -1377,19 +1689,14 @@ gtk_tree_model_sort_sort_level (GtkTreeModelSort *tree_model_sort,
        data.sort_data = tree_model_sort->default_sort_data;
       }
 
-  if (tree_model_sort->sort_column_id == GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID &&
-      tree_model_sort->default_sort_func == (GtkTreeIterCompareFunc) 0x1)
-    {
-      g_array_sort_with_data (sort_array,
-                             gtk_tree_model_sort_offset_compare_func,
-                             &data);
-    }
+  if (data.sort_func == NO_SORT_FUNC)
+    g_array_sort_with_data (sort_array,
+                           gtk_tree_model_sort_offset_compare_func,
+                           &data);
   else
-    {
-      g_array_sort_with_data (sort_array,
-                             gtk_tree_model_sort_compare_func,
-                             &data);
-    }
+    g_array_sort_with_data (sort_array,
+                           gtk_tree_model_sort_compare_func,
+                           &data);
 
   gtk_tree_path_free (data.parent_path);
 
@@ -1399,7 +1706,7 @@ gtk_tree_model_sort_sort_level (GtkTreeModelSort *tree_model_sort,
   for (i = 0; i < level->array->len; i++)
     {
       SortElt *elt;
-      
+
       elt = g_array_index (sort_array, SortTuple, i).elt;
       new_order[i] = g_array_index (sort_array, SortTuple, i).offset;
 
@@ -1413,22 +1720,9 @@ gtk_tree_model_sort_sort_level (GtkTreeModelSort *tree_model_sort,
   level->array = new_array;
   g_array_free (sort_array, TRUE);
 
-  /* recurse, if possible */
-  if (recurse)
-    {
-      for (i = 0; i < level->array->len; i++)
-       {
-         SortElt *elt = &g_array_index (level->array, SortElt, i);
-
-         if (elt->children)
-           gtk_tree_model_sort_sort_level (tree_model_sort,
-                                           elt->children,
-                                           TRUE, emit_reordered);
-       }
-    }
-
   if (emit_reordered)
     {
+      gtk_tree_model_sort_increment_stamp (tree_model_sort);
       if (level->parent_elt)
        {
          iter.stamp = tree_model_sort->stamp;
@@ -1451,19 +1745,33 @@ gtk_tree_model_sort_sort_level (GtkTreeModelSort *tree_model_sort,
 
       gtk_tree_path_free (path);
     }
-  
+
+  /* recurse, if possible */
+  if (recurse)
+    {
+      for (i = 0; i < level->array->len; i++)
+       {
+         SortElt *elt = &g_array_index (level->array, SortElt, i);
+
+         if (elt->children)
+           gtk_tree_model_sort_sort_level (tree_model_sort,
+                                           elt->children,
+                                           TRUE, emit_reordered);
+       }
+    }
+
   g_free (new_order);
-}    
+
+  level->ref_count--;
+}
 
 static void
 gtk_tree_model_sort_sort (GtkTreeModelSort *tree_model_sort)
 {
   g_return_if_fail (GTK_IS_TREE_MODEL_SORT (tree_model_sort));
-  
+
   if (!tree_model_sort->root)
-    {
-      return;
-    }
+    return;
 
   if (tree_model_sort->sort_column_id != GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID)
     {
@@ -1477,9 +1785,7 @@ gtk_tree_model_sort_sort (GtkTreeModelSort *tree_model_sort)
       g_return_if_fail (header->func != NULL);
     }
   else
-    {
-      g_return_if_fail (tree_model_sort->default_sort_func != NULL);
-    }
+    g_return_if_fail (tree_model_sort->default_sort_func != NULL);
 
   gtk_tree_model_sort_sort_level (tree_model_sort, tree_model_sort->root,
                                  TRUE, TRUE);
@@ -1490,9 +1796,9 @@ static gint
 gtk_tree_model_sort_level_find_insert (GtkTreeModelSort *tree_model_sort,
                                       SortLevel        *level,
                                       GtkTreeIter      *iter,
-                                      gboolean          skip_sort_elt)
+                                      gint             skip_index)
 {
-  gint middle;
+  gint start, middle, end;
   gint cmp;
   SortElt *tmp_elt;
   GtkTreeIter tmp_iter;
@@ -1500,44 +1806,74 @@ gtk_tree_model_sort_level_find_insert (GtkTreeModelSort *tree_model_sort,
   GtkTreeIterCompareFunc func;
   gpointer data;
 
-  if (tree_model_sort->sort_column_id == -1)
-    return level->array->len;
-  
-  {
-    GtkTreeDataSortHeader *header;
-
-    header = _gtk_tree_data_list_get_header (tree_model_sort->sort_list,
-                                            tree_model_sort->sort_column_id);
-    
-    g_return_val_if_fail (header != NULL, 0);
-    g_return_val_if_fail (header->func != NULL, 0);
-
-    func = header->func;
-    data = header->data;
-  }
-  
-  for (middle = 0; middle < level->array->len; middle++)
+  if (tree_model_sort->sort_column_id != GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID)
+    {
+      GtkTreeDataSortHeader *header;
+      
+      header = _gtk_tree_data_list_get_header (tree_model_sort->sort_list,
+                                              tree_model_sort->sort_column_id);
+      
+      g_return_val_if_fail (header != NULL, 0);
+      
+      func = header->func;
+      data = header->data;
+    }
+  else
     {
-      tmp_elt = &(g_array_index (level->array, SortElt, middle));
+      func = tree_model_sort->default_sort_func;
+      data = tree_model_sort->default_sort_data;
+      
+      g_return_val_if_fail (func != NO_SORT_FUNC, 0);
+    }
 
-      if (!skip_sort_elt && SORT_ELT (iter) == tmp_elt)
-       continue;
+  g_return_val_if_fail (func != NULL, 0);
 
-      get_child_iter_from_elt (tree_model_sort, &tmp_iter,
-                              level, tmp_elt);
+  start = 0;
+  end = level->array->len;
+  if (skip_index < 0)
+    skip_index = end;
+  else
+    end--;
 
+  if (start == end)
+    return 0;
+  
+  while (start != end)
+    {
+      middle = (start + end) / 2;
+
+      if (middle < skip_index)
+       tmp_elt = &(g_array_index (level->array, SortElt, middle));
+      else
+       tmp_elt = &(g_array_index (level->array, SortElt, middle + 1));
+  
+      if (!GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS (tree_model_sort))
+       {
+         GtkTreePath *path = gtk_tree_model_sort_elt_get_path (level, tmp_elt);
+         gtk_tree_model_get_iter (tree_model_sort->child_model,
+                                  &tmp_iter, path);
+         gtk_tree_path_free (path);
+       }
+      else
+       tmp_iter = tmp_elt->iter;
+  
       if (tree_model_sort->order == GTK_SORT_ASCENDING)
        cmp = (* func) (GTK_TREE_MODEL (tree_model_sort->child_model),
                        &tmp_iter, iter, data);
       else
        cmp = (* func) (GTK_TREE_MODEL (tree_model_sort->child_model),
                        iter, &tmp_iter, data);
-      
-      if (cmp > 0)
-       break;
+
+      if (cmp <= 0)
+       start = middle + 1;
+      else
+       end = middle;
     }
-  
-  return middle;
+
+  if (cmp <= 0)
+    return middle + 1;
+  else
+    return middle;
 }
 
 static gboolean
@@ -1547,12 +1883,12 @@ gtk_tree_model_sort_insert_value (GtkTreeModelSort *tree_model_sort,
                                  GtkTreeIter      *s_iter)
 {
   gint offset, index, i;
-  
+
   SortElt elt;
   SortElt *tmp_elt;
 
   offset = gtk_tree_path_get_indices (s_path)[gtk_tree_path_get_depth (s_path) - 1];
-  
+
   if (GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS (tree_model_sort))
     elt.iter = *s_iter;
   elt.offset = offset;
@@ -1560,31 +1896,25 @@ gtk_tree_model_sort_insert_value (GtkTreeModelSort *tree_model_sort,
   elt.ref_count = 0;
   elt.children = NULL;
 
-  if (GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS (tree_model_sort))
-    index = gtk_tree_model_sort_level_find_insert (tree_model_sort,
-                                                  level,
-                                                  &elt.iter,
-                                                  FALSE);
-  else
-    {
-      GtkTreeIter tmpiter;
-
-      gtk_tree_model_get_iter (tree_model_sort->child_model,
-                              &tmpiter, s_path);
+  /* update all larger offsets */
+  tmp_elt = SORT_ELT (level->array->data);
+  for (i = 0; i < level->array->len; i++, tmp_elt++)
+    if (tmp_elt->offset >= offset)
+      tmp_elt->offset++;
 
-      index = gtk_tree_model_sort_level_find_insert (tree_model_sort,
-                                                    level,
-                                                    &tmpiter,
-                                                    FALSE);
-    }
+  if (tree_model_sort->sort_column_id == GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID &&
+      tree_model_sort->default_sort_func == NO_SORT_FUNC)
+    index = offset;
+  else
+    index = gtk_tree_model_sort_level_find_insert (tree_model_sort,
+                                                   level, s_iter,
+                                                   -1);
 
   g_array_insert_vals (level->array, index, &elt, 1);
-
-  /* update all larger offsets */
   tmp_elt = SORT_ELT (level->array->data);
   for (i = 0; i < level->array->len; i++, tmp_elt++)
-    if ((tmp_elt->offset >= offset) && i != index)
-      tmp_elt->offset++;
+    if (tmp_elt->children)
+      tmp_elt->children->parent_elt = tmp_elt;
 
   return TRUE;
 }
@@ -1594,76 +1924,35 @@ static GtkTreePath *
 gtk_tree_model_sort_elt_get_path (SortLevel *level,
                                  SortElt *elt)
 {
-  gchar *str = NULL;
-  GList *i;
-  GList *offsets = NULL;
   SortLevel *walker = level;
   SortElt *walker2 = elt;
   GtkTreePath *path;
-  
+
   g_return_val_if_fail (level != NULL, NULL);
   g_return_val_if_fail (elt != NULL, NULL);
-  
-  while (walker && walker2)
+
+  path = gtk_tree_path_new ();
+
+  while (walker)
     {
-      offsets = g_list_prepend (offsets,
-                                g_strdup_printf ("%d", walker2->offset));
+      gtk_tree_path_prepend_index (path, walker2->offset);
+
       walker2 = walker->parent_elt;
       walker = walker->parent_level;
     }
-  
-  g_return_val_if_fail (g_list_length (offsets) > 0, NULL);
-  
-  for (i = offsets; i; i = i->next)
-    {
-      gchar *copy = str;
-      
-      if (str)
-        str = g_strconcat (copy, ":", i->data, NULL);
-      else
-        str = g_strdup (i->data);
-      
-      if (copy)
-        g_free (copy);
-      
-      g_free (i->data);
-    }
-  
-  g_list_free (offsets);
-  
-  path = gtk_tree_path_new_from_string (str);
-  g_free (str);
-  
-  return path;
-}
-
-static void
-get_child_iter_from_elt (GtkTreeModelSort *tree_model_sort,
-                        GtkTreeIter      *child_iter,
-                        SortLevel        *level,
-                        SortElt          *elt)
-{
-  if (GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS (tree_model_sort))
-    *child_iter = elt->iter;
-  else
-    {
-      GtkTreeIter tmp;
-      GtkTreePath *path = gtk_tree_model_sort_elt_get_path (level, elt);
-      gtk_tree_model_get_iter (GTK_TREE_MODEL (tree_model_sort), &tmp, path);
-      gtk_tree_path_free (path);
 
-      GET_CHILD_ITER (tree_model_sort, child_iter, &tmp);
-    }
+  return path;
 }
 
 /**
  * gtk_tree_model_sort_set_model:
  * @tree_model_sort: The #GtkTreeModelSort.
- * @child_model: A #GtkTreeModel, or NULL.
+ * @child_model: A #GtkTreeModel, or %NULL.
  *
- * Sets the model of @tree_model_sort to be @model.  If @model is NULL, then the
- * old model is unset.  The sort function is unset as a result of this call.
- * The model will be in an unsorted state until a sort function is set.
+ * Sets the model of @tree_model_sort to be @model.  If @model is %NULL, 
+ * then the old model is unset.  The sort function is unset as a result 
+ * of this call. The model will be in an unsorted state until a sort 
+ * function is set.
  **/
 static void
 gtk_tree_model_sort_set_model (GtkTreeModelSort *tree_model_sort,
@@ -1672,27 +1961,28 @@ gtk_tree_model_sort_set_model (GtkTreeModelSort *tree_model_sort,
   g_return_if_fail (GTK_IS_TREE_MODEL_SORT (tree_model_sort));
 
   if (child_model)
-    g_object_ref (G_OBJECT (child_model));
+    g_object_ref (child_model);
 
   if (tree_model_sort->child_model)
     {
-      g_signal_handler_disconnect (G_OBJECT (tree_model_sort->child_model),
+      g_signal_handler_disconnect (tree_model_sort->child_model,
                                    tree_model_sort->changed_id);
-      g_signal_handler_disconnect (G_OBJECT (tree_model_sort->child_model),
+      g_signal_handler_disconnect (tree_model_sort->child_model,
                                    tree_model_sort->inserted_id);
-      g_signal_handler_disconnect (G_OBJECT (tree_model_sort->child_model),
+      g_signal_handler_disconnect (tree_model_sort->child_model,
                                    tree_model_sort->has_child_toggled_id);
-      g_signal_handler_disconnect (G_OBJECT (tree_model_sort->child_model),
+      g_signal_handler_disconnect (tree_model_sort->child_model,
                                    tree_model_sort->deleted_id);
-      g_signal_handler_disconnect (G_OBJECT (tree_model_sort->child_model),
+      g_signal_handler_disconnect (tree_model_sort->child_model,
                                   tree_model_sort->reordered_id);
 
       /* reset our state */
-      gtk_tree_model_sort_free_level (tree_model_sort, tree_model_sort->root);
+      if (tree_model_sort->root)
+       gtk_tree_model_sort_free_level (tree_model_sort, tree_model_sort->root);
       tree_model_sort->root = NULL;
       _gtk_tree_data_list_header_free (tree_model_sort->sort_list);
       tree_model_sort->sort_list = NULL;
-      g_object_unref (G_OBJECT (tree_model_sort->child_model));
+      g_object_unref (tree_model_sort->child_model);
     }
 
   tree_model_sort->child_model = child_model;
@@ -1702,7 +1992,6 @@ gtk_tree_model_sort_set_model (GtkTreeModelSort *tree_model_sort,
       GType *types;
       gint i, n_columns;
 
-      g_object_ref (tree_model_sort->child_model);
       tree_model_sort->changed_id =
         g_signal_connect (child_model, "row_changed",
                           G_CALLBACK (gtk_tree_model_sort_row_changed),
@@ -1734,7 +2023,7 @@ gtk_tree_model_sort_set_model (GtkTreeModelSort *tree_model_sort,
       tree_model_sort->sort_list = _gtk_tree_data_list_header_new (n_columns, types);
       g_free (types);
 
-      tree_model_sort->default_sort_func = (GtkTreeIterCompareFunc)0x1;
+      tree_model_sort->default_sort_func = NO_SORT_FUNC;
       tree_model_sort->stamp = g_random_int ();
     }
 }
@@ -1776,7 +2065,7 @@ gtk_real_tree_model_sort_convert_child_path_to_path (GtkTreeModelSort *tree_mode
   if (tree_model_sort->root == NULL && build_levels)
     gtk_tree_model_sort_build_level (tree_model_sort, NULL, NULL);
   level = SORT_LEVEL (tree_model_sort->root);
-    
+
   for (i = 0; i < gtk_tree_path_get_depth (child_path); i++)
     {
       gint j;
@@ -1799,7 +2088,9 @@ gtk_real_tree_model_sort_convert_child_path_to_path (GtkTreeModelSort *tree_mode
            {
              gtk_tree_path_append_index (retval, j);
              if (g_array_index (level->array, SortElt, j).children == NULL && build_levels)
-               gtk_tree_model_sort_build_level (tree_model_sort, level, &g_array_index (level->array, SortElt, j));
+               {
+                 gtk_tree_model_sort_build_level (tree_model_sort, level, &g_array_index (level->array, SortElt, j));
+               }
              level = g_array_index (level->array, SortElt, j).children;
              found_child = TRUE;
              break;
@@ -1823,8 +2114,8 @@ gtk_real_tree_model_sort_convert_child_path_to_path (GtkTreeModelSort *tree_mode
  * 
  * Converts @child_path to a path relative to @tree_model_sort.  That is,
  * @child_path points to a path in the child model.  The returned path will
- * point to the same row in the sorted model.  If @child_path isn't a valid path
- * on the child model, then %NULL is returned.
+ * point to the same row in the sorted model.  If @child_path isn't a valid 
+ * path on the child model, then %NULL is returned.
  * 
  * Return value: A newly allocated #GtkTreePath, or %NULL
  **/
@@ -1878,11 +2169,13 @@ gtk_tree_model_sort_convert_child_iter_to_iter (GtkTreeModelSort *tree_model_sor
  * @tree_model_sort: A #GtkTreeModelSort
  * @sorted_path: A #GtkTreePath to convert
  * 
- * Converts @sort_path to a path on the child model of @tree_model_sort.  That
- * is, @sort_path points ot a location in @tree_model_sort.  The returned path
- * will point to the same location in the model not being sorted.  If @path does not point to a 
+ * Converts @sorted_path to a path on the child model of @tree_model_sort.  
+ * That is, @sorted_path points to a location in @tree_model_sort.  The 
+ * returned path will point to the same location in the model not being 
+ * sorted.  If @sorted_path does not point to a location in the child model, 
+ * %NULL is returned.
  * 
- * Return value: A newly allocated #GtkTreePath, or %NULLL
+ * Return value: A newly allocated #GtkTreePath, or %NULL
  **/
 GtkTreePath *
 gtk_tree_model_sort_convert_path_to_child_path (GtkTreeModelSort *tree_model_sort,
@@ -1905,19 +2198,28 @@ gtk_tree_model_sort_convert_path_to_child_path (GtkTreeModelSort *tree_model_sor
 
   for (i = 0; i < gtk_tree_path_get_depth (sorted_path); i++)
     {
+      gint count = sorted_indices[i];
+
       if ((level == NULL) ||
-         (level->array->len > sorted_indices[i]))
+         (level->array->len <= count))
        {
          gtk_tree_path_free (retval);
          return NULL;
        }
-      if (g_array_index (level->array, SortElt, sorted_indices[i]).children == NULL)
-       gtk_tree_model_sort_build_level (tree_model_sort, level, &g_array_index (level->array, SortElt, sorted_indices[i]));
+
+      if (g_array_index (level->array, SortElt, count).children == NULL)
+       gtk_tree_model_sort_build_level (tree_model_sort, level, &g_array_index (level->array, SortElt, count));
+
       if (level == NULL)
-       
-      gtk_tree_path_append_index (retval, g_array_index (level->array, SortElt, i).offset);
+        {
+         gtk_tree_path_free (retval);
+         break;
+       }
+
+      gtk_tree_path_append_index (retval, g_array_index (level->array, SortElt, count).offset);
+      level = g_array_index (level->array, SortElt, count).children;
     }
-  
   return retval;
 }
 
@@ -1927,7 +2229,7 @@ gtk_tree_model_sort_convert_path_to_child_path (GtkTreeModelSort *tree_model_sor
  * @child_iter: An uninitialized #GtkTreeIter
  * @sorted_iter: A valid #GtkTreeIter pointing to a row on @tree_model_sort.
  * 
- * Sets @child_iter to point to the row pointed to by *sorted_iter.
+ * Sets @child_iter to point to the row pointed to by @sorted_iter.
  **/
 void
 gtk_tree_model_sort_convert_iter_to_child_iter (GtkTreeModelSort *tree_model_sort,
@@ -1947,21 +2249,9 @@ gtk_tree_model_sort_convert_iter_to_child_iter (GtkTreeModelSort *tree_model_sor
   else
     {
       GtkTreePath *path;
-      SortElt *elt;
-      SortLevel *level;
-
-      path = gtk_tree_path_new ();
-      elt = SORT_ELT (sorted_iter->user_data2);
-      level = SORT_LEVEL (sorted_iter->user_data);
-
-      while (level)
-       {
-         gtk_tree_path_prepend_index (path, elt->offset);
-
-         elt = level->parent_elt;
-         level = level->parent_level;
-       }
 
+      path = gtk_tree_model_sort_elt_get_path (sorted_iter->user_data,
+                                              sorted_iter->user_data2);
       gtk_tree_model_get_iter (tree_model_sort->child_model, child_iter, path);
       gtk_tree_path_free (path);
     }
@@ -1981,7 +2271,7 @@ gtk_tree_model_sort_build_level (GtkTreeModelSort *tree_model_sort,
 
   if (parent_level == NULL)
     {
-      if (gtk_tree_model_get_iter_root (tree_model_sort->child_model, &iter) == FALSE)
+      if (gtk_tree_model_get_iter_first (tree_model_sort->child_model, &iter) == FALSE)
        return;
       length = gtk_tree_model_iter_n_children (tree_model_sort->child_model, NULL);
     }
@@ -2001,6 +2291,12 @@ gtk_tree_model_sort_build_level (GtkTreeModelSort *tree_model_sort,
                                        &iter,
                                        &child_parent_iter) == FALSE)
        return;
+
+      /* stamp may have changed */
+      gtk_tree_model_sort_convert_iter_to_child_iter (tree_model_sort,
+                                                     &child_parent_iter,
+                                                     &parent_iter);
+
       length = gtk_tree_model_iter_n_children (tree_model_sort->child_model, &child_parent_iter);
     }
 
@@ -2018,20 +2314,15 @@ gtk_tree_model_sort_build_level (GtkTreeModelSort *tree_model_sort,
     tree_model_sort->root = new_level;
 
   /* increase the count of zero ref_counts.*/
-  do
+  while (parent_level)
     {
-      if (parent_elt)
-       parent_elt->zero_ref_count++;
-      else
-       tree_model_sort->zero_ref_count++;
+      parent_elt->zero_ref_count++;
 
-      if (parent_level)
-       {
-         parent_elt = parent_level->parent_elt;
-         parent_level = parent_level->parent_level;
-       }
+      parent_elt = parent_level->parent_elt;
+      parent_level = parent_level->parent_level;
     }
-  while (parent_level);
+  if (new_level != tree_model_sort->root)
+    tree_model_sort->zero_ref_count++;
 
   for (i = 0; i < length; i++)
     {
@@ -2047,7 +2338,7 @@ gtk_tree_model_sort_build_level (GtkTreeModelSort *tree_model_sort,
          if (gtk_tree_model_iter_next (tree_model_sort->child_model, &iter) == FALSE &&
              i < length - 1)
            {
-             g_warning ("There is a discrepency between the sort model and the child model.");
+             g_warning ("There is a discrepancy between the sort model and the child model.");
              return;
            }
        }
@@ -2075,10 +2366,10 @@ gtk_tree_model_sort_free_level (GtkTreeModelSort *tree_model_sort,
       do
        {
          if (parent_elt)
-           parent_elt->zero_ref_count++;
+           parent_elt->zero_ref_count--;
          else
-           tree_model_sort->zero_ref_count++;
-         
+           tree_model_sort->zero_ref_count--;
+
          if (parent_level)
            {
              parent_elt = parent_level->parent_elt;
@@ -2092,25 +2383,29 @@ gtk_tree_model_sort_free_level (GtkTreeModelSort *tree_model_sort,
     {
       if (g_array_index (sort_level->array, SortElt, i).children)
        gtk_tree_model_sort_free_level (tree_model_sort, 
-                                       (SortLevel *)&g_array_index (sort_level->array, SortElt, i).children);
+                                       SORT_LEVEL(g_array_index (sort_level->array, SortElt, i).children));
     }
 
   if (sort_level->parent_elt)
-    {
-      sort_level->parent_elt->children = NULL;
-    }
+    sort_level->parent_elt->children = NULL;
   else
-    {
-      tree_model_sort->root = NULL;
-    }
+    tree_model_sort->root = NULL;
+
   g_array_free (sort_level->array, TRUE);
+  sort_level->array = NULL;
+
   g_free (sort_level);
+  sort_level = NULL;
 }
 
 static void
 gtk_tree_model_sort_increment_stamp (GtkTreeModelSort *tree_model_sort)
 {
-  while (tree_model_sort->stamp == 0) tree_model_sort->stamp++;
+  do
+    {
+      tree_model_sort->stamp++;
+    }
+  while (tree_model_sort->stamp == 0);
 
   gtk_tree_model_sort_clear_cache (tree_model_sort);
 }
@@ -2130,10 +2425,7 @@ gtk_tree_model_sort_clear_cache_helper (GtkTreeModelSort *tree_model_sort,
     }
 
   if (level->ref_count == 0 && level != tree_model_sort->root)
-    {
-      gtk_tree_model_sort_free_level (tree_model_sort, level);
-      return;
-    }
+    gtk_tree_model_sort_free_level (tree_model_sort, level);
 }
 
 /**
@@ -2141,7 +2433,9 @@ gtk_tree_model_sort_clear_cache_helper (GtkTreeModelSort *tree_model_sort,
  * @tree_model_sort: A #GtkTreeModelSort
  * 
  * This resets the default sort function to be in the 'unsorted' state.  That
- * is, it is in the same order as the child model.
+ * is, it is in the same order as the child model. It will re-sort the model
+ * to be in the same order as the child model only if the #GtkTreeModelSort
+ * is in 'unsorted' state.
  **/
 void
 gtk_tree_model_sort_reset_default_sort_func (GtkTreeModelSort *tree_model_sort)
@@ -2149,11 +2443,19 @@ gtk_tree_model_sort_reset_default_sort_func (GtkTreeModelSort *tree_model_sort)
   g_return_if_fail (GTK_IS_TREE_MODEL_SORT (tree_model_sort));
 
   if (tree_model_sort->default_sort_destroy)
-    (* tree_model_sort->default_sort_destroy) (tree_model_sort->default_sort_data);
+    {
+      GtkDestroyNotify d = tree_model_sort->default_sort_destroy;
 
-  tree_model_sort->default_sort_func = (GtkTreeIterCompareFunc) 0x1;
+      tree_model_sort->default_sort_destroy = NULL;
+      d (tree_model_sort->default_sort_data);
+    }
+
+  tree_model_sort->default_sort_func = NO_SORT_FUNC;
   tree_model_sort->default_sort_data = NULL;
   tree_model_sort->default_sort_destroy = NULL;
+
+  if (tree_model_sort->sort_column_id == GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID)
+    gtk_tree_model_sort_sort (tree_model_sort);
   tree_model_sort->sort_column_id = GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID;
 }
 
@@ -2176,3 +2478,56 @@ gtk_tree_model_sort_clear_cache (GtkTreeModelSort *tree_model_sort)
   if (tree_model_sort->zero_ref_count)
     gtk_tree_model_sort_clear_cache_helper (tree_model_sort, (SortLevel *)tree_model_sort->root);
 }
+
+static gboolean
+gtk_tree_model_sort_iter_is_valid_helper (GtkTreeIter *iter,
+                                         SortLevel   *level)
+{
+  gint i;
+
+  for (i = 0; i < level->array->len; i++)
+    {
+      SortElt *elt = &g_array_index (level->array, SortElt, i);
+
+      if (iter->user_data == level && iter->user_data2 == elt)
+       return TRUE;
+
+      if (elt->children)
+       if (gtk_tree_model_sort_iter_is_valid_helper (iter, elt->children))
+         return TRUE;
+    }
+
+  return FALSE;
+}
+
+/**
+ * gtk_tree_model_sort_iter_is_valid:
+ * @tree_model_sort: A #GtkTreeModelSort.
+ * @iter: A #GtkTreeIter.
+ *
+ * <warning><para>
+ * This function is slow. Only use it for debugging and/or testing purposes.
+ * </para></warning>
+ *
+ * Checks if the given iter is a valid iter for this #GtkTreeModelSort.
+ *
+ * Return value: %TRUE if the iter is valid, %FALSE if the iter is invalid.
+ *
+ * Since: 2.2
+ **/
+gboolean
+gtk_tree_model_sort_iter_is_valid (GtkTreeModelSort *tree_model_sort,
+                                   GtkTreeIter      *iter)
+{
+  g_return_val_if_fail (GTK_IS_TREE_MODEL_SORT (tree_model_sort), FALSE);
+  g_return_val_if_fail (iter != NULL, FALSE);
+
+  if (!VALID_ITER (iter, tree_model_sort))
+    return FALSE;
+
+  return gtk_tree_model_sort_iter_is_valid_helper (iter,
+                                                  tree_model_sort->root);
+}
+
+#define __GTK_TREE_MODEL_SORT_C__
+#include "gtkaliasdef.c"