]> Pileus Git - ~andy/gtk/blobdiff - gtk/gtktreemodelsort.c
remove the second ref command on the child_model, we only have to ref it
[~andy/gtk] / gtk / gtktreemodelsort.c
index ab02c2709aaf606defa84524bc31fdca498d6345..d3bc741ad6e358dcea77aad999efda2596e410b8 100644 (file)
@@ -1,5 +1,6 @@
 /* gtktreemodelsort.c
- * Copyright (C) 2000  Red Hat, Inc.,  Jonathan Blandford <jrb@redhat.com>
+ * Copyright (C) 2000,2001  Red Hat, Inc.,  Jonathan Blandford <jrb@redhat.com>
+ * Copyright (C) 2001,2002  Kristian Rietveld <kris@gtk.org>
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * iter->user_data2 = SortElt
  */
 
+/* WARNING: this code is dangerous, can cause sleepless nights,
+ * can cause your dog to die among other bad things
+ *
+ * we warned you and we're not liable for any head injuries.
+ */
+
+#include <string.h>
+
 #include "gtktreemodelsort.h"
 #include "gtktreesortable.h"
 #include "gtktreestore.h"
-#include "gtksignal.h"
 #include "gtktreedatalist.h"
-#include <string.h>
+#include "gtkintl.h"
 
 typedef struct _SortElt SortElt;
 typedef struct _SortLevel SortLevel;
@@ -62,54 +70,55 @@ struct _SortLevel
 struct _SortData
 {
   GtkTreeModelSort *tree_model_sort;
-  GtkTreePath *parent_a;
-  GtkTreePath *parent_b;
+  GtkTreePath *parent_path;
+  gint parent_path_depth;
+  gint *parent_path_indices;
+  GtkTreeIterCompareFunc sort_func;
+  gpointer sort_data;
 };
 
 struct _SortTuple
 {
   SortElt   *elt;
-  SortLevel *level;
-  SortLevel *children;
-  gint       offset;  
+  gint       offset;
 };
 
+/* Properties */
+enum {
+  PROP_0,
+  /* Construct args */
+  PROP_MODEL
+};
+
+
+
 #define GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS(tree_model_sort) \
        (((GtkTreeModelSort *)tree_model_sort)->child_flags&GTK_TREE_MODEL_ITERS_PERSIST)
 #define SORT_ELT(sort_elt) ((SortElt *)sort_elt)
 #define SORT_LEVEL(sort_level) ((SortLevel *)sort_level)
 
-//#define GET_CHILD_ITER(tree_model_sort,child_iter,sort_iter) ((((GtkTreeModelSort *)tree_model_sort)->child_flags&GTK_TREE_MODEL_ITERS_PERSIST)?((*child_iter)=SORT_ELT(sort_iter->user_data)->iter):gtk_tree_model_sort_convert_iter_to_child_iter (GTK_TREE_MODEL_SORT(tree_model_sort),sort_iter,child_iter))
-
 #define GET_CHILD_ITER(tree_model_sort,child_iter,sort_iter) gtk_tree_model_sort_convert_iter_to_child_iter(GTK_TREE_MODEL_SORT (tree_model_sort), child_iter, sort_iter);
 
+#define NO_SORT_FUNC ((GtkTreeIterCompareFunc) 0x1)
+
+#define VALID_ITER(iter, tree_model_sort) (iter != NULL && iter->user_data != NULL && iter->user_data2 != NULL && tree_model_sort->stamp == iter->stamp)
+
+/* general (object/interface init, etc) */
 static void gtk_tree_model_sort_init                  (GtkTreeModelSort      *tree_model_sort);
 static void gtk_tree_model_sort_class_init            (GtkTreeModelSortClass *tree_model_sort_class);
 static void gtk_tree_model_sort_tree_model_init       (GtkTreeModelIface     *iface);
 static void gtk_tree_model_sort_tree_sortable_init    (GtkTreeSortableIface  *iface);
 static void gtk_tree_model_sort_finalize              (GObject               *object);
-static void gtk_tree_model_sort_row_changed           (GtkTreeModel          *model,
-                                                      GtkTreePath           *start_path,
-                                                      GtkTreeIter           *start_iter,
-                                                      gpointer               data);
-static void gtk_tree_model_sort_row_inserted          (GtkTreeModel          *model,
-                                                      GtkTreePath           *path,
-                                                      GtkTreeIter           *iter,
-                                                      gpointer               data);
-static void gtk_tree_model_sort_row_has_child_toggled (GtkTreeModel          *model,
-                                                      GtkTreePath           *path,
-                                                      GtkTreeIter           *iter,
-                                                      gpointer               data);
-static void gtk_tree_model_sort_row_deleted           (GtkTreeModel          *model,
-                                                      GtkTreePath           *path,
-                                                      gpointer               data);
-static void gtk_tree_model_sort_rows_reordered        (GtkTreeModel          *s_model,
-                                                      GtkTreePath           *s_path,
-                                                      GtkTreeIter           *s_iter,
-                                                      gint                  *new_order,
-                                                      gpointer               data);
-static void gtk_tree_model_sort_destroy               (GtkObject             *gobject);
-
+static void gtk_tree_model_sort_set_property          (GObject               *object,
+                                                      guint                  prop_id,
+                                                      const GValue          *value,
+                                                      GParamSpec            *pspec);
+static void gtk_tree_model_sort_get_property          (GObject               *object,
+                                                      guint                  prop_id,
+                                                      GValue                *value,
+                                                      GParamSpec            *pspec);
+
+/* our signal handlers */
 static void gtk_tree_model_sort_row_changed           (GtkTreeModel          *model,
                                                       GtkTreePath           *start_path,
                                                       GtkTreeIter           *start_iter,
@@ -132,7 +141,7 @@ static void gtk_tree_model_sort_rows_reordered        (GtkTreeModel          *s_
                                                       gpointer               data);
 
 /* TreeModel interface */
-static guint        gtk_tree_model_sort_get_flags          (GtkTreeModel          *tree_model);
+static GtkTreeModelFlags gtk_tree_model_sort_get_flags     (GtkTreeModel          *tree_model);
 static gint         gtk_tree_model_sort_get_n_columns      (GtkTreeModel          *tree_model);
 static GType        gtk_tree_model_sort_get_column_type    (GtkTreeModel          *tree_model,
                                                             gint                   index);
@@ -163,66 +172,65 @@ static gboolean     gtk_tree_model_sort_iter_parent        (GtkTreeModel
                                                             GtkTreeIter           *child);
 static void         gtk_tree_model_sort_ref_node           (GtkTreeModel          *tree_model,
                                                             GtkTreeIter           *iter);
+static void         gtk_tree_model_sort_real_unref_node    (GtkTreeModel          *tree_model,
+                                                            GtkTreeIter           *iter,
+                                                           gboolean               propagate_unref);
 static void         gtk_tree_model_sort_unref_node         (GtkTreeModel          *tree_model,
                                                             GtkTreeIter           *iter);
 
 /* TreeSortable interface */
-static gboolean     gtk_tree_model_sort_get_sort_column_id (GtkTreeSortable        *sortable,
-                                                            gint                   *sort_column_id,
-                                                            GtkSortType            *order);
-static void         gtk_tree_model_sort_set_sort_column_id (GtkTreeSortable        *sortable,
-                                                            gint                    sort_column_id,
-                                                            GtkSortType        order);
-static void         gtk_tree_model_sort_set_sort_func      (GtkTreeSortable        *sortable,
-                                                            gint                    sort_column_id,
-                                                            GtkTreeIterCompareFunc  func,
-                                                            gpointer                data,
-                                                            GtkDestroyNotify        destroy);
+static gboolean     gtk_tree_model_sort_get_sort_column_id    (GtkTreeSortable        *sortable,
+                                                              gint                   *sort_column_id,
+                                                              GtkSortType            *order);
+static void         gtk_tree_model_sort_set_sort_column_id    (GtkTreeSortable        *sortable,
+                                                              gint                    sort_column_id,
+                                                              GtkSortType        order);
+static void         gtk_tree_model_sort_set_sort_func         (GtkTreeSortable        *sortable,
+                                                              gint                    sort_column_id,
+                                                              GtkTreeIterCompareFunc  func,
+                                                              gpointer                data,
+                                                              GtkDestroyNotify        destroy);
 static void         gtk_tree_model_sort_set_default_sort_func (GtkTreeSortable        *sortable,
                                                               GtkTreeIterCompareFunc  func,
                                                               gpointer                data,
                                                               GtkDestroyNotify        destroy);
 static gboolean     gtk_tree_model_sort_has_default_sort_func (GtkTreeSortable     *sortable);
 
-/* Private functions */
-static void         gtk_tree_model_sort_build_level     (GtkTreeModelSort *tree_model_sort,
-                                                        SortLevel        *parent_level,
-                                                        SortElt          *parent_elt);
-static void         gtk_tree_model_sort_free_level      (GtkTreeModelSort *tree_model_sort,
-                                                        SortLevel        *sort_level);
-static void         gtk_tree_model_sort_increment_stamp (GtkTreeModelSort *tree_model_sort);
-static void         gtk_tree_model_sort_sort_level      (GtkTreeModelSort *tree_model_sort,
-                                                        SortLevel        *level,
-                                                        gboolean          recurse,
-                                                        gboolean          emit_reordered);
-static void         gtk_tree_model_sort_sort            (GtkTreeModelSort *tree_model_sort);
-
+/* Private functions (sort funcs, level handling and other utils) */
+static void         gtk_tree_model_sort_build_level       (GtkTreeModelSort *tree_model_sort,
+                                                          SortLevel        *parent_level,
+                                                          SortElt          *parent_elt);
+static void         gtk_tree_model_sort_free_level        (GtkTreeModelSort *tree_model_sort,
+                                                          SortLevel        *sort_level);
+static void         gtk_tree_model_sort_increment_stamp   (GtkTreeModelSort *tree_model_sort);
+static void         gtk_tree_model_sort_sort_level        (GtkTreeModelSort *tree_model_sort,
+                                                          SortLevel        *level,
+                                                          gboolean          recurse,
+                                                          gboolean          emit_reordered);
+static void         gtk_tree_model_sort_sort              (GtkTreeModelSort *tree_model_sort);
 static gint         gtk_tree_model_sort_level_find_insert (GtkTreeModelSort *tree_model_sort,
                                                           SortLevel        *level,
                                                           GtkTreeIter      *iter,
                                                           gboolean          skip_sort_elt);
 static gboolean     gtk_tree_model_sort_insert_value      (GtkTreeModelSort *tree_model_sort,
+                                                          SortLevel        *level,
                                                           GtkTreePath      *s_path,
                                                           GtkTreeIter      *s_iter);
-static GtkTreePath *gtk_tree_model_sort_elt_get_path    (SortLevel        *level,
-                                                        SortElt          *elt);
-static void         get_child_iter_from_elt_no_cache    (GtkTreeModelSort *tree_model_sort,
-                                                        GtkTreeIter      *child_iter,
-                                                        SortLevel        *level,
-                                                        SortElt          *elt);
-static void         get_child_iter_from_elt             (GtkTreeModelSort *tree_model_sort,
-                                                        GtkTreeIter      *child_iter,
-                                                        SortLevel        *level,
-                                                        SortElt          *elt);
-static void         gtk_tree_model_sort_set_model       (GtkTreeModelSort *tree_model_sort,
-                                                        GtkTreeModel     *child_model);
+static GtkTreePath *gtk_tree_model_sort_elt_get_path      (SortLevel        *level,
+                                                          SortElt          *elt);
+static void         gtk_tree_model_sort_set_model         (GtkTreeModelSort *tree_model_sort,
+                                                          GtkTreeModel     *child_model);
+static GtkTreePath *gtk_real_tree_model_sort_convert_child_path_to_path (GtkTreeModelSort *tree_model_sort,
+                                                                        GtkTreePath      *child_path,
+                                                                        gboolean          build_levels);
 
+static GObjectClass *parent_class = NULL;
 
 GType
 gtk_tree_model_sort_get_type (void)
 {
   static GType tree_model_sort_type = 0;
-  
+
   if (!tree_model_sort_type)
     {
       static const GTypeInfo tree_model_sort_info =
@@ -252,13 +260,14 @@ gtk_tree_model_sort_get_type (void)
         NULL
       };
 
-      tree_model_sort_type = g_type_register_static (G_TYPE_OBJECT,
-                                                    "GtkTreeModelSort",
-                                                    &tree_model_sort_info, 0);
+      tree_model_sort_type =
+       g_type_register_static (G_TYPE_OBJECT, "GtkTreeModelSort",
+                               &tree_model_sort_info, 0);
+
       g_type_add_interface_static (tree_model_sort_type,
                                    GTK_TYPE_TREE_MODEL,
                                    &tree_model_info);
-      
+
       g_type_add_interface_static (tree_model_sort_type,
                                    GTK_TYPE_TREE_SORTABLE,
                                    &sortable_info);
@@ -281,13 +290,23 @@ static void
 gtk_tree_model_sort_class_init (GtkTreeModelSortClass *class)
 {
   GObjectClass *object_class;
-  GtkObjectClass *gobject_class;
 
   object_class = (GObjectClass *) class;
-  gobject_class = (GtkObjectClass *) class;
+  parent_class = g_type_class_peek_parent (class);
+
+  object_class->set_property = gtk_tree_model_sort_set_property;
+  object_class->get_property = gtk_tree_model_sort_get_property;
 
   object_class->finalize = gtk_tree_model_sort_finalize;
-  gobject_class->destroy = gtk_tree_model_sort_destroy;
+
+  /* Properties */
+  g_object_class_install_property (object_class,
+                                   PROP_MODEL,
+                                   g_param_spec_object ("model",
+                                                       _("TreeModelSort Model"),
+                                                       _("The model for the TreeModelSort to sort"),
+                                                       GTK_TYPE_TREE_MODEL,
+                                                       G_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY));
 }
 
 static void
@@ -334,7 +353,7 @@ gtk_tree_model_sort_new_with_model (GtkTreeModel      *child_model)
 
   g_return_val_if_fail (GTK_IS_TREE_MODEL (child_model), NULL);
 
-  retval = GTK_TREE_MODEL (g_object_new (gtk_tree_model_sort_get_type (), NULL));
+  retval = g_object_new (gtk_tree_model_sort_get_type (), NULL);
 
   gtk_tree_model_sort_set_model (GTK_TREE_MODEL_SORT (retval), child_model);
 
@@ -347,6 +366,8 @@ gtk_tree_model_sort_finalize (GObject *object)
 {
   GtkTreeModelSort *tree_model_sort = (GtkTreeModelSort *) object;
 
+  gtk_tree_model_sort_set_model (tree_model_sort, NULL);
+
   if (tree_model_sort->root)
     gtk_tree_model_sort_free_level (tree_model_sort, tree_model_sort->root);
 
@@ -355,16 +376,47 @@ gtk_tree_model_sort_finalize (GObject *object)
       _gtk_tree_data_list_header_free (tree_model_sort->sort_list);
       tree_model_sort->sort_list = NULL;
     }
+
+  /* must chain up */
+  parent_class->finalize (object);
 }
 
-/* GtkObject callbacks */
 static void
-gtk_tree_model_sort_destroy (GtkObject *gobject)
+gtk_tree_model_sort_set_property (GObject      *object,
+                                 guint         prop_id,
+                                 const GValue *value,
+                                 GParamSpec   *pspec)
 {
-  GtkTreeModelSort *tree_model_sort = (GtkTreeModelSort *) gobject;
+  GtkTreeModelSort *tree_model_sort = GTK_TREE_MODEL_SORT (object);
 
-  if (tree_model_sort->child_model)
-    gtk_tree_model_sort_set_model (tree_model_sort, NULL);
+  switch (prop_id)
+    {
+    case PROP_MODEL:
+      gtk_tree_model_sort_set_model (tree_model_sort, g_value_get_object (value));
+      break;
+    default:
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
+      break;
+    }
+}
+
+static void
+gtk_tree_model_sort_get_property (GObject    *object,
+                                 guint       prop_id,
+                                 GValue     *value,
+                                 GParamSpec *pspec)
+{
+  GtkTreeModelSort *tree_model_sort = GTK_TREE_MODEL_SORT (object);
+
+  switch (prop_id)
+    {
+    case PROP_MODEL:
+      g_value_set_object (value, gtk_tree_model_sort_get_model(tree_model_sort));
+      break;
+    default:
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
+      break;
+    }
 }
 
 static void
@@ -374,18 +426,18 @@ gtk_tree_model_sort_row_changed (GtkTreeModel *s_model,
                                 gpointer      data)
 {
   GtkTreeModelSort *tree_model_sort = GTK_TREE_MODEL_SORT (data);
-  GtkTreePath *path;
+  GtkTreePath *path = NULL;
   GtkTreeIter iter;
   GtkTreeIter tmpiter;
-  
+
   SortElt tmp;
   SortElt *elt;
   SortLevel *level;
 
-  gboolean free_s_path;
+  gboolean free_s_path = FALSE;
+
+  gint offset, index = 0, old_index, i;
 
-  gint offset, index, i;
-  
   g_return_if_fail (start_s_path != NULL || start_s_iter != NULL);
 
   if (!start_s_path)
@@ -394,8 +446,9 @@ gtk_tree_model_sort_row_changed (GtkTreeModel *s_model,
       start_s_path = gtk_tree_model_get_path (s_model, start_s_iter);
     }
 
-  path = gtk_tree_model_sort_convert_child_path_to_path (tree_model_sort,
-                                                        start_s_path);
+  path = gtk_real_tree_model_sort_convert_child_path_to_path (tree_model_sort,
+                                                             start_s_path,
+                                                             FALSE);
   if (!path)
     {
       if (free_s_path)
@@ -404,34 +457,41 @@ gtk_tree_model_sort_row_changed (GtkTreeModel *s_model,
     }
 
   gtk_tree_model_get_iter (GTK_TREE_MODEL (data), &iter, path);
-  
+
   level = iter.user_data;
   elt = iter.user_data2;
-  
-  if (level->array->len < 2)
+
+  if (level->array->len < 2 ||
+      (tree_model_sort->sort_column_id == GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID &&
+       tree_model_sort->default_sort_func == NO_SORT_FUNC))
     {
       if (free_s_path)
        gtk_tree_path_free (start_s_path);
 
       gtk_tree_model_row_changed (GTK_TREE_MODEL (data), path, &iter);
-      
+
       gtk_tree_path_free (path);
-      
+
       return;
     }
 
   if (!GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS (tree_model_sort))
-    get_child_iter_from_elt (tree_model_sort, &tmpiter, level, elt);
-  
+    {
+      gtk_tree_model_get_iter (tree_model_sort->child_model,
+                              &tmpiter, start_s_path);
+    }
+
   offset = elt->offset;
 
   for (i = 0; i < level->array->len; i++)
     if (elt->offset == g_array_index (level->array, SortElt, i).offset)
       index = i;
-  
+
   memcpy (&tmp, elt, sizeof (SortElt));
   g_array_remove_index (level->array, index);
-  
+
+  old_index = index;
+
   if (GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS (tree_model_sort))
     index = gtk_tree_model_sort_level_find_insert (tree_model_sort,
                                                   level,
@@ -444,9 +504,77 @@ gtk_tree_model_sort_row_changed (GtkTreeModel *s_model,
                                                   TRUE);
 
   g_array_insert_val (level->array, index, tmp);
+
+  for (i = 0; i < level->array->len; i++)
+    if (g_array_index (level->array, SortElt, i).children)
+      g_array_index (level->array, SortElt, i).children->parent_elt = &g_array_index (level->array, SortElt, i);
+
+  gtk_tree_path_up (path);
+  gtk_tree_path_append_index (path, index);
+
+  gtk_tree_model_sort_increment_stamp (tree_model_sort);
+
+  /* if the item moved, then emit rows_reordered */
+  if (old_index != index)
+    {
+      gint *new_order;
+      gint j;
+
+      GtkTreePath *tmppath;
+
+      new_order = g_new (gint, level->array->len);
+
+      for (j = 0; j < level->array->len; j++)
+        {
+         if (index > old_index)
+           {
+             if (j == index)
+               new_order[j] = old_index;
+             else if (j >= old_index && j < index)
+               new_order[j] = j + 1;
+             else
+               new_order[j] = j;
+           }
+         else if (index < old_index)
+           {
+             if (j == index)
+               new_order[j] = old_index;
+             else if (j > index && j <= old_index)
+               new_order[j] = j - 1;
+             else
+               new_order[j] = j;
+           }
+         /* else? shouldn't really happen */
+       }
+
+      if (level->parent_elt)
+        {
+         iter.stamp = tree_model_sort->stamp;
+         iter.user_data = level->parent_level;
+         iter.user_data2 = level->parent_elt;
+
+         tmppath = gtk_tree_model_get_path (GTK_TREE_MODEL (tree_model_sort), &iter);
+
+         gtk_tree_model_rows_reordered (GTK_TREE_MODEL (tree_model_sort),
+                                        tmppath, &iter, new_order);
+       }
+      else
+        {
+         /* toplevel */
+         tmppath = gtk_tree_path_new ();
+
+          gtk_tree_model_rows_reordered (GTK_TREE_MODEL (tree_model_sort), tmppath,
+                                        NULL, new_order);
+       }
+
+      gtk_tree_path_free (tmppath);
+      g_free (new_order);
+    }
+
+  /* emit row_changed signal (at new location) */
+  gtk_tree_model_get_iter (GTK_TREE_MODEL (data), &iter, path);
   gtk_tree_model_row_changed (GTK_TREE_MODEL (data), path, &iter);
-  /* FIXME: update stamp?? */
-  
+
   gtk_tree_path_free (path);
   if (free_s_path)
     gtk_tree_path_free (start_s_path);
@@ -461,46 +589,125 @@ gtk_tree_model_sort_row_inserted (GtkTreeModel          *s_model,
   GtkTreeModelSort *tree_model_sort = GTK_TREE_MODEL_SORT (data);
   GtkTreePath *path;
   GtkTreeIter iter;
+  GtkTreeIter real_s_iter;
+
+  gint i = 0;
+
+  gboolean free_s_path = FALSE;
+
+  SortElt *elt;
+  SortLevel *level;
+  SortLevel *parent_level = NULL;
+
+  parent_level = level = SORT_LEVEL (tree_model_sort->root);
 
   g_return_if_fail (s_path != NULL || s_iter != NULL);
-  
-  if (!s_path)
-    s_path = gtk_tree_model_get_path (s_model, s_iter);
 
-  if (!GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS (tree_model_sort)
-      && tree_model_sort->root)
+  if (!s_path)
     {
-      gtk_tree_model_sort_free_level (tree_model_sort,
-                                     SORT_LEVEL (tree_model_sort->root));
-      tree_model_sort->root = NULL;
+      s_path = gtk_tree_model_get_path (s_model, s_iter);
+      free_s_path = TRUE;
     }
+
+  if (!s_iter)
+    gtk_tree_model_get_iter (s_model, &real_s_iter, s_path);
   else
+    real_s_iter = *s_iter;
+
+  if (!tree_model_sort->root)
     {
-      GtkTreeIter real_s_iter;
+      gtk_tree_model_sort_build_level (tree_model_sort, NULL, NULL);
 
-      if (!s_iter)
-       gtk_tree_model_get_iter (s_model, &real_s_iter, s_path);
-      else
-       real_s_iter = (* s_iter);
+      /* the build level already put the inserted iter in the level,
+        so no need to handle this signal anymore */
 
-      if (!gtk_tree_model_sort_insert_value (tree_model_sort,
-                                            s_path, &real_s_iter))
-       return;
+      goto done_and_submit;
     }
 
-  if (!tree_model_sort->root)
-    gtk_tree_model_sort_build_level (tree_model_sort, NULL, NULL);
+  /* find the parent level */
+  while (i < gtk_tree_path_get_depth (s_path) - 1)
+    {
+      gint j;
+
+      if (!level)
+       {
+         /* level not yet build, we won't cover this signal */
+         goto done;
+       }
+
+      if (level->array->len < gtk_tree_path_get_indices (s_path)[i])
+       {
+         g_warning ("A node was inserted with a parent that's not in the tree.\n"
+                    "This possibly means that a GtkTreeModel inserted a child node\n"
+                    "before the parent was inserted.");
+         goto done;
+       }
+
+      elt = NULL;
+      for (j = 0; j < level->array->len; j++)
+       if (g_array_index (level->array, SortElt, j).offset == gtk_tree_path_get_indices (s_path)[i])
+         {
+           elt = &g_array_index (level->array, SortElt, j);
+           break;
+         }
+
+      g_return_if_fail (elt != NULL);
+
+      if (!elt->children)
+       {
+         GtkTreePath *tmppath;
+         GtkTreeIter  tmpiter;
+
+         tmpiter.stamp = tree_model_sort->stamp;
+         tmpiter.user_data = level;
+         tmpiter.user_data2 = elt;
+
+         tmppath = gtk_tree_model_get_path (GTK_TREE_MODEL (data), &tmpiter);
+         if (tmppath)
+           {
+             gtk_tree_model_row_has_child_toggled (GTK_TREE_MODEL (data),
+                                                   tmppath,
+                                                   &tmpiter);
+             gtk_tree_path_free (tmppath);
+           }
+
+         /* not covering this signal */
+         goto done;
+       }
+
+      level = elt->children;
+      parent_level = level;
+      i++;
+    }
+
+  if (!parent_level)
+    goto done;
+
+  if (!gtk_tree_model_sort_insert_value (tree_model_sort,
+                                        parent_level,
+                                        s_path,
+                                        &real_s_iter))
+    goto done;
+
+ done_and_submit:
+  path = gtk_real_tree_model_sort_convert_child_path_to_path (tree_model_sort,
+                                                             s_path,
+                                                             FALSE);
 
-  path = gtk_tree_model_sort_convert_child_path_to_path (tree_model_sort,
-                                                        s_path);
-  
   if (!path)
     return;
 
   gtk_tree_model_sort_increment_stamp (tree_model_sort);
+
   gtk_tree_model_get_iter (GTK_TREE_MODEL (data), &iter, path);
   gtk_tree_model_row_inserted (GTK_TREE_MODEL (data), path, &iter);
   gtk_tree_path_free (path);
+
+ done:
+  if (free_s_path)
+    gtk_tree_path_free (s_path);
+
+  return;
 }
 
 static void
@@ -512,108 +719,84 @@ gtk_tree_model_sort_row_has_child_toggled (GtkTreeModel *s_model,
   GtkTreeModelSort *tree_model_sort = GTK_TREE_MODEL_SORT (data);
   GtkTreePath *path;
   GtkTreeIter iter;
-  gboolean free_s_path = FALSE;
 
-  g_return_if_fail (s_path != NULL || s_iter != NULL);
+  g_return_if_fail (s_path != NULL && s_iter != NULL);
 
-  /* we don't handle signals which we don't cover */
-  if (!tree_model_sort->root)
+  path = gtk_real_tree_model_sort_convert_child_path_to_path (tree_model_sort, s_path, FALSE);
+  if (path == NULL)
     return;
 
-  if (!GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS (tree_model_sort))
-    {
-      gtk_tree_model_sort_free_level (tree_model_sort,
-                                     SORT_LEVEL (tree_model_sort->root));
-      tree_model_sort->root = NULL;
-    }
-
-  if (!s_path)
-    {
-      s_path = gtk_tree_model_get_path (s_model, s_iter);
-      free_s_path = TRUE;
-    }
-
-  path = gtk_tree_model_sort_convert_child_path_to_path (tree_model_sort,
-                                                        s_path);
-  if (!path)
-    return;
-  
   gtk_tree_model_get_iter (GTK_TREE_MODEL (data), &iter, path);
-  gtk_tree_model_row_has_child_toggled (GTK_TREE_MODEL (data), path,
-                                       &iter);
+  gtk_tree_model_row_has_child_toggled (GTK_TREE_MODEL (data), path, &iter);
+
   gtk_tree_path_free (path);
-  
-  if (free_s_path)
-    gtk_tree_path_free (s_path);
 }
 
+/* FIXME: I still have doubts if this works */
 static void
 gtk_tree_model_sort_row_deleted (GtkTreeModel *s_model,
                                 GtkTreePath  *s_path,
                                 gpointer      data)
 {
   GtkTreeModelSort *tree_model_sort = GTK_TREE_MODEL_SORT (data);
-  GtkTreePath *path;
+  GtkTreePath *path = NULL;
+  SortElt *elt;
+  SortLevel *level;
+  GtkTreeIter iter;
+  gint offset;
+  gint i;
 
-  /* we don't handle signals which we don't cover */
-  if (!tree_model_sort->root)
+  g_return_if_fail (s_path != NULL);
+
+  path = gtk_real_tree_model_sort_convert_child_path_to_path (tree_model_sort, s_path, FALSE);
+  if (path == NULL)
     return;
 
-  g_return_if_fail (s_path != NULL);
-  path = gtk_tree_model_sort_convert_child_path_to_path (tree_model_sort,
-                                                        s_path);
-  g_return_if_fail (path != NULL);
+  gtk_tree_model_get_iter (GTK_TREE_MODEL (data), &iter, path);
 
-  if (!GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS (tree_model_sort))
+  level = SORT_LEVEL (iter.user_data);
+  elt = SORT_ELT (iter.user_data2);
+  offset = elt->offset;
+
+  /* we _need_ to emit ::row_deleted before we start unreffing the node
+   * itself. This is because of the row refs, which start unreffing nodes
+   * when we emit ::row_deleted
+   */
+  gtk_tree_model_row_deleted (GTK_TREE_MODEL (data), path);
+
+  gtk_tree_model_get_iter (GTK_TREE_MODEL (data), &iter, path);
+
+  while (elt->ref_count > 0)
+    gtk_tree_model_sort_real_unref_node (GTK_TREE_MODEL (data), &iter, FALSE);
+
+  if (level->ref_count == 0 && level != tree_model_sort->root)
     {
-      gtk_tree_model_sort_free_level (tree_model_sort,
-                                     SORT_LEVEL (tree_model_sort->root));
-      tree_model_sort->root = NULL;
+      /* This will prune the level, so I can just emit the signal and not worry
+       * about cleaning this level up. */
+      gtk_tree_model_sort_increment_stamp (tree_model_sort);
+      gtk_tree_path_free (path);
+      return;
     }
-  else
-    {
-      SortElt *elt;
-      SortLevel *level;
-      GtkTreeIter iter;
-      gint offset;
-      gint i;
-      
-      gtk_tree_model_get_iter (GTK_TREE_MODEL (tree_model_sort),
-                              &iter, path);
-      level = SORT_LEVEL (iter.user_data);
-      elt = SORT_ELT (iter.user_data2);
-      offset = elt->offset;
 
-      if (level->array->len == 1)
-       {
-         //      if (SORT_ELT (level->array->data)->parent == NULL)
-         if (level->parent_elt == NULL)
-           tree_model_sort->root = NULL;
-         else
-           //      (SORT_ELT (level->array->data)->parent)->children = NULL;
-           level->parent_level->array = NULL;
-         gtk_tree_model_sort_free_level (tree_model_sort, level);
-       }
-      else
-       {
-         for (i = 0; i < level->array->len; i++)
-           if (elt->offset == g_array_index (level->array, SortElt, i).offset)
-             break;
+  gtk_tree_model_sort_increment_stamp (tree_model_sort);
 
-         g_array_remove_index (level->array, i);
+  /* Remove the row */
+  for (i = 0; i < level->array->len; i++)
+    if (elt->offset == g_array_index (level->array, SortElt, i).offset)
+      break;
 
-         /* update all offsets */
-         for (i = 0; i < level->array->len; i++)
-           {
-             elt = & (g_array_index (level->array, SortElt, i));
-             if (elt->offset > offset)
-               elt->offset--;
-           }
-       }
+  g_array_remove_index (level->array, i);
+
+  /* update all offsets */
+  for (i = 0; i < level->array->len; i++)
+    {
+      elt = & (g_array_index (level->array, SortElt, i));
+      if (elt->offset > offset)
+       elt->offset--;
+      if (elt->children)
+       elt->children->parent_elt = elt;
     }
 
-  gtk_tree_model_row_deleted (GTK_TREE_MODEL (data), path);
-  gtk_tree_model_sort_increment_stamp (tree_model_sort);
   gtk_tree_path_free (path);
 }
 
@@ -624,127 +807,69 @@ gtk_tree_model_sort_rows_reordered (GtkTreeModel *s_model,
                                    gint         *new_order,
                                    gpointer      data)
 {
-  int i;
-  int len;
-  int *my_new_order;
   SortElt *elt;
   SortLevel *level;
-  gboolean free_s_path = FALSE;
-  
-  GtkTreeIter  iter;
+  GtkTreeIter iter;
+  gint *tmp_array;
+  int i, j;
   GtkTreePath *path;
-
   GtkTreeModelSort *tree_model_sort = GTK_TREE_MODEL_SORT (data);
-  
-  g_return_if_fail (s_path != NULL || s_iter != NULL);
+
   g_return_if_fail (new_order != NULL);
 
-  if (!s_path)
+  if (s_path == NULL || gtk_tree_path_get_indices (s_path) == NULL)
     {
-      s_path = gtk_tree_model_get_path (s_model, s_iter);
-      free_s_path = TRUE;
+      if (tree_model_sort->root == NULL)
+       return;
+      path = gtk_tree_path_new ();
+      level = SORT_LEVEL (tree_model_sort->root);
     }
-
-  if (!gtk_tree_path_get_indices (s_path))
-    len = gtk_tree_model_iter_n_children (s_model, NULL);
   else
-    len = gtk_tree_model_iter_n_children (s_model, s_iter);
-
-  if (len < 2)
     {
-      if (free_s_path)
-       gtk_tree_path_free (s_path);
-      return;
-    }
-
-  /** get correct sort level **/
+      path = gtk_real_tree_model_sort_convert_child_path_to_path (tree_model_sort, s_path, FALSE);
+      if (path == NULL)
+       return;
+      gtk_tree_model_get_iter (GTK_TREE_MODEL (data), &iter, path);
 
-  if (!gtk_tree_path_get_indices (s_path))
-    level = SORT_LEVEL (tree_model_sort->root);
-  else
-    {
-      path = gtk_tree_model_sort_convert_child_path_to_path (tree_model_sort,
-                                                            s_path);
-      
-      if (!path)
-       {
-         if (free_s_path)
-           gtk_tree_path_free (s_path);
-         return;
-       }
+      level = SORT_LEVEL (iter.user_data);
+      elt = SORT_ELT (iter.user_data2);
 
-      if (!gtk_tree_model_get_iter (GTK_TREE_MODEL (data), &iter, path))
+      if (!elt->children)
        {
-         /* no iter for me */
-         if (free_s_path)
-           gtk_tree_path_free (s_path);
          gtk_tree_path_free (path);
          return;
        }
-      
-      level = SORT_LEVEL (iter.user_data);
-      elt = SORT_ELT (iter.user_data2);
-      gtk_tree_path_free (path);
-
-      /* FIXME: is this needed ? */
-      if (!s_iter)
-       gtk_tree_model_get_iter (s_model, s_iter, s_path);
-
-      if (!elt->children)
-       return;
 
       level = elt->children;
     }
 
-  if (!level)
+  if (level->array->len < 2)
     {
-      if (free_s_path)
-       gtk_tree_path_free (s_path);
-
-      /* ignore signal */
+      gtk_tree_path_free (path);
       return;
     }
 
-  if (len != level->array->len)
-    {
-      if (free_s_path)
-       gtk_tree_path_free (s_path);
-
-      /* length mismatch, pretty bad, shouldn't happen */
-      g_warning ("length mismatch!");
-      
-      return;
-    }
-  
-  /** unsorted: set offsets, resort without reordered emission **/
-  if (tree_model_sort->sort_column_id == -1)
+  tmp_array = g_new (int, level->array->len);
+  for (i = 0; i < level->array->len; i++)
     {
-      path = gtk_tree_model_sort_convert_child_path_to_path (tree_model_sort,
-                                                            s_path);
-
-      if (!path)
+      for (j = 0; j < level->array->len; j++)
        {
-         if (free_s_path)
-           gtk_tree_path_free (s_path);
-         
-         return;
+         if (g_array_index (level->array, SortElt, i).offset == new_order[j])
+           tmp_array[i] = j;
        }
+    }
+
+  for (i = 0; i < level->array->len; i++)
+    g_array_index (level->array, SortElt, i).offset = tmp_array[i];
+  g_free (tmp_array);
+
+  if (tree_model_sort->sort_column_id == GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID &&
+      tree_model_sort->default_sort_func == NO_SORT_FUNC)
+    {
 
-      for (i = 0; i < level->array->len; i++)
-       {
-         g_array_index (level->array, SortElt, i).offset = new_order[i];
-         
-         if (GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS (tree_model_sort))
-           {
-             get_child_iter_from_elt_no_cache (tree_model_sort,
-                                               &(g_array_index (level->array, SortElt, i).iter), level, &g_array_index (level->array, SortElt, i));
-           }
-       }
-      
-      gtk_tree_model_sort_increment_stamp (tree_model_sort);
-      
       gtk_tree_model_sort_sort_level (tree_model_sort, level,
                                      FALSE, FALSE);
+      gtk_tree_model_sort_increment_stamp (tree_model_sort);
 
       if (gtk_tree_path_get_depth (path))
        {
@@ -755,45 +880,17 @@ gtk_tree_model_sort_rows_reordered (GtkTreeModel *s_model,
                                         path, &iter, new_order);
        }
       else
-       gtk_tree_model_rows_reordered (GTK_TREE_MODEL (tree_model_sort),
-                                      path, NULL, new_order);
-      
-      gtk_tree_path_free (path);
-
-      if (free_s_path)
-       gtk_tree_path_free (s_path);
-
-      return;
+       {
+         gtk_tree_model_rows_reordered (GTK_TREE_MODEL (tree_model_sort),
+                                        path, NULL, new_order);
+       }
     }
 
-  /** sorted: update offsets, no emission of reordered signal **/
-  g_print ("B");
-  for (i = 0; i < level->array->len; i++)
-    g_print ("%3d", g_array_index (level->array, SortElt, i).offset);
-  g_print ("\n");
-
-  g_print ("N");
-  for (i = 0; i < level->array->len; i++)
-    g_print ("%3d", new_order[i]);
-  g_print ("\n");
-
-  for (i = 0; i < level->array->len; i++)
-    g_array_index (level->array, SortElt, i).offset =
-      new_order[g_array_index (level->array, SortElt, i).offset];
-
-  g_print ("A");
-  for (i = 0; i < level->array->len; i++)
-    g_print ("%3d", g_array_index (level->array, SortElt, i).offset);
-  g_print ("\n");
-  
-  gtk_tree_model_sort_increment_stamp (tree_model_sort);
-
-  if (free_s_path)
-    gtk_tree_path_free (s_path);
+  gtk_tree_path_free (path);
 }
 
 /* Fulfill our model requirements */
-static guint
+static GtkTreeModelFlags
 gtk_tree_model_sort_get_flags (GtkTreeModel *tree_model)
 {
   g_return_val_if_fail (GTK_IS_TREE_MODEL_SORT (tree_model), 0);
@@ -811,7 +908,7 @@ gtk_tree_model_sort_get_n_columns (GtkTreeModel *tree_model)
   if (tree_model_sort->child_model == 0)
     return 0;
 
-  return gtk_tree_model_get_n_columns (GTK_TREE_MODEL_SORT (tree_model)->child_model);
+  return gtk_tree_model_get_n_columns (tree_model_sort->child_model);
 }
 
 static GType
@@ -851,7 +948,7 @@ gtk_tree_model_sort_get_iter (GtkTreeModel *tree_model,
   for (i = 0; i < depth - 1; i++)
     {
       if ((level == NULL) ||
-         (level->array->len < indices[i]))
+         (indices[i] >= level->array->len))
        return FALSE;
 
       if (g_array_index (level->array, SortElt, indices[i]).children == NULL)
@@ -943,13 +1040,13 @@ gtk_tree_model_sort_iter_children (GtkTreeModel *tree_model,
   GtkTreeModelSort *tree_model_sort = (GtkTreeModelSort *) tree_model;
   SortLevel *level;
 
+  iter->stamp = 0;
   g_return_val_if_fail (GTK_IS_TREE_MODEL_SORT (tree_model), FALSE);
   g_return_val_if_fail (tree_model_sort->child_model != NULL, FALSE);
   if (parent) g_return_val_if_fail (tree_model_sort->stamp == parent->stamp, FALSE);
 
   if (parent == NULL)
     {
-
       if (tree_model_sort->root == NULL)
        gtk_tree_model_sort_build_level (tree_model_sort, NULL, NULL);
       if (tree_model_sort->root == NULL)
@@ -972,7 +1069,7 @@ gtk_tree_model_sort_iter_children (GtkTreeModel *tree_model,
       iter->user_data = ((SortElt *)parent->user_data2)->children;
       iter->user_data2 = ((SortLevel *)iter->user_data)->array->data;
     }
-  
+
   return TRUE;
 }
 
@@ -1016,21 +1113,30 @@ gtk_tree_model_sort_iter_nth_child (GtkTreeModel *tree_model,
                                    gint          n)
 {
   SortLevel *level;
+  /* We have this for the iter == parent case */
+  GtkTreeIter children;
 
   g_return_val_if_fail (GTK_IS_TREE_MODEL_SORT (tree_model), FALSE);
-  g_return_val_if_fail (GTK_TREE_MODEL_SORT (tree_model)->child_model != NULL, FALSE);
+  if (parent) g_return_val_if_fail (GTK_TREE_MODEL_SORT (tree_model)->stamp == parent->stamp, FALSE);
 
-  if (gtk_tree_model_sort_iter_children (tree_model, iter, parent) == FALSE)
-    return FALSE;
+  /* Use this instead of has_child to force us to build the level, if needed */
+  if (gtk_tree_model_sort_iter_children (tree_model, &children, parent) == FALSE)
+    {
+      iter->stamp = 0;
+      return FALSE;
+    }
 
-  level = iter->user_data;
+  level = children.user_data;
   if (n >= level->array->len)
     {
       iter->stamp = 0;
       return FALSE;
     }
 
+  iter->stamp = GTK_TREE_MODEL_SORT (tree_model)->stamp;
+  iter->user_data = level;
   iter->user_data2 = &g_array_index (level->array, SortElt, n);
+
   return TRUE;
 }
 
@@ -1041,6 +1147,7 @@ gtk_tree_model_sort_iter_parent (GtkTreeModel *tree_model,
 {
   SortLevel *level;
 
+  iter->stamp = 0;
   g_return_val_if_fail (GTK_IS_TREE_MODEL_SORT (tree_model), FALSE);
   g_return_val_if_fail (GTK_TREE_MODEL_SORT (tree_model)->child_model != NULL, FALSE);
   g_return_val_if_fail (GTK_TREE_MODEL_SORT (tree_model)->stamp == child->stamp, FALSE);
@@ -1063,6 +1170,7 @@ gtk_tree_model_sort_ref_node (GtkTreeModel *tree_model,
                              GtkTreeIter  *iter)
 {
   GtkTreeModelSort *tree_model_sort = (GtkTreeModelSort *) tree_model;
+  GtkTreeIter child_iter;
   SortLevel *level;
   SortElt *elt;
 
@@ -1070,6 +1178,10 @@ gtk_tree_model_sort_ref_node (GtkTreeModel *tree_model,
   g_return_if_fail (GTK_TREE_MODEL_SORT (tree_model)->child_model != NULL);
   g_return_if_fail (GTK_TREE_MODEL_SORT (tree_model)->stamp == iter->stamp);
 
+  GET_CHILD_ITER (tree_model, &child_iter, iter);
+
+  gtk_tree_model_ref_node (GTK_TREE_MODEL_SORT (tree_model)->child_model, &child_iter);
+
   level = iter->user_data;
   elt = iter->user_data2;
 
@@ -1086,7 +1198,7 @@ gtk_tree_model_sort_ref_node (GtkTreeModel *tree_model,
            parent_elt->zero_ref_count--;
          else
            tree_model_sort->zero_ref_count--;
-         
+
          if (parent_level)
            {
              parent_elt = parent_level->parent_elt;
@@ -1098,10 +1210,12 @@ gtk_tree_model_sort_ref_node (GtkTreeModel *tree_model,
 }
 
 static void
-gtk_tree_model_sort_unref_node (GtkTreeModel *tree_model,
-                               GtkTreeIter  *iter)
+gtk_tree_model_sort_real_unref_node (GtkTreeModel *tree_model,
+                                    GtkTreeIter  *iter,
+                                    gboolean      propagate_unref)
 {
   GtkTreeModelSort *tree_model_sort = (GtkTreeModelSort *) tree_model;
+  GtkTreeIter child_iter;
   SortLevel *level;
   SortElt *elt;
 
@@ -1109,33 +1223,43 @@ gtk_tree_model_sort_unref_node (GtkTreeModel *tree_model,
   g_return_if_fail (GTK_TREE_MODEL_SORT (tree_model)->child_model != NULL);
   g_return_if_fail (GTK_TREE_MODEL_SORT (tree_model)->stamp == iter->stamp);
 
+  GET_CHILD_ITER (tree_model, &child_iter, iter);
+
+  if (propagate_unref)
+    gtk_tree_model_unref_node (GTK_TREE_MODEL_SORT (tree_model)->child_model, &child_iter);
+
   level = iter->user_data;
   elt = iter->user_data2;
 
+  g_return_if_fail (elt->ref_count > 0);
+
   elt->ref_count--;
   level->ref_count--;
+
   if (level->ref_count == 0)
     {
       SortLevel *parent_level = level->parent_level;
       SortElt *parent_elt = level->parent_elt;
-      /* We were at zero -- time to decrement the zero_ref_count val */
-      do
+
+      /* We are at zero -- time to increment the zero_ref_count val */
+      while (parent_level)
        {
-         if (parent_elt)
-           parent_elt->zero_ref_count++;
-         else
-           tree_model_sort->zero_ref_count++;
-         
-         if (parent_level)
-           {
-             parent_elt = parent_level->parent_elt;
-             parent_level = parent_level->parent_level;
-           }
+         parent_elt->zero_ref_count++;
+
+         parent_elt = parent_level->parent_elt;
+         parent_level = parent_level->parent_level;
        }
-      while (parent_level);
+      tree_model_sort->zero_ref_count++;
     }
 }
 
+static void
+gtk_tree_model_sort_unref_node (GtkTreeModel *tree_model,
+                               GtkTreeIter  *iter)
+{
+  gtk_tree_model_sort_real_unref_node (tree_model, iter, TRUE);
+}
+
 /* Sortable interface */
 static gboolean
 gtk_tree_model_sort_get_sort_column_id (GtkTreeSortable *sortable,
@@ -1163,14 +1287,13 @@ gtk_tree_model_sort_set_sort_column_id (GtkTreeSortable *sortable,
                                        GtkSortType      order)
 {
   GtkTreeModelSort *tree_model_sort = (GtkTreeModelSort *)sortable;
-  GList *list;
-  
+
   g_return_if_fail (GTK_IS_TREE_MODEL_SORT (sortable));
-  
+
   if (sort_column_id != GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID)
     {
       GtkTreeDataSortHeader *header = NULL;
-      
+
       header = _gtk_tree_data_list_get_header (tree_model_sort->sort_list,
                                               sort_column_id);
 
@@ -1179,9 +1302,7 @@ gtk_tree_model_sort_set_sort_column_id (GtkTreeSortable *sortable,
       g_return_if_fail (header->func != NULL);
     }
   else
-    {
-      g_return_if_fail (tree_model_sort->default_sort_func != NULL);
-    }
+    g_return_if_fail (tree_model_sort->default_sort_func != NULL);
 
   if (tree_model_sort->sort_column_id == sort_column_id)
     {
@@ -1198,6 +1319,7 @@ gtk_tree_model_sort_set_sort_column_id (GtkTreeSortable *sortable,
   tree_model_sort->order = order;
 
   gtk_tree_model_sort_sort (tree_model_sort);
+
   gtk_tree_sortable_sort_column_changed (sortable);
 }
 
@@ -1217,10 +1339,14 @@ gtk_tree_model_sort_set_sort_func (GtkTreeSortable        *sortable,
 
   for (list = tree_model_sort->sort_list; list; list = list->next)
     {
-      header = (GtkTreeDataSortHeader *) list->data;
-      
-      if (header->sort_column_id == sort_column_id)
-       break;
+      GtkTreeDataSortHeader *list_header;
+
+      list_header = (GtkTreeDataSortHeader*) list->data;
+      if (list_header->sort_column_id == sort_column_id)
+       {
+         header = list_header;
+         break;
+       }
     }
 
   if (header == NULL)
@@ -1232,7 +1358,12 @@ gtk_tree_model_sort_set_sort_func (GtkTreeSortable        *sortable,
     }
 
   if (header->destroy)
-    (* header->destroy) (header->data);
+    {
+      GtkDestroyNotify d = header->destroy;
+
+      header->destroy = NULL;
+      d (header->data);
+    }
 
   header->func = func;
   header->data = data;
@@ -1246,11 +1377,16 @@ gtk_tree_model_sort_set_default_sort_func (GtkTreeSortable        *sortable,
                                           GtkDestroyNotify        destroy)
 {
   GtkTreeModelSort *tree_model_sort = (GtkTreeModelSort *)sortable;
-  
+
   g_return_if_fail (GTK_IS_TREE_MODEL_SORT (sortable));
-  
+
   if (tree_model_sort->default_sort_destroy)
-    (* tree_model_sort->default_sort_destroy) (tree_model_sort->default_sort_data);
+    {
+      GtkDestroyNotify d = tree_model_sort->default_sort_destroy;
+
+      tree_model_sort->default_sort_destroy = NULL;
+      d (tree_model_sort->default_sort_data);
+    }
 
   tree_model_sort->default_sort_func = func;
   tree_model_sort->default_sort_data = data;
@@ -1273,53 +1409,34 @@ gtk_tree_model_sort_compare_func (gconstpointer a,
                                  gconstpointer b,
                                  gpointer      user_data)
 {
-  gint retval;
-
-  SortElt *sa = ((SortTuple *)a)->elt;
-  SortElt *sb = ((SortTuple *)b)->elt;
-
-  GtkTreeIter iter_a, iter_b;
-
   SortData *data = (SortData *)user_data;
   GtkTreeModelSort *tree_model_sort = data->tree_model_sort;
+  SortTuple *sa = (SortTuple *)a;
+  SortTuple *sb = (SortTuple *)b;
 
-  GtkTreeIterCompareFunc func;
-  gpointer f_data;
-
-  if (tree_model_sort->sort_column_id != GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID)
-    {
-      GtkTreeDataSortHeader *header = NULL;
-
-      header = 
-       _gtk_tree_data_list_get_header (tree_model_sort->sort_list,
-                                       tree_model_sort->sort_column_id);
-      
-      g_return_val_if_fail (header != NULL, 0);
-      g_return_val_if_fail (header->func != NULL, 0);
-      
-      func = header->func;
-      f_data = header->data;
-    }
-  else
-    {
-      /* absolutely SHOULD NOT happen: */
-      g_return_val_if_fail (tree_model_sort->sort_column_id == GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID, 0);
-      g_return_val_if_fail (tree_model_sort->default_sort_func != (GtkTreeIterCompareFunc) 0x1, 0);
-      g_return_val_if_fail (tree_model_sort->default_sort_func != NULL, 0);
-
-      func = tree_model_sort->default_sort_func;
-      f_data = tree_model_sort->default_sort_data;
-    }
+  GtkTreeIter iter_a, iter_b;
+  gint retval;
 
   /* shortcut, if we've the same offsets here, they should be equal */
   if (sa->offset == sb->offset)
     return 0;
-  
-  get_child_iter_from_elt (tree_model_sort, &iter_a, ((SortTuple *)a)->level, sa);
-  get_child_iter_from_elt (tree_model_sort, &iter_b, ((SortTuple *)b)->level, sb);
 
-  retval = (* func) (GTK_TREE_MODEL (tree_model_sort->child_model),
-                    &iter_a, &iter_b, f_data);
+  if (GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS (tree_model_sort))
+    {
+      iter_a = sa->elt->iter;
+      iter_b = sb->elt->iter;
+    }
+  else
+    {
+      data->parent_path_indices [data->parent_path_depth-1] = sa->elt->offset;
+      gtk_tree_model_get_iter (GTK_TREE_MODEL (tree_model_sort->child_model), &iter_a, data->parent_path);
+      data->parent_path_indices [data->parent_path_depth-1] = sb->elt->offset;
+      gtk_tree_model_get_iter (GTK_TREE_MODEL (tree_model_sort->child_model), &iter_b, data->parent_path);
+    }
+
+  retval = (* data->sort_func) (GTK_TREE_MODEL (tree_model_sort->child_model),
+                               &iter_a, &iter_b,
+                               data->sort_data);
 
   if (tree_model_sort->order == GTK_SORT_DESCENDING)
     {
@@ -1339,14 +1456,14 @@ gtk_tree_model_sort_offset_compare_func (gconstpointer a,
 {
   gint retval;
 
-  SortElt *sa = ((SortTuple *)a)->elt;
-  SortElt *sb = ((SortTuple *)b)->elt;
+  SortTuple *sa = (SortTuple *)a;
+  SortTuple *sb = (SortTuple *)b;
 
   SortData *data = (SortData *)user_data;
 
-  if (sa->offset < sb->offset)
+  if (sa->elt->offset < sb->elt->offset)
     retval = -1;
-  else if (sa->offset > sb->offset)
+  else if (sa->elt->offset > sb->elt->offset)
     retval = 1;
   else
     retval = 0;
@@ -1375,105 +1492,98 @@ gtk_tree_model_sort_sort_level (GtkTreeModelSort *tree_model_sort,
 
   GtkTreeIter iter;
   GtkTreePath *path;
-  
-  SortData *data;
+
+  SortData data;
 
   g_return_if_fail (GTK_IS_TREE_MODEL_SORT (tree_model_sort));
   g_return_if_fail (level != NULL);
-  
+
   if (level->array->len < 1 && !((SortElt *)level->array->data)->children)
     return;
-  
-  data = g_new0 (SortData, 1);
 
+  /* Set up data */
+  data.tree_model_sort = tree_model_sort;
   if (level->parent_elt)
     {
-      data->parent_a = gtk_tree_model_sort_elt_get_path (level->parent_level,
-                                                        level->parent_elt);
-      data->parent_b = gtk_tree_path_copy (data->parent_a);
+      data.parent_path = gtk_tree_model_sort_elt_get_path (level->parent_level,
+                                                          level->parent_elt);
+      gtk_tree_path_append_index (data.parent_path, 0);
     }
   else
     {
-      data->parent_a = gtk_tree_path_new ();
-      data->parent_b = gtk_tree_path_new ();
+      data.parent_path = gtk_tree_path_new_first ();
     }
+  data.parent_path_depth = gtk_tree_path_get_depth (data.parent_path);
+  data.parent_path_indices = gtk_tree_path_get_indices (data.parent_path);
 
-  data->tree_model_sort = tree_model_sort;
-
+  /* make the array to be sorted */
   sort_array = g_array_sized_new (FALSE, FALSE, sizeof (SortTuple), level->array->len);
-  
   for (i = 0; i < level->array->len; i++)
     {
       SortTuple tuple;
 
       tuple.elt = &g_array_index (level->array, SortElt, i);
-      tuple.level = level;
-      tuple.children = tuple.elt->children;
-      tuple.offset = tuple.elt->offset;
+      tuple.offset = i;
 
       g_array_append_val (sort_array, tuple);
     }
 
-  g_print ("-- sort: sort_column_id = %d // default_sort_func = %.2x\n",
-          tree_model_sort->sort_column_id, tree_model_sort->default_sort_func);
+    if (tree_model_sort->sort_column_id != GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID)
+      {
+       GtkTreeDataSortHeader *header = NULL;
 
-  if (tree_model_sort->sort_column_id == GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID)
+       header = _gtk_tree_data_list_get_header (tree_model_sort->sort_list,
+                                                tree_model_sort->sort_column_id);
+
+       g_return_if_fail (header != NULL);
+       g_return_if_fail (header->func != NULL);
+
+       data.sort_func = header->func;
+       data.sort_data = header->data;
+      }
+    else
+      {
+       /* absolutely SHOULD NOT happen: */
+       g_return_if_fail (tree_model_sort->default_sort_func != NULL);
+
+       data.sort_func = tree_model_sort->default_sort_func;
+       data.sort_data = tree_model_sort->default_sort_data;
+      }
+
+  if (data.sort_func == NO_SORT_FUNC)
     g_array_sort_with_data (sort_array,
                            gtk_tree_model_sort_offset_compare_func,
-                           data);
+                           &data);
   else
     g_array_sort_with_data (sort_array,
                            gtk_tree_model_sort_compare_func,
-                           data);
+                           &data);
 
-  gtk_tree_path_free (data->parent_a);
-  gtk_tree_path_free (data->parent_b);
-  g_free (data);
+  gtk_tree_path_free (data.parent_path);
 
-  /* let the world know about our absolutely great new order */
   new_array = g_array_sized_new (FALSE, FALSE, sizeof (SortElt), level->array->len);
-  g_array_set_size (new_array, level->array->len);
   new_order = g_new (gint, level->array->len);
 
   for (i = 0; i < level->array->len; i++)
     {
-      SortElt *elt1;
-      SortElt *elt2;
-      gint j;
-      
-      elt1 = &g_array_index (level->array, SortElt, i);
-
-      for (j = 0; j < sort_array->len; j++)
-       if (elt1->offset == g_array_index (sort_array, SortTuple, j).offset)
-         break;
-
-      if (j >= level->array->len)
-       /* isn't supposed to happen */
-       break;
-
-      new_order[i] = j;
+      SortElt *elt;
 
-      /* copy ... */
-      memcpy (&g_array_index (new_array, SortElt, j), elt1, sizeof (SortElt));
-      elt2 = &g_array_index (new_array, SortElt, j);
+      elt = g_array_index (sort_array, SortTuple, i).elt;
+      new_order[i] = g_array_index (sort_array, SortTuple, i).offset;
 
-      /* point children to correct parent */
-      if (elt2->children)
-       {
-         elt2->children->parent_elt = elt2;
-         elt2->children->parent_level = level;
-       }
+      g_array_append_val (new_array, *elt);
+      elt = &g_array_index (new_array, SortElt, i);
+      if (elt->children)
+       elt->children->parent_elt = elt;
     }
 
   g_array_free (level->array, TRUE);
   level->array = new_array;
-  
   g_array_free (sort_array, TRUE);
 
   if (emit_reordered)
     {
       gtk_tree_model_sort_increment_stamp (tree_model_sort);
-
       if (level->parent_elt)
        {
          iter.stamp = tree_model_sort->stamp;
@@ -1496,8 +1606,6 @@ gtk_tree_model_sort_sort_level (GtkTreeModelSort *tree_model_sort,
 
       gtk_tree_path_free (path);
     }
-  
-  g_free (new_order);
 
   /* recurse, if possible */
   if (recurse)
@@ -1512,18 +1620,17 @@ gtk_tree_model_sort_sort_level (GtkTreeModelSort *tree_model_sort,
                                            TRUE, emit_reordered);
        }
     }
+
+  g_free (new_order);
 }
 
 static void
 gtk_tree_model_sort_sort (GtkTreeModelSort *tree_model_sort)
 {
   g_return_if_fail (GTK_IS_TREE_MODEL_SORT (tree_model_sort));
-  
+
   if (!tree_model_sort->root)
-    {
-      g_print ("sort: bailing out, no level built yet\n");
-      return;
-    }
+    return;
 
   if (tree_model_sort->sort_column_id != GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID)
     {
@@ -1537,9 +1644,7 @@ gtk_tree_model_sort_sort (GtkTreeModelSort *tree_model_sort)
       g_return_if_fail (header->func != NULL);
     }
   else
-    {
-      g_return_if_fail (tree_model_sort->default_sort_func != NULL);
-    }
+    g_return_if_fail (tree_model_sort->default_sort_func != NULL);
 
   gtk_tree_model_sort_sort_level (tree_model_sort, tree_model_sort->root,
                                  TRUE, TRUE);
@@ -1560,31 +1665,41 @@ gtk_tree_model_sort_level_find_insert (GtkTreeModelSort *tree_model_sort,
   GtkTreeIterCompareFunc func;
   gpointer data;
 
-  if (tree_model_sort->sort_column_id == -1)
-    return level->array->len;
-  
-  {
-    GtkTreeDataSortHeader *header;
-
-    header = _gtk_tree_data_list_get_header (tree_model_sort->sort_list,
-                                            tree_model_sort->sort_column_id);
-    
-    g_return_val_if_fail (header != NULL, 0);
-    g_return_val_if_fail (header->func != NULL, 0);
-
-    func = header->func;
-    data = header->data;
-  }
-  
+  GtkTreePath *path;
+
+  if (tree_model_sort->sort_column_id != GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID)
+    {
+      GtkTreeDataSortHeader *header;
+      
+      header = _gtk_tree_data_list_get_header (tree_model_sort->sort_list,
+                                              tree_model_sort->sort_column_id);
+      
+      g_return_val_if_fail (header != NULL, 0);
+      
+      func = header->func;
+      data = header->data;
+    }
+  else
+    {
+      func = tree_model_sort->default_sort_func;
+      data = tree_model_sort->default_sort_data;
+      
+      g_return_val_if_fail (func != NO_SORT_FUNC, 0);
+    }
+
+  g_return_val_if_fail (func != NULL, 0);
+      
   for (middle = 0; middle < level->array->len; middle++)
     {
       tmp_elt = &(g_array_index (level->array, SortElt, middle));
 
-      if (!skip_sort_elt && SORT_ELT (iter) == tmp_elt)
+      if (!skip_sort_elt && SORT_ELT (iter->user_data2) == tmp_elt)
        continue;
 
-      get_child_iter_from_elt (tree_model_sort, &tmp_iter,
-                              level, tmp_elt);
+      path = gtk_tree_model_sort_elt_get_path (level, tmp_elt);
+      gtk_tree_model_get_iter (tree_model_sort->child_model,
+                              &tmp_iter, path);
+      gtk_tree_path_free (path);
 
       if (tree_model_sort->order == GTK_SORT_ASCENDING)
        cmp = (* func) (GTK_TREE_MODEL (tree_model_sort->child_model),
@@ -1592,107 +1707,53 @@ gtk_tree_model_sort_level_find_insert (GtkTreeModelSort *tree_model_sort,
       else
        cmp = (* func) (GTK_TREE_MODEL (tree_model_sort->child_model),
                        iter, &tmp_iter, data);
-      
+
       if (cmp > 0)
        break;
     }
-  
+
   return middle;
 }
 
 static gboolean
 gtk_tree_model_sort_insert_value (GtkTreeModelSort *tree_model_sort,
+                                 SortLevel        *level,
                                  GtkTreePath      *s_path,
                                  GtkTreeIter      *s_iter)
 {
-  gint offset, index, j;
-  SortLevel *level;
+  gint offset, index, i;
+
   SortElt elt;
   SortElt *tmp_elt;
-  GtkTreeIter iter;
-  GtkTreePath *tmp_path;
-
-  return FALSE;
-
-  if (!tree_model_sort->root)
-    {
-      gtk_tree_model_sort_build_level (tree_model_sort, NULL, NULL);
-      return FALSE;
-    }
 
   offset = gtk_tree_path_get_indices (s_path)[gtk_tree_path_get_depth (s_path) - 1];
-  
+
   if (GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS (tree_model_sort))
     elt.iter = *s_iter;
   elt.offset = offset;
   elt.zero_ref_count = 0;
   elt.ref_count = 0;
   elt.children = NULL;
-  
-  tmp_path = gtk_tree_path_copy (s_path);
-
-  if (gtk_tree_path_up (tmp_path))
-    {
-      GtkTreePath *parent_path;
-
-      parent_path = gtk_tree_model_sort_convert_child_path_to_path (tree_model_sort, tmp_path);
 
-      if (!parent_path)
-       {
-         gtk_tree_path_free (tmp_path);
-         return FALSE;
-       }
-
-      if (!gtk_tree_model_get_iter (GTK_TREE_MODEL (tree_model_sort), &iter,
-                                   parent_path))
-       {
-         gtk_tree_path_free (parent_path);
-         gtk_tree_path_free (tmp_path);
-         return FALSE;
-       }
-
-      level = SORT_LEVEL (iter.user_data);
-      gtk_tree_path_free (parent_path);
+  /* update all larger offsets */
+  tmp_elt = SORT_ELT (level->array->data);
+  for (i = 0; i < level->array->len; i++, tmp_elt++)
+    if (tmp_elt->offset >= offset)
+      tmp_elt->offset++;
 
-      if (!level)
-       {
-         gtk_tree_path_free (tmp_path);
-         return FALSE;
-       }
-    }
+  if (tree_model_sort->sort_column_id == GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID &&
+      tree_model_sort->default_sort_func == NO_SORT_FUNC)
+    index = offset;
   else
-    {
-      if (!tree_model_sort->root)
-       gtk_tree_model_sort_build_level (tree_model_sort, NULL, NULL);
-      level = SORT_LEVEL (tree_model_sort->root);
-    }
-
-  gtk_tree_path_free (tmp_path);
-
-  if (GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS (tree_model_sort))
     index = gtk_tree_model_sort_level_find_insert (tree_model_sort,
-                                                  level,
-                                                  &elt.iter,
-                                                  FALSE);
-  else
-    {
-      GtkTreeIter tmpiter;
-      gtk_tree_model_sort_convert_child_iter_to_iter (tree_model_sort,
-                                                     &tmpiter,
-                                                     s_iter);
-      index = gtk_tree_model_sort_level_find_insert (tree_model_sort,
-                                                    level,
-                                                    &tmpiter,
-                                                    FALSE);
-    }
+                                                   level, s_iter,
+                                                   FALSE);
 
   g_array_insert_vals (level->array, index, &elt, 1);
-  
-  /* update all larger offsets */
   tmp_elt = SORT_ELT (level->array->data);
-  for (j = 0; j < level->array->len; j++, tmp_elt++)
-    if ((tmp_elt->offset >= offset) && j != index)
-      tmp_elt->offset++;
+  for (i = 0; i < level->array->len; i++, tmp_elt++)
+    if (tmp_elt->children)
+      tmp_elt->children->parent_elt = tmp_elt;
 
   return TRUE;
 }
@@ -1702,91 +1763,24 @@ static GtkTreePath *
 gtk_tree_model_sort_elt_get_path (SortLevel *level,
                                  SortElt *elt)
 {
-  gchar *str = NULL;
-  GList *i;
-  GList *offsets = NULL;
   SortLevel *walker = level;
   SortElt *walker2 = elt;
   GtkTreePath *path;
-  
+
   g_return_val_if_fail (level != NULL, NULL);
   g_return_val_if_fail (elt != NULL, NULL);
-  
-  while (walker && walker2)
-    {
-      offsets = g_list_prepend (offsets,
-                                g_strdup_printf ("%d", walker2->offset));
-      walker2 = walker->parent_elt;
-      walker = walker->parent_level;
-    }
-  
-  g_return_val_if_fail (g_list_length (offsets) > 0, NULL);
-  
-  for (i = offsets; i; i = i->next)
-    {
-      gchar *copy = str;
-      
-      if (str)
-        str = g_strconcat (copy, ":", i->data, NULL);
-      else
-        str = g_strdup (i->data);
-      
-      if (copy)
-        g_free (copy);
-      
-      g_free (i->data);
-    }
-  
-  g_list_free (offsets);
-  
-  path = gtk_tree_path_new_from_string (str);
-  g_free (str);
-  
-  return path;
-}
-
-static void
-get_child_iter_from_elt_no_cache (GtkTreeModelSort *tree_model_sort,
-                                 GtkTreeIter      *child_iter,
-                                 SortLevel        *level,
-                                 SortElt          *elt)
-{
-  GtkTreePath *path;
 
-  SortElt *elt_i = elt;
-  SortLevel *level_i = level;
-  
   path = gtk_tree_path_new ();
-  
-  while (level_i)
-    {
-      gtk_tree_path_prepend_index (path, elt_i->offset);
-      
-      elt_i = level_i->parent_elt;
-      level_i = level_i->parent_level;
-    }
-  
-  gtk_tree_model_get_iter (tree_model_sort->child_model, child_iter, path);
-  gtk_tree_path_free (path);
-}
 
-static void
-get_child_iter_from_elt (GtkTreeModelSort *tree_model_sort,
-                        GtkTreeIter      *child_iter,
-                        SortLevel        *level,
-                        SortElt          *elt)
-{
-  if (GTK_TREE_MODEL_SORT_CACHE_CHILD_ITERS (tree_model_sort))
-    *child_iter = elt->iter;
-  else
+  while (walker)
     {
-      GtkTreeIter tmp;
-      GtkTreePath *path = gtk_tree_model_sort_elt_get_path (level, elt);
-      gtk_tree_model_get_iter (GTK_TREE_MODEL (tree_model_sort), &tmp, path);
-      gtk_tree_path_free (path);
+      gtk_tree_path_prepend_index (path, walker2->offset);
 
-      GET_CHILD_ITER (tree_model_sort, child_iter, &tmp);
+      walker2 = walker->parent_elt;
+      walker = walker->parent_level;
     }
+
+  return path;
 }
 
 /**
@@ -1805,27 +1799,28 @@ gtk_tree_model_sort_set_model (GtkTreeModelSort *tree_model_sort,
   g_return_if_fail (GTK_IS_TREE_MODEL_SORT (tree_model_sort));
 
   if (child_model)
-    g_object_ref (G_OBJECT (child_model));
+    g_object_ref (child_model);
 
   if (tree_model_sort->child_model)
     {
-      g_signal_handler_disconnect (G_OBJECT (tree_model_sort->child_model),
+      g_signal_handler_disconnect (tree_model_sort->child_model,
                                    tree_model_sort->changed_id);
-      g_signal_handler_disconnect (G_OBJECT (tree_model_sort->child_model),
+      g_signal_handler_disconnect (tree_model_sort->child_model,
                                    tree_model_sort->inserted_id);
-      g_signal_handler_disconnect (G_OBJECT (tree_model_sort->child_model),
+      g_signal_handler_disconnect (tree_model_sort->child_model,
                                    tree_model_sort->has_child_toggled_id);
-      g_signal_handler_disconnect (G_OBJECT (tree_model_sort->child_model),
+      g_signal_handler_disconnect (tree_model_sort->child_model,
                                    tree_model_sort->deleted_id);
-      g_signal_handler_disconnect (G_OBJECT (tree_model_sort->child_model),
+      g_signal_handler_disconnect (tree_model_sort->child_model,
                                   tree_model_sort->reordered_id);
 
       /* reset our state */
-      gtk_tree_model_sort_free_level (tree_model_sort, tree_model_sort->root);
+      if (tree_model_sort->root)
+       gtk_tree_model_sort_free_level (tree_model_sort, tree_model_sort->root);
       tree_model_sort->root = NULL;
       _gtk_tree_data_list_header_free (tree_model_sort->sort_list);
       tree_model_sort->sort_list = NULL;
-      g_object_unref (G_OBJECT (tree_model_sort->child_model));
+      g_object_unref (tree_model_sort->child_model);
     }
 
   tree_model_sort->child_model = child_model;
@@ -1866,7 +1861,7 @@ gtk_tree_model_sort_set_model (GtkTreeModelSort *tree_model_sort,
       tree_model_sort->sort_list = _gtk_tree_data_list_header_new (n_columns, types);
       g_free (types);
 
-      tree_model_sort->default_sort_func = (GtkTreeIterCompareFunc)0x1;
+      tree_model_sort->default_sort_func = NO_SORT_FUNC;
       tree_model_sort->stamp = g_random_int ();
     }
 }
@@ -1888,21 +1883,10 @@ gtk_tree_model_sort_get_model (GtkTreeModelSort  *tree_model)
 }
 
 
-/**
- * gtk_tree_model_sort_convert_child_path_to_path:
- * @tree_model_sort: A #GtkTreeModelSort
- * @child_path: A #GtkTreePath to convert
- * 
- * Converts @child_path to a path relative to @tree_model_sort.  That is,
- * @child_path points to a path in the child model.  The returned path will
- * point to the same row in the sorted model.  If @child_path isn't a valid path
- * on the child model, then %NULL is returned.
- * 
- * Return value: A newly allocated #GtkTreePath, or %NULL
- **/
-GtkTreePath *
-gtk_tree_model_sort_convert_child_path_to_path (GtkTreeModelSort *tree_model_sort,
-                                               GtkTreePath      *child_path)
+static GtkTreePath *
+gtk_real_tree_model_sort_convert_child_path_to_path (GtkTreeModelSort *tree_model_sort,
+                                                    GtkTreePath      *child_path,
+                                                    gboolean          build_levels)
 {
   gint *child_indices;
   GtkTreePath *retval;
@@ -1916,7 +1900,10 @@ gtk_tree_model_sort_convert_child_path_to_path (GtkTreeModelSort *tree_model_sor
   retval = gtk_tree_path_new ();
   child_indices = gtk_tree_path_get_indices (child_path);
 
+  if (tree_model_sort->root == NULL && build_levels)
+    gtk_tree_model_sort_build_level (tree_model_sort, NULL, NULL);
   level = SORT_LEVEL (tree_model_sort->root);
+
   for (i = 0; i < gtk_tree_path_get_depth (child_path); i++)
     {
       gint j;
@@ -1937,7 +1924,11 @@ gtk_tree_model_sort_convert_child_path_to_path (GtkTreeModelSort *tree_model_sor
        {
          if ((g_array_index (level->array, SortElt, j)).offset == child_indices[i])
            {
-             gtk_tree_path_prepend_index (retval, j);
+             gtk_tree_path_append_index (retval, j);
+             if (g_array_index (level->array, SortElt, j).children == NULL && build_levels)
+               {
+                 gtk_tree_model_sort_build_level (tree_model_sort, level, &g_array_index (level->array, SortElt, j));
+               }
              level = g_array_index (level->array, SortElt, j).children;
              found_child = TRUE;
              break;
@@ -1953,6 +1944,30 @@ gtk_tree_model_sort_convert_child_path_to_path (GtkTreeModelSort *tree_model_sor
   return retval;
 }
 
+
+/**
+ * gtk_tree_model_sort_convert_child_path_to_path:
+ * @tree_model_sort: A #GtkTreeModelSort
+ * @child_path: A #GtkTreePath to convert
+ * 
+ * Converts @child_path to a path relative to @tree_model_sort.  That is,
+ * @child_path points to a path in the child model.  The returned path will
+ * point to the same row in the sorted model.  If @child_path isn't a valid path
+ * on the child model, then %NULL is returned.
+ * 
+ * Return value: A newly allocated #GtkTreePath, or %NULL
+ **/
+GtkTreePath *
+gtk_tree_model_sort_convert_child_path_to_path (GtkTreeModelSort *tree_model_sort,
+                                               GtkTreePath      *child_path)
+{
+  g_return_val_if_fail (GTK_IS_TREE_MODEL_SORT (tree_model_sort), NULL);
+  g_return_val_if_fail (tree_model_sort->child_model != NULL, NULL);
+  g_return_val_if_fail (child_path != NULL, NULL);
+
+  return gtk_real_tree_model_sort_convert_child_path_to_path (tree_model_sort, child_path, TRUE);
+}
+
 /**
  * gtk_tree_model_sort_convert_child_iter_to_iter:
  * @tree_model_sort: A #GtkTreeModelSort
@@ -1992,11 +2007,12 @@ gtk_tree_model_sort_convert_child_iter_to_iter (GtkTreeModelSort *tree_model_sor
  * @tree_model_sort: A #GtkTreeModelSort
  * @sorted_path: A #GtkTreePath to convert
  * 
- * Converts @sort_path to a path on the child model of @tree_model_sort.  That
- * is, @sort_path points ot a location in @tree_model_sort.  The returned path
- * will point to the same location in the model not being sorted.  If @path does not point to a 
+ * Converts @sorted_path to a path on the child model of @tree_model_sort.  That
+ * is, @sorted_path points to a location in @tree_model_sort.  The returned path
+ * will point to the same location in the model not being sorted.  If @sorted_path 
+ * does not point to a location in the child model, %NULL is returned.
  * 
- * Return value: A newly allocated #GtkTreePath, or %NULLL
+ * Return value: A newly allocated #GtkTreePath, or %NULL
  **/
 GtkTreePath *
 gtk_tree_model_sort_convert_path_to_child_path (GtkTreeModelSort *tree_model_sort,
@@ -2019,19 +2035,28 @@ gtk_tree_model_sort_convert_path_to_child_path (GtkTreeModelSort *tree_model_sor
 
   for (i = 0; i < gtk_tree_path_get_depth (sorted_path); i++)
     {
+      gint count = sorted_indices[i];
+
       if ((level == NULL) ||
-         (level->array->len > sorted_indices[i]))
+         (level->array->len <= count))
        {
          gtk_tree_path_free (retval);
          return NULL;
        }
-      if (g_array_index (level->array, SortElt, sorted_indices[i]).children == NULL)
-       gtk_tree_model_sort_build_level (tree_model_sort, level, &g_array_index (level->array, SortElt, sorted_indices[i]));
+
+      if (g_array_index (level->array, SortElt, count).children == NULL)
+       gtk_tree_model_sort_build_level (tree_model_sort, level, &g_array_index (level->array, SortElt, count));
+
       if (level == NULL)
-       
-      gtk_tree_path_append_index (retval, g_array_index (level->array, SortElt, i).offset);
+        {
+         gtk_tree_path_free (retval);
+         break;
+       }
+
+      gtk_tree_path_append_index (retval, g_array_index (level->array, SortElt, count).offset);
+      level = g_array_index (level->array, SortElt, count).children;
     }
-  
   return retval;
 }
 
@@ -2041,7 +2066,7 @@ gtk_tree_model_sort_convert_path_to_child_path (GtkTreeModelSort *tree_model_sor
  * @child_iter: An uninitialized #GtkTreeIter
  * @sorted_iter: A valid #GtkTreeIter pointing to a row on @tree_model_sort.
  * 
- * Sets @child_iter to point to the row pointed to by *sorted_iter.
+ * Sets @child_iter to point to the row pointed to by @sorted_iter.
  **/
 void
 gtk_tree_model_sort_convert_iter_to_child_iter (GtkTreeModelSort *tree_model_sort,
@@ -2061,21 +2086,9 @@ gtk_tree_model_sort_convert_iter_to_child_iter (GtkTreeModelSort *tree_model_sor
   else
     {
       GtkTreePath *path;
-      SortElt *elt;
-      SortLevel *level;
-
-      path = gtk_tree_path_new ();
-      elt = SORT_ELT (sorted_iter->user_data2);
-      level = SORT_LEVEL (sorted_iter->user_data);
-
-      while (level)
-       {
-         gtk_tree_path_prepend_index (path, elt->offset);
-
-         elt = level->parent_elt;
-         level = level->parent_level;
-       }
 
+      path = gtk_tree_model_sort_elt_get_path (sorted_iter->user_data,
+                                              sorted_iter->user_data2);
       gtk_tree_model_get_iter (tree_model_sort->child_model, child_iter, path);
       gtk_tree_path_free (path);
     }
@@ -2095,7 +2108,7 @@ gtk_tree_model_sort_build_level (GtkTreeModelSort *tree_model_sort,
 
   if (parent_level == NULL)
     {
-      if (gtk_tree_model_get_iter_root (tree_model_sort->child_model, &iter) == FALSE)
+      if (gtk_tree_model_get_iter_first (tree_model_sort->child_model, &iter) == FALSE)
        return;
       length = gtk_tree_model_iter_n_children (tree_model_sort->child_model, NULL);
     }
@@ -2115,6 +2128,12 @@ gtk_tree_model_sort_build_level (GtkTreeModelSort *tree_model_sort,
                                        &iter,
                                        &child_parent_iter) == FALSE)
        return;
+
+      /* stamp may have changed */
+      gtk_tree_model_sort_convert_iter_to_child_iter (tree_model_sort,
+                                                     &child_parent_iter,
+                                                     &parent_iter);
+
       length = gtk_tree_model_iter_n_children (tree_model_sort->child_model, &child_parent_iter);
     }
 
@@ -2132,20 +2151,15 @@ gtk_tree_model_sort_build_level (GtkTreeModelSort *tree_model_sort,
     tree_model_sort->root = new_level;
 
   /* increase the count of zero ref_counts.*/
-  do
+  while (parent_level)
     {
-      if (parent_elt)
-       parent_elt->zero_ref_count++;
-      else
-       tree_model_sort->zero_ref_count++;
+      parent_elt->zero_ref_count++;
 
-      if (parent_level)
-       {
-         parent_elt = parent_level->parent_elt;
-         parent_level = parent_level->parent_level;
-       }
+      parent_elt = parent_level->parent_elt;
+      parent_level = parent_level->parent_level;
     }
-  while (parent_level);
+  if (new_level != tree_model_sort->root)
+    tree_model_sort->zero_ref_count++;
 
   for (i = 0; i < length; i++)
     {
@@ -2189,10 +2203,10 @@ gtk_tree_model_sort_free_level (GtkTreeModelSort *tree_model_sort,
       do
        {
          if (parent_elt)
-           parent_elt->zero_ref_count++;
+           parent_elt->zero_ref_count--;
          else
-           tree_model_sort->zero_ref_count++;
-         
+           tree_model_sort->zero_ref_count--;
+
          if (parent_level)
            {
              parent_elt = parent_level->parent_elt;
@@ -2206,25 +2220,30 @@ gtk_tree_model_sort_free_level (GtkTreeModelSort *tree_model_sort,
     {
       if (g_array_index (sort_level->array, SortElt, i).children)
        gtk_tree_model_sort_free_level (tree_model_sort, 
-                                       (SortLevel *)&g_array_index (sort_level->array, SortElt, i).children);
+                                       SORT_LEVEL(g_array_index (sort_level->array, SortElt, i).children));
     }
 
   if (sort_level->parent_elt)
-    {
-      sort_level->parent_elt->children = NULL;
-    }
+    sort_level->parent_elt->children = NULL;
   else
-    {
-      tree_model_sort->root = NULL;
-    }
+    tree_model_sort->root = NULL;
+
   g_array_free (sort_level->array, TRUE);
+  sort_level->array = NULL;
+
   g_free (sort_level);
+  sort_level = NULL;
 }
 
 static void
 gtk_tree_model_sort_increment_stamp (GtkTreeModelSort *tree_model_sort)
 {
-  tree_model_sort->stamp++;
+  do
+    {
+      tree_model_sort->stamp++;
+    }
+  while (tree_model_sort->stamp == 0);
+
   gtk_tree_model_sort_clear_cache (tree_model_sort);
 }
 
@@ -2239,17 +2258,11 @@ gtk_tree_model_sort_clear_cache_helper (GtkTreeModelSort *tree_model_sort,
   for (i = 0; i < level->array->len; i++)
     {
       if (g_array_index (level->array, SortElt, i).zero_ref_count > 0)
-       {
-         gtk_tree_model_sort_clear_cache_helper (tree_model_sort, g_array_index (level->array, SortElt, i).children);
-       }
-    }
-
-  if (level->ref_count == 0)
-    {
-      gtk_tree_model_sort_free_level (tree_model_sort, level);
-      return;
+       gtk_tree_model_sort_clear_cache_helper (tree_model_sort, g_array_index (level->array, SortElt, i).children);
     }
 
+  if (level->ref_count == 0 && level != tree_model_sort->root)
+    gtk_tree_model_sort_free_level (tree_model_sort, level);
 }
 
 /**
@@ -2257,21 +2270,29 @@ gtk_tree_model_sort_clear_cache_helper (GtkTreeModelSort *tree_model_sort,
  * @tree_model_sort: A #GtkTreeModelSort
  * 
  * This resets the default sort function to be in the 'unsorted' state.  That
- * is, it is in the same order as the child model.
+ * is, it is in the same order as the child model. It will re-sort the model
+ * to be in the same order as the child model only if the #GtkTreeModelSort
+ * is in 'unsorted' state.
  **/
 void
 gtk_tree_model_sort_reset_default_sort_func (GtkTreeModelSort *tree_model_sort)
 {
   g_return_if_fail (GTK_IS_TREE_MODEL_SORT (tree_model_sort));
 
-  g_print ("RESET DEFAULT SORT FUNC\n");
-
   if (tree_model_sort->default_sort_destroy)
-    (* tree_model_sort->default_sort_destroy) (tree_model_sort->default_sort_data);
+    {
+      GtkDestroyNotify d = tree_model_sort->default_sort_destroy;
 
-  tree_model_sort->default_sort_func = (GtkTreeIterCompareFunc) 0x1;
+      tree_model_sort->default_sort_destroy = NULL;
+      d (tree_model_sort->default_sort_data);
+    }
+
+  tree_model_sort->default_sort_func = NO_SORT_FUNC;
   tree_model_sort->default_sort_data = NULL;
   tree_model_sort->default_sort_destroy = NULL;
+
+  if (tree_model_sort->sort_column_id == GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID)
+    gtk_tree_model_sort_sort (tree_model_sort);
   tree_model_sort->sort_column_id = GTK_TREE_SORTABLE_DEFAULT_SORT_COLUMN_ID;
 }
 
@@ -2294,3 +2315,50 @@ gtk_tree_model_sort_clear_cache (GtkTreeModelSort *tree_model_sort)
   if (tree_model_sort->zero_ref_count)
     gtk_tree_model_sort_clear_cache_helper (tree_model_sort, (SortLevel *)tree_model_sort->root);
 }
+
+static gboolean
+gtk_tree_model_sort_iter_is_valid_helper (GtkTreeIter *iter,
+                                         SortLevel   *level)
+{
+  gint i;
+
+  for (i = 0; i < level->array->len; i++)
+    {
+      SortElt *elt = &g_array_index (level->array, SortElt, i);
+
+      if (iter->user_data == level && iter->user_data2 == elt)
+       return TRUE;
+
+      if (elt->children)
+       if (gtk_tree_model_sort_iter_is_valid_helper (iter, elt->children))
+         return TRUE;
+    }
+
+  return FALSE;
+}
+
+/**
+ * gtk_tree_model_sort_iter_is_valid:
+ * @tree_model_sort: A #GtkTreeModelSort.
+ * @iter: A #GtkTreeIter.
+ *
+ * WARNING: This function is slow. Only use it for debugging and/or testing
+ * purposes.
+ *
+ * Checks if the given iter is a valid iter for this #GtkTreeModelSort.
+ *
+ * Return value: %TRUE if the iter is valid, %FALSE if the iter is invalid.
+ **/
+gboolean
+gtk_tree_model_sort_iter_is_valid (GtkTreeModelSort *tree_model_sort,
+                                   GtkTreeIter      *iter)
+{
+  g_return_val_if_fail (GTK_IS_TREE_MODEL_SORT (tree_model_sort), FALSE);
+  g_return_val_if_fail (iter != NULL, FALSE);
+
+  if (!VALID_ITER (iter, tree_model_sort))
+    return FALSE;
+
+  return gtk_tree_model_sort_iter_is_valid_helper (iter,
+                                                  tree_model_sort->root);
+}