]> Pileus Git - ~andy/gtk/blobdiff - gtk/gtktoolbutton.c
Remove the old widget from the tool button before overwriting it with the
[~andy/gtk] / gtk / gtktoolbutton.c
index a5fa3be88e6390f44273713a66780607c2cbd8f9..8723f893c3455761be0c4b25f4e6023950b9735e 100644 (file)
@@ -1,6 +1,6 @@
 /* gtktoolbutton.c
  *
- * Copyright (C) 2002 Anders Carlsson <andersca@codefactory.se>
+ * Copyright (C) 2002 Anders Carlsson <andersca@gnome.org>
  * Copyright (C) 2002 James Henstridge <james@daa.com.au>
  * Copyright (C) 2003 Soeren Sandmann <sandmann@daimi.au.dk>
  *
@@ -20,6 +20,7 @@
  * Boston, MA 02111-1307, USA.
  */
 
+#include <config.h>
 #include "gtktoolbutton.h"
 #include "gtkbutton.h"
 #include "gtkhbox.h"
@@ -30,6 +31,8 @@
 #include "gtkstock.h"
 #include "gtkvbox.h"
 #include "gtkintl.h"
+#include "gtktoolbar.h"
+#include "gtkiconfactory.h"
 
 #include <string.h>
 
@@ -46,17 +49,12 @@ enum {
   PROP_USE_UNDERLINE,
   PROP_LABEL_WIDGET,
   PROP_STOCK_ID,
-  PROP_ICON_SET,
   PROP_ICON_WIDGET,
 };
 
 static void gtk_tool_button_init          (GtkToolButton      *button,
                                           GtkToolButtonClass *klass);
 static void gtk_tool_button_class_init    (GtkToolButtonClass *klass);
-static void gtk_tool_button_size_request  (GtkWidget          *widget,
-                                          GtkRequisition     *requisition);
-static void gtk_tool_button_size_allocate (GtkWidget          *widget,
-                                          GtkAllocation      *allocation);
 static void gtk_tool_button_set_property  (GObject            *object,
                                           guint               prop_id,
                                           const GValue       *value,
@@ -65,6 +63,8 @@ static void gtk_tool_button_get_property  (GObject            *object,
                                           guint               prop_id,
                                           GValue             *value,
                                           GParamSpec         *pspec);
+static void gtk_tool_button_property_notify (GObject          *object,
+                                            GParamSpec       *pspec);
 static void gtk_tool_button_finalize      (GObject            *object);
 
 static void gtk_tool_button_toolbar_reconfigured (GtkToolItem *tool_item);
@@ -77,6 +77,20 @@ static void gtk_tool_button_construct_contents (GtkToolItem *tool_item);
 static GObjectClass *parent_class = NULL;
 static guint         toolbutton_signals[LAST_SIGNAL] = { 0 };
 
+#define GTK_TOOL_BUTTON_GET_PRIVATE(obj)(G_TYPE_INSTANCE_GET_PRIVATE ((obj), GTK_TYPE_TOOL_BUTTON, GtkToolButtonPrivate))
+
+struct _GtkToolButtonPrivate
+{
+  GtkWidget *button;
+
+  gchar *stock_id;
+  gchar *label_text;
+  GtkWidget *label_widget;
+  GtkWidget *icon_widget;
+  
+  guint use_underline : 1;
+};
+
 GType
 gtk_tool_button_get_type (void)
 {
@@ -119,59 +133,90 @@ gtk_tool_button_class_init (GtkToolButtonClass *klass)
   
   object_class->set_property = gtk_tool_button_set_property;
   object_class->get_property = gtk_tool_button_get_property;
+  object_class->notify = gtk_tool_button_property_notify;
   object_class->finalize = gtk_tool_button_finalize;
 
-  widget_class->size_request = gtk_tool_button_size_request;
-  widget_class->size_allocate = gtk_tool_button_size_allocate;
-
   tool_item_class->create_menu_proxy = gtk_tool_button_create_menu_proxy;
   tool_item_class->toolbar_reconfigured = gtk_tool_button_toolbar_reconfigured;
   
   klass->button_type = GTK_TYPE_BUTTON;
 
+  /* Properties are interpreted like this:
+   *
+   *          - if the tool button has an icon_widget, then that widget
+   *            will be used as the icon. Otherwise, if the tool button
+   *            has a stock id, the corresponding stock icon will be
+   *            used. Otherwise, the tool button will not have an icon.
+   *
+   *          - if the tool button has a label_widget then that widget
+   *            will be used as the label. Otherwise, if the tool button
+   *            has a label text, that text will be used as label. Otherwise,
+   *            if the toolbutton has a stock id, the corresponding text
+   *            will be used as label. Otherwise, the toolbutton will
+   *            have an empty label.
+   *
+   *         - The use_underline property only has an effect when the label
+   *            on the toolbutton comes from the label property (ie. not from
+   *            label_widget or from stock_id).
+   *
+   *            In that case, if use_underline is set,
+   *
+   *                   - underscores are removed from the label text before
+   *                      the label is shown on the toolbutton unless the
+   *                      underscore is followed by another underscore
+   *
+   *                   - an underscore indicates that the next character when
+   *                      used in the overflow menu should be used as a
+   *                      mnemonic.
+   *
+   *           In short: use_underline = TRUE means that the label text has
+   *            the form "_Open" and the toolbar should take appropriate
+   *            action.
+   */
+
   g_object_class_install_property (object_class,
                                   PROP_LABEL,
                                   g_param_spec_string ("label",
-                                                       _("Label"),
-                                                       _("Text to show in the item."),
+                                                       P_("Label"),
+                                                       P_("Text to show in the item."),
                                                        NULL,
                                                        G_PARAM_READWRITE));
   g_object_class_install_property (object_class,
                                   PROP_USE_UNDERLINE,
                                   g_param_spec_boolean ("use_underline",
-                                                        _("Use underline"),
-                                                        _("Interpret underlines in the item label"),
+                                                        P_("Use underline"),
+                                                        P_("If set, an underline in the label property indicates that the next character should be used for the mnemonic accelerator key in the overflow menu"),
                                                         FALSE,
                                                         G_PARAM_READWRITE));
   g_object_class_install_property (object_class,
                                   PROP_LABEL_WIDGET,
                                   g_param_spec_object ("label_widget",
-                                                       _("Label widget"),
-                                                       _("Widget to use as the item label"),
+                                                       P_("Label widget"),
+                                                       P_("Widget to use as the item label"),
                                                        GTK_TYPE_WIDGET,
                                                        G_PARAM_READWRITE));
   g_object_class_install_property (object_class,
                                   PROP_STOCK_ID,
                                   g_param_spec_string ("stock_id",
-                                                       _("Stock Id"),
-                                                       _("The stock icon displayed on the item"),
+                                                       P_("Stock Id"),
+                                                       P_("The stock icon displayed on the item"),
                                                        NULL,
                                                        G_PARAM_READWRITE));
-  g_object_class_install_property (object_class,
-                                  PROP_ICON_SET,
-                                  g_param_spec_boxed ("icon_set",
-                                                      _("Icon set"),
-                                                      _("Icon set to use to draw the item's icon"),
-                                                      GTK_TYPE_ICON_SET,
-                                                      G_PARAM_READWRITE));
   g_object_class_install_property (object_class,
                                   PROP_ICON_WIDGET,
                                   g_param_spec_object ("icon_widget",
-                                                       _("Icon widget"),
-                                                       _("Icon widget to display in the item"),
+                                                       P_("Icon widget"),
+                                                       P_("Icon widget to display in the item"),
                                                        GTK_TYPE_WIDGET,
                                                        G_PARAM_READWRITE));
 
+/**
+ * GtkToolButton::clicked:
+ * @toolbutton: the object that emitted the signal
+ *
+ * This signal is emitted when the tool button is clicked with the mouse
+ * or activated with the keyboard.
+ **/
   toolbutton_signals[CLICKED] =
     g_signal_new ("clicked",
                  G_OBJECT_CLASS_TYPE (klass),
@@ -180,6 +225,8 @@ gtk_tool_button_class_init (GtkToolButtonClass *klass)
                  NULL, NULL,
                  g_cclosure_marshal_VOID__VOID,
                  G_TYPE_NONE, 0);
+  
+  g_type_class_add_private (object_class, sizeof (GtkToolButtonPrivate));
 }
 
 static void
@@ -188,92 +235,18 @@ gtk_tool_button_init (GtkToolButton      *button,
 {
   GtkToolItem *toolitem = GTK_TOOL_ITEM (button);
   
-  toolitem->homogeneous = TRUE;
+  button->priv = GTK_TOOL_BUTTON_GET_PRIVATE (button);
+
+  gtk_tool_item_set_homogeneous (toolitem, TRUE);
 
   /* create button */
-  button->button = g_object_new (klass->button_type, NULL);
-  gtk_button_set_focus_on_click (button->button, FALSE);
-  g_signal_connect_object (button->button, "clicked",
+  button->priv->button = g_object_new (klass->button_type, NULL);
+  gtk_button_set_focus_on_click (GTK_BUTTON (button->priv->button), FALSE);
+  g_signal_connect_object (button->priv->button, "clicked",
                           G_CALLBACK (button_clicked), button, 0);
 
-  gtk_container_add (GTK_CONTAINER (button), button->button);
-  gtk_widget_show (button->button);
-}
-
-static void
-gtk_tool_button_size_request (GtkWidget      *widget,
-                             GtkRequisition *requisition)
-{
-  GtkWidget *child = GTK_BIN (widget)->child;
-
-  if (child && GTK_WIDGET_VISIBLE (child))
-    {
-      gtk_widget_size_request (child, requisition);
-    }
-  else
-    {
-      requisition->width = 0;
-      requisition->height = 0;
-    }
-  
-  requisition->width += GTK_CONTAINER (widget)->border_width * 2;
-  requisition->height += GTK_CONTAINER (widget)->border_width * 2;  
-}
-
-static void
-gtk_tool_button_size_allocate (GtkWidget     *widget,
-                              GtkAllocation *allocation)
-{
-  GtkToolItem *toolitem = GTK_TOOL_ITEM (widget);
-  GtkAllocation child_allocation;
-  gint border_width;
-  GtkWidget *child = GTK_BIN (widget)->child;
-
-  widget->allocation = *allocation;
-  border_width = GTK_CONTAINER (widget)->border_width;
-
-  if (toolitem->drag_window && GTK_WIDGET_REALIZED (widget))
-    gdk_window_move_resize (toolitem->drag_window,
-                            widget->allocation.x + border_width,
-                            widget->allocation.y + border_width,
-                            widget->allocation.width - border_width * 2,
-                            widget->allocation.height - border_width * 2);
-  
-  if (child && GTK_WIDGET_VISIBLE (child))
-    {
-      child_allocation.x = allocation->x + border_width;
-      child_allocation.y = allocation->y + border_width;
-      child_allocation.width = allocation->width - 2 * border_width;
-      child_allocation.height = allocation->height - 2 * border_width;
-      
-      gtk_widget_size_allocate (child, &child_allocation);
-    }
-}
-
-static gchar *
-elide_underscores (const gchar *original)
-{
-  gchar *q, *result;
-  const gchar *p;
-  gboolean last_underscore;
-
-  q = result = g_malloc (strlen (original) + 1);
-  last_underscore = FALSE;
-  
-  for (p = original; *p; p++)
-    {
-      if (!last_underscore && *p == '_')
-       last_underscore = TRUE;
-      else
-       {
-         last_underscore = FALSE;
-         *q++ = *p;
-       }
-    }
-  
-  *q = '\0';
-  
-  return result;
+  gtk_container_add (GTK_CONTAINER (button), button->priv->button);
+  gtk_widget_show (button->priv->button);
 }
 
 static void
@@ -296,22 +269,24 @@ gtk_tool_button_construct_contents (GtkToolItem *tool_item)
       gtk_tool_item_set_proxy_menu_item (tool_item, MENU_ID, NULL);
     }
   
-  if (button->icon_widget && button->icon_widget->parent)
+  if (button->priv->icon_widget && button->priv->icon_widget->parent)
     {
-      gtk_container_remove (GTK_CONTAINER (button->icon_widget->parent),
-                           button->icon_widget);
+      gtk_container_remove (GTK_CONTAINER (button->priv->icon_widget->parent),
+                           button->priv->icon_widget);
     }
 
-  if (button->label_widget && button->label_widget->parent)
+  if (button->priv->label_widget && button->priv->label_widget->parent)
     {
-      gtk_container_remove (GTK_CONTAINER (button->label_widget->parent),
-                           button->label_widget);
+      gtk_container_remove (GTK_CONTAINER (button->priv->label_widget->parent),
+                           button->priv->label_widget);
     }
 
-  if (GTK_BIN (button->button)->child)
+  if (GTK_BIN (button->priv->button)->child)
     {
-      gtk_container_remove (GTK_CONTAINER (button->button),
-                           GTK_BIN (button->button)->child);
+      /* Note: we are not destroying the label_widget or icon_widget
+       * here because they were removed from their containers above
+       */
+      gtk_widget_destroy (GTK_BIN (button->priv->button)->child);
     }
 
   style = gtk_tool_item_get_toolbar_style (GTK_TOOL_ITEM (button));
@@ -319,33 +294,51 @@ gtk_tool_button_construct_contents (GtkToolItem *tool_item)
   if (style != GTK_TOOLBAR_TEXT)
     need_icon = TRUE;
 
-  if (style != GTK_TOOLBAR_ICONS)
+  if (style != GTK_TOOLBAR_ICONS && style != GTK_TOOLBAR_BOTH_HORIZ)
     need_label = TRUE;
 
+  if (style == GTK_TOOLBAR_BOTH_HORIZ &&
+      (gtk_tool_item_get_is_important (GTK_TOOL_ITEM (button)) ||
+       gtk_tool_item_get_orientation (GTK_TOOL_ITEM (button)) == GTK_ORIENTATION_VERTICAL))
+    {
+      need_label = TRUE;
+    }
+  
+  if (style != GTK_TOOLBAR_ICONS &&
+      ((style != GTK_TOOLBAR_BOTH_HORIZ ||
+       gtk_tool_item_get_is_important (GTK_TOOL_ITEM (button)))))
+    need_label = TRUE;
+  
   if (need_label)
     {
-      if (button->label_widget)
+      if (button->priv->label_widget)
        {
-         label = button->label_widget;
+         label = button->priv->label_widget;
        }
       else
        {
          GtkStockItem stock_item;
-         gboolean elide = TRUE;
+         gboolean elide;
          gchar *label_text;
 
-         if (button->label_text)
+         if (button->priv->label_text)
            {
-             label_text = button->label_text;
-             elide = button->use_underline;
+             label_text = button->priv->label_text;
+             elide = button->priv->use_underline;
+           }
+         else if (button->priv->stock_id && gtk_stock_lookup (button->priv->stock_id, &stock_item))
+           {
+             label_text = stock_item.label;
+             elide = TRUE;
            }
-         else if (button->stock_id && gtk_stock_lookup (button->stock_id, &stock_item))
-           label_text = stock_item.label;
          else
-           label_text = "";
+           {
+             label_text = "";
+             elide = FALSE;
+           }
 
          if (elide)
-           label_text = elide_underscores (label_text);
+           label_text = _gtk_toolbar_elide_underscores (label_text);
          else
            label_text = g_strdup (label_text);
 
@@ -360,41 +353,20 @@ gtk_tool_button_construct_contents (GtkToolItem *tool_item)
   icon_size = gtk_tool_item_get_icon_size (GTK_TOOL_ITEM (button));
   if (need_icon)
     {
-      if (button->icon_set)
+      if (button->priv->icon_widget)
        {
-         icon = gtk_image_new_from_icon_set (button->icon_set, icon_size);
-         gtk_widget_show (icon);
-       }
-      else if (button->icon_widget)
-       {
-         icon = button->icon_widget;
+         icon = button->priv->icon_widget;
          
          if (GTK_IS_IMAGE (icon))
            {
-             GtkImage *image = GTK_IMAGE (icon);
-             GtkImageType storage_type = gtk_image_get_storage_type (image);
-             
-             if (storage_type == GTK_IMAGE_STOCK)
-               {
-                 gchar *stock_id;
-                 gtk_image_get_stock (image, &stock_id, NULL);
-
-                 icon = gtk_image_new_from_stock (stock_id, icon_size);
-                 gtk_widget_show (icon);
-               }
-             else if (storage_type == GTK_IMAGE_ICON_SET)
-               {
-                 GtkIconSet *icon_set;
-                 gtk_image_get_icon_set (image, &icon_set, NULL);
-                 
-                 icon = gtk_image_new_from_icon_set (icon_set, icon_size);
-                 gtk_widget_show (icon);
-               }
+             g_object_set (G_OBJECT (button->priv->icon_widget),
+                           "icon-size", icon_size,
+                           NULL);
            }
        }
-      else if (button->stock_id)
+      else if (button->priv->stock_id)
        {
-         icon = gtk_image_new_from_stock (button->stock_id, icon_size);
+         icon = gtk_image_new_from_stock (button->priv->stock_id, icon_size);
          gtk_widget_show (icon);
        }
     }
@@ -403,32 +375,35 @@ gtk_tool_button_construct_contents (GtkToolItem *tool_item)
     {
     case GTK_TOOLBAR_ICONS:
       if (icon)
-       gtk_container_add (GTK_CONTAINER (button->button), icon);
+       gtk_container_add (GTK_CONTAINER (button->priv->button), icon);
       break;
 
     case GTK_TOOLBAR_BOTH:
       box = gtk_vbox_new (FALSE, 0);
-      gtk_box_pack_start (GTK_BOX (box), icon, TRUE, TRUE, 0);
+      if (icon)
+       gtk_box_pack_start (GTK_BOX (box), icon, TRUE, TRUE, 0);
       gtk_box_pack_start (GTK_BOX (box), label, FALSE, TRUE, 0);
-      gtk_container_add (GTK_CONTAINER (button->button), box);
+      gtk_container_add (GTK_CONTAINER (button->priv->button), box);
       break;
 
     case GTK_TOOLBAR_BOTH_HORIZ:
       box = gtk_hbox_new (FALSE, 0);
-      gtk_box_pack_start (GTK_BOX (box), icon, FALSE, TRUE, 0);
-      gtk_box_pack_start (GTK_BOX (box), label, TRUE, TRUE, 0);
-      gtk_container_add (GTK_CONTAINER (button->button), box);
+      if (icon)
+       gtk_box_pack_start (GTK_BOX (box), icon, label? FALSE : TRUE, TRUE, 0);
+      if (label)
+       gtk_box_pack_start (GTK_BOX (box), label, TRUE, TRUE, 0);
+      gtk_container_add (GTK_CONTAINER (button->priv->button), box);
       break;
 
     case GTK_TOOLBAR_TEXT:
-      gtk_container_add (GTK_CONTAINER (button->button), label);
+      gtk_container_add (GTK_CONTAINER (button->priv->button), label);
       break;
     }
 
   if (box)
     gtk_widget_show (box);
 
-  gtk_button_set_relief (GTK_BUTTON (button->button),
+  gtk_button_set_relief (GTK_BUTTON (button->priv->button),
                         gtk_tool_item_get_relief_style (GTK_TOOL_ITEM (button)));
 
   gtk_widget_queue_resize (GTK_WIDGET (button));
@@ -456,9 +431,6 @@ gtk_tool_button_set_property (GObject         *object,
     case PROP_STOCK_ID:
       gtk_tool_button_set_stock_id (button, g_value_get_string (value));
       break;
-    case PROP_ICON_SET:
-      gtk_tool_button_set_icon_set (button, g_value_get_boxed (value));
-      break;
     case PROP_ICON_WIDGET:
       gtk_tool_button_set_icon_widget (button, g_value_get_object (value));
       break;
@@ -467,6 +439,17 @@ gtk_tool_button_set_property (GObject         *object,
     }
 }
 
+static void
+gtk_tool_button_property_notify (GObject          *object,
+                                GParamSpec       *pspec)
+{
+  if (strcmp (pspec->name, "is-important") == 0)
+    gtk_tool_button_construct_contents (GTK_TOOL_ITEM (object));
+
+  if (parent_class->notify)
+    parent_class->notify (object, pspec);
+}
+
 static void
 gtk_tool_button_get_property (GObject         *object,
                              guint            prop_id,
@@ -487,13 +470,10 @@ gtk_tool_button_get_property (GObject         *object,
       g_value_set_boolean (value, gtk_tool_button_get_use_underline (button));
       break;
     case PROP_STOCK_ID:
-      g_value_set_string (value, button->stock_id);
-      break;
-    case PROP_ICON_SET:
-      g_value_set_boxed (value, gtk_tool_button_get_icon_set (button));
+      g_value_set_string (value, button->priv->stock_id);
       break;
     case PROP_ICON_WIDGET:
-      g_value_set_object (value, button->icon_widget);
+      g_value_set_object (value, button->priv->icon_widget);
       break;
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
@@ -505,12 +485,59 @@ gtk_tool_button_finalize (GObject *object)
 {
   GtkToolButton *button = GTK_TOOL_BUTTON (object);
 
-  g_free (button->stock_id);
-  button->stock_id = NULL;
+  if (button->priv->stock_id)
+    g_free (button->priv->stock_id);
+
+  if (button->priv->label_text)
+    g_free (button->priv->label_text);
+
+  if (button->priv->label_widget)
+    g_object_unref (G_OBJECT (button->priv->label_widget));
 
+  if (button->priv->icon_widget)
+    g_object_unref (G_OBJECT (button->priv->icon_widget));
+  
   parent_class->finalize (object);
 }
 
+static GtkWidget *
+clone_image_menu_size (GtkImage *image, GtkSettings *settings)
+{
+  GtkImageType storage_type = gtk_image_get_storage_type (image);
+
+  if (storage_type == GTK_IMAGE_STOCK)
+    {
+      gchar *stock_id;
+      gtk_image_get_stock (image, &stock_id, NULL);
+      return gtk_image_new_from_stock (stock_id, GTK_ICON_SIZE_MENU);
+    }
+  else if (storage_type == GTK_IMAGE_ICON_SET)
+    {
+      GtkIconSet *icon_set;
+      gtk_image_get_icon_set (image, &icon_set, NULL);
+      return gtk_image_new_from_icon_set (icon_set, GTK_ICON_SIZE_MENU);
+    }
+  else if (storage_type == GTK_IMAGE_PIXBUF)
+    {
+      gint width, height;
+      
+      if (settings &&
+         gtk_icon_size_lookup_for_settings (settings, GTK_ICON_SIZE_MENU,
+                                            &width, &height))
+       {
+         GdkPixbuf *src_pixbuf, *dest_pixbuf;
+
+         src_pixbuf = gtk_image_get_pixbuf (image);
+         dest_pixbuf = gdk_pixbuf_scale_simple (src_pixbuf, width, height,
+                                                GDK_INTERP_BILINEAR);
+
+         return gtk_image_new_from_pixbuf (dest_pixbuf);
+       }
+    }
+
+  return NULL;
+}
+      
 static gboolean
 gtk_tool_button_create_menu_proxy (GtkToolItem *item)
 {
@@ -519,48 +546,40 @@ gtk_tool_button_create_menu_proxy (GtkToolItem *item)
   GtkWidget *menu_image = NULL;
   GtkStockItem stock_item;
   gboolean use_mnemonic = TRUE;
-  const char *label = "";
+  const char *label;
 
-  if (button->label_widget && GTK_IS_LABEL (button->label_widget))
-    label = gtk_label_get_label (GTK_LABEL (button->label_widget));
-  else if (button->label_text)
+  if (button->priv->label_widget && GTK_IS_LABEL (button->priv->label_widget))
+    {
+      label = gtk_label_get_label (GTK_LABEL (button->priv->label_widget));
+      use_mnemonic = gtk_label_get_use_underline (GTK_LABEL (button->priv->label_widget));
+    }
+  else if (button->priv->label_text)
+    {
+      label = button->priv->label_text;
+      use_mnemonic = button->priv->use_underline;
+    }
+  else if (button->priv->stock_id && gtk_stock_lookup (button->priv->stock_id, &stock_item))
+    {
+      label = stock_item.label;
+    }
+  else
     {
-      label = button->label_text;
-      use_mnemonic = button->use_underline;
+      label = "";
     }
-  else if (button->stock_id && gtk_stock_lookup (button->stock_id, &stock_item))
-    label = stock_item.label;
   
   if (use_mnemonic)
     menu_item = gtk_image_menu_item_new_with_mnemonic (label);
   else
     menu_item = gtk_image_menu_item_new_with_label (label);
 
-  if (button->icon_set)
+  if (button->priv->icon_widget && GTK_IS_IMAGE (button->priv->icon_widget))
     {
-      menu_image = gtk_image_new_from_icon_set (button->icon_set, GTK_ICON_SIZE_MENU);
-    }
-  else if (button->icon_widget && GTK_IS_IMAGE (button->icon_widget))
-    {
-      GtkImage *image = GTK_IMAGE (button->icon_widget);
-      GtkImageType storage_type = gtk_image_get_storage_type (image);
-      
-      if (storage_type == GTK_IMAGE_STOCK)
-       {
-         gchar *stock_id;
-         gtk_image_get_stock (image, &stock_id, NULL);
-         menu_image = gtk_image_new_from_stock (stock_id, GTK_ICON_SIZE_MENU);
-       }
-      else if (storage_type == GTK_IMAGE_ICON_SET)
-       {
-         GtkIconSet *icon_set;
-         gtk_image_get_icon_set (image, &icon_set, NULL);
-         menu_image = gtk_image_new_from_icon_set (icon_set, GTK_ICON_SIZE_MENU);
-       }
+      menu_image = clone_image_menu_size (GTK_IMAGE (button->priv->icon_widget),
+                                         gtk_widget_get_settings (GTK_WIDGET (button)));
     }
-  else if (button->stock_id)
+  else if (button->priv->stock_id)
     {
-      menu_image = gtk_image_new_from_stock (button->stock_id, GTK_ICON_SIZE_MENU);
+      menu_image = gtk_image_new_from_stock (button->priv->stock_id, GTK_ICON_SIZE_MENU);
     }
 
   if (menu_image)
@@ -569,7 +588,7 @@ gtk_tool_button_create_menu_proxy (GtkToolItem *item)
   g_signal_connect_closure_by_id (menu_item,
                                  g_signal_lookup ("activate", G_OBJECT_TYPE (menu_item)), 0,
                                  g_cclosure_new_object_swap (G_CALLBACK (gtk_button_clicked),
-                                                             G_OBJECT (GTK_TOOL_BUTTON (button)->button)),
+                                                             G_OBJECT (GTK_TOOL_BUTTON (button)->priv->button)),
                                  FALSE);
 
   gtk_tool_item_set_proxy_menu_item (GTK_TOOL_ITEM (button), MENU_ID, menu_item);
@@ -590,6 +609,20 @@ gtk_tool_button_toolbar_reconfigured (GtkToolItem *tool_item)
   gtk_tool_button_construct_contents (tool_item);
 }
 
+/**
+ * gtk_tool_button_new_from_stock:
+ * @stock_id: the name of the stock item 
+ *
+ * Creates a new #GtkToolButton containing the image and text from a
+ * stock item. Some stock ids have preprocessor macros like #GTK_STOCK_OK
+ * and #GTK_STOCK_APPLY.
+ *
+ * It is an error if @stock_id is not a name of a stock item.
+ * 
+ * Return value: A new #GtkToolButton
+ * 
+ * Since: 2.4
+ **/
 GtkToolItem *
 gtk_tool_button_new_from_stock (const gchar *stock_id)
 {
@@ -604,17 +637,49 @@ gtk_tool_button_new_from_stock (const gchar *stock_id)
   return GTK_TOOL_ITEM (button);
 }
 
+/**
+ * gtk_tool_button_new:
+ * @label: a string that will be used as label, or %NULL
+ * @icon_widget: a widget that will be used as icon widget, or %NULL
+ * 
+ * Creates a new %GtkToolButton using @icon_widget as icon and @label as
+ * label.
+ * 
+ * Return value: A new #GtkToolButton
+ * 
+ * Since: 2.4
+ **/
 GtkToolItem *
-gtk_tool_button_new (void)
+gtk_tool_button_new (GtkWidget  *icon_widget,
+                    const gchar *label)
 {
   GtkToolButton *button;
-  
+
   button = g_object_new (GTK_TYPE_TOOL_BUTTON,
                         NULL);
+  
+  if (label)
+    gtk_tool_button_set_label (button, label);
+
+  if (icon_widget)
+    gtk_tool_button_set_icon_widget (button, icon_widget);
 
   return GTK_TOOL_ITEM (button);  
 }
 
+/**
+ * gtk_tool_button_set_label:
+ * @button: a #GtkToolButton
+ * @label: a string that will be used as label, or %NULL.
+ * 
+ * Sets @label as the label used for the tool button. The "label" property
+ * only has an effect if not overridden by a non-%NULL "label_widget" property.
+ * If both the "label_widget" and "label" properties are %NULL, the label
+ * is determined by the "stock_id" property. If the "stock_id" property is also
+ * %NULL, @button will not have a label.
+ * 
+ * Since: 2.4
+ **/
 void
 gtk_tool_button_set_label (GtkToolButton *button,
                           const gchar   *label)
@@ -623,9 +688,9 @@ gtk_tool_button_set_label (GtkToolButton *button,
   
   g_return_if_fail (GTK_IS_TOOL_BUTTON (button));
 
-  old_label = button->label_text;
+  old_label = button->priv->label_text;
 
-  button->label_text = g_strdup (label);
+  button->priv->label_text = g_strdup (label);
   gtk_tool_button_construct_contents (GTK_TOOL_ITEM (button));
       
   g_object_notify (G_OBJECT (button), "label");
@@ -634,14 +699,42 @@ gtk_tool_button_set_label (GtkToolButton *button,
     g_free (old_label);
 }
 
+/**
+ * gtk_tool_button_get_label:
+ * @button: a #GtkToolButton
+ * 
+ * Returns the label used by the tool button, or %NULL if the tool button
+ * doesn't have a label. or uses a the label from a stock item. The returned
+ * string is owned by GTK+, and must not be modified or freed.
+ * 
+ * Return value: The label, or %NULL
+ * 
+ * Since: 2.4
+ **/
 G_CONST_RETURN gchar *
 gtk_tool_button_get_label (GtkToolButton *button)
 {
   g_return_val_if_fail (GTK_IS_TOOL_BUTTON (button), NULL);
 
-  return button->label_text;
+  return button->priv->label_text;
 }
 
+/**
+ * gtk_tool_button_set_use_underline:
+ * @button: a #GtkToolButton
+ * @use_underline: whether the button label has the form "_Open"
+ *
+ * If set, an underline in the label property indicates that the next character
+ * should be used for the mnemonic accelerator key in the overflow menu. For
+ * example, if the label property is "_Open" and @use_underline is %TRUE,
+ * the label on the tool button will be "Open" and the item on the overflow
+ * menu will have an underlined 'O'.
+ * 
+ * Labels shown on tool buttons never have mnemonics on them; this property
+ * only affects the menu item on the overflow menu.
+ * 
+ * Since: 2.4
+ **/
 void
 gtk_tool_button_set_use_underline (GtkToolButton *button,
                                   gboolean       use_underline)
@@ -650,9 +743,9 @@ gtk_tool_button_set_use_underline (GtkToolButton *button,
 
   use_underline = use_underline != FALSE;
 
-  if (use_underline != button->use_underline)
+  if (use_underline != button->priv->use_underline)
     {
-      button->use_underline = use_underline;
+      button->priv->use_underline = use_underline;
 
       gtk_tool_button_construct_contents (GTK_TOOL_ITEM (button));
 
@@ -660,14 +753,37 @@ gtk_tool_button_set_use_underline (GtkToolButton *button,
     }
 }
 
+/**
+ * gtk_tool_button_get_use_underline:
+ * @button: a #GtkToolButton
+ * 
+ * Returns whether underscores in the label property are used as mnemonics
+ * on menu items on the overflow menu. See gtk_tool_button_set_use_underline().
+ * 
+ * Return value: %TRUE if underscores in the label property are used as
+ * mnemonics on menu items on the overflow menu.
+ * 
+ * Since: 2.4
+ **/
 gboolean
 gtk_tool_button_get_use_underline (GtkToolButton *button)
 {
   g_return_val_if_fail (GTK_IS_TOOL_BUTTON (button), FALSE);
 
-  return button->use_underline;
+  return button->priv->use_underline;
 }
 
+/**
+ * gtk_tool_button_set_stock_id:
+ * @button: a #GtkToolButton
+ * @stock_id: a name of a stock item, or %NULL
+ * 
+ * Sets the name of the stock item. See gtk_tool_button_new_from_stock().
+ * The stock_id property only has an effect if not
+ * overridden by non-%NULL "label" and "icon_widget" properties.
+ * 
+ * Since: 2.4
+ **/
 void
 gtk_tool_button_set_stock_id (GtkToolButton *button,
                              const gchar   *stock_id)
@@ -676,9 +792,9 @@ gtk_tool_button_set_stock_id (GtkToolButton *button,
   
   g_return_if_fail (GTK_IS_TOOL_BUTTON (button));
 
-  old_stock_id = button->stock_id;
+  old_stock_id = button->priv->stock_id;
 
-  button->stock_id = g_strdup (stock_id);
+  button->priv->stock_id = g_strdup (stock_id);
   gtk_tool_button_construct_contents (GTK_TOOL_ITEM (button));
   
   g_object_notify (G_OBJECT (button), "stock_id");
@@ -686,51 +802,83 @@ gtk_tool_button_set_stock_id (GtkToolButton *button,
   g_free (old_stock_id);
 }
 
+/**
+ * gtk_tool_button_get_stock_id:
+ * @button: a #GtkToolButton
+ * 
+ * Returns the name of the stock item. See gtk_tool_button_set_stock_id().
+ * The returned string is owned by GTK+ and must not be freed or modifed.
+ * 
+ * Return value: the name of the stock item for @button.
+ * 
+ * Since: 2.4
+ **/
 G_CONST_RETURN gchar *
 gtk_tool_button_get_stock_id (GtkToolButton *button)
 {
   g_return_val_if_fail (GTK_IS_TOOL_BUTTON (button), NULL);
 
-  return button->stock_id;
+  return button->priv->stock_id;
 }
 
+/**
+ * gtk_tool_button_set_icon_widget:
+ * @button: a #GtkToolButton
+ * @icon_widget: the widget used as icon, or %NULL
+ * 
+ * Sets @icon as the widget used as icon on @button. If @icon_widget is
+ * %NULL the icon is determined by the "stock_id" property. If the
+ * "stock_id" property is also %NULL, @button will not have an icon.
+ * 
+ * Since: 2.4
+ **/
 void
 gtk_tool_button_set_icon_widget (GtkToolButton *button,
-                                GtkWidget     *icon)
+                                GtkWidget     *icon_widget)
 {
   g_return_if_fail (GTK_IS_TOOL_BUTTON (button));
-  g_return_if_fail (icon == NULL || GTK_IS_WIDGET (icon));
+  g_return_if_fail (icon_widget == NULL || GTK_IS_WIDGET (icon_widget));
 
-  if (icon != button->icon_widget)
+  if (icon_widget != button->priv->icon_widget)
     {
-      g_object_freeze_notify (G_OBJECT (button));
-      
-      if (button->icon_widget)
-       g_object_unref (G_OBJECT (button->icon_widget));
-
-      if (icon)
+      if (button->priv->icon_widget)
        {
-         g_object_ref (icon);
-         gtk_object_sink (GTK_OBJECT (icon));
-       }
+         if (button->priv->icon_widget->parent)
+           {
+             gtk_container_remove (GTK_CONTAINER (button->priv->icon_widget->parent),
+                                   button->priv->icon_widget);
+           }
 
-      button->icon_widget = icon;
-       
-      if (button->icon_widget && button->icon_set)
+         g_object_unref (G_OBJECT (button->priv->icon_widget));
+       }
+      
+      if (icon_widget)
        {
-         gtk_icon_set_unref (button->icon_set);
-         button->icon_set = NULL;
-         
-         g_object_notify (G_OBJECT (button), "icon_set");
+         g_object_ref (icon_widget);
+         gtk_object_sink (GTK_OBJECT (icon_widget));
        }
 
+      button->priv->icon_widget = icon_widget;
+
       gtk_tool_button_construct_contents (GTK_TOOL_ITEM (button));
       
       g_object_notify (G_OBJECT (button), "icon_widget");
-      g_object_thaw_notify (G_OBJECT (button));
     }
 }
 
+/**
+ * gtk_tool_button_set_label_widget:
+ * @button: a #GtkToolButton
+ * @label_widget: the widget used as label, or %NULL
+ * 
+ * Sets @label_widget as the widget that will be used as the label
+ * for @button. If @label_widget is %NULL the "label" property is used
+ * as label. If "label" is also %NULL, the label in the stock item
+ * determined by the "stock_id" property is used as label. If
+ * "stock_id" is also %NULL, @button does not have a label.
+ * 
+ * Since: 2.4
+ **/
 void
 gtk_tool_button_set_label_widget (GtkToolButton *button,
                                  GtkWidget     *label_widget)
@@ -738,18 +886,26 @@ gtk_tool_button_set_label_widget (GtkToolButton *button,
   g_return_if_fail (GTK_IS_TOOL_BUTTON (button));
   g_return_if_fail (label_widget == NULL || GTK_IS_WIDGET (label_widget));
 
-  if (label_widget != button->label_widget)
+  if (label_widget != button->priv->label_widget)
     {
-      if (button->label_widget)
-       g_object_unref (button->label_widget);
-
+      if (button->priv->label_widget)
+       {
+         if (button->priv->icon_widget->parent)
+           {
+             gtk_container_remove (GTK_CONTAINER (button->priv->icon_widget->parent),
+                                   button->priv->icon_widget);
+           }
+         
+         g_object_unref (button->priv->label_widget);
+       }
+      
       if (label_widget)
        {
          g_object_ref (label_widget);
          gtk_object_sink (GTK_OBJECT (label_widget));
        }
 
-      button->label_widget = label_widget;
+      button->priv->label_widget = label_widget;
 
       gtk_tool_button_construct_contents (GTK_TOOL_ITEM (button));
       
@@ -757,56 +913,49 @@ gtk_tool_button_set_label_widget (GtkToolButton *button,
     }
 }
 
+/**
+ * gtk_tool_button_get_label_widget:
+ * @button: a #GtkToolButton
+ * 
+ * Returns the widget used as label on @button. See
+ * gtk_tool_button_set_label_widget().
+ * 
+ * Return value: The widget used as label on @button, or %NULL.
+ * 
+ * Since: 2.4
+ **/
 GtkWidget *
 gtk_tool_button_get_label_widget (GtkToolButton *button)
 {
   g_return_val_if_fail (GTK_IS_TOOL_BUTTON (button), NULL);
 
-  return button->label_widget;
+  return button->priv->label_widget;
 }
 
+/**
+ * gtk_tool_button_get_icon_widget:
+ * @button: a #GtkToolButton
+ * 
+ * Return the widget used as icon widget on @button. See
+ * gtk_tool_button_set_icon_widget().
+ * 
+ * Return value: The widget used as icon on @button, or %NULL.
+ * 
+ * Since: 2.4
+ **/
 GtkWidget *
 gtk_tool_button_get_icon_widget (GtkToolButton *button)
 {
-  g_return_val_if_fail (GTK_IS_BUTTON (button), NULL);
+  g_return_val_if_fail (GTK_IS_TOOL_BUTTON (button), NULL);
 
-  return button->icon_widget;
+  return button->priv->icon_widget;
 }
 
-void
-gtk_tool_button_set_icon_set (GtkToolButton *button,
-                             GtkIconSet    *icon_set)
+GtkWidget *
+_gtk_tool_button_get_button (GtkToolButton *button)
 {
-  g_return_if_fail (GTK_IS_TOOL_BUTTON (button));
-
-  if (icon_set != button->icon_set)
-    {
-      g_object_freeze_notify (G_OBJECT (button));
-
-      if (button->icon_set)
-       gtk_icon_set_unref (button->icon_set);
-
-      button->icon_set = icon_set;
-
-      if (button->icon_set && button->icon_widget)
-       {
-         g_object_unref (button->icon_widget);
-         button->icon_widget = NULL;
-
-         g_object_notify (G_OBJECT (button->icon_widget), "icon_widget");
-       }
+  g_return_val_if_fail (GTK_IS_TOOL_BUTTON (button), NULL);
 
-      gtk_tool_button_construct_contents (GTK_TOOL_ITEM (button));
-      
-      g_object_notify (G_OBJECT (button), "icon_set");
-      g_object_thaw_notify (G_OBJECT (button));
-    }
+  return button->priv->button;
 }
 
-GtkIconSet *
-gtk_tool_button_get_icon_set (GtkToolButton *button)
-{
-  g_return_val_if_fail (GTK_IS_TOOL_BUTTON (button), NULL);
-  
-  return button->icon_set;
-}