]> Pileus Git - ~andy/gtk/blobdiff - gtk/gtktoolbutton.c
Merge branch 'master' into toolpalette
[~andy/gtk] / gtk / gtktoolbutton.c
index fcb7f92f91d56465d3fb5da8bbe0d160f24220f5..38055e06cf6bf27ec1945b5bfcba3ff6c18ecdc8 100644 (file)
@@ -20,7 +20,7 @@
  * Boston, MA 02111-1307, USA.
  */
 
-#include <config.h>
+#include "config.h"
 #include "gtktoolbutton.h"
 #include "gtkbutton.h"
 #include "gtkhbox.h"
@@ -32,7 +32,7 @@
 #include "gtkvbox.h"
 #include "gtkintl.h"
 #include "gtktoolbar.h"
-#include "gtkiconfactory.h"
+#include "gtkactivatable.h"
 #include "gtkprivate.h"
 #include "gtkalias.h"
 
@@ -74,13 +74,18 @@ static void gtk_tool_button_toolbar_reconfigured (GtkToolItem *tool_item);
 static gboolean   gtk_tool_button_create_menu_proxy (GtkToolItem     *item);
 static void       button_clicked                    (GtkWidget       *widget,
                                                     GtkToolButton   *button);
+static void gtk_tool_button_style_set      (GtkWidget          *widget,
+                                           GtkStyle           *prev_style);
 
 static void gtk_tool_button_construct_contents (GtkToolItem *tool_item);
-      
-static GObjectClass *parent_class = NULL;
-static guint         toolbutton_signals[LAST_SIGNAL] = { 0 };
 
-#define GTK_TOOL_BUTTON_GET_PRIVATE(obj)(G_TYPE_INSTANCE_GET_PRIVATE ((obj), GTK_TYPE_TOOL_BUTTON, GtkToolButtonPrivate))
+static void gtk_tool_button_activatable_interface_init (GtkActivatableIface  *iface);
+static void gtk_tool_button_update                     (GtkActivatable       *activatable,
+                                                       GtkAction            *action,
+                                                       const gchar          *property_name);
+static void gtk_tool_button_sync_action_properties     (GtkActivatable       *activatable,
+                                                       GtkAction            *action);
+
 
 struct _GtkToolButtonPrivate
 {
@@ -91,33 +96,43 @@ struct _GtkToolButtonPrivate
   gchar *label_text;
   GtkWidget *label_widget;
   GtkWidget *icon_widget;
-  
+
+  GtkSizeGroup *text_size_group;
+
   guint use_underline : 1;
+  guint contents_invalid : 1;
 };
 
+static GObjectClass        *parent_class = NULL;
+static GtkActivatableIface *parent_activatable_iface;
+static guint                toolbutton_signals[LAST_SIGNAL] = { 0 };
+
+#define GTK_TOOL_BUTTON_GET_PRIVATE(obj)(G_TYPE_INSTANCE_GET_PRIVATE ((obj), GTK_TYPE_TOOL_BUTTON, GtkToolButtonPrivate))
+
 GType
 gtk_tool_button_get_type (void)
 {
-  static GtkType type = 0;
-
+  static GType type = 0;
+  
   if (!type)
     {
-      static const GTypeInfo type_info =
-       {
-         sizeof (GtkToolButtonClass),
-         (GBaseInitFunc) NULL,
-         (GBaseFinalizeFunc) NULL,
-         (GClassInitFunc) gtk_tool_button_class_init,
-         (GClassFinalizeFunc) NULL,
-         NULL,
-         sizeof (GtkToolButton),
-         0, /* n_preallocs */
-         (GInstanceInitFunc) gtk_tool_button_init,
-       };
-
-      type = g_type_register_static (GTK_TYPE_TOOL_ITEM,
-                                    I_("GtkToolButton"),
-                                    &type_info, 0);
+      const GInterfaceInfo activatable_info =
+      {
+        (GInterfaceInitFunc) gtk_tool_button_activatable_interface_init,
+        (GInterfaceFinalizeFunc) NULL,
+        NULL
+      };
+
+      type = g_type_register_static_simple (GTK_TYPE_TOOL_ITEM,
+                                           I_("GtkToolButton"),
+                                           sizeof (GtkToolButtonClass),
+                                           (GClassInitFunc) gtk_tool_button_class_init,
+                                           sizeof (GtkToolButton),
+                                           (GInstanceInitFunc) gtk_tool_button_init,
+                                           0);
+
+      g_type_add_interface_static (type, GTK_TYPE_ACTIVATABLE,
+                                   &activatable_info);
     }
   return type;
 }
@@ -126,11 +141,13 @@ static void
 gtk_tool_button_class_init (GtkToolButtonClass *klass)
 {
   GObjectClass *object_class;
+  GtkWidgetClass *widget_class;
   GtkToolItemClass *tool_item_class;
   
   parent_class = g_type_class_peek_parent (klass);
   
   object_class = (GObjectClass *)klass;
+  widget_class = (GtkWidgetClass *)klass;
   tool_item_class = (GtkToolItemClass *)klass;
   
   object_class->set_property = gtk_tool_button_set_property;
@@ -138,6 +155,8 @@ gtk_tool_button_class_init (GtkToolButtonClass *klass)
   object_class->notify = gtk_tool_button_property_notify;
   object_class->finalize = gtk_tool_button_finalize;
 
+  widget_class->style_set = gtk_tool_button_style_set;
+
   tool_item_class->create_menu_proxy = gtk_tool_button_create_menu_proxy;
   tool_item_class->toolbar_reconfigured = gtk_tool_button_toolbar_reconfigured;
   
@@ -232,6 +251,22 @@ gtk_tool_button_class_init (GtkToolButtonClass *klass)
                                                        GTK_TYPE_WIDGET,
                                                        GTK_PARAM_READWRITE));
 
+  /**
+   * GtkButton:icon-spacing:
+   * 
+   * Spacing in pixels between the icon and label.
+   * 
+   * Since: 2.10
+   */
+  gtk_widget_class_install_style_property (widget_class,
+                                          g_param_spec_int ("icon-spacing",
+                                                            P_("Icon spacing"),
+                                                            P_("Spacing in pixels between the icon and label"),
+                                                            0,
+                                                            G_MAXINT,
+                                                            0,
+                                                            GTK_PARAM_READWRITE));
+
 /**
  * GtkToolButton::clicked:
  * @toolbutton: the object that emitted the signal
@@ -242,7 +277,7 @@ gtk_tool_button_class_init (GtkToolButtonClass *klass)
   toolbutton_signals[CLICKED] =
     g_signal_new (I_("clicked"),
                  G_OBJECT_CLASS_TYPE (klass),
-                 G_SIGNAL_RUN_FIRST,
+                 G_SIGNAL_RUN_FIRST | G_SIGNAL_ACTION,
                  G_STRUCT_OFFSET (GtkToolButtonClass, clicked),
                  NULL, NULL,
                  g_cclosure_marshal_VOID__VOID,
@@ -259,6 +294,8 @@ gtk_tool_button_init (GtkToolButton      *button,
   
   button->priv = GTK_TOOL_BUTTON_GET_PRIVATE (button);
 
+  button->priv->contents_invalid = TRUE;
+
   gtk_tool_item_set_homogeneous (toolitem, TRUE);
 
   /* create button */
@@ -282,6 +319,15 @@ gtk_tool_button_construct_contents (GtkToolItem *tool_item)
   gboolean need_icon = FALSE;
   GtkIconSize icon_size;
   GtkWidget *box = NULL;
+  guint icon_spacing;
+  GtkOrientation text_orientation = GTK_ORIENTATION_HORIZONTAL;
+  GtkSizeGroup *size_group = NULL;
+
+  button->priv->contents_invalid = FALSE;
+
+  gtk_widget_style_get (GTK_WIDGET (tool_item), 
+                       "icon-spacing", &icon_spacing,
+                       NULL);
 
   if (button->priv->icon_widget && button->priv->icon_widget->parent)
     {
@@ -313,7 +359,8 @@ gtk_tool_button_construct_contents (GtkToolItem *tool_item)
 
   if (style == GTK_TOOLBAR_BOTH_HORIZ &&
       (gtk_tool_item_get_is_important (GTK_TOOL_ITEM (button)) ||
-       gtk_tool_item_get_orientation (GTK_TOOL_ITEM (button)) == GTK_ORIENTATION_VERTICAL))
+       gtk_tool_item_get_orientation (GTK_TOOL_ITEM (button)) == GTK_ORIENTATION_VERTICAL ||
+       gtk_tool_item_get_text_orientation (GTK_TOOL_ITEM (button)) == GTK_ORIENTATION_VERTICAL))
     {
       need_label = TRUE;
     }
@@ -373,6 +420,28 @@ gtk_tool_button_construct_contents (GtkToolItem *tool_item)
          
          gtk_widget_show (label);
        }
+
+      gtk_label_set_ellipsize (GTK_LABEL (label),
+                              gtk_tool_item_get_ellipsize_mode (GTK_TOOL_ITEM (button)));
+      text_orientation = gtk_tool_item_get_text_orientation (GTK_TOOL_ITEM (button));
+      if (text_orientation == GTK_ORIENTATION_HORIZONTAL)
+       {
+          gtk_label_set_angle (GTK_LABEL (label), 0);
+          gtk_misc_set_alignment (GTK_MISC (label),
+                                  gtk_tool_item_get_text_alignment (GTK_TOOL_ITEM (button)),
+                                  0.5);
+        }
+      else
+        {
+          gtk_label_set_ellipsize (GTK_LABEL (label), PANGO_ELLIPSIZE_NONE);
+         if (gtk_widget_get_direction (GTK_WIDGET (tool_item)) == GTK_TEXT_DIR_RTL)
+           gtk_label_set_angle (GTK_LABEL (label), -90);
+         else
+           gtk_label_set_angle (GTK_LABEL (label), 90);
+          gtk_misc_set_alignment (GTK_MISC (label),
+                                  0.5,
+                                  1 - gtk_tool_item_get_text_alignment (GTK_TOOL_ITEM (button)));
+        }
     }
 
   icon_size = gtk_tool_item_get_icon_size (GTK_TOOL_ITEM (button));
@@ -389,7 +458,8 @@ gtk_tool_button_construct_contents (GtkToolItem *tool_item)
                            NULL);
            }
        }
-      else if (button->priv->stock_id)
+      else if (button->priv->stock_id && 
+              gtk_icon_factory_lookup_default (button->priv->stock_id))
        {
          icon = gtk_image_new_from_stock (button->priv->stock_id, icon_size);
          gtk_widget_show (icon);
@@ -399,6 +469,22 @@ gtk_tool_button_construct_contents (GtkToolItem *tool_item)
          icon = gtk_image_new_from_icon_name (button->priv->icon_name, icon_size);
          gtk_widget_show (icon);
        }
+
+      if (icon && text_orientation == GTK_ORIENTATION_HORIZONTAL)
+       gtk_misc_set_alignment (GTK_MISC (icon),
+                               1.0 - gtk_tool_item_get_text_alignment (GTK_TOOL_ITEM (button)),
+                               0.5);
+      else if (icon)
+       gtk_misc_set_alignment (GTK_MISC (icon),
+                               0.5,
+                               gtk_tool_item_get_text_alignment (GTK_TOOL_ITEM (button)));
+
+      if (icon)
+       {
+         size_group = gtk_tool_item_get_text_size_group (GTK_TOOL_ITEM (button));
+         if (size_group != NULL)
+           gtk_size_group_add_widget (size_group, icon);
+       }
     }
 
   switch (style)
@@ -409,19 +495,33 @@ gtk_tool_button_construct_contents (GtkToolItem *tool_item)
       break;
 
     case GTK_TOOLBAR_BOTH:
-      box = gtk_vbox_new (FALSE, 0);
+      if (text_orientation == GTK_ORIENTATION_HORIZONTAL)
+       box = gtk_vbox_new (FALSE, icon_spacing);
+      else
+       box = gtk_hbox_new (FALSE, icon_spacing);
       if (icon)
        gtk_box_pack_start (GTK_BOX (box), icon, TRUE, TRUE, 0);
-      gtk_box_pack_start (GTK_BOX (box), label, FALSE, TRUE, 0);
+      gtk_box_pack_end (GTK_BOX (box), label, FALSE, TRUE, 0);
       gtk_container_add (GTK_CONTAINER (button->priv->button), box);
       break;
 
     case GTK_TOOLBAR_BOTH_HORIZ:
-      box = gtk_hbox_new (FALSE, 0);
-      if (icon)
-       gtk_box_pack_start (GTK_BOX (box), icon, label? FALSE : TRUE, TRUE, 0);
-      if (label)
-       gtk_box_pack_start (GTK_BOX (box), label, TRUE, TRUE, 0);
+      if (text_orientation == GTK_ORIENTATION_HORIZONTAL)
+       {
+         box = gtk_hbox_new (FALSE, icon_spacing);
+         if (icon)
+           gtk_box_pack_start (GTK_BOX (box), icon, label? FALSE : TRUE, TRUE, 0);
+         if (label)
+           gtk_box_pack_end (GTK_BOX (box), label, TRUE, TRUE, 0);
+       }
+      else
+       {
+         box = gtk_vbox_new (FALSE, icon_spacing);
+         if (icon)
+           gtk_box_pack_end (GTK_BOX (box), icon, label ? FALSE : TRUE, TRUE, 0);
+         if (label)
+           gtk_box_pack_start (GTK_BOX (box), label, TRUE, TRUE, 0);
+       }
       gtk_container_add (GTK_CONTAINER (button->priv->button), box);
       break;
 
@@ -471,6 +571,7 @@ gtk_tool_button_set_property (GObject         *object,
       break;
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
+      break;
     }
 }
 
@@ -478,7 +579,10 @@ static void
 gtk_tool_button_property_notify (GObject          *object,
                                 GParamSpec       *pspec)
 {
-  if (strcmp (pspec->name, "is-important") == 0)
+  GtkToolButton *button = GTK_TOOL_BUTTON (object);
+
+  if (button->priv->contents_invalid ||
+      strcmp ("is-important", pspec->name) == 0)
     gtk_tool_button_construct_contents (GTK_TOOL_ITEM (object));
 
   if (parent_class->notify)
@@ -515,6 +619,7 @@ gtk_tool_button_get_property (GObject         *object,
       break;
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
+      break;
     }
 }
 
@@ -553,6 +658,12 @@ clone_image_menu_size (GtkImage *image, GtkSettings *settings)
       gtk_image_get_icon_set (image, &icon_set, NULL);
       return gtk_image_new_from_icon_set (icon_set, GTK_ICON_SIZE_MENU);
     }
+  else if (storage_type == GTK_IMAGE_GICON)
+    {
+      GIcon *icon;
+      gtk_image_get_gicon (image, &icon, NULL);
+      return gtk_image_new_from_gicon (icon, GTK_ICON_SIZE_MENU);
+    }
   else if (storage_type == GTK_IMAGE_PIXBUF)
     {
       gint width, height;
@@ -588,7 +699,10 @@ gtk_tool_button_create_menu_proxy (GtkToolItem *item)
   gboolean use_mnemonic = TRUE;
   const char *label;
 
-  if (button->priv->label_widget && GTK_IS_LABEL (button->priv->label_widget))
+  if (_gtk_tool_item_create_menu_proxy (item))
+    return TRUE;
+  if (GTK_IS_LABEL (button->priv->label_widget))
     {
       label = gtk_label_get_label (GTK_LABEL (button->priv->label_widget));
       use_mnemonic = gtk_label_get_use_underline (GTK_LABEL (button->priv->label_widget));
@@ -612,7 +726,7 @@ gtk_tool_button_create_menu_proxy (GtkToolItem *item)
   else
     menu_item = gtk_image_menu_item_new_with_label (label);
 
-  if (button->priv->icon_widget && GTK_IS_IMAGE (button->priv->icon_widget))
+  if (GTK_IS_IMAGE (button->priv->icon_widget))
     {
       menu_image = clone_image_menu_size (GTK_IMAGE (button->priv->icon_widget),
                                          gtk_widget_get_settings (GTK_WIDGET (button)));
@@ -640,6 +754,13 @@ static void
 button_clicked (GtkWidget     *widget,
                GtkToolButton *button)
 {
+  GtkAction *action;
+
+  action = gtk_activatable_get_related_action (GTK_ACTIVATABLE (button));
+  
+  if (action)
+    gtk_action_activate (action);
+
   g_signal_emit_by_name (button, "clicked");
 }
 
@@ -649,6 +770,127 @@ gtk_tool_button_toolbar_reconfigured (GtkToolItem *tool_item)
   gtk_tool_button_construct_contents (tool_item);
 }
 
+static void 
+gtk_tool_button_update_icon_spacing (GtkToolButton *button)
+{
+  GtkWidget *box;
+  guint spacing;
+
+  box = GTK_BIN (button->priv->button)->child;
+  if (GTK_IS_BOX (box))
+    {
+      gtk_widget_style_get (GTK_WIDGET (button), 
+                           "icon-spacing", &spacing,
+                           NULL);
+      gtk_box_set_spacing (GTK_BOX (box), spacing);      
+    }
+}
+
+static void
+gtk_tool_button_style_set (GtkWidget *widget,
+                          GtkStyle  *prev_style)
+{
+  gtk_tool_button_update_icon_spacing (GTK_TOOL_BUTTON (widget));
+}
+
+static void 
+gtk_tool_button_activatable_interface_init (GtkActivatableIface  *iface)
+{
+  parent_activatable_iface = g_type_interface_peek_parent (iface);
+  iface->update = gtk_tool_button_update;
+  iface->sync_action_properties = gtk_tool_button_sync_action_properties;
+}
+
+static void
+gtk_tool_button_update (GtkActivatable *activatable,
+                       GtkAction      *action,
+                       const gchar    *property_name)
+{
+  GtkToolButton *button;
+  GtkWidget *image;
+
+  parent_activatable_iface->update (activatable, action, property_name);
+
+  if (!gtk_activatable_get_use_action_appearance (activatable))
+    return;
+
+  button = GTK_TOOL_BUTTON (activatable);
+  
+  if (strcmp (property_name, "short-label") == 0)
+    gtk_tool_button_set_label (button, gtk_action_get_short_label (action));
+  else if (strcmp (property_name, "stock-id") == 0)
+    gtk_tool_button_set_stock_id (button, gtk_action_get_stock_id (action));
+  else if (strcmp (property_name, "gicon") == 0)
+    {
+      const gchar *stock_id = gtk_action_get_stock_id (action);
+      GIcon *icon = gtk_action_get_gicon (action);
+      GtkIconSize icon_size = GTK_ICON_SIZE_BUTTON;
+
+      if ((stock_id && gtk_icon_factory_lookup_default (stock_id)) || !icon)
+       image = NULL;
+      else 
+       {   
+         image = gtk_tool_button_get_icon_widget (button);
+         icon_size = gtk_tool_item_get_icon_size (GTK_TOOL_ITEM (button));
+
+         if (!image)
+           image = gtk_image_new ();
+       }
+
+      gtk_tool_button_set_icon_widget (button, image);
+      gtk_image_set_from_gicon (GTK_IMAGE (image), icon, icon_size);
+
+    }
+  else if (strcmp (property_name, "icon-name") == 0)
+    gtk_tool_button_set_icon_name (button, gtk_action_get_icon_name (action));
+}
+
+static void
+gtk_tool_button_sync_action_properties (GtkActivatable *activatable,
+                                       GtkAction      *action)
+{
+  GtkToolButton *button;
+  GIcon         *icon;
+  const gchar   *stock_id;
+
+  parent_activatable_iface->sync_action_properties (activatable, action);
+
+  if (!action)
+    return;
+
+  if (!gtk_activatable_get_use_action_appearance (activatable))
+    return;
+
+  button = GTK_TOOL_BUTTON (activatable);
+  stock_id = gtk_action_get_stock_id (action);
+
+  gtk_tool_button_set_label (button, gtk_action_get_short_label (action));
+  gtk_tool_button_set_use_underline (button, TRUE);
+  gtk_tool_button_set_stock_id (button, stock_id);
+  gtk_tool_button_set_icon_name (button, gtk_action_get_icon_name (action));
+
+  if (stock_id && gtk_icon_factory_lookup_default (stock_id))
+      gtk_tool_button_set_icon_widget (button, NULL);
+  else if ((icon = gtk_action_get_gicon (action)) != NULL)
+    {
+      GtkIconSize icon_size = gtk_tool_item_get_icon_size (GTK_TOOL_ITEM (button));
+      GtkWidget  *image = gtk_tool_button_get_icon_widget (button);
+      
+      if (!image)
+       {
+         image = gtk_image_new ();
+         gtk_widget_show (image);
+         gtk_tool_button_set_icon_widget (button, image);
+       }
+
+      gtk_image_set_from_gicon (GTK_IMAGE (image), icon, icon_size);
+    }
+  else if (gtk_action_get_icon_name (action))
+    gtk_tool_button_set_icon_name (button, gtk_action_get_icon_name (action));
+  else
+    gtk_tool_button_set_label (button, gtk_action_get_short_label (action));
+}
+
 /**
  * gtk_tool_button_new_from_stock:
  * @stock_id: the name of the stock item 
@@ -696,13 +938,9 @@ gtk_tool_button_new (GtkWidget      *icon_widget,
   GtkToolButton *button;
 
   button = g_object_new (GTK_TYPE_TOOL_BUTTON,
+                         "label", label,
+                         "icon-widget", icon_widget,
                         NULL);
-  
-  if (label)
-    gtk_tool_button_set_label (button, label);
-
-  if (icon_widget)
-    gtk_tool_button_set_icon_widget (button, icon_widget);
 
   return GTK_TOOL_ITEM (button);  
 }
@@ -725,18 +963,27 @@ gtk_tool_button_set_label (GtkToolButton *button,
                           const gchar   *label)
 {
   gchar *old_label;
+  gchar *elided_label;
+  AtkObject *accessible;
   
   g_return_if_fail (GTK_IS_TOOL_BUTTON (button));
 
   old_label = button->priv->label_text;
 
   button->priv->label_text = g_strdup (label);
-  gtk_tool_button_construct_contents (GTK_TOOL_ITEM (button));
-      
-  g_object_notify (G_OBJECT (button), "label");
+  button->priv->contents_invalid = TRUE;     
 
-  if (old_label)
-    g_free (old_label);
+  if (label)
+    {
+      elided_label = _gtk_toolbar_elide_underscores (label);
+      accessible = gtk_widget_get_accessible (GTK_WIDGET (button->priv->button));
+      atk_object_set_name (accessible, elided_label);
+      g_free (elided_label);
+    }
+
+  g_free (old_label);
+  g_object_notify (G_OBJECT (button), "label");
 }
 
 /**
@@ -786,8 +1033,7 @@ gtk_tool_button_set_use_underline (GtkToolButton *button,
   if (use_underline != button->priv->use_underline)
     {
       button->priv->use_underline = use_underline;
-
-      gtk_tool_button_construct_contents (GTK_TOOL_ITEM (button));
+      button->priv->contents_invalid = TRUE;
 
       g_object_notify (G_OBJECT (button), "use-underline");
     }
@@ -835,11 +1081,11 @@ gtk_tool_button_set_stock_id (GtkToolButton *button,
   old_stock_id = button->priv->stock_id;
 
   button->priv->stock_id = g_strdup (stock_id);
-  gtk_tool_button_construct_contents (GTK_TOOL_ITEM (button));
-  
-  g_object_notify (G_OBJECT (button), "stock-id");
+  button->priv->contents_invalid = TRUE;
 
   g_free (old_stock_id);
+  
+  g_object_notify (G_OBJECT (button), "stock-id");
 }
 
 /**
@@ -885,11 +1131,11 @@ gtk_tool_button_set_icon_name (GtkToolButton *button,
   old_icon_name = button->priv->icon_name;
 
   button->priv->icon_name = g_strdup (icon_name);
-  gtk_tool_button_construct_contents (GTK_TOOL_ITEM (button));
-
-  g_object_notify (G_OBJECT (button), "icon-name");
+  button->priv->contents_invalid = TRUE; 
 
   g_free (old_icon_name);
+
+  g_object_notify (G_OBJECT (button), "icon-name");
 }
 
 /**
@@ -935,22 +1181,17 @@ gtk_tool_button_set_icon_widget (GtkToolButton *button,
       if (button->priv->icon_widget)
        {
          if (button->priv->icon_widget->parent)
-           {
-             gtk_container_remove (GTK_CONTAINER (button->priv->icon_widget->parent),
+           gtk_container_remove (GTK_CONTAINER (button->priv->icon_widget->parent),
                                    button->priv->icon_widget);
-           }
 
          g_object_unref (button->priv->icon_widget);
        }
       
       if (icon_widget)
-       {
-         g_object_ref_sink (icon_widget);
-       }
+       g_object_ref_sink (icon_widget);
 
       button->priv->icon_widget = icon_widget;
-
-      gtk_tool_button_construct_contents (GTK_TOOL_ITEM (button));
+      button->priv->contents_invalid = TRUE;
       
       g_object_notify (G_OBJECT (button), "icon-widget");
     }
@@ -981,22 +1222,17 @@ gtk_tool_button_set_label_widget (GtkToolButton *button,
       if (button->priv->label_widget)
        {
          if (button->priv->label_widget->parent)
-           {
-             gtk_container_remove (GTK_CONTAINER (button->priv->label_widget->parent),
-                                   button->priv->label_widget);
-           }
+           gtk_container_remove (GTK_CONTAINER (button->priv->label_widget->parent),
+                                 button->priv->label_widget);
          
          g_object_unref (button->priv->label_widget);
        }
       
       if (label_widget)
-       {
-         g_object_ref_sink (label_widget);
-       }
+       g_object_ref_sink (label_widget);
 
       button->priv->label_widget = label_widget;
-
-      gtk_tool_button_construct_contents (GTK_TOOL_ITEM (button));
+      button->priv->contents_invalid = TRUE;
       
       g_object_notify (G_OBJECT (button), "label-widget");
     }
@@ -1048,5 +1284,6 @@ _gtk_tool_button_get_button (GtkToolButton *button)
   return button->priv->button;
 }
 
+
 #define __GTK_TOOL_BUTTON_C__
 #include "gtkaliasdef.c"