]> Pileus Git - ~andy/gtk/blobdiff - gtk/gtktexttag.c
Get rid of incorrect calls to g_value_init(). (#100669, Johan Dahlin,
[~andy/gtk] / gtk / gtktexttag.c
index 4f35a80b956f4d0a7d9d2dae23514fe190094cf5..38c314e8e083cfb76bf4fba1f2778aa4abded84b 100644 (file)
@@ -51,8 +51,9 @@
 #include "gtktexttag.h"
 #include "gtktexttypes.h"
 #include "gtktexttagtable.h"
-#include "gtksignal.h"
 #include "gtkmain.h"
+#include "gtkintl.h"
+#include "gtkmarshalers.h"
 
 #include <stdlib.h>
 #include <string.h>
@@ -63,99 +64,113 @@ enum {
 };
 
 enum {
-  ARG_0,
+  PROP_0,
   /* Construct args */
-  ARG_NAME,
+  PROP_NAME,
 
   /* Style args */
-  ARG_BACKGROUND,
-  ARG_FOREGROUND,
-  ARG_BACKGROUND_GDK,
-  ARG_FOREGROUND_GDK,
-  ARG_BACKGROUND_STIPPLE,
-  ARG_FOREGROUND_STIPPLE,
-  ARG_FONT,
-  ARG_FONT_DESC,
-  ARG_PIXELS_ABOVE_LINES,
-  ARG_PIXELS_BELOW_LINES,
-  ARG_PIXELS_INSIDE_WRAP,
-  ARG_EDITABLE,
-  ARG_WRAP_MODE,
-  ARG_JUSTIFY,
-  ARG_DIRECTION,
-  ARG_LEFT_MARGIN,
-  ARG_INDENT,
-  ARG_STRIKETHROUGH,
-  ARG_RIGHT_MARGIN,
-  ARG_UNDERLINE,
-  ARG_OFFSET,
-  ARG_BG_FULL_HEIGHT,
-  ARG_LANGUAGE,
-  ARG_TABS,
-  ARG_INVISIBLE,
+  PROP_BACKGROUND,
+  PROP_FOREGROUND,
+  PROP_BACKGROUND_GDK,
+  PROP_FOREGROUND_GDK,
+  PROP_BACKGROUND_STIPPLE,
+  PROP_FOREGROUND_STIPPLE,
+  PROP_FONT,
+  PROP_FONT_DESC,
+  PROP_FAMILY,
+  PROP_STYLE,
+  PROP_VARIANT,
+  PROP_WEIGHT,
+  PROP_STRETCH,
+  PROP_SIZE,
+  PROP_SIZE_POINTS,
+  PROP_SCALE,
+  PROP_PIXELS_ABOVE_LINES,
+  PROP_PIXELS_BELOW_LINES,
+  PROP_PIXELS_INSIDE_WRAP,
+  PROP_EDITABLE,
+  PROP_WRAP_MODE,
+  PROP_JUSTIFICATION,
+  PROP_DIRECTION,
+  PROP_LEFT_MARGIN,
+  PROP_INDENT,
+  PROP_STRIKETHROUGH,
+  PROP_RIGHT_MARGIN,
+  PROP_UNDERLINE,
+  PROP_RISE,
+  PROP_BG_FULL_HEIGHT,
+  PROP_LANGUAGE,
+  PROP_TABS,
+  PROP_INVISIBLE,
   
   /* Whether-a-style-arg-is-set args */
-  ARG_BACKGROUND_SET,
-  ARG_FOREGROUND_SET,
-  ARG_BACKGROUND_GDK_SET,
-  ARG_FOREGROUND_GDK_SET,
-  ARG_BACKGROUND_STIPPLE_SET,
-  ARG_FOREGROUND_STIPPLE_SET,
-  ARG_FONT_SET,
-  ARG_PIXELS_ABOVE_LINES_SET,
-  ARG_PIXELS_BELOW_LINES_SET,
-  ARG_PIXELS_INSIDE_WRAP_SET,
-  ARG_EDITABLE_SET,
-  ARG_WRAP_MODE_SET,
-  ARG_JUSTIFY_SET,
-  ARG_LEFT_MARGIN_SET,
-  ARG_INDENT_SET,
-  ARG_STRIKETHROUGH_SET,
-  ARG_RIGHT_MARGIN_SET,
-  ARG_UNDERLINE_SET,
-  ARG_OFFSET_SET,
-  ARG_BG_FULL_HEIGHT_SET,
-  ARG_LANGUAGE_SET,
-  ARG_TABS_SET,
-  ARG_INVISIBLE_SET,
+  PROP_BACKGROUND_SET,
+  PROP_FOREGROUND_SET,
+  PROP_BACKGROUND_STIPPLE_SET,
+  PROP_FOREGROUND_STIPPLE_SET,
+  PROP_FAMILY_SET,
+  PROP_STYLE_SET,
+  PROP_VARIANT_SET,
+  PROP_WEIGHT_SET,
+  PROP_STRETCH_SET,
+  PROP_SIZE_SET,
+  PROP_SCALE_SET,
+  PROP_PIXELS_ABOVE_LINES_SET,
+  PROP_PIXELS_BELOW_LINES_SET,
+  PROP_PIXELS_INSIDE_WRAP_SET,
+  PROP_EDITABLE_SET,
+  PROP_WRAP_MODE_SET,
+  PROP_JUSTIFICATION_SET,
+  PROP_LEFT_MARGIN_SET,
+  PROP_INDENT_SET,
+  PROP_STRIKETHROUGH_SET,
+  PROP_RIGHT_MARGIN_SET,
+  PROP_UNDERLINE_SET,
+  PROP_RISE_SET,
+  PROP_BG_FULL_HEIGHT_SET,
+  PROP_LANGUAGE_SET,
+  PROP_TABS_SET,
+  PROP_INVISIBLE_SET,
 
   LAST_ARG
 };
-
-static void gtk_text_tag_init       (GtkTextTag      *text_tag);
-static void gtk_text_tag_class_init (GtkTextTagClass *klass);
-static void gtk_text_tag_destroy    (GtkObject       *object);
-static void gtk_text_tag_finalize   (GObject         *object);
-static void gtk_text_tag_set_arg    (GtkObject       *object,
-                                     GtkArg          *arg,
-                                     guint            arg_id);
-static void gtk_text_tag_get_arg    (GtkObject       *object,
-                                     GtkArg          *arg,
-                                     guint            arg_id);
-
-static GtkObjectClass *parent_class = NULL;
+static void gtk_text_tag_init         (GtkTextTag      *text_tag);
+static void gtk_text_tag_class_init   (GtkTextTagClass *klass);
+static void gtk_text_tag_finalize     (GObject         *object);
+static void gtk_text_tag_set_property (GObject         *object,
+                                       guint            prop_id,
+                                       const GValue    *value,
+                                       GParamSpec      *pspec);
+static void gtk_text_tag_get_property (GObject         *object,
+                                       guint            prop_id,
+                                       GValue          *value,
+                                       GParamSpec      *pspec);
+
+static GObjectClass *parent_class = NULL;
 static guint signals[LAST_SIGNAL] = { 0 };
 
-GtkType
+GType
 gtk_text_tag_get_type (void)
 {
-  static GtkType our_type = 0;
+  static GType our_type = 0;
 
   if (our_type == 0)
     {
-      static const GtkTypeInfo our_info =
+      static const GTypeInfo our_info =
       {
-        "GtkTextTag",
-        sizeof (GtkTextTag),
         sizeof (GtkTextTagClass),
-        (GtkClassInitFunc) gtk_text_tag_class_init,
-        (GtkObjectInitFunc) gtk_text_tag_init,
-        /* reserved_1 */ NULL,
-        /* reserved_2 */ NULL,
-        (GtkClassInitFunc) NULL
+        (GBaseInitFunc) NULL,
+        (GBaseFinalizeFunc) NULL,
+        (GClassInitFunc) gtk_text_tag_class_init,
+        NULL,           /* class_finalize */
+        NULL,           /* class_data */
+        sizeof (GtkTextTag),
+        0,              /* n_preallocs */
+        (GInstanceInitFunc) gtk_text_tag_init
       };
 
-      our_type = gtk_type_unique (GTK_TYPE_OBJECT, &our_info);
+      our_type = g_type_register_static (G_TYPE_OBJECT, "GtkTextTag",
+                                         &our_info, 0);
     }
 
   return our_type;
@@ -164,146 +179,460 @@ gtk_text_tag_get_type (void)
 static void
 gtk_text_tag_class_init (GtkTextTagClass *klass)
 {
-  GObjectClass *gobject_class = G_OBJECT_CLASS (klass);
-  GtkObjectClass *object_class = GTK_OBJECT_CLASS (klass);
+  GObjectClass *object_class = G_OBJECT_CLASS (klass);
+
+  parent_class = g_type_class_peek_parent (klass);
 
-  parent_class = gtk_type_class (GTK_TYPE_OBJECT);
+  object_class->set_property = gtk_text_tag_set_property;
+  object_class->get_property = gtk_text_tag_get_property;
+  
+  object_class->finalize = gtk_text_tag_finalize;
 
   /* Construct */
-  gtk_object_add_arg_type ("GtkTextTag::name", GTK_TYPE_STRING,
-                           GTK_ARG_READWRITE | GTK_ARG_CONSTRUCT_ONLY,
-                           ARG_NAME);
+  g_object_class_install_property (object_class,
+                                   PROP_NAME,
+                                   g_param_spec_string ("name",
+                                                        _("Tag name"),
+                                                        _("Name used to refer to the text tag. NULL for anonymous tags"),
+                                                        NULL,
+                                                        G_PARAM_READABLE | G_PARAM_WRITABLE | G_PARAM_CONSTRUCT_ONLY));
 
   /* Style args */
-  gtk_object_add_arg_type ("GtkTextTag::background", GTK_TYPE_STRING,
-                           GTK_ARG_WRITABLE, ARG_BACKGROUND);
-  gtk_object_add_arg_type ("GtkTextTag::background_gdk", GTK_TYPE_GDK_COLOR,
-                           GTK_ARG_READWRITE, ARG_BACKGROUND_GDK);
-  gtk_object_add_arg_type ("GtkTextTag::background_full_height", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_BG_FULL_HEIGHT);
-  gtk_object_add_arg_type ("GtkTextTag::background_stipple",
-                           GDK_TYPE_PIXMAP,
-                           GTK_ARG_READWRITE, ARG_BACKGROUND_STIPPLE);
-  gtk_object_add_arg_type ("GtkTextTag::direction", GTK_TYPE_ENUM,
-                           GTK_ARG_READWRITE, ARG_DIRECTION);
-  gtk_object_add_arg_type ("GtkTextTag::editable", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_EDITABLE);
-  gtk_object_add_arg_type ("GtkTextTag::font", GTK_TYPE_STRING,
-                           GTK_ARG_READWRITE, ARG_FONT);
-  gtk_object_add_arg_type ("GtkTextTag::font_desc", GTK_TYPE_BOXED,
-                           GTK_ARG_READWRITE, ARG_FONT_DESC);
-  gtk_object_add_arg_type ("GtkTextTag::foreground", GTK_TYPE_STRING,
-                           GTK_ARG_WRITABLE, ARG_FOREGROUND);
-  gtk_object_add_arg_type ("GtkTextTag::foreground_gdk", GTK_TYPE_GDK_COLOR,
-                           GTK_ARG_READWRITE, ARG_FOREGROUND_GDK);
-  gtk_object_add_arg_type ("GtkTextTag::foreground_stipple",
-                           GDK_TYPE_PIXMAP,
-                           GTK_ARG_READWRITE, ARG_FOREGROUND_STIPPLE);
-  gtk_object_add_arg_type ("GtkTextTag::justify", GTK_TYPE_ENUM,
-                           GTK_ARG_READWRITE, ARG_JUSTIFY);
-  gtk_object_add_arg_type ("GtkTextTag::language", GTK_TYPE_STRING,
-                           GTK_ARG_READWRITE, ARG_LANGUAGE);
-  gtk_object_add_arg_type ("GtkTextTag::left_margin", GTK_TYPE_INT,
-                           GTK_ARG_READWRITE, ARG_LEFT_MARGIN);
-  gtk_object_add_arg_type ("GtkTextTag::indent", GTK_TYPE_INT,
-                           GTK_ARG_READWRITE, ARG_INDENT);
-  gtk_object_add_arg_type ("GtkTextTag::offset", GTK_TYPE_INT,
-                           GTK_ARG_READWRITE, ARG_OFFSET);
-  gtk_object_add_arg_type ("GtkTextTag::pixels_above_lines", GTK_TYPE_INT,
-                           GTK_ARG_READWRITE, ARG_PIXELS_ABOVE_LINES);
-  gtk_object_add_arg_type ("GtkTextTag::pixels_below_lines", GTK_TYPE_INT,
-                           GTK_ARG_READWRITE, ARG_PIXELS_BELOW_LINES);
-  gtk_object_add_arg_type ("GtkTextTag::pixels_inside_wrap", GTK_TYPE_INT,
-                           GTK_ARG_READWRITE, ARG_PIXELS_INSIDE_WRAP);
-  gtk_object_add_arg_type ("GtkTextTag::right_margin", GTK_TYPE_INT,
-                           GTK_ARG_READWRITE, ARG_RIGHT_MARGIN);
-  gtk_object_add_arg_type ("GtkTextTag::strikethrough", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_STRIKETHROUGH);
-  gtk_object_add_arg_type ("GtkTextTag::underline", GTK_TYPE_ENUM,
-                           GTK_ARG_READWRITE, ARG_UNDERLINE);
-  gtk_object_add_arg_type ("GtkTextTag::wrap_mode", GTK_TYPE_ENUM,
-                           GTK_ARG_READWRITE, ARG_WRAP_MODE);
-  gtk_object_add_arg_type ("GtkTextTag::tabs", GTK_TYPE_POINTER, /* FIXME */
-                           GTK_ARG_READWRITE, ARG_TABS);
-  gtk_object_add_arg_type ("GtkTextTag::invisible", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_INVISIBLE);
+
+  g_object_class_install_property (object_class,
+                                   PROP_BACKGROUND,
+                                   g_param_spec_string ("background",
+                                                        _("Background color name"),
+                                                        _("Background color as a string"),
+                                                        NULL,
+                                                        G_PARAM_WRITABLE));
+
+  g_object_class_install_property (object_class,
+                                   PROP_BACKGROUND_GDK,
+                                   g_param_spec_boxed ("background_gdk",
+                                                       _("Background color"),
+                                                       _("Background color as a (possibly unallocated) GdkColor"),
+                                                       GDK_TYPE_COLOR,
+                                                       G_PARAM_READABLE | G_PARAM_WRITABLE));
+
+  g_object_class_install_property (object_class,
+                                   PROP_BG_FULL_HEIGHT,
+                                   g_param_spec_boolean ("background_full_height",
+                                                         _("Background full height"),
+                                                         _("Whether the background color fills the entire line height or only the height of the tagged characters"),
+                                                         FALSE,
+                                                         G_PARAM_READABLE | G_PARAM_WRITABLE));
+
+  
+  g_object_class_install_property (object_class,
+                                   PROP_BACKGROUND_STIPPLE,
+                                   g_param_spec_object ("background_stipple",
+                                                        _("Background stipple mask"),
+                                                        _("Bitmap to use as a mask when drawing the text background"),
+                                                        GDK_TYPE_PIXMAP,
+                                                        G_PARAM_READABLE | G_PARAM_WRITABLE));  
+
+
+  g_object_class_install_property (object_class,
+                                   PROP_FOREGROUND,
+                                   g_param_spec_string ("foreground",
+                                                        _("Foreground color name"),
+                                                        _("Foreground color as a string"),
+                                                        NULL,
+                                                        G_PARAM_WRITABLE));
+
+  g_object_class_install_property (object_class,
+                                   PROP_FOREGROUND_GDK,
+                                   g_param_spec_boxed ("foreground_gdk",
+                                                       _("Foreground color"),
+                                                       _("Foreground color as a (possibly unallocated) GdkColor"),
+                                                       GDK_TYPE_COLOR,
+                                                       G_PARAM_READABLE | G_PARAM_WRITABLE));
+
+  
+  g_object_class_install_property (object_class,
+                                   PROP_FOREGROUND_STIPPLE,
+                                   g_param_spec_object ("foreground_stipple",
+                                                        _("Foreground stipple mask"),
+                                                        _("Bitmap to use as a mask when drawing the text foreground"),
+                                                        GDK_TYPE_PIXMAP,
+                                                        G_PARAM_READABLE | G_PARAM_WRITABLE));  
+  
+  g_object_class_install_property (object_class,
+                                   PROP_DIRECTION,
+                                   g_param_spec_enum ("direction",
+                                                      _("Text direction"),
+                                                      _("Text direction, e.g. right-to-left or left-to-right"),
+                                                      GTK_TYPE_TEXT_DIRECTION,
+                                                      GTK_TEXT_DIR_LTR,
+                                                      G_PARAM_READABLE | G_PARAM_WRITABLE));
+
+  g_object_class_install_property (object_class,
+                                   PROP_EDITABLE,
+                                   g_param_spec_boolean ("editable",
+                                                         _("Editable"),
+                                                         _("Whether the text can be modified by the user"),
+                                                         TRUE,
+                                                         G_PARAM_READABLE | G_PARAM_WRITABLE));
+
+  g_object_class_install_property (object_class,
+                                   PROP_FONT,
+                                   g_param_spec_string ("font",
+                                                        _("Font"),
+                                                        _("Font description as a string, e.g. \"Sans Italic 12\""),
+                                                        NULL,
+                                                        G_PARAM_READABLE | G_PARAM_WRITABLE));
+
+  g_object_class_install_property (object_class,
+                                   PROP_FONT_DESC,
+                                   g_param_spec_boxed ("font_desc",
+                                                       _("Font"),
+                                                       _("Font description as a PangoFontDescription struct"),
+                                                       PANGO_TYPE_FONT_DESCRIPTION,
+                                                       G_PARAM_READABLE | G_PARAM_WRITABLE));
+
+  
+  g_object_class_install_property (object_class,
+                                   PROP_FAMILY,
+                                   g_param_spec_string ("family",
+                                                        _("Font family"),
+                                                        _("Name of the font family, e.g. Sans, Helvetica, Times, Monospace"),
+                                                        NULL,
+                                                        G_PARAM_READABLE | G_PARAM_WRITABLE));
+
+  g_object_class_install_property (object_class,
+                                   PROP_STYLE,
+                                   g_param_spec_enum ("style",
+                                                      _("Font style"),
+                                                      _("Font style as a PangoStyle, e.g. PANGO_STYLE_ITALIC"),
+                                                      PANGO_TYPE_STYLE,
+                                                      PANGO_STYLE_NORMAL,
+                                                      G_PARAM_READABLE | G_PARAM_WRITABLE));
+
+  g_object_class_install_property (object_class,
+                                   PROP_VARIANT,
+                                   g_param_spec_enum ("variant",
+                                                     _("Font variant"),
+                                                     _("Font variant as a PangoVariant, e.g. PANGO_VARIANT_SMALL_CAPS"),
+                                                      PANGO_TYPE_VARIANT,
+                                                      PANGO_VARIANT_NORMAL,
+                                                      G_PARAM_READABLE | G_PARAM_WRITABLE));
+  
+  g_object_class_install_property (object_class,
+                                   PROP_WEIGHT,
+                                   g_param_spec_int ("weight",
+                                                     _("Font weight"),
+                                                     _("Font weight as an integer, see predefined values in PangoWeight; for example, PANGO_WEIGHT_BOLD"),
+                                                     0,
+                                                     G_MAXINT,
+                                                     PANGO_WEIGHT_NORMAL,
+                                                     G_PARAM_READABLE | G_PARAM_WRITABLE));
+  
+
+  g_object_class_install_property (object_class,
+                                   PROP_STRETCH,
+                                   g_param_spec_enum ("stretch",
+                                                      _("Font stretch"),
+                                                      _("Font stretch as a PangoStretch, e.g. PANGO_STRETCH_CONDENSED"),
+                                                      PANGO_TYPE_STRETCH,
+                                                      PANGO_STRETCH_NORMAL,
+                                                      G_PARAM_READABLE | G_PARAM_WRITABLE));
+  
+  g_object_class_install_property (object_class,
+                                   PROP_SIZE,
+                                   g_param_spec_int ("size",
+                                                     _("Font size"),
+                                                     _("Font size in Pango units"),
+                                                     0,
+                                                     G_MAXINT,
+                                                     0,
+                                                     G_PARAM_READABLE | G_PARAM_WRITABLE));
+
+  g_object_class_install_property (object_class,
+                                   PROP_SCALE,
+                                   g_param_spec_double ("scale",
+                                                        _("Font scale"),
+                                                        _("Font size as a scale factor relative to the default font size. This properly adapts to theme changes etc. so is recommended. Pango predefines some scales such as PANGO_SCALE_X_LARGE"),
+                                                        0.0,
+                                                        G_MAXDOUBLE,
+                                                        1.0,
+                                                        G_PARAM_READABLE | G_PARAM_WRITABLE));
   
-  /* Style args are set or not */
-  gtk_object_add_arg_type ("GtkTextTag::background_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_BACKGROUND_SET);
-  gtk_object_add_arg_type ("GtkTextTag::background_full_height_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_BG_FULL_HEIGHT_SET);
-  gtk_object_add_arg_type ("GtkTextTag::background_gdk_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_BACKGROUND_GDK_SET);
-  gtk_object_add_arg_type ("GtkTextTag::background_stipple_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_BACKGROUND_STIPPLE_SET);
-  gtk_object_add_arg_type ("GtkTextTag::editable_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_EDITABLE_SET);
-  gtk_object_add_arg_type ("GtkTextTag::font_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_FONT_SET);
-  gtk_object_add_arg_type ("GtkTextTag::foreground_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_FOREGROUND_SET);
-  gtk_object_add_arg_type ("GtkTextTag::foreground_gdk_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_FOREGROUND_GDK_SET);
-  gtk_object_add_arg_type ("GtkTextTag::foreground_stipple_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_FOREGROUND_STIPPLE_SET);
-  gtk_object_add_arg_type ("GtkTextTag::justify_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_JUSTIFY_SET);
-  gtk_object_add_arg_type ("GtkTextTag::language_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_LANGUAGE_SET);
-  gtk_object_add_arg_type ("GtkTextTag::left_margin_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_LEFT_MARGIN_SET);
-  gtk_object_add_arg_type ("GtkTextTag::indent_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_INDENT_SET);
-  gtk_object_add_arg_type ("GtkTextTag::offset_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_OFFSET_SET);
-  gtk_object_add_arg_type ("GtkTextTag::pixels_above_lines_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_PIXELS_ABOVE_LINES_SET);
-  gtk_object_add_arg_type ("GtkTextTag::pixels_below_lines_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_PIXELS_BELOW_LINES_SET);
-  gtk_object_add_arg_type ("GtkTextTag::pixels_inside_wrap_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_PIXELS_INSIDE_WRAP_SET);
-  gtk_object_add_arg_type ("GtkTextTag::strikethrough_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_STRIKETHROUGH_SET);
-  gtk_object_add_arg_type ("GtkTextTag::right_margin_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_RIGHT_MARGIN_SET);
-  gtk_object_add_arg_type ("GtkTextTag::underline_set", GTK_TYPE_ENUM,
-                           GTK_ARG_READWRITE, ARG_UNDERLINE_SET);
-  gtk_object_add_arg_type ("GtkTextTag::wrap_mode_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_WRAP_MODE_SET);
-  gtk_object_add_arg_type ("GtkTextTag::tabs_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_TABS_SET);
-  gtk_object_add_arg_type ("GtkTextTag::invisible_set", GTK_TYPE_BOOL,
-                           GTK_ARG_READWRITE, ARG_INVISIBLE_SET);
+  g_object_class_install_property (object_class,
+                                   PROP_SIZE_POINTS,
+                                   g_param_spec_double ("size_points",
+                                                        _("Font points"),
+                                                        _("Font size in points"),
+                                                        0.0,
+                                                        G_MAXDOUBLE,
+                                                        0.0,
+                                                        G_PARAM_READABLE | G_PARAM_WRITABLE));  
+
+  g_object_class_install_property (object_class,
+                                   PROP_JUSTIFICATION,
+                                   g_param_spec_enum ("justification",
+                                                      _("Justification"),
+                                                      _("Left, right, or center justification"),
+                                                      GTK_TYPE_JUSTIFICATION,
+                                                      GTK_JUSTIFY_LEFT,
+                                                      G_PARAM_READABLE | G_PARAM_WRITABLE));
+  
+  g_object_class_install_property (object_class,
+                                   PROP_LANGUAGE,
+                                   g_param_spec_string ("language",
+                                                        _("Language"),
+                                                        _("The language this text is in, as an ISO code. Pango can use this as a hint when rendering the text. If you don't understand this parameter, you probably don't need it"),
+                                                        NULL,
+                                                        G_PARAM_READABLE | G_PARAM_WRITABLE));  
+
+  g_object_class_install_property (object_class,
+                                   PROP_LEFT_MARGIN,
+                                   g_param_spec_int ("left_margin",
+                                                     _("Left margin"),
+                                                     _("Width of the left margin in pixels"),
+                                                     0,
+                                                     G_MAXINT,
+                                                     0,
+                                                     G_PARAM_READABLE | G_PARAM_WRITABLE));
+
+  g_object_class_install_property (object_class,
+                                   PROP_RIGHT_MARGIN,
+                                   g_param_spec_int ("right_margin",
+                                                     _("Right margin"),
+                                                     _("Width of the right margin in pixels"),
+                                                     0,
+                                                     G_MAXINT,
+                                                     0,
+                                                     G_PARAM_READABLE | G_PARAM_WRITABLE));
+
   
+  g_object_class_install_property (object_class,
+                                   PROP_INDENT,
+                                   g_param_spec_int ("indent",
+                                                     _("Indent"),
+                                                     _("Amount to indent the paragraph, in pixels"),
+                                                     G_MININT,
+                                                     G_MAXINT,
+                                                     0,
+                                                     G_PARAM_READABLE | G_PARAM_WRITABLE));
+
+  
+  g_object_class_install_property (object_class,
+                                   PROP_RISE,
+                                   g_param_spec_int ("rise",
+                                                     _("Rise"),
+                                                     _("Offset of text above the baseline (below the baseline if rise is negative) in pixels"),
+                                                    G_MININT,
+                                                     G_MAXINT,
+                                                     0,
+                                                     G_PARAM_READABLE | G_PARAM_WRITABLE));
+
+  g_object_class_install_property (object_class,
+                                   PROP_PIXELS_ABOVE_LINES,
+                                   g_param_spec_int ("pixels_above_lines",
+                                                     _("Pixels above lines"),
+                                                     _("Pixels of blank space above paragraphs"),
+                                                     0,
+                                                     G_MAXINT,
+                                                     0,
+                                                     G_PARAM_READABLE | G_PARAM_WRITABLE));
+  
+  g_object_class_install_property (object_class,
+                                   PROP_PIXELS_BELOW_LINES,
+                                   g_param_spec_int ("pixels_below_lines",
+                                                     _("Pixels below lines"),
+                                                     _("Pixels of blank space below paragraphs"),
+                                                     0,
+                                                     G_MAXINT,
+                                                     0,
+                                                     G_PARAM_READABLE | G_PARAM_WRITABLE));
+
+  g_object_class_install_property (object_class,
+                                   PROP_PIXELS_INSIDE_WRAP,
+                                   g_param_spec_int ("pixels_inside_wrap",
+                                                     _("Pixels inside wrap"),
+                                                     _("Pixels of blank space between wrapped lines in a paragraph"),
+                                                     0,
+                                                     G_MAXINT,
+                                                     0,
+                                                     G_PARAM_READABLE | G_PARAM_WRITABLE));
+
+  g_object_class_install_property (object_class,
+                                   PROP_STRIKETHROUGH,
+                                   g_param_spec_boolean ("strikethrough",
+                                                         _("Strikethrough"),
+                                                         _("Whether to strike through the text"),
+                                                         FALSE,
+                                                         G_PARAM_READABLE | G_PARAM_WRITABLE));
+  
+  g_object_class_install_property (object_class,
+                                   PROP_UNDERLINE,
+                                   g_param_spec_enum ("underline",
+                                                      _("Underline"),
+                                                      _("Style of underline for this text"),
+                                                      PANGO_TYPE_UNDERLINE,
+                                                      PANGO_UNDERLINE_NONE,
+                                                      G_PARAM_READABLE | G_PARAM_WRITABLE));
+  
+  g_object_class_install_property (object_class,
+                                   PROP_WRAP_MODE,
+                                   g_param_spec_enum ("wrap_mode",
+                                                     _("Wrap mode"),
+                                                     _("Whether to wrap lines never, at word boundaries, or at character boundaries"),
+                                                      GTK_TYPE_WRAP_MODE,
+                                                      GTK_WRAP_NONE,
+                                                      G_PARAM_READABLE | G_PARAM_WRITABLE));
+  
+
+  g_object_class_install_property (object_class,
+                                   PROP_TABS,
+                                   g_param_spec_boxed ("tabs",
+                                                       _("Tabs"),
+                                                       _("Custom tabs for this text"),
+                                                       PANGO_TYPE_TAB_ARRAY,
+                                                       G_PARAM_READABLE | G_PARAM_WRITABLE));
+  
+  g_object_class_install_property (object_class,
+                                   PROP_INVISIBLE,
+                                   g_param_spec_boolean ("invisible",
+                                                         _("Invisible"),
+                                                         _("Whether this text is hidden. Not implemented in GTK 2.0"),
+                                                         FALSE,
+                                                         G_PARAM_READABLE | G_PARAM_WRITABLE));
+
+  /* Style props are set or not */
+
+#define ADD_SET_PROP(propname, propval, nick, blurb) g_object_class_install_property (object_class, propval, g_param_spec_boolean (propname, nick, blurb, FALSE, G_PARAM_READABLE | G_PARAM_WRITABLE))
+
+  ADD_SET_PROP ("background_set", PROP_BACKGROUND_SET,
+                _("Background set"),
+                _("Whether this tag affects the background color"));
+  
+  ADD_SET_PROP ("background_full_height_set", PROP_BG_FULL_HEIGHT_SET,
+                _("Background full height set"),
+                _("Whether this tag affects background height"));
+
+  ADD_SET_PROP ("background_stipple_set", PROP_BACKGROUND_STIPPLE_SET,
+                _("Background stipple set"),
+                _("Whether this tag affects the background stipple"));  
+
+  ADD_SET_PROP ("foreground_set", PROP_FOREGROUND_SET,
+                _("Foreground set"),
+                _("Whether this tag affects the foreground color"));
+
+  ADD_SET_PROP ("foreground_stipple_set", PROP_FOREGROUND_STIPPLE_SET,
+                _("Foreground stipple set"),
+                _("Whether this tag affects the foreground stipple"));
+  
+  ADD_SET_PROP ("editable_set", PROP_EDITABLE_SET,
+                _("Editability set"),
+                _("Whether this tag affects text editability"));
+
+  ADD_SET_PROP ("family_set", PROP_FAMILY_SET,
+                _("Font family set"),
+                _("Whether this tag affects the font family"));  
+
+  ADD_SET_PROP ("style_set", PROP_STYLE_SET,
+                _("Font style set"),
+                _("Whether this tag affects the font style"));
+
+  ADD_SET_PROP ("variant_set", PROP_VARIANT_SET,
+                _("Font variant set"),
+                _("Whether this tag affects the font variant"));
+
+  ADD_SET_PROP ("weight_set", PROP_WEIGHT_SET,
+                _("Font weight set"),
+                _("Whether this tag affects the font weight"));
+
+  ADD_SET_PROP ("stretch_set", PROP_STRETCH_SET,
+                _("Font stretch set"),
+                _("Whether this tag affects the font stretch"));
+
+  ADD_SET_PROP ("size_set", PROP_SIZE_SET,
+                _("Font size set"),
+                _("Whether this tag affects the font size"));
+
+  ADD_SET_PROP ("scale_set", PROP_SCALE_SET,
+                _("Font scale set"),
+                _("Whether this tag scales the font size by a factor"));
+  
+  ADD_SET_PROP ("justification_set", PROP_JUSTIFICATION_SET,
+                _("Justification set"),
+                _("Whether this tag affects paragraph justification"));
+  
+  ADD_SET_PROP ("language_set", PROP_LANGUAGE_SET,
+                _("Language set"),
+                _("Whether this tag affects the language the text is rendered as"));
+
+  ADD_SET_PROP ("left_margin_set", PROP_LEFT_MARGIN_SET,
+                _("Left margin set"),
+                _("Whether this tag affects the left margin"));
+
+  ADD_SET_PROP ("indent_set", PROP_INDENT_SET,
+                _("Indent set"),
+                _("Whether this tag affects indentation"));
+
+  ADD_SET_PROP ("rise_set", PROP_RISE_SET,
+                _("Rise set"),
+                _("Whether this tag affects the rise"));
+
+  ADD_SET_PROP ("pixels_above_lines_set", PROP_PIXELS_ABOVE_LINES_SET,
+                _("Pixels above lines set"),
+                _("Whether this tag affects the number of pixels above lines"));
+
+  ADD_SET_PROP ("pixels_below_lines_set", PROP_PIXELS_BELOW_LINES_SET,
+                _("Pixels below lines set"),
+                _("Whether this tag affects the number of pixels above lines"));
+
+  ADD_SET_PROP ("pixels_inside_wrap_set", PROP_PIXELS_INSIDE_WRAP_SET,
+                _("Pixels inside wrap set"),
+                _("Whether this tag affects the number of pixels between wrapped lines"));
+
+  ADD_SET_PROP ("strikethrough_set", PROP_STRIKETHROUGH_SET,
+                _("Strikethrough set"),
+                _("Whether this tag affects strikethrough"));
+  
+  ADD_SET_PROP ("right_margin_set", PROP_RIGHT_MARGIN_SET,
+                _("Right margin set"),
+                _("Whether this tag affects the right margin"));
+
+  ADD_SET_PROP ("underline_set", PROP_UNDERLINE_SET,
+                _("Underline set"),
+                _("Whether this tag affects underlining"));
+
+  ADD_SET_PROP ("wrap_mode_set", PROP_WRAP_MODE_SET,
+                _("Wrap mode set"),
+                _("Whether this tag affects line wrap mode"));
+
+  ADD_SET_PROP ("tabs_set", PROP_TABS_SET,
+                _("Tabs set"),
+                _("Whether this tag affects tabs"));
+
+  ADD_SET_PROP ("invisible_set", PROP_INVISIBLE_SET,
+                _("Invisible set"),
+                _("Whether this tag affects text visibility"));
 
   signals[EVENT] =
-    gtk_signal_new ("event",
-                    GTK_RUN_LAST,
-                    GTK_CLASS_TYPE (object_class),
-                    GTK_SIGNAL_OFFSET (GtkTextTagClass, event),
-                    gtk_marshal_INT__OBJECT_BOXED_BOXED,
-                    GTK_TYPE_INT,
-                    3,
-                    G_TYPE_OBJECT,
-                    GTK_TYPE_GDK_EVENT,
-                    GTK_TYPE_TEXT_ITER);
-
-  gtk_object_class_add_signals (object_class, signals, LAST_SIGNAL);
-
-  object_class->set_arg = gtk_text_tag_set_arg;
-  object_class->get_arg = gtk_text_tag_get_arg;
-
-  object_class->destroy = gtk_text_tag_destroy;
-  gobject_class->finalize = gtk_text_tag_finalize;
+    g_signal_new ("event",
+                  G_OBJECT_CLASS_TYPE (object_class),
+                  G_SIGNAL_RUN_LAST,
+                  G_STRUCT_OFFSET (GtkTextTagClass, event),
+                  _gtk_boolean_handled_accumulator, NULL,
+                  _gtk_marshal_BOOLEAN__OBJECT_BOXED_BOXED,
+                  G_TYPE_BOOLEAN,
+                  3,
+                  G_TYPE_OBJECT,
+                  GDK_TYPE_EVENT | G_SIGNAL_TYPE_STATIC_SCOPE,
+                  GTK_TYPE_TEXT_ITER);
 }
 
-void
+static void
 gtk_text_tag_init (GtkTextTag *text_tag)
 {
   /* 0 is basically a fine way to initialize everything in the
      entire struct */
-
+  
+  text_tag->values = gtk_text_attributes_new ();
 }
 
 /**
@@ -320,17 +649,13 @@ gtk_text_tag_new (const gchar *name)
 {
   GtkTextTag *tag;
 
-  tag = GTK_TEXT_TAG (gtk_type_new (gtk_text_tag_get_type ()));
-
-  tag->name = g_strdup (name);
-
-  tag->values = gtk_text_attributes_new ();
+  tag = g_object_new (GTK_TYPE_TEXT_TAG, "name", name, NULL);
 
   return tag;
 }
 
 static void
-gtk_text_tag_destroy (GtkObject *object)
+gtk_text_tag_finalize (GObject *object)
 {
   GtkTextTag *text_tag;
 
@@ -345,17 +670,7 @@ gtk_text_tag_destroy (GtkObject *object)
 
   gtk_text_attributes_unref (text_tag->values);
   text_tag->values = NULL;
-
-  (* GTK_OBJECT_CLASS (parent_class)->destroy) (object);
-}
-
-static void
-gtk_text_tag_finalize (GObject *object)
-{
-  GtkTextTag *text_tag;
-
-  text_tag = GTK_TEXT_TAG (object);
-
+  
   g_free (text_tag->name);
   text_tag->name = NULL;
 
@@ -367,12 +682,21 @@ set_bg_color (GtkTextTag *tag, GdkColor *color)
 {
   if (color)
     {
-      tag->bg_color_set = TRUE;
+      if (!tag->bg_color_set)
+        {
+          tag->bg_color_set = TRUE;
+          g_object_notify (G_OBJECT (tag), "background_set");
+        }
+      
       tag->values->appearance.bg_color = *color;
     }
   else
     {
-      tag->bg_color_set = FALSE;
+      if (tag->bg_color_set)
+        {
+          tag->bg_color_set = FALSE;
+          g_object_notify (G_OBJECT (tag), "background_set");
+        }
     }
 }
 
@@ -381,17 +705,186 @@ set_fg_color (GtkTextTag *tag, GdkColor *color)
 {
   if (color)
     {
-      tag->fg_color_set = TRUE;
+      if (!tag->fg_color_set)
+        {
+          tag->fg_color_set = TRUE;
+          g_object_notify (G_OBJECT (tag), "foreground_set");
+        }
       tag->values->appearance.fg_color = *color;
     }
   else
     {
-      tag->fg_color_set = FALSE;
+      if (tag->fg_color_set)
+        {
+          tag->fg_color_set = FALSE;
+          g_object_notify (G_OBJECT (tag), "foreground_set");
+        }
+    }
+}
+
+static PangoFontMask
+get_property_font_set_mask (guint prop_id)
+{
+  switch (prop_id)
+    {
+    case PROP_FAMILY_SET:
+      return PANGO_FONT_MASK_FAMILY;
+    case PROP_STYLE_SET:
+      return PANGO_FONT_MASK_STYLE;
+    case PROP_VARIANT_SET:
+      return PANGO_FONT_MASK_VARIANT;
+    case PROP_WEIGHT_SET:
+      return PANGO_FONT_MASK_WEIGHT;
+    case PROP_STRETCH_SET:
+      return PANGO_FONT_MASK_STRETCH;
+    case PROP_SIZE_SET:
+      return PANGO_FONT_MASK_SIZE;
+    }
+
+  return 0;
+}
+
+static PangoFontMask
+set_font_desc_fields (PangoFontDescription *desc,
+                     PangoFontMask         to_set)
+{
+  PangoFontMask changed_mask = 0;
+  
+  if (to_set & PANGO_FONT_MASK_FAMILY)
+    {
+      const char *family = pango_font_description_get_family (desc);
+      if (!family)
+       {
+         family = "sans";
+         changed_mask |= PANGO_FONT_MASK_FAMILY;
+       }
+
+      pango_font_description_set_family (desc, family);
+    }
+  if (to_set & PANGO_FONT_MASK_STYLE)
+    pango_font_description_set_style (desc, pango_font_description_get_style (desc));
+  if (to_set & PANGO_FONT_MASK_VARIANT)
+    pango_font_description_set_variant (desc, pango_font_description_get_variant (desc));
+  if (to_set & PANGO_FONT_MASK_WEIGHT)
+    pango_font_description_set_weight (desc, pango_font_description_get_weight (desc));
+  if (to_set & PANGO_FONT_MASK_STRETCH)
+    pango_font_description_set_stretch (desc, pango_font_description_get_stretch (desc));
+  if (to_set & PANGO_FONT_MASK_SIZE)
+    {
+      gint size = pango_font_description_get_size (desc);
+      if (size <= 0)
+       {
+         size = 10 * PANGO_SCALE;
+         changed_mask |= PANGO_FONT_MASK_SIZE;
+       }
+      
+      pango_font_description_set_size (desc, size);
+    }
+
+  return changed_mask;
+}
+
+static void
+notify_set_changed (GObject       *object,
+                   PangoFontMask  changed_mask)
+{
+  if (changed_mask & PANGO_FONT_MASK_FAMILY)
+    g_object_notify (object, "family_set");
+  if (changed_mask & PANGO_FONT_MASK_STYLE)
+    g_object_notify (object, "style_set");
+  if (changed_mask & PANGO_FONT_MASK_VARIANT)
+    g_object_notify (object, "variant_set");
+  if (changed_mask & PANGO_FONT_MASK_WEIGHT)
+    g_object_notify (object, "weight_set");
+  if (changed_mask & PANGO_FONT_MASK_STRETCH)
+    g_object_notify (object, "stretch_set");
+  if (changed_mask & PANGO_FONT_MASK_SIZE)
+    g_object_notify (object, "size_set");
+}
+
+static void
+notify_fields_changed (GObject       *object,
+                      PangoFontMask  changed_mask)
+{
+  if (changed_mask & PANGO_FONT_MASK_FAMILY)
+    g_object_notify (object, "family");
+  if (changed_mask & PANGO_FONT_MASK_STYLE)
+    g_object_notify (object, "style");
+  if (changed_mask & PANGO_FONT_MASK_VARIANT)
+    g_object_notify (object, "variant");
+  if (changed_mask & PANGO_FONT_MASK_WEIGHT)
+    g_object_notify (object, "weight");
+  if (changed_mask & PANGO_FONT_MASK_STRETCH)
+    g_object_notify (object, "stretch");
+  if (changed_mask & PANGO_FONT_MASK_SIZE)
+    g_object_notify (object, "size");
+}
+
+static void
+set_font_description (GtkTextTag           *text_tag,
+                      PangoFontDescription *font_desc)
+{
+  GObject *object = G_OBJECT (text_tag);
+  PangoFontDescription *new_font_desc;
+  PangoFontMask old_mask, new_mask, changed_mask, set_changed_mask;
+  
+  if (font_desc)
+    new_font_desc = pango_font_description_copy (font_desc);
+  else
+    new_font_desc = pango_font_description_new ();
+
+  if (text_tag->values->font)
+    old_mask = pango_font_description_get_set_fields (text_tag->values->font);
+  else
+    old_mask = 0;
+  
+  new_mask = pango_font_description_get_set_fields (new_font_desc);
+
+  changed_mask = old_mask | new_mask;
+  set_changed_mask = old_mask ^ new_mask;
+
+  if (text_tag->values->font)
+    pango_font_description_free (text_tag->values->font);
+  text_tag->values->font = new_font_desc;
+  
+  g_object_freeze_notify (object);
+
+  g_object_notify (object, "font_desc");
+  g_object_notify (object, "font");
+  
+  if (changed_mask & PANGO_FONT_MASK_FAMILY)
+    g_object_notify (object, "family");
+  if (changed_mask & PANGO_FONT_MASK_STYLE)
+    g_object_notify (object, "style");
+  if (changed_mask & PANGO_FONT_MASK_VARIANT)
+    g_object_notify (object, "variant");
+  if (changed_mask & PANGO_FONT_MASK_WEIGHT)
+    g_object_notify (object, "weight");
+  if (changed_mask & PANGO_FONT_MASK_STRETCH)
+    g_object_notify (object, "stretch");
+  if (changed_mask & PANGO_FONT_MASK_SIZE)
+    {
+      g_object_notify (object, "size");
+      g_object_notify (object, "size_points");
     }
+
+  notify_set_changed (object, set_changed_mask);
+  
+  g_object_thaw_notify (object);
 }
 
 static void
-gtk_text_tag_set_arg (GtkObject *object, GtkArg *arg, guint arg_id)
+gtk_text_tag_ensure_font (GtkTextTag *text_tag)
+{
+  if (!text_tag->values->font)
+    text_tag->values->font = pango_font_description_new ();
+}
+
+static void
+gtk_text_tag_set_property (GObject      *object,
+                           guint         prop_id,
+                           const GValue *value,
+                           GParamSpec   *pspec)
 {
   GtkTextTag *text_tag;
   gboolean size_changed = FALSE;
@@ -400,553 +893,734 @@ gtk_text_tag_set_arg (GtkObject *object, GtkArg *arg, guint arg_id)
 
   g_return_if_fail (!text_tag->values->realized);
 
-  switch (arg_id)
+  switch (prop_id)
     {
-    case ARG_NAME:
+    case PROP_NAME:
       g_return_if_fail (text_tag->name == NULL);
-      text_tag->name = g_strdup (GTK_VALUE_STRING (*arg));
+      text_tag->name = g_strdup (g_value_get_string (value));
       break;
 
-    case ARG_BACKGROUND:
+    case PROP_BACKGROUND:
       {
         GdkColor color;
 
-        if (gdk_color_parse (GTK_VALUE_STRING (*arg), &color))
+        if (gdk_color_parse (g_value_get_string (value), &color))
           set_bg_color (text_tag, &color);
         else
-          g_warning ("Don't know color `%s'", GTK_VALUE_STRING (*arg));
+          g_warning ("Don't know color `%s'", g_value_get_string (value));
+
+        g_object_notify (object, "background_gdk");
       }
       break;
 
-    case ARG_FOREGROUND:
+    case PROP_FOREGROUND:
       {
         GdkColor color;
 
-        if (gdk_color_parse (GTK_VALUE_STRING (*arg), &color))
+        if (gdk_color_parse (g_value_get_string (value), &color))
           set_fg_color (text_tag, &color);
         else
-          g_warning ("Don't know color `%s'", GTK_VALUE_STRING (*arg));
+          g_warning ("Don't know color `%s'", g_value_get_string (value));
+
+        g_object_notify (object, "foreground_gdk");
       }
       break;
 
-    case ARG_BACKGROUND_GDK:
+    case PROP_BACKGROUND_GDK:
       {
-        GdkColor *color = GTK_VALUE_POINTER (*arg);
+        GdkColor *color = g_value_get_boxed (value);
+
         set_bg_color (text_tag, color);
       }
       break;
 
-    case ARG_FOREGROUND_GDK:
+    case PROP_FOREGROUND_GDK:
       {
-        GdkColor *color = GTK_VALUE_POINTER (*arg);
+        GdkColor *color = g_value_get_boxed (value);
+
         set_fg_color (text_tag, color);
       }
       break;
 
-    case ARG_BACKGROUND_STIPPLE:
+    case PROP_BACKGROUND_STIPPLE:
       {
-        GdkBitmap *bitmap = GTK_VALUE_POINTER (*arg);
+        GdkBitmap *bitmap = g_value_get_object (value);
 
         text_tag->bg_stipple_set = TRUE;
-
+        g_object_notify (object, "background_stipple_set");
+        
         if (text_tag->values->appearance.bg_stipple != bitmap)
           {
             if (bitmap != NULL)
-              gdk_bitmap_ref (bitmap);
+              g_object_ref (bitmap);
 
             if (text_tag->values->appearance.bg_stipple)
-              gdk_bitmap_unref (text_tag->values->appearance.bg_stipple);
+              g_object_unref (text_tag->values->appearance.bg_stipple);
 
             text_tag->values->appearance.bg_stipple = bitmap;
           }
       }
       break;
 
-    case ARG_FOREGROUND_STIPPLE:
+    case PROP_FOREGROUND_STIPPLE:
       {
-        GdkBitmap *bitmap = GTK_VALUE_POINTER (*arg);
+        GdkBitmap *bitmap = g_value_get_object (value);
 
         text_tag->fg_stipple_set = TRUE;
+        g_object_notify (object, "foreground_stipple_set");
 
         if (text_tag->values->appearance.fg_stipple != bitmap)
           {
             if (bitmap != NULL)
-              gdk_bitmap_ref (bitmap);
+              g_object_ref (bitmap);
 
             if (text_tag->values->appearance.fg_stipple)
-              gdk_bitmap_unref (text_tag->values->appearance.fg_stipple);
+              g_object_unref (text_tag->values->appearance.fg_stipple);
 
             text_tag->values->appearance.fg_stipple = bitmap;
           }
       }
       break;
 
-    case ARG_FONT:
+    case PROP_FONT:
       {
         PangoFontDescription *font_desc = NULL;
         const gchar *name;
 
-        name = GTK_VALUE_STRING (*arg);
+        name = g_value_get_string (value);
 
         if (name)
           font_desc = pango_font_description_from_string (name);
 
-        if (text_tag->values->font_desc)
-          pango_font_description_free (text_tag->values->font_desc);
-
-        text_tag->font_set = (font_desc != NULL);
-        text_tag->values->font_desc = font_desc;
-
+        set_font_description (text_tag, font_desc);
+       if (font_desc)
+         pango_font_description_free (font_desc);
+        
         size_changed = TRUE;
       }
       break;
 
-    case ARG_FONT_DESC:
+    case PROP_FONT_DESC:
       {
         PangoFontDescription *font_desc;
 
-        font_desc = GTK_VALUE_BOXED (*arg);
+        font_desc = g_value_get_boxed (value);
 
-        if (text_tag->values->font_desc)
-          pango_font_description_free (text_tag->values->font_desc);
-
-        if (font_desc)
-          text_tag->values->font_desc = pango_font_description_copy (font_desc);
-        else
-          text_tag->values->font_desc = NULL;
-
-        text_tag->font_set = (font_desc != NULL);
+        set_font_description (text_tag, font_desc);
 
         size_changed = TRUE;
       }
       break;
 
-    case ARG_PIXELS_ABOVE_LINES:
+    case PROP_FAMILY:
+    case PROP_STYLE:
+    case PROP_VARIANT:
+    case PROP_WEIGHT:
+    case PROP_STRETCH:
+    case PROP_SIZE:
+    case PROP_SIZE_POINTS:
+      {
+       PangoFontMask old_set_mask;
+
+       gtk_text_tag_ensure_font (text_tag);
+       old_set_mask = pango_font_description_get_set_fields (text_tag->values->font);
+       switch (prop_id)
+         {
+         case PROP_FAMILY:
+           pango_font_description_set_family (text_tag->values->font,
+                                              g_value_get_string (value));
+           break;
+         case PROP_STYLE:
+           pango_font_description_set_style (text_tag->values->font,
+                                             g_value_get_enum (value));
+           break;
+         case PROP_VARIANT:
+           pango_font_description_set_variant (text_tag->values->font,
+                                               g_value_get_enum (value));
+           break;
+         case PROP_WEIGHT:
+           pango_font_description_set_weight (text_tag->values->font,
+                                              g_value_get_int (value));
+           break;
+         case PROP_STRETCH:
+           pango_font_description_set_stretch (text_tag->values->font,
+                                               g_value_get_enum (value));
+           break;
+         case PROP_SIZE:
+           pango_font_description_set_size (text_tag->values->font,
+                                            g_value_get_int (value));
+           g_object_notify (object, "size_points");
+           break;
+         case PROP_SIZE_POINTS:
+           pango_font_description_set_size (text_tag->values->font,
+                                            g_value_get_double (value) * PANGO_SCALE);
+           g_object_notify (object, "size");
+           break;
+         }
+
+       size_changed = TRUE;
+       notify_set_changed (object, old_set_mask & pango_font_description_get_set_fields (text_tag->values->font));
+       g_object_notify (object, "font_desc");
+       g_object_notify (object, "font");
+
+       break;
+      }
+      
+    case PROP_SCALE:
+      text_tag->values->font_scale = g_value_get_double (value);
+      text_tag->scale_set = TRUE;
+      g_object_notify (object, "scale_set");
+      size_changed = TRUE;
+      break;
+      
+    case PROP_PIXELS_ABOVE_LINES:
       text_tag->pixels_above_lines_set = TRUE;
-      text_tag->values->pixels_above_lines = GTK_VALUE_INT (*arg);
+      text_tag->values->pixels_above_lines = g_value_get_int (value);
+      g_object_notify (object, "pixels_above_lines_set");
       size_changed = TRUE;
       break;
 
-    case ARG_PIXELS_BELOW_LINES:
+    case PROP_PIXELS_BELOW_LINES:
       text_tag->pixels_below_lines_set = TRUE;
-      text_tag->values->pixels_below_lines = GTK_VALUE_INT (*arg);
+      text_tag->values->pixels_below_lines = g_value_get_int (value);
+      g_object_notify (object, "pixels_below_lines_set");
       size_changed = TRUE;
       break;
 
-    case ARG_PIXELS_INSIDE_WRAP:
+    case PROP_PIXELS_INSIDE_WRAP:
       text_tag->pixels_inside_wrap_set = TRUE;
-      text_tag->values->pixels_inside_wrap = GTK_VALUE_INT (*arg);
+      text_tag->values->pixels_inside_wrap = g_value_get_int (value);
+      g_object_notify (object, "pixels_inside_wrap_set");
       size_changed = TRUE;
       break;
 
-    case ARG_EDITABLE:
+    case PROP_EDITABLE:
       text_tag->editable_set = TRUE;
-      text_tag->values->editable = GTK_VALUE_BOOL (*arg);
+      text_tag->values->editable = g_value_get_boolean (value);
+      g_object_notify (object, "editable_set");
       break;
 
-    case ARG_WRAP_MODE:
+    case PROP_WRAP_MODE:
       text_tag->wrap_mode_set = TRUE;
-      text_tag->values->wrap_mode = GTK_VALUE_ENUM (*arg);
+      text_tag->values->wrap_mode = g_value_get_enum (value);
+      g_object_notify (object, "wrap_mode_set");
       size_changed = TRUE;
       break;
 
-    case ARG_JUSTIFY:
-      text_tag->justify_set = TRUE;
-      text_tag->values->justify = GTK_VALUE_ENUM (*arg);
+    case PROP_JUSTIFICATION:
+      text_tag->justification_set = TRUE;
+      text_tag->values->justification = g_value_get_enum (value);
+      g_object_notify (object, "justification_set");
       size_changed = TRUE;
       break;
 
-    case ARG_DIRECTION:
-      text_tag->values->direction = GTK_VALUE_ENUM (*arg);
+    case PROP_DIRECTION:
+      text_tag->values->direction = g_value_get_enum (value);
       break;
 
-    case ARG_LEFT_MARGIN:
+    case PROP_LEFT_MARGIN:
       text_tag->left_margin_set = TRUE;
-      text_tag->values->left_margin = GTK_VALUE_INT (*arg);
+      text_tag->values->left_margin = g_value_get_int (value);
+      g_object_notify (object, "left_margin_set");
       size_changed = TRUE;
       break;
 
-    case ARG_INDENT:
+    case PROP_INDENT:
       text_tag->indent_set = TRUE;
-      text_tag->values->indent = GTK_VALUE_INT (*arg);
+      text_tag->values->indent = g_value_get_int (value);
+      g_object_notify (object, "indent_set");
       size_changed = TRUE;
       break;
 
-    case ARG_STRIKETHROUGH:
+    case PROP_STRIKETHROUGH:
       text_tag->strikethrough_set = TRUE;
-      text_tag->values->appearance.strikethrough = GTK_VALUE_BOOL (*arg);
+      text_tag->values->appearance.strikethrough = g_value_get_boolean (value);
+      g_object_notify (object, "strikethrough_set");
       break;
 
-    case ARG_RIGHT_MARGIN:
+    case PROP_RIGHT_MARGIN:
       text_tag->right_margin_set = TRUE;
-      text_tag->values->right_margin = GTK_VALUE_INT (*arg);
+      text_tag->values->right_margin = g_value_get_int (value);
+      g_object_notify (object, "right_margin_set");
       size_changed = TRUE;
       break;
 
-    case ARG_UNDERLINE:
+    case PROP_UNDERLINE:
       text_tag->underline_set = TRUE;
-      text_tag->values->appearance.underline = GTK_VALUE_ENUM (*arg);
+      text_tag->values->appearance.underline = g_value_get_enum (value);
+      g_object_notify (object, "underline_set");
       break;
 
-    case ARG_OFFSET:
-      text_tag->offset_set = TRUE;
-      text_tag->values->offset = GTK_VALUE_INT (*arg);
-      size_changed = TRUE;
+    case PROP_RISE:
+      text_tag->rise_set = TRUE;
+      text_tag->values->appearance.rise = g_value_get_int (value);
+      g_object_notify (object, "rise_set");
+      size_changed = TRUE;      
       break;
 
-    case ARG_BG_FULL_HEIGHT:
+    case PROP_BG_FULL_HEIGHT:
       text_tag->bg_full_height_set = TRUE;
-      text_tag->values->bg_full_height = GTK_VALUE_BOOL (*arg);
+      text_tag->values->bg_full_height = g_value_get_boolean (value);
+      g_object_notify (object, "background_full_height_set");
       break;
 
-    case ARG_LANGUAGE:
+    case PROP_LANGUAGE:
       text_tag->language_set = TRUE;
-      text_tag->values->language = g_strdup (GTK_VALUE_STRING (*arg));
+      text_tag->values->language = pango_language_from_string (g_value_get_string (value));
+      g_object_notify (object, "language_set");
       break;
 
-    case ARG_TABS:
+    case PROP_TABS:
       text_tag->tabs_set = TRUE;
 
       if (text_tag->values->tabs)
         pango_tab_array_free (text_tag->values->tabs);
 
+      /* FIXME I'm not sure if this is a memleak or not */
       text_tag->values->tabs =
-        pango_tab_array_copy (GTK_VALUE_POINTER (*arg));
+        pango_tab_array_copy (g_value_get_boxed (value));
 
+      g_object_notify (object, "tabs_set");
+      
       size_changed = TRUE;
       break;
 
-    case ARG_INVISIBLE:
+    case PROP_INVISIBLE:
+      g_warning ("The \"invisible\" property on GtkTextTag is not supported for GTK 2.0, it will be added in a future release. see http://bugzilla.gnome.org bug #66194 for status.");
       text_tag->invisible_set = TRUE;
-      text_tag->values->invisible = GTK_VALUE_BOOL (*arg);
+      text_tag->values->invisible = g_value_get_boolean (value);
+      g_object_notify (object, "invisible_set");
       size_changed = TRUE;
       break;
       
       /* Whether the value should be used... */
 
-    case ARG_BACKGROUND_SET:
-    case ARG_BACKGROUND_GDK_SET:
-      text_tag->bg_color_set = GTK_VALUE_BOOL (*arg);
+    case PROP_BACKGROUND_SET:
+      text_tag->bg_color_set = g_value_get_boolean (value);
       break;
 
-    case ARG_FOREGROUND_SET:
-    case ARG_FOREGROUND_GDK_SET:
-      text_tag->fg_color_set = GTK_VALUE_BOOL (*arg);
+    case PROP_FOREGROUND_SET:
+      text_tag->fg_color_set = g_value_get_boolean (value);
       break;
 
-    case ARG_BACKGROUND_STIPPLE_SET:
-      text_tag->bg_stipple_set = GTK_VALUE_BOOL (*arg);
+    case PROP_BACKGROUND_STIPPLE_SET:
+      text_tag->bg_stipple_set = g_value_get_boolean (value);
+      if (!text_tag->bg_stipple_set &&
+          text_tag->values->appearance.bg_stipple)
+        {
+          g_object_unref (text_tag->values->appearance.bg_stipple);
+          text_tag->values->appearance.bg_stipple = NULL;
+        }
       break;
 
-    case ARG_FOREGROUND_STIPPLE_SET:
-      text_tag->fg_stipple_set = GTK_VALUE_BOOL (*arg);
+    case PROP_FOREGROUND_STIPPLE_SET:
+      text_tag->fg_stipple_set = g_value_get_boolean (value);
+      if (!text_tag->fg_stipple_set &&
+          text_tag->values->appearance.fg_stipple)
+        {
+          g_object_unref (text_tag->values->appearance.fg_stipple);
+          text_tag->values->appearance.fg_stipple = NULL;
+        }
       break;
 
-    case ARG_FONT_SET:
-      text_tag->font_set = GTK_VALUE_BOOL (*arg);
+    case PROP_FAMILY_SET:
+    case PROP_STYLE_SET:
+    case PROP_VARIANT_SET:
+    case PROP_WEIGHT_SET:
+    case PROP_STRETCH_SET:
+    case PROP_SIZE_SET:
+      if (!g_value_get_boolean (value))
+       {
+         if (text_tag->values->font)
+           pango_font_description_unset_fields (text_tag->values->font,
+                                                get_property_font_set_mask (prop_id));
+       }
+      else
+       {
+         PangoFontMask changed_mask;
+         
+         gtk_text_tag_ensure_font (text_tag);
+         changed_mask = set_font_desc_fields (text_tag->values->font,
+                                              get_property_font_set_mask (prop_id));
+         notify_fields_changed (G_OBJECT (text_tag), changed_mask);
+       }
+      break;
+
+    case PROP_SCALE_SET:
+      text_tag->scale_set = g_value_get_boolean (value);
       size_changed = TRUE;
       break;
-
-    case ARG_PIXELS_ABOVE_LINES_SET:
-      text_tag->pixels_above_lines_set = GTK_VALUE_BOOL (*arg);
+      
+    case PROP_PIXELS_ABOVE_LINES_SET:
+      text_tag->pixels_above_lines_set = g_value_get_boolean (value);
       size_changed = TRUE;
       break;
 
-    case ARG_PIXELS_BELOW_LINES_SET:
-      text_tag->pixels_below_lines_set = GTK_VALUE_BOOL (*arg);
+    case PROP_PIXELS_BELOW_LINES_SET:
+      text_tag->pixels_below_lines_set = g_value_get_boolean (value);
       size_changed = TRUE;
       break;
 
-    case ARG_PIXELS_INSIDE_WRAP_SET:
-      text_tag->pixels_inside_wrap_set = GTK_VALUE_BOOL (*arg);
+    case PROP_PIXELS_INSIDE_WRAP_SET:
+      text_tag->pixels_inside_wrap_set = g_value_get_boolean (value);
       size_changed = TRUE;
       break;
 
-    case ARG_EDITABLE_SET:
-      text_tag->editable_set = GTK_VALUE_BOOL (*arg);
+    case PROP_EDITABLE_SET:
+      text_tag->editable_set = g_value_get_boolean (value);
       break;
 
-    case ARG_WRAP_MODE_SET:
-      text_tag->wrap_mode_set = GTK_VALUE_BOOL (*arg);
+    case PROP_WRAP_MODE_SET:
+      text_tag->wrap_mode_set = g_value_get_boolean (value);
       size_changed = TRUE;
       break;
 
-    case ARG_JUSTIFY_SET:
-      text_tag->justify_set = GTK_VALUE_BOOL (*arg);
+    case PROP_JUSTIFICATION_SET:
+      text_tag->justification_set = g_value_get_boolean (value);
       size_changed = TRUE;
       break;
-
-    case ARG_LEFT_MARGIN_SET:
-      text_tag->left_margin_set = GTK_VALUE_BOOL (*arg);
+      
+    case PROP_LEFT_MARGIN_SET:
+      text_tag->left_margin_set = g_value_get_boolean (value);
       size_changed = TRUE;
       break;
 
-    case ARG_INDENT_SET:
-      text_tag->indent_set = GTK_VALUE_BOOL (*arg);
+    case PROP_INDENT_SET:
+      text_tag->indent_set = g_value_get_boolean (value);
       size_changed = TRUE;
       break;
 
-    case ARG_STRIKETHROUGH_SET:
-      text_tag->strikethrough_set = GTK_VALUE_BOOL (*arg);
+    case PROP_STRIKETHROUGH_SET:
+      text_tag->strikethrough_set = g_value_get_boolean (value);
       break;
 
-    case ARG_RIGHT_MARGIN_SET:
-      text_tag->right_margin_set = GTK_VALUE_BOOL (*arg);
+    case PROP_RIGHT_MARGIN_SET:
+      text_tag->right_margin_set = g_value_get_boolean (value);
       size_changed = TRUE;
       break;
 
-    case ARG_UNDERLINE_SET:
-      text_tag->underline_set = GTK_VALUE_BOOL (*arg);
+    case PROP_UNDERLINE_SET:
+      text_tag->underline_set = g_value_get_boolean (value);
       break;
 
-    case ARG_OFFSET_SET:
-      text_tag->offset_set = GTK_VALUE_BOOL (*arg);
+    case PROP_RISE_SET:
+      text_tag->rise_set = g_value_get_boolean (value);
       size_changed = TRUE;
       break;
 
-    case ARG_BG_FULL_HEIGHT_SET:
-      text_tag->bg_full_height_set = GTK_VALUE_BOOL (*arg);
+    case PROP_BG_FULL_HEIGHT_SET:
+      text_tag->bg_full_height_set = g_value_get_boolean (value);
       break;
 
-    case ARG_LANGUAGE_SET:
-      text_tag->language_set = GTK_VALUE_BOOL (*arg);
+    case PROP_LANGUAGE_SET:
+      text_tag->language_set = g_value_get_boolean (value);
       size_changed = TRUE;
       break;
 
-    case ARG_TABS_SET:
-      text_tag->tabs_set = GTK_VALUE_BOOL (*arg);
+    case PROP_TABS_SET:
+      text_tag->tabs_set = g_value_get_boolean (value);
       size_changed = TRUE;
       break;
 
-    case ARG_INVISIBLE_SET:
-      text_tag->invisible_set = GTK_VALUE_BOOL (*arg);
+    case PROP_INVISIBLE_SET:
+      text_tag->invisible_set = g_value_get_boolean (value);
       size_changed = TRUE;
       break;
       
     default:
-      g_assert_not_reached ();
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
       break;
     }
 
-  /* FIXME I would like to do this after all set_arg in a single
-     gtk_object_set () have been called. But an idle function
-     won't work; we need to emit when the tag is changed, not
-     when we get around to the event loop. So blah, we eat some
-     inefficiency. */
+  /* FIXME I would like to do this after all set_property in a single
+   * g_object_set () have been called. But an idle function won't
+   * work; we need to emit when the tag is changed, not when we get
+   * around to the event loop. So blah, we eat some inefficiency.
+   */
 
   /* This is also somewhat weird since we emit another object's
-     signal here, but the two objects are already tightly bound. */
+   * signal here, but the two objects are already tightly bound.
+   */
 
   if (text_tag->table)
-    gtk_signal_emit_by_name (GTK_OBJECT (text_tag->table),
-                             "tag_changed",
-                             text_tag, size_changed);
+    g_signal_emit_by_name (text_tag->table,
+                           "tag_changed",
+                           text_tag, size_changed);
 }
 
 static void
-get_color_arg (GtkArg *arg, GdkColor *orig)
-{
-  GdkColor *color;
-
-  color = g_new (GdkColor, 1);
-  *color = *orig;
-  GTK_VALUE_BOXED (*arg) = color;
-}
-
-static void
-gtk_text_tag_get_arg (GtkObject *object, GtkArg *arg, guint arg_id)
+gtk_text_tag_get_property (GObject      *object,
+                           guint         prop_id,
+                           GValue       *value,
+                           GParamSpec   *pspec)
 {
   GtkTextTag *tag;
 
   tag = GTK_TEXT_TAG (object);
 
-  switch (arg_id)
+  switch (prop_id)
     {
-    case ARG_NAME:
-      GTK_VALUE_STRING (*arg) = g_strdup (tag->name);
+    case PROP_NAME:
+      g_value_set_string (value, tag->name);
       break;
 
-    case ARG_BACKGROUND_GDK:
-      get_color_arg (arg, &tag->values->appearance.bg_color);
+    case PROP_BACKGROUND_GDK:
+      g_value_set_boxed (value, &tag->values->appearance.bg_color);
       break;
 
-    case ARG_FOREGROUND_GDK:
-      get_color_arg (arg, &tag->values->appearance.fg_color);
+    case PROP_FOREGROUND_GDK:
+      g_value_set_boxed (value, &tag->values->appearance.fg_color);
       break;
 
-    case ARG_BACKGROUND_STIPPLE:
-      GTK_VALUE_BOXED (*arg) = tag->values->appearance.bg_stipple;
+    case PROP_BACKGROUND_STIPPLE:
+      if (tag->bg_stipple_set)
+        g_value_set_boxed (value, tag->values->appearance.bg_stipple);
       break;
 
-    case ARG_FOREGROUND_STIPPLE:
-      GTK_VALUE_BOXED (*arg) = tag->values->appearance.fg_stipple;
+    case PROP_FOREGROUND_STIPPLE:
+      if (tag->fg_stipple_set)
+        g_value_set_boxed (value, tag->values->appearance.fg_stipple);
       break;
 
-    case ARG_FONT:
-      if (tag->values->font_desc)
-        GTK_VALUE_STRING (*arg) = pango_font_description_to_string (tag->values->font_desc);
-      else
-        GTK_VALUE_STRING (*arg) = NULL;
+    case PROP_FONT:
+        {
+          /* FIXME GValue imposes a totally gratuitous string copy
+           * here, we could just hand off string ownership
+           */
+          gchar *str;
+
+         gtk_text_tag_ensure_font (tag);
+         
+         str = pango_font_description_to_string (tag->values->font);
+          g_value_set_string (value, str);
+          g_free (str);
+        }
       break;
 
-    case ARG_FONT_DESC:
-      if (tag->values->font_desc)
-        GTK_VALUE_BOXED (*arg) = pango_font_description_copy (tag->values->font_desc);
-      else
-        GTK_VALUE_BOXED (*arg) = NULL;
+    case PROP_FONT_DESC:
+      gtk_text_tag_ensure_font (tag);
+      g_value_set_boxed (value, tag->values->font);
+      break;
+
+    case PROP_FAMILY:
+    case PROP_STYLE:
+    case PROP_VARIANT:
+    case PROP_WEIGHT:
+    case PROP_STRETCH:
+    case PROP_SIZE:
+    case PROP_SIZE_POINTS:
+      gtk_text_tag_ensure_font (tag);
+      switch (prop_id)
+       {
+       case PROP_FAMILY:
+         g_value_set_string (value, pango_font_description_get_family (tag->values->font));
+         break;
+         
+       case PROP_STYLE:
+         g_value_set_enum (value, pango_font_description_get_style (tag->values->font));
+         break;
+         
+       case PROP_VARIANT:
+         g_value_set_enum (value, pango_font_description_get_variant (tag->values->font));
+         break;
+         
+       case PROP_WEIGHT:
+         g_value_set_int (value, pango_font_description_get_weight (tag->values->font));
+         break;
+         
+       case PROP_STRETCH:
+         g_value_set_enum (value, pango_font_description_get_stretch (tag->values->font));
+         break;
+         
+       case PROP_SIZE:
+         g_value_set_int (value, pango_font_description_get_size (tag->values->font));
+         break;
+         
+       case PROP_SIZE_POINTS:
+         g_value_set_double (value, ((double)pango_font_description_get_size (tag->values->font)) / (double)PANGO_SCALE);
+         break;
+       }
       break;
-
-    case ARG_PIXELS_ABOVE_LINES:
-      GTK_VALUE_INT (*arg) = tag->values->pixels_above_lines;
+      
+    case PROP_SCALE:
+      g_value_set_double (value, tag->values->font_scale);
       break;
-
-    case ARG_PIXELS_BELOW_LINES:
-      GTK_VALUE_INT (*arg) = tag->values->pixels_below_lines;
+      
+    case PROP_PIXELS_ABOVE_LINES:
+      g_value_set_int (value,  tag->values->pixels_above_lines);
       break;
 
-    case ARG_PIXELS_INSIDE_WRAP:
-      GTK_VALUE_INT (*arg) = tag->values->pixels_inside_wrap;
+    case PROP_PIXELS_BELOW_LINES:
+      g_value_set_int (value,  tag->values->pixels_below_lines);
       break;
 
-    case ARG_EDITABLE:
-      GTK_VALUE_BOOL (*arg) = tag->values->editable;
+    case PROP_PIXELS_INSIDE_WRAP:
+      g_value_set_int (value,  tag->values->pixels_inside_wrap);
       break;
 
-    case ARG_WRAP_MODE:
-      GTK_VALUE_ENUM (*arg) = tag->values->wrap_mode;
+    case PROP_EDITABLE:
+      g_value_set_boolean (value, tag->values->editable);
       break;
 
-    case ARG_JUSTIFY:
-      GTK_VALUE_ENUM (*arg) = tag->values->justify;
+    case PROP_WRAP_MODE:
+      g_value_set_enum (value, tag->values->wrap_mode);
       break;
 
-    case ARG_LEFT_MARGIN:
-      GTK_VALUE_INT (*arg) = tag->values->left_margin;
+    case PROP_JUSTIFICATION:
+      g_value_set_enum (value, tag->values->justification);
       break;
 
-    case ARG_INDENT:
-      GTK_VALUE_INT (*arg) = tag->values->indent;
+    case PROP_DIRECTION:
+      g_value_set_enum (value, tag->values->direction);
       break;
-
-    case ARG_STRIKETHROUGH:
-      GTK_VALUE_BOOL (*arg) = tag->values->appearance.strikethrough;
+      
+    case PROP_LEFT_MARGIN:
+      g_value_set_int (value,  tag->values->left_margin);
       break;
 
-    case ARG_RIGHT_MARGIN:
-      GTK_VALUE_INT (*arg) = tag->values->right_margin;
+    case PROP_INDENT:
+      g_value_set_int (value,  tag->values->indent);
       break;
 
-    case ARG_UNDERLINE:
-      GTK_VALUE_ENUM (*arg) = tag->values->appearance.underline;
+    case PROP_STRIKETHROUGH:
+      g_value_set_boolean (value, tag->values->appearance.strikethrough);
       break;
 
-    case ARG_OFFSET:
-      GTK_VALUE_INT (*arg) = tag->values->offset;
+    case PROP_RIGHT_MARGIN:
+      g_value_set_int (value, tag->values->right_margin);
       break;
 
-    case ARG_BG_FULL_HEIGHT:
-      GTK_VALUE_BOOL (*arg) = tag->values->bg_full_height;
+    case PROP_UNDERLINE:
+      g_value_set_enum (value, tag->values->appearance.underline);
       break;
 
-    case ARG_LANGUAGE:
-      GTK_VALUE_STRING (*arg) = g_strdup (tag->values->language);
+    case PROP_RISE:
+      g_value_set_int (value, tag->values->appearance.rise);
       break;
 
-    case ARG_TABS:
-      GTK_VALUE_POINTER (*arg) = tag->values->tabs ?
-        pango_tab_array_copy (tag->values->tabs) : NULL;
+    case PROP_BG_FULL_HEIGHT:
+      g_value_set_boolean (value, tag->values->bg_full_height);
       break;
 
-    case ARG_BACKGROUND_SET:
-    case ARG_BACKGROUND_GDK_SET:
-      GTK_VALUE_BOOL (*arg) = tag->bg_color_set;
+    case PROP_LANGUAGE:
+      g_value_set_string (value, pango_language_to_string (tag->values->language));
       break;
 
-    case ARG_FOREGROUND_SET:
-    case ARG_FOREGROUND_GDK_SET:
-      GTK_VALUE_BOOL (*arg) = tag->fg_color_set;
+    case PROP_TABS:
+      if (tag->values->tabs)
+        g_value_set_boxed (value, tag->values->tabs);
       break;
 
-    case ARG_BACKGROUND_STIPPLE_SET:
-      GTK_VALUE_BOOL (*arg) = tag->bg_stipple_set;
+    case PROP_INVISIBLE:
+      g_value_set_boolean (value, tag->values->invisible);
+      break;
+      
+    case PROP_BACKGROUND_SET:
+      g_value_set_boolean (value, tag->bg_color_set);
       break;
 
-    case ARG_FOREGROUND_STIPPLE_SET:
-      GTK_VALUE_BOOL (*arg) = tag->fg_stipple_set;
+    case PROP_FOREGROUND_SET:
+      g_value_set_boolean (value, tag->fg_color_set);
       break;
 
-    case ARG_FONT_SET:
-      GTK_VALUE_BOOL (*arg) = tag->font_set;
+    case PROP_BACKGROUND_STIPPLE_SET:
+      g_value_set_boolean (value, tag->bg_stipple_set);
       break;
 
-    case ARG_PIXELS_ABOVE_LINES_SET:
-      GTK_VALUE_BOOL (*arg) = tag->pixels_above_lines_set;
+    case PROP_FOREGROUND_STIPPLE_SET:
+      g_value_set_boolean (value, tag->fg_stipple_set);
       break;
 
-    case ARG_PIXELS_BELOW_LINES_SET:
-      GTK_VALUE_BOOL (*arg) = tag->pixels_below_lines_set;
+    case PROP_FAMILY_SET:
+    case PROP_STYLE_SET:
+    case PROP_VARIANT_SET:
+    case PROP_WEIGHT_SET:
+    case PROP_STRETCH_SET:
+    case PROP_SIZE_SET:
+      {
+       PangoFontMask set_mask = tag->values->font ? pango_font_description_get_set_fields (tag->values->font) : 0;
+       PangoFontMask test_mask = get_property_font_set_mask (prop_id);
+       g_value_set_boolean (value, (set_mask & test_mask) != 0);
+
+       break;
+      }
+
+    case PROP_SCALE_SET:
+      g_value_set_boolean (value, tag->scale_set);
+      break;
+      
+    case PROP_PIXELS_ABOVE_LINES_SET:
+      g_value_set_boolean (value, tag->pixels_above_lines_set);
       break;
 
-    case ARG_PIXELS_INSIDE_WRAP_SET:
-      GTK_VALUE_BOOL (*arg) = tag->pixels_inside_wrap_set;
+    case PROP_PIXELS_BELOW_LINES_SET:
+      g_value_set_boolean (value, tag->pixels_below_lines_set);
       break;
 
-    case ARG_EDITABLE_SET:
-      GTK_VALUE_BOOL (*arg) = tag->editable_set;
+    case PROP_PIXELS_INSIDE_WRAP_SET:
+      g_value_set_boolean (value, tag->pixels_inside_wrap_set);
       break;
 
-    case ARG_WRAP_MODE_SET:
-      GTK_VALUE_BOOL (*arg) = tag->wrap_mode_set;
+    case PROP_EDITABLE_SET:
+      g_value_set_boolean (value, tag->editable_set);
       break;
 
-    case ARG_JUSTIFY_SET:
-      GTK_VALUE_BOOL (*arg) = tag->justify_set;
+    case PROP_WRAP_MODE_SET:
+      g_value_set_boolean (value, tag->wrap_mode_set);
       break;
 
-    case ARG_LEFT_MARGIN_SET:
-      GTK_VALUE_BOOL (*arg) = tag->left_margin_set;
+    case PROP_JUSTIFICATION_SET:
+      g_value_set_boolean (value, tag->justification_set);
+      break;
+      
+    case PROP_LEFT_MARGIN_SET:
+      g_value_set_boolean (value, tag->left_margin_set);
       break;
 
-    case ARG_INDENT_SET:
-      GTK_VALUE_BOOL (*arg) = tag->indent_set;
+    case PROP_INDENT_SET:
+      g_value_set_boolean (value, tag->indent_set);
       break;
 
-    case ARG_STRIKETHROUGH_SET:
-      GTK_VALUE_BOOL (*arg) = tag->strikethrough_set;
+    case PROP_STRIKETHROUGH_SET:
+      g_value_set_boolean (value, tag->strikethrough_set);
       break;
 
-    case ARG_RIGHT_MARGIN_SET:
-      GTK_VALUE_BOOL (*arg) = tag->right_margin_set;
+    case PROP_RIGHT_MARGIN_SET:
+      g_value_set_boolean (value, tag->right_margin_set);
       break;
 
-    case ARG_UNDERLINE_SET:
-      GTK_VALUE_BOOL (*arg) = tag->underline_set;
+    case PROP_UNDERLINE_SET:
+      g_value_set_boolean (value, tag->underline_set);
       break;
 
-    case ARG_OFFSET_SET:
-      GTK_VALUE_BOOL (*arg) = tag->offset_set;
+    case PROP_RISE_SET:
+      g_value_set_boolean (value, tag->rise_set);
       break;
 
-    case ARG_BG_FULL_HEIGHT_SET:
-      GTK_VALUE_BOOL (*arg) = tag->bg_full_height_set;
+    case PROP_BG_FULL_HEIGHT_SET:
+      g_value_set_boolean (value, tag->bg_full_height_set);
       break;
 
-    case ARG_LANGUAGE_SET:
-      GTK_VALUE_BOOL (*arg) = tag->language_set;
+    case PROP_LANGUAGE_SET:
+      g_value_set_boolean (value, tag->language_set);
       break;
 
-    case ARG_TABS_SET:
-      GTK_VALUE_BOOL (*arg) = tag->tabs_set;
+    case PROP_TABS_SET:
+      g_value_set_boolean (value, tag->tabs_set);
       break;
 
-    case ARG_BACKGROUND:
-    case ARG_FOREGROUND:
+    case PROP_INVISIBLE_SET:
+      g_value_set_boolean (value, tag->invisible_set);
+      break;
+      
+    case PROP_BACKGROUND:
+    case PROP_FOREGROUND:
+      g_warning ("'foreground' and 'background' properties are not readable, use 'foreground_gdk' and 'background_gdk'");
     default:
-      arg->type = GTK_TYPE_INVALID;
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
       break;
     }
-  /* FIXME */
-  arg->type = GTK_TYPE_INVALID;
 }
 
 /*
@@ -990,7 +1664,7 @@ gtk_text_tag_get_priority (GtkTextTag *tag)
  * @priority: the new priority
  * 
  * Sets the priority of a #GtkTextTag. Valid priorities are
- * start at 0 and go to one less than gtk_text_tag_table_size().
+ * start at 0 and go to one less than gtk_text_tag_table_get_size().
  * Each tag in a table has a unique priority; setting the priority
  * of one tag shifts the priorities of all the other tags in the
  * table to maintain a unique priority for each tag. Higher priority
@@ -1010,7 +1684,7 @@ gtk_text_tag_set_priority (GtkTextTag *tag,
   g_return_if_fail (GTK_IS_TEXT_TAG (tag));
   g_return_if_fail (tag->table != NULL);
   g_return_if_fail (priority >= 0);
-  g_return_if_fail (priority < gtk_text_tag_table_size (tag->table));
+  g_return_if_fail (priority < gtk_text_tag_table_get_size (tag->table));
 
   if (priority == tag->priority)
     return;
@@ -1046,24 +1720,25 @@ gtk_text_tag_set_priority (GtkTextTag *tag,
  * 
  * Return value: result of signal emission (whether the event was handled)
  **/
-gint
+gboolean
 gtk_text_tag_event (GtkTextTag        *tag,
                     GObject           *event_object,
                     GdkEvent          *event,
                     const GtkTextIter *iter)
 {
-  gint retval = FALSE;
+  gboolean retval = FALSE;
 
   g_return_val_if_fail (GTK_IS_TEXT_TAG (tag), FALSE);
-  g_return_val_if_fail (GTK_IS_OBJECT (event_object), FALSE);
+  g_return_val_if_fail (G_IS_OBJECT (event_object), FALSE);
   g_return_val_if_fail (event != NULL, FALSE);
 
-  gtk_signal_emit (GTK_OBJECT (tag),
-                   signals[EVENT],
-                   event_object,
-                   event,
-                   iter,
-                   &retval);
+  g_signal_emit (tag,
+                 signals[EVENT],
+                 0,
+                 event_object,
+                 event,
+                 iter,
+                 &retval);
 
   return retval;
 }
@@ -1079,8 +1754,8 @@ tag_sort_func (gconstpointer first, gconstpointer second)
 }
 
 void
-gtk_text_tag_array_sort (GtkTextTag** tag_array_p,
-                         guint len)
+_gtk_text_tag_array_sort (GtkTextTag** tag_array_p,
+                          guint len)
 {
   int i, j, prio;
   GtkTextTag **tag;
@@ -1145,7 +1820,7 @@ gtk_text_attributes_new (void)
 {
   GtkTextAttributes *values;
 
-  values = g_new0(GtkTextAttributes, 1);
+  values = g_new0 (GtkTextAttributes, 1);
 
   /* 0 is a valid value for most of the struct */
 
@@ -1153,13 +1828,54 @@ gtk_text_attributes_new (void)
 
   values->language = gtk_get_default_language ();
 
+  values->font_scale = 1.0;
+  
   return values;
 }
 
-/* FIXME change the signature of this to be correct */
+/**
+ * gtk_text_attributes_copy:
+ * @src: a #GtkTextAttributes to be copied
+ * 
+ * Copies @src and returns a new #GtkTextAttributes.
+ * 
+ * Return value: a copy of @src
+ **/
+GtkTextAttributes*
+gtk_text_attributes_copy (GtkTextAttributes *src)
+{
+  GtkTextAttributes *dest;
+
+  dest = gtk_text_attributes_new ();
+  gtk_text_attributes_copy_values (src, dest);
+
+  return dest;
+}
+
+GType
+gtk_text_attributes_get_type (void)
+{
+  static GType our_type = 0;
+  
+  if (our_type == 0)
+    our_type = g_boxed_type_register_static ("GtkTextAttributes",
+                                            (GBoxedCopyFunc) gtk_text_attributes_ref,
+                                            (GBoxedFreeFunc) gtk_text_attributes_unref);
+
+  return our_type;
+}
+
+/**
+ * gtk_text_attributes_copy_values:
+ * @src: a #GtkTextAttributes
+ * @dest: another #GtkTextAttributes
+ * 
+ * Copies the values from @src to @dest so that @dest has the same values
+ * as @src. Frees existing values in @dest.
+ **/
 void
-gtk_text_attributes_copy (GtkTextAttributes *src,
-                          GtkTextAttributes *dest)
+gtk_text_attributes_copy_values (GtkTextAttributes *src,
+                                 GtkTextAttributes *dest)
 {
   guint orig_refcount;
 
@@ -1171,38 +1887,45 @@ gtk_text_attributes_copy (GtkTextAttributes *src,
   /* Add refs */
 
   if (src->appearance.bg_stipple)
-    gdk_bitmap_ref (src->appearance.bg_stipple);
+    g_object_ref (src->appearance.bg_stipple);
 
   if (src->appearance.fg_stipple)
-    gdk_bitmap_ref (src->appearance.fg_stipple);
+    g_object_ref (src->appearance.fg_stipple);
 
   /* Remove refs */
 
   if (dest->appearance.bg_stipple)
-    gdk_bitmap_unref (dest->appearance.bg_stipple);
+    g_object_unref (dest->appearance.bg_stipple);
 
   if (dest->appearance.fg_stipple)
-    gdk_bitmap_unref (dest->appearance.fg_stipple);
+    g_object_unref (dest->appearance.fg_stipple);
 
-  if (dest->language)
-    g_free (dest->language);
+  if (dest->font)
+    pango_font_description_free (dest->font);
   
   /* Copy */
   orig_refcount = dest->refcount;
 
   *dest = *src;
 
-  dest->font_desc = pango_font_description_copy (src->font_desc);
-
   if (src->tabs)
     dest->tabs = pango_tab_array_copy (src->tabs);
 
-  dest->language = g_strdup (src->language);
+  dest->language = src->language;
 
+  if (dest->font)
+    dest->font = pango_font_description_copy (src->font);
+  
   dest->refcount = orig_refcount;
   dest->realized = FALSE;
 }
 
+/**
+ * gtk_text_attributes_ref:
+ * @values: a #GtkTextAttributes
+ * 
+ * Increments the reference count on @values.
+ **/
 void
 gtk_text_attributes_ref (GtkTextAttributes *values)
 {
@@ -1211,6 +1934,13 @@ gtk_text_attributes_ref (GtkTextAttributes *values)
   values->refcount += 1;
 }
 
+/**
+ * gtk_text_attributes_unref:
+ * @values: a #GtkTextAttributes
+ * 
+ * Decrements the reference count on @values, freeing the structure
+ * if the reference count reaches 0.
+ **/
 void
 gtk_text_attributes_unref (GtkTextAttributes *values)
 {
@@ -1224,28 +1954,25 @@ gtk_text_attributes_unref (GtkTextAttributes *values)
       g_assert (!values->realized);
 
       if (values->appearance.bg_stipple)
-        gdk_bitmap_unref (values->appearance.bg_stipple);
-
-      if (values->font_desc)
-        pango_font_description_free (values->font_desc);
+        g_object_unref (values->appearance.bg_stipple);
 
       if (values->appearance.fg_stipple)
-        gdk_bitmap_unref (values->appearance.fg_stipple);
+        g_object_unref (values->appearance.fg_stipple);
 
       if (values->tabs)
         pango_tab_array_free (values->tabs);
 
-      if (values->language)
-        g_free (values->language);
-
+      if (values->font)
+       pango_font_description_free (values->font);
+      
       g_free (values);
     }
 }
 
 void
-gtk_text_attributes_realize (GtkTextAttributes *values,
-                             GdkColormap *cmap,
-                             GdkVisual *visual)
+_gtk_text_attributes_realize (GtkTextAttributes *values,
+                              GdkColormap *cmap,
+                              GdkVisual *visual)
 {
   g_return_if_fail (values != NULL);
   g_return_if_fail (values->refcount > 0);
@@ -1264,9 +1991,9 @@ gtk_text_attributes_realize (GtkTextAttributes *values,
 }
 
 void
-gtk_text_attributes_unrealize (GtkTextAttributes *values,
-                               GdkColormap *cmap,
-                               GdkVisual *visual)
+_gtk_text_attributes_unrealize (GtkTextAttributes *values,
+                                GdkColormap *cmap,
+                                GdkVisual *visual)
 {
   g_return_if_fail (values != NULL);
   g_return_if_fail (values->refcount > 0);
@@ -1286,9 +2013,9 @@ gtk_text_attributes_unrealize (GtkTextAttributes *values,
 }
 
 void
-gtk_text_attributes_fill_from_tags (GtkTextAttributes *dest,
-                                    GtkTextTag**        tags,
-                                    guint               n_tags)
+_gtk_text_attributes_fill_from_tags (GtkTextAttributes *dest,
+                                     GtkTextTag**       tags,
+                                     guint              n_tags)
 {
   guint n = 0;
 
@@ -1299,6 +2026,7 @@ gtk_text_attributes_fill_from_tags (GtkTextAttributes *dest,
       GtkTextTag *tag = tags[n];
       GtkTextAttributes *vals = tag->values;
 
+      g_assert (tag->table != NULL);
       if (n > 0)
         g_assert (tags[n]->priority > tags[n-1]->priority);
 
@@ -1308,37 +2036,41 @@ gtk_text_attributes_fill_from_tags (GtkTextAttributes *dest,
 
           dest->appearance.draw_bg = TRUE;
         }
-
+      if (tag->fg_color_set)
+        dest->appearance.fg_color = vals->appearance.fg_color;
+      
       if (tag->bg_stipple_set)
         {
-          gdk_bitmap_ref (vals->appearance.bg_stipple);
+          g_object_ref (vals->appearance.bg_stipple);
           if (dest->appearance.bg_stipple)
-            gdk_bitmap_unref (dest->appearance.bg_stipple);
+            g_object_unref (dest->appearance.bg_stipple);
           dest->appearance.bg_stipple = vals->appearance.bg_stipple;
 
           dest->appearance.draw_bg = TRUE;
         }
 
-      if (tag->fg_color_set)
-        dest->appearance.fg_color = vals->appearance.fg_color;
-
-      if (tag->font_set)
-        {
-          if (dest->font_desc)
-            pango_font_description_free (dest->font_desc);
-          dest->font_desc = pango_font_description_copy (vals->font_desc);
-        }
-
       if (tag->fg_stipple_set)
         {
-          gdk_bitmap_ref (vals->appearance.fg_stipple);
+          g_object_ref (vals->appearance.fg_stipple);
           if (dest->appearance.fg_stipple)
-            gdk_bitmap_unref (dest->appearance.fg_stipple);
+            g_object_unref (dest->appearance.fg_stipple);
           dest->appearance.fg_stipple = vals->appearance.fg_stipple;
         }
 
-      if (tag->justify_set)
-        dest->justify = vals->justify;
+      if (vals->font)
+       {
+         if (dest->font)
+           pango_font_description_merge (dest->font, vals->font, TRUE);
+         else
+           dest->font = pango_font_description_copy (vals->font);
+       }
+
+      /* multiply all the scales together to get a composite */
+      if (tag->scale_set)
+        dest->font_scale *= vals->font_scale;
+      
+      if (tag->justification_set)
+        dest->justification = vals->justification;
 
       if (vals->direction != GTK_TEXT_DIR_NONE)
         dest->direction = vals->direction;
@@ -1349,8 +2081,8 @@ gtk_text_attributes_fill_from_tags (GtkTextAttributes *dest,
       if (tag->indent_set)
         dest->indent = vals->indent;
 
-      if (tag->offset_set)
-        dest->offset = vals->offset;
+      if (tag->rise_set)
+        dest->appearance.rise = vals->appearance.rise;
 
       if (tag->right_margin_set)
         dest->right_margin = vals->right_margin;
@@ -1390,26 +2122,24 @@ gtk_text_attributes_fill_from_tags (GtkTextAttributes *dest,
         dest->bg_full_height = vals->bg_full_height;
 
       if (tag->language_set)
-        {
-          g_free (dest->language);
-          dest->language = g_strdup (vals->language);
-        }
+       dest->language = vals->language;
 
       ++n;
     }
 }
 
 gboolean
-gtk_text_tag_affects_size (GtkTextTag *tag)
+_gtk_text_tag_affects_size (GtkTextTag *tag)
 {
   g_return_val_if_fail (GTK_IS_TEXT_TAG (tag), FALSE);
 
   return
-    tag->font_set ||
-    tag->justify_set ||
+    (tag->values->font && pango_font_description_get_set_fields (tag->values->font) != 0) ||
+    tag->scale_set ||
+    tag->justification_set ||
     tag->left_margin_set ||
     tag->indent_set ||
-    tag->offset_set ||
+    tag->rise_set ||
     tag->right_margin_set ||
     tag->pixels_above_lines_set ||
     tag->pixels_below_lines_set ||
@@ -1421,7 +2151,7 @@ gtk_text_tag_affects_size (GtkTextTag *tag)
 }
 
 gboolean
-gtk_text_tag_affects_nonsize_appearance (GtkTextTag *tag)
+_gtk_text_tag_affects_nonsize_appearance (GtkTextTag *tag)
 {
   g_return_val_if_fail (GTK_IS_TEXT_TAG (tag), FALSE);