]> Pileus Git - ~andy/gtk/blobdiff - gtk/gtkscale.c
new default color scheme based on the GNOME stock icon palette. (#80691,
[~andy/gtk] / gtk / gtkscale.c
index 2aa5483f4f70c0b33d88947208baadadffd48480..598d9dc1ab9516e3eb5f5f79719d0411fd6b4817 100644 (file)
 /* GTK - The GIMP Toolkit
  * Copyright (C) 1995-1997 Peter Mattis, Spencer Kimball and Josh MacDonald
+ * Copyright (C) 2001 Red Hat, Inc.
  *
  * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Library General Public
+ * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Library General Public License for more details.
+ * Lesser General Public License for more details.
  *
- * You should have received a copy of the GNU Library General Public
+ * You should have received a copy of the GNU Lesser General Public
  * License along with this library; if not, write to the
  * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
  * Boston, MA 02111-1307, USA.
  */
 
 /*
- * Modified by the GTK+ Team and others 1997-1999.  See the AUTHORS
+ * Modified by the GTK+ Team and others 1997-2000.  See the AUTHORS
  * file for a list of people on the GTK+ Team.  See the ChangeLog
  * files for a list of changes.  These files are distributed with
  * GTK+ at ftp://ftp.gtk.org/pub/gtk/. 
  */
 
 #include <math.h>
-#include "gtkcontainer.h"
+#include "gtkintl.h"
 #include "gtkscale.h"
-
-enum {
-  ARG_0,
-  ARG_DIGITS,
-  ARG_DRAW_VALUE,
-  ARG_VALUE_POS
-};
+#include "gtkmarshalers.h"
+#include "gdk/gdkkeysyms.h"
+#include "gtkbindings.h"
 
 
-static void gtk_scale_class_init      (GtkScaleClass *klass);
-static void gtk_scale_init            (GtkScale      *scale);
-static void gtk_scale_set_arg         (GtkObject     *object,
-                                      GtkArg        *arg,
-                                      guint          arg_id);
-static void gtk_scale_get_arg         (GtkObject     *object,
-                                      GtkArg        *arg,
-                                      guint          arg_id);
-static void gtk_scale_map             (GtkWidget     *widget);
-static void gtk_scale_unmap           (GtkWidget     *widget);
+#define        MAX_DIGITS      (64)    /* don't change this,
+                                * a) you don't need to and
+                                * b) you might cause buffer owerflows in
+                                *    unrelated code portions otherwise
+                                */
 
-static void gtk_scale_draw_background (GtkRange      *range);
+enum {
+  PROP_0,
+  PROP_DIGITS,
+  PROP_DRAW_VALUE,
+  PROP_VALUE_POS
+};
 
+enum {
+  FORMAT_VALUE,
+  LAST_SIGNAL
+};
 
+static guint signals[LAST_SIGNAL];
 static GtkRangeClass *parent_class = NULL;
 
-
-GtkType
+static void gtk_scale_class_init       (GtkScaleClass *klass);
+static void gtk_scale_init             (GtkScale      *scale);
+static void gtk_scale_set_property     (GObject       *object,
+                                        guint          prop_id,
+                                        const GValue  *value,
+                                        GParamSpec    *pspec);
+static void gtk_scale_get_property     (GObject       *object,
+                                        guint          prop_id,
+                                        GValue        *value,
+                                        GParamSpec    *pspec);
+static void gtk_scale_style_set        (GtkWidget     *widget,
+                                        GtkStyle      *previous);
+static void gtk_scale_get_range_border (GtkRange      *range,
+                                        GtkBorder     *border);
+
+GType
 gtk_scale_get_type (void)
 {
-  static GtkType scale_type = 0;
+  static GType scale_type = 0;
 
   if (!scale_type)
     {
-      static const GtkTypeInfo scale_info =
+      static const GTypeInfo scale_info =
       {
-       "GtkScale",
-       sizeof (GtkScale),
        sizeof (GtkScaleClass),
-       (GtkClassInitFunc) gtk_scale_class_init,
-       (GtkObjectInitFunc) gtk_scale_init,
-       /* reserved_1 */ NULL,
-        /* reserved_2 */ NULL,
-        (GtkClassInitFunc) NULL,
+       NULL,           /* base_init */
+       NULL,           /* base_finalize */
+       (GClassInitFunc) gtk_scale_class_init,
+       NULL,           /* class_finalize */
+       NULL,           /* class_data */
+       sizeof (GtkScale),
+       0,              /* n_preallocs */
+       (GInstanceInitFunc) gtk_scale_init,
+       NULL,           /* value_table */
       };
 
-      scale_type = gtk_type_unique (GTK_TYPE_RANGE, &scale_info);
+      scale_type = g_type_register_static (GTK_TYPE_RANGE, "GtkScale",
+                                          &scale_info, G_TYPE_FLAG_ABSTRACT);
     }
 
   return scale_type;
 }
 
+static gboolean
+single_string_accumulator (GSignalInvocationHint *ihint,
+                           GValue                *return_accu,
+                           const GValue          *handler_return,
+                           gpointer               dummy)
+{
+  gboolean continue_emission;
+  const gchar *str;
+  
+  str = g_value_get_string (handler_return);
+  g_value_set_string (return_accu, str);
+  continue_emission = str == NULL;
+  
+  return continue_emission;
+}
+
+
+#define add_slider_binding(binding_set, keyval, mask, scroll)          \
+  gtk_binding_entry_add_signal (binding_set, keyval, mask,             \
+                                "move_slider", 1,                      \
+                                GTK_TYPE_SCROLL_TYPE, scroll)
+
 static void
 gtk_scale_class_init (GtkScaleClass *class)
 {
-  GtkObjectClass *object_class;
+  GObjectClass   *gobject_class;
   GtkWidgetClass *widget_class;
-  GtkRangeClass *range_class;
-
-  object_class = (GtkObjectClass*) class;
+  GtkRangeClass  *range_class;
+  GtkBindingSet  *binding_set;
+  
+  gobject_class = G_OBJECT_CLASS (class);
   range_class = (GtkRangeClass*) class;
   widget_class = (GtkWidgetClass*) class;
   
-  parent_class = gtk_type_class (GTK_TYPE_RANGE);
+  parent_class = g_type_class_peek_parent (class);
+  
+  gobject_class->set_property = gtk_scale_set_property;
+  gobject_class->get_property = gtk_scale_get_property;
+
+  widget_class->style_set = gtk_scale_style_set;
+
+  range_class->get_range_border = gtk_scale_get_range_border;
+  
+  signals[FORMAT_VALUE] =
+    g_signal_new ("format_value",
+                  G_TYPE_FROM_CLASS (gobject_class),
+                  G_SIGNAL_RUN_LAST,
+                  G_STRUCT_OFFSET (GtkScaleClass, format_value),
+                  single_string_accumulator, NULL,
+                  _gtk_marshal_STRING__DOUBLE,
+                  G_TYPE_STRING, 1,
+                  G_TYPE_DOUBLE);
+
+  g_object_class_install_property (gobject_class,
+                                   PROP_DIGITS,
+                                   g_param_spec_int ("digits",
+                                                    _("Digits"),
+                                                    _("The number of decimal places that are displayed in the value"),
+                                                    -1,
+                                                    MAX_DIGITS,
+                                                    1,
+                                                    G_PARAM_READWRITE));
+  
+  g_object_class_install_property (gobject_class,
+                                   PROP_DRAW_VALUE,
+                                   g_param_spec_boolean ("draw_value",
+                                                        _("Draw Value"),
+                                                        _("Whether the current value is displayed as a string next to the slider"),
+                                                        FALSE,
+                                                        G_PARAM_READWRITE));
+  
+  g_object_class_install_property (gobject_class,
+                                   PROP_VALUE_POS,
+                                   g_param_spec_enum ("value_pos",
+                                                     _("Value Position"),
+                                                     _("The position in which the current value is displayed"),
+                                                     GTK_TYPE_POSITION_TYPE,
+                                                     GTK_POS_LEFT,
+                                                     G_PARAM_READWRITE));
+
+  gtk_widget_class_install_style_property (widget_class,
+                                          g_param_spec_int ("slider_length",
+                                                            _("Slider Length"),
+                                                            _("Length of scale's slider"),
+                                                            0,
+                                                            G_MAXINT,
+                                                            31,
+                                                            G_PARAM_READABLE));
+
+  gtk_widget_class_install_style_property (widget_class,
+                                          g_param_spec_int ("value_spacing",
+                                                            _("Value spacing"),
+                                                            _("Space between value text and the slider/trough area"),
+                                                            0,
+                                                            G_MAXINT,
+                                                            2,
+                                                            G_PARAM_READABLE));
+  
+  /* All bindings (even arrow keys) are on both h/v scale, because
+   * blind users etc. don't care about scale orientation.
+   */
+  
+  binding_set = gtk_binding_set_by_class (class);
+
+  add_slider_binding (binding_set, GDK_Left, 0,
+                      GTK_SCROLL_STEP_LEFT);
+
+  add_slider_binding (binding_set, GDK_Left, GDK_CONTROL_MASK,
+                      GTK_SCROLL_PAGE_LEFT);
+
+  add_slider_binding (binding_set, GDK_KP_Left, 0,
+                      GTK_SCROLL_STEP_LEFT);
+
+  add_slider_binding (binding_set, GDK_KP_Left, GDK_CONTROL_MASK,
+                      GTK_SCROLL_PAGE_LEFT);
+
+  add_slider_binding (binding_set, GDK_Right, 0,
+                      GTK_SCROLL_STEP_RIGHT);
+
+  add_slider_binding (binding_set, GDK_Right, GDK_CONTROL_MASK,
+                      GTK_SCROLL_PAGE_RIGHT);
+
+  add_slider_binding (binding_set, GDK_KP_Right, 0,
+                      GTK_SCROLL_STEP_RIGHT);
+
+  add_slider_binding (binding_set, GDK_KP_Right, GDK_CONTROL_MASK,
+                      GTK_SCROLL_PAGE_RIGHT);
+
+  add_slider_binding (binding_set, GDK_Up, 0,
+                      GTK_SCROLL_STEP_UP);
+
+  add_slider_binding (binding_set, GDK_Up, GDK_CONTROL_MASK,
+                      GTK_SCROLL_PAGE_UP);
+
+  add_slider_binding (binding_set, GDK_KP_Up, 0,
+                      GTK_SCROLL_STEP_UP);
+
+  add_slider_binding (binding_set, GDK_KP_Up, GDK_CONTROL_MASK,
+                      GTK_SCROLL_PAGE_UP);
+
+  add_slider_binding (binding_set, GDK_Down, 0,
+                      GTK_SCROLL_STEP_DOWN);
+
+  add_slider_binding (binding_set, GDK_Down, GDK_CONTROL_MASK,
+                      GTK_SCROLL_PAGE_DOWN);
+
+  add_slider_binding (binding_set, GDK_KP_Down, 0,
+                      GTK_SCROLL_STEP_DOWN);
+
+  add_slider_binding (binding_set, GDK_KP_Down, GDK_CONTROL_MASK,
+                      GTK_SCROLL_PAGE_DOWN);
+   
+  add_slider_binding (binding_set, GDK_Page_Up, 0,
+                      GTK_SCROLL_PAGE_LEFT);
+
+  add_slider_binding (binding_set, GDK_KP_Page_Up, 0,
+                      GTK_SCROLL_PAGE_LEFT);  
+
+  add_slider_binding (binding_set, GDK_Page_Up, 0,
+                      GTK_SCROLL_PAGE_UP);
+
+  add_slider_binding (binding_set, GDK_KP_Page_Up, 0,
+                      GTK_SCROLL_PAGE_UP);
+  
+  add_slider_binding (binding_set, GDK_Page_Down, 0,
+                      GTK_SCROLL_PAGE_RIGHT);
+
+  add_slider_binding (binding_set, GDK_KP_Page_Down, 0,
+                      GTK_SCROLL_PAGE_RIGHT);
+
+  add_slider_binding (binding_set, GDK_Page_Down, 0,
+                      GTK_SCROLL_PAGE_DOWN);
+
+  add_slider_binding (binding_set, GDK_KP_Page_Down, 0,
+                      GTK_SCROLL_PAGE_DOWN);
+
+  /* Logical bindings (vs. visual bindings above) */
+
+  add_slider_binding (binding_set, GDK_plus, 0,
+                      GTK_SCROLL_STEP_FORWARD);  
+
+  add_slider_binding (binding_set, GDK_minus, 0,
+                      GTK_SCROLL_STEP_BACKWARD);  
+
+  add_slider_binding (binding_set, GDK_plus, GDK_CONTROL_MASK,
+                      GTK_SCROLL_PAGE_FORWARD);  
+
+  add_slider_binding (binding_set, GDK_minus, GDK_CONTROL_MASK,
+                      GTK_SCROLL_PAGE_BACKWARD);
+
+
+  add_slider_binding (binding_set, GDK_KP_Add, 0,
+                      GTK_SCROLL_STEP_FORWARD);  
+
+  add_slider_binding (binding_set, GDK_KP_Subtract, 0,
+                      GTK_SCROLL_STEP_BACKWARD);  
+
+  add_slider_binding (binding_set, GDK_KP_Add, GDK_CONTROL_MASK,
+                      GTK_SCROLL_PAGE_FORWARD);  
+
+  add_slider_binding (binding_set, GDK_KP_Subtract, GDK_CONTROL_MASK,
+                      GTK_SCROLL_PAGE_BACKWARD);
   
-  gtk_object_add_arg_type ("GtkScale::digits",
-                          GTK_TYPE_INT,
-                          GTK_ARG_READWRITE,
-                          ARG_DIGITS);
-  gtk_object_add_arg_type ("GtkScale::draw_value",
-                          GTK_TYPE_BOOL,
-                          GTK_ARG_READWRITE,
-                          ARG_DRAW_VALUE);
-  gtk_object_add_arg_type ("GtkScale::value_pos",
-                          GTK_TYPE_POSITION_TYPE,
-                          GTK_ARG_READWRITE,
-                          ARG_VALUE_POS);
-
-  object_class->set_arg = gtk_scale_set_arg;
-  object_class->get_arg = gtk_scale_get_arg;
-
-  widget_class->map = gtk_scale_map;
-  widget_class->unmap = gtk_scale_unmap;
   
-  range_class->draw_background = gtk_scale_draw_background;
+  add_slider_binding (binding_set, GDK_Home, 0,
+                      GTK_SCROLL_START);
+
+  add_slider_binding (binding_set, GDK_KP_Home, 0,
+                      GTK_SCROLL_START);
+
+  add_slider_binding (binding_set, GDK_End, 0,
+                      GTK_SCROLL_END);
 
-  class->slider_length = 31;
-  class->value_spacing = 2;
-  class->draw_value = NULL;
+  add_slider_binding (binding_set, GDK_KP_End, 0,
+                      GTK_SCROLL_END);
 }
 
 static void
-gtk_scale_set_arg (GtkObject      *object,
-                  GtkArg         *arg,
-                  guint           arg_id)
+gtk_scale_set_property (GObject      *object,
+                       guint         prop_id,
+                       const GValue *value,
+                       GParamSpec   *pspec)
 {
   GtkScale *scale;
 
   scale = GTK_SCALE (object);
 
-  switch (arg_id)
+  switch (prop_id)
     {
-    case ARG_DIGITS:
-      gtk_scale_set_digits (scale, GTK_VALUE_INT (*arg));
+    case PROP_DIGITS:
+      gtk_scale_set_digits (scale, g_value_get_int (value));
       break;
-    case ARG_DRAW_VALUE:
-      gtk_scale_set_draw_value (scale, GTK_VALUE_BOOL (*arg));
+    case PROP_DRAW_VALUE:
+      gtk_scale_set_draw_value (scale, g_value_get_boolean (value));
       break;
-    case ARG_VALUE_POS:
-      gtk_scale_set_value_pos (scale, GTK_VALUE_ENUM (*arg));
+    case PROP_VALUE_POS:
+      gtk_scale_set_value_pos (scale, g_value_get_enum (value));
       break;
     default:
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
       break;
     }
 }
 
 static void
-gtk_scale_get_arg (GtkObject      *object,
-                  GtkArg         *arg,
-                  guint           arg_id)
+gtk_scale_get_property (GObject      *object,
+                       guint         prop_id,
+                       GValue       *value,
+                       GParamSpec   *pspec)
 {
   GtkScale *scale;
 
   scale = GTK_SCALE (object);
 
-  switch (arg_id)
+  switch (prop_id)
     {
-    case ARG_DIGITS:
-      GTK_VALUE_INT (*arg) = GTK_RANGE (scale)->digits;
+    case PROP_DIGITS:
+      g_value_set_int (value, scale->digits);
       break;
-    case ARG_DRAW_VALUE:
-      GTK_VALUE_BOOL (*arg) = scale->draw_value;
+    case PROP_DRAW_VALUE:
+      g_value_set_boolean (value, scale->draw_value);
       break;
-    case ARG_VALUE_POS:
-      GTK_VALUE_ENUM (*arg) = scale->value_pos;
+    case PROP_VALUE_POS:
+      g_value_set_enum (value, scale->value_pos);
       break;
     default:
-      arg->type = GTK_TYPE_INVALID;
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
       break;
     }
 }
 
 static void
 gtk_scale_init (GtkScale *scale)
-{
-  GTK_WIDGET_SET_FLAGS (scale, GTK_CAN_FOCUS);
-  GTK_WIDGET_SET_FLAGS (scale, GTK_NO_WINDOW);
-  GTK_RANGE (scale)->digits = 1;
-  scale->draw_value = TRUE;
-  scale->value_pos = GTK_POS_TOP;
-}
-
-static void
-gtk_scale_map (GtkWidget *widget)
 {
   GtkRange *range;
 
-  g_return_if_fail (widget != NULL);
-  g_return_if_fail (GTK_IS_SCALE (widget));
-
-  GTK_WIDGET_SET_FLAGS (widget, GTK_MAPPED);
-  range = GTK_RANGE (widget);
-
-  gdk_window_show (range->trough);
-}
-
-static void
-gtk_scale_unmap (GtkWidget *widget)
-{
-  GtkRange *range;
-
-  g_return_if_fail (widget != NULL);
-  g_return_if_fail (GTK_IS_SCALE (widget));
-
-  GTK_WIDGET_UNSET_FLAGS (widget, GTK_MAPPED);
-  range = GTK_RANGE (widget);
-
-  if (GTK_WIDGET_NO_WINDOW (widget))
-     gtk_widget_queue_clear (widget);
+  range = GTK_RANGE (scale);
+  
+  GTK_WIDGET_SET_FLAGS (scale, GTK_CAN_FOCUS);
 
-  gdk_window_hide (range->trough);
+  range->slider_size_fixed = TRUE;
+  range->has_stepper_a = FALSE;
+  range->has_stepper_b = FALSE;
+  range->has_stepper_c = FALSE;
+  range->has_stepper_d = FALSE;
+  
+  scale->draw_value = TRUE;
+  scale->value_pos = GTK_POS_TOP;
+  scale->digits = 1;
+  range->round_digits = scale->digits;
 }
 
 void
 gtk_scale_set_digits (GtkScale *scale,
                      gint      digits)
 {
-  g_return_if_fail (scale != NULL);
+  GtkRange *range;
+  
   g_return_if_fail (GTK_IS_SCALE (scale));
 
-  digits = CLAMP (digits, -1, 16);
+  range = GTK_RANGE (scale);
+  
+  digits = CLAMP (digits, -1, MAX_DIGITS);
 
-  if (GTK_RANGE (scale)->digits != digits)
+  if (scale->digits != digits)
     {
-      GTK_RANGE (scale)->digits = digits;
-
+      scale->digits = digits;
+      if (scale->draw_value)
+       range->round_digits = digits;
+      
       gtk_widget_queue_resize (GTK_WIDGET (scale));
+
+      g_object_notify (G_OBJECT (scale), "digits");
     }
 }
 
+gint
+gtk_scale_get_digits (GtkScale *scale)
+{
+  g_return_val_if_fail (GTK_IS_SCALE (scale), -1);
+
+  return scale->digits;
+}
+
 void
 gtk_scale_set_draw_value (GtkScale *scale,
                          gboolean  draw_value)
 {
-  g_return_if_fail (scale != NULL);
   g_return_if_fail (GTK_IS_SCALE (scale));
 
   draw_value = draw_value != FALSE;
@@ -238,16 +432,29 @@ gtk_scale_set_draw_value (GtkScale *scale,
   if (scale->draw_value != draw_value)
     {
       scale->draw_value = draw_value;
+      if (draw_value)
+       GTK_RANGE (scale)->round_digits = scale->digits;
+      else
+       GTK_RANGE (scale)->round_digits = -1;
 
       gtk_widget_queue_resize (GTK_WIDGET (scale));
+
+      g_object_notify (G_OBJECT (scale), "draw_value");
     }
 }
 
+gboolean
+gtk_scale_get_draw_value (GtkScale *scale)
+{
+  g_return_val_if_fail (GTK_IS_SCALE (scale), FALSE);
+
+  return scale->draw_value;
+}
+
 void
 gtk_scale_set_value_pos (GtkScale        *scale,
                         GtkPositionType  pos)
 {
-  g_return_if_fail (scale != NULL);
   g_return_if_fail (GTK_IS_SCALE (scale));
 
   if (scale->value_pos != pos)
@@ -256,75 +463,95 @@ gtk_scale_set_value_pos (GtkScale        *scale,
 
       if (GTK_WIDGET_VISIBLE (scale) && GTK_WIDGET_MAPPED (scale))
        gtk_widget_queue_resize (GTK_WIDGET (scale));
+
+      g_object_notify (G_OBJECT (scale), "value_pos");
     }
 }
 
+GtkPositionType
+gtk_scale_get_value_pos (GtkScale *scale)
+{
+  g_return_val_if_fail (GTK_IS_SCALE (scale), 0);
+
+  return scale->value_pos;
+}
+
+static void
+gtk_scale_get_range_border (GtkRange  *range,
+                            GtkBorder *border)
+{
+  GtkWidget *widget;
+  GtkScale *scale;
+  gint w, h;
+  
+  widget = GTK_WIDGET (range);
+  scale = GTK_SCALE (range);
+
+  _gtk_scale_get_value_size (scale, &w, &h);
+
+  border->left = 0;
+  border->right = 0;
+  border->top = 0;
+  border->bottom = 0;
+
+  if (scale->draw_value)
+    {
+      gint value_spacing;
+      gtk_widget_style_get (widget, "value_spacing", &value_spacing, NULL);
+
+      switch (scale->value_pos)
+        {
+        case GTK_POS_LEFT:
+          border->left += w + value_spacing;
+          break;
+        case GTK_POS_RIGHT:
+          border->right += w + value_spacing;
+          break;
+        case GTK_POS_TOP:
+          border->top += h + value_spacing;
+          break;
+        case GTK_POS_BOTTOM:
+          border->bottom += h + value_spacing;
+          break;
+        }
+    }
+}
+
+/* FIXME this could actually be static at the moment. */
 void
-gtk_scale_get_value_size (GtkScale *scale,
-                         gint     *width,
-                         gint     *height)
+_gtk_scale_get_value_size (GtkScale *scale,
+                           gint     *width,
+                           gint     *height)
 {
   GtkRange *range;
 
-  g_return_if_fail (scale != NULL);
   g_return_if_fail (GTK_IS_SCALE (scale));
 
   if (scale->draw_value)
     {
       PangoLayout *layout;
       PangoRectangle logical_rect;
-      gchar buffer[128];
-      gfloat value;
-      gint digits;
-      gint i, j;
+      gchar *txt;
       
       range = GTK_RANGE (scale);
 
       layout = gtk_widget_create_pango_layout (GTK_WIDGET (scale), NULL);
 
-      value = ABS (range->adjustment->lower);
-      if (value == 0) value = 1;
-      digits = log10 (value) + 1;
-      if (digits > 13)
-       digits = 13;
-
-      i = 0;
-      if (range->adjustment->lower < 0)
-        buffer[i++] = '-';
-      for (j = 0; j < digits; j++)
-        buffer[i++] = '0';
-      if (GTK_RANGE (scale)->digits)
-        buffer[i++] = '.';
-      for (j = 0; j < GTK_RANGE (scale)->digits; j++)
-        buffer[i++] = '0';
-      buffer[i] = '\0';
-
-      pango_layout_set_text (layout, buffer, i);
+      txt = _gtk_scale_format_value (scale, range->adjustment->lower);
+      pango_layout_set_text (layout, txt, -1);
+      g_free (txt);
+      
       pango_layout_get_pixel_extents (layout, NULL, &logical_rect);
 
       if (width)
        *width = logical_rect.width;
       if (height)
-       *height = logical_rect.width;
+       *height = logical_rect.height;
+
+      txt = _gtk_scale_format_value (scale, range->adjustment->upper);
+      pango_layout_set_text (layout, txt, -1);
+      g_free (txt);
       
-      value = ABS (range->adjustment->upper);
-      if (value == 0) value = 1;
-      digits = log10 (value) + 1;
-      if (digits > 13)
-        digits = 13;
-
-      i = 0;
-      if (range->adjustment->upper < 0)
-        buffer[i++] = '-';
-      for (j = 0; j < digits; j++)
-        buffer[i++] = '0';
-      if (GTK_RANGE (scale)->digits)
-        buffer[i++] = '.';
-      for (j = 0; j < GTK_RANGE (scale)->digits; j++)
-        buffer[i++] = '0';
-      buffer[i] = '\0';
-
-      pango_layout_set_text (layout, buffer, i);
       pango_layout_get_pixel_extents (layout, NULL, &logical_rect);
 
       if (width)
@@ -332,7 +559,7 @@ gtk_scale_get_value_size (GtkScale *scale,
       if (height)
        *height = MAX (*height, logical_rect.height);
 
-      g_object_unref (G_OBJECT (layout));
+      g_object_unref (layout);
     }
   else
     {
@@ -344,35 +571,50 @@ gtk_scale_get_value_size (GtkScale *scale,
 
 }
 
-gint
-gtk_scale_get_value_width (GtkScale *scale)
+static void
+gtk_scale_style_set (GtkWidget *widget,
+                     GtkStyle  *previous)
 {
-  gint width;
+  gint slider_length;
+  GtkRange *range;
 
-  g_return_val_if_fail (scale != NULL, 0);
-  g_return_val_if_fail (GTK_IS_SCALE (scale), 0);
+  range = GTK_RANGE (widget);
   
-  gtk_scale_get_value_size (scale, &width, NULL);
-
-  return width;
-}
-
-void
-gtk_scale_draw_value (GtkScale *scale)
-{
-  g_return_if_fail (scale != NULL);
-  g_return_if_fail (GTK_IS_SCALE (scale));
-
-  if (GTK_SCALE_GET_CLASS (scale)->draw_value)
-    GTK_SCALE_GET_CLASS (scale)->draw_value (scale);
+  gtk_widget_style_get (widget,
+                        "slider_length", &slider_length,
+                        NULL);
+  
+  range->min_slider_size = slider_length;
+  
+  (* GTK_WIDGET_CLASS (parent_class)->style_set) (widget, previous);
 }
 
 
-static void
-gtk_scale_draw_background (GtkRange *range)
+/**
+ * _gtk_scale_format_value:
+ * @scale: a #GtkScale
+ * @value: adjustment value
+ * 
+ * Emits "format_value" signal to format the value, if no user
+ * signal handlers, falls back to a default format.
+ * 
+ * Return value: formatted value
+ **/
+gchar*
+_gtk_scale_format_value (GtkScale *scale,
+                         gdouble   value)
 {
-  g_return_if_fail (range != NULL);
-  g_return_if_fail (GTK_IS_SCALE (range));
+  gchar *fmt = NULL;
 
-  gtk_scale_draw_value (GTK_SCALE (range));
+  g_signal_emit (scale,
+                 signals[FORMAT_VALUE],
+                 0,
+                 value,
+                 &fmt);
+
+  if (fmt)
+    return fmt;
+  else
+    return g_strdup_printf ("%0.*f", scale->digits,
+                            value);
 }