]> Pileus Git - ~andy/gtk/blobdiff - gtk/gtkplug.c
Use the correct screen for getting the height. (Fix from Stephen Browne,
[~andy/gtk] / gtk / gtkplug.c
index aff46e861b86cd24cb05d31a06e88eb7c1678233..17345563ed537a2dd6d8a99615f67d88086972ac 100644 (file)
@@ -37,6 +37,7 @@
 
 static void            gtk_plug_class_init            (GtkPlugClass     *klass);
 static void            gtk_plug_init                  (GtkPlug          *plug);
+static void            gtk_plug_finalize              (GObject          *object);
 static void            gtk_plug_realize               (GtkWidget        *widget);
 static void            gtk_plug_unrealize             (GtkWidget        *widget);
 static void            gtk_plug_show                  (GtkWidget        *widget);
@@ -47,23 +48,18 @@ static void            gtk_plug_size_allocate         (GtkWidget        *widget,
                                                       GtkAllocation    *allocation);
 static gboolean        gtk_plug_key_press_event       (GtkWidget        *widget,
                                                       GdkEventKey      *event);
-static void            gtk_plug_forward_key_press     (GtkPlug          *plug,
-                                                      GdkEventKey      *event);
+static gboolean        gtk_plug_focus_event           (GtkWidget        *widget,
+                                                      GdkEventFocus    *event);
 static void            gtk_plug_set_focus             (GtkWindow        *window,
                                                       GtkWidget        *focus);
 static gboolean        gtk_plug_focus                 (GtkWidget        *widget,
                                                       GtkDirectionType  direction);
 static void            gtk_plug_check_resize          (GtkContainer     *container);
-#if 0
-static void            gtk_plug_accel_entries_changed (GtkWindow        *window);
-#endif
+static void            gtk_plug_keys_changed          (GtkWindow        *window);
 static GdkFilterReturn gtk_plug_filter_func           (GdkXEvent        *gdk_xevent,
                                                       GdkEvent         *event,
                                                       gpointer          data);
 
-#if 0
-static void gtk_plug_free_grabbed_keys (GHashTable    *key_table);
-#endif
 static void handle_modality_off        (GtkPlug       *plug);
 static void send_xembed_message        (GtkPlug       *plug,
                                        glong          message,
@@ -87,10 +83,10 @@ enum {
 
 static guint plug_signals[LAST_SIGNAL] = { 0 };
 
-GtkType
+GType
 gtk_plug_get_type ()
 {
-  static GtkType plug_type = 0;
+  static GType plug_type = 0;
 
   if (!plug_type)
     {
@@ -107,7 +103,8 @@ gtk_plug_get_type ()
        (GInstanceInitFunc) gtk_plug_init,
       };
 
-      plug_type = g_type_register_static (GTK_TYPE_WINDOW, "GtkPlug", &plug_info, 0);
+      plug_type = g_type_register_static (GTK_TYPE_WINDOW, "GtkPlug",
+                                         &plug_info, 0);
     }
 
   return plug_type;
@@ -116,16 +113,21 @@ gtk_plug_get_type ()
 static void
 gtk_plug_class_init (GtkPlugClass *class)
 {
+  GObjectClass *gobject_class = (GObjectClass *)class;
   GtkWidgetClass *widget_class = (GtkWidgetClass *)class;
   GtkWindowClass *window_class = (GtkWindowClass *)class;
   GtkContainerClass *container_class = (GtkContainerClass *)class;
 
-  parent_class = gtk_type_class (GTK_TYPE_WINDOW);
-  bin_class = gtk_type_class (GTK_TYPE_BIN);
+  parent_class = g_type_class_peek_parent (class);
+  bin_class = g_type_class_peek (GTK_TYPE_BIN);
 
+  gobject_class->finalize = gtk_plug_finalize;
+  
   widget_class->realize = gtk_plug_realize;
   widget_class->unrealize = gtk_plug_unrealize;
   widget_class->key_press_event = gtk_plug_key_press_event;
+  widget_class->focus_in_event = gtk_plug_focus_event;
+  widget_class->focus_out_event = gtk_plug_focus_event;
 
   widget_class->show = gtk_plug_show;
   widget_class->hide = gtk_plug_hide;
@@ -138,9 +140,7 @@ gtk_plug_class_init (GtkPlugClass *class)
   container_class->check_resize = gtk_plug_check_resize;
 
   window_class->set_focus = gtk_plug_set_focus;
-#if 0  
-  window_class->accel_entries_changed = gtk_plug_accel_entries_changed;
-#endif
+  window_class->keys_changed = gtk_plug_keys_changed;
 
   plug_signals[EMBEDDED] =
     g_signal_new ("embedded",
@@ -149,7 +149,7 @@ gtk_plug_class_init (GtkPlugClass *class)
                  G_STRUCT_OFFSET (GtkPlugClass, embedded),
                  NULL, NULL,
                  _gtk_marshal_VOID__VOID,
-                 GTK_TYPE_NONE, 0);
+                 G_TYPE_NONE, 0);
 }
 
 static void
@@ -195,6 +195,11 @@ gtk_plug_set_is_child (GtkPlug  *plug,
     }
   else
     {
+      if (GTK_WINDOW (plug)->focus_widget)
+       gtk_window_set_focus (GTK_WINDOW (plug), NULL);
+      if (GTK_WINDOW (plug)->default_widget)
+       gtk_window_set_default (GTK_WINDOW (plug), NULL);
+         
       plug->modality_group = gtk_window_group_new ();
       gtk_window_group_add_window (plug->modality_group, GTK_WINDOW (plug));
       
@@ -208,7 +213,7 @@ gtk_plug_set_is_child (GtkPlug  *plug,
 /**
  * _gtk_plug_add_to_socket:
  * @plug: a #GtkPlug
- * @socket: a #GtkSocket
+ * @socket_: a #GtkSocket
  * 
  * Adds a plug to a socket within the same application.
  **/
@@ -217,6 +222,7 @@ _gtk_plug_add_to_socket (GtkPlug   *plug,
                         GtkSocket *socket)
 {
   GtkWidget *widget;
+  gint w, h;
   
   g_return_if_fail (GTK_IS_PLUG (plug));
   g_return_if_fail (GTK_IS_SOCKET (socket));
@@ -232,17 +238,38 @@ _gtk_plug_add_to_socket (GtkPlug   *plug,
   plug->socket_window = GTK_WIDGET (socket)->window;
 
   if (GTK_WIDGET_REALIZED (widget))
-    gdk_window_reparent (widget->window, plug->socket_window, 0, 0);
+    {
+      gdk_drawable_get_size (GDK_DRAWABLE (widget->window), &w, &h);
+      gdk_window_reparent (widget->window, plug->socket_window, -w, -h);
+    }
 
   gtk_widget_set_parent (widget, GTK_WIDGET (socket));
 
-  g_signal_emit_by_name (G_OBJECT (socket), "plug_added", 0);
+  g_signal_emit_by_name (socket, "plug_added", 0);
+}
+
+static void
+send_delete_event (GtkWidget *widget)
+{
+  GdkEvent *event = gdk_event_new (GDK_DELETE);
+  
+  event->any.window = g_object_ref (widget->window);
+  event->any.send_event = FALSE;
+
+  gtk_widget_ref (widget);
+  
+  if (!gtk_widget_event (widget, event))
+    gtk_widget_destroy (widget);
+  
+  gtk_widget_unref (widget);
+
+  gdk_event_free (event);
 }
 
 /**
  * _gtk_plug_remove_from_socket:
  * @plug: a #GtkPlug
- * @socket: a #GtkSocket
+ * @socket_: a #GtkSocket
  * 
  * Removes a plug from a socket within the same application.
  **/
@@ -251,7 +278,6 @@ _gtk_plug_remove_from_socket (GtkPlug   *plug,
                              GtkSocket *socket)
 {
   GtkWidget *widget;
-  GdkEvent event;
   gboolean result;
   gboolean widget_was_visible;
 
@@ -267,14 +293,18 @@ _gtk_plug_remove_from_socket (GtkPlug   *plug,
   widget_was_visible = GTK_WIDGET_VISIBLE (plug);
   
   gdk_window_hide (widget->window);
-  gdk_window_reparent (widget->window, GDK_ROOT_PARENT (), 0, 0);
+  gdk_window_reparent (widget->window,
+                      gtk_widget_get_root_window (widget),
+                      0, 0);
 
   GTK_PRIVATE_SET_FLAG (plug, GTK_IN_REPARENT);
   gtk_widget_unparent (GTK_WIDGET (plug));
   GTK_PRIVATE_UNSET_FLAG (plug, GTK_IN_REPARENT);
   
   socket->plug_widget = NULL;
+  g_object_unref (socket->plug_window);
   socket->plug_window = NULL;
+  
   socket->same_app = FALSE;
 
   plug->same_app = FALSE;
@@ -282,18 +312,12 @@ _gtk_plug_remove_from_socket (GtkPlug   *plug,
 
   gtk_plug_set_is_child (plug, FALSE);
                    
-  g_signal_emit_by_name (G_OBJECT (socket), "plug_removed", &result);
+  g_signal_emit_by_name (socket, "plug_removed", &result);
   if (!result)
     gtk_widget_destroy (GTK_WIDGET (socket));
 
-  event.any.type = GDK_DELETE;
-  event.any.window = g_object_ref (widget->window);
-  event.any.send_event = FALSE;
-  
-  if (!gtk_widget_event (widget, &event))
-    gtk_widget_destroy (widget);
-  
-  g_object_unref (event.any.window);
+  send_delete_event (widget);
+
   g_object_unref (plug);
 
   if (widget_was_visible && GTK_WIDGET_VISIBLE (socket))
@@ -302,21 +326,50 @@ _gtk_plug_remove_from_socket (GtkPlug   *plug,
   g_object_unref (socket);
 }
 
+/**
+ * gtk_plug_construct:
+ * @plug: a #GtkPlug.
+ * @socket_id: the XID of the socket's window.
+ *
+ * Finish the initialization of @plug for a given #GtkSocket identified by
+ * @socket_id. This function will generally only be used by classes deriving from #GtkPlug.
+ **/
 void
 gtk_plug_construct (GtkPlug         *plug,
                    GdkNativeWindow  socket_id)
+{
+  gtk_plug_construct_for_display (plug, gdk_display_get_default (), socket_id);
+}
+
+/**
+ * gtk_plug_construct_for_display:
+ * @plug: a #GtkPlug.
+ * @display: the #GdkDisplay associated with @socket_id's 
+ *          #GtkSocket.
+ * @socket_id: the XID of the socket's window.
+ *
+ * Finish the initialization of @plug for a given #GtkSocket identified by
+ * @socket_id which is currently displayed on @display.
+ * This function will generally only be used by classes deriving from #GtkPlug.
+ *
+ * Since: 2.2
+ **/
+void
+gtk_plug_construct_for_display (GtkPlug         *plug,
+                               GdkDisplay      *display,
+                               GdkNativeWindow  socket_id)
 {
   if (socket_id)
     {
       gpointer user_data = NULL;
 
-      plug->socket_window = gdk_window_lookup (socket_id);
-
+      plug->socket_window = gdk_window_lookup_for_display (display, socket_id);
+      
       if (plug->socket_window)
        gdk_window_get_user_data (plug->socket_window, &user_data);
       else
-       plug->socket_window = gdk_window_foreign_new (socket_id);
-
+       plug->socket_window = gdk_window_foreign_new_for_display (display, socket_id);
+         
       if (user_data)
        {
          if (GTK_IS_SOCKET (user_data))
@@ -329,17 +382,45 @@ gtk_plug_construct (GtkPlug         *plug,
        }
 
       if (plug->socket_window)
-       g_signal_emit (G_OBJECT (plug), plug_signals[EMBEDDED], 0);
+       g_signal_emit (plug, plug_signals[EMBEDDED], 0);
     }
 }
 
+/**
+ * gtk_plug_new:
+ * @socket_id:  the window ID of the socket, or 0.
+ * 
+ * Creates a new plug widget inside the #GtkSocket identified
+ * by @socket_id. If @socket_id is 0, the plug is left "unplugged" and
+ * can later be plugged into a #GtkSocket by  gtk_socket_add_id().
+ * 
+ * Return value: the new #GtkPlug widget.
+ **/
 GtkWidget*
 gtk_plug_new (GdkNativeWindow socket_id)
+{
+  return gtk_plug_new_for_display (gdk_display_get_default (), socket_id);
+}
+
+/**
+ * gtk_plug_new_for_display:
+ * @display : the #GdkDisplay on which @socket_id is displayed
+ * @socket_id: the XID of the socket's window.
+ * 
+ * Create a new plug widget inside the #GtkSocket identified by socket_id.
+ *
+ * Return value: the new #GtkPlug widget.
+ *
+ * Since: 2.2
+ */
+GtkWidget*
+gtk_plug_new_for_display (GdkDisplay     *display,
+                         GdkNativeWindow  socket_id)
 {
   GtkPlug *plug;
 
-  plug = GTK_PLUG (gtk_type_new (GTK_TYPE_PLUG));
-  gtk_plug_construct (plug, socket_id);
+  plug = g_object_new (GTK_TYPE_PLUG, NULL);
+  gtk_plug_construct_for_display (plug, display, socket_id);
   return GTK_WIDGET (plug);
 }
 
@@ -364,6 +445,20 @@ gtk_plug_get_id (GtkPlug *plug)
   return GDK_WINDOW_XWINDOW (GTK_WIDGET (plug)->window);
 }
 
+static void
+gtk_plug_finalize (GObject *object)
+{
+  GtkPlug *plug = GTK_PLUG (object);
+
+  if (plug->grabbed_keys)
+    {
+      g_hash_table_destroy (plug->grabbed_keys);
+      plug->grabbed_keys = NULL;
+    }
+  
+  G_OBJECT_CLASS (parent_class)->finalize (object);
+}
+
 static void
 gtk_plug_unrealize (GtkWidget *widget)
 {
@@ -376,7 +471,7 @@ gtk_plug_unrealize (GtkWidget *widget)
   if (plug->socket_window != NULL)
     {
       gdk_window_set_user_data (plug->socket_window, NULL);
-      gdk_window_unref (plug->socket_window);
+      g_object_unref (plug->socket_window);
       plug->socket_window = NULL;
     }
 
@@ -425,7 +520,6 @@ gtk_plug_realize (GtkWidget *widget)
                            GDK_KEY_RELEASE_MASK |
                            GDK_ENTER_NOTIFY_MASK |
                            GDK_LEAVE_NOTIFY_MASK |
-                           GDK_FOCUS_CHANGE_MASK |
                            GDK_STRUCTURE_MASK);
 
   attributes_mask = GDK_WA_VISUAL | GDK_WA_COLORMAP;
@@ -437,16 +531,22 @@ gtk_plug_realize (GtkWidget *widget)
       attributes.window_type = GDK_WINDOW_TOPLEVEL;
 
       gdk_error_trap_push ();
-      widget->window = gdk_window_new (plug->socket_window, 
-                                      &attributes, attributes_mask);
-      gdk_flush ();
+      if (plug->socket_window)
+       widget->window = gdk_window_new (plug->socket_window, 
+                                        &attributes, attributes_mask);
+      else /* If it's a passive plug, we use the root window */
+       widget->window = gdk_window_new (gtk_widget_get_root_window (widget),
+                                        &attributes, attributes_mask);
+
+      gdk_display_sync (gtk_widget_get_display (widget));
       if (gdk_error_trap_pop ()) /* Uh-oh */
        {
          gdk_error_trap_push ();
          gdk_window_destroy (widget->window);
          gdk_flush ();
          gdk_error_trap_pop ();
-         widget->window = gdk_window_new (NULL, &attributes, attributes_mask);
+         widget->window = gdk_window_new (gtk_widget_get_root_window (widget),
+                                          &attributes, attributes_mask);
        }
       
       gdk_window_add_filter (widget->window, gtk_plug_filter_func, widget);
@@ -457,7 +557,8 @@ gtk_plug_realize (GtkWidget *widget)
       xembed_set_info (widget->window, 0);
     }
   else
-    widget->window = gdk_window_new (gtk_widget_get_parent_window (widget), &attributes, attributes_mask);      
+    widget->window = gdk_window_new (gtk_widget_get_parent_window (widget), 
+                                    &attributes, attributes_mask);      
   
   gdk_window_set_user_data (widget->window, window);
 
@@ -568,46 +669,20 @@ gtk_plug_key_press_event (GtkWidget   *widget,
                          GdkEventKey *event)
 {
   if (GTK_WIDGET_TOPLEVEL (widget))
-    {
-      if (!GTK_WINDOW (widget)->has_focus)
-       {
-         gtk_plug_forward_key_press (GTK_PLUG (widget), event);
-         return TRUE;
-       }
-      else
-       return GTK_WIDGET_CLASS (parent_class)->key_press_event (widget, event);
-    }
+    return GTK_WIDGET_CLASS (parent_class)->key_press_event (widget, event);
   else
     return FALSE;
 }
 
-static void
-gtk_plug_forward_key_press (GtkPlug *plug, GdkEventKey *event)
+static gboolean
+gtk_plug_focus_event (GtkWidget      *widget,
+                     GdkEventFocus  *event)
 {
-  XEvent xevent;
-  
-  xevent.xkey.type = KeyPress;
-  xevent.xkey.display = GDK_WINDOW_XDISPLAY (GTK_WIDGET(plug)->window);
-  xevent.xkey.window = GDK_WINDOW_XWINDOW (plug->socket_window);
-  xevent.xkey.root = GDK_ROOT_WINDOW (); /* FIXME */
-  xevent.xkey.time = event->time;
-  /* FIXME, the following might cause big problems for
-   * non-GTK apps */
-  xevent.xkey.x = 0;
-  xevent.xkey.y = 0;
-  xevent.xkey.x_root = 0;
-  xevent.xkey.y_root = 0;
-  xevent.xkey.state = event->state;
-  xevent.xkey.keycode =  XKeysymToKeycode(GDK_DISPLAY(), 
-                                         event->keyval);
-  xevent.xkey.same_screen = TRUE; /* FIXME ? */
-
-  gdk_error_trap_push ();
-  XSendEvent (GDK_DISPLAY (),
-             GDK_WINDOW_XWINDOW (plug->socket_window),
-             False, NoEventMask, &xevent);
-  gdk_flush ();
-  gdk_error_trap_pop ();
+  /* We eat focus-in events and focus-out events, since they
+   * can be generated by something like a keyboard grab on
+   * a child of the plug.
+   */
+  return FALSE;
 }
 
 static void
@@ -621,32 +696,13 @@ gtk_plug_set_focus (GtkWindow *window,
   /* Ask for focus from embedder
    */
 
-  if (focus && !window->has_focus)
+  if (focus && !window->has_toplevel_focus)
     {
-#if 0      
-      XEvent xevent;
-
-      xevent.xfocus.type = FocusIn;
-      xevent.xfocus.display = GDK_WINDOW_XDISPLAY (GTK_WIDGET(plug)->window);
-      xevent.xfocus.window = GDK_WINDOW_XWINDOW (plug->socket_window);
-      xevent.xfocus.mode = EMBEDDED_APP_WANTS_FOCUS;
-      xevent.xfocus.detail = FALSE; /* Don't force */
-
-      gdk_error_trap_push ();
-      XSendEvent (GDK_DISPLAY (),
-                 GDK_WINDOW_XWINDOW (plug->socket_window),
-                 False, NoEventMask, &xevent);
-      gdk_flush ();
-      gdk_error_trap_pop ();
-#endif
-
       send_xembed_message (plug, XEMBED_REQUEST_FOCUS, 0, 0, 0,
                           gtk_get_current_event_time ());
     }
 }
 
-#if 0
-
 typedef struct
 {
   guint                         accelerator_key;
@@ -677,7 +733,7 @@ grabbed_key_equal (gconstpointer a, gconstpointer b)
 }
 
 static void
-add_grabbed_keys (gpointer key, gpointer val, gpointer data)
+add_grabbed_key (gpointer key, gpointer val, gpointer data)
 {
   GrabbedKey *grabbed_key = key;
   GtkPlug *plug = data;
@@ -685,14 +741,25 @@ add_grabbed_keys (gpointer key, gpointer val, gpointer data)
   if (!plug->grabbed_keys ||
       !g_hash_table_lookup (plug->grabbed_keys, grabbed_key))
     {
-      send_xembed_message (plug, XEMBED_GRAB_KEY, 0, 
+      send_xembed_message (plug, XEMBED_GTK_GRAB_KEY, 0, 
                           grabbed_key->accelerator_key, grabbed_key->accelerator_mods,
                           gtk_get_current_event_time ());
     }
 }
 
 static void
-remove_grabbed_keys (gpointer key, gpointer val, gpointer data)
+add_grabbed_key_always (gpointer key, gpointer val, gpointer data)
+{
+  GrabbedKey *grabbed_key = key;
+  GtkPlug *plug = data;
+
+  send_xembed_message (plug, XEMBED_GTK_GRAB_KEY, 0, 
+                      grabbed_key->accelerator_key, grabbed_key->accelerator_mods,
+                      gtk_get_current_event_time ());
+}
+
+static void
+remove_grabbed_key (gpointer key, gpointer val, gpointer data)
 {
   GrabbedKey *grabbed_key = key;
   GtkPlug *plug = data;
@@ -700,74 +767,50 @@ remove_grabbed_keys (gpointer key, gpointer val, gpointer data)
   if (!plug->grabbed_keys ||
       !g_hash_table_lookup (plug->grabbed_keys, grabbed_key))
     {
-      send_xembed_message (plug, XEMBED_UNGRAB_KEY, 0, 
+      send_xembed_message (plug, XEMBED_GTK_UNGRAB_KEY, 0, 
                           grabbed_key->accelerator_key, grabbed_key->accelerator_mods,
                           gtk_get_current_event_time ());
     }
 }
 
 static void
-gtk_plug_free_grabbed_keys (GHashTable *key_table)
+keys_foreach (GtkWindow      *window,
+             guint           keyval,
+             GdkModifierType modifiers,
+             gboolean        is_mnemonic,
+             gpointer        data)
 {
-  g_hash_table_foreach (key_table, (GHFunc)g_free, NULL);
-  g_hash_table_destroy (key_table);
+  GHashTable *new_grabbed_keys = data;
+  GrabbedKey *key = g_new (GrabbedKey, 1);
+
+  key->accelerator_key = keyval;
+  key->accelerator_mods = modifiers;
+  
+  g_hash_table_replace (new_grabbed_keys, key, key);
 }
 
 static void
-gtk_plug_accel_entries_changed (GtkWindow *window)
+gtk_plug_keys_changed (GtkWindow *window)
 {
   GHashTable *new_grabbed_keys, *old_grabbed_keys;
-  GSList *accel_groups, *tmp_list;
   GtkPlug *plug = GTK_PLUG (window);
 
-  new_grabbed_keys = g_hash_table_new (grabbed_key_hash, grabbed_key_equal);
-
-  accel_groups = gtk_accel_groups_from_object (G_OBJECT (window));
-  
-  tmp_list = accel_groups;
-
-  while (tmp_list)
-    {
-      GtkAccelGroup *accel_group = tmp_list->data;
-      gint i, n_entries;
-      GtkAccelEntry *entries;
-
-      gtk_accel_group_get_entries (accel_group, &entries, &n_entries);
-
-      for (i = 0; i < n_entries; i++)
-       {
-         GdkKeymapKey *keys;
-         gint n_keys;
-         
-         if (gdk_keymap_get_entries_for_keyval (NULL, entries[i].accelerator_key, &keys, &n_keys))
-           {
-             GrabbedKey *key = g_new (GrabbedKey, 1);
-             
-             key->accelerator_key = keys[0].keycode;
-             key->accelerator_mods = entries[i].accelerator_mods;
-             
-             g_hash_table_insert (new_grabbed_keys, key, key);
-
-             g_free (keys);
-           }
-       }
-      
-      tmp_list = tmp_list->next;
-    }
+  new_grabbed_keys = g_hash_table_new_full (grabbed_key_hash, grabbed_key_equal, (GDestroyNotify)g_free, NULL);
+  _gtk_window_keys_foreach (window, keys_foreach, new_grabbed_keys);
 
-  g_hash_table_foreach (new_grabbed_keys, add_grabbed_keys, plug);
+  if (plug->socket_window)
+    g_hash_table_foreach (new_grabbed_keys, add_grabbed_key, plug);
 
   old_grabbed_keys = plug->grabbed_keys;
   plug->grabbed_keys = new_grabbed_keys;
 
   if (old_grabbed_keys)
     {
-      g_hash_table_foreach (old_grabbed_keys, remove_grabbed_keys, plug);
-      gtk_plug_free_grabbed_keys (old_grabbed_keys);
+      if (plug->socket_window)
+       g_hash_table_foreach (old_grabbed_keys, remove_grabbed_key, plug);
+      g_hash_table_destroy (old_grabbed_keys);
     }
-
 }
-#endif
 
 static gboolean
 gtk_plug_focus (GtkWidget        *widget,
@@ -819,19 +862,6 @@ gtk_plug_focus (GtkWidget        *widget,
              
              send_xembed_message (plug, message, 0, 0, 0,
                                   gtk_get_current_event_time ());
-             
-#if 0        
-             gtk_window_set_focus (GTK_WINDOW (widget), NULL);
-
-             gdk_error_trap_push ();
-             XSetInputFocus (GDK_DISPLAY (),
-                             GDK_WINDOW_XWINDOW (plug->socket_window),
-                             RevertToParent, event->time);
-             gdk_flush ();
-             gdk_error_trap_pop ();
-
-             gtk_plug_forward_key_press (plug, event);
-#endif       
            }
        }
 
@@ -841,7 +871,7 @@ gtk_plug_focus (GtkWidget        *widget,
     {
       /* Try to focus the first widget in the window */
       
-      if (gtk_widget_child_focus (bin->child, direction))
+      if (bin->child && gtk_widget_child_focus (bin->child, direction))
         return TRUE;
     }
 
@@ -867,11 +897,15 @@ send_xembed_message (GtkPlug *plug,
 {
   if (plug->socket_window)
     {
+      GdkDisplay *display = gdk_drawable_get_display (plug->socket_window);
       XEvent xevent;
 
+      GTK_NOTE(PLUGSOCKET,
+              g_message ("GtkPlug: Sending XEMBED message of type %ld", message));
+
       xevent.xclient.window = GDK_WINDOW_XWINDOW (plug->socket_window);
       xevent.xclient.type = ClientMessage;
-      xevent.xclient.message_type = gdk_x11_get_xatom_by_name ("_XEMBED");
+      xevent.xclient.message_type = gdk_x11_get_xatom_by_name_for_display (display, "_XEMBED");
       xevent.xclient.format = 32;
       xevent.xclient.data.l[0] = time;
       xevent.xclient.data.l[1] = message;
@@ -880,10 +914,10 @@ send_xembed_message (GtkPlug *plug,
       xevent.xclient.data.l[4] = data2;
 
       gdk_error_trap_push ();
-      XSendEvent (GDK_DISPLAY (),
+      XSendEvent (GDK_WINDOW_XDISPLAY(plug->socket_window),
                  GDK_WINDOW_XWINDOW (plug->socket_window),
                  False, NoEventMask, &xevent);
-      gdk_flush ();
+      gdk_display_sync (display);
       gdk_error_trap_pop ();
     }
 }
@@ -916,6 +950,8 @@ handle_modality_on (GtkPlug *plug)
   if (!plug->modality_window)
     {
       plug->modality_window = gtk_window_new (GTK_WINDOW_POPUP);
+      gtk_window_set_screen (GTK_WINDOW (plug->modality_window),
+                            gtk_widget_get_screen (GTK_WIDGET (plug)));
       gtk_widget_realize (plug->modality_window);
       gtk_window_group_add_window (plug->modality_group, GTK_WINDOW (plug->modality_window));
       gtk_grab_add (plug->modality_window);
@@ -933,19 +969,19 @@ handle_modality_off (GtkPlug *plug)
 }
 
 static void
-xembed_set_info (GdkWindow     *gdk_window,
+xembed_set_info (GdkWindow     *window,
                 unsigned long  flags)
 {
-  Display *display = GDK_WINDOW_XDISPLAY (gdk_window);
-  Window window = GDK_WINDOW_XWINDOW (gdk_window);
+  GdkDisplay *display = gdk_drawable_get_display (window);
   unsigned long buffer[2];
-  
-  Atom xembed_info_atom = gdk_x11_get_xatom_by_name ("_XEMBED_INFO");
+
+  Atom xembed_info_atom = gdk_x11_get_xatom_by_name_for_display (display, "_XEMBED_INFO");
 
   buffer[1] = 0;               /* Protocol version */
   buffer[1] = flags;
 
-  XChangeProperty (display, window,
+  XChangeProperty (GDK_DISPLAY_XDISPLAY (display),
+                  GDK_WINDOW_XWINDOW (window),
                   xembed_info_atom, xembed_info_atom, 32,
                   PropModeReplace,
                   (unsigned char *)buffer, 2);
@@ -959,20 +995,20 @@ handle_xembed_message (GtkPlug   *plug,
                       glong      data2,
                       guint32    time)
 {
+  GtkWindow *window = GTK_WINDOW (plug);
+  
   GTK_NOTE (PLUGSOCKET,
-           g_message ("Message of type %ld received", message));
+           g_message ("GtkPlug: Message of type %ld received", message));
   
   switch (message)
     {
     case XEMBED_EMBEDDED_NOTIFY:
       break;
     case XEMBED_WINDOW_ACTIVATE:
-      GTK_NOTE(PLUGSOCKET,
-              g_message ("GtkPlug: ACTIVATE received"));
+      _gtk_window_set_is_active (window, TRUE);
       break;
     case XEMBED_WINDOW_DEACTIVATE:
-      GTK_NOTE(PLUGSOCKET,
-              g_message ("GtkPlug: DEACTIVATE received"));
+      _gtk_window_set_is_active (window, FALSE);
       break;
       
     case XEMBED_MODALITY_ON:
@@ -983,6 +1019,7 @@ handle_xembed_message (GtkPlug   *plug,
       break;
 
     case XEMBED_FOCUS_IN:
+      _gtk_window_set_has_toplevel_focus (window, TRUE);
       switch (detail)
        {
        case XEMBED_FOCUS_FIRST:
@@ -992,28 +1029,21 @@ handle_xembed_message (GtkPlug   *plug,
          focus_first_last (plug, GTK_DIR_TAB_BACKWARD);
          break;
        case XEMBED_FOCUS_CURRENT:
-         /* fall through */;
+         break;
        }
-      
-    case XEMBED_FOCUS_OUT:
-      {
-       GdkEvent event;
-
-       event.focus_change.type = GDK_FOCUS_CHANGE;
-       event.focus_change.window = GTK_WIDGET (plug)->window;
-       event.focus_change.send_event = TRUE;
-       event.focus_change.in = (message == XEMBED_FOCUS_IN);
-
-       gtk_widget_event (GTK_WIDGET (plug), &event);
+      break;
 
-       break;
-      }
+    case XEMBED_FOCUS_OUT:
+      _gtk_window_set_has_toplevel_focus (window, FALSE);
+      break;
       
+    case XEMBED_GRAB_KEY:
+    case XEMBED_UNGRAB_KEY:
+    case XEMBED_GTK_GRAB_KEY:
+    case XEMBED_GTK_UNGRAB_KEY:
     case XEMBED_REQUEST_FOCUS:
     case XEMBED_FOCUS_NEXT:
     case XEMBED_FOCUS_PREV:
-    case XEMBED_GRAB_KEY:
-    case XEMBED_UNGRAB_KEY:
       g_warning ("GtkPlug: Invalid _XEMBED message of type %ld received", message);
       break;
       
@@ -1027,6 +1057,8 @@ handle_xembed_message (GtkPlug   *plug,
 static GdkFilterReturn
 gtk_plug_filter_func (GdkXEvent *gdk_xevent, GdkEvent *event, gpointer data)
 {
+  GdkScreen *screen = gdk_drawable_get_screen (event->any.window);
+  GdkDisplay *display = gdk_screen_get_display (screen);
   GtkPlug *plug = GTK_PLUG (data);
   XEvent *xevent = (XEvent *)gdk_xevent;
 
@@ -1037,7 +1069,7 @@ gtk_plug_filter_func (GdkXEvent *gdk_xevent, GdkEvent *event, gpointer data)
   switch (xevent->type)
     {
     case ClientMessage:
-      if (xevent->xclient.message_type == gdk_x11_get_xatom_by_name ("_XEMBED"))
+      if (xevent->xclient.message_type == gdk_x11_get_xatom_by_name_for_display (display, "_XEMBED"))
        {
          handle_xembed_message (plug,
                                 xevent->xclient.data.l[1],
@@ -1049,7 +1081,7 @@ gtk_plug_filter_func (GdkXEvent *gdk_xevent, GdkEvent *event, gpointer data)
 
          return GDK_FILTER_REMOVE;
        }
-      else if (xevent->xclient.message_type == gdk_x11_get_xatom_by_name ("WM_DELETE_WINDOW"))
+      else if (xevent->xclient.message_type == gdk_x11_get_xatom_by_name_for_display (display, "WM_DELETE_WINDOW"))
        {
          /* We filter these out because we take being reparented back to the
           * root window as the reliable end of the embedding protocol
@@ -1081,7 +1113,7 @@ gtk_plug_filter_func (GdkXEvent *gdk_xevent, GdkEvent *event, gpointer data)
                GtkWidget *widget = GTK_WIDGET (plug);
 
                gdk_window_set_user_data (plug->socket_window, NULL);
-               gdk_window_unref (plug->socket_window);
+               g_object_unref (plug->socket_window);
                plug->socket_window = NULL;
 
                /* Emit a delete window, as if the user attempted
@@ -1093,29 +1125,18 @@ gtk_plug_filter_func (GdkXEvent *gdk_xevent, GdkEvent *event, gpointer data)
                 * be invisible to the app.
                 */
 
-               if (xre->parent == GDK_ROOT_WINDOW())
-                 {
-                   GdkEvent event;
-                   
-                   event.any.type = GDK_DELETE;
-                   event.any.window = g_object_ref (widget->window);
-                   event.any.send_event = FALSE;
-                   
-                   if (!gtk_widget_event (widget, &event))
-                     gtk_widget_destroy (widget);
-                   
-                   g_object_unref (event.any.window);
-                 }
+               if (xre->parent == GDK_WINDOW_XWINDOW (gdk_screen_get_root_window (screen)))
+                 send_delete_event (widget);
              }
            else
-             break;
+             goto done;
          }
 
-       if (xre->parent != GDK_ROOT_WINDOW ())
+       if (xre->parent != GDK_WINDOW_XWINDOW (gdk_screen_get_root_window (screen)))
          {
            /* Start of embedding protocol */
 
-           plug->socket_window = gdk_window_lookup (xre->parent);
+           plug->socket_window = gdk_window_lookup_for_display (display, xre->parent);
            if (plug->socket_window)
              {
                gpointer user_data = NULL;
@@ -1132,17 +1153,19 @@ gtk_plug_filter_func (GdkXEvent *gdk_xevent, GdkEvent *event, gpointer data)
              }
            else
              {
-               plug->socket_window = gdk_window_foreign_new (xre->parent);
+               plug->socket_window = gdk_window_foreign_new_for_display (display, xre->parent);
                if (!plug->socket_window) /* Already gone */
                  break;
              }
 
-           /* FIXME: Add grabbed keys here */
+           if (plug->grabbed_keys)
+             g_hash_table_foreach (plug->grabbed_keys, add_grabbed_key_always, plug);
 
            if (!was_embedded)
-             g_signal_emit (G_OBJECT (plug), plug_signals[EMBEDDED], 0);
+             g_signal_emit (plug, plug_signals[EMBEDDED], 0);
          }
-       
+
+      done:
        g_object_unref (plug);
        
        break;