]> Pileus Git - ~andy/gtk/blobdiff - gtk/gtkpaned.c
Implement missing functions.
[~andy/gtk] / gtk / gtkpaned.c
index 3184d8ee19e79b7cb6a578a9c70c0469341da1ac..bd48803f4b821b3a6e384c065530ddf5d3bb1cf9 100644 (file)
  * GTK+ at ftp://ftp.gtk.org/pub/gtk/. 
  */
 
-#include <config.h>
-#include "gtkalias.h"
+#include "config.h"
 #include "gtkintl.h"
 #include "gtkpaned.h"
 #include "gtkbindings.h"
-#include "gtksignal.h"
 #include "gdk/gdkkeysyms.h"
 #include "gtkwindow.h"
 #include "gtkmain.h"
 #include "gtkmarshalers.h"
+#include "gtkprivate.h"
+#include "gtkalias.h"
 
 enum {
   PROP_0,
@@ -59,8 +59,6 @@ enum {
   LAST_SIGNAL
 };
 
-static void     gtk_paned_class_init            (GtkPanedClass    *klass);
-static void     gtk_paned_init                  (GtkPaned         *paned);
 static void     gtk_paned_set_property          (GObject          *object,
                                                 guint             prop_id,
                                                 const GValue     *value,
@@ -84,6 +82,8 @@ static void     gtk_paned_realize               (GtkWidget        *widget);
 static void     gtk_paned_unrealize             (GtkWidget        *widget);
 static void     gtk_paned_map                   (GtkWidget        *widget);
 static void     gtk_paned_unmap                 (GtkWidget        *widget);
+static void     gtk_paned_state_changed         (GtkWidget        *widget,
+                                                 GtkStateType      previous_state);
 static gboolean gtk_paned_expose                (GtkWidget        *widget,
                                                 GdkEventExpose   *event);
 static gboolean gtk_paned_enter                 (GtkWidget        *widget,
@@ -98,6 +98,8 @@ static gboolean gtk_paned_motion                (GtkWidget        *widget,
                                                 GdkEventMotion   *event);
 static gboolean gtk_paned_focus                 (GtkWidget        *widget,
                                                 GtkDirectionType  direction);
+static gboolean gtk_paned_grab_broken           (GtkWidget          *widget,
+                                                GdkEventGrabBroken *event);
 static void     gtk_paned_add                   (GtkContainer     *container,
                                                 GtkWidget        *widget);
 static void     gtk_paned_remove                (GtkContainer     *container,
@@ -126,43 +128,18 @@ static gboolean gtk_paned_accept_position       (GtkPaned         *paned);
 static gboolean gtk_paned_cancel_position       (GtkPaned         *paned);
 static gboolean gtk_paned_toggle_handle_focus   (GtkPaned         *paned);
 
-static GType    gtk_paned_child_type             (GtkContainer     *container);
-
-static GtkContainerClass *parent_class = NULL;
+static GType    gtk_paned_child_type            (GtkContainer     *container);
+static void     gtk_paned_grab_notify           (GtkWidget        *widget,
+                                                gboolean          was_grabbed);
 
 struct _GtkPanedPrivate
 {
   GtkWidget *saved_focus;
-  GtkPaned *first_paned;
+  GtkPaned  *first_paned;
+  guint32    grab_time;
 };
 
-GType
-gtk_paned_get_type (void)
-{
-  static GType paned_type = 0;
-  
-  if (!paned_type)
-    {
-      static const GTypeInfo paned_info =
-      {
-       sizeof (GtkPanedClass),
-       NULL,           /* base_init */
-       NULL,           /* base_finalize */
-       (GClassInitFunc) gtk_paned_class_init,
-       NULL,           /* class_finalize */
-       NULL,           /* class_data */
-       sizeof (GtkPaned),
-       0,              /* n_preallocs */
-       (GInstanceInitFunc) gtk_paned_init,
-       NULL,           /* value_table */
-      };
-
-      paned_type = g_type_register_static (GTK_TYPE_CONTAINER, "GtkPaned",
-                                          &paned_info, G_TYPE_FLAG_ABSTRACT);
-    }
-  
-  return paned_type;
-}
+G_DEFINE_ABSTRACT_TYPE (GtkPaned, gtk_paned, GTK_TYPE_CONTAINER)
 
 static guint signals[LAST_SIGNAL] = { 0 };
 
@@ -201,8 +178,6 @@ gtk_paned_class_init (GtkPanedClass *class)
   container_class = (GtkContainerClass *) class;
   paned_class = (GtkPanedClass *) class;
 
-  parent_class = g_type_class_peek_parent (class);
-
   object_class->set_property = gtk_paned_set_property;
   object_class->get_property = gtk_paned_get_property;
   object_class->finalize = gtk_paned_finalize;
@@ -218,6 +193,9 @@ gtk_paned_class_init (GtkPanedClass *class)
   widget_class->button_press_event = gtk_paned_button_press;
   widget_class->button_release_event = gtk_paned_button_release;
   widget_class->motion_notify_event = gtk_paned_motion;
+  widget_class->grab_broken_event = gtk_paned_grab_broken;
+  widget_class->grab_notify = gtk_paned_grab_notify;
+  widget_class->state_changed = gtk_paned_state_changed;
   
   container_class->add = gtk_paned_add;
   container_class->remove = gtk_paned_remove;
@@ -242,23 +220,23 @@ gtk_paned_class_init (GtkPanedClass *class)
                                                     0,
                                                     G_MAXINT,
                                                     0,
-                                                    G_PARAM_READABLE | G_PARAM_WRITABLE));
+                                                    GTK_PARAM_READWRITE));
   g_object_class_install_property (object_class,
                                   PROP_POSITION_SET,
-                                  g_param_spec_boolean ("position_set",
+                                  g_param_spec_boolean ("position-set",
                                                         P_("Position Set"),
                                                         P_("TRUE if the Position property should be used"),
                                                         FALSE,
-                                                        G_PARAM_READABLE | G_PARAM_WRITABLE));
+                                                        GTK_PARAM_READWRITE));
                                   
   gtk_widget_class_install_style_property (widget_class,
-                                          g_param_spec_int ("handle_size",
+                                          g_param_spec_int ("handle-size",
                                                             P_("Handle Size"),
                                                             P_("Width of handle"),
                                                             0,
                                                             G_MAXINT,
                                                             5,
-                                                            G_PARAM_READABLE));
+                                                            GTK_PARAM_READABLE));
   /**
    * GtkPaned:min-position:
    *
@@ -268,14 +246,14 @@ gtk_paned_class_init (GtkPanedClass *class)
    * Since: 2.4
    */
   g_object_class_install_property (object_class,
-                                  PROP_MAX_POSITION,
-                                  g_param_spec_int ("min_position",
+                                  PROP_MIN_POSITION,
+                                  g_param_spec_int ("min-position",
                                                     P_("Minimal Position"),
                                                     P_("Smallest possible value for the \"position\" property"),
                                                     0,
                                                     G_MAXINT,
                                                     0,
-                                                    G_PARAM_READABLE));
+                                                    GTK_PARAM_READABLE));
 
   /**
    * GtkPaned:max-position:
@@ -286,14 +264,14 @@ gtk_paned_class_init (GtkPanedClass *class)
    * Since: 2.4
    */
   g_object_class_install_property (object_class,
-                                  PROP_MIN_POSITION,
-                                  g_param_spec_int ("max_position",
+                                  PROP_MAX_POSITION,
+                                  g_param_spec_int ("max-position",
                                                     P_("Maximal Position"),
                                                     P_("Largest possible value for the \"position\" property"),
                                                     0,
                                                     G_MAXINT,
                                                     G_MAXINT,
-                                                    G_PARAM_READABLE));
+                                                    GTK_PARAM_READABLE));
 
 /**
  * GtkPaned:resize:
@@ -309,7 +287,7 @@ gtk_paned_class_init (GtkPanedClass *class)
                                                                    P_("Resize"),
                                                                    P_("If TRUE, the child expands and shrinks along with the paned widget"),
                                                                    TRUE,
-                                                                   G_PARAM_READWRITE));
+                                                                   GTK_PARAM_READWRITE));
 
 /**
  * GtkPaned:shrink:
@@ -325,10 +303,23 @@ gtk_paned_class_init (GtkPanedClass *class)
                                                                    P_("Shrink"),
                                                                    P_("If TRUE, the child can be made smaller than its requisition"),
                                                                    TRUE,
-                                                                   G_PARAM_READWRITE));
+                                                                   GTK_PARAM_READWRITE));
 
+  /**
+   * GtkPaned::cycle-child-focus:
+   * @widget: the object that received the signal
+   * @reversed: whether cycling backward or forward
+   *
+   * The ::cycle-child-focus signal is a 
+   * <link linkend="keybinding-signals">keybinding signal</link>
+   * which gets emitted to cycle the focus between the children of the paned.
+   *
+   * The default binding is f6.
+   *
+   * Since: 2.0
+   */
   signals [CYCLE_CHILD_FOCUS] =
-    g_signal_new ("cycle_child_focus",
+    g_signal_new (I_("cycle_child_focus"),
                  G_TYPE_FROM_CLASS (object_class),
                  G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
                  G_STRUCT_OFFSET (GtkPanedClass, cycle_child_focus),
@@ -337,8 +328,21 @@ gtk_paned_class_init (GtkPanedClass *class)
                  G_TYPE_BOOLEAN, 1,
                  G_TYPE_BOOLEAN);
 
+  /**
+   * GtkPaned::toggle-handle-focus:
+   * @widget: the object that received the signal
+   *
+   * The ::toggle-handle-focus is a 
+   * <link linkend="keybinding-signals">keybinding signal</link>
+   * which gets emitted to accept the current position of the handle and then 
+   * move focus to the next widget in the focus chain.
+   *
+   * The default binding is Tab.
+   *
+   * Since: 2.0
+   */
   signals [TOGGLE_HANDLE_FOCUS] =
-    g_signal_new ("toggle_handle_focus",
+    g_signal_new (I_("toggle_handle_focus"),
                  G_TYPE_FROM_CLASS (object_class),
                  G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
                  G_STRUCT_OFFSET (GtkPanedClass, toggle_handle_focus),
@@ -346,8 +350,20 @@ gtk_paned_class_init (GtkPanedClass *class)
                  _gtk_marshal_BOOLEAN__VOID,
                  G_TYPE_BOOLEAN, 0);
 
+  /**
+   * GtkPaned::move-handle:
+   * @widget: the object that received the signal
+   * @scroll_type: a #GtkScrollType
+   *
+   * The ::move-handle signal is a 
+   * <link linkend="keybinding-signals">keybinding signal</link>
+   * which gets emitted to move the handle when the user is using key bindings 
+   * to move it.
+   *
+   * Since: 2.0
+   */
   signals[MOVE_HANDLE] =
-    g_signal_new ("move_handle",
+    g_signal_new (I_("move_handle"),
                  G_TYPE_FROM_CLASS (object_class),
                   G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
                   G_STRUCT_OFFSET (GtkPanedClass, move_handle),
@@ -356,8 +372,22 @@ gtk_paned_class_init (GtkPanedClass *class)
                   G_TYPE_BOOLEAN, 1,
                   GTK_TYPE_SCROLL_TYPE);
 
+  /**
+   * GtkPaned::cycle-handle-focus:
+   * @widget: the object that received the signal
+   * @reversed: whether cycling backward or forward
+   *
+   * The ::cycle-handle-focus signal is a 
+   * <link linkend="keybinding-signals">keybinding signal</link>
+   * which gets emitted to cycle whether the paned should grab focus to allow
+   * the user to change position of the handle by using key bindings.
+   *
+   * The default binding for this signal is f8.
+   *
+   * Since: 2.0
+   */
   signals [CYCLE_HANDLE_FOCUS] =
-    g_signal_new ("cycle_handle_focus",
+    g_signal_new (I_("cycle_handle_focus"),
                  G_TYPE_FROM_CLASS (object_class),
                  G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
                  G_STRUCT_OFFSET (GtkPanedClass, cycle_handle_focus),
@@ -366,8 +396,21 @@ gtk_paned_class_init (GtkPanedClass *class)
                  G_TYPE_BOOLEAN, 1,
                  G_TYPE_BOOLEAN);
 
+  /**
+   * GtkPaned::accept-position:
+   * @widget: the object that received the signal
+   *
+   * The ::accept-position signal is a 
+   * <link linkend="keybinding-signals">keybinding signal</link>
+   * which gets emitted to accept the current position of the handle when 
+   * moving it using key bindings.
+   *
+   * The default binding for this signal is Return or Space.
+   *
+   * Since: 2.0
+   */
   signals [ACCEPT_POSITION] =
-    g_signal_new ("accept_position",
+    g_signal_new (I_("accept_position"),
                  G_TYPE_FROM_CLASS (object_class),
                  G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
                  G_STRUCT_OFFSET (GtkPanedClass, accept_position),
@@ -375,8 +418,22 @@ gtk_paned_class_init (GtkPanedClass *class)
                  _gtk_marshal_BOOLEAN__VOID,
                  G_TYPE_BOOLEAN, 0);
 
+  /**
+   * GtkPaned::cancel-position:
+   * @widget: the object that received the signal
+   *
+   * The ::cancel-position signal is a 
+   * <link linkend="keybinding-signals">keybinding signal</link>
+   * which gets emitted to cancel moving the position of the handle using key 
+   * bindings. The position of the handle will be reset to the value prior to 
+   * moving it.
+   *
+   * The default binding for this signal is Escape.
+   *
+   * Since: 2.0
+   */
   signals [CANCEL_POSITION] =
-    g_signal_new ("cancel_position",
+    g_signal_new (I_("cancel_position"),
                  G_TYPE_FROM_CLASS (object_class),
                  G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
                  G_STRUCT_OFFSET (GtkPanedClass, cancel_position),
@@ -420,6 +477,9 @@ gtk_paned_class_init (GtkPanedClass *class)
   gtk_binding_entry_add_signal (binding_set,
                                GDK_Return, 0,
                                "accept_position", 0);
+  gtk_binding_entry_add_signal (binding_set,
+                               GDK_ISO_Enter, 0,
+                               "accept_position", 0);
   gtk_binding_entry_add_signal (binding_set,
                                GDK_KP_Enter, 0,
                                "accept_position", 0);
@@ -459,6 +519,8 @@ gtk_paned_class_init (GtkPanedClass *class)
   add_move_binding (binding_set, GDK_KP_Home, 0, GTK_SCROLL_START);
   add_move_binding (binding_set, GDK_End, 0, GTK_SCROLL_END);
   add_move_binding (binding_set, GDK_KP_End, 0, GTK_SCROLL_END);
+
+  g_type_class_add_private (object_class, sizeof (GtkPanedPrivate));  
 }
 
 static GType
@@ -487,7 +549,7 @@ gtk_paned_init (GtkPaned *paned)
   paned->last_allocation = -1;
   paned->in_drag = FALSE;
 
-  paned->priv = g_new0 (GtkPanedPrivate, 1);
+  paned->priv = G_TYPE_INSTANCE_GET_PRIVATE (paned, GTK_TYPE_PANED, GtkPanedPrivate);
   paned->last_child1_focus = NULL;
   paned->last_child2_focus = NULL;
   paned->in_recursion = FALSE;
@@ -638,9 +700,7 @@ gtk_paned_finalize (GObject *object)
   gtk_paned_set_saved_focus (paned, NULL);
   gtk_paned_set_first_paned (paned, NULL);
 
-  g_free (paned->priv);
-
-  G_OBJECT_CLASS (parent_class)->finalize (object);
+  G_OBJECT_CLASS (gtk_paned_parent_class)->finalize (object);
 }
 
 static void
@@ -662,8 +722,6 @@ gtk_paned_realize (GtkWidget *widget)
   attributes.y = paned->handle_pos.y;
   attributes.width = paned->handle_pos.width;
   attributes.height = paned->handle_pos.height;
-  attributes.cursor = gdk_cursor_new_for_display (gtk_widget_get_display (widget),
-                                                 paned->cursor_type);
   attributes.event_mask = gtk_widget_get_events (widget);
   attributes.event_mask |= (GDK_BUTTON_PRESS_MASK |
                            GDK_BUTTON_RELEASE_MASK |
@@ -671,12 +729,19 @@ gtk_paned_realize (GtkWidget *widget)
                            GDK_LEAVE_NOTIFY_MASK |
                            GDK_POINTER_MOTION_MASK |
                            GDK_POINTER_MOTION_HINT_MASK);
-  attributes_mask = GDK_WA_X | GDK_WA_Y | GDK_WA_CURSOR;
+  attributes_mask = GDK_WA_X | GDK_WA_Y;
+  if (GTK_WIDGET_IS_SENSITIVE (widget))
+    {
+      attributes.cursor = gdk_cursor_new_for_display (gtk_widget_get_display (widget),
+                                                     paned->cursor_type);
+      attributes_mask |= GDK_WA_CURSOR;
+    }
 
   paned->handle = gdk_window_new (widget->window,
                                  &attributes, attributes_mask);
   gdk_window_set_user_data (paned->handle, paned);
-  gdk_cursor_unref (attributes.cursor);
+  if (attributes_mask & GDK_WA_CURSOR)
+    gdk_cursor_unref (attributes.cursor);
 
   widget->style = gtk_style_attach (widget->style, widget->window);
 
@@ -708,8 +773,8 @@ gtk_paned_unrealize (GtkWidget *widget)
   gtk_paned_set_saved_focus (paned, NULL);
   gtk_paned_set_first_paned (paned, NULL);
   
-  if (GTK_WIDGET_CLASS (parent_class)->unrealize)
-    (* GTK_WIDGET_CLASS (parent_class)->unrealize) (widget);
+  if (GTK_WIDGET_CLASS (gtk_paned_parent_class)->unrealize)
+    (* GTK_WIDGET_CLASS (gtk_paned_parent_class)->unrealize) (widget);
 }
 
 static void
@@ -719,7 +784,7 @@ gtk_paned_map (GtkWidget *widget)
 
   gdk_window_show (paned->handle);
 
-  GTK_WIDGET_CLASS (parent_class)->map (widget);
+  GTK_WIDGET_CLASS (gtk_paned_parent_class)->map (widget);
 }
 
 static void
@@ -729,7 +794,7 @@ gtk_paned_unmap (GtkWidget *widget)
     
   gdk_window_hide (paned->handle);
 
-  GTK_WIDGET_CLASS (parent_class)->unmap (widget);
+  GTK_WIDGET_CLASS (gtk_paned_parent_class)->unmap (widget);
 }
 
 static gboolean
@@ -760,7 +825,7 @@ gtk_paned_expose (GtkWidget      *widget,
     }
 
   /* Chain up to draw children */
-  GTK_WIDGET_CLASS (parent_class)->expose_event (widget, event);
+  GTK_WIDGET_CLASS (gtk_paned_parent_class)->expose_event (widget, event);
   
   return FALSE;
 }
@@ -794,7 +859,7 @@ update_drag (GtkPaned *paned)
   if (is_rtl (paned))
     {
       gtk_widget_style_get (GTK_WIDGET (paned),
-                           "handle_size", &handle_size,
+                           "handle-size", &handle_size,
                            NULL);
       
       size = GTK_WIDGET (paned)->allocation.width - pos - handle_size;
@@ -866,7 +931,7 @@ gtk_paned_focus (GtkWidget        *widget,
    */
 
   GTK_WIDGET_UNSET_FLAGS (widget, GTK_CAN_FOCUS);
-  retval = (* GTK_WIDGET_CLASS (parent_class)->focus) (widget, direction);
+  retval = (* GTK_WIDGET_CLASS (gtk_paned_parent_class)->focus) (widget, direction);
   GTK_WIDGET_SET_FLAGS (widget, GTK_CAN_FOCUS);
 
   return retval;
@@ -881,18 +946,20 @@ gtk_paned_button_press (GtkWidget      *widget,
   if (!paned->in_drag &&
       (event->window == paned->handle) && (event->button == 1))
     {
-      paned->in_drag = TRUE;
-
       /* We need a server grab here, not gtk_grab_add(), since
        * we don't want to pass events on to the widget's children */
-      gdk_pointer_grab (paned->handle, FALSE,
-                       GDK_POINTER_MOTION_HINT_MASK
-                       | GDK_BUTTON1_MOTION_MASK
-                       | GDK_BUTTON_RELEASE_MASK
-                       | GDK_ENTER_NOTIFY_MASK
-                       | GDK_LEAVE_NOTIFY_MASK,
-                       NULL, NULL,
-                       event->time);
+      if (gdk_pointer_grab (paned->handle, FALSE,
+                           GDK_POINTER_MOTION_HINT_MASK
+                           | GDK_BUTTON1_MOTION_MASK
+                           | GDK_BUTTON_RELEASE_MASK
+                           | GDK_ENTER_NOTIFY_MASK
+                           | GDK_LEAVE_NOTIFY_MASK,
+                           NULL, NULL,
+                           event->time) != GDK_GRAB_SUCCESS)
+       return FALSE;
+
+      paned->in_drag = TRUE;
+      paned->priv->grab_time = event->time;
 
       if (paned->orientation == GTK_ORIENTATION_HORIZONTAL)
        paned->drag_pos = event->y;
@@ -905,6 +972,61 @@ gtk_paned_button_press (GtkWidget      *widget,
   return FALSE;
 }
 
+static gboolean
+gtk_paned_grab_broken (GtkWidget          *widget,
+                      GdkEventGrabBroken *event)
+{
+  GtkPaned *paned = GTK_PANED (widget);
+
+  paned->in_drag = FALSE;
+  paned->drag_pos = -1;
+  paned->position_set = TRUE;
+
+  return TRUE;
+}
+
+static void
+stop_drag (GtkPaned *paned)
+{
+  paned->in_drag = FALSE;
+  paned->drag_pos = -1;
+  paned->position_set = TRUE;
+  gdk_display_pointer_ungrab (gtk_widget_get_display (GTK_WIDGET (paned)),
+                             paned->priv->grab_time);
+}
+
+static void
+gtk_paned_grab_notify (GtkWidget *widget,
+                      gboolean   was_grabbed)
+{
+  GtkPaned *paned = GTK_PANED (widget);
+
+  if (!was_grabbed && paned->in_drag)
+    stop_drag (paned);
+}
+
+static void
+gtk_paned_state_changed (GtkWidget    *widget,
+                         GtkStateType  previous_state)
+{
+  GtkPaned *paned = GTK_PANED (widget);
+  GdkCursor *cursor;
+
+  if (GTK_WIDGET_REALIZED (paned))
+    {
+      if (GTK_WIDGET_IS_SENSITIVE (widget))
+        cursor = gdk_cursor_new_for_display (gtk_widget_get_display (widget),
+                                             paned->cursor_type); 
+      else
+        cursor = NULL;
+
+      gdk_window_set_cursor (paned->handle, cursor);
+
+      if (cursor)
+        gdk_cursor_unref (cursor);
+    }
+}
+
 static gboolean
 gtk_paned_button_release (GtkWidget      *widget,
                          GdkEventButton *event)
@@ -913,11 +1035,8 @@ gtk_paned_button_release (GtkWidget      *widget,
 
   if (paned->in_drag && (event->button == 1))
     {
-      paned->in_drag = FALSE;
-      paned->drag_pos = -1;
-      paned->position_set = TRUE;
-      gdk_display_pointer_ungrab (gtk_widget_get_display (widget),
-                                 event->time);
+      stop_drag (paned);
+
       return TRUE;
     }
 
@@ -1006,6 +1125,8 @@ gtk_paned_add (GtkContainer *container,
     gtk_paned_add1 (paned, widget);
   else if (!paned->child2)
     gtk_paned_add2 (paned, widget);
+  else
+    g_warning ("GtkPaned cannot have more than 2 children\n");
 }
 
 static void
@@ -1109,10 +1230,18 @@ gtk_paned_set_position (GtkPaned *paned,
 
   g_object_freeze_notify (object);
   g_object_notify (object, "position");
-  g_object_notify (object, "position_set");
+  g_object_notify (object, "position-set");
   g_object_thaw_notify (object);
 
   gtk_widget_queue_resize (GTK_WIDGET (paned));
+
+#ifdef G_OS_WIN32
+  /* Hacky work-around for bug #144269 */
+  if (paned->child2 != NULL)
+    {
+      gtk_widget_queue_draw (paned->child2);
+    }
+#endif
 }
 
 /**
@@ -1172,6 +1301,7 @@ gtk_paned_compute_position (GtkPaned *paned,
   paned->max_position = allocation;
   if (!paned->child2_shrink)
     paned->max_position = MAX (1, paned->max_position - child2_req);
+  paned->max_position = MAX (paned->min_position, paned->max_position);
 
   if (!paned->position_set)
     {
@@ -1180,9 +1310,9 @@ gtk_paned_compute_position (GtkPaned *paned,
       else if (!paned->child1_resize && paned->child2_resize)
        paned->child1_size = child1_req;
       else if (child1_req + child2_req != 0)
-       paned->child1_size = allocation * ((gdouble)child1_req / (child1_req + child2_req));
+       paned->child1_size = allocation * ((gdouble)child1_req / (child1_req + child2_req)) + 0.5;
       else
-       paned->child1_size = allocation * 0.5;
+       paned->child1_size = allocation * 0.5 + 0.5;
     }
   else
     {
@@ -1194,7 +1324,7 @@ gtk_paned_compute_position (GtkPaned *paned,
          if (paned->child1_resize && !paned->child2_resize)
            paned->child1_size += allocation - paned->last_allocation;
          else if (!(!paned->child1_resize && paned->child2_resize))
-           paned->child1_size = allocation * ((gdouble) paned->child1_size / (paned->last_allocation));
+           paned->child1_size = allocation * ((gdouble) paned->child1_size / (paned->last_allocation)) + 0.5;
        }
     }
 
@@ -1202,16 +1332,19 @@ gtk_paned_compute_position (GtkPaned *paned,
                              paned->min_position,
                              paned->max_position);
 
-  gtk_widget_set_child_visible (paned->child1, paned->child1_size != 0);
-  gtk_widget_set_child_visible (paned->child2, paned->child1_size != allocation);
+  if (paned->child1)
+    gtk_widget_set_child_visible (paned->child1, paned->child1_size != 0);
+  
+  if (paned->child2)
+    gtk_widget_set_child_visible (paned->child2, paned->child1_size != allocation); 
 
   g_object_freeze_notify (G_OBJECT (paned));
   if (paned->child1_size != old_position)
     g_object_notify (G_OBJECT (paned), "position");
   if (paned->min_position != old_min_position)
-    g_object_notify (G_OBJECT (paned), "min_position");
+    g_object_notify (G_OBJECT (paned), "min-position");
   if (paned->max_position != old_max_position)
-    g_object_notify (G_OBJECT (paned), "max_position");
+    g_object_notify (G_OBJECT (paned), "max-position");
   g_object_thaw_notify (G_OBJECT (paned));
 
   paned->last_allocation = allocation;
@@ -1318,8 +1451,8 @@ gtk_paned_set_focus_child (GtkContainer *container,
        }
     }
 
-  if (parent_class->set_focus_child)
-    (* parent_class->set_focus_child) (container, focus_child);
+  if (GTK_CONTAINER_CLASS (gtk_paned_parent_class)->set_focus_child)
+    (* GTK_CONTAINER_CLASS (gtk_paned_parent_class)->set_focus_child) (container, focus_child);
 }
 
 static void
@@ -1472,7 +1605,7 @@ get_child_panes (GtkWidget  *widget,
     }
   else if (GTK_IS_CONTAINER (widget))
     {
-      gtk_container_foreach (GTK_CONTAINER (widget),
+      gtk_container_forall (GTK_CONTAINER (widget),
                             (GtkCallback)get_child_panes, panes);
     }
 }
@@ -1795,3 +1928,6 @@ gtk_paned_toggle_handle_focus (GtkPaned *paned)
 
   return FALSE;
 }
+
+#define __GTK_PANED_C__
+#include "gtkaliasdef.c"