]> Pileus Git - ~andy/gtk/blobdiff - gtk/gtkmenubar.c
menubar: Respect ipadding also in y direction
[~andy/gtk] / gtk / gtkmenubar.c
index 42dadbd92095bcc23186419e71f993aec07a391f..a50a25c6f301fe7596910fef19a59388483b7c9d 100644 (file)
@@ -77,14 +77,20 @@ static void gtk_menu_bar_get_property      (GObject             *object,
                                            guint                prop_id,
                                            GValue              *value,
                                            GParamSpec          *pspec);
-static void gtk_menu_bar_size_request      (GtkWidget       *widget,
-                                           GtkRequisition  *requisition);
 static void gtk_menu_bar_get_preferred_width (GtkWidget     *widget,
                                              gint          *minimum,
                                              gint          *natural);
 static void gtk_menu_bar_get_preferred_height (GtkWidget    *widget,
                                               gint         *minimum,
                                               gint         *natural);
+static void gtk_menu_bar_get_preferred_width_for_height (GtkWidget    *widget,
+                                                         gint          height,
+                                                         gint         *minimum,
+                                                         gint         *natural);
+static void gtk_menu_bar_get_preferred_height_for_width (GtkWidget    *widget,
+                                                         gint          width,
+                                                         gint         *minimum,
+                                                         gint         *natural);
 static void gtk_menu_bar_size_allocate     (GtkWidget       *widget,
                                            GtkAllocation   *allocation);
 static gint gtk_menu_bar_draw              (GtkWidget       *widget,
@@ -117,6 +123,8 @@ gtk_menu_bar_class_init (GtkMenuBarClass *class)
 
   widget_class->get_preferred_width = gtk_menu_bar_get_preferred_width;
   widget_class->get_preferred_height = gtk_menu_bar_get_preferred_height;
+  widget_class->get_preferred_width_for_height = gtk_menu_bar_get_preferred_width_for_height;
+  widget_class->get_preferred_height_for_width = gtk_menu_bar_get_preferred_height_for_width;
   widget_class->size_allocate = gtk_menu_bar_size_allocate;
   widget_class->draw = gtk_menu_bar_draw;
   widget_class->hierarchy_changed = gtk_menu_bar_hierarchy_changed;
@@ -292,31 +300,63 @@ gtk_menu_bar_get_property (GObject    *object,
     }
 }
 
+static void
+get_preferred_size_for_size (GtkWidget      *widget,
+                             GtkOrientation  orientation,
+                             gint            size,
+                             gint           *minimum,
+                             gint           *natural)
+{
+  if (orientation == GTK_ORIENTATION_HORIZONTAL)
+    if (size < 0)
+      gtk_widget_get_preferred_width (widget, minimum, natural);
+    else
+      gtk_widget_get_preferred_width_for_height (widget, size, minimum, natural);
+  else
+    if (size < 0)
+      gtk_widget_get_preferred_height (widget, minimum, natural);
+    else
+      gtk_widget_get_preferred_height_for_width (widget, size, minimum, natural);
+}
+
 static void
 gtk_menu_bar_size_request (GtkWidget      *widget,
-                          GtkRequisition *requisition)
+                           GtkOrientation  orientation,
+                           gint            size,
+                           gint           *minimum,
+                           gint           *natural)
 {
   GtkMenuBar *menu_bar;
   GtkMenuBarPrivate *priv;
   GtkMenuShell *menu_shell;
   GtkWidget *child;
   GList *children;
-  GtkRequisition child_requisition;
   gint ipadding;
   guint border_width;
+  gboolean use_toggle_size, use_maximize;
+  gint child_minimum, child_natural;
 
-  g_return_if_fail (GTK_IS_MENU_BAR (widget));
-  g_return_if_fail (requisition != NULL);
+  *minimum = 0;
+  *natural = 0;
 
-  requisition->width = 0;
-  requisition->height = 0;
-  
   menu_bar = GTK_MENU_BAR (widget);
   menu_shell = GTK_MENU_SHELL (widget);
   priv = menu_bar->priv;
 
   children = menu_shell->priv->children;
 
+  if (priv->child_pack_direction == GTK_PACK_DIRECTION_LTR ||
+      priv->child_pack_direction == GTK_PACK_DIRECTION_RTL)
+    use_toggle_size = (orientation == GTK_ORIENTATION_HORIZONTAL);
+  else
+    use_toggle_size = (orientation == GTK_ORIENTATION_VERTICAL);
+
+  if (priv->pack_direction == GTK_PACK_DIRECTION_LTR ||
+      priv->pack_direction == GTK_PACK_DIRECTION_RTL)
+    use_maximize = (orientation == GTK_ORIENTATION_VERTICAL);
+  else
+    use_maximize = (orientation == GTK_ORIENTATION_HORIZONTAL);
+
   while (children)
     {
       child = children->data;
@@ -324,41 +364,36 @@ gtk_menu_bar_size_request (GtkWidget      *widget,
 
       if (gtk_widget_get_visible (child))
         {
-          gint toggle_size;
+          get_preferred_size_for_size (child, orientation, size, &child_minimum, &child_natural);
 
-          gtk_widget_get_preferred_size (child, &child_requisition, NULL);
-          gtk_menu_item_toggle_size_request (GTK_MENU_ITEM (child),
-                                             &toggle_size);
+          if (use_toggle_size)
+            {
+              gint toggle_size;
 
-          if (priv->child_pack_direction == GTK_PACK_DIRECTION_LTR ||
-              priv->child_pack_direction == GTK_PACK_DIRECTION_RTL)
-            child_requisition.width += toggle_size;
-          else
-            child_requisition.height += toggle_size;
+              gtk_menu_item_toggle_size_request (GTK_MENU_ITEM (child),
+                                                 &toggle_size);
 
-          if (priv->pack_direction == GTK_PACK_DIRECTION_LTR ||
-              priv->pack_direction == GTK_PACK_DIRECTION_RTL)
+              child_minimum += toggle_size;
+              child_natural += toggle_size;
+            }
+
+          if (use_maximize)
             {
-              requisition->width += child_requisition.width;
-              requisition->height = MAX (requisition->height, child_requisition.height);
+              *minimum = MAX (*minimum, child_minimum);
+              *natural = MAX (*natural, child_natural);
             }
           else
             {
-              requisition->width = MAX (requisition->width, child_requisition.width);
-              requisition->height += child_requisition.height;
+              *minimum += child_minimum;
+              *natural += child_natural;
             }
         }
     }
 
   gtk_widget_style_get (widget, "internal-padding", &ipadding, NULL);
-
   border_width = gtk_container_get_border_width (GTK_CONTAINER (menu_bar));
-  requisition->width += (border_width +
-                         ipadding + 
-                         BORDER_SPACING) * 2;
-  requisition->height += (border_width +
-                          ipadding +
-                          BORDER_SPACING) * 2;
+  *minimum += (border_width + ipadding + BORDER_SPACING) * 2;
+  *natural += (border_width + ipadding + BORDER_SPACING) * 2;
 
   if (get_shadow_type (menu_bar) != GTK_SHADOW_NONE)
     {
@@ -371,8 +406,16 @@ gtk_menu_bar_size_request (GtkWidget      *widget,
                              "border-width", &border,
                              NULL);
 
-      requisition->width += border->left + border->right;
-      requisition->height += border->top + border->bottom;
+      if (orientation == GTK_ORIENTATION_HORIZONTAL)
+        {
+          *minimum += border->left + border->right;
+          *natural += border->left + border->right;
+        }
+      else
+        {
+          *minimum += border->top + border->bottom;
+          *natural += border->top + border->bottom;
+        }
       gtk_border_free (border);
     }
 }
@@ -382,11 +425,7 @@ gtk_menu_bar_get_preferred_width (GtkWidget *widget,
                                  gint      *minimum,
                                  gint      *natural)
 {
-  GtkRequisition requisition;
-
-  gtk_menu_bar_size_request (widget, &requisition);
-
-  *minimum = *natural = requisition.width;
+  gtk_menu_bar_size_request (widget, GTK_ORIENTATION_HORIZONTAL, -1, minimum, natural);
 }
 
 static void
@@ -394,11 +433,25 @@ gtk_menu_bar_get_preferred_height (GtkWidget *widget,
                                   gint      *minimum,
                                   gint      *natural)
 {
-  GtkRequisition requisition;
+  gtk_menu_bar_size_request (widget, GTK_ORIENTATION_VERTICAL, -1, minimum, natural);
+}
 
-  gtk_menu_bar_size_request (widget, &requisition);
+static void
+gtk_menu_bar_get_preferred_width_for_height (GtkWidget *widget,
+                                             gint       height,
+                                             gint      *minimum,
+                                             gint      *natural)
+{
+  gtk_menu_bar_size_request (widget, GTK_ORIENTATION_HORIZONTAL, height, minimum, natural);
+}
 
-  *minimum = *natural = requisition.height;
+static void
+gtk_menu_bar_get_preferred_height_for_width (GtkWidget *widget,
+                                             gint       width,
+                                             gint      *minimum,
+                                             gint      *natural)
+{
+  gtk_menu_bar_size_request (widget, GTK_ORIENTATION_VERTICAL, width, minimum, natural);
 }
 
 static void
@@ -443,6 +496,7 @@ gtk_menu_bar_size_allocate (GtkWidget     *widget,
                            ipadding + 
                            BORDER_SPACING);
       child_allocation.y = (border_width +
+                            ipadding +
                            BORDER_SPACING);
       
       if (get_shadow_type (menu_bar) != GTK_SHADOW_NONE)