]> Pileus Git - ~andy/gtk/blobdiff - gtk/gtklayout.c
Updated
[~andy/gtk] / gtk / gtklayout.c
index 46772136e3508835c33d15fa1b12ffd697a32498..3d9ad1b5376c30d346bf7d4f22b780c9795311cf 100644 (file)
@@ -31,9 +31,9 @@
 #include "gdkconfig.h"
 
 #include "gtklayout.h"
-#include "gtksignal.h"
 #include "gtkprivate.h"
 #include "gtkintl.h"
+#include "gtkmarshalers.h"
 
 typedef struct _GtkLayoutChild   GtkLayoutChild;
 
@@ -51,49 +51,80 @@ enum {
    PROP_HEIGHT
 };
 
-static void     gtk_layout_class_init         (GtkLayoutClass *class);
-static void     gtk_layout_get_property       (GObject        *object,
-                                              guint          prop_id,
-                                              GValue         *value,
-                                              GParamSpec     *pspec);
-static void     gtk_layout_set_property       (GObject        *object,
-                                              guint          prop_id,
-                                              const GValue   *value,
-                                              GParamSpec     *pspec);
-static void     gtk_layout_init               (GtkLayout      *layout);
-
-static void     gtk_layout_finalize           (GObject        *object);
-static void     gtk_layout_realize            (GtkWidget      *widget);
-static void     gtk_layout_unrealize          (GtkWidget      *widget);
-static void     gtk_layout_map                (GtkWidget      *widget);
-static void     gtk_layout_size_request       (GtkWidget      *widget,
-                                              GtkRequisition *requisition);
-static void     gtk_layout_size_allocate      (GtkWidget      *widget,
-                                              GtkAllocation  *allocation);
-static gint     gtk_layout_expose             (GtkWidget      *widget, 
-                                              GdkEventExpose *event);
-
-static void     gtk_layout_remove             (GtkContainer *container, 
-                                              GtkWidget    *widget);
-static void     gtk_layout_forall             (GtkContainer *container,
-                                              gboolean      include_internals,
-                                              GtkCallback   callback,
-                                              gpointer      callback_data);
-static void     gtk_layout_set_adjustments    (GtkLayout     *layout,
-                                              GtkAdjustment *hadj,
-                                              GtkAdjustment *vadj);
-
-static void     gtk_layout_allocate_child     (GtkLayout      *layout,
-                                              GtkLayoutChild *child);
-
-
-static void     gtk_layout_adjustment_changed (GtkAdjustment  *adjustment,
-                                              GtkLayout      *layout);
+enum {
+  CHILD_PROP_0,
+  CHILD_PROP_X,
+  CHILD_PROP_Y
+};
+
+static void gtk_layout_class_init         (GtkLayoutClass *class);
+static void gtk_layout_get_property       (GObject        *object,
+                                           guint           prop_id,
+                                           GValue         *value,
+                                           GParamSpec     *pspec);
+static void gtk_layout_set_property       (GObject        *object,
+                                           guint           prop_id,
+                                           const GValue   *value,
+                                           GParamSpec     *pspec);
+static GObject *gtk_layout_constructor    (GType                  type,
+                                          guint                  n_properties,
+                                          GObjectConstructParam *properties);
+static void gtk_layout_init               (GtkLayout      *layout);
+static void gtk_layout_finalize           (GObject        *object);
+static void gtk_layout_realize            (GtkWidget      *widget);
+static void gtk_layout_unrealize          (GtkWidget      *widget);
+static void gtk_layout_map                (GtkWidget      *widget);
+static void gtk_layout_size_request       (GtkWidget      *widget,
+                                           GtkRequisition *requisition);
+static void gtk_layout_size_allocate      (GtkWidget      *widget,
+                                           GtkAllocation  *allocation);
+static gint gtk_layout_expose             (GtkWidget      *widget,
+                                           GdkEventExpose *event);
+static void gtk_layout_remove             (GtkContainer   *container,
+                                           GtkWidget      *widget);
+static void gtk_layout_forall             (GtkContainer   *container,
+                                           gboolean        include_internals,
+                                           GtkCallback     callback,
+                                           gpointer        callback_data);
+static void gtk_layout_set_adjustments    (GtkLayout      *layout,
+                                           GtkAdjustment  *hadj,
+                                           GtkAdjustment  *vadj);
+static void gtk_layout_set_child_property (GtkContainer   *container,
+                                           GtkWidget      *child,
+                                           guint           property_id,
+                                           const GValue   *value,
+                                           GParamSpec     *pspec);
+static void gtk_layout_get_child_property (GtkContainer   *container,
+                                           GtkWidget      *child,
+                                           guint           property_id,
+                                           GValue         *value,
+                                           GParamSpec     *pspec);
+static void gtk_layout_allocate_child     (GtkLayout      *layout,
+                                           GtkLayoutChild *child);
+static void gtk_layout_adjustment_changed (GtkAdjustment  *adjustment,
+                                           GtkLayout      *layout);
+static void gtk_layout_style_set          (GtkWidget      *widget,
+                                          GtkStyle       *old_style);
+
+static void gtk_layout_set_adjustment_upper (GtkAdjustment *adj,
+                                            gdouble        upper,
+                                            gboolean       always_emit_changed);
 
 static GtkWidgetClass *parent_class = NULL;
 
 /* Public interface
  */
+/**
+ * gtk_layout_new:
+ * @hadjustment: horizontal scroll adjustment, or %NULL
+ * @vadjustment: vertical scroll adjustment, or %NULL
+ * 
+ * Creates a new #GtkLayout. Unless you have a specific adjustment
+ * you'd like the layout to use for scrolling, pass %NULL for
+ * @hadjustment and @vadjustment.
+ * 
+ * Return value: a new #GtkLayout
+ **/
   
 GtkWidget*    
 gtk_layout_new (GtkAdjustment *hadjustment,
@@ -101,30 +132,61 @@ gtk_layout_new (GtkAdjustment *hadjustment,
 {
   GtkLayout *layout;
 
-  layout = gtk_type_new (GTK_TYPE_LAYOUT);
-
-  gtk_layout_set_adjustments (layout, hadjustment, vadjustment);
+  layout = g_object_new (GTK_TYPE_LAYOUT,
+                        "hadjustment", hadjustment,
+                        "vadjustment", vadjustment,
+                        NULL);
 
   return GTK_WIDGET (layout);
 }
 
+/**
+ * gtk_layout_get_hadjustment:
+ * @layout: a #GtkLayout
+ * 
+ * This function should only be called after the layout has been
+ * placed in a #GtkScrolledWindow or otherwise configured for
+ * scrolling. It returns the #GtkAdjustment used for communication
+ * between the horizontal scrollbar and @layout.
+ *
+ * See #GtkScrolledWindow, #GtkScrollbar, #GtkAdjustment for details.
+ * 
+ * Return value: horizontal scroll adjustment
+ **/
 GtkAdjustment* 
 gtk_layout_get_hadjustment (GtkLayout     *layout)
 {
-  g_return_val_if_fail (layout != NULL, NULL);
   g_return_val_if_fail (GTK_IS_LAYOUT (layout), NULL);
 
   return layout->hadjustment;
 }
+/**
+ * gtk_layout_get_vadjustment:
+ * @layout: a #GtkLayout
+ * 
+ * This function should only be called after the layout has been
+ * placed in a #GtkScrolledWindow or otherwise configured for
+ * scrolling. It returns the #GtkAdjustment used for communication
+ * between the vertical scrollbar and @layout.
+ *
+ * See #GtkScrolledWindow, #GtkScrollbar, #GtkAdjustment for details.
+ * 
+ * Return value: vertical scroll adjustment
+ **/
 GtkAdjustment* 
 gtk_layout_get_vadjustment (GtkLayout     *layout)
 {
-  g_return_val_if_fail (layout != NULL, NULL);
   g_return_val_if_fail (GTK_IS_LAYOUT (layout), NULL);
 
   return layout->vadjustment;
 }
 
+static GtkAdjustment *
+new_default_adjustment (void)
+{
+  return GTK_ADJUSTMENT (gtk_adjustment_new (0.0, 0.0, 0.0, 0.0, 0.0, 0.0));
+}
+
 static void           
 gtk_layout_set_adjustments (GtkLayout     *layout,
                            GtkAdjustment *hadj,
@@ -132,55 +194,62 @@ gtk_layout_set_adjustments (GtkLayout     *layout,
 {
   gboolean need_adjust = FALSE;
 
-  g_return_if_fail (layout != NULL);
   g_return_if_fail (GTK_IS_LAYOUT (layout));
 
   if (hadj)
     g_return_if_fail (GTK_IS_ADJUSTMENT (hadj));
-  else
-    hadj = GTK_ADJUSTMENT (gtk_adjustment_new (0.0, 0.0, 0.0, 0.0, 0.0, 0.0));
+  else if (layout->hadjustment)
+    hadj = new_default_adjustment ();
   if (vadj)
     g_return_if_fail (GTK_IS_ADJUSTMENT (vadj));
-  else
-    vadj = GTK_ADJUSTMENT (gtk_adjustment_new (0.0, 0.0, 0.0, 0.0, 0.0, 0.0));
+  else if (layout->vadjustment)
+    vadj = new_default_adjustment ();
   
   if (layout->hadjustment && (layout->hadjustment != hadj))
     {
-      gtk_signal_disconnect_by_data (GTK_OBJECT (layout->hadjustment), layout);
-      gtk_object_unref (GTK_OBJECT (layout->hadjustment));
+      g_signal_handlers_disconnect_by_func (layout->hadjustment,
+                                           gtk_layout_adjustment_changed,
+                                           layout);
+      g_object_unref (layout->hadjustment);
     }
   
   if (layout->vadjustment && (layout->vadjustment != vadj))
     {
-      gtk_signal_disconnect_by_data (GTK_OBJECT (layout->vadjustment), layout);
-      gtk_object_unref (GTK_OBJECT (layout->vadjustment));
+      g_signal_handlers_disconnect_by_func (layout->vadjustment,
+                                           gtk_layout_adjustment_changed,
+                                           layout);
+      g_object_unref (layout->vadjustment);
     }
   
   if (layout->hadjustment != hadj)
     {
       layout->hadjustment = hadj;
-      gtk_object_ref (GTK_OBJECT (layout->hadjustment));
+      g_object_ref (layout->hadjustment);
       gtk_object_sink (GTK_OBJECT (layout->hadjustment));
+      gtk_layout_set_adjustment_upper (layout->hadjustment, layout->width, FALSE);
       
-      gtk_signal_connect (GTK_OBJECT (layout->hadjustment), "value_changed",
-                         (GtkSignalFunc) gtk_layout_adjustment_changed,
-                         layout);
+      g_signal_connect (layout->hadjustment, "value_changed",
+                       G_CALLBACK (gtk_layout_adjustment_changed),
+                       layout);
       need_adjust = TRUE;
     }
   
   if (layout->vadjustment != vadj)
     {
       layout->vadjustment = vadj;
-      gtk_object_ref (GTK_OBJECT (layout->vadjustment));
+      g_object_ref (layout->vadjustment);
       gtk_object_sink (GTK_OBJECT (layout->vadjustment));
+      gtk_layout_set_adjustment_upper (layout->vadjustment, layout->height, FALSE);
       
-      gtk_signal_connect (GTK_OBJECT (layout->vadjustment), "value_changed",
-                         (GtkSignalFunc) gtk_layout_adjustment_changed,
-                         layout);
+      g_signal_connect (layout->vadjustment, "value_changed",
+                       G_CALLBACK (gtk_layout_adjustment_changed),
+                       layout);
       need_adjust = TRUE;
     }
 
-  if (need_adjust)
+  /* vadj or hadj can be NULL while constructing; don't emit a signal
+     then */
+  if (need_adjust && vadj && hadj)
     gtk_layout_adjustment_changed (NULL, layout);
 }
 
@@ -189,36 +258,84 @@ gtk_layout_finalize (GObject *object)
 {
   GtkLayout *layout = GTK_LAYOUT (object);
 
-  gtk_object_unref (GTK_OBJECT (layout->hadjustment));
-  gtk_object_unref (GTK_OBJECT (layout->vadjustment));
+  g_object_unref (layout->hadjustment);
+  g_object_unref (layout->vadjustment);
 
   G_OBJECT_CLASS (parent_class)->finalize (object);
 }
 
+/**
+ * gtk_layout_set_hadjustment:
+ * @layout: a #GtkLayout
+ * @adjustment: new scroll adjustment
+ *
+ * Sets the horizontal scroll adjustment for the layout.
+ *
+ * See #GtkScrolledWindow, #GtkScrollbar, #GtkAdjustment for details.
+ * 
+ **/
 void           
 gtk_layout_set_hadjustment (GtkLayout     *layout,
                            GtkAdjustment *adjustment)
 {
-  g_return_if_fail (layout != NULL);
   g_return_if_fail (GTK_IS_LAYOUT (layout));
 
   gtk_layout_set_adjustments (layout, adjustment, layout->vadjustment);
   g_object_notify (G_OBJECT (layout), "hadjustment");
 }
  
-
+/**
+ * gtk_layout_set_vadjustment:
+ * @layout: a #GtkLayout
+ * @adjustment: new scroll adjustment
+ *
+ * Sets the vertical scroll adjustment for the layout.
+ *
+ * See #GtkScrolledWindow, #GtkScrollbar, #GtkAdjustment for details.
+ * 
+ **/
 void           
 gtk_layout_set_vadjustment (GtkLayout     *layout,
                            GtkAdjustment *adjustment)
 {
-  g_return_if_fail (layout != NULL);
   g_return_if_fail (GTK_IS_LAYOUT (layout));
   
   gtk_layout_set_adjustments (layout, layout->hadjustment, adjustment);
   g_object_notify (G_OBJECT (layout), "vadjustment");
 }
 
+static GtkLayoutChild*
+get_child (GtkLayout  *layout,
+           GtkWidget  *widget)
+{
+  GList *children;
+  
+  children = layout->children;
+  while (children)
+    {
+      GtkLayoutChild *child;
+      
+      child = children->data;
+      children = children->next;
 
+      if (child->widget == widget)
+        return child;
+    }
+
+  return NULL;
+}
+
+/**
+ * gtk_layout_put:
+ * @layout: a #GtkLayout
+ * @child_widget: child widget
+ * @x: X position of child widget
+ * @y: Y position of child widget
+ *
+ * Adds @child_widget to @layout, at position (@x,@y).
+ * @layout becomes the new parent container of @child_widget.
+ * 
+ **/
 void           
 gtk_layout_put (GtkLayout     *layout, 
                GtkWidget     *child_widget, 
@@ -227,9 +344,7 @@ gtk_layout_put (GtkLayout     *layout,
 {
   GtkLayoutChild *child;
 
-  g_return_if_fail (layout != NULL);
   g_return_if_fail (GTK_IS_LAYOUT (layout));
-  g_return_if_fail (child_widget != NULL);
   g_return_if_fail (GTK_IS_WIDGET (child_widget));
   
   child = g_new (GtkLayoutChild, 1);
@@ -240,76 +355,110 @@ gtk_layout_put (GtkLayout     *layout,
 
   layout->children = g_list_append (layout->children, child);
   
-  gtk_widget_set_parent (child_widget, GTK_WIDGET (layout));
   if (GTK_WIDGET_REALIZED (layout))
     gtk_widget_set_parent_window (child->widget, layout->bin_window);
 
-  if (GTK_WIDGET_REALIZED (layout))
-    gtk_widget_realize (child_widget);
-    
-  if (GTK_WIDGET_VISIBLE (layout) && GTK_WIDGET_VISIBLE (child_widget))
+  gtk_widget_set_parent (child_widget, GTK_WIDGET (layout));
+}
+
+static void
+gtk_layout_move_internal (GtkLayout       *layout,
+                          GtkWidget       *widget,
+                          gboolean         change_x,
+                          gint             x,
+                          gboolean         change_y,
+                          gint             y)
+{
+  GtkLayoutChild *child;
+  
+  g_return_if_fail (GTK_IS_LAYOUT (layout));
+  g_return_if_fail (GTK_IS_WIDGET (widget));
+  g_return_if_fail (widget->parent == GTK_WIDGET (layout));  
+  
+  child = get_child (layout, widget);
+
+  g_assert (child);
+
+  gtk_widget_freeze_child_notify (widget);
+  
+  if (change_x)
     {
-      if (GTK_WIDGET_MAPPED (layout))
-       gtk_widget_map (child_widget);
+      child->x = x;
+      gtk_widget_child_notify (widget, "x");
+    }
 
-      gtk_widget_queue_resize (child_widget);
+  if (change_y)
+    {
+      child->y = y;
+      gtk_widget_child_notify (widget, "y");
     }
+
+  gtk_widget_thaw_child_notify (widget);
+  
+  if (GTK_WIDGET_VISIBLE (widget) && GTK_WIDGET_VISIBLE (layout))
+    gtk_widget_queue_resize (GTK_WIDGET (widget));
 }
 
+/**
+ * gtk_layout_move:
+ * @layout: a #GtkLayout
+ * @child_widget: a current child of @layout
+ * @x: X position to move to
+ * @y: Y position to move to
+ *
+ * Moves a current child of @layout to a new position.
+ * 
+ **/
 void           
 gtk_layout_move (GtkLayout     *layout, 
                 GtkWidget     *child_widget, 
                 gint           x, 
                 gint           y)
 {
-  GList *tmp_list;
-  GtkLayoutChild *child;
-  
-  g_return_if_fail (layout != NULL);
   g_return_if_fail (GTK_IS_LAYOUT (layout));
+  g_return_if_fail (GTK_IS_WIDGET (child_widget));
+  g_return_if_fail (child_widget->parent == GTK_WIDGET (layout));  
 
-  tmp_list = layout->children;
-  while (tmp_list)
-    {
-      child = tmp_list->data;
-      tmp_list = tmp_list->next;
-
-      if (child->widget == child_widget)
-       {
-         child->x = x;
-         child->y = y;
-
-         if (GTK_WIDGET_VISIBLE (child_widget) && GTK_WIDGET_VISIBLE (layout))
-           gtk_widget_queue_resize (child_widget);
-
-         return;
-       }
-    }
+  gtk_layout_move_internal (layout, child_widget, TRUE, x, TRUE, y);
 }
 
 static void
 gtk_layout_set_adjustment_upper (GtkAdjustment *adj,
-                                gdouble        upper)
+                                gdouble        upper,
+                                gboolean       always_emit_changed)
 {
+  gboolean changed = FALSE;
+  gboolean value_changed = FALSE;
+  
+  gdouble min = MAX (0., upper - adj->page_size);
+
   if (upper != adj->upper)
     {
-      gdouble min = MAX (0., upper - adj->page_size);
-      gboolean value_changed = FALSE;
-      
       adj->upper = upper;
+      changed = TRUE;
+    }
       
-      if (adj->value > min)
-       {
-         adj->value = min;
-         value_changed = TRUE;
-       }
-      
-      gtk_signal_emit_by_name (GTK_OBJECT (adj), "changed");
-      if (value_changed)
-       gtk_signal_emit_by_name (GTK_OBJECT (adj), "value_changed");
+  if (adj->value > min)
+    {
+      adj->value = min;
+      value_changed = TRUE;
     }
+  
+  if (changed || always_emit_changed)
+    gtk_adjustment_changed (adj);
+  if (value_changed)
+    gtk_adjustment_value_changed (adj);
 }
 
+/**
+ * gtk_layout_set_size:
+ * @layout: a #GtkLayout
+ * @width: width of entire scrollable area
+ * @height: height of entire scrollable area
+ *
+ * Sets the size of the scrollable area of the layout.
+ * 
+ **/
 void
 gtk_layout_set_size (GtkLayout     *layout, 
                     guint          width,
@@ -317,11 +466,11 @@ gtk_layout_set_size (GtkLayout     *layout,
 {
   GtkWidget *widget;
   
-  g_return_if_fail (layout != NULL);
   g_return_if_fail (GTK_IS_LAYOUT (layout));
 
   widget = GTK_WIDGET (layout);
   
+  g_object_freeze_notify (G_OBJECT (layout));
   if (width != layout->width)
      {
        layout->width = width;
@@ -332,9 +481,12 @@ gtk_layout_set_size (GtkLayout     *layout,
        layout->height = height;
        g_object_notify (G_OBJECT (layout), "height");
      }
+  g_object_thaw_notify (G_OBJECT (layout));
 
-  gtk_layout_set_adjustment_upper (layout->hadjustment, layout->width);
-  gtk_layout_set_adjustment_upper (layout->vadjustment, layout->height);
+  if (layout->hadjustment)
+    gtk_layout_set_adjustment_upper (layout->hadjustment, layout->width, FALSE);
+  if (layout->vadjustment)
+    gtk_layout_set_adjustment_upper (layout->vadjustment, layout->height, FALSE);
 
   if (GTK_WIDGET_REALIZED (layout))
     {
@@ -367,49 +519,66 @@ gtk_layout_get_size (GtkLayout *layout,
     *height = layout->height;
 }
 
+/**
+ * gtk_layout_freeze:
+ * @layout: a #GtkLayout
+ * 
+ * This is a deprecated function, it doesn't do anything useful.
+ **/
 void
 gtk_layout_freeze (GtkLayout *layout)
 {
-  g_return_if_fail (layout != NULL);
   g_return_if_fail (GTK_IS_LAYOUT (layout));
 
   layout->freeze_count++;
 }
 
+/**
+ * gtk_layout_thaw:
+ * @layout: a #GtkLayout
+ * 
+ * This is a deprecated function, it doesn't do anything useful.
+ **/
 void
 gtk_layout_thaw (GtkLayout *layout)
 {
-  g_return_if_fail (layout != NULL);
   g_return_if_fail (GTK_IS_LAYOUT (layout));
 
   if (layout->freeze_count)
-    if (!(--layout->freeze_count))
-      gtk_widget_draw (GTK_WIDGET (layout), NULL);
+    {
+      if (!(--layout->freeze_count))
+       {
+         gtk_widget_queue_draw (GTK_WIDGET (layout));
+         gdk_window_process_updates (GTK_WIDGET (layout)->window, TRUE);
+       }
+    }
+
 }
 
 /* Basic Object handling procedures
  */
-GtkType
+GType
 gtk_layout_get_type (void)
 {
-  static GtkType layout_type = 0;
+  static GType layout_type = 0;
 
   if (!layout_type)
     {
       static const GTypeInfo layout_info =
       {
        sizeof (GtkLayoutClass),
-       NULL,           /* base_init */
-       NULL,           /* base_finalize */
+       NULL,           /* base_init */
+       NULL,           /* base_finalize */
        (GClassInitFunc) gtk_layout_class_init,
-       NULL,           /* class_finalize */
-       NULL,           /* class_data */
+       NULL,           /* class_finalize */
+       NULL,           /* class_data */
        sizeof (GtkLayout),
-       16,             /* n_preallocs */
+       0,              /* n_preallocs */
        (GInstanceInitFunc) gtk_layout_init,
       };
 
-      layout_type = g_type_register_static (GTK_TYPE_CONTAINER, "GtkLayout", &layout_info, 0);
+      layout_type = g_type_register_static (GTK_TYPE_CONTAINER, "GtkLayout",
+                                           &layout_info, 0);
     }
 
   return layout_type;
@@ -419,26 +588,48 @@ static void
 gtk_layout_class_init (GtkLayoutClass *class)
 {
   GObjectClass *gobject_class;
-  GtkObjectClass *object_class;
   GtkWidgetClass *widget_class;
   GtkContainerClass *container_class;
 
   gobject_class = (GObjectClass*) class;
-  object_class = (GtkObjectClass*) class;
   widget_class = (GtkWidgetClass*) class;
   container_class = (GtkContainerClass*) class;
 
-  parent_class = gtk_type_class (GTK_TYPE_CONTAINER);
+  parent_class = g_type_class_peek_parent (class);
 
   gobject_class->set_property = gtk_layout_set_property;
   gobject_class->get_property = gtk_layout_get_property;
   gobject_class->finalize = gtk_layout_finalize;
-
+  gobject_class->constructor = gtk_layout_constructor;
+
+  container_class->set_child_property = gtk_layout_set_child_property;
+  container_class->get_child_property = gtk_layout_get_child_property;
+
+  gtk_container_class_install_child_property (container_class,
+                                             CHILD_PROP_X,
+                                             g_param_spec_int ("x",
+                                                                _("X position"),
+                                                                _("X position of child widget"),
+                                                                G_MININT,
+                                                                G_MAXINT,
+                                                                0,
+                                                                G_PARAM_READWRITE));
+
+  gtk_container_class_install_child_property (container_class,
+                                             CHILD_PROP_Y,
+                                             g_param_spec_int ("y",
+                                                                _("Y position"),
+                                                                _("Y position of child widget"),
+                                                                G_MININT,
+                                                                G_MAXINT,
+                                                                0,
+                                                                G_PARAM_READWRITE));
+  
   g_object_class_install_property (gobject_class,
                                   PROP_HADJUSTMENT,
                                   g_param_spec_object ("hadjustment",
                                                        _("Horizontal adjustment"),
-                                                       _("The GtkAdjustment for the horizontal position."),
+                                                       _("The GtkAdjustment for the horizontal position"),
                                                        GTK_TYPE_ADJUSTMENT,
                                                        G_PARAM_READWRITE));
   
@@ -446,7 +637,7 @@ gtk_layout_class_init (GtkLayoutClass *class)
                                   PROP_VADJUSTMENT,
                                   g_param_spec_object ("vadjustment",
                                                        _("Vertical adjustment"),
-                                                       _("The GtkAdjustment for the vertical position."),
+                                                       _("The GtkAdjustment for the vertical position"),
                                                        GTK_TYPE_ADJUSTMENT,
                                                        G_PARAM_READWRITE));
 
@@ -454,7 +645,7 @@ gtk_layout_class_init (GtkLayoutClass *class)
                                   PROP_WIDTH,
                                   g_param_spec_uint ("width",
                                                     _("Width"),
-                                                    _("The width of the layout."),
+                                                    _("The width of the layout"),
                                                     0,
                                                     G_MAXINT,
                                                     100,
@@ -463,7 +654,7 @@ gtk_layout_class_init (GtkLayoutClass *class)
                                   PROP_HEIGHT,
                                   g_param_spec_uint ("height",
                                                     _("Height"),
-                                                    _("The height of the layout."),
+                                                    _("The height of the layout"),
                                                     0,
                                                     G_MAXINT,
                                                     100,
@@ -474,6 +665,7 @@ gtk_layout_class_init (GtkLayoutClass *class)
   widget_class->size_request = gtk_layout_size_request;
   widget_class->size_allocate = gtk_layout_size_allocate;
   widget_class->expose_event = gtk_layout_expose;
+  widget_class->style_set = gtk_layout_style_set;
 
   container_class->remove = gtk_layout_remove;
   container_class->forall = gtk_layout_forall;
@@ -481,12 +673,15 @@ gtk_layout_class_init (GtkLayoutClass *class)
   class->set_scroll_adjustments = gtk_layout_set_adjustments;
 
   widget_class->set_scroll_adjustments_signal =
-    gtk_signal_new ("set_scroll_adjustments",
-                   GTK_RUN_LAST,
-                   GTK_CLASS_TYPE (object_class),
-                   GTK_SIGNAL_OFFSET (GtkLayoutClass, set_scroll_adjustments),
-                   gtk_marshal_VOID__OBJECT_OBJECT,
-                   GTK_TYPE_NONE, 2, GTK_TYPE_ADJUSTMENT, GTK_TYPE_ADJUSTMENT);
+    g_signal_new ("set_scroll_adjustments",
+                 G_OBJECT_CLASS_TYPE (gobject_class),
+                 G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
+                 G_STRUCT_OFFSET (GtkLayoutClass, set_scroll_adjustments),
+                 NULL, NULL,
+                 _gtk_marshal_VOID__OBJECT_OBJECT,
+                 G_TYPE_NONE, 2,
+                 GTK_TYPE_ADJUSTMENT,
+                 GTK_TYPE_ADJUSTMENT);
 }
 
 static void
@@ -500,10 +695,10 @@ gtk_layout_get_property (GObject     *object,
   switch (prop_id)
     {
     case PROP_HADJUSTMENT:
-      g_value_set_object (value, G_OBJECT (layout->hadjustment));
+      g_value_set_object (value, layout->hadjustment);
       break;
     case PROP_VADJUSTMENT:
-      g_value_set_object (value, G_OBJECT (layout->vadjustment));
+      g_value_set_object (value, layout->vadjustment);
       break;
     case PROP_WIDTH:
       g_value_set_uint (value, layout->width);
@@ -549,6 +744,57 @@ gtk_layout_set_property (GObject      *object,
     }
 }
 
+static void
+gtk_layout_set_child_property (GtkContainer    *container,
+                               GtkWidget       *child,
+                               guint            property_id,
+                               const GValue    *value,
+                               GParamSpec      *pspec)
+{
+  switch (property_id)
+    {
+    case CHILD_PROP_X:
+      gtk_layout_move_internal (GTK_LAYOUT (container),
+                                child,
+                                TRUE, g_value_get_int (value),
+                                FALSE, 0);
+      break;
+    case CHILD_PROP_Y:
+      gtk_layout_move_internal (GTK_LAYOUT (container),
+                                child,
+                                FALSE, 0,
+                                TRUE, g_value_get_int (value));
+      break;
+    default:
+      GTK_CONTAINER_WARN_INVALID_CHILD_PROPERTY_ID (container, property_id, pspec);
+      break;
+    }
+}
+
+static void
+gtk_layout_get_child_property (GtkContainer *container,
+                               GtkWidget    *child,
+                               guint         property_id,
+                               GValue       *value,
+                               GParamSpec   *pspec)
+{
+  GtkLayoutChild *layout_child;
+
+  layout_child = get_child (GTK_LAYOUT (container), child);
+  
+  switch (property_id)
+    {
+    case CHILD_PROP_X:
+      g_value_set_int (value, layout_child->x);
+      break;
+    case CHILD_PROP_Y:
+      g_value_set_int (value, layout_child->y);
+      break;
+    default:
+      GTK_CONTAINER_WARN_INVALID_CHILD_PROPERTY_ID (container, property_id, pspec);
+      break;
+    }
+}
 
 static void
 gtk_layout_init (GtkLayout *layout)
@@ -570,6 +816,30 @@ gtk_layout_init (GtkLayout *layout)
   layout->freeze_count = 0;
 }
 
+static GObject *
+gtk_layout_constructor (GType                  type,
+                       guint                  n_properties,
+                       GObjectConstructParam *properties)
+{
+  GtkLayout *layout;
+  GObject *object;
+  GtkAdjustment *hadj, *vadj;
+  
+  object = G_OBJECT_CLASS (parent_class)->constructor (type,
+                                                      n_properties,
+                                                      properties);
+
+  layout = GTK_LAYOUT (object);
+
+  hadj = layout->hadjustment ? layout->hadjustment : new_default_adjustment ();
+  vadj = layout->vadjustment ? layout->vadjustment : new_default_adjustment ();
+
+  if (!layout->hadjustment || !layout->vadjustment)
+    gtk_layout_set_adjustments (layout, hadj, vadj);
+
+  return object;
+}
+
 /* Widget methods
  */
 
@@ -581,7 +851,6 @@ gtk_layout_realize (GtkWidget *widget)
   GdkWindowAttr attributes;
   gint attributes_mask;
 
-  g_return_if_fail (widget != NULL);
   g_return_if_fail (GTK_IS_LAYOUT (widget));
 
   layout = GTK_LAYOUT (widget);
@@ -603,8 +872,8 @@ gtk_layout_realize (GtkWidget *widget)
                                   &attributes, attributes_mask);
   gdk_window_set_user_data (widget->window, widget);
 
-  attributes.x = 0;
-  attributes.y = 0;
+  attributes.x = - layout->hadjustment->value,
+  attributes.y = - layout->vadjustment->value;
   attributes.width = MAX (layout->width, widget->allocation.width);
   attributes.height = MAX (layout->height, widget->allocation.height);
   attributes.event_mask = GDK_EXPOSURE_MASK | GDK_SCROLL_MASK | 
@@ -628,13 +897,24 @@ gtk_layout_realize (GtkWidget *widget)
     }
 }
 
+static void
+gtk_layout_style_set (GtkWidget *widget, GtkStyle *old_style)
+{
+  if (GTK_WIDGET_CLASS (parent_class)->style_set)
+    (* GTK_WIDGET_CLASS (parent_class)->style_set) (widget, old_style);
+
+  if (GTK_WIDGET_REALIZED (widget))
+    {
+      gtk_style_set_background (widget->style, GTK_LAYOUT (widget)->bin_window, GTK_STATE_NORMAL);
+    }
+}
+
 static void 
 gtk_layout_map (GtkWidget *widget)
 {
   GList *tmp_list;
   GtkLayout *layout;
 
-  g_return_if_fail (widget != NULL);
   g_return_if_fail (GTK_IS_LAYOUT (widget));
 
   layout = GTK_LAYOUT (widget);
@@ -663,7 +943,6 @@ gtk_layout_unrealize (GtkWidget *widget)
 {
   GtkLayout *layout;
 
-  g_return_if_fail (widget != NULL);
   g_return_if_fail (GTK_IS_LAYOUT (widget));
 
   layout = GTK_LAYOUT (widget);
@@ -683,7 +962,6 @@ gtk_layout_size_request (GtkWidget     *widget,
   GList *tmp_list;
   GtkLayout *layout;
 
-  g_return_if_fail (widget != NULL);
   g_return_if_fail (GTK_IS_LAYOUT (widget));
 
   layout = GTK_LAYOUT (widget);
@@ -711,7 +989,6 @@ gtk_layout_size_allocate (GtkWidget     *widget,
   GList *tmp_list;
   GtkLayout *layout;
 
-  g_return_if_fail (widget != NULL);
   g_return_if_fail (GTK_IS_LAYOUT (widget));
 
   widget->allocation = *allocation;
@@ -740,16 +1017,16 @@ gtk_layout_size_allocate (GtkWidget     *widget,
     }
 
   layout->hadjustment->page_size = allocation->width;
-  layout->hadjustment->page_increment = allocation->width / 2;
+  layout->hadjustment->page_increment = allocation->width * 0.9;
   layout->hadjustment->lower = 0;
-  layout->hadjustment->upper = MAX (allocation->width, layout->width);
-  gtk_signal_emit_by_name (GTK_OBJECT (layout->hadjustment), "changed");
+  /* set_adjustment_upper() emits ::changed */
+  gtk_layout_set_adjustment_upper (layout->hadjustment, MAX (allocation->width, layout->width), TRUE);
 
   layout->vadjustment->page_size = allocation->height;
-  layout->vadjustment->page_increment = allocation->height / 2;
+  layout->vadjustment->page_increment = allocation->height * 0.9;
   layout->vadjustment->lower = 0;
   layout->vadjustment->upper = MAX (allocation->height, layout->height);
-  gtk_signal_emit_by_name (GTK_OBJECT (layout->vadjustment), "changed");
+  gtk_layout_set_adjustment_upper (layout->vadjustment, MAX (allocation->height, layout->height), TRUE);
 }
 
 static gint 
@@ -757,7 +1034,6 @@ gtk_layout_expose (GtkWidget *widget, GdkEventExpose *event)
 {
   GtkLayout *layout;
 
-  g_return_val_if_fail (widget != NULL, FALSE);
   g_return_val_if_fail (GTK_IS_LAYOUT (widget), FALSE);
 
   layout = GTK_LAYOUT (widget);
@@ -780,7 +1056,6 @@ gtk_layout_remove (GtkContainer *container,
   GtkLayout *layout;
   GtkLayoutChild *child = NULL;
   
-  g_return_if_fail (container != NULL);
   g_return_if_fail (GTK_IS_LAYOUT (container));
   
   layout = GTK_LAYOUT (container);
@@ -814,7 +1089,6 @@ gtk_layout_forall (GtkContainer *container,
   GtkLayoutChild *child;
   GList *tmp_list;
 
-  g_return_if_fail (container != NULL);
   g_return_if_fail (GTK_IS_LAYOUT (container));
   g_return_if_fail (callback != NULL);