]> Pileus Git - ~andy/gtk/blobdiff - gtk/gtklabel.c
Use the correct screen for getting the height. (Fix from Stephen Browne,
[~andy/gtk] / gtk / gtklabel.c
index f648f2d342c39303fbdcc5d58e1267cbc0db01b9..2129b50e66dcd487f040e16bb95b212d0f07e568 100644 (file)
 #include "gtklabel.h"
 #include "gtkmain.h"
 #include "gtkmarshalers.h"
-#include "gtksignal.h"
 #include "gtkwindow.h"
 #include "gdk/gdkkeysyms.h"
 #include "gtkclipboard.h"
-#include "gdk/gdki18n.h"
 #include <pango/pango.h>
 #include "gtkimagemenuitem.h"
 #include "gtkintl.h"
@@ -47,7 +45,6 @@ struct _GtkLabelSelectionInfo
   GdkWindow *window;
   gint selection_anchor;
   gint selection_end;
-  GdkGC *cursor_gc;
   GtkWidget *popup_menu;
 };
 
@@ -133,6 +130,8 @@ static void set_markup                           (GtkLabel      *label,
 static void gtk_label_recalculate                (GtkLabel      *label);
 static void gtk_label_hierarchy_changed          (GtkWidget     *widget,
                                                  GtkWidget     *old_toplevel);
+static void gtk_label_screen_changed             (GtkWidget     *widget,
+                                                 GdkScreen     *old_screen);
 
 static void gtk_label_create_window       (GtkLabel *label);
 static void gtk_label_destroy_window      (GtkLabel *label);
@@ -167,10 +166,10 @@ static gint gtk_label_move_backward_word (GtkLabel        *label,
 static GtkMiscClass *parent_class = NULL;
 
 
-GtkType
+GType
 gtk_label_get_type (void)
 {
-  static GtkType label_type = 0;
+  static GType label_type = 0;
   
   if (!label_type)
     {
@@ -187,7 +186,8 @@ gtk_label_get_type (void)
        (GInstanceInitFunc) gtk_label_init,
       };
 
-      label_type = g_type_register_static (GTK_TYPE_MISC, "GtkLabel", &label_info, 0);
+      label_type = g_type_register_static (GTK_TYPE_MISC, "GtkLabel",
+                                          &label_info, 0);
     }
   
   return label_type;
@@ -204,16 +204,16 @@ add_move_binding (GtkBindingSet  *binding_set,
   
   gtk_binding_entry_add_signal (binding_set, keyval, modmask,
                                "move_cursor", 3,
-                               GTK_TYPE_ENUM, step,
+                               G_TYPE_ENUM, step,
                                G_TYPE_INT, count,
-                                G_TYPE_BOOLEAN, FALSE);
+                               G_TYPE_BOOLEAN, FALSE);
 
   /* Selection-extending version */
   gtk_binding_entry_add_signal (binding_set, keyval, modmask | GDK_SHIFT_MASK,
                                "move_cursor", 3,
-                               GTK_TYPE_ENUM, step,
+                               G_TYPE_ENUM, step,
                                G_TYPE_INT, count,
-                                G_TYPE_BOOLEAN, TRUE);
+                               G_TYPE_BOOLEAN, TRUE);
 }
 
 static void
@@ -224,7 +224,7 @@ gtk_label_class_init (GtkLabelClass *class)
   GtkWidgetClass *widget_class = GTK_WIDGET_CLASS (class);
   GtkBindingSet *binding_set;
 
-  parent_class = gtk_type_class (GTK_TYPE_MISC);
+  parent_class = g_type_class_peek_parent (class);
   
   gobject_class->set_property = gtk_label_set_property;
   gobject_class->get_property = gtk_label_get_property;
@@ -246,6 +246,7 @@ gtk_label_class_init (GtkLabelClass *class)
   widget_class->button_release_event = gtk_label_button_release;
   widget_class->motion_notify_event = gtk_label_motion;
   widget_class->hierarchy_changed = gtk_label_hierarchy_changed;
+  widget_class->screen_changed = gtk_label_screen_changed;
   widget_class->mnemonic_activate = gtk_label_mnemonic_activate;
   widget_class->focus = gtk_label_focus;
 
@@ -253,48 +254,55 @@ gtk_label_class_init (GtkLabelClass *class)
   class->copy_clipboard = gtk_label_copy_clipboard;
   
   signals[MOVE_CURSOR] = 
-      gtk_signal_new ("move_cursor",
-                      GTK_RUN_LAST | GTK_RUN_ACTION,
-                      GTK_CLASS_TYPE (object_class),
-                      GTK_SIGNAL_OFFSET (GtkLabelClass, move_cursor),
-                      _gtk_marshal_VOID__ENUM_INT_BOOLEAN,
-                      GTK_TYPE_NONE, 3, GTK_TYPE_MOVEMENT_STEP, GTK_TYPE_INT, GTK_TYPE_BOOL);
+    g_signal_new ("move_cursor",
+                 G_OBJECT_CLASS_TYPE (gobject_class),
+                 G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
+                 G_STRUCT_OFFSET (GtkLabelClass, move_cursor),
+                 NULL, NULL,
+                 _gtk_marshal_VOID__ENUM_INT_BOOLEAN,
+                 G_TYPE_NONE, 3,
+                 GTK_TYPE_MOVEMENT_STEP,
+                 G_TYPE_INT,
+                 G_TYPE_BOOLEAN);
   
   signals[COPY_CLIPBOARD] =
-    gtk_signal_new ("copy_clipboard",
-                    GTK_RUN_LAST | GTK_RUN_ACTION,
-                    GTK_CLASS_TYPE (object_class),
-                    GTK_SIGNAL_OFFSET (GtkLabelClass, copy_clipboard),
-                    _gtk_marshal_VOID__VOID,
-                    GTK_TYPE_NONE, 0);
+    g_signal_new ("copy_clipboard",
+                 G_OBJECT_CLASS_TYPE (gobject_class),
+                 G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
+                 G_STRUCT_OFFSET (GtkLabelClass, copy_clipboard),
+                 NULL, NULL,
+                 _gtk_marshal_VOID__VOID,
+                 G_TYPE_NONE, 0);
   
   signals[POPULATE_POPUP] =
-    gtk_signal_new ("populate_popup",
-                   GTK_RUN_LAST,
-                   GTK_CLASS_TYPE (object_class),
-                   GTK_SIGNAL_OFFSET (GtkLabelClass, populate_popup),
-                   _gtk_marshal_VOID__OBJECT,
-                   GTK_TYPE_NONE, 1, GTK_TYPE_MENU);
-
-  g_object_class_install_property (G_OBJECT_CLASS(object_class),
+    g_signal_new ("populate_popup",
+                 G_OBJECT_CLASS_TYPE (gobject_class),
+                 G_SIGNAL_RUN_LAST,
+                 G_STRUCT_OFFSET (GtkLabelClass, populate_popup),
+                 NULL, NULL,
+                 _gtk_marshal_VOID__OBJECT,
+                 G_TYPE_NONE, 1,
+                 GTK_TYPE_MENU);
+
+  g_object_class_install_property (gobject_class,
                                    PROP_LABEL,
                                    g_param_spec_string ("label",
                                                         _("Label"),
-                                                        _("The text of the label."),
+                                                        _("The text of the label"),
                                                         NULL,
                                                         G_PARAM_READWRITE));
   g_object_class_install_property (gobject_class,
                                   PROP_ATTRIBUTES,
                                   g_param_spec_boxed ("attributes",
                                                       _("Attributes"),
-                                                      _("A list of style attributes to apply to the text of the label."),
+                                                      _("A list of style attributes to apply to the text of the label"),
                                                       PANGO_TYPE_ATTR_LIST,
                                                       G_PARAM_READWRITE));
   g_object_class_install_property (gobject_class,
                                    PROP_USE_MARKUP,
                                    g_param_spec_boolean ("use_markup",
                                                         _("Use markup"),
-                                                        _("The text of the label includes XML markup. See pango_parse_markup()."),
+                                                        _("The text of the label includes XML markup. See pango_parse_markup()"),
                                                         FALSE,
                                                         G_PARAM_READWRITE));
   g_object_class_install_property (gobject_class,
@@ -309,7 +317,7 @@ gtk_label_class_init (GtkLabelClass *class)
                                   PROP_JUSTIFY,
                                    g_param_spec_enum ("justify",
                                                       _("Justification"),
-                                                      _("The alignment of the lines in the text of the label relative to each other. This does NOT affect the alignment of the label within its allocation. See GtkMisc::xalign for that."),
+                                                      _("The alignment of the lines in the text of the label relative to each other. This does NOT affect the alignment of the label within its allocation. See GtkMisc::xalign for that"),
                                                      GTK_TYPE_JUSTIFICATION,
                                                      GTK_JUSTIFY_LEFT,
                                                       G_PARAM_READWRITE));
@@ -318,7 +326,7 @@ gtk_label_class_init (GtkLabelClass *class)
                                    PROP_PATTERN,
                                    g_param_spec_string ("pattern",
                                                         _("Pattern"),
-                                                        _("A string with _ characters in positions correspond to characters in the text to underline."),
+                                                        _("A string with _ characters in positions correspond to characters in the text to underline"),
                                                         NULL,
                                                         G_PARAM_WRITABLE));
 
@@ -326,21 +334,21 @@ gtk_label_class_init (GtkLabelClass *class)
                                    PROP_WRAP,
                                    g_param_spec_boolean ("wrap",
                                                         _("Line wrap"),
-                                                        _("If set, wrap lines if the text becomes too wide."),
+                                                        _("If set, wrap lines if the text becomes too wide"),
                                                         FALSE,
                                                         G_PARAM_READWRITE));
   g_object_class_install_property (gobject_class,
                                    PROP_SELECTABLE,
                                    g_param_spec_boolean ("selectable",
                                                         _("Selectable"),
-                                                        _("Whether the label text can be selected with the mouse."),
+                                                        _("Whether the label text can be selected with the mouse"),
                                                         FALSE,
                                                         G_PARAM_READWRITE));
   g_object_class_install_property (gobject_class,
                                    PROP_MNEMONIC_KEYVAL,
                                    g_param_spec_uint ("mnemonic_keyval",
                                                      _("Mnemonic key"),
-                                                     _("The mnemonic accelerator key for this label."),
+                                                     _("The mnemonic accelerator key for this label"),
                                                      0,
                                                      G_MAXUINT,
                                                      GDK_VoidSymbol,
@@ -350,7 +358,7 @@ gtk_label_class_init (GtkLabelClass *class)
                                    g_param_spec_object ("mnemonic_widget",
                                                        _("Mnemonic widget"),
                                                        _("The widget to be activated when the label's mnemonic "
-                                                         "key is pressed."),
+                                                         "key is pressed"),
                                                        GTK_TYPE_WIDGET,
                                                        G_PARAM_READWRITE));
 
@@ -358,7 +366,7 @@ gtk_label_class_init (GtkLabelClass *class)
                                    PROP_CURSOR_POSITION,
                                    g_param_spec_int ("cursor_position",
                                                      _("Cursor Position"),
-                                                     _("The current position of the insertion cursor in chars."),
+                                                     _("The current position of the insertion cursor in chars"),
                                                      0,
                                                      G_MAXINT,
                                                      0,
@@ -368,19 +376,12 @@ gtk_label_class_init (GtkLabelClass *class)
                                    PROP_SELECTION_BOUND,
                                    g_param_spec_int ("selection_bound",
                                                      _("Selection Bound"),
-                                                     _("The position of the opposite end of the selection from the cursor in chars."),
+                                                     _("The position of the opposite end of the selection from the cursor in chars"),
                                                      0,
                                                      G_MAXINT,
                                                      0,
                                                      G_PARAM_READABLE));
   
-  gtk_widget_class_install_style_property (widget_class,
-                                          g_param_spec_boxed ("cursor_color",
-                                                              _("Cursor color"),
-                                                              _("Color with which to draw insertion cursor"),
-                                                              GDK_TYPE_COLOR,
-                                                              G_PARAM_READABLE));
-  
   /*
    * Key bindings
    */
@@ -548,8 +549,8 @@ gtk_label_get_property (GObject     *object,
     case PROP_CURSOR_POSITION:
       if (label->select_info)
        {
-         gint offset = g_utf8_pointer_to_offset (label->label,
-                                                 label->label + label->select_info->selection_end);
+         gint offset = g_utf8_pointer_to_offset (label->text,
+                                                 label->text + label->select_info->selection_end);
          g_value_set_int (value, offset);
        }
       else
@@ -558,8 +559,8 @@ gtk_label_get_property (GObject     *object,
     case PROP_SELECTION_BOUND:
       if (label->select_info)
        {
-         gint offset = g_utf8_pointer_to_offset (label->label,
-                                                 label->label + label->select_info->selection_anchor);
+         gint offset = g_utf8_pointer_to_offset (label->text,
+                                                 label->text + label->select_info->selection_anchor);
          g_value_set_int (value, offset);
        }
       else
@@ -610,7 +611,7 @@ gtk_label_new (const gchar *str)
 {
   GtkLabel *label;
   
-  label = gtk_type_new (GTK_TYPE_LABEL);
+  label = g_object_new (GTK_TYPE_LABEL, NULL);
 
   if (str && *str)
     gtk_label_set_text (label, str);
@@ -646,7 +647,7 @@ gtk_label_new_with_mnemonic (const gchar *str)
 {
   GtkLabel *label;
   
-  label = gtk_type_new (GTK_TYPE_LABEL);
+  label = g_object_new (GTK_TYPE_LABEL, NULL);
 
   if (str && *str)
     gtk_label_set_text_with_mnemonic (label, str);
@@ -683,7 +684,7 @@ gtk_label_mnemonic_activate (GtkWidget *widget,
 
   /* barf if there was nothing to activate */
   g_warning ("Couldn't find a target for a mnemonic activation.");
-  gdk_beep ();
+  gdk_display_beep (gtk_widget_get_display (widget));
   
   return FALSE;
 }
@@ -720,10 +721,26 @@ gtk_label_hierarchy_changed (GtkWidget *widget,
                             GtkWidget *old_toplevel)
 {
   GtkLabel *label = GTK_LABEL (widget);
-  
+
   gtk_label_setup_mnemonic (label, label->mnemonic_keyval);
 }
 
+static void
+gtk_label_screen_changed (GtkWidget *widget,
+                         GdkScreen *old_screen)
+{
+  gtk_label_clear_layout (GTK_LABEL (widget));
+}
+
+static void
+label_mnemonic_widget_weak_notify (gpointer      data,
+                                  GObject      *where_the_object_was)
+{
+  GtkLabel *label = data;
+
+  label->mnemonic_widget = NULL;
+  g_object_notify (G_OBJECT (label), "mnemonic_widget");
+}
 
 /**
  * gtk_label_set_mnemonic_widget:
@@ -753,10 +770,16 @@ gtk_label_set_mnemonic_widget (GtkLabel  *label,
     g_return_if_fail (GTK_IS_WIDGET (widget));
 
   if (label->mnemonic_widget)
-    gtk_widget_unref (label->mnemonic_widget);
+    g_object_weak_unref (G_OBJECT (label->mnemonic_widget),
+                        label_mnemonic_widget_weak_notify,
+                        label);
   label->mnemonic_widget = widget;
   if (label->mnemonic_widget)
-    gtk_widget_ref (label->mnemonic_widget);
+    g_object_weak_ref (G_OBJECT (label->mnemonic_widget),
+                      label_mnemonic_widget_weak_notify,
+                      label);
+  
+  g_object_notify (G_OBJECT (label), "mnemonic_widget");
 }
 
 /**
@@ -915,11 +938,15 @@ gtk_label_set_text (GtkLabel    *label,
 {
   g_return_if_fail (GTK_IS_LABEL (label));
   
+  g_object_freeze_notify (G_OBJECT (label));
+
   gtk_label_set_label_internal (label, g_strdup (str ? str : ""));
   gtk_label_set_use_markup_internal (label, FALSE);
   gtk_label_set_use_underline_internal (label, FALSE);
   
   gtk_label_recalculate (label);
+
+  g_object_thaw_notify (G_OBJECT (label));
 }
 
 /**
@@ -929,7 +956,8 @@ gtk_label_set_text (GtkLabel    *label,
  * 
  * Sets a #PangoAttrList; the attributes in the list are applied to the
  * label text. The attributes set with this function will be ignored
- * if label->use_underline or label->use_markup is %TRUE.
+ * if the "use_underline" property or the "use_markup" property
+ * is %TRUE.
  **/
 void
 gtk_label_set_attributes (GtkLabel         *label,
@@ -1307,7 +1335,7 @@ gtk_label_finalize (GObject *object)
   g_free (label->text);
 
   if (label->layout)
-    g_object_unref (G_OBJECT (label->layout));
+    g_object_unref (label->layout);
 
   if (label->attrs)
     pango_attr_list_unref (label->attrs);
@@ -1325,11 +1353,56 @@ gtk_label_clear_layout (GtkLabel *label)
 {
   if (label->layout)
     {
-      g_object_unref (G_OBJECT (label->layout));
+      g_object_unref (label->layout);
       label->layout = NULL;
     }
 }
 
+typedef struct _LabelWrapWidth LabelWrapWidth;
+struct _LabelWrapWidth
+{
+  gint width;
+  PangoFontDescription *font_desc;
+};
+
+static void
+label_wrap_width_free (gpointer data)
+{
+  LabelWrapWidth *wrap_width = data;
+  pango_font_description_free (wrap_width->font_desc);
+  g_free (wrap_width);
+}
+
+static gint
+get_label_wrap_width (GtkLabel *label)
+{
+  PangoLayout *layout;
+  GtkStyle *style = GTK_WIDGET (label)->style;
+
+  LabelWrapWidth *wrap_width = g_object_get_data (G_OBJECT (style), "gtk-label-wrap-width");
+  if (!wrap_width)
+    {
+      wrap_width = g_new0 (LabelWrapWidth, 1);
+      g_object_set_data_full (G_OBJECT (style), "gtk-label-wrap-width",
+                             wrap_width, label_wrap_width_free);
+    }
+
+  if (wrap_width->font_desc && pango_font_description_equal (wrap_width->font_desc, style->font_desc))
+    return wrap_width->width;
+
+  if (wrap_width->font_desc)
+    pango_font_description_free (wrap_width->font_desc);
+
+  wrap_width->font_desc = pango_font_description_copy (style->font_desc);
+
+  layout = gtk_widget_create_pango_layout (GTK_WIDGET (label), 
+                                          "This long string gives a good enough length for any line to have.");
+  pango_layout_get_size (layout, &wrap_width->width, NULL);
+  g_object_unref (layout);
+
+  return wrap_width->width;
+}
+
 static void
 gtk_label_ensure_layout (GtkLabel *label)
 {
@@ -1384,6 +1457,9 @@ gtk_label_ensure_layout (GtkLabel *label)
            pango_layout_set_width (label->layout, aux_info->width * PANGO_SCALE);
          else
            {
+             GdkScreen *screen = gtk_widget_get_screen (GTK_WIDGET (label));
+             gint wrap_width;
+             
              pango_layout_set_width (label->layout, -1);
              pango_layout_get_extents (label->layout, NULL, &logical_rect);
 
@@ -1391,15 +1467,15 @@ gtk_label_ensure_layout (GtkLabel *label)
              
              /* Try to guess a reasonable maximum width */
              longest_paragraph = width;
-             
-             width = MIN (width,
-                          PANGO_SCALE * gdk_string_width (gtk_style_get_font (GTK_WIDGET (label)->style),
-                                                          "This long string gives a good enough length for any line to have."));
+
+             wrap_width = get_label_wrap_width (label);
+             width = MIN (width, wrap_width);
              width = MIN (width,
-                          PANGO_SCALE * (gdk_screen_width () + 1) / 2);
+                          PANGO_SCALE * (gdk_screen_get_width (screen) + 1) / 2);
              
              pango_layout_set_width (label->layout, width);
              pango_layout_get_extents (label->layout, NULL, &logical_rect);
+             width = logical_rect.width;
              height = logical_rect.height;
              
              /* Unfortunately, the above may leave us with a very unbalanced looking paragraph,
@@ -1418,7 +1494,7 @@ gtk_label_ensure_layout (GtkLabel *label)
                      pango_layout_get_extents (label->layout, NULL, &logical_rect);
                      
                      if (logical_rect.height <= height)
-                       width = perfect_width;
+                       width = logical_rect.width;
                      else
                        {
                          gint mid_width = (perfect_width + width) / 2;
@@ -1429,7 +1505,7 @@ gtk_label_ensure_layout (GtkLabel *label)
                              pango_layout_get_extents (label->layout, NULL, &logical_rect);
                              
                              if (logical_rect.height <= height)
-                               width = mid_width;
+                               width = logical_rect.width;
                            }
                        }
                    }
@@ -1600,15 +1676,21 @@ get_layout_location (GtkLabel  *label,
     xalign = misc->xalign;
   else
     xalign = 1.0 - misc->xalign;
-  
-  x = floor (widget->allocation.x + (gint)misc->xpad
-             + ((widget->allocation.width - widget->requisition.width) * xalign)
-             + 0.5);
-  
+
+  x = floor (widget->allocation.x + (gint)misc->xpad +
+            xalign * (widget->allocation.width - widget->requisition.width)
+            + 0.5);
+
+  if (gtk_widget_get_direction (widget) == GTK_TEXT_DIR_LTR)
+    x = MAX (x, widget->allocation.x + misc->xpad);
+  else
+    x = MIN (x,
+            widget->allocation.x + widget->allocation.width -
+            widget->requisition.width - misc->xpad);
+
   y = floor (widget->allocation.y + (gint)misc->ypad 
-             + ((widget->allocation.height - widget->requisition.height) * misc->yalign)
-             + 0.5);
-  
+             + MAX (((widget->allocation.height - widget->requisition.height) * misc->yalign)
+                   + 0.5, 0));
 
   if (xp)
     *xp = x;
@@ -1636,11 +1718,10 @@ gtk_label_draw_cursor (GtkLabel  *label, gint xoffset, gint yoffset)
       GdkRectangle cursor_location;
       GtkTextDirection dir1 = GTK_TEXT_DIR_NONE;
       GtkTextDirection dir2 = GTK_TEXT_DIR_NONE;
-      GdkGC *gc1 = NULL;
-      GdkGC *gc2 = NULL;
+      GdkGC *gc;
 
       keymap_direction =
-       (gdk_keymap_get_direction (gdk_keymap_get_default ()) == PANGO_DIRECTION_LTR) ?
+       (gdk_keymap_get_direction (gdk_keymap_get_for_display (gtk_widget_get_display (widget))) == PANGO_DIRECTION_LTR) ?
        GTK_TEXT_DIR_LTR : GTK_TEXT_DIR_RTL;
 
       widget_direction = gtk_widget_get_direction (widget);
@@ -1654,25 +1735,21 @@ gtk_label_draw_cursor (GtkLabel  *label, gint xoffset, gint yoffset)
                    "gtk-split-cursor", &split_cursor,
                    NULL);
 
+      dir1 = widget_direction;
+      
       if (split_cursor)
        {
-         gc1 = label->select_info->cursor_gc;
          cursor1 = &strong_pos;
 
          if (strong_pos.x != weak_pos.x ||
              strong_pos.y != weak_pos.y)
            {
-             dir1 = widget_direction;
              dir2 = (widget_direction == GTK_TEXT_DIR_LTR) ? GTK_TEXT_DIR_RTL : GTK_TEXT_DIR_LTR;
-             
-             gc2 = widget->style->black_gc;
              cursor2 = &weak_pos;
            }
        }
       else
        {
-         gc1 = label->select_info->cursor_gc;
-         
          if (keymap_direction == widget_direction)
            cursor1 = &strong_pos;
          else
@@ -1683,19 +1760,24 @@ gtk_label_draw_cursor (GtkLabel  *label, gint xoffset, gint yoffset)
       cursor_location.y = yoffset + PANGO_PIXELS (cursor1->y);
       cursor_location.width = 0;
       cursor_location.height = PANGO_PIXELS (cursor1->height);
+
+      gc = _gtk_get_insertion_cursor_gc (widget, TRUE);
+      _gtk_draw_insertion_cursor (widget, widget->window, gc,
+                                 &cursor_location, dir1,
+                                  dir2 != GTK_TEXT_DIR_NONE);
+      g_object_unref (gc);
       
-      _gtk_draw_insertion_cursor (widget->window, gc1,
-                                 &cursor_location, dir1);
-      
-      if (gc2)
+      if (dir2 != GTK_TEXT_DIR_NONE)
        {
          cursor_location.x = xoffset + PANGO_PIXELS (cursor2->x);
          cursor_location.y = yoffset + PANGO_PIXELS (cursor2->y);
          cursor_location.width = 0;
          cursor_location.height = PANGO_PIXELS (cursor2->height);
-         
-         _gtk_draw_insertion_cursor (widget->window, gc2,
-                                     &cursor_location, dir2);
+
+         gc = _gtk_get_insertion_cursor_gc (widget, FALSE);
+         _gtk_draw_insertion_cursor (widget, widget->window, gc,
+                                     &cursor_location, dir2, TRUE);
+         g_object_unref (gc);
        }
     }
 }
@@ -1796,8 +1878,10 @@ gtk_label_set_uline_text_internal (GtkLabel    *label,
   g_return_if_fail (GTK_IS_LABEL (label));
   g_return_if_fail (str != NULL);
 
-  /* Convert text to wide characters */
-
+  /* Split text into the base text and a separate pattern
+   * of underscores.
+   */
+  
   new_str = g_new (gchar, strlen (str) + 1);
   pattern = g_new (gchar, g_utf8_strlen (str, -1) + 1);
   
@@ -1833,7 +1917,7 @@ gtk_label_set_uline_text_internal (GtkLabel    *label,
            {
              *pattern_dest++ = '_';
              if (accel_key == GDK_VoidSymbol)
-               accel_key = gdk_keyval_to_lower (c);
+               accel_key = gdk_keyval_to_lower (gdk_unicode_to_keyval (c));
            }
 
          while (src < next_src)
@@ -1879,6 +1963,8 @@ gtk_label_parse_uline (GtkLabel    *label,
   g_return_val_if_fail (str != NULL, GDK_VoidSymbol);
 
   orig_keyval = label->mnemonic_keyval;
+
+  g_object_freeze_notify (G_OBJECT (label));
   
   gtk_label_set_label_internal (label, g_strdup (str ? str : ""));
   gtk_label_set_use_markup_internal (label, FALSE);
@@ -1891,6 +1977,8 @@ gtk_label_parse_uline (GtkLabel    *label,
   
   gtk_label_setup_mnemonic (label, orig_keyval);
   
+  g_object_thaw_notify (G_OBJECT (label));
+
   return keyval;
 }
 
@@ -1915,7 +2003,9 @@ gtk_label_set_text_with_mnemonic (GtkLabel    *label,
   g_return_if_fail (str != NULL);
 
   last_keyval = label->mnemonic_keyval;
-  
+
+  g_object_freeze_notify (G_OBJECT (label));
+
   gtk_label_set_label_internal (label, g_strdup (str ? str : ""));
   gtk_label_set_use_markup_internal (label, FALSE);
   gtk_label_set_use_underline_internal (label, TRUE);
@@ -1923,26 +2013,8 @@ gtk_label_set_text_with_mnemonic (GtkLabel    *label,
   gtk_label_recalculate (label);
 
   gtk_label_setup_mnemonic (label, last_keyval);
-}
 
-static void
-gtk_label_realize_cursor_gc (GtkLabel *label)
-{
-  GdkColor *cursor_color;
-  GdkColor red = {0, 0xffff, 0x0000, 0x0000};
-
-  if (label->select_info == NULL)
-    return;
-  
-  if (label->select_info->cursor_gc)
-    gdk_gc_unref (label->select_info->cursor_gc);
-
-  gtk_widget_style_get (GTK_WIDGET (label), "cursor_color", &cursor_color, NULL);
-  label->select_info->cursor_gc = gdk_gc_new (GTK_WIDGET (label)->window);
-  if (cursor_color)
-    gdk_gc_set_rgb_fg_color (label->select_info->cursor_gc, cursor_color);
-  else
-    gdk_gc_set_rgb_fg_color (label->select_info->cursor_gc, &red);
+  g_object_thaw_notify (G_OBJECT (label));
 }
 
 static void
@@ -1955,23 +2027,7 @@ gtk_label_realize (GtkWidget *widget)
   (* GTK_WIDGET_CLASS (parent_class)->realize) (widget);
 
   if (label->select_info)
-    {
-      gtk_label_create_window (label);
-      gtk_label_realize_cursor_gc (label);
-    }
-}
-
-static void
-gtk_label_unrealize_cursor_gc (GtkLabel *label)
-{
-  if (label->select_info == NULL)
-    return;
-  
-  if (label->select_info->cursor_gc)
-    {
-      gdk_gc_unref (label->select_info->cursor_gc);
-      label->select_info->cursor_gc = NULL;
-    }
+    gtk_label_create_window (label);
 }
 
 static void
@@ -1982,10 +2038,7 @@ gtk_label_unrealize (GtkWidget *widget)
   label = GTK_LABEL (widget);
 
   if (label->select_info)
-    {
-      gtk_label_unrealize_cursor_gc (label);
-      gtk_label_destroy_window (label);
-    }
+    gtk_label_destroy_window (label);
   
   (* GTK_WIDGET_CLASS (parent_class)->unrealize) (widget);
 }
@@ -2143,7 +2196,7 @@ gtk_label_button_press (GtkWidget      *widget,
 
       if (event->type == GDK_3BUTTON_PRESS)
        {
-         gtk_label_select_region_index (label, 0, strlen (label->label));
+         gtk_label_select_region_index (label, 0, strlen (label->text));
          return TRUE;
        }
       
@@ -2183,7 +2236,7 @@ gtk_label_button_press (GtkWidget      *widget,
       else
        {
          if (event->type == GDK_3BUTTON_PRESS)
-             gtk_label_select_region_index (label, 0, strlen (label->label));
+             gtk_label_select_region_index (label, 0, strlen (label->text));
          else if (event->type == GDK_2BUTTON_PRESS)
              gtk_label_select_word (label);
          else 
@@ -2275,7 +2328,8 @@ gtk_label_create_window (GtkLabel *label)
   attributes.window_type = GDK_WINDOW_TEMP;
   attributes.wclass = GDK_INPUT_ONLY;
   attributes.override_redirect = TRUE;
-  attributes.cursor = gdk_cursor_new (GDK_XTERM);
+  attributes.cursor = gdk_cursor_new_for_display (gtk_widget_get_display (widget),
+                                                 GDK_XTERM);
   attributes.event_mask = gtk_widget_get_events (widget) |
     GDK_BUTTON_PRESS_MASK        |
     GDK_BUTTON_RELEASE_MASK      |
@@ -2332,10 +2386,7 @@ gtk_label_set_selectable (GtkLabel *label,
          GTK_WIDGET_SET_FLAGS (label, GTK_CAN_FOCUS);
       
           if (GTK_WIDGET_REALIZED (label))
-           {
-             gtk_label_create_window (label);
-             gtk_label_realize_cursor_gc (label);
-           }
+           gtk_label_create_window (label);
 
           if (GTK_WIDGET_MAPPED (label))
             gdk_window_show (label->select_info->window);
@@ -2348,8 +2399,6 @@ gtk_label_set_selectable (GtkLabel *label,
           /* unselect, to give up the selection */
           gtk_label_select_region (label, 0, 0);
           
-         gtk_label_unrealize_cursor_gc (label);
-         
           if (label->select_info->window)
            {
              gtk_label_destroy_window (label);
@@ -2466,7 +2515,8 @@ gtk_label_select_region_index (GtkLabel *label,
       label->select_info->selection_anchor = anchor_index;
       label->select_info->selection_end = end_index;
 
-      clipboard = gtk_clipboard_get (GDK_SELECTION_PRIMARY);      
+      clipboard = gtk_widget_get_clipboard (GTK_WIDGET (label),
+                                           GDK_SELECTION_PRIMARY);      
       
       if (anchor_index != end_index)
         {
@@ -2735,8 +2785,9 @@ get_better_cursor (GtkLabel *label,
                   gint      *x,
                   gint      *y)
 {
+  GdkKeymap *keymap = gdk_keymap_get_for_display (gtk_widget_get_display (GTK_WIDGET (label)));
   GtkTextDirection keymap_direction =
-    (gdk_keymap_get_direction (gdk_keymap_get_default ()) == PANGO_DIRECTION_LTR) ?
+    (gdk_keymap_get_direction (keymap) == PANGO_DIRECTION_LTR) ?
     GTK_TEXT_DIR_LTR : GTK_TEXT_DIR_RTL;
   GtkTextDirection widget_direction = gtk_widget_get_direction (GTK_WIDGET (label));
   gboolean split_cursor;
@@ -2777,10 +2828,10 @@ gtk_label_move_logically (GtkLabel *label,
                          gint      start,
                          gint      count)
 {
-  gint offset = g_utf8_pointer_to_offset (label->label,
-                                         label->label + start);
+  gint offset = g_utf8_pointer_to_offset (label->text,
+                                         label->text + start);
 
-  if (label->label)
+  if (label->text)
     {
       PangoLogAttr *log_attrs;
       gint n_attrs;
@@ -2788,7 +2839,7 @@ gtk_label_move_logically (GtkLabel *label,
 
       gtk_label_ensure_layout (label);
       
-      length = g_utf8_strlen (label->label, -1);
+      length = g_utf8_strlen (label->text, -1);
 
       pango_layout_get_log_attrs (label->layout, &log_attrs, &n_attrs);
 
@@ -2812,7 +2863,7 @@ gtk_label_move_logically (GtkLabel *label,
       g_free (log_attrs);
     }
 
-  return g_utf8_offset_to_pointer (label->label, offset) - label->label;
+  return g_utf8_offset_to_pointer (label->text, offset) - label->text;
 }
 
 static gint
@@ -2840,8 +2891,9 @@ gtk_label_move_visually (GtkLabel *label,
        strong = TRUE;
       else
        {
+         GdkKeymap *keymap = gdk_keymap_get_for_display (gtk_widget_get_display (GTK_WIDGET (label)));
          GtkTextDirection keymap_direction =
-           (gdk_keymap_get_direction (gdk_keymap_get_default ()) == PANGO_DIRECTION_LTR) ?
+           (gdk_keymap_get_direction (keymap) == PANGO_DIRECTION_LTR) ?
            GTK_TEXT_DIR_LTR : GTK_TEXT_DIR_RTL;
 
          strong = keymap_direction == gtk_widget_get_direction (GTK_WIDGET (label));
@@ -2864,7 +2916,7 @@ gtk_label_move_visually (GtkLabel *label,
       index = new_index;
       
       while (new_trailing--)
-       index = g_utf8_next_char (label->label + new_index) - label->label;
+       index = g_utf8_next_char (label->text + new_index) - label->text;
     }
   
   return index;
@@ -2874,11 +2926,11 @@ static gint
 gtk_label_move_forward_word (GtkLabel *label,
                             gint      start)
 {
-  gint new_pos = g_utf8_pointer_to_offset (label->label,
-                                          label->label + start);
+  gint new_pos = g_utf8_pointer_to_offset (label->text,
+                                          label->text + start);
   gint length;
 
-  length = g_utf8_strlen (label->label, -1);
+  length = g_utf8_strlen (label->text, -1);
   if (new_pos < length)
     {
       PangoLogAttr *log_attrs;
@@ -2896,7 +2948,7 @@ gtk_label_move_forward_word (GtkLabel *label,
       g_free (log_attrs);
     }
 
-  return g_utf8_offset_to_pointer (label->label, new_pos) - label->label;
+  return g_utf8_offset_to_pointer (label->text, new_pos) - label->text;
 }
 
 
@@ -2904,11 +2956,11 @@ static gint
 gtk_label_move_backward_word (GtkLabel *label,
                              gint      start)
 {
-  gint new_pos = g_utf8_pointer_to_offset (label->label,
-                                          label->label + start);
+  gint new_pos = g_utf8_pointer_to_offset (label->text,
+                                          label->text + start);
   gint length;
 
-  length = g_utf8_strlen (label->label, -1);
+  length = g_utf8_strlen (label->text, -1);
   
   if (new_pos > 0)
     {
@@ -2928,7 +2980,7 @@ gtk_label_move_backward_word (GtkLabel *label,
       g_free (log_attrs);
     }
 
-  return g_utf8_offset_to_pointer (label->label, new_pos) - label->label;
+  return g_utf8_offset_to_pointer (label->text, new_pos) - label->text;
 }
 
 static void
@@ -2981,7 +3033,7 @@ gtk_label_move_cursor (GtkLabel       *label,
        case GTK_MOVEMENT_PARAGRAPH_ENDS:
        case GTK_MOVEMENT_BUFFER_ENDS:
          /* FIXME: Can do better here */
-         new_pos = count < 0 ? 0 : strlen (label->label);
+         new_pos = count < 0 ? 0 : strlen (label->text);
          break;
        case GTK_MOVEMENT_DISPLAY_LINES:
        case GTK_MOVEMENT_PARAGRAPHS:
@@ -3015,7 +3067,7 @@ gtk_label_move_cursor (GtkLabel       *label,
        case GTK_MOVEMENT_PARAGRAPH_ENDS:
        case GTK_MOVEMENT_BUFFER_ENDS:
          /* FIXME: Can do better here */
-         new_pos = count < 0 ? 0 : strlen (label->label);
+         new_pos = count < 0 ? 0 : strlen (label->text);
          break;
        case GTK_MOVEMENT_DISPLAY_LINES:
        case GTK_MOVEMENT_PARAGRAPHS:
@@ -3054,7 +3106,8 @@ gtk_label_copy_clipboard (GtkLabel *label)
         start = len;
 
       if (start != end)
-       gtk_clipboard_set_text (gtk_clipboard_get (GDK_SELECTION_CLIPBOARD),
+       gtk_clipboard_set_text (gtk_widget_get_clipboard (GTK_WIDGET (label),
+                                                         GDK_SELECTION_CLIPBOARD),
                                label->text + start, end - start);
     }
 }
@@ -3062,7 +3115,7 @@ gtk_label_copy_clipboard (GtkLabel *label)
 static void
 gtk_label_select_all (GtkLabel *label)
 {
-  gtk_label_select_region_index (label, 0, strlen (label->label));
+  gtk_label_select_region_index (label, 0, strlen (label->text));
 }
 
 /* Quick hack of a popup menu
@@ -3071,8 +3124,8 @@ static void
 activate_cb (GtkWidget *menuitem,
             GtkLabel  *label)
 {
-  const gchar *signal = gtk_object_get_data (GTK_OBJECT (menuitem), "gtk-signal");
-  gtk_signal_emit_by_name (GTK_OBJECT (label), signal);
+  const gchar *signal = g_object_get_data (G_OBJECT (menuitem), "gtk-signal");
+  g_signal_emit_by_name (label, signal);
 }
 
 static void
@@ -3084,9 +3137,9 @@ append_action_signal (GtkLabel     *label,
 {
   GtkWidget *menuitem = gtk_image_menu_item_new_from_stock (stock_id, NULL);
 
-  gtk_object_set_data (GTK_OBJECT (menuitem), "gtk-signal", (char *)signal);
-  gtk_signal_connect (GTK_OBJECT (menuitem), "activate",
-                     GTK_SIGNAL_FUNC (activate_cb), label);
+  g_object_set_data (G_OBJECT (menuitem), "gtk-signal", (char *)signal);
+  g_signal_connect (menuitem, "activate",
+                   G_CALLBACK (activate_cb), label);
 
   gtk_widget_set_sensitive (menuitem, sensitive);
   
@@ -3115,6 +3168,7 @@ popup_position_func (GtkMenu   *menu,
   GtkLabel *label;
   GtkWidget *widget;
   GtkRequisition req;
+  GdkScreen *screen;
   
   label = GTK_LABEL (user_data);  
   widget = GTK_WIDGET (label);
@@ -3123,7 +3177,8 @@ popup_position_func (GtkMenu   *menu,
     return;
   
   g_return_if_fail (GTK_WIDGET_REALIZED (label));
-
+  
+  screen = gtk_widget_get_screen (widget);
   gdk_window_get_origin (widget->window, x, y);      
 
   gtk_widget_size_request (label->select_info->popup_menu, &req);
@@ -3131,8 +3186,8 @@ popup_position_func (GtkMenu   *menu,
   *x += widget->allocation.width / 2;
   *y += widget->allocation.height;
 
-  *x = CLAMP (*x, 0, MAX (0, gdk_screen_width () - req.width));
-  *y = CLAMP (*y, 0, MAX (0, gdk_screen_height () - req.height));
+  *x = CLAMP (*x, 0, MAX (0, gdk_screen_get_width (screen) - req.width));
+  *y = CLAMP (*y, 0, MAX (0, gdk_screen_get_height (screen) - req.height));
 }
 
 
@@ -3167,8 +3222,8 @@ gtk_label_do_popup (GtkLabel       *label,
                         FALSE);
   
   menuitem = gtk_menu_item_new_with_label (_("Select All"));
-  gtk_signal_connect_object (GTK_OBJECT (menuitem), "activate",
-                            GTK_SIGNAL_FUNC (gtk_label_select_all), label);
+  g_signal_connect_swapped (menuitem, "activate",
+                           G_CALLBACK (gtk_label_select_all), label);
   gtk_widget_show (menuitem);
   gtk_menu_shell_append (GTK_MENU_SHELL (label->select_info->popup_menu), menuitem);
 
@@ -3182,9 +3237,10 @@ gtk_label_do_popup (GtkLabel       *label,
   gtk_widget_set_sensitive (menuitem, FALSE);
   gtk_menu_shell_append (GTK_MENU_SHELL (label->select_info->popup_menu), menuitem);
 
-  gtk_signal_emit (GTK_OBJECT (label),
-                   signals[POPULATE_POPUP],
-                   label->select_info->popup_menu);
+  g_signal_emit (label,
+                signals[POPULATE_POPUP],
+                0,
+                label->select_info->popup_menu);
   
   if (event)
     gtk_menu_popup (GTK_MENU (label->select_info->popup_menu), NULL, NULL,