]> Pileus Git - ~andy/gtk/blobdiff - gtk/gtkhandlebox.c
Apply a cleanup patch by Kjartan Maraas (#341812)
[~andy/gtk] / gtk / gtkhandlebox.c
index 31b817cb259a7aa061c81231bc0ee502f419ab05..fc1bd49c8001efeaecc1a4a994ffb8d85ad93021 100644 (file)
  * Copyright (C) 1998 Elliot Lee
  *
  * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Library General Public
+ * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Library General Public License for more details.
+ * Lesser General Public License for more details.
  *
- * You should have received a copy of the GNU Library General Public
- * License along with this library; if not, write to the Free
- * Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the
+ * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
+ * Boston, MA 02111-1307, USA.
  */
 
+/*
+ * Modified by the GTK+ Team and others 1997-2000.  See the AUTHORS
+ * file for a list of people on the GTK+ Team.  See the ChangeLog
+ * files for a list of changes.  These files are distributed with
+ * GTK+ at ftp://ftp.gtk.org/pub/gtk/. 
+ */
 
+#include <config.h>
 #include <stdlib.h>
-#include "gdk/gdkx.h"
 #include "gtkhandlebox.h"
+#include "gtkinvisible.h"
 #include "gtkmain.h"
-#include "gtksignal.h"
+#include "gtkmarshalers.h"
 #include "gtkwindow.h"
+#include "gtkprivate.h"
+#include "gtkintl.h"
+#include "gtkalias.h"
+
+typedef struct _GtkHandleBoxPrivate GtkHandleBoxPrivate;
 
+struct _GtkHandleBoxPrivate
+{
+  gint orig_x;
+  gint orig_y;
+};
+
+enum {
+  PROP_0,
+  PROP_SHADOW,
+  PROP_SHADOW_TYPE,
+  PROP_HANDLE_POSITION,
+  PROP_SNAP_EDGE,
+  PROP_SNAP_EDGE_SET
+};
 
 #define DRAG_HANDLE_SIZE 10
-#define BORDER_SIZE 5
+#define CHILDLESS_SIZE 25
 #define GHOST_HEIGHT 3
-#define SNAP_TOLERANCE 10
+#define TOLERANCE 5
 
+enum {
+  SIGNAL_CHILD_ATTACHED,
+  SIGNAL_CHILD_DETACHED,
+  SIGNAL_LAST
+};
 
-static void gtk_handle_box_class_init     (GtkHandleBoxClass *klass);
-static void gtk_handle_box_init           (GtkHandleBox      *handle_box);
+/* The algorithm for docking and redocking implemented here
+ * has a couple of nice properties:
+ *
+ * 1) During a single drag, docking always occurs at the
+ *    the same cursor position. This means that the users
+ *    motions are reversible, and that you won't
+ *    undock/dock oscillations.
+ *
+ * 2) Docking generally occurs at user-visible features.
+ *    The user, once they figure out to redock, will
+ *    have useful information about doing it again in
+ *    the future.
+ *
+ * Please try to preserve these properties if you
+ * change the algorithm. (And the current algorithm
+ * is far from ideal). Briefly, the current algorithm
+ * for deciding whether the handlebox is docked or not:
+ *
+ * 1) The decision is done by comparing two rectangles - the
+ *    allocation if the widget at the start of the drag,
+ *    and the boundary of hb->bin_window at the start of
+ *    of the drag offset by the distance that the cursor
+ *    has moved.
+ *
+ * 2) These rectangles must have one edge, the "snap_edge"
+ *    of the handlebox, aligned within TOLERANCE.
+ * 
+ * 3) On the other dimension, the extents of one rectangle
+ *    must be contained in the extents of the other,
+ *    extended by tolerance. That is, either we can have:
+ *
+ * <-TOLERANCE-|--------bin_window--------------|-TOLERANCE->
+ *         <--------float_window-------------------->
+ *
+ * or we can have:
+ *
+ * <-TOLERANCE-|------float_window--------------|-TOLERANCE->
+ *          <--------bin_window-------------------->
+ */
+
+static void gtk_handle_box_set_property   (GObject      *object,
+                                          guint         param_id,
+                                          const GValue *value,
+                                          GParamSpec   *pspec);
+static void gtk_handle_box_get_property   (GObject     *object,
+                                          guint        param_id,
+                                          GValue      *value,
+                                          GParamSpec  *pspec);
 static void gtk_handle_box_destroy        (GtkObject         *object);
 static void gtk_handle_box_map            (GtkWidget         *widget);
 static void gtk_handle_box_unmap          (GtkWidget         *widget);
 static void gtk_handle_box_realize        (GtkWidget         *widget);
 static void gtk_handle_box_unrealize      (GtkWidget         *widget);
+static void gtk_handle_box_style_set      (GtkWidget         *widget,
+                                          GtkStyle          *previous_style);
 static void gtk_handle_box_size_request   (GtkWidget         *widget,
                                           GtkRequisition    *requisition);
 static void gtk_handle_box_size_allocate  (GtkWidget         *widget,
-                                          GtkAllocation     *allocation);
-static void gtk_handle_box_draw_ghost     (GtkWidget         *widget);
+                                          GtkAllocation     *real_allocation);
+static void gtk_handle_box_add            (GtkContainer      *container,
+                                          GtkWidget         *widget);
+static void gtk_handle_box_remove         (GtkContainer      *container,
+                                          GtkWidget         *widget);
+static void gtk_handle_box_draw_ghost     (GtkHandleBox      *hb);
 static void gtk_handle_box_paint          (GtkWidget         *widget,
                                           GdkEventExpose    *event,
                                           GdkRectangle      *area);
-static void gtk_handle_box_draw           (GtkWidget         *widget,
-                                          GdkRectangle      *area);
 static gint gtk_handle_box_expose         (GtkWidget         *widget,
                                           GdkEventExpose    *event);
 static gint gtk_handle_box_button_changed (GtkWidget         *widget,
                                           GdkEventButton    *event);
 static gint gtk_handle_box_motion         (GtkWidget         *widget,
                                           GdkEventMotion    *event);
-static gint gtk_handle_box_delete_float   (GtkWidget         *widget,
-                                          GdkEvent          *event,
-                                          gpointer           data);
-
-
-static GtkBinClass *parent_class;
+static gint gtk_handle_box_delete_event   (GtkWidget         *widget,
+                                          GdkEventAny       *event);
+static void gtk_handle_box_reattach       (GtkHandleBox      *hb);
+static void gtk_handle_box_end_drag       (GtkHandleBox      *hb,
+                                          guint32            time);
 
+static guint        handle_box_signals[SIGNAL_LAST] = { 0 };
 
-guint
-gtk_handle_box_get_type (void)
-{
-  static guint handle_box_type = 0;
-
-  if (!handle_box_type)
-    {
-      GtkTypeInfo handle_box_info =
-      {
-       "GtkHandleBox",
-       sizeof (GtkHandleBox),
-       sizeof (GtkHandleBoxClass),
-       (GtkClassInitFunc) gtk_handle_box_class_init,
-       (GtkObjectInitFunc) gtk_handle_box_init,
-       (GtkArgSetFunc) NULL,
-        (GtkArgGetFunc) NULL,
-      };
-
-      handle_box_type = gtk_type_unique (gtk_bin_get_type (), &handle_box_info);
-    }
-
-  return handle_box_type;
-}
+G_DEFINE_TYPE (GtkHandleBox, gtk_handle_box, GTK_TYPE_BIN)
 
 static void
 gtk_handle_box_class_init (GtkHandleBoxClass *class)
 {
-  GtkWidgetClass *widget_class;
+  GObjectClass *gobject_class;
   GtkObjectClass *object_class;
+  GtkWidgetClass *widget_class;
+  GtkContainerClass *container_class;
 
+  gobject_class = (GObjectClass *) class;
   object_class = (GtkObjectClass *) class;
   widget_class = (GtkWidgetClass *) class;
+  container_class = (GtkContainerClass *) class;
 
-  parent_class = gtk_type_class (gtk_bin_get_type ());
+  gobject_class->set_property = gtk_handle_box_set_property;
+  gobject_class->get_property = gtk_handle_box_get_property;
+  
+  g_object_class_install_property (gobject_class,
+                                   PROP_SHADOW,
+                                   g_param_spec_enum ("shadow", NULL,
+                                                      P_("Deprecated property, use shadow_type instead"),
+                                                     GTK_TYPE_SHADOW_TYPE,
+                                                     GTK_SHADOW_ETCHED_OUT,
+                                                      GTK_PARAM_READWRITE));
+  g_object_class_install_property (gobject_class,
+                                   PROP_SHADOW_TYPE,
+                                   g_param_spec_enum ("shadow-type",
+                                                      P_("Shadow type"),
+                                                      P_("Appearance of the shadow that surrounds the container"),
+                                                     GTK_TYPE_SHADOW_TYPE,
+                                                     GTK_SHADOW_ETCHED_OUT,
+                                                      GTK_PARAM_READWRITE));
+  
+  g_object_class_install_property (gobject_class,
+                                   PROP_HANDLE_POSITION,
+                                   g_param_spec_enum ("handle-position",
+                                                      P_("Handle position"),
+                                                      P_("Position of the handle relative to the child widget"),
+                                                     GTK_TYPE_POSITION_TYPE,
+                                                     GTK_POS_LEFT,
+                                                      GTK_PARAM_READWRITE));
+  
+  g_object_class_install_property (gobject_class,
+                                   PROP_SNAP_EDGE,
+                                   g_param_spec_enum ("snap-edge",
+                                                      P_("Snap edge"),
+                                                      P_("Side of the handlebox that's lined up with the docking point to dock the handlebox"),
+                                                     GTK_TYPE_POSITION_TYPE,
+                                                     GTK_POS_TOP,
+                                                      GTK_PARAM_READWRITE));
+
+  g_object_class_install_property (gobject_class,
+                                   PROP_SNAP_EDGE_SET,
+                                   g_param_spec_boolean ("snap-edge-set",
+                                                        P_("Snap edge set"),
+                                                        P_("Whether to use the value from the snap_edge property or a value derived from handle_position"),
+                                                        FALSE,
+                                                        GTK_PARAM_READWRITE));
 
   object_class->destroy = gtk_handle_box_destroy;
 
@@ -104,53 +211,135 @@ gtk_handle_box_class_init (GtkHandleBoxClass *class)
   widget_class->unmap = gtk_handle_box_unmap;
   widget_class->realize = gtk_handle_box_realize;
   widget_class->unrealize = gtk_handle_box_unrealize;
+  widget_class->style_set = gtk_handle_box_style_set;
   widget_class->size_request = gtk_handle_box_size_request;
   widget_class->size_allocate = gtk_handle_box_size_allocate;
-  widget_class->draw = gtk_handle_box_draw;
   widget_class->expose_event = gtk_handle_box_expose;
   widget_class->button_press_event = gtk_handle_box_button_changed;
-  widget_class->button_release_event = gtk_handle_box_button_changed;
-  widget_class->motion_notify_event = gtk_handle_box_motion;
+  widget_class->delete_event = gtk_handle_box_delete_event;
+
+  container_class->add = gtk_handle_box_add;
+  container_class->remove = gtk_handle_box_remove;
+
+  class->child_attached = NULL;
+  class->child_detached = NULL;
+
+  handle_box_signals[SIGNAL_CHILD_ATTACHED] =
+    g_signal_new (I_("child_attached"),
+                 G_OBJECT_CLASS_TYPE (gobject_class),
+                 G_SIGNAL_RUN_FIRST,
+                 G_STRUCT_OFFSET (GtkHandleBoxClass, child_attached),
+                 NULL, NULL,
+                 _gtk_marshal_VOID__OBJECT,
+                 G_TYPE_NONE, 1,
+                 GTK_TYPE_WIDGET);
+  handle_box_signals[SIGNAL_CHILD_DETACHED] =
+    g_signal_new (I_("child_detached"),
+                 G_OBJECT_CLASS_TYPE (gobject_class),
+                 G_SIGNAL_RUN_FIRST,
+                 G_STRUCT_OFFSET (GtkHandleBoxClass, child_detached),
+                 NULL, NULL,
+                 _gtk_marshal_VOID__OBJECT,
+                 G_TYPE_NONE, 1,
+                 GTK_TYPE_WIDGET);
+
+  g_type_class_add_private (gobject_class, sizeof (GtkHandleBoxPrivate));    
+}
+
+static GtkHandleBoxPrivate *
+gtk_handle_box_get_private (GtkHandleBox *hb)
+{
+  return G_TYPE_INSTANCE_GET_PRIVATE (hb, GTK_TYPE_HANDLE_BOX, GtkHandleBoxPrivate);
 }
 
 static void
 gtk_handle_box_init (GtkHandleBox *handle_box)
 {
   GTK_WIDGET_UNSET_FLAGS (handle_box, GTK_NO_WINDOW);
-  GTK_WIDGET_SET_FLAGS (handle_box, GTK_BASIC); /* FIXME: are we really a basic widget? */
 
-  handle_box->steady_window = NULL;
+  handle_box->bin_window = NULL;
   handle_box->float_window = NULL;
-  handle_box->is_being_dragged = FALSE;
-  handle_box->is_onroot = FALSE;
-  handle_box->fleur_cursor = gdk_cursor_new (GDK_FLEUR);
-  handle_box->dragoff_x = 0;
-  handle_box->dragoff_y = 0;
-  handle_box->steady_x = 0;
-  handle_box->steady_x = 0;
+  handle_box->shadow_type = GTK_SHADOW_OUT;
+  handle_box->handle_position = GTK_POS_LEFT;
+  handle_box->float_window_mapped = FALSE;
+  handle_box->child_detached = FALSE;
+  handle_box->in_drag = FALSE;
+  handle_box->shrink_on_detach = TRUE;
+  handle_box->snap_edge = -1;
 }
 
+static void 
+gtk_handle_box_set_property (GObject         *object,
+                            guint            prop_id,
+                            const GValue    *value,
+                            GParamSpec      *pspec)
+{
+  GtkHandleBox *handle_box = GTK_HANDLE_BOX (object);
+
+  switch (prop_id)
+    {
+    case PROP_SHADOW:
+    case PROP_SHADOW_TYPE:
+      gtk_handle_box_set_shadow_type (handle_box, g_value_get_enum (value));
+      break;
+    case PROP_HANDLE_POSITION:
+      gtk_handle_box_set_handle_position (handle_box, g_value_get_enum (value));
+      break;
+    case PROP_SNAP_EDGE:
+      gtk_handle_box_set_snap_edge (handle_box, g_value_get_enum (value));
+      break;
+    case PROP_SNAP_EDGE_SET:
+      if (!g_value_get_boolean (value))
+       gtk_handle_box_set_snap_edge (handle_box, (GtkPositionType)-1);
+      break;
+    default:
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
+      break;
+    }
+}
+
+static void 
+gtk_handle_box_get_property (GObject         *object,
+                            guint            prop_id,
+                            GValue          *value,
+                            GParamSpec      *pspec)
+{
+  GtkHandleBox *handle_box = GTK_HANDLE_BOX (object);
+  
+  switch (prop_id)
+    {
+    case PROP_SHADOW:
+    case PROP_SHADOW_TYPE:
+      g_value_set_enum (value, handle_box->shadow_type);
+      break;
+    case PROP_HANDLE_POSITION:
+      g_value_set_enum (value, handle_box->handle_position);
+      break;
+    case PROP_SNAP_EDGE:
+      g_value_set_enum (value,
+                       (handle_box->snap_edge == -1 ?
+                        GTK_POS_TOP : handle_box->snap_edge));
+      break;
+    case PROP_SNAP_EDGE_SET:
+      g_value_set_boolean (value, handle_box->snap_edge != -1);
+      break;
+    default:
+      G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
+      break;
+    }
+}
 GtkWidget*
 gtk_handle_box_new (void)
 {
-  return GTK_WIDGET (gtk_type_new (gtk_handle_box_get_type ()));
+  return g_object_new (GTK_TYPE_HANDLE_BOX, NULL);
 }
 
 static void
 gtk_handle_box_destroy (GtkObject *object)
 {
-  GtkHandleBox *hb;
-
-  g_return_if_fail (object != NULL);
-  g_return_if_fail (GTK_IS_HANDLE_BOX (object));
-
-  hb = GTK_HANDLE_BOX (object);
-
-  gdk_cursor_destroy (hb->fleur_cursor);
-  hb->fleur_cursor = NULL;
-
-  if (GTK_OBJECT_CLASS (parent_class)->destroy)
-    (* GTK_OBJECT_CLASS (parent_class)->destroy) (object);
+  if (GTK_OBJECT_CLASS (gtk_handle_box_parent_class)->destroy)
+    (* GTK_OBJECT_CLASS (gtk_handle_box_parent_class)->destroy) (object);
 }
 
 static void
@@ -159,21 +348,24 @@ gtk_handle_box_map (GtkWidget *widget)
   GtkBin *bin;
   GtkHandleBox *hb;
 
-  g_return_if_fail (widget != NULL);
-  g_return_if_fail (GTK_IS_HANDLE_BOX (widget));
-
   GTK_WIDGET_SET_FLAGS (widget, GTK_MAPPED);
 
   bin = GTK_BIN (widget);
   hb = GTK_HANDLE_BOX (widget);
 
-  gdk_window_show (hb->steady_window);
-  gdk_window_show (widget->window);
-
-  if (bin->child
-      && GTK_WIDGET_VISIBLE (bin->child)
-      && !GTK_WIDGET_MAPPED (bin->child))
+  if (bin->child &&
+      GTK_WIDGET_VISIBLE (bin->child) &&
+      !GTK_WIDGET_MAPPED (bin->child))
     gtk_widget_map (bin->child);
+
+  if (hb->child_detached && !hb->float_window_mapped)
+    {
+      gdk_window_show (hb->float_window);
+      hb->float_window_mapped = TRUE;
+    }
+
+  gdk_window_show (hb->bin_window);
+  gdk_window_show (widget->window);
 }
 
 static void
@@ -181,15 +373,16 @@ gtk_handle_box_unmap (GtkWidget *widget)
 {
   GtkHandleBox *hb;
 
-  g_return_if_fail (widget != NULL);
-  g_return_if_fail (GTK_IS_HANDLE_BOX (widget));
-
   GTK_WIDGET_UNSET_FLAGS (widget, GTK_MAPPED);
 
   hb = GTK_HANDLE_BOX (widget);
 
   gdk_window_hide (widget->window);
-  gdk_window_hide (hb->steady_window);
+  if (hb->float_window_mapped)
+    {
+      gdk_window_hide (hb->float_window);
+      hb->float_window_mapped = FALSE;
+    }
 }
 
 static void
@@ -199,26 +392,10 @@ gtk_handle_box_realize (GtkWidget *widget)
   gint attributes_mask;
   GtkHandleBox *hb;
 
-  g_return_if_fail (widget != NULL);
-  g_return_if_fail (GTK_IS_HANDLE_BOX (widget));
-
   hb = GTK_HANDLE_BOX (widget);
 
   GTK_WIDGET_SET_FLAGS (widget, GTK_REALIZED);
 
-  /* FIXME: we need a property that would tell the window manager not
-   * to put decoration on this window.  This is not part of the ICCCM,
-   * so we'll have to define our own (a la KWM) and hack some window
-   * managers to support it.
-   */
-
-  hb->float_window = gtk_window_new (GTK_WINDOW_DIALOG);
-  gtk_window_set_policy (GTK_WINDOW (hb->float_window), FALSE, FALSE, TRUE);
-  gtk_container_border_width (GTK_CONTAINER (hb->float_window), 0);
-  gtk_signal_connect (GTK_OBJECT (hb->float_window), "delete_event",
-                     (GtkSignalFunc) gtk_handle_box_delete_float,
-                     hb);
-  
   attributes.x = widget->allocation.x;
   attributes.y = widget->allocation.y;
   attributes.width = widget->allocation.width;
@@ -229,57 +406,111 @@ gtk_handle_box_realize (GtkWidget *widget)
   attributes.colormap = gtk_widget_get_colormap (widget);
   attributes.event_mask = (gtk_widget_get_events (widget)
                           | GDK_EXPOSURE_MASK);
-
   attributes_mask = GDK_WA_X | GDK_WA_Y | GDK_WA_VISUAL | GDK_WA_COLORMAP;
-
-  hb->steady_window = gdk_window_new (gtk_widget_get_parent_window (widget), &attributes, attributes_mask);
-  gdk_window_set_user_data (hb->steady_window, widget);
+  widget->window = gdk_window_new (gtk_widget_get_parent_window (widget), &attributes, attributes_mask);
+  gdk_window_set_user_data (widget->window, widget);
 
   attributes.x = 0;
   attributes.y = 0;
-  attributes.event_mask |= (GDK_BUTTON1_MOTION_MASK
-                           | GDK_POINTER_MOTION_HINT_MASK
-                           | GDK_BUTTON_PRESS_MASK
-                           | GDK_BUTTON_RELEASE_MASK);
-
-  widget->window = gdk_window_new (hb->steady_window, &attributes, attributes_mask);
-  gdk_window_set_user_data (widget->window, widget);
-
+  attributes.width = widget->allocation.width;
+  attributes.height = widget->allocation.height;
+  attributes.window_type = GDK_WINDOW_CHILD;
+  attributes.event_mask = (gtk_widget_get_events (widget) |
+                          GDK_EXPOSURE_MASK |
+                          GDK_BUTTON1_MOTION_MASK |
+                          GDK_POINTER_MOTION_HINT_MASK |
+                          GDK_BUTTON_PRESS_MASK |
+                           GDK_BUTTON_RELEASE_MASK);
+  attributes_mask = GDK_WA_X | GDK_WA_Y | GDK_WA_VISUAL | GDK_WA_COLORMAP;
+  hb->bin_window = gdk_window_new (widget->window, &attributes, attributes_mask);
+  gdk_window_set_user_data (hb->bin_window, widget);
+  if (GTK_BIN (hb)->child)
+    gtk_widget_set_parent_window (GTK_BIN (hb)->child, hb->bin_window);
+  
+  attributes.x = 0;
+  attributes.y = 0;
+  attributes.width = widget->requisition.width;
+  attributes.height = widget->requisition.height;
+  attributes.window_type = GDK_WINDOW_TOPLEVEL;
+  attributes.wclass = GDK_INPUT_OUTPUT;
+  attributes.visual = gtk_widget_get_visual (widget);
+  attributes.colormap = gtk_widget_get_colormap (widget);
+  attributes.event_mask = (gtk_widget_get_events (widget) |
+                          GDK_KEY_PRESS_MASK |
+                          GDK_ENTER_NOTIFY_MASK |
+                          GDK_LEAVE_NOTIFY_MASK |
+                          GDK_FOCUS_CHANGE_MASK |
+                          GDK_STRUCTURE_MASK);
+  attributes_mask = GDK_WA_X | GDK_WA_Y | GDK_WA_VISUAL | GDK_WA_COLORMAP;
+  hb->float_window = gdk_window_new (gtk_widget_get_root_window (widget),
+                                    &attributes, attributes_mask);
+  gdk_window_set_user_data (hb->float_window, widget);
+  gdk_window_set_decorations (hb->float_window, 0);
+  gdk_window_set_type_hint (hb->float_window, GDK_WINDOW_TYPE_HINT_TOOLBAR);
+  
   widget->style = gtk_style_attach (widget->style, widget->window);
-  gtk_style_set_background (widget->style, hb->steady_window, GTK_STATE_NORMAL);
-  gtk_style_set_background (widget->style, widget->window, GTK_STATE_NORMAL);
+  gtk_style_set_background (widget->style, widget->window, GTK_WIDGET_STATE (hb));
+  gtk_style_set_background (widget->style, hb->bin_window, GTK_WIDGET_STATE (hb));
+  gtk_style_set_background (widget->style, hb->float_window, GTK_WIDGET_STATE (hb));
+  gdk_window_set_back_pixmap (widget->window, NULL, TRUE);
 }
 
 static void
 gtk_handle_box_unrealize (GtkWidget *widget)
 {
-  GtkHandleBox *hb;
-
-  g_return_if_fail (widget != NULL);
-  g_return_if_fail (GTK_IS_HANDLE_BOX (widget));
+  GtkHandleBox *hb = GTK_HANDLE_BOX (widget);
 
-  GTK_WIDGET_UNSET_FLAGS (widget, GTK_REALIZED | GTK_MAPPED);
+  gdk_window_set_user_data (hb->bin_window, NULL);
+  gdk_window_destroy (hb->bin_window);
+  hb->bin_window = NULL;
+  gdk_window_set_user_data (hb->float_window, NULL);
+  gdk_window_destroy (hb->float_window);
+  hb->float_window = NULL;
 
-  gtk_style_detach (widget->style);
+  if (GTK_WIDGET_CLASS (gtk_handle_box_parent_class)->unrealize)
+    (* GTK_WIDGET_CLASS (gtk_handle_box_parent_class)->unrealize) (widget);
+}
 
-  hb = GTK_HANDLE_BOX (widget);
+static void
+gtk_handle_box_style_set (GtkWidget *widget,
+                         GtkStyle  *previous_style)
+{
+  GtkHandleBox *hb = GTK_HANDLE_BOX (widget);
 
-  if (widget->window)
+  if (GTK_WIDGET_REALIZED (widget) &&
+      !GTK_WIDGET_NO_WINDOW (widget))
     {
-      gdk_window_set_user_data (widget->window, NULL);
-      gdk_window_destroy (widget->window);
-      widget->window = NULL;
+      gtk_style_set_background (widget->style, widget->window,
+                               widget->state);
+      gtk_style_set_background (widget->style, hb->bin_window, widget->state);
+      gtk_style_set_background (widget->style, hb->float_window, widget->state);
     }
+}
 
-  if (hb->steady_window)
+static int
+effective_handle_position (GtkHandleBox *hb)
+{
+  int handle_position;
+
+  if (gtk_widget_get_direction (GTK_WIDGET (hb)) == GTK_TEXT_DIR_LTR)
+    handle_position = hb->handle_position;
+  else
     {
-      gdk_window_set_user_data (hb->steady_window, NULL);
-      gdk_window_destroy (hb->steady_window);
-      hb->steady_window = NULL;
+      switch (hb->handle_position) 
+       {
+       case GTK_POS_LEFT:
+         handle_position = GTK_POS_RIGHT;
+         break;
+       case GTK_POS_RIGHT:
+         handle_position = GTK_POS_LEFT;
+         break;
+       default:
+         handle_position = hb->handle_position;
+         break;
+       }
     }
 
-  gtk_widget_destroy (hb->float_window);
-  hb->float_window = NULL;
+  return handle_position;
 }
 
 static void
@@ -288,29 +519,73 @@ gtk_handle_box_size_request (GtkWidget      *widget,
 {
   GtkBin *bin;
   GtkHandleBox *hb;
-
-  g_return_if_fail (widget != NULL);
-  g_return_if_fail (GTK_IS_HANDLE_BOX (widget));
-  g_return_if_fail (requisition != NULL);
+  GtkRequisition child_requisition;
+  gint handle_position;
 
   bin = GTK_BIN (widget);
   hb = GTK_HANDLE_BOX (widget);
 
-  requisition->width = DRAG_HANDLE_SIZE + GTK_CONTAINER (widget)->border_width * 2;
-  requisition->height = GTK_CONTAINER (widget)->border_width * 2;
+  handle_position = effective_handle_position (hb);
 
-  if (bin->child && GTK_WIDGET_VISIBLE (bin->child))
+  if (handle_position == GTK_POS_LEFT ||
+      handle_position == GTK_POS_RIGHT)
     {
-      gtk_widget_size_request (bin->child, &bin->child->requisition);
-
-      requisition->width += bin->child->requisition.width;
-      requisition->height += bin->child->requisition.height;
+      requisition->width = DRAG_HANDLE_SIZE;
+      requisition->height = 0;
+    }
+  else
+    {
+      requisition->width = 0;
+      requisition->height = DRAG_HANDLE_SIZE;
     }
 
-  hb->real_requisition = *requisition;
-  if (hb->is_onroot)
-      requisition->height = GHOST_HEIGHT;
-  /* FIXME: Should also set requisition->width to a small value? */
+  /* if our child is not visible, we still request its size, since we
+   * won't have any useful hint for our size otherwise.
+   */
+  if (bin->child)
+    gtk_widget_size_request (bin->child, &child_requisition);
+  else
+    {
+      child_requisition.width = 0;
+      child_requisition.height = 0;
+    }      
+
+  if (hb->child_detached)
+    {
+      /* FIXME: This doesn't work currently */
+      if (!hb->shrink_on_detach)
+       {
+         if (handle_position == GTK_POS_LEFT ||
+             handle_position == GTK_POS_RIGHT)
+           requisition->height += child_requisition.height;
+         else
+           requisition->width += child_requisition.width;
+       }
+      else
+       {
+         if (handle_position == GTK_POS_LEFT ||
+             handle_position == GTK_POS_RIGHT)
+           requisition->height += widget->style->ythickness;
+         else
+           requisition->width += widget->style->xthickness;
+       }
+    }
+  else
+    {
+      requisition->width += GTK_CONTAINER (widget)->border_width * 2;
+      requisition->height += GTK_CONTAINER (widget)->border_width * 2;
+      
+      if (bin->child)
+       {
+         requisition->width += child_requisition.width;
+         requisition->height += child_requisition.height;
+       }
+      else
+       {
+         requisition->width += CHILDLESS_SIZE;
+         requisition->height += CHILDLESS_SIZE;
+       }
+    }
 }
 
 static void
@@ -318,65 +593,93 @@ gtk_handle_box_size_allocate (GtkWidget     *widget,
                              GtkAllocation *allocation)
 {
   GtkBin *bin;
-  GtkAllocation child_allocation;
   GtkHandleBox *hb;
-  gint border_width;
-
-  g_return_if_fail (widget != NULL);
-  g_return_if_fail (GTK_IS_HANDLE_BOX (widget));
-  g_return_if_fail (allocation != NULL);
-
-  widget->allocation = *allocation;
+  GtkRequisition child_requisition;
+  gint handle_position;
+  
   bin = GTK_BIN (widget);
   hb = GTK_HANDLE_BOX (widget);
+  
+  handle_position = effective_handle_position (hb);
 
-  border_width = GTK_CONTAINER (widget)->border_width;
-
-  if (GTK_WIDGET_REALIZED (widget))
+  if (bin->child)
+    gtk_widget_get_child_requisition (bin->child, &child_requisition);
+  else
     {
-      if (!hb->is_onroot)
-       {
-         gdk_window_move_resize (hb->steady_window,
-                                 allocation->x + border_width,
-                                 allocation->y + border_width,
-                                 allocation->width - border_width * 2,
-                                 allocation->height - border_width * 2);
-         gdk_window_move_resize (widget->window,
-                                 0,
-                                 0,
-                                 allocation->width - border_width * 2,
-                                 allocation->height - border_width * 2);
-       }
-      else
-       {
-         gtk_widget_set_usize (hb->float_window,
-                               hb->real_requisition.width,
-                               hb->real_requisition.height);
-         gdk_window_resize (widget->window,
-                            hb->real_requisition.width,
-                            hb->real_requisition.height);
-         gdk_window_move_resize (hb->steady_window,
-                                 allocation->x + border_width,
-                                 allocation->y + border_width,
-                                 allocation->width - border_width * 2,
-                                 GHOST_HEIGHT);
-       }
-    }
+      child_requisition.width = 0;
+      child_requisition.height = 0;
+    }      
+      
+  widget->allocation = *allocation;
+
+  if (GTK_WIDGET_REALIZED (hb))
+    gdk_window_move_resize (widget->window,
+                           widget->allocation.x,
+                           widget->allocation.y,
+                           widget->allocation.width,
+                           widget->allocation.height);
+
 
   if (bin->child && GTK_WIDGET_VISIBLE (bin->child))
     {
-      child_allocation.x = DRAG_HANDLE_SIZE;
-      child_allocation.y = 0;
+      GtkAllocation child_allocation;
+      guint border_width;
+
+      border_width = GTK_CONTAINER (widget)->border_width;
+
+      child_allocation.x = border_width;
+      child_allocation.y = border_width;
+      if (handle_position == GTK_POS_LEFT)
+       child_allocation.x += DRAG_HANDLE_SIZE;
+      else if (handle_position == GTK_POS_TOP)
+       child_allocation.y += DRAG_HANDLE_SIZE;
 
-      if (hb->is_onroot)
+      if (hb->child_detached)
        {
-         child_allocation.width = hb->real_requisition.width - DRAG_HANDLE_SIZE;
-         child_allocation.height = hb->real_requisition.height;
+         guint float_width;
+         guint float_height;
+         
+         child_allocation.width = child_requisition.width;
+         child_allocation.height = child_requisition.height;
+         
+         float_width = child_allocation.width + 2 * border_width;
+         float_height = child_allocation.height + 2 * border_width;
+         
+         if (handle_position == GTK_POS_LEFT ||
+             handle_position == GTK_POS_RIGHT)
+           float_width += DRAG_HANDLE_SIZE;
+         else
+           float_height += DRAG_HANDLE_SIZE;
+
+         if (GTK_WIDGET_REALIZED (hb))
+           {
+             gdk_window_resize (hb->float_window,
+                                float_width,
+                                float_height);
+             gdk_window_move_resize (hb->bin_window,
+                                     0,
+                                     0,
+                                     float_width,
+                                     float_height);
+           }
        }
       else
        {
-         child_allocation.width = allocation->width - DRAG_HANDLE_SIZE - border_width * 2;
-         child_allocation.height = allocation->height - border_width * 2;
+         child_allocation.width = MAX (1, (gint)widget->allocation.width - 2 * border_width);
+         child_allocation.height = MAX (1, (gint)widget->allocation.height - 2 * border_width);
+
+         if (handle_position == GTK_POS_LEFT ||
+             handle_position == GTK_POS_RIGHT)
+           child_allocation.width -= DRAG_HANDLE_SIZE;
+         else
+           child_allocation.height -= DRAG_HANDLE_SIZE;
+         
+         if (GTK_WIDGET_REALIZED (hb))
+           gdk_window_move_resize (hb->bin_window,
+                                   0,
+                                   0,
+                                   widget->allocation.width,
+                                   widget->allocation.height);
        }
 
       gtk_widget_size_allocate (bin->child, &child_allocation);
@@ -384,108 +687,246 @@ gtk_handle_box_size_allocate (GtkWidget     *widget,
 }
 
 static void
-gtk_handle_box_draw_ghost (GtkWidget *widget)
+gtk_handle_box_draw_ghost (GtkHandleBox *hb)
 {
-  gtk_draw_hline (widget->style,
-                 GTK_HANDLE_BOX (widget)->steady_window,
-                 GTK_WIDGET_STATE (widget),
-                 0,
-                 widget->allocation.width - GTK_CONTAINER (widget)->border_width * 2,
-                 0);
+  GtkWidget *widget;
+  guint x;
+  guint y;
+  guint width;
+  guint height;
+  gint handle_position;
+
+  widget = GTK_WIDGET (hb);
+  
+  handle_position = effective_handle_position (hb);
+  if (handle_position == GTK_POS_LEFT ||
+      handle_position == GTK_POS_RIGHT)
+    {
+      x = handle_position == GTK_POS_LEFT ? 0 : widget->allocation.width - DRAG_HANDLE_SIZE;
+      y = 0;
+      width = DRAG_HANDLE_SIZE;
+      height = widget->allocation.height;
+    }
+  else
+    {
+      x = 0;
+      y = handle_position == GTK_POS_TOP ? 0 : widget->allocation.height - DRAG_HANDLE_SIZE;
+      width = widget->allocation.width;
+      height = DRAG_HANDLE_SIZE;
+    }
+  gtk_paint_shadow (widget->style,
+                   widget->window,
+                   GTK_WIDGET_STATE (widget),
+                   GTK_SHADOW_ETCHED_IN,
+                   NULL, widget, "handle",
+                   x,
+                   y,
+                   width,
+                   height);
+   if (handle_position == GTK_POS_LEFT ||
+       handle_position == GTK_POS_RIGHT)
+     gtk_paint_hline (widget->style,
+                     widget->window,
+                     GTK_WIDGET_STATE (widget),
+                     NULL, widget, "handlebox",
+                     handle_position == GTK_POS_LEFT ? DRAG_HANDLE_SIZE : 0,
+                     handle_position == GTK_POS_LEFT ? widget->allocation.width : widget->allocation.width - DRAG_HANDLE_SIZE,
+                     widget->allocation.height / 2);
+   else
+     gtk_paint_vline (widget->style,
+                     widget->window,
+                     GTK_WIDGET_STATE (widget),
+                     NULL, widget, "handlebox",
+                     handle_position == GTK_POS_TOP ? DRAG_HANDLE_SIZE : 0,
+                     handle_position == GTK_POS_TOP ? widget->allocation.height : widget->allocation.height - DRAG_HANDLE_SIZE,
+                     widget->allocation.width / 2);
 }
 
 static void
-gtk_handle_box_paint (GtkWidget      *widget,
-                     GdkEventExpose *event,
-                     GdkRectangle   *area)
+draw_textured_frame (GtkWidget *widget, GdkWindow *window, GdkRectangle *rect, GtkShadowType shadow,
+                    GdkRectangle *clip)
 {
-  GtkBin *bin;
-  GtkHandleBox *hb;
-  GdkRectangle child_area;
-  GdkEventExpose child_event;
-  gint x;
+   gtk_paint_handle (widget->style, window, GTK_STATE_NORMAL, shadow,
+                    clip, widget, "handlebox",
+                    rect->x, rect->y, rect->width, rect->height, 
+                    GTK_ORIENTATION_VERTICAL);
+}
 
-  bin = GTK_BIN (widget);
-  hb = GTK_HANDLE_BOX (widget);
+void
+gtk_handle_box_set_shadow_type (GtkHandleBox  *handle_box,
+                               GtkShadowType  type)
+{
+  g_return_if_fail (GTK_IS_HANDLE_BOX (handle_box));
 
-  if (event != NULL)
-    area = &event->area;
+  if ((GtkShadowType) handle_box->shadow_type != type)
+    {
+      handle_box->shadow_type = type;
+      g_object_notify (G_OBJECT (handle_box), "shadow-type");
+      gtk_widget_queue_resize (GTK_WIDGET (handle_box));
+    }
+}
 
-  for (x = 1; x < DRAG_HANDLE_SIZE; x += 3)
-    gtk_draw_vline (widget->style,
-                   widget->window,
-                   GTK_WIDGET_STATE (widget),
-                   0, hb->is_onroot ? hb->real_requisition.height : widget->allocation.height,
-                   x);
-
-  if (hb->is_onroot)
-    gtk_draw_shadow (widget->style,
-                    widget->window,
-                    GTK_WIDGET_STATE (widget),
-                    GTK_SHADOW_OUT,
-                    0, 0,
-                    hb->real_requisition.width,
-                    hb->real_requisition.height);
-  else
-    gtk_draw_shadow (widget->style,
-                    widget->window,
-                    GTK_WIDGET_STATE (widget),
-                    GTK_SHADOW_OUT,
-                    0, 0,
-                    widget->allocation.width,
-                    widget->allocation.height);
+/**
+ * gtk_handle_box_get_shadow_type:
+ * @handle_box: a #GtkHandleBox
+ * 
+ * Gets the type of shadow drawn around the handle box. See
+ * gtk_handle_box_set_shadow_type().
+ *
+ * Return value: the type of shadow currently drawn around the handle box.
+ **/
+GtkShadowType
+gtk_handle_box_get_shadow_type (GtkHandleBox *handle_box)
+{
+  g_return_val_if_fail (GTK_IS_HANDLE_BOX (handle_box), GTK_SHADOW_ETCHED_OUT);
 
-  if (bin->child)
+  return handle_box->shadow_type;
+}
+
+void        
+gtk_handle_box_set_handle_position  (GtkHandleBox    *handle_box,
+                                    GtkPositionType  position)
+{
+  g_return_if_fail (GTK_IS_HANDLE_BOX (handle_box));
+
+  if ((GtkPositionType) handle_box->handle_position != position)
     {
-      if (event == NULL) /* we were called from draw() */
-       {
-         if (gtk_widget_intersect (bin->child, area, &child_area))
-           gtk_widget_draw (bin->child, &child_area);
-       }
-      else /* we were called from expose() */
-       {
-         child_event = *event;
-         
-         if (GTK_WIDGET_NO_WINDOW (bin->child)
-             && gtk_widget_intersect (bin->child, &event->area, &child_event.area))
-           gtk_widget_event (bin->child, (GdkEvent *) &child_event);
-       }
+      handle_box->handle_position = position;
+      g_object_notify (G_OBJECT (handle_box), "handle-position");
+      gtk_widget_queue_resize (GTK_WIDGET (handle_box));
+    }
+}
+
+/**
+ * gtk_handle_box_get_handle_position:
+ * @handle_box: a #GtkHandleBox
+ *
+ * Gets the handle position of the handle box. See
+ * gtk_handle_box_set_handle_position().
+ *
+ * Return value: the current handle position.
+ **/
+GtkPositionType
+gtk_handle_box_get_handle_position (GtkHandleBox *handle_box)
+{
+  g_return_val_if_fail (GTK_IS_HANDLE_BOX (handle_box), GTK_POS_LEFT);
+
+  return handle_box->handle_position;
+}
+
+void        
+gtk_handle_box_set_snap_edge        (GtkHandleBox    *handle_box,
+                                    GtkPositionType  edge)
+{
+  g_return_if_fail (GTK_IS_HANDLE_BOX (handle_box));
+
+  if (handle_box->snap_edge != edge)
+    {
+      handle_box->snap_edge = edge;
+      
+      g_object_freeze_notify (G_OBJECT (handle_box));
+      g_object_notify (G_OBJECT (handle_box), "snap-edge");
+      g_object_notify (G_OBJECT (handle_box), "snap-edge-set");
+      g_object_thaw_notify (G_OBJECT (handle_box));
     }
 }
 
+/**
+ * gtk_handle_box_get_snap_edge:
+ * @handle_box: a #GtkHandleBox
+ * 
+ * Gets the edge used for determining reattachment of the handle box. See
+ * gtk_handle_box_set_snap_edge().
+ *
+ * Return value: the edge used for determining reattachment, or (GtkPositionType)-1 if this
+ *               is determined (as per default) from the handle position. 
+ **/
+GtkPositionType
+gtk_handle_box_get_snap_edge (GtkHandleBox *handle_box)
+{
+  g_return_val_if_fail (GTK_IS_HANDLE_BOX (handle_box), (GtkPositionType)-1);
+
+  return handle_box->snap_edge;
+}
+
 static void
-gtk_handle_box_draw (GtkWidget    *widget,
-                    GdkRectangle *area)
+gtk_handle_box_paint (GtkWidget      *widget,
+                 
+    GdkEventExpose *event,
+                     GdkRectangle   *area)
 {
-  GdkRectangle child_area;
+  GtkBin *bin;
   GtkHandleBox *hb;
+  guint width, height;
+  GdkRectangle rect;
+  GdkRectangle dest;
+  gint handle_position;
 
-  g_return_if_fail (widget != NULL);
-  g_return_if_fail (GTK_IS_HANDLE_BOX (widget));
-  g_return_if_fail (area != NULL);
-
+  bin = GTK_BIN (widget);
   hb = GTK_HANDLE_BOX (widget);
 
-  if (GTK_WIDGET_DRAWABLE (widget))
-    {
-      if (hb->is_onroot)
-       {
-         /* The area parameter does not make sense in this case, so we
-          * repaint everything.
-          */
+  handle_position = effective_handle_position (hb);
 
-         gtk_handle_box_draw_ghost (widget);
+  gdk_drawable_get_size (hb->bin_window, &width, &height);
+  
+  if (!event)
+    gtk_paint_box (widget->style,
+                  hb->bin_window,
+                  GTK_WIDGET_STATE (widget),
+                  hb->shadow_type,
+                  area, widget, "handlebox_bin",
+                  0, 0, -1, -1);
+  else
+   gtk_paint_box (widget->style,
+                 hb->bin_window,
+                 GTK_WIDGET_STATE (widget),
+                 hb->shadow_type,
+                 &event->area, widget, "handlebox_bin",
+                 0, 0, -1, -1);
 
-         child_area.x = 0;
-         child_area.y = 0;
-         child_area.width = hb->real_requisition.width;
-         child_area.height = hb->real_requisition.height;
+/* We currently draw the handle _above_ the relief of the handlebox.
+ * it could also be drawn on the same level...
 
-         gtk_handle_box_paint (widget, NULL, &child_area);
-       }
-      else
-       gtk_handle_box_paint (widget, NULL, area);
+                hb->handle_position == GTK_POS_LEFT ? DRAG_HANDLE_SIZE : 0,
+                hb->handle_position == GTK_POS_TOP ? DRAG_HANDLE_SIZE : 0,
+                width,
+                height);*/
+
+  switch (handle_position)
+    {
+    case GTK_POS_LEFT:
+      rect.x = 0;
+      rect.y = 0; 
+      rect.width = DRAG_HANDLE_SIZE;
+      rect.height = height;
+      break;
+    case GTK_POS_RIGHT:
+      rect.x = width - DRAG_HANDLE_SIZE; 
+      rect.y = 0;
+      rect.width = DRAG_HANDLE_SIZE;
+      rect.height = height;
+      break;
+    case GTK_POS_TOP:
+      rect.x = 0;
+      rect.y = 0; 
+      rect.width = width;
+      rect.height = DRAG_HANDLE_SIZE;
+      break;
+    case GTK_POS_BOTTOM:
+      rect.x = 0;
+      rect.y = height - DRAG_HANDLE_SIZE;
+      rect.width = width;
+      rect.height = DRAG_HANDLE_SIZE;
+      break;
     }
+
+  if (gdk_rectangle_intersect (event ? &event->area : area, &rect, &dest))
+    draw_textured_frame (widget, hb->bin_window, &rect,
+                        GTK_SHADOW_OUT,
+                        event ? &event->area : area);
+
+  if (bin->child && GTK_WIDGET_VISIBLE (bin->child))
+    (* GTK_WIDGET_CLASS (gtk_handle_box_parent_class)->expose_event) (widget, event);
 }
 
 static gint
@@ -494,19 +935,58 @@ gtk_handle_box_expose (GtkWidget      *widget,
 {
   GtkHandleBox *hb;
 
-  g_return_val_if_fail (widget != NULL, FALSE);
-  g_return_val_if_fail (GTK_IS_HANDLE_BOX (widget), FALSE);
-  g_return_val_if_fail (event != NULL, FALSE);
-
   if (GTK_WIDGET_DRAWABLE (widget))
     {
       hb = GTK_HANDLE_BOX (widget);
 
-      if (event->window == hb->steady_window)
-       gtk_handle_box_draw_ghost (widget);
-      else if (event->window == widget->window)
+      if (event->window == widget->window)
+       {
+         if (hb->child_detached)
+           gtk_handle_box_draw_ghost (hb);
+       }
+      else
        gtk_handle_box_paint (widget, event, NULL);
     }
+  
+  return FALSE;
+}
+
+static GtkWidget *
+gtk_handle_box_get_invisible (void)
+{
+  static GtkWidget *handle_box_invisible = NULL;
+
+  if (!handle_box_invisible)
+    {
+      handle_box_invisible = gtk_invisible_new ();
+      gtk_widget_show (handle_box_invisible);
+    }
+  
+  return handle_box_invisible;
+}
+
+static gboolean
+gtk_handle_box_grab_event (GtkWidget    *widget,
+                          GdkEvent     *event,
+                          GtkHandleBox *hb)
+{
+  switch (event->type)
+    {
+    case GDK_BUTTON_RELEASE:
+      if (hb->in_drag)         /* sanity check */
+       {
+         gtk_handle_box_end_drag (hb, event->button.time);
+         return TRUE;
+       }
+      break;
+
+    case GDK_MOTION_NOTIFY:
+      return gtk_handle_box_motion (GTK_WIDGET (hb), (GdkEventMotion *)event);
+      break;
+
+    default:
+      break;
+    }
 
   return FALSE;
 }
@@ -516,158 +996,410 @@ gtk_handle_box_button_changed (GtkWidget      *widget,
                               GdkEventButton *event)
 {
   GtkHandleBox *hb;
-
-  g_return_val_if_fail (widget != NULL, FALSE);
-  g_return_val_if_fail (GTK_IS_HANDLE_BOX (widget), FALSE);
-  g_return_val_if_fail (event != NULL, FALSE);
+  gboolean event_handled;
+  GdkCursor *fleur;
+  gint handle_position;
 
   hb = GTK_HANDLE_BOX (widget);
 
-  if (event->button == 1)
+  handle_position = effective_handle_position (hb);
+
+  event_handled = FALSE;
+  if ((event->button == 1) && 
+      (event->type == GDK_BUTTON_PRESS || event->type == GDK_2BUTTON_PRESS))
     {
-      if ((event->type == GDK_BUTTON_PRESS) && (event->x < DRAG_HANDLE_SIZE))
+      GtkWidget *child;
+      gboolean in_handle;
+      
+      if (event->window != hb->bin_window)
+       return FALSE;
+
+      child = GTK_BIN (hb)->child;
+
+      if (child)
        {
-         hb->dragoff_x = event->x;
-         hb->dragoff_y = event->y;
-
-         gdk_window_get_origin (hb->steady_window, &hb->steady_x, &hb->steady_y);
-
-         hb->is_being_dragged = TRUE;
-
-         gdk_flush();
-         gtk_grab_add (widget);
-         while (gdk_pointer_grab (widget->window,
-                                  FALSE,
-                                  (GDK_BUTTON1_MOTION_MASK
-                                   | GDK_POINTER_MOTION_HINT_MASK
-                                   | GDK_BUTTON_RELEASE_MASK),
-                                  NULL,
-                                  hb->fleur_cursor,
-                                  GDK_CURRENT_TIME) != 0); /* wait for success */
+         switch (handle_position)
+           {
+           case GTK_POS_LEFT:
+             in_handle = event->x < DRAG_HANDLE_SIZE;
+             break;
+           case GTK_POS_TOP:
+             in_handle = event->y < DRAG_HANDLE_SIZE;
+             break;
+           case GTK_POS_RIGHT:
+             in_handle = event->x > 2 * GTK_CONTAINER (hb)->border_width + child->allocation.width;
+             break;
+           case GTK_POS_BOTTOM:
+             in_handle = event->y > 2 * GTK_CONTAINER (hb)->border_width + child->allocation.height;
+             break;
+           default:
+             in_handle = FALSE;
+             break;
+           }
        }
-      else if ((event->type == GDK_BUTTON_RELEASE) && hb->is_being_dragged)
+      else
        {
-         gdk_pointer_ungrab (GDK_CURRENT_TIME);
-         gtk_grab_remove (widget);
-         hb->is_being_dragged = FALSE;
+         in_handle = FALSE;
+         event_handled = TRUE;
+       }
+      
+      if (in_handle)
+       {
+         if (event->type == GDK_BUTTON_PRESS) /* Start a drag */
+           {
+             GtkHandleBoxPrivate *private = gtk_handle_box_get_private (hb);
+             GtkWidget *invisible = gtk_handle_box_get_invisible ();
+             gint desk_x, desk_y;
+             gint root_x, root_y;
+             gint width, height;
+
+             gdk_window_get_deskrelative_origin (hb->bin_window, &desk_x, &desk_y);
+             gdk_window_get_origin (hb->bin_window, &root_x, &root_y);
+             gdk_drawable_get_size (hb->bin_window, &width, &height);
+                 
+             private->orig_x = event->x_root;
+             private->orig_y = event->y_root;
+                 
+             hb->float_allocation.x = root_x - event->x_root;
+             hb->float_allocation.y = root_y - event->y_root;
+             hb->float_allocation.width = width;
+             hb->float_allocation.height = height;
+             
+             hb->deskoff_x = desk_x - root_x;
+             hb->deskoff_y = desk_y - root_y;
+             
+             if (gdk_window_is_viewable (widget->window))
+               {
+                 gdk_window_get_origin (widget->window, &root_x, &root_y);
+                 gdk_drawable_get_size (widget->window, &width, &height);
+             
+                 hb->attach_allocation.x = root_x;
+                 hb->attach_allocation.y = root_y;
+                 hb->attach_allocation.width = width;
+                 hb->attach_allocation.height = height;
+               }
+             else
+               {
+                 hb->attach_allocation.x = -1;
+                 hb->attach_allocation.y = -1;
+                 hb->attach_allocation.width = 0;
+                 hb->attach_allocation.height = 0;
+               }
+             hb->in_drag = TRUE;
+             fleur = gdk_cursor_new_for_display (gtk_widget_get_display (widget),
+                                                 GDK_FLEUR);
+             if (gdk_pointer_grab (invisible->window,
+                                   FALSE,
+                                   (GDK_BUTTON1_MOTION_MASK |
+                                    GDK_POINTER_MOTION_HINT_MASK |
+                                    GDK_BUTTON_RELEASE_MASK),
+                                   NULL,
+                                   fleur,
+                                   event->time) != 0)
+               {
+                 hb->in_drag = FALSE;
+               }
+             else
+               {
+                 gtk_grab_add (invisible);
+                 g_signal_connect (invisible, "event",
+                                   G_CALLBACK (gtk_handle_box_grab_event), hb);
+               }
+             
+             gdk_cursor_unref (fleur);
+             event_handled = TRUE;
+           }
+         else if (hb->child_detached) /* Double click */
+           {
+             gtk_handle_box_reattach (hb);
+           }
        }
     }
-  return TRUE;
+  
+  return event_handled;
 }
 
 static gint
 gtk_handle_box_motion (GtkWidget      *widget,
                       GdkEventMotion *event)
 {
-  GtkHandleBox *hb;
-  gint newx, newy;
-  gint ox, oy;
+  GtkHandleBox *hb = GTK_HANDLE_BOX (widget);
+  gint new_x, new_y;
+  gint snap_edge;
+  gboolean is_snapped = FALSE;
+  gint handle_position;
+  GdkGeometry geometry;
+  GdkScreen *screen, *pointer_screen;
+
+  if (!hb->in_drag)
+    return FALSE;
+  handle_position = effective_handle_position (hb);
+
+  /* Calculate the attachment point on the float, if the float
+   * were detached
+   */
+  new_x = 0;
+  new_y = 0;
+  screen = gtk_widget_get_screen (widget);
+  gdk_display_get_pointer (gdk_screen_get_display (screen),
+                          &pointer_screen, 
+                          &new_x, &new_y, NULL);
+  if (pointer_screen != screen)
+    {
+      GtkHandleBoxPrivate *private = gtk_handle_box_get_private (hb);
 
-  g_return_val_if_fail (widget != NULL, FALSE);
-  g_return_val_if_fail (GTK_IS_HANDLE_BOX (widget), FALSE);
-  g_return_val_if_fail (event != NULL, FALSE);
+      new_x = private->orig_x;
+      new_y = private->orig_y;
+    }
+  
+  new_x += hb->float_allocation.x;
+  new_y += hb->float_allocation.y;
 
-  hb = GTK_HANDLE_BOX (widget);
+  snap_edge = hb->snap_edge;
+  if (snap_edge == -1)
+    snap_edge = (handle_position == GTK_POS_LEFT ||
+                handle_position == GTK_POS_RIGHT) ?
+      GTK_POS_TOP : GTK_POS_LEFT;
 
-  if (event->is_hint)
-    {
-      gdk_window_get_origin (widget->window, &ox, &oy);
-      gdk_window_get_pointer (widget->window, &newx, &newy, NULL);
-      newx += ox;
-      newy += oy;
-    }
-  else
+  if (gtk_widget_get_direction (widget) == GTK_TEXT_DIR_RTL) 
+    switch (snap_edge) 
+      {
+      case GTK_POS_LEFT:
+       snap_edge = GTK_POS_RIGHT;
+       break;
+      case GTK_POS_RIGHT:
+       snap_edge = GTK_POS_LEFT;
+       break;
+      default:
+       break;
+      }
+
+  /* First, check if the snapped edge is aligned
+   */
+  switch (snap_edge)
     {
-      newx = event->x_root;
-      newy = event->y_root;
+    case GTK_POS_TOP:
+      is_snapped = abs (hb->attach_allocation.y - new_y) < TOLERANCE;
+      break;
+    case GTK_POS_BOTTOM:
+      is_snapped = abs (hb->attach_allocation.y + (gint)hb->attach_allocation.height -
+                       new_y - (gint)hb->float_allocation.height) < TOLERANCE;
+      break;
+    case GTK_POS_LEFT:
+      is_snapped = abs (hb->attach_allocation.x - new_x) < TOLERANCE;
+      break;
+    case GTK_POS_RIGHT:
+      is_snapped = abs (hb->attach_allocation.x + (gint)hb->attach_allocation.width -
+                       new_x - (gint)hb->float_allocation.width) < TOLERANCE;
+      break;
     }
 
-  newx -= hb->dragoff_x;
-  newy -= hb->dragoff_y;
-
-  if (hb->is_being_dragged)
+  /* Next, check if coordinates in the other direction are sufficiently
+   * aligned
+   */
+  if (is_snapped)
     {
-      if ((abs (hb->steady_x - newx) < SNAP_TOLERANCE)
-         && (abs (hb->steady_y - newy) < SNAP_TOLERANCE))
+      gint float_pos1 = 0;     /* Initialize to suppress warnings */
+      gint float_pos2 = 0;
+      gint attach_pos1 = 0;
+      gint attach_pos2 = 0;
+      
+      switch (snap_edge)
        {
-         if (hb->is_onroot)
-           {
-             hb->is_onroot = FALSE;
+       case GTK_POS_TOP:
+       case GTK_POS_BOTTOM:
+         attach_pos1 = hb->attach_allocation.x;
+         attach_pos2 = hb->attach_allocation.x + hb->attach_allocation.width;
+         float_pos1 = new_x;
+         float_pos2 = new_x + hb->float_allocation.width;
+         break;
+       case GTK_POS_LEFT:
+       case GTK_POS_RIGHT:
+         attach_pos1 = hb->attach_allocation.y;
+         attach_pos2 = hb->attach_allocation.y + hb->attach_allocation.height;
+         float_pos1 = new_y;
+         float_pos2 = new_y + hb->float_allocation.height;
+         break;
+       }
 
-             gdk_pointer_ungrab (GDK_CURRENT_TIME);
+      is_snapped = ((attach_pos1 - TOLERANCE < float_pos1) && 
+                   (attach_pos2 + TOLERANCE > float_pos2)) ||
+                  ((float_pos1 - TOLERANCE < attach_pos1) &&
+                   (float_pos2 + TOLERANCE > attach_pos2));
+    }
 
-             gdk_window_reparent (widget->window, hb->steady_window, 0, 0);
+  if (is_snapped)
+    {
+      if (hb->child_detached)
+       {
+         hb->child_detached = FALSE;
+         gdk_window_hide (hb->float_window);
+         gdk_window_reparent (hb->bin_window, widget->window, 0, 0);
+         hb->float_window_mapped = FALSE;
+         g_signal_emit (hb,
+                        handle_box_signals[SIGNAL_CHILD_ATTACHED],
+                        0,
+                        GTK_BIN (hb)->child);
+         
+         gtk_widget_queue_resize (widget);
+       }
+    }
+  else
+    {
+      gint width, height;
 
-             gtk_widget_hide (hb->float_window);
+      gdk_drawable_get_size (hb->float_window, &width, &height);
+      new_x += hb->deskoff_x;
+      new_y += hb->deskoff_y;
 
-             while (gdk_pointer_grab (widget->window,
-                                      FALSE,
-                                      (GDK_BUTTON1_MOTION_MASK
-                                       | GDK_POINTER_MOTION_HINT_MASK
-                                       | GDK_BUTTON_RELEASE_MASK),
-                                      NULL,
-                                      hb->fleur_cursor,
-                                      GDK_CURRENT_TIME) != 0); /* wait for success */
+      switch (handle_position)
+       {
+       case GTK_POS_LEFT:
+         new_y += ((gint)hb->float_allocation.height - height) / 2;
+         break;
+       case GTK_POS_RIGHT:
+         new_x += (gint)hb->float_allocation.width - width;
+         new_y += ((gint)hb->float_allocation.height - height) / 2;
+         break;
+       case GTK_POS_TOP:
+         new_x += ((gint)hb->float_allocation.width - width) / 2;
+         break;
+       case GTK_POS_BOTTOM:
+         new_x += ((gint)hb->float_allocation.width - width) / 2;
+         new_y += (gint)hb->float_allocation.height - height;
+         break;
+       }
 
-             gtk_widget_queue_resize (widget);
-           }
+      if (hb->child_detached)
+       {
+         gdk_window_move (hb->float_window, new_x, new_y);
+         gdk_window_raise (hb->float_window);
        }
       else
        {
-         if (hb->is_onroot)
-           {
-             gtk_widget_set_uposition (hb->float_window, newx, newy);
-             gdk_window_raise (hb->float_window->window);
-           }
-         else
-           {
-             hb->is_onroot = TRUE;
-
-             gdk_pointer_ungrab (GDK_CURRENT_TIME);
+         gint width;
+         gint height;
+         GtkRequisition child_requisition;
 
-             if (!GTK_WIDGET_REALIZED (hb->float_window))
-               gtk_widget_realize (hb->float_window);
+         hb->child_detached = TRUE;
 
-             gtk_widget_set_uposition (hb->float_window, newx, newy);
-             gdk_window_reparent (widget->window, hb->float_window->window, 0, 0);
-             gtk_widget_show (hb->float_window);
+         if (GTK_BIN (hb)->child)
+           gtk_widget_get_child_requisition (GTK_BIN (hb)->child, &child_requisition);
+         else
+           {
+             child_requisition.width = 0;
+             child_requisition.height = 0;
+           }      
 
-             while (gdk_pointer_grab (widget->window,
-                                      FALSE,
-                                      (GDK_BUTTON1_MOTION_MASK
-                                       | GDK_POINTER_MOTION_HINT_MASK
-                                       | GDK_BUTTON_RELEASE_MASK),
-                                      NULL,
-                                      hb->fleur_cursor,
-                                      GDK_CURRENT_TIME) != 0); /* wait for success */
+         width = child_requisition.width + 2 * GTK_CONTAINER (hb)->border_width;
+         height = child_requisition.height + 2 * GTK_CONTAINER (hb)->border_width;
 
-             gtk_widget_queue_resize (widget);
-           }
+         if (handle_position == GTK_POS_LEFT || handle_position == GTK_POS_RIGHT)
+           width += DRAG_HANDLE_SIZE;
+         else
+           height += DRAG_HANDLE_SIZE;
+         
+         gdk_window_move_resize (hb->float_window, new_x, new_y, width, height);
+         gdk_window_reparent (hb->bin_window, hb->float_window, 0, 0);
+         gdk_window_set_geometry_hints (hb->float_window, &geometry, GDK_HINT_POS);
+         gdk_window_show (hb->float_window);
+         hb->float_window_mapped = TRUE;
+#if    0
+         /* this extra move is necessary if we use decorations, or our
+          * window manager insists on decorations.
+          */
+         gdk_display_sync (gtk_widget_get_display (widget));
+         gdk_window_move (hb->float_window, new_x, new_y);
+         gdk_display_sync (gtk_widget_get_display (widget));
+#endif /* 0 */
+         g_signal_emit (hb,
+                        handle_box_signals[SIGNAL_CHILD_DETACHED],
+                        0,
+                        GTK_BIN (hb)->child);
+         gtk_handle_box_draw_ghost (hb);
+         
+         gtk_widget_queue_resize (widget);
        }
     }
 
   return TRUE;
 }
 
+static void
+gtk_handle_box_add (GtkContainer *container,
+                   GtkWidget    *widget)
+{
+  gtk_widget_set_parent_window (widget, GTK_HANDLE_BOX (container)->bin_window);
+  GTK_CONTAINER_CLASS (gtk_handle_box_parent_class)->add (container, widget);
+}
+
+static void
+gtk_handle_box_remove (GtkContainer *container,
+                      GtkWidget    *widget)
+{
+  GTK_CONTAINER_CLASS (gtk_handle_box_parent_class)->remove (container, widget);
+
+  gtk_handle_box_reattach (GTK_HANDLE_BOX (container));
+}
+
 static gint
-gtk_handle_box_delete_float (GtkWidget *widget,
-                            GdkEvent  *event,
-                            gpointer   data)
+gtk_handle_box_delete_event (GtkWidget *widget,
+                            GdkEventAny  *event)
 {
-  GtkHandleBox *hb;
+  GtkHandleBox *hb = GTK_HANDLE_BOX (widget);
+
+  if (event->window == hb->float_window)
+    {
+      gtk_handle_box_reattach (hb);
+      
+      return TRUE;
+    }
 
-  g_return_val_if_fail (widget != NULL, FALSE);
-  g_return_val_if_fail (event != NULL, FALSE);
-  g_return_val_if_fail (data != NULL, FALSE);
-  g_return_val_if_fail (GTK_IS_HANDLE_BOX (data), FALSE);
+  return FALSE;
+}
+
+static void
+gtk_handle_box_reattach (GtkHandleBox *hb)
+{
+  GtkWidget *widget = GTK_WIDGET (hb);
+  
+  if (hb->child_detached)
+    {
+      hb->child_detached = FALSE;
+      if (GTK_WIDGET_REALIZED (hb))
+       {
+         gdk_window_hide (hb->float_window);
+         gdk_window_reparent (hb->bin_window, widget->window, 0, 0);
 
-  hb = GTK_HANDLE_BOX (data);
+         if (GTK_BIN (hb)->child)
+           g_signal_emit (hb,
+                          handle_box_signals[SIGNAL_CHILD_ATTACHED],
+                          0,
+                          GTK_BIN (hb)->child);
 
-  hb->is_onroot = FALSE;
+       }
+      hb->float_window_mapped = FALSE;
+    }
+  if (hb->in_drag)
+    gtk_handle_box_end_drag (hb, GDK_CURRENT_TIME);
 
-  gdk_window_reparent (GTK_WIDGET (hb)->window, hb->steady_window, 0, 0);
-  gtk_widget_hide (hb->float_window);
   gtk_widget_queue_resize (GTK_WIDGET (hb));
+}
 
-  return FALSE;
+static void
+gtk_handle_box_end_drag (GtkHandleBox *hb,
+                        guint32       time)
+{
+  GtkWidget *invisible = gtk_handle_box_get_invisible ();
+               
+  hb->in_drag = FALSE;
+
+  gtk_grab_remove (invisible);
+  gdk_pointer_ungrab (time);
+  g_signal_handlers_disconnect_by_func (invisible,
+                                       G_CALLBACK (gtk_handle_box_grab_event),
+                                       hb);
 }
+
+#define __GTK_HANDLE_BOX_C__
+#include "gtkaliasdef.c"