]> Pileus Git - ~andy/gtk/blobdiff - gtk/gtkentry.c
Use the correct screen for getting the height. (Fix from Stephen Browne,
[~andy/gtk] / gtk / gtkentry.c
index d7ac305671590b52847c4a06764c08e967169b3c..a1a6be22f62bdd0ac2e81c637f66d9f4daa680c8 100644 (file)
 
 #include "gdk/gdkkeysyms.h"
 #include "gtkbindings.h"
+#include "gtkcelleditable.h"
 #include "gtkclipboard.h"
 #include "gtkdnd.h"
 #include "gtkentry.h"
+#include "gtkimagemenuitem.h"
 #include "gtkimmulticontext.h"
 #include "gtkintl.h"
 #include "gtkmain.h"
+#include "gtkmarshalers.h"
 #include "gtkmenu.h"
 #include "gtkmenuitem.h"
 #include "gtkseparatormenuitem.h"
 #include "gtkselection.h"
-#include "gtksignal.h"
+#include "gtksettings.h"
+#include "gtkstock.h"
+#include "gtktextutil.h"
 #include "gtkwindow.h"
 
 #define MIN_ENTRY_WIDTH  150
@@ -54,9 +59,6 @@
 #define MAX_SIZE G_MAXUSHORT
 
 enum {
-  INSERT_TEXT,
-  DELETE_TEXT,
-  CHANGED,
   ACTIVATE,
   POPULATE_POPUP,
   MOVE_CURSOR,
@@ -71,13 +73,17 @@ enum {
 
 enum {
   PROP_0,
-  PROP_TEXT_POSITION,
+  PROP_CURSOR_POSITION,
+  PROP_SELECTION_BOUND,
   PROP_EDITABLE,
   PROP_MAX_LENGTH,
   PROP_VISIBILITY,
+  PROP_HAS_FRAME,
   PROP_INVISIBLE_CHAR,
   PROP_ACTIVATES_DEFAULT,
-  PROP_WIDTH_CHARS
+  PROP_WIDTH_CHARS,
+  PROP_SCROLL_OFFSET,
+  PROP_TEXT
 };
 
 static guint signals[LAST_SIGNAL] = { 0 };
@@ -91,14 +97,14 @@ static GtkTargetEntry target_table[] = {
   { "UTF8_STRING",   0, 0 },
   { "COMPOUND_TEXT", 0, 0 },
   { "TEXT",          0, 0 },
-  { "text/plain",    0, 0 },
   { "STRING",        0, 0 }
 };
 
 /* GObject, GtkObject methods
  */
-static void   gtk_entry_class_init           (GtkEntryClass    *klass);
-static void   gtk_entry_editable_init        (GtkEditableClass *iface);
+static void   gtk_entry_class_init           (GtkEntryClass        *klass);
+static void   gtk_entry_editable_init        (GtkEditableClass     *iface);
+static void   gtk_entry_cell_editable_init   (GtkCellEditableIface *iface);
 static void   gtk_entry_init                 (GtkEntry         *entry);
 static void   gtk_entry_set_property (GObject         *object,
                                      guint            prop_id,
@@ -118,7 +124,7 @@ static void   gtk_entry_size_request         (GtkWidget        *widget,
                                              GtkRequisition   *requisition);
 static void   gtk_entry_size_allocate        (GtkWidget        *widget,
                                              GtkAllocation    *allocation);
-static void   gtk_entry_draw_focus           (GtkWidget        *widget);
+static void   gtk_entry_draw_frame           (GtkWidget        *widget);
 static gint   gtk_entry_expose               (GtkWidget        *widget,
                                              GdkEventExpose   *event);
 static gint   gtk_entry_button_press         (GtkWidget        *widget,
@@ -129,10 +135,13 @@ static gint   gtk_entry_motion_notify        (GtkWidget        *widget,
                                              GdkEventMotion   *event);
 static gint   gtk_entry_key_press            (GtkWidget        *widget,
                                              GdkEventKey      *event);
+static gint   gtk_entry_key_release          (GtkWidget        *widget,
+                                             GdkEventKey      *event);
 static gint   gtk_entry_focus_in             (GtkWidget        *widget,
                                              GdkEventFocus    *event);
 static gint   gtk_entry_focus_out            (GtkWidget        *widget,
                                              GdkEventFocus    *event);
+static void   gtk_entry_grab_focus           (GtkWidget        *widget);
 static void   gtk_entry_style_set            (GtkWidget        *widget,
                                              GtkStyle         *previous_style);
 static void   gtk_entry_direction_changed    (GtkWidget        *widget,
@@ -140,6 +149,11 @@ static void   gtk_entry_direction_changed    (GtkWidget        *widget,
 static void   gtk_entry_state_changed        (GtkWidget        *widget,
                                              GtkStateType      previous_state);
 
+static gboolean gtk_entry_drag_drop          (GtkWidget        *widget,
+                                              GdkDragContext   *context,
+                                              gint              x,
+                                              gint              y,
+                                              guint             time);
 static gboolean gtk_entry_drag_motion        (GtkWidget        *widget,
                                              GdkDragContext   *context,
                                              gint              x,
@@ -185,13 +199,18 @@ static gboolean gtk_entry_get_selection_bounds (GtkEditable *editable,
                                                gint        *start,
                                                gint        *end);
 
+/* GtkCellEditable method implementations
+ */
+static void gtk_entry_start_editing (GtkCellEditable *cell_editable,
+                                    GdkEvent        *event);
+
 /* Default signal handlers
  */
-static void gtk_entry_real_insert_text   (GtkEntry        *entry,
+static void gtk_entry_real_insert_text   (GtkEditable     *editable,
                                          const gchar     *new_text,
                                          gint             new_text_length,
                                          gint            *position);
-static void gtk_entry_real_delete_text   (GtkEntry        *entry,
+static void gtk_entry_real_delete_text   (GtkEditable     *editable,
                                          gint             start_pos,
                                          gint             end_pos);
 static void gtk_entry_move_cursor        (GtkEntry        *entry,
@@ -207,23 +226,39 @@ static void gtk_entry_cut_clipboard      (GtkEntry        *entry);
 static void gtk_entry_copy_clipboard     (GtkEntry        *entry);
 static void gtk_entry_paste_clipboard    (GtkEntry        *entry);
 static void gtk_entry_toggle_overwrite   (GtkEntry        *entry);
+static void gtk_entry_select_all         (GtkEntry        *entry);
 static void gtk_entry_real_activate      (GtkEntry        *entry);
-static void gtk_entry_popup_menu         (GtkWidget      *widget);
+static gboolean gtk_entry_popup_menu     (GtkWidget      *widget);
 
+static void gtk_entry_keymap_direction_changed (GdkKeymap *keymap,
+                                               GtkEntry  *entry);
 /* IM Context Callbacks
  */
-static void gtk_entry_commit_cb           (GtkIMContext      *context,
-                                          const gchar       *str,
-                                          GtkEntry          *entry);
-static void gtk_entry_preedit_changed_cb  (GtkIMContext      *context,
-                                          GtkEntry          *entry);
+static void     gtk_entry_commit_cb               (GtkIMContext *context,
+                                                  const gchar  *str,
+                                                  GtkEntry     *entry);
+static void     gtk_entry_preedit_changed_cb      (GtkIMContext *context,
+                                                  GtkEntry     *entry);
+static gboolean gtk_entry_retrieve_surrounding_cb (GtkIMContext *context,
+                                                  GtkEntry     *entry);
+static gboolean gtk_entry_delete_surrounding_cb   (GtkIMContext *context,
+                                                  gint          offset,
+                                                  gint          n_chars,
+                                                  GtkEntry     *entry);
+
 /* Internal routines
  */
+static void         gtk_entry_enter_text               (GtkEntry       *entry,
+                                                        const gchar    *str);
+static void         gtk_entry_set_positions            (GtkEntry       *entry,
+                                                       gint            current_pos,
+                                                       gint            selection_bound);
 static void         gtk_entry_draw_text                (GtkEntry       *entry);
 static void         gtk_entry_draw_cursor              (GtkEntry       *entry,
                                                        CursorType      type);
-static PangoLayout *gtk_entry_get_layout               (GtkEntry       *entry,
-                                                       gboolean        include_preedit);
+static PangoLayout *gtk_entry_ensure_layout            (GtkEntry       *entry,
+                                                        gboolean        include_preedit);
+static void         gtk_entry_reset_layout             (GtkEntry       *entry);
 static void         gtk_entry_queue_draw               (GtkEntry       *entry);
 static void         gtk_entry_reset_im_context         (GtkEntry       *entry);
 static void         gtk_entry_recompute                (GtkEntry       *entry);
@@ -237,6 +272,9 @@ static void         gtk_entry_adjust_scroll            (GtkEntry       *entry);
 static gint         gtk_entry_move_visually            (GtkEntry       *editable,
                                                        gint            start,
                                                        gint            count);
+static gint         gtk_entry_move_logically           (GtkEntry       *entry,
+                                                       gint            start,
+                                                       gint            count);
 static gint         gtk_entry_move_forward_word        (GtkEntry       *entry,
                                                        gint            start);
 static gint         gtk_entry_move_backward_word       (GtkEntry       *entry,
@@ -252,28 +290,43 @@ static void         gtk_entry_paste                    (GtkEntry       *entry,
 static void         gtk_entry_update_primary_selection (GtkEntry       *entry);
 static void         gtk_entry_do_popup                 (GtkEntry       *entry,
                                                        GdkEventButton *event);
-static gboolean     gtk_entry_mnemonic_activate        (GtkWidget     *widget,
-                                                       gboolean       group_cycling);
+static gboolean     gtk_entry_mnemonic_activate        (GtkWidget      *widget,
+                                                       gboolean        group_cycling);
+static void         gtk_entry_state_changed            (GtkWidget      *widget,
+                                                       GtkStateType    previous_state);
+static void         gtk_entry_check_cursor_blink       (GtkEntry       *entry);
+static void         gtk_entry_pend_cursor_blink        (GtkEntry       *entry);
+static void         get_text_area_size                 (GtkEntry       *entry,
+                                                       gint           *x,
+                                                       gint           *y,
+                                                       gint           *width,
+                                                       gint           *height);
+static void         get_widget_window_size             (GtkEntry       *entry,
+                                                       gint           *x,
+                                                       gint           *y,
+                                                       gint           *width,
+                                                       gint           *height);
 
 static GtkWidgetClass *parent_class = NULL;
 
-GtkType
+GType
 gtk_entry_get_type (void)
 {
-  static GtkType entry_type = 0;
+  static GType entry_type = 0;
 
   if (!entry_type)
     {
-      static const GtkTypeInfo entry_info =
+      static const GTypeInfo entry_info =
       {
-       "GtkEntry",
-       sizeof (GtkEntry),
        sizeof (GtkEntryClass),
-       (GtkClassInitFunc) gtk_entry_class_init,
-       (GtkObjectInitFunc) gtk_entry_init,
-       /* reserved_1 */ NULL,
-       /* reserved_2 */ NULL,
-        (GtkClassInitFunc) NULL,
+       NULL,           /* base_init */
+       NULL,           /* base_finalize */
+       (GClassInitFunc) gtk_entry_class_init,
+       NULL,           /* class_finalize */
+       NULL,           /* class_data */
+       sizeof (GtkEntry),
+       0,              /* n_preallocs */
+       (GInstanceInitFunc) gtk_entry_init,
       };
       
       static const GInterfaceInfo editable_info =
@@ -283,10 +336,22 @@ gtk_entry_get_type (void)
        NULL                                             /* interface_data */
       };
 
-      entry_type = gtk_type_unique (GTK_TYPE_WIDGET, &entry_info);
+      static const GInterfaceInfo cell_editable_info =
+      {
+       (GInterfaceInitFunc) gtk_entry_cell_editable_init,    /* interface_init */
+       NULL,                                                 /* interface_finalize */
+       NULL                                                  /* interface_data */
+      };
+      
+      entry_type = g_type_register_static (GTK_TYPE_WIDGET, "GtkEntry",
+                                          &entry_info, 0);
+
       g_type_add_interface_static (entry_type,
                                   GTK_TYPE_EDITABLE,
                                   &editable_info);
+      g_type_add_interface_static (entry_type,
+                                  GTK_TYPE_CELL_EDITABLE,
+                                  &cell_editable_info);
     }
 
   return entry_type;
@@ -303,29 +368,27 @@ add_move_binding (GtkBindingSet  *binding_set,
   
   gtk_binding_entry_add_signal (binding_set, keyval, modmask,
                                "move_cursor", 3,
-                               GTK_TYPE_ENUM, step,
+                               G_TYPE_ENUM, step,
                                G_TYPE_INT, count,
-                                G_TYPE_BOOLEAN, FALSE);
+                               G_TYPE_BOOLEAN, FALSE);
 
   /* Selection-extending version */
   gtk_binding_entry_add_signal (binding_set, keyval, modmask | GDK_SHIFT_MASK,
                                "move_cursor", 3,
-                               GTK_TYPE_ENUM, step,
+                               G_TYPE_ENUM, step,
                                G_TYPE_INT, count,
-                                G_TYPE_BOOLEAN, TRUE);
+                               G_TYPE_BOOLEAN, TRUE);
 }
 
 static void
 gtk_entry_class_init (GtkEntryClass *class)
 {
   GObjectClass *gobject_class = G_OBJECT_CLASS (class);
-  GtkObjectClass *object_class;
   GtkWidgetClass *widget_class;
   GtkBindingSet *binding_set;
 
-  object_class = (GtkObjectClass*) class;
   widget_class = (GtkWidgetClass*) class;
-  parent_class = gtk_type_class (GTK_TYPE_WIDGET);
+  parent_class = g_type_class_peek_parent (class);
 
   gobject_class->finalize = gtk_entry_finalize;
   gobject_class->set_property = gtk_entry_set_property;
@@ -340,13 +403,16 @@ gtk_entry_class_init (GtkEntryClass *class)
   widget_class->button_release_event = gtk_entry_button_release;
   widget_class->motion_notify_event = gtk_entry_motion_notify;
   widget_class->key_press_event = gtk_entry_key_press;
+  widget_class->key_release_event = gtk_entry_key_release;
   widget_class->focus_in_event = gtk_entry_focus_in;
   widget_class->focus_out_event = gtk_entry_focus_out;
+  widget_class->grab_focus = gtk_entry_grab_focus;
   widget_class->style_set = gtk_entry_style_set;
   widget_class->direction_changed = gtk_entry_direction_changed;
   widget_class->state_changed = gtk_entry_state_changed;
   widget_class->mnemonic_activate = gtk_entry_mnemonic_activate;
 
+  widget_class->drag_drop = gtk_entry_drag_drop;
   widget_class->drag_motion = gtk_entry_drag_motion;
   widget_class->drag_leave = gtk_entry_drag_leave;
   widget_class->drag_data_received = gtk_entry_drag_data_received;
@@ -354,9 +420,7 @@ gtk_entry_class_init (GtkEntryClass *class)
   widget_class->drag_data_delete = gtk_entry_drag_data_delete;
 
   widget_class->popup_menu = gtk_entry_popup_menu;
-  
-  class->insert_text = gtk_entry_real_insert_text;
-  class->delete_text = gtk_entry_real_delete_text;
+
   class->move_cursor = gtk_entry_move_cursor;
   class->insert_at_cursor = gtk_entry_insert_at_cursor;
   class->delete_from_cursor = gtk_entry_delete_from_cursor;
@@ -367,14 +431,24 @@ gtk_entry_class_init (GtkEntryClass *class)
   class->activate = gtk_entry_real_activate;
   
   g_object_class_install_property (gobject_class,
-                                   PROP_TEXT_POSITION,
-                                   g_param_spec_int ("text_position",
-                                                     _("Text Position"),
-                                                     _("The current position of the insertion point"),
+                                   PROP_CURSOR_POSITION,
+                                   g_param_spec_int ("cursor_position",
+                                                     _("Cursor Position"),
+                                                     _("The current position of the insertion cursor in chars"),
                                                      0,
-                                                     G_MAXINT,
+                                                     MAX_SIZE,
                                                      0,
-                                                     G_PARAM_READABLE | G_PARAM_WRITABLE));
+                                                     G_PARAM_READABLE));
+  
+  g_object_class_install_property (gobject_class,
+                                   PROP_SELECTION_BOUND,
+                                   g_param_spec_int ("selection_bound",
+                                                     _("Selection Bound"),
+                                                     _("The position of the opposite end of the selection from the cursor in chars"),
+                                                     0,
+                                                     MAX_SIZE,
+                                                     0,
+                                                     G_PARAM_READABLE));
   
   g_object_class_install_property (gobject_class,
                                    PROP_EDITABLE,
@@ -388,10 +462,10 @@ gtk_entry_class_init (GtkEntryClass *class)
                                    PROP_MAX_LENGTH,
                                    g_param_spec_int ("max_length",
                                                      _("Maximum length"),
-                                                     _("Maximum number of characters for this entry"),
-                                                     -1,
-                                                     G_MAXINT,
-                                                     -1,
+                                                     _("Maximum number of characters for this entry. Zero if no maximum"),
+                                                     0,
+                                                     MAX_SIZE,
+                                                     0,
                                                      G_PARAM_READABLE | G_PARAM_WRITABLE));
   g_object_class_install_property (gobject_class,
                                    PROP_VISIBILITY,
@@ -400,7 +474,16 @@ gtk_entry_class_init (GtkEntryClass *class)
                                                         _("FALSE displays the \"invisible char\" instead of the actual text (password mode)"),
                                                          TRUE,
                                                         G_PARAM_READABLE | G_PARAM_WRITABLE));
+
   g_object_class_install_property (gobject_class,
+                                   PROP_HAS_FRAME,
+                                   g_param_spec_boolean ("has_frame",
+                                                        _("Has Frame"),
+                                                        _("FALSE removes outside bevel from entry"),
+                                                         TRUE,
+                                                        G_PARAM_READABLE | G_PARAM_WRITABLE));
+
+    g_object_class_install_property (gobject_class,
                                    PROP_INVISIBLE_CHAR,
                                    g_param_spec_unichar ("invisible_char",
                                                         _("Invisible character"),
@@ -412,132 +495,127 @@ gtk_entry_class_init (GtkEntryClass *class)
                                    PROP_ACTIVATES_DEFAULT,
                                    g_param_spec_boolean ("activates_default",
                                                         _("Activates default"),
-                                                        _("Whether to activate the default widget (such as the default button in a dialog) when Enter is pressed."),
+                                                        _("Whether to activate the default widget (such as the default button in a dialog) when Enter is pressed"),
                                                          FALSE,
                                                         G_PARAM_READABLE | G_PARAM_WRITABLE));
   g_object_class_install_property (gobject_class,
                                    PROP_WIDTH_CHARS,
                                    g_param_spec_int ("width_chars",
                                                      _("Width in chars"),
-                                                     _("Number of characters to leave space for in the entry."),
+                                                     _("Number of characters to leave space for in the entry"),
                                                      -1,
                                                      G_MAXINT,
-                                                     
                                                      -1,
                                                      G_PARAM_READABLE | G_PARAM_WRITABLE));
 
-  gtk_widget_class_install_style_property (widget_class,
-                                          g_param_spec_boxed ("cursor_color",
-                                                              _("Cursor color"),
-                                                              _("Color with which to draw insertion cursor"),
-                                                              GDK_TYPE_COLOR,
-                                                              G_PARAM_READABLE));
-
-  signals[INSERT_TEXT] =
-    gtk_signal_new ("insert_text",
-                   GTK_RUN_LAST,
-                   GTK_CLASS_TYPE (object_class),
-                   GTK_SIGNAL_OFFSET (GtkEntryClass, insert_text),
-                   gtk_marshal_VOID__STRING_INT_POINTER,
-                   GTK_TYPE_NONE,
-                   3,
-                   GTK_TYPE_STRING,
-                   GTK_TYPE_INT,
-                   GTK_TYPE_POINTER);
-
-  signals[DELETE_TEXT] =
-    gtk_signal_new ("delete_text",
-                   GTK_RUN_LAST,
-                   GTK_CLASS_TYPE (object_class),
-                   GTK_SIGNAL_OFFSET (GtkEntryClass, delete_text),
-                   gtk_marshal_VOID__INT_INT,
-                   GTK_TYPE_NONE,
-                   2,
-                   GTK_TYPE_INT,
-                   GTK_TYPE_INT);                  
-
-  signals[CHANGED] =
-    gtk_signal_new ("changed",
-                   GTK_RUN_LAST,
-                   GTK_CLASS_TYPE (object_class),
-                   GTK_SIGNAL_OFFSET (GtkEntryClass, changed),
-                   gtk_marshal_VOID__VOID,
-                   GTK_TYPE_NONE, 0);
+  g_object_class_install_property (gobject_class,
+                                   PROP_SCROLL_OFFSET,
+                                   g_param_spec_int ("scroll_offset",
+                                                     _("Scroll offset"),
+                                                     _("Number of pixels of the entry scrolled off the screen to the left"),
+                                                     0,
+                                                     G_MAXINT,
+                                                     0,
+                                                     G_PARAM_READABLE));
 
+  g_object_class_install_property (gobject_class,
+                                   PROP_TEXT,
+                                   g_param_spec_string ("text",
+                                                       _("Text"),
+                                                       _("The contents of the entry"),
+                                                       "",
+                                                       G_PARAM_READABLE | G_PARAM_WRITABLE));
+  
   signals[POPULATE_POPUP] =
-    gtk_signal_new ("populate_popup",
-                   GTK_RUN_LAST,
-                   GTK_CLASS_TYPE (object_class),
-                   GTK_SIGNAL_OFFSET (GtkEntryClass, populate_popup),
-                   gtk_marshal_VOID__OBJECT,
-                   GTK_TYPE_NONE, 1, GTK_TYPE_MENU);
+    g_signal_new ("populate_popup",
+                 G_OBJECT_CLASS_TYPE (gobject_class),
+                 G_SIGNAL_RUN_LAST,
+                 G_STRUCT_OFFSET (GtkEntryClass, populate_popup),
+                 NULL, NULL,
+                 _gtk_marshal_VOID__OBJECT,
+                 G_TYPE_NONE, 1,
+                 GTK_TYPE_MENU);
   
  /* Action signals */
   
   signals[ACTIVATE] =
-    gtk_signal_new ("activate",
-                   GTK_RUN_LAST | GTK_RUN_ACTION,
-                   GTK_CLASS_TYPE (object_class),
-                   GTK_SIGNAL_OFFSET (GtkEntryClass, activate),
-                   gtk_marshal_VOID__VOID,
-                   GTK_TYPE_NONE, 0);
+    g_signal_new ("activate",
+                 G_OBJECT_CLASS_TYPE (gobject_class),
+                 G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
+                 G_STRUCT_OFFSET (GtkEntryClass, activate),
+                 NULL, NULL,
+                 _gtk_marshal_VOID__VOID,
+                 G_TYPE_NONE, 0);
   widget_class->activate_signal = signals[ACTIVATE];
 
   signals[MOVE_CURSOR] = 
-      gtk_signal_new ("move_cursor",
-                      GTK_RUN_LAST | GTK_RUN_ACTION,
-                      GTK_CLASS_TYPE (object_class),
-                      GTK_SIGNAL_OFFSET (GtkEntryClass, move_cursor),
-                      gtk_marshal_VOID__ENUM_INT_BOOLEAN,
-                      GTK_TYPE_NONE, 3, GTK_TYPE_MOVEMENT_STEP, GTK_TYPE_INT, GTK_TYPE_BOOL);
+    g_signal_new ("move_cursor",
+                 G_OBJECT_CLASS_TYPE (gobject_class),
+                 G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
+                 G_STRUCT_OFFSET (GtkEntryClass, move_cursor),
+                 NULL, NULL,
+                 _gtk_marshal_VOID__ENUM_INT_BOOLEAN,
+                 G_TYPE_NONE, 3,
+                 GTK_TYPE_MOVEMENT_STEP,
+                 G_TYPE_INT,
+                 G_TYPE_BOOLEAN);
 
   signals[INSERT_AT_CURSOR] = 
-      gtk_signal_new ("insert_at_cursor",
-                      GTK_RUN_LAST | GTK_RUN_ACTION,
-                      GTK_CLASS_TYPE (object_class),
-                      GTK_SIGNAL_OFFSET (GtkEntryClass, insert_at_cursor),
-                      gtk_marshal_VOID__STRING,
-                      GTK_TYPE_NONE, 1, GTK_TYPE_STRING);
+    g_signal_new ("insert_at_cursor",
+                 G_OBJECT_CLASS_TYPE (gobject_class),
+                 G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
+                 G_STRUCT_OFFSET (GtkEntryClass, insert_at_cursor),
+                 NULL, NULL,
+                 _gtk_marshal_VOID__STRING,
+                 G_TYPE_NONE, 1,
+                 G_TYPE_STRING);
 
   signals[DELETE_FROM_CURSOR] = 
-      gtk_signal_new ("delete_from_cursor",
-                      GTK_RUN_LAST | GTK_RUN_ACTION,
-                      GTK_CLASS_TYPE (object_class),
-                      GTK_SIGNAL_OFFSET (GtkEntryClass, delete_from_cursor),
-                      gtk_marshal_VOID__ENUM_INT,
-                      GTK_TYPE_NONE, 2, GTK_TYPE_DELETE_TYPE, GTK_TYPE_INT);
+    g_signal_new ("delete_from_cursor",
+                 G_OBJECT_CLASS_TYPE (gobject_class),
+                 G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
+                 G_STRUCT_OFFSET (GtkEntryClass, delete_from_cursor),
+                 NULL, NULL,
+                 _gtk_marshal_VOID__ENUM_INT,
+                 G_TYPE_NONE, 2,
+                 GTK_TYPE_DELETE_TYPE,
+                 G_TYPE_INT);
 
   signals[CUT_CLIPBOARD] =
-    gtk_signal_new ("cut_clipboard",
-                    GTK_RUN_LAST | GTK_RUN_ACTION,
-                    GTK_CLASS_TYPE (object_class),
-                    GTK_SIGNAL_OFFSET (GtkEntryClass, cut_clipboard),
-                    gtk_marshal_VOID__VOID,
-                    GTK_TYPE_NONE, 0);
+    g_signal_new ("cut_clipboard",
+                 G_OBJECT_CLASS_TYPE (gobject_class),
+                 G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
+                 G_STRUCT_OFFSET (GtkEntryClass, cut_clipboard),
+                 NULL, NULL,
+                 _gtk_marshal_VOID__VOID,
+                 G_TYPE_NONE, 0);
 
   signals[COPY_CLIPBOARD] =
-    gtk_signal_new ("copy_clipboard",
-                    GTK_RUN_LAST | GTK_RUN_ACTION,
-                    GTK_CLASS_TYPE (object_class),
-                    GTK_SIGNAL_OFFSET (GtkEntryClass, copy_clipboard),
-                    gtk_marshal_VOID__VOID,
-                    GTK_TYPE_NONE, 0);
+    g_signal_new ("copy_clipboard",
+                 G_OBJECT_CLASS_TYPE (gobject_class),
+                 G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
+                 G_STRUCT_OFFSET (GtkEntryClass, copy_clipboard),
+                 NULL, NULL,
+                 _gtk_marshal_VOID__VOID,
+                 G_TYPE_NONE, 0);
 
   signals[PASTE_CLIPBOARD] =
-    gtk_signal_new ("paste_clipboard",
-                    GTK_RUN_LAST | GTK_RUN_ACTION,
-                    GTK_CLASS_TYPE (object_class),
-                    GTK_SIGNAL_OFFSET (GtkEntryClass, paste_clipboard),
-                    gtk_marshal_VOID__VOID,
-                    GTK_TYPE_NONE, 0);
+    g_signal_new ("paste_clipboard",
+                 G_OBJECT_CLASS_TYPE (gobject_class),
+                 G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
+                 G_STRUCT_OFFSET (GtkEntryClass, paste_clipboard),
+                 NULL, NULL,
+                 _gtk_marshal_VOID__VOID,
+                 G_TYPE_NONE, 0);
 
   signals[TOGGLE_OVERWRITE] =
-    gtk_signal_new ("toggle_overwrite",
-                    GTK_RUN_LAST | GTK_RUN_ACTION,
-                    GTK_CLASS_TYPE (object_class),
-                    GTK_SIGNAL_OFFSET (GtkEntryClass, toggle_overwrite),
-                    gtk_marshal_VOID__VOID,
-                    GTK_TYPE_NONE, 0);
+    g_signal_new ("toggle_overwrite",
+                 G_OBJECT_CLASS_TYPE (gobject_class),
+                 G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
+                 G_STRUCT_OFFSET (GtkEntryClass, toggle_overwrite),
+                 NULL, NULL,
+                 _gtk_marshal_VOID__VOID,
+                 G_TYPE_NONE, 0);
 
   /*
    * Key bindings
@@ -558,12 +636,6 @@ gtk_entry_class_init (GtkEntryClass *class)
   add_move_binding (binding_set, GDK_KP_Left, 0,
                    GTK_MOVEMENT_VISUAL_POSITIONS, -1);
   
-  add_move_binding (binding_set, GDK_f, GDK_CONTROL_MASK,
-                   GTK_MOVEMENT_LOGICAL_POSITIONS, 1);
-  
-  add_move_binding (binding_set, GDK_b, GDK_CONTROL_MASK,
-                   GTK_MOVEMENT_LOGICAL_POSITIONS, -1);
-  
   add_move_binding (binding_set, GDK_Right, GDK_CONTROL_MASK,
                    GTK_MOVEMENT_WORDS, 1);
 
@@ -576,18 +648,6 @@ gtk_entry_class_init (GtkEntryClass *class)
   add_move_binding (binding_set, GDK_KP_Left, GDK_CONTROL_MASK,
                    GTK_MOVEMENT_WORDS, -1);
   
-  add_move_binding (binding_set, GDK_a, GDK_CONTROL_MASK,
-                   GTK_MOVEMENT_PARAGRAPH_ENDS, -1);
-
-  add_move_binding (binding_set, GDK_e, GDK_CONTROL_MASK,
-                   GTK_MOVEMENT_PARAGRAPH_ENDS, 1);
-
-  add_move_binding (binding_set, GDK_f, GDK_MOD1_MASK,
-                   GTK_MOVEMENT_WORDS, 1);
-
-  add_move_binding (binding_set, GDK_b, GDK_MOD1_MASK,
-                   GTK_MOVEMENT_WORDS, -1);
-
   add_move_binding (binding_set, GDK_Home, 0,
                    GTK_MOVEMENT_DISPLAY_LINE_ENDS, -1);
 
@@ -612,105 +672,100 @@ gtk_entry_class_init (GtkEntryClass *class)
   add_move_binding (binding_set, GDK_KP_End, GDK_CONTROL_MASK,
                    GTK_MOVEMENT_BUFFER_ENDS, 1);
 
-  /* Activate */
-
+  /* Select all
+   */
+  gtk_binding_entry_add_signal (binding_set, GDK_a, GDK_CONTROL_MASK,
+                                "move_cursor", 3,
+                                GTK_TYPE_MOVEMENT_STEP, GTK_MOVEMENT_BUFFER_ENDS,
+                                G_TYPE_INT, -1,
+                               G_TYPE_BOOLEAN, FALSE);
+  gtk_binding_entry_add_signal (binding_set, GDK_a, GDK_CONTROL_MASK,
+                                "move_cursor", 3,
+                                GTK_TYPE_MOVEMENT_STEP, GTK_MOVEMENT_BUFFER_ENDS,
+                                G_TYPE_INT, 1,
+                               G_TYPE_BOOLEAN, TRUE);
+
+
+  /* Activate
+   */
   gtk_binding_entry_add_signal (binding_set, GDK_Return, 0,
                                "activate", 0);
-
   gtk_binding_entry_add_signal (binding_set, GDK_KP_Enter, 0,
                                "activate", 0);
   
   /* Deleting text */
   gtk_binding_entry_add_signal (binding_set, GDK_Delete, 0,
                                "delete_from_cursor", 2,
-                               GTK_TYPE_ENUM, GTK_DELETE_CHARS,
-                               GTK_TYPE_INT, 1);
+                               G_TYPE_ENUM, GTK_DELETE_CHARS,
+                               G_TYPE_INT, 1);
 
   gtk_binding_entry_add_signal (binding_set, GDK_KP_Delete, 0,
                                "delete_from_cursor", 2,
-                               GTK_TYPE_ENUM, GTK_DELETE_CHARS,
-                               GTK_TYPE_INT, 1);
+                               G_TYPE_ENUM, GTK_DELETE_CHARS,
+                               G_TYPE_INT, 1);
   
-  gtk_binding_entry_add_signal (binding_set, GDK_d, GDK_CONTROL_MASK,
-                               "delete_from_cursor", 2,
-                               GTK_TYPE_ENUM, GTK_DELETE_CHARS,
-                               GTK_TYPE_INT, 1);
-
   gtk_binding_entry_add_signal (binding_set, GDK_BackSpace, 0,
                                "delete_from_cursor", 2,
-                               GTK_TYPE_ENUM, GTK_DELETE_CHARS,
-                               GTK_TYPE_INT, -1);
+                               G_TYPE_ENUM, GTK_DELETE_CHARS,
+                               G_TYPE_INT, -1);
+
+  /* Make this do the same as Backspace, to help with mis-typing */
+  gtk_binding_entry_add_signal (binding_set, GDK_BackSpace, GDK_SHIFT_MASK,
+                                "delete_from_cursor", 2,
+                                G_TYPE_ENUM, GTK_DELETE_CHARS,
+                                G_TYPE_INT, -1);
 
   gtk_binding_entry_add_signal (binding_set, GDK_Delete, GDK_CONTROL_MASK,
                                "delete_from_cursor", 2,
-                               GTK_TYPE_ENUM, GTK_DELETE_WORD_ENDS,
-                               GTK_TYPE_INT, 1);
+                               G_TYPE_ENUM, GTK_DELETE_WORD_ENDS,
+                               G_TYPE_INT, 1);
 
   gtk_binding_entry_add_signal (binding_set, GDK_KP_Delete, GDK_CONTROL_MASK,
                                "delete_from_cursor", 2,
-                               GTK_TYPE_ENUM, GTK_DELETE_WORD_ENDS,
-                               GTK_TYPE_INT, 1);
+                               G_TYPE_ENUM, GTK_DELETE_WORD_ENDS,
+                               G_TYPE_INT, 1);
   
-  gtk_binding_entry_add_signal (binding_set, GDK_d, GDK_MOD1_MASK,
-                               "delete_from_cursor", 2,
-                               GTK_TYPE_ENUM, GTK_DELETE_WORD_ENDS,
-                               GTK_TYPE_INT, 1);
-
   gtk_binding_entry_add_signal (binding_set, GDK_BackSpace, GDK_CONTROL_MASK,
                                "delete_from_cursor", 2,
-                               GTK_TYPE_ENUM, GTK_DELETE_WORD_ENDS,
-                               GTK_TYPE_INT, -1);
-
-  gtk_binding_entry_add_signal (binding_set, GDK_k, GDK_CONTROL_MASK,
-                               "delete_from_cursor", 2,
-                               GTK_TYPE_ENUM, GTK_DELETE_PARAGRAPH_ENDS,
-                               GTK_TYPE_INT, 1);
-
-  gtk_binding_entry_add_signal (binding_set, GDK_u, GDK_CONTROL_MASK,
-                               "delete_from_cursor", 2,
-                               GTK_TYPE_ENUM, GTK_DELETE_PARAGRAPHS,
-                               GTK_TYPE_INT, 1);
-
-  gtk_binding_entry_add_signal (binding_set, GDK_space, GDK_MOD1_MASK,
-                               "delete_from_cursor", 2,
-                               GTK_TYPE_ENUM, GTK_DELETE_WHITESPACE,
-                               GTK_TYPE_INT, 1);
-  gtk_binding_entry_add_signal (binding_set, GDK_space, GDK_MOD1_MASK,
-                               "insert_at_cursor", 1,
-                               GTK_TYPE_STRING, " ");
+                               G_TYPE_ENUM, GTK_DELETE_WORD_ENDS,
+                               G_TYPE_INT, -1);
 
-  gtk_binding_entry_add_signal (binding_set, GDK_backslash, GDK_MOD1_MASK,
-                               "delete_from_cursor", 2,
-                               GTK_TYPE_ENUM, GTK_DELETE_WHITESPACE,
-                               GTK_TYPE_INT, 1);
-  
   /* Cut/copy/paste */
 
   gtk_binding_entry_add_signal (binding_set, GDK_x, GDK_CONTROL_MASK,
                                "cut_clipboard", 0);
-
-  gtk_binding_entry_add_signal (binding_set, GDK_w, GDK_CONTROL_MASK,
-                               "cut_clipboard", 0);
-  
   gtk_binding_entry_add_signal (binding_set, GDK_c, GDK_CONTROL_MASK,
                                "copy_clipboard", 0);
-  
   gtk_binding_entry_add_signal (binding_set, GDK_v, GDK_CONTROL_MASK,
                                "paste_clipboard", 0);
 
-  gtk_binding_entry_add_signal (binding_set, GDK_y, GDK_CONTROL_MASK,
+  gtk_binding_entry_add_signal (binding_set, GDK_Delete, GDK_SHIFT_MASK,
+                               "cut_clipboard", 0);
+  gtk_binding_entry_add_signal (binding_set, GDK_Insert, GDK_CONTROL_MASK,
+                               "copy_clipboard", 0);
+  gtk_binding_entry_add_signal (binding_set, GDK_Insert, GDK_SHIFT_MASK,
                                "paste_clipboard", 0);
 
   /* Overwrite */
   gtk_binding_entry_add_signal (binding_set, GDK_Insert, 0,
                                "toggle_overwrite", 0);
+  gtk_binding_entry_add_signal (binding_set, GDK_KP_Insert, 0,
+                               "toggle_overwrite", 0);
+
+  gtk_settings_install_property (g_param_spec_boolean ("gtk-entry-select-on-focus",
+                                                      _("Select on focus"),
+                                                      _("Whether to select the contents of an entry when it is focused"),
+                                                      TRUE,
+                                                      G_PARAM_READWRITE));
 }
 
 static void
 gtk_entry_editable_init (GtkEditableClass *iface)
 {
-  iface->insert_text = gtk_entry_insert_text;
-  iface->delete_text = gtk_entry_delete_text;
+  iface->do_insert_text = gtk_entry_insert_text;
+  iface->do_delete_text = gtk_entry_delete_text;
+  iface->insert_text = gtk_entry_real_insert_text;
+  iface->delete_text = gtk_entry_real_delete_text;
   iface->get_chars = gtk_entry_get_chars;
   iface->set_selection_bounds = gtk_entry_set_selection_bounds;
   iface->get_selection_bounds = gtk_entry_get_selection_bounds;
@@ -718,6 +773,12 @@ gtk_entry_editable_init (GtkEditableClass *iface)
   iface->get_position = gtk_entry_get_position;
 }
 
+static void
+gtk_entry_cell_editable_init (GtkCellEditableIface *iface)
+{
+  iface->start_editing = gtk_entry_start_editing;
+}
+
 static void
 gtk_entry_set_property (GObject         *object,
                         guint            prop_id,
@@ -728,11 +789,6 @@ gtk_entry_set_property (GObject         *object,
 
   switch (prop_id)
     {
-    case PROP_TEXT_POSITION:
-      gtk_editable_set_position (GTK_EDITABLE (object), 
-                                g_value_get_int (value));
-      break;
-
     case PROP_EDITABLE:
       {
         gboolean new_value = g_value_get_boolean (value);
@@ -741,6 +797,9 @@ gtk_entry_set_property (GObject         *object,
          {
            entry->editable = new_value;
            gtk_entry_queue_draw (entry);
+
+           if (!entry->editable)
+             gtk_entry_reset_im_context (entry);
          }
       }
       break;
@@ -753,8 +812,12 @@ gtk_entry_set_property (GObject         *object,
       gtk_entry_set_visibility (entry, g_value_get_boolean (value));
       break;
 
+    case PROP_HAS_FRAME:
+      gtk_entry_set_has_frame (entry, g_value_get_boolean (value));
+      break;
+
     case PROP_INVISIBLE_CHAR:
-      gtk_entry_set_invisible_char (entry, g_value_get_int (value));
+      gtk_entry_set_invisible_char (entry, g_value_get_uint (value));
       break;
 
     case PROP_ACTIVATES_DEFAULT:
@@ -764,7 +827,13 @@ gtk_entry_set_property (GObject         *object,
     case PROP_WIDTH_CHARS:
       gtk_entry_set_width_chars (entry, g_value_get_int (value));
       break;
-      
+
+    case PROP_TEXT:
+      gtk_entry_set_text (entry, g_value_get_string (value));
+      break;
+
+    case PROP_SCROLL_OFFSET:
+    case PROP_CURSOR_POSITION:
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
       break;
@@ -777,15 +846,16 @@ gtk_entry_get_property (GObject         *object,
                         GValue          *value,
                         GParamSpec      *pspec)
 {
-  GtkEntry *entry;
-
-  entry = GTK_ENTRY (object);
+  GtkEntry *entry = GTK_ENTRY (object);
 
   switch (prop_id)
     {
-    case PROP_TEXT_POSITION:
+    case PROP_CURSOR_POSITION:
       g_value_set_int (value, entry->current_pos);
       break;
+    case PROP_SELECTION_BOUND:
+      g_value_set_int (value, entry->selection_bound);
+      break;
     case PROP_EDITABLE:
       g_value_set_boolean (value, entry->editable);
       break;
@@ -795,8 +865,11 @@ gtk_entry_get_property (GObject         *object,
     case PROP_VISIBILITY:
       g_value_set_boolean (value, entry->visible);
       break;
+    case PROP_HAS_FRAME:
+      g_value_set_boolean (value, entry->has_frame);
+      break;
     case PROP_INVISIBLE_CHAR:
-      g_value_set_int (value, entry->invisible_char);
+      g_value_set_uint (value, entry->invisible_char);
       break;
     case PROP_ACTIVATES_DEFAULT:
       g_value_set_boolean (value, entry->activates_default);
@@ -804,6 +877,12 @@ gtk_entry_get_property (GObject         *object,
     case PROP_WIDTH_CHARS:
       g_value_set_int (value, entry->width_chars);
       break;
+    case PROP_SCROLL_OFFSET:
+      g_value_set_int (value, entry->scroll_offset);
+      break;
+    case PROP_TEXT:
+      g_value_set_string (value, gtk_entry_get_text (entry));
+      break;
       
     default:
       G_OBJECT_WARN_INVALID_PROPERTY_ID (object, prop_id, pspec);
@@ -825,11 +904,12 @@ gtk_entry_init (GtkEntry *entry)
   entry->invisible_char = '*';
   entry->dnd_position = -1;
   entry->width_chars = -1;
-  
+  entry->is_cell_renderer = FALSE;
+  entry->editing_canceled = FALSE;
   entry->has_frame = TRUE;
-  
+
   gtk_drag_dest_set (GTK_WIDGET (entry),
-                     GTK_DEST_DEFAULT_DROP | GTK_DEST_DEFAULT_HIGHLIGHT,
+                     GTK_DEST_DEFAULT_HIGHLIGHT,
                      target_table, G_N_ELEMENTS (target_table),
                      GDK_ACTION_COPY | GDK_ACTION_MOVE);
 
@@ -838,28 +918,28 @@ gtk_entry_init (GtkEntry *entry)
    */
   entry->im_context = gtk_im_multicontext_new ();
   
-  gtk_signal_connect (GTK_OBJECT (entry->im_context), "commit",
-                     GTK_SIGNAL_FUNC (gtk_entry_commit_cb), entry);
-  gtk_signal_connect (GTK_OBJECT (entry->im_context), "preedit_changed",
-                     GTK_SIGNAL_FUNC (gtk_entry_preedit_changed_cb), entry);
+  g_signal_connect (entry->im_context, "commit",
+                   G_CALLBACK (gtk_entry_commit_cb), entry);
+  g_signal_connect (entry->im_context, "preedit_changed",
+                   G_CALLBACK (gtk_entry_preedit_changed_cb), entry);
+  g_signal_connect (entry->im_context, "retrieve_surrounding",
+                   G_CALLBACK (gtk_entry_retrieve_surrounding_cb), entry);
+  g_signal_connect (entry->im_context, "delete_surrounding",
+                   G_CALLBACK (gtk_entry_delete_surrounding_cb), entry);
 }
 
 static void
 gtk_entry_finalize (GObject *object)
 {
-  GtkEntry *entry;
-
-  g_return_if_fail (GTK_IS_ENTRY (object));
-
-  entry = GTK_ENTRY (object);
+  GtkEntry *entry = GTK_ENTRY (object);
 
   if (entry->cached_layout)
-    g_object_unref (G_OBJECT (entry->cached_layout));
+    g_object_unref (entry->cached_layout);
 
-  gtk_object_unref (GTK_OBJECT (entry->im_context));
+  g_object_unref (entry->im_context);
 
-  if (entry->timer)
-    g_source_remove (entry->timer);
+  if (entry->blink_timeout)
+    g_source_remove (entry->blink_timeout);
 
   if (entry->recompute_idle)
     g_source_remove (entry->recompute_idle);
@@ -873,48 +953,22 @@ gtk_entry_finalize (GObject *object)
   G_OBJECT_CLASS (parent_class)->finalize (object);
 }
 
-static void
-gtk_entry_realize_cursor_gc (GtkEntry *entry)
-{
-  GdkColor *cursor_color;
-  
-  if (entry->cursor_gc)
-    gdk_gc_unref (entry->cursor_gc);
-
-  gtk_widget_style_get (GTK_WIDGET (entry), "cursor_color", &cursor_color, NULL);
-  if (cursor_color)
-    {
-      entry->cursor_gc = gdk_gc_new (entry->text_area);
-      gdk_gc_set_rgb_fg_color (entry->cursor_gc, cursor_color);
-    }
-  else
-    entry->cursor_gc = gdk_gc_ref (GTK_WIDGET (entry)->style->base_gc[GTK_STATE_SELECTED]);
-}
-
 static void
 gtk_entry_realize (GtkWidget *widget)
 {
   GtkEntry *entry;
   GtkEditable *editable;
-  GtkRequisition requisition;
   GdkWindowAttr attributes;
   gint attributes_mask;
 
-  g_return_if_fail (widget != NULL);
-  g_return_if_fail (GTK_IS_ENTRY (widget));
-
   GTK_WIDGET_SET_FLAGS (widget, GTK_REALIZED);
   entry = GTK_ENTRY (widget);
   editable = GTK_EDITABLE (widget);
 
-  gtk_widget_get_child_requisition (widget, &requisition);
-  
   attributes.window_type = GDK_WINDOW_CHILD;
-  attributes.x = widget->allocation.x;
-  attributes.y = widget->allocation.y + (widget->allocation.height -
-                                        requisition.height) / 2;
-  attributes.width = widget->allocation.width;
-  attributes.height = requisition.height;
+  
+  get_widget_window_size (entry, &attributes.x, &attributes.y, &attributes.width, &attributes.height);
+
   attributes.wclass = GDK_INPUT_OUTPUT;
   attributes.visual = gtk_widget_get_visual (widget);
   attributes.colormap = gtk_widget_get_colormap (widget);
@@ -925,6 +979,7 @@ gtk_entry_realize (GtkWidget *widget)
                            GDK_BUTTON1_MOTION_MASK |
                            GDK_BUTTON3_MOTION_MASK |
                            GDK_POINTER_MOTION_HINT_MASK |
+                           GDK_POINTER_MOTION_MASK |
                             GDK_ENTER_NOTIFY_MASK |
                            GDK_LEAVE_NOTIFY_MASK);
   attributes_mask = GDK_WA_X | GDK_WA_Y | GDK_WA_VISUAL | GDK_WA_COLORMAP;
@@ -932,31 +987,18 @@ gtk_entry_realize (GtkWidget *widget)
   widget->window = gdk_window_new (gtk_widget_get_parent_window (widget), &attributes, attributes_mask);
   gdk_window_set_user_data (widget->window, entry);
 
-  if (entry->has_frame)
-    {
-      attributes.x = widget->style->xthickness;
-      attributes.y = widget->style->ythickness;
-    }
-  else
-    {
-      attributes.x = 0;
-      attributes.y = 0;
-    }
-  
-  attributes.width = widget->allocation.width - attributes.x * 2;
-  attributes.height = requisition.height - attributes.y * 2;
-  attributes.cursor = gdk_cursor_new (GDK_XTERM);
+  get_text_area_size (entry, &attributes.x, &attributes.y, &attributes.width, &attributes.height);
+
+  attributes.cursor = gdk_cursor_new_for_display (gtk_widget_get_display (widget), GDK_XTERM);
   attributes_mask |= GDK_WA_CURSOR;
 
   entry->text_area = gdk_window_new (widget->window, &attributes, attributes_mask);
   gdk_window_set_user_data (entry->text_area, entry);
 
-  gdk_cursor_destroy (attributes.cursor);
+  gdk_cursor_unref (attributes.cursor);
 
   widget->style = gtk_style_attach (widget->style, widget->window);
 
-  gtk_entry_realize_cursor_gc (entry);
-
   gdk_window_set_background (widget->window, &widget->style->base[GTK_WIDGET_STATE (widget)]);
   gdk_window_set_background (entry->text_area, &widget->style->base[GTK_WIDGET_STATE (widget)]);
 
@@ -965,19 +1007,22 @@ gtk_entry_realize (GtkWidget *widget)
   gtk_im_context_set_client_window (entry->im_context, entry->text_area);
 
   gtk_entry_adjust_scroll (entry);
+  gtk_entry_update_primary_selection (entry);
 }
 
 static void
 gtk_entry_unrealize (GtkWidget *widget)
 {
-  GtkEntry *entry;
-
-  g_return_if_fail (widget != NULL);
-  g_return_if_fail (GTK_IS_ENTRY (widget));
+  GtkEntry *entry = GTK_ENTRY (widget);
+  GtkClipboard *clipboard;
 
-  entry = GTK_ENTRY (widget);
+  gtk_entry_reset_layout (entry);
+  
+  gtk_im_context_set_client_window (entry->im_context, NULL);
 
-  gtk_im_context_set_client_window (entry->im_context, entry->text_area);
+  clipboard = gtk_widget_get_clipboard (widget, GDK_SELECTION_PRIMARY);
+  if (gtk_clipboard_get_owner (clipboard) == G_OBJECT (entry))
+    gtk_clipboard_clear (clipboard);
   
   if (entry->text_area)
     {
@@ -986,12 +1031,6 @@ gtk_entry_unrealize (GtkWidget *widget)
       entry->text_area = NULL;
     }
 
-  if (entry->cursor_gc)
-    {
-      gdk_gc_unref (entry->cursor_gc);
-      entry->cursor_gc = NULL;
-    }
-
   if (entry->popup_menu)
     {
       gtk_widget_destroy (entry->popup_menu);
@@ -1003,86 +1042,70 @@ gtk_entry_unrealize (GtkWidget *widget)
 }
 
 static void
-gtk_entry_size_request (GtkWidget      *widget,
-                       GtkRequisition *requisition)
+get_borders (GtkEntry *entry,
+             gint     *xborder,
+             gint     *yborder)
 {
-  GtkEntry *entry;
-  PangoFontMetrics metrics;
-  PangoFont *font;
-  gchar *lang;
-  gint xborder, yborder;
-  
-  g_return_if_fail (widget != NULL);
-  g_return_if_fail (GTK_IS_ENTRY (widget));
-  g_return_if_fail (requisition != NULL);
-
-  entry = GTK_ENTRY (widget);
-  
-  /* hackish for now, get metrics
-   */
-  font = pango_context_load_font (gtk_widget_get_pango_context (widget),
-                                 widget->style->font_desc);
-  lang = pango_context_get_lang (gtk_widget_get_pango_context (widget));
-  pango_font_get_metrics (font, lang, &metrics);
-  g_free (lang);
-  
-  g_object_unref (G_OBJECT (font));
+  GtkWidget *widget = GTK_WIDGET (entry);
+  gint focus_width;
+  gboolean interior_focus;
 
-  entry->ascent = metrics.ascent;
-  entry->descent = metrics.descent;
+  gtk_widget_style_get (widget,
+                       "interior-focus", &interior_focus,
+                       "focus-line-width", &focus_width,
+                       NULL);
 
-  xborder = INNER_BORDER;
-  yborder = INNER_BORDER;
-  
   if (entry->has_frame)
     {
-      xborder += widget->style->xthickness;
-      yborder += widget->style->ythickness;
+      *xborder = widget->style->xthickness;
+      *yborder = widget->style->ythickness;
     }
   else
     {
-      /* add 1 pixel to draw focus rect in widget->window */
-      xborder += 1;
-      yborder += 1;
+      *xborder = 0;
+      *yborder = 0;
     }
 
-  if (entry->width_chars < 0)
-    requisition->width = MIN_ENTRY_WIDTH + xborder * 2;
-  else
+  if (!interior_focus)
     {
-      requisition->width =
-        PANGO_PIXELS (metrics.approximate_char_width) * entry->width_chars +
-        xborder * 2;
+      *xborder += focus_width;
+      *yborder += focus_width;
     }
-    
-  requisition->height = ((metrics.ascent + metrics.descent) / PANGO_SCALE + 
-                         yborder * 2);
 }
 
 static void
-get_borders (GtkEntry *entry,
-             gint     *xborder,
-             gint     *yborder)
+gtk_entry_size_request (GtkWidget      *widget,
+                       GtkRequisition *requisition)
 {
-  GtkWidget *widget;
+  GtkEntry *entry = GTK_ENTRY (widget);
+  PangoFontMetrics *metrics;
+  gint xborder, yborder;
+  PangoContext *context;
+  
+  context = gtk_widget_get_pango_context (widget);
+  metrics = pango_context_get_metrics (context,
+                                      widget->style->font_desc,
+                                      pango_context_get_language (context));
 
-  widget = GTK_WIDGET (entry);
+  entry->ascent = pango_font_metrics_get_ascent (metrics);
+  entry->descent = pango_font_metrics_get_descent (metrics);
+
+  get_borders (entry, &xborder, &yborder);
   
-  if (entry->has_frame)
-    {
-      if (xborder)
-        *xborder = widget->style->xthickness;
-      if (yborder)
-        *yborder = widget->style->ythickness;
-    }
+  xborder += INNER_BORDER;
+  yborder += INNER_BORDER;
+  
+  if (entry->width_chars < 0)
+    requisition->width = MIN_ENTRY_WIDTH + xborder * 2;
   else
     {
-      /* 1 pixel for focus rect */
-      if (xborder)
-        *xborder = 1;
-      if (yborder)
-        *yborder = 1;
+      gint char_width = pango_font_metrics_get_approximate_char_width (metrics);
+      requisition->width = PANGO_PIXELS (char_width) * entry->width_chars + xborder * 2;
     }
+    
+  requisition->height = PANGO_PIXELS (entry->ascent + entry->descent) + yborder * 2;
+
+  pango_font_metrics_unref (metrics);
 }
 
 static void
@@ -1094,10 +1117,8 @@ get_text_area_size (GtkEntry *entry,
 {
   gint xborder, yborder;
   GtkRequisition requisition;
-  GtkWidget *widget;
+  GtkWidget *widget = GTK_WIDGET (entry);
 
-  widget = GTK_WIDGET (entry);
-  
   gtk_widget_get_child_requisition (widget, &requisition);
 
   get_borders (entry, &xborder, &yborder);
@@ -1123,9 +1144,7 @@ get_widget_window_size (GtkEntry *entry,
                         gint     *height)
 {
   GtkRequisition requisition;
-  GtkWidget *widget;  
-
-  widget = GTK_WIDGET (entry);
+  GtkWidget *widget = GTK_WIDGET (entry);
       
   gtk_widget_get_child_requisition (widget, &requisition);
 
@@ -1133,29 +1152,32 @@ get_widget_window_size (GtkEntry *entry,
     *x = widget->allocation.x;
 
   if (y)
-    *y = widget->allocation.y + (widget->allocation.height - requisition.height) / 2;
+    {
+      if (entry->is_cell_renderer)
+       *y = widget->allocation.y;
+      else
+       *y = widget->allocation.y + (widget->allocation.height - requisition.height) / 2;
+    }
 
   if (width)
     *width = widget->allocation.width;
 
   if (height)
-    *height = requisition.height;
+    {
+      if (entry->is_cell_renderer)
+       *height = widget->allocation.height;
+      else
+       *height = requisition.height;
+    }
 }
 
 static void
 gtk_entry_size_allocate (GtkWidget     *widget,
                         GtkAllocation *allocation)
 {
-  GtkEntry *entry;
-  GtkEditable *editable;
+  GtkEntry *entry = GTK_ENTRY (widget);
   
-  g_return_if_fail (widget != NULL);
-  g_return_if_fail (GTK_IS_ENTRY (widget));
-  g_return_if_fail (allocation != NULL);
-
   widget->allocation = *allocation;
-  entry = GTK_ENTRY (widget);
-  editable = GTK_EDITABLE (widget);
   
   if (GTK_WIDGET_REALIZED (widget))
     {
@@ -1180,50 +1202,43 @@ gtk_entry_size_allocate (GtkWidget     *widget,
 }
 
 static void
-gtk_entry_draw_focus (GtkWidget *widget)
+gtk_entry_draw_frame (GtkWidget *widget)
 {
+  gint x = 0, y = 0;
   gint width, height;
-  GtkEntry *entry;
   gboolean interior_focus;
+  gint focus_width;
+  
+  gtk_widget_style_get (widget,
+                       "interior-focus", &interior_focus,
+                       "focus-line-width", &focus_width,
+                       NULL);
   
-  g_return_if_fail (widget != NULL);
-  g_return_if_fail (GTK_IS_ENTRY (widget));
+  gdk_drawable_get_size (widget->window, &width, &height);
+  
+  if (GTK_WIDGET_HAS_FOCUS (widget) && !interior_focus)
+    {
+      x += focus_width;
+      y += focus_width;
+      width -= 2 * focus_width;
+      height -= 2 * focus_width;
+    }
 
-  gtk_widget_style_get (widget, "interior_focus", &interior_focus, NULL);
+  gtk_paint_shadow (widget->style, widget->window,
+                   GTK_STATE_NORMAL, GTK_SHADOW_IN,
+                   NULL, widget, "entry",
+                   x, y, width, height);
 
-  entry = GTK_ENTRY (widget);
-  
-  if (GTK_WIDGET_DRAWABLE (widget))
-    {      
-      if (entry->has_frame)
-        {
-          gint x = 0, y = 0;
-
-          gdk_window_get_size (widget->window, &width, &height);
-
-          if (GTK_WIDGET_HAS_FOCUS (widget) && !interior_focus)
-            {
-              x += 1;
-              y += 1;
-              width -= 2;
-              height -= 2;
-            }
-
-          gtk_paint_shadow (widget->style, widget->window,
-                            GTK_STATE_NORMAL, GTK_SHADOW_IN,
-                            NULL, widget, "entry",
-                            x, y, width, height);
-        }
-      else
-        gdk_window_clear (widget->window);
-        
-      if (GTK_WIDGET_HAS_FOCUS (widget) && !interior_focus)
-        {
-          gdk_window_get_size (widget->window, &width, &height);
-          gtk_paint_focus (widget->style, widget->window, 
-                           NULL, widget, "entry",
-                           0, 0, width - 1, height - 1);
-        }
+  if (GTK_WIDGET_HAS_FOCUS (widget) && !interior_focus)
+    {
+      x -= focus_width;
+      y -= focus_width;
+      width += 2 * focus_width;
+      height += 2 * focus_width;
+      
+      gtk_paint_focus (widget->style, widget->window, GTK_WIDGET_STATE (widget), 
+                      NULL, widget, "entry",
+                      0, 0, width, height);
     }
 }
 
@@ -1231,27 +1246,30 @@ static gint
 gtk_entry_expose (GtkWidget      *widget,
                  GdkEventExpose *event)
 {
-  GtkEntry *entry;
-
-  g_return_val_if_fail (widget != NULL, FALSE);
-  g_return_val_if_fail (GTK_IS_ENTRY (widget), FALSE);
-  g_return_val_if_fail (event != NULL, FALSE);
-
-  entry = GTK_ENTRY (widget);
+  GtkEntry *entry = GTK_ENTRY (widget);
 
   if (widget->window == event->window)
-    gtk_entry_draw_focus (widget);
+    gtk_entry_draw_frame (widget);
   else if (entry->text_area == event->window)
     {
-      gtk_entry_draw_text (GTK_ENTRY (widget));
+      gint area_width, area_height;
+
+      get_text_area_size (entry, NULL, NULL, &area_width, &area_height);
 
+      gtk_paint_flat_box (widget->style, entry->text_area, 
+                         GTK_WIDGET_STATE(widget), GTK_SHADOW_NONE,
+                         NULL, widget, "entry_bg", 
+                         0, 0, area_width, area_height);
+      
       if ((entry->visible || entry->invisible_char != 0) &&
          GTK_WIDGET_HAS_FOCUS (widget) &&
-         entry->selection_bound == entry->current_pos)
+         entry->selection_bound == entry->current_pos && entry->cursor_visible)
        gtk_entry_draw_cursor (GTK_ENTRY (widget), CURSOR_STANDARD);
 
       if (entry->dnd_position != -1)
        gtk_entry_draw_cursor (GTK_ENTRY (widget), CURSOR_DND);
+      
+      gtk_entry_draw_text (GTK_ENTRY (widget));
     }
 
   return FALSE;
@@ -1266,9 +1284,6 @@ gtk_entry_button_press (GtkWidget      *widget,
   gint tmp_pos;
   gint sel_start, sel_end;
 
-  entry = GTK_ENTRY (widget);
-  editable = GTK_EDITABLE (widget);
-  
   if (event->window != entry->text_area ||
       (entry->button && event->button != entry->button))
     return FALSE;
@@ -1276,7 +1291,11 @@ gtk_entry_button_press (GtkWidget      *widget,
   entry->button = event->button;
   
   if (!GTK_WIDGET_HAS_FOCUS (widget))
-    gtk_widget_grab_focus (widget);
+    {
+      entry->in_click = TRUE;
+      gtk_widget_grab_focus (widget);
+      entry->in_click = FALSE;
+    }
   
   tmp_pos = gtk_entry_find_position (entry, event->x + entry->scroll_offset);
     
@@ -1286,13 +1305,15 @@ gtk_entry_button_press (GtkWidget      *widget,
       
       if (event->state & GDK_SHIFT_MASK)
        {
+         gtk_entry_reset_im_context (entry);
+         
          if (!have_selection) /* select from the current position to the clicked position */
            sel_start = sel_end = entry->current_pos;
          
          if (tmp_pos > sel_start && tmp_pos < sel_end)
            {
              /* Truncate current selection */
-             entry->current_pos = tmp_pos;
+             gtk_entry_set_positions (entry, tmp_pos, -1);
            }
          else
            {
@@ -1303,7 +1324,7 @@ gtk_entry_button_press (GtkWidget      *widget,
              switch (event->type)
                {
                case GDK_BUTTON_PRESS:
-                 entry->current_pos = entry->selection_bound = tmp_pos;
+                 gtk_entry_set_positions (entry, tmp_pos, tmp_pos);
                  break;
                  
                case GDK_2BUTTON_PRESS:
@@ -1330,18 +1351,10 @@ gtk_entry_button_press (GtkWidget      *widget,
                extend_to_left = (end == sel_end);
              
              if (extend_to_left)
-               {
-                 entry->selection_bound = end;
-                 entry->current_pos = start;
-               }
+               gtk_entry_set_positions (entry, start, end);
              else
-               {
-                 entry->selection_bound = start;
-                 entry->current_pos = end;
-               }
+               gtk_entry_set_positions (entry, end, start);
            }
-         
-         gtk_entry_recompute (entry);
        }
       else /* no shift key */
        switch (event->type)
@@ -1358,14 +1371,7 @@ gtk_entry_button_press (GtkWidget      *widget,
              entry->drag_start_y = event->y + entry->scroll_offset;
            }
          else
-           {
-             gtk_entry_reset_im_context (entry);
-             
-             entry->current_pos = tmp_pos;
-             entry->selection_bound = tmp_pos;
-
-             gtk_entry_recompute (entry);
-           }
+           gtk_editable_set_position (editable, tmp_pos);
          
          break;
 
@@ -1425,12 +1431,7 @@ gtk_entry_button_release (GtkWidget      *widget,
     {
       gint tmp_pos = gtk_entry_find_position (entry, entry->drag_start_x);
 
-      gtk_entry_reset_im_context (entry);
-             
-      entry->current_pos = tmp_pos;
-      entry->selection_bound = tmp_pos;
-             
-      gtk_entry_recompute (entry);
+      gtk_editable_set_position (GTK_EDITABLE (entry), tmp_pos);
 
       entry->in_drag = 0;
     }
@@ -1449,7 +1450,17 @@ gtk_entry_motion_notify (GtkWidget      *widget,
   GtkEntry *entry = GTK_ENTRY (widget);
   gint tmp_pos;
 
-  if (event->window != entry->text_area || entry->button != 1)
+  if (entry->mouse_cursor_obscured)
+    {
+      GdkCursor *cursor;
+      
+      cursor = gdk_cursor_new_for_display (gtk_widget_get_display (widget), GDK_XTERM);
+      gdk_window_set_cursor (entry->text_area, cursor);
+      gdk_cursor_unref (cursor);
+      entry->mouse_cursor_obscured = FALSE;
+    }
+
+  if (event->window != entry->text_area || entry->button !=1)
     return FALSE;
 
   if (event->is_hint || (entry->text_area != event->window))
@@ -1463,8 +1474,9 @@ gtk_entry_motion_notify (GtkWidget      *widget,
        {
          GdkDragContext *context;
          GtkTargetList *target_list = gtk_target_list_new (target_table, G_N_ELEMENTS (target_table));
+         guint actions = entry->editable ? GDK_ACTION_COPY | GDK_ACTION_MOVE : GDK_ACTION_COPY;
          
-         context = gtk_drag_begin (widget, target_list, GDK_ACTION_COPY | GDK_ACTION_MOVE,
+         context = gtk_drag_begin (widget, target_list, actions,
                          entry->button, (GdkEvent *)event);
 
          
@@ -1477,33 +1489,79 @@ gtk_entry_motion_notify (GtkWidget      *widget,
     }
   else
     {
-      tmp_pos = gtk_entry_find_position (entry, event->x + entry->scroll_offset);
+      gint height;
+      gdk_drawable_get_size (entry->text_area, NULL, &height);
 
-      if (tmp_pos != entry->current_pos)
-       {
-         entry->current_pos = tmp_pos;
-         gtk_entry_recompute (entry);
-       }
+      if (event->y < 0)
+       tmp_pos = 0;
+      else if (event->y >= height)
+       tmp_pos = entry->text_length;
+      else
+       tmp_pos = gtk_entry_find_position (entry, event->x + entry->scroll_offset);
+      
+      gtk_entry_set_positions (entry, tmp_pos, -1);
     }
       
   return TRUE;
 }
 
-static gint
-gtk_entry_key_press (GtkWidget   *widget,
-                    GdkEventKey *event)
+static void
+set_invisible_cursor (GdkWindow *window)
 {
-  GtkEntry *entry = GTK_ENTRY (widget);
-
-  if (!entry->editable)
-    return FALSE;
-
-  if (gtk_im_context_filter_keypress (entry->im_context, event))
-    {
-      entry->need_im_reset = TRUE;
-      return TRUE;
+  GdkBitmap *empty_bitmap;
+  GdkCursor *cursor;
+  GdkColor useless;
+  char invisible_cursor_bits[] = { 0x0 };      
+       
+  useless.red = useless.green = useless.blue = 0;
+  useless.pixel = 0;
+  
+  empty_bitmap = gdk_bitmap_create_from_data (window,
+                                             invisible_cursor_bits,
+                                             1, 1);
+  
+  cursor = gdk_cursor_new_from_pixmap (empty_bitmap,
+                                      empty_bitmap,
+                                      &useless,
+                                      &useless, 0, 0);
+  
+  gdk_window_set_cursor (window, cursor);
+  
+  gdk_cursor_unref (cursor);
+  
+  g_object_unref (empty_bitmap);
+}
+
+static void
+gtk_entry_obscure_mouse_cursor (GtkEntry *entry)
+{
+  if (entry->mouse_cursor_obscured)
+    return;
+
+  set_invisible_cursor (entry->text_area);
+  
+  entry->mouse_cursor_obscured = TRUE;  
+}
+
+static gint
+gtk_entry_key_press (GtkWidget   *widget,
+                    GdkEventKey *event)
+{
+  GtkEntry *entry = GTK_ENTRY (widget);
+
+  gtk_entry_pend_cursor_blink (entry);
+
+  if (entry->editable)
+    {
+      if (gtk_im_context_filter_keypress (entry->im_context, event))
+       {
+         gtk_entry_obscure_mouse_cursor (entry);
+         entry->need_im_reset = TRUE;
+         return TRUE;
+       }
     }
-  else if (GTK_WIDGET_CLASS (parent_class)->key_press_event (widget, event))
+
+  if (GTK_WIDGET_CLASS (parent_class)->key_press_event (widget, event))
     /* Activate key bindings
      */
     return TRUE;
@@ -1511,20 +1569,40 @@ gtk_entry_key_press (GtkWidget   *widget,
   return FALSE;
 }
 
+static gint
+gtk_entry_key_release (GtkWidget   *widget,
+                      GdkEventKey *event)
+{
+  GtkEntry *entry = GTK_ENTRY (widget);
+
+  if (entry->editable)
+    {
+      if (gtk_im_context_filter_keypress (entry->im_context, event))
+       {
+         entry->need_im_reset = TRUE;
+         return TRUE;
+       }
+    }
+
+  return GTK_WIDGET_CLASS (parent_class)->key_release_event (widget, event);
+}
+
 static gint
 gtk_entry_focus_in (GtkWidget     *widget,
                    GdkEventFocus *event)
 {
-  g_return_val_if_fail (widget != NULL, FALSE);
-  g_return_val_if_fail (GTK_IS_ENTRY (widget), FALSE);
-  g_return_val_if_fail (event != NULL, FALSE);
-
-  GTK_WIDGET_SET_FLAGS (widget, GTK_HAS_FOCUS);
-  gtk_entry_draw_focus (widget);
-  gtk_entry_queue_draw (GTK_ENTRY (widget));
+  GtkEntry *entry = GTK_ENTRY (widget);
   
-  GTK_ENTRY (widget)->need_im_reset = TRUE;
-  gtk_im_context_focus_in (GTK_ENTRY (widget)->im_context);
+  gtk_widget_queue_draw (widget);
+  
+  entry->need_im_reset = TRUE;
+  gtk_im_context_focus_in (entry->im_context);
+
+  g_signal_connect (gdk_keymap_get_for_display (gtk_widget_get_display (widget)),
+                   "direction_changed",
+                   G_CALLBACK (gtk_entry_keymap_direction_changed), entry);
+
+  gtk_entry_check_cursor_blink (entry);
 
   return FALSE;
 }
@@ -1533,20 +1611,39 @@ static gint
 gtk_entry_focus_out (GtkWidget     *widget,
                     GdkEventFocus *event)
 {
-  g_return_val_if_fail (widget != NULL, FALSE);
-  g_return_val_if_fail (GTK_IS_ENTRY (widget), FALSE);
-  g_return_val_if_fail (event != NULL, FALSE);
-
-  GTK_WIDGET_UNSET_FLAGS (widget, GTK_HAS_FOCUS);
-  gtk_entry_draw_focus (widget);
-  gtk_entry_queue_draw (GTK_ENTRY (widget));
+  GtkEntry *entry = GTK_ENTRY (widget);
+  
+  gtk_widget_queue_draw (widget);
 
-  GTK_ENTRY (widget)->need_im_reset = TRUE;
-  gtk_im_context_focus_out (GTK_ENTRY (widget)->im_context);
+  entry->need_im_reset = TRUE;
+  gtk_im_context_focus_out (entry->im_context);
 
+  gtk_entry_check_cursor_blink (entry);
+  
+  g_signal_handlers_disconnect_by_func (gdk_keymap_get_for_display (gtk_widget_get_display (widget)),
+                                        gtk_entry_keymap_direction_changed,
+                                        entry);
+  
   return FALSE;
 }
 
+static void
+gtk_entry_grab_focus (GtkWidget        *widget)
+{
+  GtkEntry *entry = GTK_ENTRY (widget);
+  gboolean select_on_focus;
+  
+  GTK_WIDGET_CLASS (parent_class)->grab_focus (widget);
+
+  g_object_get (G_OBJECT (gtk_widget_get_settings (widget)),
+               "gtk-entry-select-on-focus",
+               &select_on_focus,
+               NULL);
+  
+  if (select_on_focus && entry->editable && !entry->in_click)
+    gtk_editable_select_region (GTK_EDITABLE (widget), 0, -1);
+}
+
 static void 
 gtk_entry_direction_changed (GtkWidget        *widget,
                             GtkTextDirection  previous_dir)
@@ -1562,16 +1659,21 @@ static void
 gtk_entry_state_changed (GtkWidget      *widget,
                         GtkStateType    previous_state)
 {
-  g_return_if_fail (widget != NULL);
-  g_return_if_fail (GTK_IS_ENTRY (widget));
-
+  GtkEntry *entry = GTK_ENTRY (widget);
+  
   if (GTK_WIDGET_REALIZED (widget))
     {
       gdk_window_set_background (widget->window, &widget->style->base[GTK_WIDGET_STATE (widget)]);
-      gdk_window_set_background (GTK_ENTRY (widget)->text_area, &widget->style->base[GTK_WIDGET_STATE (widget)]);
+      gdk_window_set_background (entry->text_area, &widget->style->base[GTK_WIDGET_STATE (widget)]);
     }
 
-  gtk_widget_queue_clear (widget);
+  if (!GTK_WIDGET_IS_SENSITIVE (widget))
+    {
+      /* Clear any selection */
+      gtk_editable_select_region (GTK_EDITABLE (entry), entry->current_pos, entry->current_pos);      
+    }
+  
+  gtk_widget_queue_draw (widget);
 }
 
 /* GtkEditable method implementations
@@ -1589,7 +1691,7 @@ gtk_entry_insert_text (GtkEditable *editable,
   if (*position < 0 || *position > entry->text_length)
     *position = entry->text_length;
   
-  g_object_ref (G_OBJECT (editable));
+  g_object_ref (editable);
   
   if (new_text_length <= 63)
     text = buf;
@@ -1598,14 +1700,13 @@ gtk_entry_insert_text (GtkEditable *editable,
 
   text[new_text_length] = '\0';
   strncpy (text, new_text, new_text_length);
-
-  gtk_signal_emit (GTK_OBJECT (editable), signals[INSERT_TEXT], text, new_text_length, position);
-  gtk_signal_emit (GTK_OBJECT (editable), signals[CHANGED]);
+  
+  g_signal_emit_by_name (editable, "insert_text", text, new_text_length, position);
 
   if (new_text_length > 63)
     g_free (text);
 
-  g_object_unref (G_OBJECT (editable));
+  g_object_unref (editable);
 }
 
 static void
@@ -1622,12 +1723,11 @@ gtk_entry_delete_text (GtkEditable *editable,
   if (start_pos > end_pos)
     start_pos = end_pos;
   
-  g_object_ref (G_OBJECT (editable));
+  g_object_ref (editable);
 
-  gtk_signal_emit (GTK_OBJECT (editable), signals[DELETE_TEXT], start_pos, end_pos);
-  gtk_signal_emit (GTK_OBJECT (editable), signals[CHANGED]);
+  g_signal_emit_by_name (editable, "delete_text", start_pos, end_pos);
 
-  g_object_unref (G_OBJECT (editable));
+  g_object_unref (editable);
 }
 
 static gchar *    
@@ -1635,14 +1735,9 @@ gtk_entry_get_chars      (GtkEditable   *editable,
                          gint           start_pos,
                          gint           end_pos)
 {
-  GtkEntry *entry;
+  GtkEntry *entry = GTK_ENTRY (editable);
   gint start_index, end_index;
   
-  g_return_val_if_fail (editable != NULL, NULL);
-  g_return_val_if_fail (GTK_IS_ENTRY (editable), NULL);
-
-  entry = GTK_ENTRY (editable);
-
   if (end_pos < 0)
     end_pos = entry->text_length;
 
@@ -1664,14 +1759,11 @@ gtk_entry_real_set_position (GtkEditable *editable,
   if (position < 0 || position > entry->text_length)
     position = entry->text_length;
 
-  if (position != entry->current_pos)
+  if (position != entry->current_pos ||
+      position != entry->selection_bound)
     {
       gtk_entry_reset_im_context (entry);
-
-      entry->current_pos = entry->selection_bound = position;
-      gtk_entry_recompute (entry);
-
-      g_object_notify (G_OBJECT (entry), "text_position");
+      gtk_entry_set_positions (entry, position, position);
     }
 }
 
@@ -1695,12 +1787,11 @@ gtk_entry_set_selection_bounds (GtkEditable *editable,
   
   gtk_entry_reset_im_context (entry);
 
-  entry->selection_bound = MIN (start, entry->text_length);
-  entry->current_pos = MIN (end, entry->text_length);
+  gtk_entry_set_positions (entry,
+                          MIN (end, entry->text_length),
+                          MIN (start, entry->text_length));
 
   gtk_entry_update_primary_selection (entry);
-  
-  gtk_entry_recompute (entry);
 }
 
 static gboolean
@@ -1728,15 +1819,60 @@ gtk_entry_style_set     (GtkWidget      *widget,
 
       gdk_window_set_background (widget->window, &widget->style->base[GTK_WIDGET_STATE (widget)]);
       gdk_window_set_background (entry->text_area, &widget->style->base[GTK_WIDGET_STATE (widget)]);
+    }
+}
+
+/* GtkCellEditable method implementations
+ */
+static void
+gtk_cell_editable_entry_activated (GtkEntry *entry, gpointer data)
+{
+  gtk_cell_editable_editing_done (GTK_CELL_EDITABLE (entry));
+  gtk_cell_editable_remove_widget (GTK_CELL_EDITABLE (entry));
+}
+
+static gboolean
+gtk_cell_editable_key_press_event (GtkEntry    *entry,
+                                  GdkEventKey *key_event,
+                                  gpointer     data)
+{
+  if (key_event->keyval == GDK_Escape)
+    {
+      entry->editing_canceled = TRUE;
+      gtk_cell_editable_editing_done (GTK_CELL_EDITABLE (entry));
+      gtk_cell_editable_remove_widget (GTK_CELL_EDITABLE (entry));
 
-      gtk_entry_realize_cursor_gc (entry);
+      return TRUE;
+    }
+
+  /* override focus */
+  if (key_event->keyval == GDK_Up || key_event->keyval == GDK_Down)
+    {
+      gtk_cell_editable_editing_done (GTK_CELL_EDITABLE (entry));
+      gtk_cell_editable_remove_widget (GTK_CELL_EDITABLE (entry));
+
+      return TRUE;
     }
+
+  return FALSE;
+}
+
+static void
+gtk_entry_start_editing (GtkCellEditable *cell_editable,
+                        GdkEvent        *event)
+{
+  GTK_ENTRY (cell_editable)->is_cell_renderer = TRUE;
+
+  g_signal_connect (cell_editable, "activate",
+                   G_CALLBACK (gtk_cell_editable_entry_activated), NULL);
+  g_signal_connect (cell_editable, "key_press_event",
+                   G_CALLBACK (gtk_cell_editable_key_press_event), NULL);
 }
 
 /* Default signal handlers
  */
 static void
-gtk_entry_real_insert_text (GtkEntry    *entry,
+gtk_entry_real_insert_text (GtkEditable *editable,
                            const gchar *new_text,
                            gint         new_text_length,
                            gint        *position)
@@ -1744,14 +1880,17 @@ gtk_entry_real_insert_text (GtkEntry    *entry,
   gint index;
   gint n_chars;
 
+  GtkEntry *entry = GTK_ENTRY (editable);
+
   if (new_text_length < 0)
     new_text_length = strlen (new_text);
 
   n_chars = g_utf8_strlen (new_text, new_text_length);
   if (entry->text_max_length > 0 && n_chars + entry->text_length > entry->text_max_length)
     {
-      gdk_beep ();
+      gdk_display_beep (gtk_widget_get_display (GTK_WIDGET (entry)));
       n_chars = entry->text_max_length - entry->text_length;
+      new_text_length = g_utf8_offset_to_pointer (new_text, n_chars) - new_text;
     }
 
   if (new_text_length + entry->n_bytes + 1 > entry->text_size)
@@ -1768,7 +1907,12 @@ gtk_entry_real_insert_text (GtkEntry    *entry,
              else
                {
                  entry->text_size = MAX_SIZE;
-                 new_text_length = entry->text_size - new_text_length - 1;
+                 if (new_text_length > (gint)entry->text_size - (gint)entry->n_bytes - 1)
+                   {
+                     new_text_length = (gint)entry->text_size - (gint)entry->n_bytes - 1;
+                     new_text_length = g_utf8_find_prev_char (new_text, new_text + new_text_length + 1) - new_text;
+                     n_chars = g_utf8_strlen (new_text, new_text_length);
+                   }
                  break;
                }
            }
@@ -1797,13 +1941,18 @@ gtk_entry_real_insert_text (GtkEntry    *entry,
   *position += n_chars;
 
   gtk_entry_recompute (entry);
+
+  g_signal_emit_by_name (editable, "changed");
+  g_object_notify (G_OBJECT (editable), "text");
 }
 
 static void
-gtk_entry_real_delete_text (GtkEntry *entry,
-                           gint      start_pos,
-                           gint      end_pos)
+gtk_entry_real_delete_text (GtkEditable *editable,
+                           gint         start_pos,
+                           gint         end_pos)
 {
+  GtkEntry *entry = GTK_ENTRY (editable);
+
   if (start_pos < 0)
     start_pos = 0;
   if (end_pos < 0 || end_pos > entry->text_length)
@@ -1813,25 +1962,67 @@ gtk_entry_real_delete_text (GtkEntry *entry,
     {
       gint start_index = g_utf8_offset_to_pointer (entry->text, start_pos) - entry->text;
       gint end_index = g_utf8_offset_to_pointer (entry->text, end_pos) - entry->text;
+      gint current_pos;
+      gint selection_bound;
 
       g_memmove (entry->text + start_index, entry->text + end_index, entry->n_bytes + 1 - end_index);
       entry->text_length -= (end_pos - start_pos);
       entry->n_bytes -= (end_index - start_index);
       
-      if (entry->current_pos > start_pos)
-       entry->current_pos -= MIN (entry->current_pos, end_pos) - start_pos;
+      current_pos = entry->current_pos;
+      if (current_pos > start_pos)
+       current_pos -= MIN (current_pos, end_pos) - start_pos;
 
-      if (entry->selection_bound > start_pos)
-       entry->selection_bound -= MIN (entry->selection_bound, end_pos) - start_pos;
-    }
+      selection_bound = entry->selection_bound;
+      if (selection_bound > start_pos)
+        selection_bound -= MIN (selection_bound, end_pos) - start_pos;
 
-  /* We might have deleted the selection
-   */
-  gtk_entry_update_primary_selection (entry);
+      gtk_entry_set_positions (entry, current_pos, selection_bound);
 
-  gtk_entry_recompute (entry);
+      /* We might have deleted the selection
+       */
+      gtk_entry_update_primary_selection (entry);
+      
+      gtk_entry_recompute (entry);
+
+      g_signal_emit_by_name (editable, "changed");
+      g_object_notify (G_OBJECT (editable), "text");
+    }
 }
 
+/* Compute the X position for an offset that corresponds to the "more important
+ * cursor position for that offset. We use this when trying to guess to which
+ * end of the selection we should go to when the user hits the left or
+ * right arrow key.
+ */
+static gint
+get_better_cursor_x (GtkEntry *entry,
+                    gint      offset)
+{
+  GdkKeymap *keymap = gdk_keymap_get_for_display (gtk_widget_get_display (GTK_WIDGET (entry)));
+  GtkTextDirection keymap_direction =
+    (gdk_keymap_get_direction (keymap) == PANGO_DIRECTION_LTR) ?
+    GTK_TEXT_DIR_LTR : GTK_TEXT_DIR_RTL;
+  GtkTextDirection widget_direction = gtk_widget_get_direction (GTK_WIDGET (entry));
+  gboolean split_cursor;
+  
+  PangoLayout *layout = gtk_entry_ensure_layout (entry, TRUE);
+  const gchar *text = pango_layout_get_text (layout);
+  gint index = g_utf8_offset_to_pointer (text, offset) - text;
+  
+  PangoRectangle strong_pos, weak_pos;
+  
+  g_object_get (gtk_widget_get_settings (GTK_WIDGET (entry)),
+               "gtk-split-cursor", &split_cursor,
+               NULL);
+
+  pango_layout_get_cursor_pos (layout, index, &strong_pos, &weak_pos);
+
+  if (split_cursor)
+    return strong_pos.x / PANGO_SCALE;
+  else
+    return (keymap_direction == widget_direction) ? strong_pos.x / PANGO_SCALE : weak_pos.x / PANGO_SCALE;
+}
 
 static void
 gtk_entry_move_cursor (GtkEntry       *entry,
@@ -1842,42 +2033,84 @@ gtk_entry_move_cursor (GtkEntry       *entry,
   gint new_pos = entry->current_pos;
 
   gtk_entry_reset_im_context (entry);
-  
-  switch (step)
+
+  if (entry->current_pos != entry->selection_bound && !extend_selection)
     {
-    case GTK_MOVEMENT_LOGICAL_POSITIONS:
-      new_pos = CLAMP (new_pos + count, 0, entry->text_length);
-      break;
-    case GTK_MOVEMENT_VISUAL_POSITIONS:
-      new_pos = gtk_entry_move_visually (entry, new_pos, count);
-      break;
-    case GTK_MOVEMENT_WORDS:
-      while (count > 0)
+      /* If we have a current selection and aren't extending it, move to the
+       * start/or end of the selection as appropriate
+       */
+      switch (step)
        {
-         new_pos = gtk_entry_move_forward_word (entry, new_pos);
-         count--;
+       case GTK_MOVEMENT_VISUAL_POSITIONS:
+         {
+           gint current_x = get_better_cursor_x (entry, entry->current_pos);
+           gint bound_x = get_better_cursor_x (entry, entry->selection_bound);
+
+           if (count < 0)
+             new_pos = current_x < bound_x ? entry->current_pos : entry->selection_bound;
+           else
+             new_pos = current_x > bound_x ? entry->current_pos : entry->selection_bound;
+
+           break;
+         }
+       case GTK_MOVEMENT_LOGICAL_POSITIONS:
+       case GTK_MOVEMENT_WORDS:
+         if (count < 0)
+           new_pos = MIN (entry->current_pos, entry->selection_bound);
+         else
+           new_pos = MAX (entry->current_pos, entry->selection_bound);
+         break;
+       case GTK_MOVEMENT_DISPLAY_LINE_ENDS:
+       case GTK_MOVEMENT_PARAGRAPH_ENDS:
+       case GTK_MOVEMENT_BUFFER_ENDS:
+         new_pos = count < 0 ? 0 : entry->text_length;
+         break;
+       case GTK_MOVEMENT_DISPLAY_LINES:
+       case GTK_MOVEMENT_PARAGRAPHS:
+       case GTK_MOVEMENT_PAGES:
+         break;
        }
-      while (count < 0)
+    }
+  else
+    {
+      switch (step)
        {
-         new_pos = gtk_entry_move_backward_word (entry, new_pos);
-         count++;
+       case GTK_MOVEMENT_LOGICAL_POSITIONS:
+         new_pos = gtk_entry_move_logically (entry, new_pos, count);
+         break;
+       case GTK_MOVEMENT_VISUAL_POSITIONS:
+         new_pos = gtk_entry_move_visually (entry, new_pos, count);
+         break;
+       case GTK_MOVEMENT_WORDS:
+         while (count > 0)
+           {
+             new_pos = gtk_entry_move_forward_word (entry, new_pos);
+             count--;
+           }
+         while (count < 0)
+           {
+             new_pos = gtk_entry_move_backward_word (entry, new_pos);
+             count++;
+           }
+         break;
+       case GTK_MOVEMENT_DISPLAY_LINE_ENDS:
+       case GTK_MOVEMENT_PARAGRAPH_ENDS:
+       case GTK_MOVEMENT_BUFFER_ENDS:
+         new_pos = count < 0 ? 0 : entry->text_length;
+         break;
+       case GTK_MOVEMENT_DISPLAY_LINES:
+       case GTK_MOVEMENT_PARAGRAPHS:
+       case GTK_MOVEMENT_PAGES:
+         break;
        }
-      break;
-    case GTK_MOVEMENT_DISPLAY_LINE_ENDS:
-    case GTK_MOVEMENT_PARAGRAPH_ENDS:
-    case GTK_MOVEMENT_BUFFER_ENDS:
-      new_pos = count < 0 ? 0 : entry->text_length;
-      break;
-    case GTK_MOVEMENT_DISPLAY_LINES:
-    case GTK_MOVEMENT_PARAGRAPHS:
-    case GTK_MOVEMENT_PAGES:
-      break;
     }
 
   if (extend_selection)
     gtk_editable_select_region (GTK_EDITABLE (entry), entry->selection_bound, new_pos);
   else
     gtk_editable_set_position (GTK_EDITABLE (entry), new_pos);
+  
+  gtk_entry_pend_cursor_blink (entry);
 }
 
 static void
@@ -1887,10 +2120,13 @@ gtk_entry_insert_at_cursor (GtkEntry    *entry,
   GtkEditable *editable = GTK_EDITABLE (entry);
   gint pos = entry->current_pos;
 
-  gtk_entry_reset_im_context (entry);
+  if (entry->editable)
+    {
+      gtk_entry_reset_im_context (entry);
 
-  gtk_editable_insert_text (editable, str, -1, &pos);
-  gtk_editable_set_position (editable, pos);
+      gtk_editable_insert_text (editable, str, -1, &pos);
+      gtk_editable_set_position (editable, pos);
+    }
 }
 
 static void
@@ -1916,7 +2152,7 @@ gtk_entry_delete_from_cursor (GtkEntry       *entry,
   switch (type)
     {
     case GTK_DELETE_CHARS:
-      end_pos = entry->current_pos + count;
+      end_pos = gtk_entry_move_logically (entry, entry->current_pos, count);
       gtk_editable_delete_text (editable, MIN (start_pos, end_pos), MAX (start_pos, end_pos));
       break;
     case GTK_DELETE_WORDS:
@@ -1962,6 +2198,8 @@ gtk_entry_delete_from_cursor (GtkEntry       *entry,
       gtk_entry_delete_whitespace (entry);
       break;
     }
+  
+  gtk_entry_pend_cursor_blink (entry);
 }
 
 static void
@@ -1973,7 +2211,9 @@ gtk_entry_copy_clipboard (GtkEntry *entry)
   if (gtk_editable_get_selection_bounds (editable, &start, &end))
     {
       gchar *str = gtk_entry_get_public_chars (entry, start, end);
-      gtk_clipboard_set_text (gtk_clipboard_get (GDK_NONE), str, -1);
+      gtk_clipboard_set_text (gtk_widget_get_clipboard (GTK_WIDGET (entry),
+                                                       GDK_SELECTION_CLIPBOARD),
+                             str, -1);
       g_free (str);
     }
 }
@@ -1985,14 +2225,19 @@ gtk_entry_cut_clipboard (GtkEntry *entry)
   gint start, end;
 
   gtk_entry_copy_clipboard (entry);
-  if (gtk_editable_get_selection_bounds (editable, &start, &end))
-    gtk_editable_delete_text (editable, start, end);
+
+  if (entry->editable)
+    {
+      if (gtk_editable_get_selection_bounds (editable, &start, &end))
+       gtk_editable_delete_text (editable, start, end);
+    }
 }
 
 static void
 gtk_entry_paste_clipboard (GtkEntry *entry)
 {
-  gtk_entry_paste (entry, GDK_NONE);
+  if (entry->editable)
+    gtk_entry_paste (entry, GDK_NONE);
 }
 
 static void
@@ -2001,24 +2246,44 @@ gtk_entry_toggle_overwrite (GtkEntry *entry)
   entry->overwrite_mode = !entry->overwrite_mode;
 }
 
+static void
+gtk_entry_select_all (GtkEntry *entry)
+{
+  gtk_entry_select_line (entry);
+}
+
 static void
 gtk_entry_real_activate (GtkEntry *entry)
 {
   GtkWindow *window;
+  GtkWidget *toplevel;
   GtkWidget *widget;
 
   widget = GTK_WIDGET (entry);
 
   if (entry->activates_default)
     {
-      window = (GtkWindow *) gtk_widget_get_ancestor (widget, GTK_TYPE_WINDOW);
+      toplevel = gtk_widget_get_toplevel (widget);
+      if (GTK_IS_WINDOW (toplevel))
+       {
+         window = GTK_WINDOW (toplevel);
       
-      if (window &&
-          window->default_widget != widget)
-        gtk_window_activate_default (window);
+         if (window &&
+             widget != window->default_widget &&
+             !(widget == window->focus_widget &&
+               (!window->default_widget || !GTK_WIDGET_SENSITIVE (window->default_widget))))
+           gtk_window_activate_default (window);
+       }
     }
 }
 
+static void
+gtk_entry_keymap_direction_changed (GdkKeymap *keymap,
+                                   GtkEntry  *entry)
+{
+  gtk_entry_queue_draw (entry);
+}
+
 /* IM Context Callbacks
  */
 
@@ -2027,13 +2292,7 @@ gtk_entry_commit_cb (GtkIMContext *context,
                     const gchar  *str,
                     GtkEntry     *entry)
 {
-  GtkEditable *editable = GTK_EDITABLE (entry);
-  gint tmp_pos = entry->current_pos;
-
-  gtk_editable_delete_selection (editable);
-
-  gtk_editable_insert_text (editable, str, strlen (str), &tmp_pos);
-  gtk_editable_set_position (editable, tmp_pos);
+  gtk_entry_enter_text (entry, str);
 }
 
 static void 
@@ -2054,15 +2313,97 @@ gtk_entry_preedit_changed_cb (GtkIMContext *context,
   gtk_entry_recompute (entry);
 }
 
+static gboolean
+gtk_entry_retrieve_surrounding_cb (GtkIMContext *context,
+                              GtkEntry     *entry)
+{
+  gtk_im_context_set_surrounding (context,
+                                 entry->text,
+                                 entry->n_bytes,
+                                 g_utf8_offset_to_pointer (entry->text, entry->current_pos) - entry->text);
+
+  return TRUE;
+}
+
+static gboolean
+gtk_entry_delete_surrounding_cb (GtkIMContext *slave,
+                                gint          offset,
+                                gint          n_chars,
+                                GtkEntry     *entry)
+{
+  gtk_editable_delete_text (GTK_EDITABLE (entry),
+                           entry->current_pos + offset,
+                           entry->current_pos + offset + n_chars);
+
+  return TRUE;
+}
+
 /* Internal functions
  */
 
+/* Used for im_commit_cb and inserting Unicode chars */
+static void
+gtk_entry_enter_text (GtkEntry       *entry,
+                      const gchar    *str)
+{
+  GtkEditable *editable = GTK_EDITABLE (entry);
+  gint tmp_pos;
+
+  if (gtk_editable_get_selection_bounds (editable, NULL, NULL))
+    gtk_editable_delete_selection (editable);
+  else
+    {
+      if (entry->overwrite_mode)
+        gtk_entry_delete_from_cursor (entry, GTK_DELETE_CHARS, 1);
+    }
+
+  tmp_pos = entry->current_pos;
+  gtk_editable_insert_text (editable, str, strlen (str), &tmp_pos);
+  gtk_editable_set_position (editable, tmp_pos);
+}
+
+/* All changes to entry->current_pos and entry->selection_bound
+ * should go through this function.
+ */
+static void
+gtk_entry_set_positions (GtkEntry *entry,
+                        gint      current_pos,
+                        gint      selection_bound)
+{
+  gboolean changed = FALSE;
+
+  g_object_freeze_notify (G_OBJECT (entry));
+  
+  if (current_pos != -1 &&
+      entry->current_pos != current_pos)
+    {
+      entry->current_pos = current_pos;
+      changed = TRUE;
+
+      g_object_notify (G_OBJECT (entry), "cursor_position");
+    }
+
+  if (selection_bound != -1 &&
+      entry->selection_bound != selection_bound)
+    {
+      entry->selection_bound = selection_bound;
+      changed = TRUE;
+      
+      g_object_notify (G_OBJECT (entry), "selection_bound");
+    }
+
+  g_object_thaw_notify (G_OBJECT (entry));
+
+  if (changed)
+    gtk_entry_recompute (entry);
+}
+
 static void
 gtk_entry_reset_layout (GtkEntry *entry)
 {
   if (entry->cached_layout)
     {
-      g_object_unref (G_OBJECT (entry->cached_layout));
+      g_object_unref (entry->cached_layout);
       entry->cached_layout = NULL;
     }
 }
@@ -2073,11 +2414,11 @@ update_im_cursor_location (GtkEntry *entry)
   GdkRectangle area;
   gint strong_x;
   gint strong_xoffset;
-  gint x, y, area_width, area_height;
+  gint area_width, area_height;
 
   gtk_entry_get_cursor_locations (entry, CURSOR_STANDARD, &strong_x, NULL)
 ;
-  get_text_area_size (entry, &x, &y, &area_width, &area_height);
+  get_text_area_size (entry, NULL, NULL, &area_width, &area_height);
 
   strong_xoffset = strong_x - entry->scroll_offset;
   if (strong_xoffset < 0)
@@ -2088,9 +2429,9 @@ update_im_cursor_location (GtkEntry *entry)
     {
       strong_xoffset = area_width;
     }
-  area.x = x + strong_xoffset;
-  area.y = y + area_height;
-  area.width = area_width;
+  area.x = strong_xoffset;
+  area.y = 0;
+  area.width = 0;
   area.height = area_height;
 
   gtk_im_context_set_cursor_location (entry->im_context, &area);
@@ -2099,7 +2440,11 @@ update_im_cursor_location (GtkEntry *entry)
 static gboolean
 recompute_idle_func (gpointer data)
 {
-  GtkEntry *entry = GTK_ENTRY (data);
+  GtkEntry *entry;
+
+  GDK_THREADS_ENTER ();
+
+  entry = GTK_ENTRY (data);
 
   gtk_entry_adjust_scroll (entry);
   gtk_entry_queue_draw (entry);
@@ -2108,6 +2453,8 @@ recompute_idle_func (gpointer data)
   
   update_im_cursor_location (entry);
 
+  GDK_THREADS_LEAVE ();
+
   return FALSE;
 }
 
@@ -2115,7 +2462,8 @@ static void
 gtk_entry_recompute (GtkEntry *entry)
 {
   gtk_entry_reset_layout (entry);
-
+  gtk_entry_check_cursor_blink (entry);
+  
   if (!entry->recompute_idle)
     {
       entry->recompute_idle = g_idle_add_full (G_PRIORITY_HIGH_IDLE + 15, /* between resize and redraw */
@@ -2244,8 +2592,8 @@ gtk_entry_create_layout (GtkEntry *entry,
 }
 
 static PangoLayout *
-gtk_entry_get_layout (GtkEntry *entry,
-                     gboolean  include_preedit)
+gtk_entry_ensure_layout (GtkEntry *entry,
+                         gboolean  include_preedit)
 {
   if (entry->preedit_length > 0 &&
       !include_preedit != !entry->cache_includes_preedit)
@@ -2257,7 +2605,6 @@ gtk_entry_get_layout (GtkEntry *entry,
       entry->cache_includes_preedit = include_preedit;
     }
   
-  g_object_ref (G_OBJECT (entry->cached_layout));
   return entry->cached_layout;
 }
 
@@ -2272,7 +2619,7 @@ get_layout_position (GtkEntry *entry,
   gint y_pos;
   PangoLayoutLine *line;
   
-  layout = gtk_entry_get_layout (entry, TRUE);
+  layout = gtk_entry_ensure_layout (entry, TRUE);
 
   get_text_area_size (entry, NULL, NULL, &area_width, &area_height);      
       
@@ -2308,16 +2655,12 @@ gtk_entry_draw_text (GtkEntry *entry)
   GtkWidget *widget;
   PangoLayoutLine *line;
   
-  g_return_if_fail (entry != NULL);
-  g_return_if_fail (GTK_IS_ENTRY (entry));
-
   if (!entry->visible && entry->invisible_char == 0)
     return;
   
   if (GTK_WIDGET_DRAWABLE (entry))
     {
-      PangoLayout *layout = gtk_entry_get_layout (entry, TRUE);
-      gint area_width, area_height;
+      PangoLayout *layout = gtk_entry_ensure_layout (entry, TRUE);
       gint x, y;
       gint start_pos, end_pos;
       
@@ -2325,13 +2668,6 @@ gtk_entry_draw_text (GtkEntry *entry)
       
       get_layout_position (entry, &x, &y);
 
-      get_text_area_size (entry, NULL, NULL, &area_width, &area_height);
-
-      gtk_paint_flat_box (widget->style, entry->text_area, 
-                         GTK_WIDGET_STATE(widget), GTK_SHADOW_NONE,
-                         NULL, widget, "entry_bg", 
-                         0, 0, area_width, area_height);
-
       gdk_draw_layout (entry->text_area, widget->style->text_gc [widget->state],       
                        x, y,
                       layout);
@@ -2341,9 +2677,12 @@ gtk_entry_draw_text (GtkEntry *entry)
          gint *ranges;
          gint n_ranges, i;
           PangoRectangle logical_rect;
-         gint start_index = g_utf8_offset_to_pointer (entry->text, start_pos) - entry->text;
-         gint end_index = g_utf8_offset_to_pointer (entry->text, end_pos) - entry->text;
+         const gchar *text = pango_layout_get_text (layout);
+         gint start_index = g_utf8_offset_to_pointer (text, start_pos) - text;
+         gint end_index = g_utf8_offset_to_pointer (text, end_pos) - text;
          GdkRegion *clip_region = gdk_region_new ();
+         GdkGC *text_gc;
+         GdkGC *selection_gc;
 
           line = pango_layout_get_lines (layout)->data;
           
@@ -2351,6 +2690,17 @@ gtk_entry_draw_text (GtkEntry *entry)
 
           pango_layout_get_extents (layout, NULL, &logical_rect);
           
+         if (GTK_WIDGET_HAS_FOCUS (entry))
+           {
+             selection_gc = widget->style->base_gc [GTK_STATE_SELECTED];
+             text_gc = widget->style->text_gc [GTK_STATE_SELECTED];
+           }
+         else
+           {
+             selection_gc = widget->style->base_gc [GTK_STATE_ACTIVE];
+             text_gc = widget->style->text_gc [GTK_STATE_ACTIVE];
+           }
+         
          for (i=0; i < n_ranges; i++)
            {
              GdkRectangle rect;
@@ -2359,24 +2709,22 @@ gtk_entry_draw_text (GtkEntry *entry)
              rect.y = y;
              rect.width = (ranges[2*i + 1] - ranges[2*i]) / PANGO_SCALE;
              rect.height = logical_rect.height / PANGO_SCALE;
-             
-             gdk_draw_rectangle (entry->text_area, widget->style->base_gc [GTK_STATE_SELECTED], TRUE,
+               
+             gdk_draw_rectangle (entry->text_area, selection_gc, TRUE,
                                  rect.x, rect.y, rect.width, rect.height);
 
              gdk_region_union_with_rect (clip_region, &rect);
            }
 
-         gdk_gc_set_clip_region (widget->style->text_gc [GTK_STATE_SELECTED], clip_region);
-         gdk_draw_layout (entry->text_area, widget->style->text_gc [GTK_STATE_SELECTED]
+         gdk_gc_set_clip_region (text_gc, clip_region);
+         gdk_draw_layout (entry->text_area, text_gc
                           x, y,
                           layout);
-         gdk_gc_set_clip_region (widget->style->text_gc [GTK_STATE_SELECTED], NULL);
+         gdk_gc_set_clip_region (text_gc, NULL);
          
          gdk_region_destroy (clip_region);
          g_free (ranges);
        }
-
-      g_object_unref (G_OBJECT (layout));
     }
 }
 
@@ -2384,45 +2732,83 @@ static void
 gtk_entry_draw_cursor (GtkEntry  *entry,
                       CursorType type)
 {
-  g_return_if_fail (entry != NULL);
-  g_return_if_fail (GTK_IS_ENTRY (entry));
-
+  GdkKeymap *keymap = gdk_keymap_get_for_display (gtk_widget_get_display (GTK_WIDGET (entry)));
+  GtkTextDirection keymap_direction =
+    (gdk_keymap_get_direction (keymap) == PANGO_DIRECTION_LTR) ?
+    GTK_TEXT_DIR_LTR : GTK_TEXT_DIR_RTL;
+  GtkTextDirection widget_direction = gtk_widget_get_direction (GTK_WIDGET (entry));
+  
   if (GTK_WIDGET_DRAWABLE (entry))
     {
       GtkWidget *widget = GTK_WIDGET (entry);
+      GdkRectangle cursor_location;
+      gboolean split_cursor;
 
       gint xoffset = INNER_BORDER - entry->scroll_offset;
       gint strong_x, weak_x;
       gint text_area_height;
+      GtkTextDirection dir1 = GTK_TEXT_DIR_NONE;
+      GtkTextDirection dir2 = GTK_TEXT_DIR_NONE;
+      gint x1 = 0;
+      gint x2 = 0;
+      GdkGC *gc;
 
-      gdk_window_get_size (entry->text_area, NULL, &text_area_height);
+      gdk_drawable_get_size (entry->text_area, NULL, &text_area_height);
       
       gtk_entry_get_cursor_locations (entry, type, &strong_x, &weak_x);
+
+      g_object_get (gtk_widget_get_settings (widget),
+                   "gtk-split-cursor", &split_cursor,
+                   NULL);
+
+      dir1 = widget_direction;
       
-      gdk_draw_line (entry->text_area, entry->cursor_gc,
-                    xoffset + strong_x, INNER_BORDER,
-                    xoffset + strong_x, text_area_height - INNER_BORDER);
+      if (split_cursor)
+       {
+         x1 = strong_x;
+
+         if (weak_x != strong_x)
+           {
+             dir2 = (widget_direction == GTK_TEXT_DIR_LTR) ? GTK_TEXT_DIR_RTL : GTK_TEXT_DIR_LTR;
+             x2 = weak_x;
+           }
+       }
+      else
+       {
+         if (keymap_direction == widget_direction)
+           x1 = strong_x;
+         else
+           x1 = weak_x;
+       }
+
+      cursor_location.x = xoffset + x1;
+      cursor_location.y = INNER_BORDER;
+      cursor_location.width = 0;
+      cursor_location.height = text_area_height - 2 * INNER_BORDER ;
+
+      gc = _gtk_get_insertion_cursor_gc (widget, TRUE);
+      _gtk_draw_insertion_cursor (widget, entry->text_area, gc,
+                                 &cursor_location, dir1,
+                                  dir2 != GTK_TEXT_DIR_NONE);
+      g_object_unref (gc);
       
-      if (weak_x != strong_x)
-       gdk_draw_line (entry->text_area, widget->style->text_gc[GTK_STATE_NORMAL], 
-                      xoffset + weak_x, INNER_BORDER,
-                      xoffset + weak_x, text_area_height - INNER_BORDER);
+      if (dir2 != GTK_TEXT_DIR_NONE)
+       {
+         cursor_location.x = xoffset + x2;
+         gc = _gtk_get_insertion_cursor_gc (widget, FALSE);
+         _gtk_draw_insertion_cursor (widget, entry->text_area, gc,
+                                     &cursor_location, dir2,
+                                      TRUE);
+         g_object_unref (gc);
+       }
     }
 }
 
 static void
 gtk_entry_queue_draw (GtkEntry *entry)
 {
-  g_return_if_fail (entry != NULL);
-  g_return_if_fail (GTK_IS_ENTRY (entry));
-
   if (GTK_WIDGET_REALIZED (entry))
-    {
-      GdkRectangle rect = { 0 };
-
-      gdk_window_get_size (entry->text_area, &rect.width, &rect.height);
-      gdk_window_invalidate_rect (entry->text_area, &rect, FALSE);
-    }
+    gdk_window_invalidate_rect (entry->text_area, NULL, FALSE);
 }
 
 static void
@@ -2444,14 +2830,15 @@ gtk_entry_find_position (GtkEntry *entry,
   gint index;
   gint pos;
   gboolean trailing;
-  gint cursor_index = g_utf8_offset_to_pointer (entry->text, entry->current_pos) - entry->text;
+  const gchar *text;
+  gint cursor_index;
   
-  layout = gtk_entry_get_layout (entry, TRUE);
+  layout = gtk_entry_ensure_layout (entry, TRUE);
+  text = pango_layout_get_text (layout);
+  cursor_index = g_utf8_offset_to_pointer (text, entry->current_pos) - text;
   
   line = pango_layout_get_lines (layout)->data;
   pango_layout_line_x_to_index (line, x * PANGO_SCALE, &index, &trailing);
-  
-  g_object_unref (G_OBJECT (layout));
 
   if (index >= cursor_index && entry->preedit_length)
     {
@@ -2464,10 +2851,8 @@ gtk_entry_find_position (GtkEntry *entry,
        }
     }
 
-  pos = g_utf8_pointer_to_offset (entry->text, entry->text + index);
-  
-  if (trailing)
-    pos += 1;
+  pos = g_utf8_pointer_to_offset (text, text + index);
+  pos += trailing;
 
   return pos;
 }
@@ -2478,37 +2863,54 @@ gtk_entry_get_cursor_locations (GtkEntry   *entry,
                                gint       *strong_x,
                                gint       *weak_x)
 {
-  PangoLayout *layout = gtk_entry_get_layout (entry, TRUE);
-  const gchar *text;
-  PangoRectangle strong_pos, weak_pos;
-  gint index;
-  
-  if (type == CURSOR_STANDARD)
+  if (!entry->visible && !entry->invisible_char)
     {
-      text = pango_layout_get_text (layout);
-      index = g_utf8_offset_to_pointer (text, entry->current_pos + entry->preedit_cursor) - text;
+      if (strong_x)
+       *strong_x = 0;
+      
+      if (weak_x)
+       *weak_x = 0;
     }
-  else /* type == CURSOR_DND */
+  else
     {
-      index = g_utf8_offset_to_pointer (entry->text, entry->dnd_position) - entry->text;
-      if (entry->dnd_position > entry->current_pos)
-       index += entry->preedit_length;
-    }
-      
-  pango_layout_get_cursor_pos (layout, index, &strong_pos, &weak_pos);
-  g_object_unref (G_OBJECT (layout));
-
-  if (strong_x)
-    *strong_x = strong_pos.x / PANGO_SCALE;
+      PangoLayout *layout = gtk_entry_ensure_layout (entry, TRUE);
+      const gchar *text = pango_layout_get_text (layout);
+      PangoRectangle strong_pos, weak_pos;
+      gint index;
+  
+      if (type == CURSOR_STANDARD)
+       {
+         index = g_utf8_offset_to_pointer (text, entry->current_pos + entry->preedit_cursor) - text;
+       }
+      else /* type == CURSOR_DND */
+       {
+         index = g_utf8_offset_to_pointer (text, entry->dnd_position) - text;
 
-  if (weak_x)
-    *weak_x = weak_pos.x / PANGO_SCALE;
+         if (entry->dnd_position > entry->current_pos)
+           {
+             if (entry->visible)
+               index += entry->preedit_length;
+             else
+               {
+                 gint preedit_len_chars = g_utf8_strlen (text, -1) - entry->text_length;
+                 index += preedit_len_chars * g_unichar_to_utf8 (entry->invisible_char, NULL);
+               }
+           }
+       }
+      
+      pango_layout_get_cursor_pos (layout, index, &strong_pos, &weak_pos);
+      
+      if (strong_x)
+       *strong_x = strong_pos.x / PANGO_SCALE;
+      
+      if (weak_x)
+       *weak_x = weak_pos.x / PANGO_SCALE;
+    }
 }
 
 static void
 gtk_entry_adjust_scroll (GtkEntry *entry)
 {
-  GtkWidget *widget;
   gint min_offset, max_offset;
   gint text_area_width;
   gint strong_x, weak_x;
@@ -2517,26 +2919,20 @@ gtk_entry_adjust_scroll (GtkEntry *entry)
   PangoLayoutLine *line;
   PangoRectangle logical_rect;
 
-  g_return_if_fail (entry != NULL);
-  g_return_if_fail (GTK_IS_ENTRY (entry));
-
-  widget = GTK_WIDGET (entry);
-
   if (!GTK_WIDGET_REALIZED (entry))
     return;
   
-  gdk_window_get_size (entry->text_area, &text_area_width, NULL);
+  gdk_drawable_get_size (entry->text_area, &text_area_width, NULL);
   text_area_width -= 2 * INNER_BORDER;
 
-  layout = gtk_entry_get_layout (entry, TRUE);
+  layout = gtk_entry_ensure_layout (entry, TRUE);
   line = pango_layout_get_lines (layout)->data;
 
   pango_layout_line_get_extents (line, NULL, &logical_rect);
-  g_object_unref (G_OBJECT (layout));
 
   /* Display as much text as we can */
 
-  if (gtk_widget_get_direction (widget) == GTK_TEXT_DIR_LTR)
+  if (gtk_widget_get_direction (GTK_WIDGET (entry)) == GTK_TEXT_DIR_LTR)
     {
       min_offset = 0;
       max_offset = MAX (min_offset, logical_rect.width / PANGO_SCALE - text_area_width);
@@ -2589,6 +2985,8 @@ gtk_entry_adjust_scroll (GtkEntry *entry)
     {
       entry->scroll_offset += weak_xoffset - text_area_width;
     }
+
+  g_object_notify (G_OBJECT (entry), "scroll_offset");
 }
 
 static gint
@@ -2597,7 +2995,7 @@ gtk_entry_move_visually (GtkEntry *entry,
                         gint      count)
 {
   gint index;
-  PangoLayout *layout = gtk_entry_get_layout (entry, FALSE);
+  PangoLayout *layout = gtk_entry_ensure_layout (entry, FALSE);
   const gchar *text;
 
   text = pango_layout_get_text (layout);
@@ -2607,32 +3005,91 @@ gtk_entry_move_visually (GtkEntry *entry,
   while (count != 0)
     {
       int new_index, new_trailing;
+      gboolean split_cursor;
+      gboolean strong;
+
+      g_object_get (gtk_widget_get_settings (GTK_WIDGET (entry)),
+                   "gtk-split-cursor", &split_cursor,
+                   NULL);
+
+      if (split_cursor)
+       strong = TRUE;
+      else
+       {
+         GdkKeymap *keymap = gdk_keymap_get_for_display (gtk_widget_get_display (GTK_WIDGET (entry)));
+         GtkTextDirection keymap_direction =
+           (gdk_keymap_get_direction (keymap) == PANGO_DIRECTION_LTR) ?
+           GTK_TEXT_DIR_LTR : GTK_TEXT_DIR_RTL;
+
+         strong = keymap_direction == gtk_widget_get_direction (GTK_WIDGET (entry));
+       }
       
       if (count > 0)
        {
-         pango_layout_move_cursor_visually (layout, index, 0, 1, &new_index, &new_trailing);
+         pango_layout_move_cursor_visually (layout, strong, index, 0, 1, &new_index, &new_trailing);
          count--;
        }
       else
        {
-         pango_layout_move_cursor_visually (layout, index, 0, -1, &new_index, &new_trailing);
+         pango_layout_move_cursor_visually (layout, strong, index, 0, -1, &new_index, &new_trailing);
          count++;
        }
 
       if (new_index < 0 || new_index == G_MAXINT)
        break;
+
+      index = new_index;
       
-      if (new_trailing)
-       index = g_utf8_next_char (entry->text + new_index) - entry->text;
-      else
-       index = new_index;
+      while (new_trailing--)
+       index = g_utf8_next_char (text + new_index) - text;
     }
-
-  g_object_unref (G_OBJECT (layout));
   
   return g_utf8_pointer_to_offset (text, text + index);
 }
 
+static gint
+gtk_entry_move_logically (GtkEntry *entry,
+                         gint      start,
+                         gint      count)
+{
+  gint new_pos = start;
+
+  /* Prevent any leak of information */
+  if (!entry->visible)
+    {
+      new_pos = CLAMP (start + count, 0, entry->text_length);
+    }
+  else if (entry->text)
+    {
+      PangoLayout *layout = gtk_entry_ensure_layout (entry, FALSE);
+      PangoLogAttr *log_attrs;
+      gint n_attrs;
+
+      pango_layout_get_log_attrs (layout, &log_attrs, &n_attrs);
+
+      while (count > 0 && new_pos < entry->text_length)
+       {
+         do
+           new_pos++;
+         while (new_pos < entry->text_length && !log_attrs[new_pos].is_cursor_position);
+         
+         count--;
+       }
+      while (count < 0 && new_pos > 0)
+       {
+         do
+           new_pos--;
+         while (new_pos > 0 && !log_attrs[new_pos].is_cursor_position);
+         
+         count++;
+       }
+      
+      g_free (log_attrs);
+    }
+
+  return new_pos;
+}
+
 static gint
 gtk_entry_move_forward_word (GtkEntry *entry,
                             gint      start)
@@ -2646,7 +3103,7 @@ gtk_entry_move_forward_word (GtkEntry *entry,
     }
   else if (entry->text && (new_pos < entry->text_length))
     {
-      PangoLayout *layout = gtk_entry_get_layout (entry, FALSE);
+      PangoLayout *layout = gtk_entry_ensure_layout (entry, FALSE);
       PangoLogAttr *log_attrs;
       gint n_attrs;
 
@@ -2658,7 +3115,6 @@ gtk_entry_move_forward_word (GtkEntry *entry,
        new_pos++;
 
       g_free (log_attrs);
-      g_object_unref (G_OBJECT (layout));
     }
 
   return new_pos;
@@ -2678,7 +3134,7 @@ gtk_entry_move_backward_word (GtkEntry *entry,
     }
   else if (entry->text && start > 0)
     {
-      PangoLayout *layout = gtk_entry_get_layout (entry, FALSE);
+      PangoLayout *layout = gtk_entry_ensure_layout (entry, FALSE);
       PangoLogAttr *log_attrs;
       gint n_attrs;
 
@@ -2691,7 +3147,6 @@ gtk_entry_move_backward_word (GtkEntry *entry,
        new_pos--;
 
       g_free (log_attrs);
-      g_object_unref (G_OBJECT (layout));
     }
 
   return new_pos;
@@ -2700,7 +3155,7 @@ gtk_entry_move_backward_word (GtkEntry *entry,
 static void
 gtk_entry_delete_whitespace (GtkEntry *entry)
 {
-  PangoLayout *layout = gtk_entry_get_layout (entry, FALSE);
+  PangoLayout *layout = gtk_entry_ensure_layout (entry, FALSE);
   PangoLogAttr *log_attrs;
   gint n_attrs;
   gint start, end;
@@ -2712,11 +3167,10 @@ gtk_entry_delete_whitespace (GtkEntry *entry)
   while (start > 0 && log_attrs[start-1].is_white)
     start--;
 
-  while (end < n_attrs && log_attrs[start-1].is_white)
+  while (end < n_attrs && log_attrs[end].is_white)
     end++;
 
   g_free (log_attrs);
-  g_object_unref (G_OBJECT (layout));
 
   if (start != end)
     gtk_editable_delete_text (GTK_EDITABLE (entry), start, end);
@@ -2739,8 +3193,8 @@ gtk_entry_select_line (GtkEntry *entry)
 }
 
 /*
- * Like gtk_editable_get_chars, but if the editable is not
- * visible, return asterisks; also convert result to UTF-8.
+ * Like gtk_editable_get_chars, but handle not-visible entries
+ * correctly.
  */
 static char *    
 gtk_entry_get_public_chars (GtkEntry *entry,
@@ -2752,20 +3206,14 @@ gtk_entry_get_public_chars (GtkEntry *entry,
   
   if (entry->visible)
     return gtk_editable_get_chars (GTK_EDITABLE (entry), start, end);
+  else if (!entry->invisible_char)
+    return g_strdup ("");
   else
     {
-      gchar *str;
-      gint i;
-      gint n_chars = end - start;
-       
-      str = g_malloc (n_chars + 1);
-      for (i = 0; i < n_chars; i++)
-       str[i] = '*';
-      str[i] = '\0';
-      
-      return str;
+      GString *str = g_string_new (NULL);
+      append_char (str, entry->invisible_char, end - start);
+      return g_string_free (str, FALSE);
     }
-
 }
 
 static void
@@ -2778,21 +3226,25 @@ paste_received (GtkClipboard *clipboard,
       
   if (text)
     {
-      gint pos = entry->current_pos;
+      gint pos, start, end;
       
+      if (gtk_editable_get_selection_bounds (editable, &start, &end))
+        gtk_editable_delete_text (editable, start, end);
+
+      pos = entry->current_pos;
       gtk_editable_insert_text (editable, text, -1, &pos);
       gtk_editable_set_position (editable, pos);
     }
 
-  g_object_unref (G_OBJECT (entry));
+  g_object_unref (entry);
 }
 
 static void
 gtk_entry_paste (GtkEntry *entry,
                 GdkAtom   selection)
 {
-  g_object_ref (G_OBJECT (entry));
-  gtk_clipboard_request_text (gtk_clipboard_get (selection),
+  g_object_ref (entry);
+  gtk_clipboard_request_text (gtk_widget_get_clipboard (GTK_WIDGET (entry), selection),
                              paste_received, entry);
 }
 
@@ -2808,7 +3260,7 @@ primary_get_cb (GtkClipboard     *clipboard,
   if (gtk_editable_get_selection_bounds (GTK_EDITABLE (entry), &start, &end))
     {
       gchar *str = gtk_entry_get_public_chars (entry, start, end);
-      gtk_selection_data_set_text (selection_data, str);
+      gtk_selection_data_set_text (selection_data, str, -1);
       g_free (str);
     }
 }
@@ -2832,8 +3284,13 @@ gtk_entry_update_primary_selection (GtkEntry *entry)
     { "COMPOUND_TEXT", 0, 0 }
   };
   
-  GtkClipboard *clipboard = gtk_clipboard_get (GDK_SELECTION_PRIMARY);
+  GtkClipboard *clipboard;
   gint start, end;
+
+  if (!GTK_WIDGET_REALIZED (entry))
+    return;
+
+  clipboard = gtk_widget_get_clipboard (GTK_WIDGET (entry), GDK_SELECTION_PRIMARY);
   
   if (gtk_editable_get_selection_bounds (GTK_EDITABLE (entry), &start, &end))
     {
@@ -2854,38 +3311,58 @@ gtk_entry_update_primary_selection (GtkEntry *entry)
 GtkWidget*
 gtk_entry_new (void)
 {
-  return GTK_WIDGET (gtk_type_new (GTK_TYPE_ENTRY));
+  return g_object_new (GTK_TYPE_ENTRY, NULL);
 }
 
+/**
+ * gtk_entry_new_with_max_length:
+ * @max: the maximum length of the entry, or 0 for no maximum.
+ *   (other than the maximum length of entries.) The value passed in will
+ *   be clamped to the range 0-65536.
+ *
+ * Creates a new #GtkEntry widget with the given maximum length.
+ * 
+ * Note: the existance of this function is inconsistent
+ * with the rest of the GTK+ API. The normal setup would
+ * be to just require the user to make an extra call
+ * to gtk_entry_set_max_length() instead. It is not
+ * expected that this function will be removed, but
+ * it would be better practice not to use it.
+ * 
+ * Return value: a new #GtkEntry.
+ **/
 GtkWidget*
 gtk_entry_new_with_max_length (gint max)
 {
   GtkEntry *entry;
 
-  entry = gtk_type_new (GTK_TYPE_ENTRY);
+  max = CLAMP (max, 0, MAX_SIZE);
+
+  entry = g_object_new (GTK_TYPE_ENTRY, NULL);
   entry->text_max_length = max;
 
   return GTK_WIDGET (entry);
 }
 
 void
-gtk_entry_set_text (GtkEntry *entry,
+gtk_entry_set_text (GtkEntry    *entry,
                    const gchar *text)
 {
   gint tmp_pos;
 
-  GtkEditable *editable;
-
-  g_return_if_fail (entry != NULL);
   g_return_if_fail (GTK_IS_ENTRY (entry));
   g_return_if_fail (text != NULL);
 
-  editable = GTK_EDITABLE (entry);
-  
-  gtk_editable_delete_text (GTK_EDITABLE(entry), 0, -1);
+  /* Actually setting the text will affect the cursor and selection;
+   * if the contents don't actually change, this will look odd to the user.
+   */
+  if (strcmp (entry->text, text) == 0)
+    return;
+
+  gtk_editable_delete_text (GTK_EDITABLE (entry), 0, -1);
 
   tmp_pos = 0;
-  gtk_editable_insert_text (editable, text, strlen (text), &tmp_pos);
+  gtk_editable_insert_text (GTK_EDITABLE (entry), text, strlen (text), &tmp_pos);
 }
 
 void
@@ -2894,12 +3371,11 @@ gtk_entry_append_text (GtkEntry *entry,
 {
   gint tmp_pos;
 
-  g_return_if_fail (entry != NULL);
   g_return_if_fail (GTK_IS_ENTRY (entry));
   g_return_if_fail (text != NULL);
 
   tmp_pos = entry->text_length;
-  gtk_editable_insert_text (GTK_EDITABLE(entry), text, -1, &tmp_pos);
+  gtk_editable_insert_text (GTK_EDITABLE (entry), text, -1, &tmp_pos);
 }
 
 void
@@ -2908,19 +3384,17 @@ gtk_entry_prepend_text (GtkEntry *entry,
 {
   gint tmp_pos;
 
-  g_return_if_fail (entry != NULL);
   g_return_if_fail (GTK_IS_ENTRY (entry));
   g_return_if_fail (text != NULL);
 
   tmp_pos = 0;
-  gtk_editable_insert_text (GTK_EDITABLE(entry), text, -1, &tmp_pos);
+  gtk_editable_insert_text (GTK_EDITABLE (entry), text, -1, &tmp_pos);
 }
 
 void
 gtk_entry_set_position (GtkEntry *entry,
                        gint       position)
 {
-  g_return_if_fail (entry != NULL);
   g_return_if_fail (GTK_IS_ENTRY (entry));
 
   gtk_editable_set_position (GTK_EDITABLE (entry), position);
@@ -2930,7 +3404,6 @@ void
 gtk_entry_set_visibility (GtkEntry *entry,
                          gboolean visible)
 {
-  g_return_if_fail (entry != NULL);
   g_return_if_fail (GTK_IS_ENTRY (entry));
 
   entry->visible = visible ? TRUE : FALSE;
@@ -2938,6 +3411,23 @@ gtk_entry_set_visibility (GtkEntry *entry,
   gtk_entry_recompute (entry);
 }
 
+/**
+ * gtk_entry_get_visibility:
+ * @entry: a #GtkEntry
+ *
+ * Retrieves whether the text in @entry is visible. See
+ * gtk_entry_set_visibility().
+ *
+ * Return value: %TRUE if the text is currently visible
+ **/
+gboolean
+gtk_entry_get_visibility (GtkEntry *entry)
+{
+  g_return_val_if_fail (GTK_IS_ENTRY (entry), FALSE);
+
+  return entry->visible;
+}
+
 /**
  * gtk_entry_set_invisible_char:
  * @entry: a #GtkEntry
@@ -2966,20 +3456,48 @@ gtk_entry_set_invisible_char (GtkEntry *entry,
   gtk_entry_recompute (entry);  
 }
 
+/**
+ * gtk_entry_get_invisible_char:
+ * @entry: a #GtkEntry
+ *
+ * Retrieves the character displayed in place of the real characters
+ * for entries with visisbility set to false. See gtk_entry_set_invisible_char().
+ *
+ * Return value: the current invisible char, or 0, if the entry does not
+ *               show invisible text at all. 
+ **/
+gunichar
+gtk_entry_get_invisible_char (GtkEntry *entry)
+{
+  g_return_val_if_fail (GTK_IS_ENTRY (entry), 0);
+
+  return entry->invisible_char;
+}
+
 void
-gtk_entry_set_editable(GtkEntry *entry,
-                      gboolean  editable)
+gtk_entry_set_editable (GtkEntry *entry,
+                       gboolean  editable)
 {
-  g_return_if_fail (entry != NULL);
   g_return_if_fail (GTK_IS_ENTRY (entry));
 
   gtk_editable_set_editable (GTK_EDITABLE (entry), editable);
 }
 
+/**
+ * gtk_entry_get_text:
+ * @entry: a #GtkEntry
+ *
+ * Retrieves the contents of the entry widget.
+ * See also gtk_editable_get_chars().
+ *
+ * Return value: a pointer to the contents of the widget as a
+ *      string.  This string points to internally allocated
+ *      storage in the widget and must not be freed, modified or
+ *      stored.
+ **/
 G_CONST_RETURN gchar*
 gtk_entry_get_text (GtkEntry *entry)
 {
-  g_return_val_if_fail (entry != NULL, NULL);
   g_return_val_if_fail (GTK_IS_ENTRY (entry), NULL);
 
   return entry->text;
@@ -2993,20 +3511,50 @@ gtk_entry_select_region  (GtkEntry       *entry,
   gtk_editable_select_region (GTK_EDITABLE (entry), start, end);
 }
 
+/**
+ * gtk_entry_set_max_length:
+ * @entry: a #GtkEntry.
+ * @max: the maximum length of the entry, or 0 for no maximum.
+ *   (other than the maximum length of entries.) The value passed in will
+ *   be clamped to the range 0-65536.
+ * 
+ * Sets the maximum allowed length of the contents of the widget. If
+ * the current contents are longer than the given length, then they
+ * will be truncated to fit.
+ **/
 void
 gtk_entry_set_max_length (GtkEntry     *entry,
                           gint          max)
 {
-  g_return_if_fail (entry != NULL);
   g_return_if_fail (GTK_IS_ENTRY (entry));
 
+  max = CLAMP (max, 0, MAX_SIZE);
+
   if (max > 0 && entry->text_length > max)
-    gtk_editable_delete_text (GTK_EDITABLE(entry), max, -1);
+    gtk_editable_delete_text (GTK_EDITABLE (entry), max, -1);
   
   entry->text_max_length = max;
   g_object_notify (G_OBJECT (entry), "max_length");
 }
 
+/**
+ * gtk_entry_get_max_length:
+ * @entry: a #GtkEntry
+ *
+ * Retrieves the maximum allowed length of the text in
+ * @entry. See gtk_entry_set_max_length().
+ *
+ * Return value: the maximum allowed number of characters
+ *               in #GtkEntry, or 0 if there is no maximum.
+ **/
+gint
+gtk_entry_get_max_length (GtkEntry *entry)
+{
+  g_return_val_if_fail (GTK_IS_ENTRY (entry), 0);
+
+  return entry->text_max_length;
+}
+
 /**
  * gtk_entry_set_activates_default:
  * @entry: a #GtkEntry
@@ -3059,7 +3607,7 @@ gtk_entry_get_activates_default (GtkEntry *entry)
  *
  * Changes the size request of the entry to be about the right size
  * for @n_chars characters. Note that it changes the size
- * <emphasize>request</emphasize>, the size can still be affected by
+ * <emphasis>request</emphasis>, the size can still be affected by
  * how you pack the widget into containers. If @n_chars is -1, the
  * size reverts to the default entry size.
  * 
@@ -3089,6 +3637,8 @@ gtk_entry_set_width_chars (GtkEntry *entry,
 gint
 gtk_entry_get_width_chars (GtkEntry *entry)
 {
+  g_return_val_if_fail (GTK_IS_ENTRY (entry), 0);
+
   return entry->width_chars;
 }
 
@@ -3106,11 +3656,13 @@ gtk_entry_set_has_frame (GtkEntry *entry,
   g_return_if_fail (GTK_IS_ENTRY (entry));
 
   setting = (setting != FALSE);
-  
-  if (entry->has_frame != setting)
-    gtk_widget_queue_resize (GTK_WIDGET (entry));
-  
+
+  if (entry->has_frame == setting)
+    return;
+
+  gtk_widget_queue_resize (GTK_WIDGET (entry));
   entry->has_frame = setting;
+  g_object_notify (G_OBJECT (entry), "has_frame");
 }
 
 /**
@@ -3129,16 +3681,130 @@ gtk_entry_get_has_frame (GtkEntry *entry)
   return entry->has_frame;
 }
 
+
+/**
+ * gtk_entry_get_layout:
+ * @entry: a #GtkEntry
+ * 
+ * Gets the #PangoLayout used to display the entry.
+ * The layout is useful to e.g. convert text positions to
+ * pixel positions, in combination with gtk_entry_get_layout_offsets().
+ * The returned layout is owned by the entry so need not be
+ * freed by the caller.
+ *
+ * Keep in mind that the layout text may contain a preedit string, so
+ * gtk_entry_layout_index_to_text_index() and
+ * gtk_entry_text_index_to_layout_index() are needed to convert byte
+ * indices in the layout to byte indices in the entry contents.
+ * 
+ * Return value: the #PangoLayout for this entry
+ **/
+PangoLayout*
+gtk_entry_get_layout (GtkEntry *entry)
+{
+  PangoLayout *layout;
+  
+  g_return_val_if_fail (GTK_IS_ENTRY (entry), NULL);
+
+  layout = gtk_entry_ensure_layout (entry, TRUE);
+
+  return layout;
+}
+
+
+/**
+ * gtk_entry_layout_index_to_text_index:
+ * @entry: a #GtkEntry
+ * @layout_index: byte index into the entry layout text
+ * 
+ * Converts from a position in the entry contents (returned
+ * by gtk_entry_get_text()) to a position in the
+ * entry's #PangoLayout (returned by gtk_entry_get_layout(),
+ * with text retrieved via pango_layout_get_text()).
+ * 
+ * Return value: byte index into the entry contents
+ **/
+gint
+gtk_entry_layout_index_to_text_index (GtkEntry *entry,
+                                      gint      layout_index)
+{
+  PangoLayout *layout;
+  const gchar *text;
+  gint cursor_index;
+  
+  g_return_val_if_fail (GTK_IS_ENTRY (entry), 0);
+
+  layout = gtk_entry_ensure_layout (entry, TRUE);
+  text = pango_layout_get_text (layout);
+  cursor_index = g_utf8_offset_to_pointer (text, entry->current_pos) - text;
+  
+  if (layout_index >= cursor_index && entry->preedit_length)
+    {
+      if (layout_index >= cursor_index + entry->preedit_length)
+       layout_index -= entry->preedit_length;
+      else
+        layout_index = cursor_index;
+    }
+
+  return layout_index;
+}
+
+/**
+ * gtk_entry_text_index_to_layout_index:
+ * @entry: a #GtkEntry
+ * @text_index: byte index into the entry contents
+ * 
+ * Converts from a position in the entry's #PangoLayout(returned by
+ * gtk_entry_get_layout()) to a position in the entry contents
+ * (returned by gtk_entry_get_text()).
+ * 
+ * Return value: byte index into the entry layout text
+ **/
+gint
+gtk_entry_text_index_to_layout_index (GtkEntry *entry,
+                                      gint      text_index)
+{
+  PangoLayout *layout;
+  const gchar *text;
+  gint cursor_index;
+  g_return_val_if_fail (GTK_IS_ENTRY (entry), 0);
+
+  layout = gtk_entry_ensure_layout (entry, TRUE);
+  text = pango_layout_get_text (layout);
+  cursor_index = g_utf8_offset_to_pointer (text, entry->current_pos) - text;
+  
+  if (text_index > cursor_index)
+    text_index += entry->preedit_length;
+
+  return text_index;
+}
+
 /**
  * gtk_entry_get_layout_offsets:
  * @entry: a #GtkEntry
- * @x: location to store X coordinate of layout
- * @y: location to store Y coordinate of layout
+ * @x: location to store X offset of layout, or %NULL
+ * @y: location to store Y offset of layout, or %NULL
+ *
  *
  * Obtains the position of the #PangoLayout used to render text
  * in the entry, in widget coordinates. Useful if you want to line
  * up the text in an entry with some other text, e.g. when using the
  * entry to implement editable cells in a sheet widget.
+ *
+ * Also useful to convert mouse events into coordinates inside the
+ * #PangoLayout, e.g. to take some action if some part of the entry text
+ * is clicked.
+ * 
+ * Note that as the user scrolls around in the entry the offsets will
+ * change; you'll need to connect to the "notify::scroll_offset"
+ * signal to track this. Remember when using the #PangoLayout
+ * functions you need to convert to and from pixels using
+ * PANGO_PIXELS() or #PANGO_SCALE.
+ *
+ * Keep in mind that the layout text may contain a preedit string, so
+ * gtk_entry_layout_index_to_text_index() and
+ * gtk_entry_text_index_to_layout_index() are needed to convert byte
+ * indices in the layout to byte indices in the entry contents.
  * 
  **/
 void
@@ -3169,8 +3835,8 @@ static void
 activate_cb (GtkWidget *menuitem,
             GtkEntry  *entry)
 {
-  const gchar *signal = gtk_object_get_data (GTK_OBJECT (menuitem), "gtk-signal");
-  gtk_signal_emit_by_name (GTK_OBJECT (entry), signal);
+  const gchar *signal = g_object_get_data (G_OBJECT (menuitem), "gtk-signal");
+  g_signal_emit_by_name (entry, signal);
 }
 
 
@@ -3185,15 +3851,15 @@ gtk_entry_mnemonic_activate (GtkWidget *widget,
 static void
 append_action_signal (GtkEntry     *entry,
                      GtkWidget    *menu,
-                     const gchar  *label,
+                     const gchar  *stock_id,
                      const gchar  *signal,
                       gboolean      sensitive)
 {
-  GtkWidget *menuitem = gtk_menu_item_new_with_label (label);
+  GtkWidget *menuitem = gtk_image_menu_item_new_from_stock (stock_id, NULL);
 
-  gtk_object_set_data (GTK_OBJECT (menuitem), "gtk-signal", (char *)signal);
-  gtk_signal_connect (GTK_OBJECT (menuitem), "activate",
-                     GTK_SIGNAL_FUNC (activate_cb), entry);
+  g_object_set_data (G_OBJECT (menuitem), "gtk-signal", (char *)signal);
+  g_signal_connect (menuitem, "activate",
+                   G_CALLBACK (activate_cb), entry);
 
   gtk_widget_set_sensitive (menuitem, sensitive);
   
@@ -3215,13 +3881,11 @@ popup_position_func (GtkMenu   *menu,
                      gboolean  *push_in,
                      gpointer  user_data)
 {
-  GtkEntry *entry;
-  GtkWidget *widget;
+  GtkEntry *entry = GTK_ENTRY (user_data);
+  GtkWidget *widget = GTK_WIDGET (entry);
+  GdkScreen *screen = gtk_widget_get_screen (widget);
   GtkRequisition req;
   
-  entry = GTK_ENTRY (user_data);  
-  widget = GTK_WIDGET (entry);
-  
   g_return_if_fail (GTK_WIDGET_REALIZED (entry));
 
   gdk_window_get_origin (widget->window, x, y);      
@@ -3231,69 +3895,148 @@ popup_position_func (GtkMenu   *menu,
   *x += widget->allocation.width / 2;
   *y += widget->allocation.height;
 
-  *x = CLAMP (*x, 0, MAX (0, gdk_screen_width () - req.width));
-  *y = CLAMP (*y, 0, MAX (0, gdk_screen_height () - req.height));
+  *x = CLAMP (*x, 0, MAX (0, gdk_screen_get_width (screen) - req.width));
+  *y = CLAMP (*y, 0, MAX (0, gdk_screen_get_height (screen) - req.height));
 }
 
+
 static void
-gtk_entry_do_popup (GtkEntry       *entry,
-                    GdkEventButton *event)
+unichar_chosen_func (const char *text,
+                     gpointer    data)
 {
+  GtkEntry *entry = GTK_ENTRY (data);
 
-  GtkWidget *menuitem;
-  GtkWidget *submenu;
-  gboolean have_selection;
-
-  if (entry->popup_menu)
-    gtk_widget_destroy (entry->popup_menu);
-  
-  entry->popup_menu = gtk_menu_new ();
+  if (entry->editable)
+    gtk_entry_enter_text (entry, text);
+}
 
-  gtk_menu_attach_to_widget (GTK_MENU (entry->popup_menu),
-                             GTK_WIDGET (entry),
-                             popup_menu_detach);
+typedef struct
+{
+  GtkEntry *entry;
+  gint button;
+  guint time;
+} PopupInfo;
 
-  have_selection = entry->current_pos != entry->selection_bound;
+static void
+popup_targets_received (GtkClipboard     *clipboard,
+                       GtkSelectionData *data,
+                       gpointer          user_data)
+{
+  PopupInfo *info = user_data;
+  GtkEntry *entry = info->entry;
   
-  append_action_signal (entry, entry->popup_menu, _("Cut"), "cut_clipboard",
-                        have_selection);
-  append_action_signal (entry, entry->popup_menu, _("Copy"), "copy_clipboard",
-                        have_selection);
-  append_action_signal (entry, entry->popup_menu, _("Paste"), "paste_clipboard",
-                        TRUE);
-
-  menuitem = gtk_separator_menu_item_new ();
-  gtk_widget_show (menuitem);
-  gtk_menu_shell_append (GTK_MENU_SHELL (entry->popup_menu), menuitem);
+  if (GTK_WIDGET_REALIZED (entry))
+    {
+      gboolean clipboard_contains_text = gtk_selection_data_targets_include_text (data);
+      GtkWidget *menuitem;
+      GtkWidget *submenu;
       
-  menuitem = gtk_menu_item_new_with_label (_("Input Methods"));
-  gtk_widget_show (menuitem);
-  submenu = gtk_menu_new ();
-  gtk_menu_item_set_submenu (GTK_MENU_ITEM (menuitem), submenu);
-
-  gtk_menu_shell_append (GTK_MENU_SHELL (entry->popup_menu), menuitem);
+      if (entry->popup_menu)
+       gtk_widget_destroy (entry->popup_menu);
+      
+      entry->popup_menu = gtk_menu_new ();
+      
+      gtk_menu_attach_to_widget (GTK_MENU (entry->popup_menu),
+                                GTK_WIDGET (entry),
+                                popup_menu_detach);
+      
+      append_action_signal (entry, entry->popup_menu, GTK_STOCK_CUT, "cut_clipboard",
+                           entry->editable && entry->current_pos != entry->selection_bound);
+      append_action_signal (entry, entry->popup_menu, GTK_STOCK_COPY, "copy_clipboard",
+                           entry->current_pos != entry->selection_bound);
+      append_action_signal (entry, entry->popup_menu, GTK_STOCK_PASTE, "paste_clipboard",
+                           entry->editable && clipboard_contains_text);
+      
+      menuitem = gtk_menu_item_new_with_label (_("Select All"));
+      g_signal_connect_swapped (menuitem, "activate",
+                               G_CALLBACK (gtk_entry_select_all), entry);
+      gtk_widget_show (menuitem);
+      gtk_menu_shell_append (GTK_MENU_SHELL (entry->popup_menu), menuitem);
+      
+      menuitem = gtk_separator_menu_item_new ();
+      gtk_widget_show (menuitem);
+      gtk_menu_shell_append (GTK_MENU_SHELL (entry->popup_menu), menuitem);
+      
+      menuitem = gtk_menu_item_new_with_label (_("Input Methods"));
+      gtk_widget_show (menuitem);
+      submenu = gtk_menu_new ();
+      gtk_menu_item_set_submenu (GTK_MENU_ITEM (menuitem), submenu);
+      
+      gtk_menu_shell_append (GTK_MENU_SHELL (entry->popup_menu), menuitem);
+      
+      gtk_im_multicontext_append_menuitems (GTK_IM_MULTICONTEXT (entry->im_context),
+                                           GTK_MENU_SHELL (submenu));
+      
+      menuitem = gtk_menu_item_new_with_mnemonic (_("_Insert Unicode control character"));
+      gtk_widget_show (menuitem);
+      
+      submenu = gtk_menu_new ();
+      gtk_menu_item_set_submenu (GTK_MENU_ITEM (menuitem), submenu);
+      gtk_menu_shell_append (GTK_MENU_SHELL (entry->popup_menu), menuitem);      
+
+      _gtk_text_util_append_special_char_menuitems (GTK_MENU_SHELL (submenu),
+                                                    unichar_chosen_func,
+                                                    entry);
+      if (!entry->editable)
+        gtk_widget_set_sensitive (menuitem, FALSE);
       
-  gtk_im_multicontext_append_menuitems (GTK_IM_MULTICONTEXT (entry->im_context),
-                                        GTK_MENU_SHELL (submenu));
+      g_signal_emit (entry,
+                    signals[POPULATE_POPUP],
+                    0,
+                    entry->popup_menu);
+  
+
+      if (info->button)
+       gtk_menu_popup (GTK_MENU (entry->popup_menu), NULL, NULL,
+                       NULL, NULL,
+                       info->button, info->time);
+      else
+       {
+         gtk_menu_popup (GTK_MENU (entry->popup_menu), NULL, NULL,
+                         popup_position_func, entry,
+                         info->button, info->time);
+         gtk_menu_shell_select_first (GTK_MENU_SHELL (entry->popup_menu), FALSE);
+       }
+    }
+
+  g_object_unref (entry);
+  g_free (info);
+}
+                       
+static void
+gtk_entry_do_popup (GtkEntry       *entry,
+                    GdkEventButton *event)
+{
+  PopupInfo *info = g_new (PopupInfo, 1);
 
-  gtk_signal_emit (GTK_OBJECT (entry),
-                   signals[POPULATE_POPUP],
-                   entry->popup_menu);
+  /* In order to know what entries we should make sensitive, we
+   * ask for the current targets of the clipboard, and when
+   * we get them, then we actually pop up the menu.
+   */
+  info->entry = g_object_ref (entry);
   
   if (event)
-    gtk_menu_popup (GTK_MENU (entry->popup_menu), NULL, NULL,
-                    NULL, NULL,
-                    event->button, event->time);
+    {
+      info->button = event->button;
+      info->time = event->time;
+    }
   else
-    gtk_menu_popup (GTK_MENU (entry->popup_menu), NULL, NULL,
-                    popup_position_func, entry,
-                    0, gtk_get_current_event_time ());
+    {
+      info->button = 0;
+      info->time = gtk_get_current_event_time ();
+    }
+
+  gtk_clipboard_request_contents (gtk_widget_get_clipboard (GTK_WIDGET (entry), GDK_SELECTION_CLIPBOARD),
+                                 gdk_atom_intern ("TARGETS", FALSE),
+                                 popup_targets_received,
+                                 info);
 }
 
-static void
+static gboolean
 gtk_entry_popup_menu (GtkWidget *widget)
 {
   gtk_entry_do_popup (GTK_ENTRY (widget), NULL);
+  return TRUE;
 }
 
 static void
@@ -3301,14 +4044,33 @@ gtk_entry_drag_leave (GtkWidget        *widget,
                      GdkDragContext   *context,
                      guint             time)
 {
-  GtkEntry *entry;
-
-  entry = GTK_ENTRY (widget);
+  GtkEntry *entry = GTK_ENTRY (widget);
 
   entry->dnd_position = -1;
   gtk_widget_queue_draw (widget);
 }
 
+static gboolean
+gtk_entry_drag_drop  (GtkWidget        *widget,
+                     GdkDragContext   *context,
+                     gint              x,
+                     gint              y,
+                     guint             time)
+{
+  GtkEntry *entry = GTK_ENTRY (widget);
+  GdkAtom target = GDK_NONE;
+  
+  if (entry->editable)
+    target = gtk_drag_dest_find_target (widget, context, NULL);
+
+  if (target != GDK_NONE)
+    gtk_drag_get_data (widget, context, target, time);
+  else
+    gtk_drag_finish (context, FALSE, FALSE, time);
+  
+  return TRUE;
+}
+
 static gboolean
 gtk_entry_drag_motion (GtkWidget        *widget,
                       GdkDragContext   *context,
@@ -3316,45 +4078,53 @@ gtk_entry_drag_motion (GtkWidget        *widget,
                       gint              y,
                       guint             time)
 {
-  GtkEntry *entry;
+  GtkEntry *entry = GTK_ENTRY (widget);
   GtkWidget *source_widget;
   GdkDragAction suggested_action;
   gint new_position, old_position;
   gint sel1, sel2;
   
-  entry = GTK_ENTRY (widget);
-
   x -= widget->style->xthickness;
   y -= widget->style->ythickness;
   
   old_position = entry->dnd_position;
   new_position = gtk_entry_find_position (entry, x + entry->scroll_offset);
 
-  source_widget = gtk_drag_get_source_widget (context);
-  suggested_action = context->suggested_action;
-
-  if (!gtk_editable_get_selection_bounds (GTK_EDITABLE (entry), &sel1, &sel2) ||
-      new_position < sel1 || new_position > sel2)
+  if (entry->editable &&
+      gtk_drag_dest_find_target (widget, context, NULL) != GDK_NONE)
     {
-      if (source_widget == widget)
-       {
-         /* Default to MOVE, unless the user has
-          * pressed ctrl or alt to affect available actions
-          */
-         if ((context->actions & GDK_ACTION_MOVE) != 0)
-           suggested_action = GDK_ACTION_MOVE;
-       }
+      source_widget = gtk_drag_get_source_widget (context);
+      suggested_action = context->suggested_action;
+
+      if (!gtk_editable_get_selection_bounds (GTK_EDITABLE (entry), &sel1, &sel2) ||
+          new_position < sel1 || new_position > sel2)
+        {
+          if (source_widget == widget)
+           {
+             /* Default to MOVE, unless the user has
+              * pressed ctrl or alt to affect available actions
+              */
+             if ((context->actions & GDK_ACTION_MOVE) != 0)
+               suggested_action = GDK_ACTION_MOVE;
+           }
+              
+          entry->dnd_position = new_position;
+        }
+      else
+        {
+          if (source_widget == widget)
+           suggested_action = 0;       /* Can't drop in selection where drag started */
           
-      entry->dnd_position = new_position;
+          entry->dnd_position = -1;
+        }
     }
   else
     {
-      if (source_widget == widget)
-       suggested_action = 0;   /* Can't drop in selection where drag started */
-      
+      /* Entry not editable, or no text */
+      suggested_action = 0;
       entry->dnd_position = -1;
     }
-
+  
   gdk_drag_status (context, suggested_action, time);
   
   if (entry->dnd_position != old_position)
@@ -3372,16 +4142,13 @@ gtk_entry_drag_data_received (GtkWidget        *widget,
                              guint             info,
                              guint             time)
 {
-  GtkEntry *entry;
-  GtkEditable *editable;
+  GtkEntry *entry = GTK_ENTRY (widget);
+  GtkEditable *editable = GTK_EDITABLE (widget);
   gchar *str;
 
-  entry = GTK_ENTRY (widget);
-  editable = GTK_EDITABLE (widget);
-
   str = gtk_selection_data_get_text (selection_data);
 
-  if (str)
+  if (str && entry->editable)
     {
       gint new_position;
       gint sel1, sel2;
@@ -3401,6 +4168,12 @@ gtk_entry_drag_data_received (GtkWidget        *widget,
        }
       
       g_free (str);
+      gtk_drag_finish (context, TRUE, context->action == GDK_ACTION_MOVE, time);
+    }
+  else
+    {
+      /* Drag and drop didn't happen! */
+      gtk_drag_finish (context, FALSE, FALSE, time);
     }
 }
 
@@ -3417,9 +4190,9 @@ gtk_entry_drag_data_get (GtkWidget        *widget,
   
   if (gtk_editable_get_selection_bounds (editable, &sel_start, &sel_end))
     {
-      gchar *str = gtk_editable_get_chars (editable, sel_start, sel_end);
+      gchar *str = gtk_entry_get_public_chars (GTK_ENTRY (widget), sel_start, sel_end);
 
-      gtk_selection_data_set_text (selection_data, str);
+      gtk_selection_data_set_text (selection_data, str, -1);
       
       g_free (str);
     }
@@ -3434,6 +4207,152 @@ gtk_entry_drag_data_delete (GtkWidget      *widget,
 
   GtkEditable *editable = GTK_EDITABLE (widget);
   
-  if (gtk_editable_get_selection_bounds (editable, &sel_start, &sel_end))
+  if (GTK_ENTRY (widget)->editable &&
+      gtk_editable_get_selection_bounds (editable, &sel_start, &sel_end))
     gtk_editable_delete_text (editable, sel_start, sel_end);
 }
+
+/* We display the cursor when
+ *
+ *  - the selection is empty, AND
+ *  - the widget has focus
+ */
+
+#define CURSOR_ON_MULTIPLIER 0.66
+#define CURSOR_OFF_MULTIPLIER 0.34
+#define CURSOR_PEND_MULTIPLIER 1.0
+
+static gboolean
+cursor_blinks (GtkEntry *entry)
+{
+  GtkSettings *settings = gtk_widget_get_settings (GTK_WIDGET (entry));
+  gboolean blink;
+
+  if (GTK_WIDGET_HAS_FOCUS (entry) &&
+      entry->selection_bound == entry->current_pos)
+    {
+      g_object_get (G_OBJECT (settings), "gtk-cursor-blink", &blink, NULL);
+      return blink;
+    }
+  else
+    return FALSE;
+}
+
+static gint
+get_cursor_time (GtkEntry *entry)
+{
+  GtkSettings *settings = gtk_widget_get_settings (GTK_WIDGET (entry));
+  gint time;
+
+  g_object_get (G_OBJECT (settings), "gtk-cursor-blink-time", &time, NULL);
+
+  return time;
+}
+
+static void
+show_cursor (GtkEntry *entry)
+{
+  if (!entry->cursor_visible)
+    {
+      entry->cursor_visible = TRUE;
+
+      if (GTK_WIDGET_HAS_FOCUS (entry) && entry->selection_bound == entry->current_pos)
+       gtk_widget_queue_draw (GTK_WIDGET (entry));
+    }
+}
+
+static void
+hide_cursor (GtkEntry *entry)
+{
+  if (entry->cursor_visible)
+    {
+      entry->cursor_visible = FALSE;
+
+      if (GTK_WIDGET_HAS_FOCUS (entry) && entry->selection_bound == entry->current_pos)
+       gtk_widget_queue_draw (GTK_WIDGET (entry));
+    }
+}
+
+/*
+ * Blink!
+ */
+static gint
+blink_cb (gpointer data)
+{
+  GtkEntry *entry;
+
+  GDK_THREADS_ENTER ();
+
+  entry = GTK_ENTRY (data);
+
+  if (!GTK_WIDGET_HAS_FOCUS (entry))
+    {
+      g_warning ("GtkEntry - did not receive focus-out-event. If you\n"
+                "connect a handler to this signal, it must return\n"
+                "FALSE so the entry gets the event as well");
+    }
+  
+  g_assert (GTK_WIDGET_HAS_FOCUS (entry));
+  g_assert (entry->selection_bound == entry->current_pos);
+
+  if (entry->cursor_visible)
+    {
+      hide_cursor (entry);
+      entry->blink_timeout = gtk_timeout_add (get_cursor_time (entry) * CURSOR_OFF_MULTIPLIER,
+                                             blink_cb,
+                                             entry);
+    }
+  else
+    {
+      show_cursor (entry);
+      entry->blink_timeout = gtk_timeout_add (get_cursor_time (entry) * CURSOR_ON_MULTIPLIER,
+                                             blink_cb,
+                                             entry);
+    }
+
+  GDK_THREADS_LEAVE ();
+
+  /* Remove ourselves */
+  return FALSE;
+}
+
+static void
+gtk_entry_check_cursor_blink (GtkEntry *entry)
+{
+  if (cursor_blinks (entry))
+    {
+      if (!entry->blink_timeout)
+       {
+         entry->blink_timeout = gtk_timeout_add (get_cursor_time (entry) * CURSOR_ON_MULTIPLIER,
+                                                 blink_cb,
+                                                 entry);
+         show_cursor (entry);
+       }
+    }
+  else
+    {
+      if (entry->blink_timeout)  
+       { 
+         gtk_timeout_remove (entry->blink_timeout);
+         entry->blink_timeout = 0;
+       }
+      
+      entry->cursor_visible = TRUE;
+    }
+  
+}
+
+static void
+gtk_entry_pend_cursor_blink (GtkEntry *entry)
+{
+  if (cursor_blinks (entry))
+    {
+      if (entry->blink_timeout != 0)
+       gtk_timeout_remove (entry->blink_timeout);
+      
+      entry->blink_timeout = gtk_timeout_add (get_cursor_time (entry) * CURSOR_PEND_MULTIPLIER,
+                                             blink_cb,
+                                             entry);
+      show_cursor (entry);
+    }
+}